Re: [systemd-devel] [PATCH 2/2] macro: allow assert_se() assertions to also be optimized out when NDEBUG is set

2015-03-31 Thread Djalal Harouni
Hi Shawn, On Tue, Mar 31, 2015 at 04:59:29PM -0700, Shawn Landden wrote: > On Tue, Mar 31, 2015 at 2:40 PM, Djalal Harouni wrote: > > On Tue, Mar 31, 2015 at 11:10:34AM -0700, Shawn Landden wrote: [...] > >> The point is that assert() and assert_se() should only be used for > >> programming error

Re: [systemd-devel] [PATCH 2/2] macro: allow assert_se() assertions to also be optimized out when NDEBUG is set

2015-03-31 Thread Shawn Landden
On Tue, Mar 31, 2015 at 2:40 PM, Djalal Harouni wrote: > On Tue, Mar 31, 2015 at 11:10:34AM -0700, Shawn Landden wrote: >> On Tue, Mar 31, 2015 at 8:38 AM, Djalal Harouni wrote: >> > On Mon, Mar 30, 2015 at 07:32:35PM -0700, Shawn Landden wrote: >> >> On Mon, Mar 30, 2015 at 5:04 PM, Djalal Harou

Re: [systemd-devel] [PATCH 2/2] macro: allow assert_se() assertions to also be optimized out when NDEBUG is set

2015-03-31 Thread Djalal Harouni
On Tue, Mar 31, 2015 at 11:10:34AM -0700, Shawn Landden wrote: > On Tue, Mar 31, 2015 at 8:38 AM, Djalal Harouni wrote: > > On Mon, Mar 30, 2015 at 07:32:35PM -0700, Shawn Landden wrote: > >> On Mon, Mar 30, 2015 at 5:04 PM, Djalal Harouni wrote: > >> > On Fri, Mar 27, 2015 at 09:51:26AM -0700, S

[systemd-devel] [PATCH] systemctl: clean up output a little bit

2015-03-31 Thread Shawn Landden
--- src/systemctl/systemctl.c | 51 +++ 1 file changed, 51 insertions(+) diff --git a/src/systemctl/systemctl.c b/src/systemctl/systemctl.c index 3158a38..bf279f9 100644 --- a/src/systemctl/systemctl.c +++ b/src/systemctl/systemctl.c @@ -4133,6 +4133,57

Re: [systemd-devel] Providing DNS for DHCPServer configuration

2015-03-31 Thread Ash Charles
On Fri, Mar 27, 2015 at 5:33 AM, Tom Gundersen wrote: > That has the restriction that any DNS server you want to pass on to > the client must also be a valid DNS server on the server. Which I > think is fine. > > Makes sense? Hi Tom, Definitely. If this is a useful feature, I'm happy to try to g

Re: [systemd-devel] [PATCH 2/2] macro: allow assert_se() assertions to also be optimized out when NDEBUG is set

2015-03-31 Thread Shawn Landden
On Tue, Mar 31, 2015 at 8:38 AM, Djalal Harouni wrote: > On Mon, Mar 30, 2015 at 07:32:35PM -0700, Shawn Landden wrote: >> On Mon, Mar 30, 2015 at 5:04 PM, Djalal Harouni wrote: >> > On Fri, Mar 27, 2015 at 09:51:26AM -0700, Shawn Landden wrote: >> >> On Fri, Mar 27, 2015 at 8:16 AM, Tom Gunderse

Re: [systemd-devel] [PATCH] macro: allow assert_se() assertions to also be optimized when NDEBUG is set

2015-03-31 Thread Shawn Landden
On Mon, Mar 30, 2015 at 8:24 PM, Shawn Landden wrote: > replaces log with abort() to remove strings. > > saves 3kB from text section of systemd. and 7kB from rodata. The saving in text is probably because abort() is no_return. > --- > src/shared/macro.h | 16 ++-- > 1 file changed, 10

Re: [systemd-devel] Drop systemd-ui

2015-03-31 Thread Lennart Poettering
On Tue, 31.03.15 11:01, Shawn Landden (shawnland...@gmail.com) wrote: > On Tue, Mar 31, 2015 at 10:35 AM, Lennart Poettering > wrote: > > On Mon, 30.03.15 19:30, Shawn Landden (shawnland...@gmail.com) wrote: > > > >> > What do you feel is missing from systemctl show? > >> > >> It is only suppose

Re: [systemd-devel] [PATCH 2/2] macro: allow assert_se() assertions to also be optimized out when NDEBUG is set

2015-03-31 Thread Shawn Landden
On Tue, Mar 31, 2015 at 8:38 AM, Djalal Harouni wrote: > On Mon, Mar 30, 2015 at 07:32:35PM -0700, Shawn Landden wrote: >> On Mon, Mar 30, 2015 at 5:04 PM, Djalal Harouni wrote: >> > On Fri, Mar 27, 2015 at 09:51:26AM -0700, Shawn Landden wrote: >> >> On Fri, Mar 27, 2015 at 8:16 AM, Tom Gunderse

Re: [systemd-devel] Drop systemd-ui

2015-03-31 Thread Shawn Landden
On Tue, Mar 31, 2015 at 10:35 AM, Lennart Poettering wrote: > On Mon, 30.03.15 19:30, Shawn Landden (shawnland...@gmail.com) wrote: > >> > What do you feel is missing from systemctl show? >> >> It is only suppose to show fields that have been changed by humans >> (even the developer) not systemd d

Re: [systemd-devel] Drop systemd-ui

2015-03-31 Thread Shawn Landden
On Tue, Mar 31, 2015 at 7:19 AM, Dimitri John Ledkov wrote: > On 31 March 2015 at 15:08, Shawn Landden wrote: >> On Tue, Mar 31, 2015 at 12:31 AM, "Jóhann B. Guðmundsson" >> wrote: >>> >>> >>> On 03/31/2015 02:30 AM, Shawn Landden wrote: On Mon, Mar 30, 2015 at 4:02 PM, "Jóhann B. Guðm

Re: [systemd-devel] Drop systemd-ui

2015-03-31 Thread Lennart Poettering
On Mon, 30.03.15 19:30, Shawn Landden (shawnland...@gmail.com) wrote: > > What do you feel is missing from systemctl show? > > It is only suppose to show fields that have been changed by humans > (even the developer) not systemd defaults. Hmm? It supresses "empty" fields by default, unless you

Re: [systemd-devel] Drop systemd-ui

2015-03-31 Thread Lennart Poettering
On Mon, 30.03.15 15:32, Shawn Landden (shawnland...@gmail.com) wrote: > On Mon, Mar 30, 2015 at 1:35 PM, "Jóhann B. Guðmundsson" > wrote: > > Heyja > > > > Should this not be dropped and *DE write,integrate/implement an graphical > > frontend to systemd for themselves? > > > > It's not like this

Re: [systemd-devel] Drop systemd-ui

2015-03-31 Thread Lennart Poettering
On Mon, 30.03.15 20:35, Jóhann B. Guðmundsson (johan...@gmail.com) wrote: > Heyja > > Should this not be dropped and *DE write,integrate/implement an graphical > frontend to systemd for themselves? > > It's not like this is receiving the love it needs, hence I'm pretty sure > nobody is using thi

Re: [systemd-devel] [PATCH] [PATCH v3] nspawn: fallback on bind mount when mknod fails

2015-03-31 Thread Dave Reisner
On Tue, Mar 31, 2015 at 07:14:26PM +0200, Lennart Poettering wrote: > On Tue, 31.03.15 11:35, Dave Reisner (d...@falconindy.com) wrote: > > > > +/* Some systems abusively restrict mknod > > > but > > > + * allow bind mounts. */ > > >

Re: [systemd-devel] [PATCH] mount: don't run quotaon only for network filesystems

2015-03-31 Thread Lennart Poettering
On Mon, 30.03.15 14:42, Lukas Nykryn (lnyk...@redhat.com) wrote: > If you havei for example ext4 on iscsi devices it is possible to setup > qoutas there. Unfortunatelly because such fstab entry contains _netdev, > systemd will not add dependency to quotaon.service. I think this really needs a com

Re: [systemd-devel] [PATCH] systemctl: list-units -r should not fail with older systemd in container

2015-03-31 Thread Lennart Poettering
On Tue, 31.03.15 16:10, Lukas Nykryn (lnyk...@redhat.com) wrote: > Older version of systemd does not have d-bus method "ListUnitsFiltered", > so systemctl -r will fail just with: I think I'd really prefer if we'd simply fall back to ListUnits() in this case, and do the filtering client side only.

Re: [systemd-devel] [PATCH] bus-util: be more verbose if bus job failed because of start limit

2015-03-31 Thread Lennart Poettering
On Tue, 31.03.15 17:10, Michal Sekletar (msekl...@redhat.com) wrote: > Users might have hard time figuring out that they need to call systemctl > reset-failed, before they are allowed to start the service again, after > service > ended up in failed state because start job rate limiting. Let's be

Re: [systemd-devel] [PATCH] [PATCH v3] nspawn: fallback on bind mount when mknod fails

2015-03-31 Thread Lennart Poettering
On Tue, 31.03.15 11:35, Dave Reisner (d...@falconindy.com) wrote: > > +/* Some systems abusively restrict mknod > > but > > + * allow bind mounts. */ > > +r = touch(to); > > +

Re: [systemd-devel] [PATCH] python-systemd: fix is_socket_inet to cope with ports

2015-03-31 Thread Simon Farnsworth
On Tuesday 31 March 2015 13:53:38 Zbigniew Jędrzejewski-Szmek wrote: > On Tue, Mar 31, 2015 at 09:46:40AM +0100, Simon Farnsworth wrote: > > Hello, > > > > We've got the Easter long weekend coming up here in the UK, and I intend to > > spend it away from the computer. Is there anything I need to f

Re: [systemd-devel] [PATCH] [PATCH v3] nspawn: fallback on bind mount when mknod fails

2015-03-31 Thread Alban Crequy
On Tue, Mar 31, 2015 at 5:35 PM, Dave Reisner wrote: > On Tue, Mar 31, 2015 at 05:14:48PM +0200, Alban Crequy wrote: >> From: Alban Crequy >> >> Some systems abusively restrict mknod, even when the device node already >> exists in /dev. This is unfortunate because it prevents systemd-nspawn >> fr

Re: [systemd-devel] Drop systemd-ui

2015-03-31 Thread Jóhann B. Guðmundsson
On 03/31/2015 02:30 PM, Michael Laß wrote: Am Montag, den 30.03.2015, 20:35 + schrieb "Jóhann B. Guðmundsson": It's not like this is receiving the love it needs, hence I'm pretty sure nobody is using this. Is there a replacement for systemd-gnome-ask-password-agent in any desktop suite? I

Re: [systemd-devel] [PATCH 2/2] macro: allow assert_se() assertions to also be optimized out when NDEBUG is set

2015-03-31 Thread Djalal Harouni
On Mon, Mar 30, 2015 at 07:32:35PM -0700, Shawn Landden wrote: > On Mon, Mar 30, 2015 at 5:04 PM, Djalal Harouni wrote: > > On Fri, Mar 27, 2015 at 09:51:26AM -0700, Shawn Landden wrote: > >> On Fri, Mar 27, 2015 at 8:16 AM, Tom Gundersen wrote: > > [...] > >> >> * Current expression may modify/i

Re: [systemd-devel] [PATCH] [PATCH v3] nspawn: fallback on bind mount when mknod fails

2015-03-31 Thread Dave Reisner
On Tue, Mar 31, 2015 at 05:14:48PM +0200, Alban Crequy wrote: > From: Alban Crequy > > Some systems abusively restrict mknod, even when the device node already > exists in /dev. This is unfortunate because it prevents systemd-nspawn > from creating the basic devices in /dev in the container. > >

Re: [systemd-devel] [PATCH] [PATCH v3] nspawn: fallback on bind mount when mknod fails

2015-03-31 Thread Lennart Poettering
On Tue, 31.03.15 17:14, Alban Crequy (alban.cre...@gmail.com) wrote: > From: Alban Crequy > > Some systems abusively restrict mknod, even when the device node already > exists in /dev. This is unfortunate because it prevents systemd-nspawn > from creating the basic devices in /dev in the contain

Re: [systemd-devel] Drop systemd-ui

2015-03-31 Thread Jóhann B. Guðmundsson
On 03/31/2015 02:58 PM, Michael Biebl wrote: When I made the final ConsoleKit release, I added a NEWS entry, saying that this software was discontinued and pointing to the replacements. http://cgit.freedesktop.org/ConsoleKit/commit/?id=af75e100dc4d4fac2e1633aa134e40e390d38918 We could do some

[systemd-devel] [PATCH] [PATCH v3] nspawn: fallback on bind mount when mknod fails

2015-03-31 Thread Alban Crequy
From: Alban Crequy Some systems abusively restrict mknod, even when the device node already exists in /dev. This is unfortunate because it prevents systemd-nspawn from creating the basic devices in /dev in the container. This patch implements a workaround: when mknod fails, fallback on bind moun

[systemd-devel] [PATCH] bus-util: be more verbose if bus job failed because of start limit

2015-03-31 Thread Michal Sekletar
Users might have hard time figuring out that they need to call systemctl reset-failed, before they are allowed to start the service again, after service ended up in failed state because start job rate limiting. Let's be nice and print better error message. https://bugzilla.redhat.com/show_bug.cgi?

Re: [systemd-devel] Drop systemd-ui

2015-03-31 Thread Michael Biebl
When I made the final ConsoleKit release, I added a NEWS entry, saying that this software was discontinued and pointing to the replacements. http://cgit.freedesktop.org/ConsoleKit/commit/?id=af75e100dc4d4fac2e1633aa134e40e390d38918 We could do something similar for systemd-ui. That said, I think

Re: [systemd-devel] [PATCH] [PATCH v2] nspawn: fallback on bind mount when mknod fails

2015-03-31 Thread Lennart Poettering
On Tue, 31.03.15 16:51, Alban Crequy (alban.cre...@gmail.com) wrote: > -if (mknod(to, st.st_mode, st.st_rdev) < 0) > -return log_error_errno(errno, "mknod(%s) > failed: %m", to); > +if (mknod(to, st.st_mode, st.st_rde

[systemd-devel] [PATCH] [PATCH v2] nspawn: fallback on bind mount when mknod fails

2015-03-31 Thread Alban Crequy
From: Alban Crequy Some systems abusively restrict mknod, even when the device node already exists in /dev. This is unfortunate because it prevents systemd-nspawn from creating the basic devices in /dev in the container. This patch implements a workaround: when mknod fails, fallback on bind moun

Re: [systemd-devel] Drop systemd-ui

2015-03-31 Thread Jóhann B. Guðmundsson
On 03/31/2015 02:27 PM, Michael Biebl wrote: >And from the looks of it the Red Hat desktop team maintainers in Gnome seem >to be expecting the Gnome users to be using Red Hat's own product cockpit to >take care of that. sorry, but that's not a real replacement for systemadm. Don't want to run

Re: [systemd-devel] Drop systemd-ui

2015-03-31 Thread Michael Laß
Am Montag, den 30.03.2015, 20:35 + schrieb "Jóhann B. Guðmundsson": > It's not like this is receiving the love it needs, hence I'm pretty sure > nobody is using this. Is there a replacement for systemd-gnome-ask-password-agent in any desktop suite? I know at least one person using that peace

Re: [systemd-devel] Drop systemd-ui

2015-03-31 Thread Michael Biebl
2015-03-31 16:20 GMT+02:00 "Jóhann B. Guðmundsson" : > > > On 03/31/2015 02:09 PM, Michael Biebl wrote: >> >> 2015-03-31 15:47 GMT+02:00 Zbigniew Jędrzejewski-Szmek >> : >>> >>> On Tue, Mar 31, 2015 at 07:31:31AM +, "Jóhann B. Guðmundsson" wrote: What I'm proposing is that we dropped

Re: [systemd-devel] Drop systemd-ui

2015-03-31 Thread Dimitri John Ledkov
On 31 March 2015 at 15:08, Shawn Landden wrote: > On Tue, Mar 31, 2015 at 12:31 AM, "Jóhann B. Guðmundsson" > wrote: >> >> >> On 03/31/2015 02:30 AM, Shawn Landden wrote: >>> >>> On Mon, Mar 30, 2015 at 4:02 PM, "Jóhann B. Guðmundsson" >>> wrote: > > >On 03/30/2015 10:32 PM,

Re: [systemd-devel] Drop systemd-ui

2015-03-31 Thread Jóhann B. Guðmundsson
On 03/31/2015 02:09 PM, Michael Biebl wrote: 2015-03-31 15:47 GMT+02:00 Zbigniew Jędrzejewski-Szmek : On Tue, Mar 31, 2015 at 07:31:31AM +, "Jóhann B. Guðmundsson" wrote: What I'm proposing is that we dropped that proof of concept since it's not being maintained, there exist better altern

Re: [systemd-devel] Drop systemd-ui

2015-03-31 Thread Jóhann B. Guðmundsson
On 03/31/2015 01:47 PM, Zbigniew Jędrzejewski-Szmek wrote: On Tue, Mar 31, 2015 at 07:31:31AM +, "Jóhann B. Guðmundsson" wrote: >What I'm proposing is that we dropped that proof of concept since >it's not being maintained, there exist better alternatives thus it's >intended purpose has bee

[systemd-devel] [PATCH] systemctl: list-units -r should not fail with older systemd in container

2015-03-31 Thread Lukas Nykryn
Older version of systemd does not have d-bus method "ListUnitsFiltered", so systemctl -r will fail just with: Failed to list units: Method "ListUnitsFiltered" with signature "as" on interface "org.freedesktop.systemd1.Manager" doesn't exist So lets skip such machines. --- src/systemctl/systemctl

Re: [systemd-devel] Drop systemd-ui

2015-03-31 Thread Michael Biebl
2015-03-31 15:47 GMT+02:00 Zbigniew Jędrzejewski-Szmek : > On Tue, Mar 31, 2015 at 07:31:31AM +, "Jóhann B. Guðmundsson" wrote: >> What I'm proposing is that we dropped that proof of concept since >> it's not being maintained, there exist better alternatives thus it's >> intended purpose has be

Re: [systemd-devel] Drop systemd-ui

2015-03-31 Thread Shawn Landden
On Tue, Mar 31, 2015 at 12:31 AM, "Jóhann B. Guðmundsson" wrote: > > > On 03/31/2015 02:30 AM, Shawn Landden wrote: >> >> On Mon, Mar 30, 2015 at 4:02 PM, "Jóhann B. Guðmundsson" >> wrote: >>> >>> > >>> > >>> >On 03/30/2015 10:32 PM, Shawn Landden wrote: >> >>On Mon, Mar 30, 2015

Re: [systemd-devel] [PATCH] python-systemd: fix is_socket_inet to cope with ports

2015-03-31 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Mar 31, 2015 at 09:46:40AM +0100, Simon Farnsworth wrote: > Hello, > > We've got the Easter long weekend coming up here in the UK, and I intend to > spend it away from the computer. Is there anything I need to fix with this > patch to make it acceptable to you? No, the patch is fine afaik.

Re: [systemd-devel] Drop systemd-ui

2015-03-31 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Mar 31, 2015 at 07:31:31AM +, "Jóhann B. Guðmundsson" wrote: > What I'm proposing is that we dropped that proof of concept since > it's not being maintained, there exist better alternatives thus it's > intended purpose has been fulfilled already. Agreed that it doesn't make sense to hav

Re: [systemd-devel] [PATCH v2 0/3] [RFT] ARM: detect-virt: detect Xen and QEMU/KVM

2015-03-31 Thread Lennart Poettering
On Tue, 31.03.15 11:08, Andrew Jones (drjo...@redhat.com) wrote: Thanks! Applied all three! > This series adds support for detecting if an arm or aarch64 > deployment is a Xen or QEMU/KVM guest. I've tested the QEMU/KVM > detection on an AArch64 guest. The Xen detection has *not* been > tested, t

Re: [systemd-devel] [PATCH] change filesystemtype from "bind" to NULL in mount syscalls

2015-03-31 Thread Lennart Poettering
On Tue, 31.03.15 11:50, Iago López Galeiras (i...@endocode.com) wrote: > Try to keep syscalls as minimal as possible. Thanks! Applied! > --- > src/core/namespace.c | 2 +- > src/nspawn/nspawn.c | 16 > 2 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/src/cor

[systemd-devel] [PATCH] change filesystemtype from "bind" to NULL in mount syscalls

2015-03-31 Thread Iago López Galeiras
Try to keep syscalls as minimal as possible. --- src/core/namespace.c | 2 +- src/nspawn/nspawn.c | 16 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/core/namespace.c b/src/core/namespace.c index f8a2bbc..718da23 100644 --- a/src/core/namespace.c +++ b/src/c

[systemd-devel] [PATCH v2 3/3] ARM: detect-virt: detect QEMU/KVM

2015-03-31 Thread Andrew Jones
QEMU/KVM guests do not have hypervisor nodes, but they do have fw-cfg nodes (since qemu v2.3.0-rc0). fw-cfg nodes are documented, see kernel doc Documentation/devicetree/bindings/arm/fw-cfg.txt, and therefore we should be able to rely on it in this detection. Unfortunately, we currently don't have

[systemd-devel] [PATCH v2 0/3] [RFT] ARM: detect-virt: detect Xen and QEMU/KVM

2015-03-31 Thread Andrew Jones
This series adds support for detecting if an arm or aarch64 deployment is a Xen or QEMU/KVM guest. I've tested the QEMU/KVM detection on an AArch64 guest. The Xen detection has *not* been tested, thus the RFT. Also note that testing was not done with this exact series, but rather a backport to an o

[systemd-devel] [PATCH v2 1/3] detect-virt: use /proc/device-tree

2015-03-31 Thread Andrew Jones
Kernel doc Documentation/ABI/testing/sysfs-firmware-ofw says that the /proc/device-tree symlink should be used, as opposed to directly accessing /sys/firmware/devicetree/base. The former is ABI, but not the later. --- src/shared/virt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

[systemd-devel] [PATCH v2 2/3] ARM: detect-virt: detect Xen

2015-03-31 Thread Andrew Jones
--- src/shared/virt.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/shared/virt.c b/src/shared/virt.c index aa3501f42916c..712523210d720 100644 --- a/src/shared/virt.c +++ b/src/shared/virt.c @@ -102,7 +102,7 @@ static int detect_vm_cpuid(const char **_id) { } sta

Re: [systemd-devel] [PATCH 3/3] ARM: detect-virt: detect QEMU/KVM

2015-03-31 Thread Andrew Jones
On Tue, Mar 31, 2015 at 09:18:08AM +0200, Lennart Poettering wrote: > On Mon, 30.03.15 21:15, Andrew Jones (drjo...@redhat.com) wrote: > > > QEMU/KVM guests do not have hypervisor nodes, but they do have > > fw-cfg nodes (since qemu v2.3.0-rc0). fw-cfg nodes are documented, > > see kernel doc Docu

Re: [systemd-devel] [PATCH] python-systemd: fix is_socket_inet to cope with ports

2015-03-31 Thread Simon Farnsworth
Hello, We've got the Easter long weekend coming up here in the UK, and I intend to spend it away from the computer. Is there anything I need to fix with this patch to make it acceptable to you? On Wednesday 25 March 2015 17:00:09 Simon Farnsworth wrote: > Just a couple of trivial oversights. > --

Re: [systemd-devel] Drop systemd-ui

2015-03-31 Thread Jóhann B. Guðmundsson
On 03/31/2015 02:30 AM, Shawn Landden wrote: On Mon, Mar 30, 2015 at 4:02 PM, "Jóhann B. Guðmundsson" wrote: > > >On 03/30/2015 10:32 PM, Shawn Landden wrote: >> >>On Mon, Mar 30, 2015 at 1:35 PM, "Jóhann B. Guðmundsson" >> wrote: >>> >>>Heyja >>> >>>Should this not be dropped and *DE wri

Re: [systemd-devel] [PATCH 3/3] ARM: detect-virt: detect QEMU/KVM

2015-03-31 Thread Lennart Poettering
On Mon, 30.03.15 21:15, Andrew Jones (drjo...@redhat.com) wrote: > QEMU/KVM guests do not have hypervisor nodes, but they do have > fw-cfg nodes (since qemu v2.3.0-rc0). fw-cfg nodes are documented, > see kernel doc Documentation/devicetree/bindings/arm/fw-cfg.txt, > and therefore we should be abl