Re: patch: fix top

On Thu, Nov 05, 2015 at 10:42:54AM +0100, Marc Espie wrote: > - if (pledge("stdio rpath getpw tty id ps vminfo", NULL) == -1) > + if (pledge("stdio rpath getpw tty proc id ps vminfo", NULL) == -1) > err(1, "pledge"); I think both "proc" and "id" are too much: "id" was added

patch: fix top

either that, or we have to remove (and undocument) the 'k' command. Personally, I find it incredibly useful Index: top.c === RCS file: /data/openbsd/cvs/src/usr.bin/top/top.c,v retrieving revision 1.87 diff -u -p -r1.87 top.c ---

Re: [patch] cvs: retire xfree()

Applied, thanks. I don't know why cvs and rcs xmalloc.c has ended up so different. On Thu, Nov 05, 2015 at 11:50:51AM +0800, Michael W. Bombardieri wrote: > Hi tech@, > > Function xfree() was previously removed from rcs, so drop it from > opencvs too... > >

Re: [patch] tail(1) follow multiple files

On 5 November 2015 at 00:29, Martijn van Duren wrote: > > I got somewhat annoyed by the fact that OpenBSD's tail can't follow multiple > files and since the last attempt at it was from 2008 I thought I'd give it a > shot. Thank you for sharing this, hope it gets accepted.

tls_init.3 add small info

Hi, I'm playing around with client-side certificates[1] and saw that the manpage of tls_init.3 recommend to uses the functions: tls_config_set_ca_{file,path,mem} only in client context. But to check client-side certificates its also useful in server context. bye, Jan [1]:

Re: mpe(4) and rt_ifp

On Thu, Nov 05, 2015 at 11:59:45AM +0100, Martin Pieuchot wrote: > Stop using rt_ifp in mpe(4), ok? Looks good untested but just move on. OK claudio > Index: net/if_mpe.c > === > RCS file: /cvs/src/sys/net/if_mpe.c,v > retrieving

Re: patch: fix top

On Thu, Nov 05, 2015 at 11:33:56AM +0100, Marc Espie wrote: > On Thu, Nov 05, 2015 at 10:54:32AM +0100, Theo Buehler wrote: > > On Thu, Nov 05, 2015 at 10:42:54AM +0100, Marc Espie wrote: > > > - if (pledge("stdio rpath getpw tty id ps vminfo", NULL) == -1) > > > + if (pledge("stdio rpath getpw

nd6_nud_hint and rt_ifp

Change nd6_nud_hint() to no longer use rt_ifp directly. While here remove unused argument and convert the route check to rtisvalid(9). ok? Index: netinet/tcp_input.c === RCS file: /cvs/src/sys/netinet/tcp_input.c,v retrieving

mpe(4) and rt_ifp

Stop using rt_ifp in mpe(4), ok? Index: net/if_mpe.c === RCS file: /cvs/src/sys/net/if_mpe.c,v retrieving revision 1.49 diff -u -p -r1.49 if_mpe.c --- net/if_mpe.c22 Oct 2015 17:48:34 - 1.49 +++ net/if_mpe.c5

Re: Possible em(4) fix

> From: Alexis VACHETTE > Date: Thu, 5 Nov 2015 10:24:27 +0100 > > Hi Mark, > > If you need a box for testing purpose on this issue. > > I can provide you bug reports when I will get a spare box which trigger > the watchdog timeout. Time is the scarce resource here.

Re: patch: fix top

On Thu, Nov 05, 2015 at 10:54:32AM +0100, Theo Buehler wrote: > On Thu, Nov 05, 2015 at 10:42:54AM +0100, Marc Espie wrote: > > - if (pledge("stdio rpath getpw tty id ps vminfo", NULL) == -1) > > + if (pledge("stdio rpath getpw tty proc id ps vminfo", NULL) == -1) > > err(1,

Re: [patch] tcpdump gre sre segfault

Stuart Henderson writes: > On 2015/11/03 20:04, Kevin Reay wrote: >> Fix a segfault in the GRE printer when a GRE packet SRE length >> extends past the actual captured length (but not the packet's >> original length). > > That's OK with me.. Committed, thanks Kevin. >>

Re: [patch] tcpdump print-tcp printf format tweaks

Kevin Reay writes: >> > Attempted to match printf formating of unsigned 32bits to rest of >> > file. >> >> I don't think this is the good direction. "seq" and "length" are 32bits >> integers. Why cast them to long, and then print them as unsigned long? >> Let's

Re: chgrp(1) & chown(8): mark -h and -R as mutually exclusive

I don't think it makes it clearer; it makes it more confusing. The usage messages of programs are not a sufficent grammer to exactly describe what conflicts with what. Taken too far, it would bewilder newcomers. > the command line arguments -h and -R for chgrp and chown are mutually >

Re: patch: fix top

Marc Espie wrote: > On Thu, Nov 05, 2015 at 11:52:32AM +0100, Theo Buehler wrote: > > On Thu, Nov 05, 2015 at 11:33:56AM +0100, Marc Espie wrote: > > > On Thu, Nov 05, 2015 at 10:54:32AM +0100, Theo Buehler wrote: > > > > On Thu, Nov 05, 2015 at 10:42:54AM +0100, Marc Espie wrote: > > > > > -

Re: cvs.1: document annotate command

> On 05 November 2015 at 16:08 Jason McIntyre wrote: > > > On Thu, Nov 05, 2015 at 03:11:38PM +0100, Frederic Nowak wrote: > > Hi there, > > > > it seems the documentation for cvs(1) is missing a few commands: > > annotate, edit, editors, login, logout, pserver, rannotate,

Re: unify xmalloc (was Re: [patch] cvs: retire xfree())

I like this a lot. There are some trivial differences in the various xmalloc.h as well, and I think you could make the style consistent within the files (eg "return i" in xasprintf and xsnprintf). On Thu, Nov 05, 2015 at 03:50:29PM +0100, Tobias Stoeckmann wrote: > On Thu, Nov 05, 2015 at

Re: unify xmalloc (was Re: [patch] cvs: retire xfree())

On Thu, Nov 05, 2015 at 03:57:26PM +, Nicholas Marriott wrote: > I like this a lot. > > There are some trivial differences in the various xmalloc.h as well, and > I think you could make the style consistent within the files (eg "return > i" in xasprintf and xsnprintf). Oh yes, forgot to

Re: ftp.1: "dir |more" example not working as intended

Hi Frederic, Frederic Nowak wrote on Tue, Nov 03, 2015 at 04:59:35PM +0100: > I think the "dir |more" example in ftp.1 is not working as intended. > > ls (and by extension its synonym dir) expects to be called like this: > > ls [remote-directory [local-file]] > > Therefore, "dir |more" would

Re: unbound 1.5.6 update

I have one OK for unbound/nsd, no other feedback. I'd like to commit these updates soon so if anyone has any objections please speak up.

Re: cvs.1: document annotate command

On Thu, Nov 05, 2015 at 04:59:21PM +0100, Frederic Nowak wrote: > > On 05 November 2015 at 16:08 Jason McIntyre wrote: > > > > > > On Thu, Nov 05, 2015 at 03:11:38PM +0100, Frederic Nowak wrote: > > > Hi there, > > > > > > it seems the documentation for cvs(1) is missing a

Re: patch: fix top

On Thu, Nov 05, 2015 at 11:52:34AM -0500, Michael McConville wrote: > > It's not documented so it doesn't exist for me. :P > > > > (hint hint) > > Seconded. Here is an update for some missing syscalls for "stdio", "proc" and "id": Index: lib/libc/sys/pledge.2

chgrp(1) & chown(8): mark -h and -R as mutually exclusive

Hi there, the command line arguments -h and -R for chgrp and chown are mutually exclusive. The patch below changes the markup and the usage strings to make this clearer. Cheers, Frederic Index: bin/chmod/chgrp.1 === RCS file:

Re: [patch] tcpdump print-null AF_LINK segfault

Kevin Reay writes: > Fixes a segfault (in tcpdump.c:default_print) when a printing a raw > packet of family AF_LINK with an unknown ether_type with > MALLOC_OPTIONS=S. The original version would print 4-bytes of d0 and > occasionally segfault. > > With this change,

Re: cvs.1: document annotate command

On Thu, 05 Nov 2015 17:12:28 +, Jason McIntyre wrote: > however it's generated, we don;t have local changes in this file (as far > as i'm aware). if gnu cvs have some doc bugs, you can ping them. if not, > then our doc is out of date. but i doubt anyone will work on updating > this page

Re: patch: fix top

Michael McConville wrote: > > It's not documented so it doesn't exist for me. :P > > > > (hint hint) > > Seconded. I thought thought that this was referring to the undocumented top option. Disregard. :)

less ppp in getty

Sorry, uh, not tested... Index: main.c === RCS file: /cvs/src/libexec/getty/main.c,v retrieving revision 1.38 diff -u -p -r1.38 main.c --- main.c 16 Oct 2015 22:25:50 - 1.38 +++ main.c 5 Nov 2015 22:57:52 - @@

execless wump

here's a nickel kid, get a terminal with scrollback... Index: wump.c === RCS file: /cvs/src/games/wump/wump.c,v retrieving revision 1.26 diff -u -p -r1.26 wump.c --- wump.c 29 Aug 2013 20:22:22 - 1.26 +++ wump.c 5

Re: libc asr _res.nsaddr_list overflow

Looks like I have fogotten to update the name server counter correctly. ok? bluhm Index: lib/libc/asr/res_init.c === RCS file: /data/mirror/openbsd/cvs/src/lib/libc/asr/res_init.c,v retrieving revision 1.7 diff -u -p -U4 -r1.7

Re: less time

ok On Thu, Nov 05, 2015 at 05:45:15PM -0500, Ted Unangst wrote: > time_t is not a long. > > > Index: funcs.h > === > RCS file: /cvs/src/usr.bin/less/funcs.h,v > retrieving revision 1.9 > diff -u -p -r1.9 funcs.h > --- funcs.h 5

Re: unify xmalloc (was Re: [patch] cvs: retire xfree())

Looks good, ok nicm On Thu, Nov 05, 2015 at 05:35:22PM +0100, Tobias Stoeckmann wrote: > On Thu, Nov 05, 2015 at 03:57:26PM +, Nicholas Marriott wrote: > > I like this a lot. > > > > There are some trivial differences in the various xmalloc.h as well, and > > I think you could make the

delete execl from phantasia

Just deleting the option to play again seems easier than figuring out why a loop won't work like any normal program. Just push the up arrow and hit enter if you want to play again. Index: io.c === RCS file:

less: use __progname

Not sure if such changes which diverge from upstream are wanted, but here it is. Index: less.h === RCS file: /cvs/src/usr.bin/less/less.h,v retrieving revision 1.11 diff -u -p -r1.11 less.h --- less.h 5 Nov 2015 22:18:27 -

less time

time_t is not a long. Index: funcs.h === RCS file: /cvs/src/usr.bin/less/funcs.h,v retrieving revision 1.9 diff -u -p -r1.9 funcs.h --- funcs.h 5 Nov 2015 22:08:44 - 1.9 +++ funcs.h 5 Nov 2015 22:44:47 - @@

libc asr _res.nsaddr_list overflow

Hi, I had sendmail crashes because of invalid pointers in _res.dnsrch. I have 4 nameservers in /etc/resolv.conf, the last one is IPv6. /usr/include/resolv.h: #define MAXNS 3 /* max # name servers we'll track */ struct __res_state { ... struct sockaddr_in

Re: remove NLS directory

On Thu, Nov 05, 2015 at 11:12:50PM +0100, Alexander Bluhm wrote: > On Thu, Nov 05, 2015 at 10:49:30PM +0100, Stefan Sperling wrote: > > It sounds like not providing a default path violates POSIX. > > Do we care? Perhaps this detail is not important? > > I think this spec was not written with

Re: libc asr _res.nsaddr_list overflow

On Thu, 05 Nov 2015 23:08:07 +0100, Alexander Bluhm wrote: > Hi, > > I had sendmail crashes because of invalid pointers in _res.dnsrch. > I have 4 nameservers in /etc/resolv.conf, the last one is IPv6. > > /usr/include/resolv.h: > #define MAXNS 3 /* max # name servers

Re: cvs.1: document annotate command

On Thu, Nov 05, 2015 at 11:26:19AM -0700, Todd C. Miller wrote: > On Thu, 05 Nov 2015 17:12:28 +, Jason McIntyre wrote: > > > however it's generated, we don;t have local changes in this file (as far > > as i'm aware). if gnu cvs have some doc bugs, you can ping them. if not, > > then our doc

Re: remove NLS directory

On Thu, Nov 05, 2015 at 04:29:12PM +0100, Alexander Bluhm wrote: > Hi, > > After removing National Language Support (NLS) from base, I think > the directory /usr/share/nls should go. Having a non-existing > default path in catopen(3) does not make sense, so I also removed > that. It sounds like

Re: remove NLS directory

On Thu, Nov 05, 2015 at 10:49:30PM +0100, Stefan Sperling wrote: > It sounds like not providing a default path violates POSIX. > Do we care? Perhaps this detail is not important? I think this spec was not written with implementations without NLS in mind. So I don't care. The kernel has

Re: remove NLS directory

Hi Stefan, Stefan Sperling wrote on Thu, Nov 05, 2015 at 10:49:30PM +0100: > On Thu, Nov 05, 2015 at 04:29:12PM +0100, Alexander Bluhm wrote: >> After removing National Language Support (NLS) from base, I think >> the directory /usr/share/nls should go. Having a non-existing >> default path in

Re: ld.so crash second attempt

On 03/11/15 at 01:46P, Philip Guenther wrote: > On Sun, 25 Oct 2015, Peter Hajdu wrote: > > I try to give it one more attempt with a bit more description about the > > bug. > > > > After calling dlclose in _dl_notify_unload_shlib_ group reference counts > > are decreased by following the

remove NLS directory

Hi, After removing National Language Support (NLS) from base, I think the directory /usr/share/nls should go. Having a non-existing default path in catopen(3) does not make sense, so I also removed that. ok? bluhm Index: etc/mtree/4.4BSD.dist

Re: nd6_nud_hint and rt_ifp

On Thu, Nov 05, 2015 at 11:53:34AM +0100, Martin Pieuchot wrote: > Change nd6_nud_hint() to no longer use rt_ifp directly. While here > remove unused argument and convert the route check to rtisvalid(9). > > ok? OK bluhm@ > > Index: netinet/tcp_input.c >

eou(4) - another operating systems course assignment

the last assignment i set for the operating systems course i was helping with was to write a driver for a virtual network interface that implemented the client side of a protocol i made up. the protocol was largely inspired by vxlan, but requires some negotiation for a client to get a working

Re: eou(4) - another operating systems course assignment

> On 6 Nov 2015, at 15:42, David Gwynne wrote: > > the last assignment i set for the operating systems course i was > helping with was to write a driver for a virtual network interface > that implemented the client side of a protocol i made up. > > the protocol was largely

fix CRYPTO_chacha_20() on BE32 platforms

Running regress/lib/libcrypto/aead fails on big-endian platforms without the following diff, for the ``Test vector from RFC7539 2.8.2'' test, due to 64-bit counters being truncated to size_t. Index: chacha/chacha.c === RCS file:

Re: ld.so crash second attempt

On Thu, Nov 5, 2015 at 1:00 PM, Peter Hajdu wrote: ... > I've tested the patch on amd64 with a simple sdl2 test and with my > original tests on both amd64 and i386. Everything seems to work just > fine. Thank you very much for your effort. And it's now committed.

err(3) trivia

Apparently the programmer didn't know that you could pass it NULL. However, including the function name seems more informative. ok? Index: usr.sbin/netgroup_mkdb/util.c === RCS file: /cvs/src/usr.sbin/netgroup_mkdb/util.c,v

Re: err(3) trivia

Hi Michael, Michael McConville wrote on Thu, Nov 05, 2015 at 09:09:51PM -0500: > Apparently the programmer didn't know that you could pass it NULL. > However, including the function name seems more informative. For malloc failure, including a function name is not necessary because the message

Re: chgrp(1) & chown(8): mark -h and -R as mutually exclusive

> On 05 November 2015 at 18:53 Theo de Raadt > wrote: > > > I don't think it makes it clearer; it makes it more confusing. > > The usage messages of programs are not a sufficent grammer to exactly > describe what conflicts with what. Taken too far, it would bewilder >

Re: patch: fix top

On Thu, Nov 05, 2015 at 06:23:52PM +0100, Theo Buehler wrote: > On Thu, Nov 05, 2015 at 11:52:34AM -0500, Michael McConville wrote: > > > It's not documented so it doesn't exist for me. :P > > > > > > (hint hint) > > > > Seconded. > > Here is an update for some missing syscalls for > "stdio",

unify xmalloc (was Re: [patch] cvs: retire xfree())

On Thu, Nov 05, 2015 at 09:50:48AM +, Nicholas Marriott wrote: > I don't know why cvs and rcs xmalloc.c has ended up so different. It's not just about cvs and rcs: /usr/src/usr.bin/cvs/xmalloc.c /usr/src/usr.bin/diff/xmalloc.c /usr/src/usr.bin/file/xmalloc.c /usr/src/usr.bin/rcs/xmalloc.c

Re: cvs.1: document annotate command

On Thu, Nov 05, 2015 at 03:11:38PM +0100, Frederic Nowak wrote: > Hi there, > > it seems the documentation for cvs(1) is missing a few commands: > annotate, edit, editors, login, logout, pserver, rannotate, rlog, > server, version, watch, watchers, unedit > The patch below adds a description for

Re: Possible em(4) fix

Hi Mark, If you need a box for testing purpose on this issue. I can provide you bug reports when I will get a spare box which trigger the watchdog timeout. In my case it's only with trunk device on failover mode so far. Regards, Alexis VACHETTE* * On 05/10/2015 22:45, Mark Kettenis wrote:

Re: patch: fix top

On Thu, Nov 05, 2015 at 11:52:32AM +0100, Theo Buehler wrote: > On Thu, Nov 05, 2015 at 11:33:56AM +0100, Marc Espie wrote: > > On Thu, Nov 05, 2015 at 10:54:32AM +0100, Theo Buehler wrote: > > > On Thu, Nov 05, 2015 at 10:42:54AM +0100, Marc Espie wrote: > > > > - if (pledge("stdio rpath

cvs.1: document annotate command

Hi there, it seems the documentation for cvs(1) is missing a few commands: annotate, edit, editors, login, logout, pserver, rannotate, rlog, server, version, watch, watchers, unedit The patch below adds a description for annotate. Cheers, Frederic Index: gnu/usr.bin/cvs/man/cvs.1