Re: [macppc 6.7-beta] clang backend error: "adde Constant" issue

2020-04-27 Thread George Koehler
Moving from bugs@ to tech@, because some people might miss a clang diff on bugs@. This diff modifies LLVM's DAGCombiner to skip an optimization if it would make an illegal ISD::ADDE node. This fixes fatal errors from powerpc clang when building ports net/libtorrent-rasterbar and

Re: vi: add expandtab option

2020-04-27 Thread David Gwynne
> On 28 Apr 2020, at 13:31, Todd C. Miller wrote: > > On Thu, 02 Apr 2020 16:21:47 -0600, "Todd C. Miller" wrote: > >> In vim, the expandtab option expands tabs to spaces in insert mode >> as well as when shifting and indenting/outdenting. This is very >> useful when working on a code-base

Re: vi: add expandtab option

2020-04-27 Thread Todd C . Miller
On Thu, 02 Apr 2020 16:21:47 -0600, "Todd C. Miller" wrote: > In vim, the expandtab option expands tabs to spaces in insert mode > as well as when shifting and indenting/outdenting. This is very > useful when working on a code-base where the style dictates using > spaces instead of tabs for

Re: iked(8): remove insecure EC2N curves

2020-04-27 Thread Klemens Nanni
On Tue, Apr 28, 2020 at 01:09:09AM +0200, Tobias Heider wrote: > the EC2N family of curves have been marked as insecure for at least 10 years. > In fact, IANA has stopped listing them altogether [1]. > Their former IDs are now 'reserved'. > > I think it's time for us to drop them as well. OK kn

msi-x for ixl(4)

2020-04-27 Thread Jonathan Matthew
This makes ixl(4) use MSI-X where available. The hardware is set up for the same kind of approach as we're heading towards in em(4) and ix(4) - interrupts for admin commands and events (link state etc.) can only be delivered to vector 0, and the natural approach is to map rx and tx queues to

iked(8): remove insecure EC2N curves

2020-04-27 Thread Tobias Heider
Hi, the EC2N family of curves have been marked as insecure for at least 10 years. In fact, IANA has stopped listing them altogether [1]. Their former IDs are now 'reserved'. I think it's time for us to drop them as well. ok? [1]

alpha installation notes INSTALL.alpha

2020-04-27 Thread Sebastian Benoit
Hi, there have been no floppy images since the 6.2 release. This removes mention of boot floppies from the INSTALL.alpha notes. Maybe someone who knows something about alpha machines can do a check? comments or oks? diff --git distrib/notes/alpha/contents distrib/notes/alpha/contents index

Re: [PATCH] printf: Add %B conversion specifier for binary

2020-04-27 Thread Theo de Raadt
Ingo Schwarze wrote: > Alejandro Colomar wrote on Mon, Apr 27, 2020 at 08:26:38PM +0200: > > > This patch adds a new feature to the ``printf`` family of functions: > > ``%B`` conversion specifier for printing unsigned numbers in binary. > > No. We do not want non-standard extensions to

Re: [PATCH] printf: Add %B conversion specifier for binary

2020-04-27 Thread Ingo Schwarze
Hi, Alejandro Colomar wrote on Mon, Apr 27, 2020 at 08:26:38PM +0200: > This patch adds a new feature to the ``printf`` family of functions: > ``%B`` conversion specifier for printing unsigned numbers in binary. No. We do not want non-standard extensions to standard functions unless they

Re: [PATCH] printf: Add %B conversion specifier for binary

2020-04-27 Thread Theo de Raadt
Alejandro Colomar wrote: > I also sent today a patch to add this specifier to glibc. They are > concerned about adding a new non-standard specifier, but if more C libs > are going to add it at the same time, it may become a thing. Sorry, but I doubt any of this is going to happen. The action

[PATCH] printf: Add %B conversion specifier for binary

2020-04-27 Thread Alejandro Colomar
Hi all, This patch adds a new feature to the ``printf`` family of functions: ``%B`` conversion specifier for printing unsigned numbers in binary. Behaviour is exactly as with ``%X``, only changing the base (16 -> 2). ``%b`` is already in use by some ``printf(1)`` implementations, so I didn't

Re: drm(4) kqfilter & EVFILT_READ

2020-04-27 Thread Martin Pieuchot
On 28/04/20(Tue) 01:54, Jonathan Gray wrote: > On Mon, Apr 27, 2020 at 04:52:33PM +0200, Martin Pieuchot wrote: > > Diff below extends the existing drmkqfilter() to support EVFILT_READ. > > This makes drm(4)'s kqueue support in pair with poll(). > > > > The event list queried in the

net80211/athn/iwm/iwx: add nwflag nomimo

2020-04-27 Thread Stefan Sperling
We currently do not support 11n mode on devices which do not have all antenna ports connected. So if e.g. an athn(4) card is installed into an APU or Alix, we require that users plug pigtails into all antenna connectors on the card, and mount a corresponding number of antennas on the case. Given

Re: drm(4) kqfilter & EVFILT_READ

2020-04-27 Thread Jonathan Gray
On Mon, Apr 27, 2020 at 04:52:33PM +0200, Martin Pieuchot wrote: > Diff below extends the existing drmkqfilter() to support EVFILT_READ. > This makes drm(4)'s kqueue support in pair with poll(). > > The event list queried in the filt_drmread() should be protected by the > `event_lock' mutex.

Re: IPv6 Support for umb(4)

2020-04-27 Thread Gerhard Roth
On 4/27/20 4:53 PM, Theo de Raadt wrote: Gerhard Roth wrote: Hi Theo, On 4/27/20 4:39 PM, Theo de Raadt wrote: Is this code in umb_decode_ip_configuration() reached again, if you do a late ifconfig (don't set inet6 at up time, but set it later) no, seting inet6 later doesn't work. On MBIM

Re: IPv6 Support for umb(4)

2020-04-27 Thread Theo de Raadt
Gerhard Roth wrote: > Hi Theo, > > On 4/27/20 4:39 PM, Theo de Raadt wrote: > > Is this code in umb_decode_ip_configuration() reached again, if > > you do a late ifconfig (don't set inet6 at up time, but set it > > later) > > no, seting inet6 later doesn't work. On MBIM level I have to tell

drm(4) kqfilter & EVFILT_READ

2020-04-27 Thread Martin Pieuchot
Diff below extends the existing drmkqfilter() to support EVFILT_READ. This makes drm(4)'s kqueue support in pair with poll(). The event list queried in the filt_drmread() should be protected by the `event_lock' mutex. This could be done by using the `kdev' backpointer as shown in comment.

Re: IPv6 Support for umb(4)

2020-04-27 Thread Gerhard Roth
Hi Theo, On 4/27/20 4:39 PM, Theo de Raadt wrote: Is this code in umb_decode_ip_configuration() reached again, if you do a late ifconfig (don't set inet6 at up time, but set it later) no, seting inet6 later doesn't work. On MBIM level I have to tell the device *before* the CONNECT whether I

Re: IPv6 Support for umb(4)

2020-04-27 Thread Theo de Raadt
Is this code in umb_decode_ip_configuration() reached again, if you do a late ifconfig (don't set inet6 at up time, but set it later) That is how other network interfaces work. I'm trying to make sure this behaviour isn't too weird (ie. requiring a down, then up). Gerhard Roth wrote: > And

Re: IPv6 Support for umb(4)

2020-04-27 Thread Gerhard Roth
And since IPv6 is now optional for umb(4), we can just skip evaluation of the IPv6 part of the IP configuration, if it wasn't enabled. Gerhard Index: sys/dev/usb/if_umb.c === RCS file: /cvs/src/sys/dev/usb/if_umb.c,v retrieving

Re: patch: Enable dock audio on Thinkpad dock (Thinkpad L460)

2020-04-27 Thread Abel Abraham Camarillo Ojeda
On Monday, April 27, 2020, Jan Klemkow wrote: > On Thu, Apr 16, 2020 at 05:59:44PM -0500, Abel Abraham Camarillo Ojeda > wrote: > > On Tuesday, February 11, 2020, Abel Abraham Camarillo Ojeda < > acam...@verlet.org> wrote: > > > On Wednesday, January 8, 2020, Abel Abraham Camarillo Ojeda < >

Re: Raspberry Pi GPIO

2020-04-27 Thread Mark Kettenis
> Date: Mon, 27 Apr 2020 12:33:24 +0100 > From: Stuart Henderson > > On 2020/04/26 12:56, Mark Kettenis wrote: > > Diff below adds GPIO support to bcmgpio(4). It also adds the bits to > > attach gpio(4) such that GPIO pins can be controlled from userland. > > This makes sense on boards like the

Re: Raspberry Pi GPIO

2020-04-27 Thread Stuart Henderson
On 2020/04/26 12:56, Mark Kettenis wrote: > Diff below adds GPIO support to bcmgpio(4). It also adds the bits to > attach gpio(4) such that GPIO pins can be controlled from userland. > This makes sense on boards like the Raspberry Pi and the > implementation makes sure that pins used by kernel

Re: IPv6 Support for umb(4)

2020-04-27 Thread Gerhard Roth
Hello Claudio, On Mon, 27 Apr 2020 11:51:50 +0200 Claudio Jeker wrote: > On Mon, Apr 27, 2020 at 10:26:01AM +0200, Gerhard Roth wrote: > > Should we change umb(4) so that it only grabs an IPv6 address > > in case somebody does a "ifconfig umb0 inet6 eui64" first? > > > > Anyone willing to ok

Re: maxrtc(4)

2020-04-27 Thread Mark Kettenis
> Date: Sat, 25 Apr 2020 20:20:37 +0200 (CEST) > From: Mark Kettenis > > The cvs log tells me this driver was written to privide an alternative > clock for the Sun Fire V210. That is probably why it prints a message > about overwriting the rtc handler. But the driver was never enabled > on

Re: pcfrtc(4) fix

2020-04-27 Thread Mark Kettenis
> Date: Sat, 25 Apr 2020 00:41:38 +0200 (CEST) > From: Mark Kettenis > > The chip will set the OSF flag whenever the internal oscillator stops > running. That happens for example wen the battry runs out of juice. > The idea as that we can check this flag to decide whether we should > trust the

Re: Simplify NET_LOCK() variations

2020-04-27 Thread Martin Pieuchot
On 16/04/20(Thu) 11:08, Alexandr Nedvedicky wrote: > [...] > > @@ -356,7 +367,17 @@ taskq_thread(void *xtq) > > { > > struct taskq *tq = xtq; > > struct task work; > > - int last; > > + int last, i; > > + > > + mtx_enter(>tq_mtx); > > + for (i = 0; i < tq->tq_nthreads; i++) { > >

Re: IPv6 Support for umb(4)

2020-04-27 Thread Claudio Jeker
On Mon, Apr 27, 2020 at 10:26:01AM +0200, Gerhard Roth wrote: > Should we change umb(4) so that it only grabs an IPv6 address > in case somebody does a "ifconfig umb0 inet6 eui64" first? > > Anyone willing to ok the patch below? see below > On 2/19/20 9:19 AM, Gerhard Roth wrote: > > On Wed,

Re: patch: Enable dock audio on Thinkpad dock (Thinkpad L460)

2020-04-27 Thread Jan Klemkow
On Thu, Apr 16, 2020 at 05:59:44PM -0500, Abel Abraham Camarillo Ojeda wrote: > On Tuesday, February 11, 2020, Abel Abraham Camarillo Ojeda > wrote: > > On Wednesday, January 8, 2020, Abel Abraham Camarillo Ojeda > > wrote: > >> On Mon, Dec 30, 2019 at 1:24 PM Abel Abraham Camarillo Ojeda >

Re: diff: em(4) deadlock fix

2020-04-27 Thread Martin Pieuchot
On 21/04/20(Tue) 15:54, Jan Klemkow wrote: > Hi, > > The following diff fixes a deadlock in em(4) when system runs out of > mbuf(9)s. > > Tested with current on amd64 with: > em0 at pci0 dev 25 function 0 "Intel I217-LM" rev 0x05: msi, mac 0x1e phy > 0xb, address d0:50:99:c1:67:94 > > When the

Re: [patch] Check for -1 explicitly in getpeereid.c

2020-04-27 Thread Martin Vahlensieck
On Sun, Apr 26, 2020 at 03:30:51PM -0600, Theo de Raadt wrote: > Patrick Wildt wrote: > > > I don't know userland very well, so I have a question. In the middle of > > 2019 there have been plenty of changes in regards to changing checks of > > syscalls from < 0 to a more strict == -1, like this

Re: IPv6 Support for umb(4)

2020-04-27 Thread Gerhard Roth
Should we change umb(4) so that it only grabs an IPv6 address in case somebody does a "ifconfig umb0 inet6 eui64" first? Anyone willing to ok the patch below? On 2/19/20 9:19 AM, Gerhard Roth wrote: On Wed, 19 Feb 2020 08:45:39 +0100 Claudio Jeker wrote: On Tue, Feb 18, 2020 at 11:16:54PM

Re: athn(4): configure Tx interrupt mitigation

2020-04-27 Thread Stefan Sperling
Anyone? On Wed, Apr 22, 2020 at 07:28:02PM +0200, Stefan Sperling wrote: > We currently configure interrupt mitigation for Rx, but not for Tx. > > And there is also a global Tx/Rx interrupt limit which can be configured > via the MIRT register. Setting this could prevent Tx/Rx interrupt storms.