Re: lex(1): warning with -Wmisleading-indentation in generated scanner

2021-05-04 Thread Theo Buehler
On Wed, May 05, 2021 at 10:40:57AM +0800, Nick Gasson wrote: > Hi, > > When I build my program with the lex(1) in OpenBSD I get the following > warning: > > src/lexer.c:2415:3: warning: misleading indentation; statement is not part of > the previous 'if' > [-Wmisleading-indentation] >

lex(1): warning with -Wmisleading-indentation in generated scanner

2021-05-04 Thread Nick Gasson
Hi, When I build my program with the lex(1) in OpenBSD I get the following warning: src/lexer.c:2415:3: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation] return yy_is_jam ? 0 : yy_current_state; ^

nvme: add timeout to nvme_poll() loop

2021-05-04 Thread Ashton Fagg
I noticed this when looking through the nvme.c code the other day. Currently, nvme_poll() has a loop like this: while (!ISSET(state.c.flags, htole16(NVME_CQE_PHASE))) { if (nvme_q_complete(sc, q) == 0) delay(10); /* XXX no timeout?

Re: timeout_del_barrier(9): remove kernel lock

2021-05-04 Thread David Gwynne
On Tue, May 04, 2021 at 11:54:31AM -0500, Scott Cheloha wrote: > On Tue, May 04, 2021 at 11:21:27PM +1000, David Gwynne wrote: > > On Tue, May 04, 2021 at 11:24:05AM +0200, Martin Pieuchot wrote: > > > On 04/05/21(Tue) 01:10, Scott Cheloha wrote: > > > > [...] > > > > I want to run softclock()

Cleanup of err(1, "unveil") pattern: usr.bin

2021-05-04 Thread Ashton Fagg
Ashton Fagg writes: > Ok splendid. I've regenerated these, this time including dhcpleased and > slaacd since Florian requested I do this in private mail. > > I went for err(1, "unveil %s", path) per Theo's suggestion - nice and > clear. This is now everything in sbin, bin and games. usr/{bin,

Re: ld.so: NULL dereference on corrupt library

2021-05-04 Thread Klemens Nanni
On Thu, Apr 15, 2021 at 03:05:45PM +0200, Mark Kettenis wrote: > > Date: Thu, 15 Apr 2021 14:20:00 +0200 > > From: Martin Pieuchot > > Content-Type: text/plain; charset=utf-8 > > Content-Disposition: inline > > > > On 14/04/21(Wed) 18:33, Klemens Nanni wrote: > > > A bogus libvorbisenc.so.3.1

Re: timeout_del_barrier(9): remove kernel lock

2021-05-04 Thread Scott Cheloha
On Tue, May 04, 2021 at 11:21:27PM +1000, David Gwynne wrote: > On Tue, May 04, 2021 at 11:24:05AM +0200, Martin Pieuchot wrote: > > On 04/05/21(Tue) 01:10, Scott Cheloha wrote: > > > [...] > > > I want to run softclock() without the kernel lock. The way to go, I > > > think, is to first push

Re: timeout_del_barrier(9): remove kernel lock

2021-05-04 Thread Scott Cheloha
On Tue, May 04, 2021 at 11:24:05AM +0200, Martin Pieuchot wrote: > On 04/05/21(Tue) 01:10, Scott Cheloha wrote: > > [...] > > I want to run softclock() without the kernel lock. The way to go, I > > think, is to first push the kernel lock down into timeout_run(), and > > then to remove the kernel

services(5): add default ftps ports

2021-05-04 Thread Jan Klemkow
Hi, Add missing ftps defaults ports to servies(5). OK? bye, Jan Index: services === RCS file: /cvs/src/etc/services,v retrieving revision 1.99 diff -u -p -r1.99 services --- services18 Feb 2021 02:30:29 - 1.99 +++

Re: timeout_del_barrier(9): remove kernel lock

2021-05-04 Thread David Gwynne
On Tue, May 04, 2021 at 11:24:05AM +0200, Martin Pieuchot wrote: > On 04/05/21(Tue) 01:10, Scott Cheloha wrote: > > [...] > > I want to run softclock() without the kernel lock. The way to go, I > > think, is to first push the kernel lock down into timeout_run(), and > > then to remove the kernel

ftpd(8): constify internal functions

2021-05-04 Thread Jan Klemkow
Hi, The following diff adds some missing consts for char * to the internal program functions. OK? bye, Jan Index: extern.h === RCS file: /cvs/src/libexec/ftpd/extern.h,v retrieving revision 1.21 diff -u -p -r1.21 extern.h ---

Re: iwx and sysupgrade

2021-05-04 Thread Raf Czlonka
On Tue, May 04, 2021 at 11:33:31AM BST, Stefan Sperling wrote: > On Tue, May 04, 2021 at 11:15:45AM +0100, Raf Czlonka wrote: > > Unless I'm missing something, Hrvoje's not suing dhclient(8) - as > > there's no 'dhcp' entry in the /etc/hostname.iwx0 - but dhcpleased(8), > > most likely. > > It is

Re: iwx and sysupgrade

2021-05-04 Thread Stefan Sperling
On Tue, May 04, 2021 at 11:15:45AM +0100, Raf Czlonka wrote: > Unless I'm missing something, Hrvoje's not suing dhclient(8) - as > there's no 'dhcp' entry in the /etc/hostname.iwx0 - but dhcpleased(8), > most likely. It is happening in the ramdisk kernel, which is still using dhclient at this

Re: iwx and sysupgrade

2021-05-04 Thread Hrvoje Popovski
On 4.5.2021. 12:15, Raf Czlonka wrote: > On Tue, May 04, 2021 at 10:55:37AM BST, Stefan Sperling wrote: >> On Tue, May 04, 2021 at 11:47:43AM +0200, Hrvoje Popovski wrote: >>> I'm not sure that with iwx and eduroam, sysupgrade can finish. Maybe i >>> need to wait longer, will try that ...

Re: iwx and sysupgrade

2021-05-04 Thread Raf Czlonka
On Tue, May 04, 2021 at 10:55:37AM BST, Stefan Sperling wrote: > On Tue, May 04, 2021 at 11:47:43AM +0200, Hrvoje Popovski wrote: > > I'm not sure that with iwx and eduroam, sysupgrade can finish. Maybe i > > need to wait longer, will try that ... sysupgrade will finish if iwx is > > disabled or

Re: iwx and sysupgrade

2021-05-04 Thread Hrvoje Popovski
On 4.5.2021. 11:55, Stefan Sperling wrote: > On Tue, May 04, 2021 at 11:47:43AM +0200, Hrvoje Popovski wrote: >> I'm not sure that with iwx and eduroam, sysupgrade can finish. Maybe i >> need to wait longer, will try that ... sysupgrade will finish if iwx is >> disabled or hostname.iwx0 is removed

Re: iwx and sysupgrade

2021-05-04 Thread Stefan Sperling
On Tue, May 04, 2021 at 11:47:43AM +0200, Hrvoje Popovski wrote: > I'm not sure that with iwx and eduroam, sysupgrade can finish. Maybe i > need to wait longer, will try that ... sysupgrade will finish if iwx is > disabled or hostname.iwx0 is removed from etc before doing sysupgrade If iwx is

Re: iwx and sysupgrade

2021-05-04 Thread Florian Obser
On 2021-05-04 11:47 +02, Hrvoje Popovski wrote: > I'm not sure that with iwx and eduroam, sysupgrade can finish. Maybe i We have seen bugs before where we would wait for network while doing an automated upgrade. I think bsd.rd should not bring up the network when it detects that it's in

Re: iwx and sysupgrade

2021-05-04 Thread Hrvoje Popovski
On 4.5.2021. 11:44, Stefan Sperling wrote: > On Tue, May 04, 2021 at 11:36:01AM +0200, Hrvoje Popovski wrote: >> On 4.5.2021. 11:02, Hrvoje Popovski wrote: >>> i've disabled and stopped wpa_supplicant and reboot laptop and iwx0 >>> didn't get ip but laptop did boot normally .. >>> >>> iwx0:

Re: iwx and sysupgrade

2021-05-04 Thread Hrvoje Popovski
On 4.5.2021. 11:38, Stefan Sperling wrote: > On Tue, May 04, 2021 at 11:02:49AM +0200, Hrvoje Popovski wrote: >> On 4.5.2021. 10:47, Stefan Sperling wrote: >>> On Tue, May 04, 2021 at 10:32:02AM +0200, Hrvoje Popovski wrote: Hi all, today i tried to do sysupgrade and it wouldn't

Re: iwx and sysupgrade

2021-05-04 Thread Stefan Sperling
On Tue, May 04, 2021 at 11:36:01AM +0200, Hrvoje Popovski wrote: > On 4.5.2021. 11:02, Hrvoje Popovski wrote: > > i've disabled and stopped wpa_supplicant and reboot laptop and iwx0 > > didn't get ip but laptop did boot normally .. > > > > iwx0: flags=808843 mtu > > 1500 > > lladdr

Re: iwx and sysupgrade

2021-05-04 Thread Stefan Sperling
On Tue, May 04, 2021 at 11:02:49AM +0200, Hrvoje Popovski wrote: > On 4.5.2021. 10:47, Stefan Sperling wrote: > > On Tue, May 04, 2021 at 10:32:02AM +0200, Hrvoje Popovski wrote: > >> Hi all, > >> > >> today i tried to do sysupgrade and it wouldn't finish because of iwx > >> errors. > >> iwx is

Re: iwx and sysupgrade

2021-05-04 Thread Hrvoje Popovski
On 4.5.2021. 11:02, Hrvoje Popovski wrote: > On 4.5.2021. 10:47, Stefan Sperling wrote: >> On Tue, May 04, 2021 at 10:32:02AM +0200, Hrvoje Popovski wrote: >>> Hi all, >>> >>> today i tried to do sysupgrade and it wouldn't finish because of iwx errors. >>> iwx is working just fine with with

Re: timeout_del_barrier(9): remove kernel lock

2021-05-04 Thread Martin Pieuchot
On 04/05/21(Tue) 01:10, Scott Cheloha wrote: > [...] > I want to run softclock() without the kernel lock. The way to go, I > think, is to first push the kernel lock down into timeout_run(), and > then to remove the kernel lock from each timeout, one by one. Grabbing and releasing the

Re: iwx and sysupgrade

2021-05-04 Thread Hrvoje Popovski
On 4.5.2021. 10:47, Stefan Sperling wrote: > On Tue, May 04, 2021 at 10:32:02AM +0200, Hrvoje Popovski wrote: >> Hi all, >> >> today i tried to do sysupgrade and it wouldn't finish because of iwx errors. >> iwx is working just fine with with snapshots, even with eduroam :) >> >> e14gen2# cat

Re: iwx and sysupgrade

2021-05-04 Thread Stefan Sperling
On Tue, May 04, 2021 at 10:32:02AM +0200, Hrvoje Popovski wrote: > Hi all, > > today i tried to do sysupgrade and it wouldn't finish because of iwx errors. > iwx is working just fine with with snapshots, even with eduroam :) > > e14gen2# cat /etc/hostname.iwx0 > debug > join "eduroam" wpa

iwx and sysupgrade

2021-05-04 Thread Hrvoje Popovski
Hi all, today i tried to do sysupgrade and it wouldn't finish because of iwx errors. iwx is working just fine with with snapshots, even with eduroam :) e14gen2# cat /etc/hostname.iwx0 debug join "eduroam" wpa wpaakms 802.1x autoconf e14gen2# ifconfig iwx0 iwx0: flags=808847 mtu 1500

bgpd fix for rde evaluate all

2021-05-04 Thread Claudio Jeker
Noticed by the arouteserver author Pier Carlo Chiodi the new rde evaluate all feature has a bug when a 2nd best route is withdrawn. In that case that route got not withdrawn from the adj-rib-out. The problem is in up_generate_updates() and the fact that 'rde evaluate all' calls

timeout_del_barrier(9): remove kernel lock

2021-05-04 Thread Scott Cheloha
Hi, I want to run softclock() without the kernel lock. The way to go, I think, is to first push the kernel lock down into timeout_run(), and then to remove the kernel lock from each timeout, one by one. Before we can push the kernel lock down into timeout_run() we need to remove the kernel lock