Re: Provide memory barriers in refcnt_rele() and refcnt_finalize()

2022-03-13 Thread Philip Guenther
On Sun, Mar 13, 2022 at 10:27 AM Visa Hankala wrote: > On Sun, Mar 13, 2022 at 04:29:44PM +0100, Mark Kettenis wrote: > ... > > Under what circumstances does memory ordering matter for these > > interfaces? > > Consider the following scenario: > > struct widget { > struct refcnt

Re: issue with login.conf(5) rtable and su -l user

2022-03-13 Thread Todd C . Miller
On Sun, 13 Mar 2022 12:02:03 -0500, Matthew Martin wrote: > Ignoring -L which already honors rtable, su has three cases: > -l (asme=0 asthem=1) > -m (asme=1 asthem=0) >(asme=0 asthem=0) > > -l should honor rtable; I am not sure about the other two. I think the > least suprising would be

Re: pf: drop tcp packet when syn AND fin flags are set

2022-03-13 Thread Alexander Bluhm
On Sun, Mar 13, 2022 at 11:24:33PM +0100, Remi Locherer wrote: > Hi, > > When pf processes a TCP packet with SYN and FIN flags set, it removes > the FIN flag and continuous processing it. I propose we change that and > let pf drop such a packet. I don't see any legit use for combining these > two

pf: drop tcp packet when syn AND fin flags are set

2022-03-13 Thread Remi Locherer
Hi, When pf processes a TCP packet with SYN and FIN flags set, it removes the FIN flag and continuous processing it. I propose we change that and let pf drop such a packet. I don't see any legit use for combining these two flags in the same packet. Henning added this comment 7 years ago: XXX

Re: document membar atomic

2022-03-13 Thread Mark Kettenis
> Date: Sun, 13 Mar 2022 22:59:36 +0100 > From: Alexander Bluhm > > On Sun, Mar 13, 2022 at 10:55:51PM +0100, Mark Kettenis wrote: > > You missed atomic_cas. > > Fixed. ok kettenis@ > Index: share/man/man9/membar_sync.9 > === >

Re: document membar atomic

2022-03-13 Thread Alexander Bluhm
On Sun, Mar 13, 2022 at 10:55:51PM +0100, Mark Kettenis wrote: > You missed atomic_cas. Fixed. Index: share/man/man9/membar_sync.9 === RCS file: /data/mirror/openbsd/cvs/src/share/man/man9/membar_sync.9,v retrieving revision 1.3

Re: document membar atomic

2022-03-13 Thread Mark Kettenis
> Date: Sun, 13 Mar 2022 22:43:56 +0100 > From: Alexander Bluhm > > On Thu, Mar 10, 2022 at 10:12:40PM +0100, Mark Kettenis wrote: > > > Date: Thu, 10 Mar 2022 21:53:13 +0100 > > > From: Alexander Bluhm > > > > > > Hi, > > > > > > claudio@ mentioned that documentation for

Re: document membar atomic

2022-03-13 Thread Alexander Bluhm
On Thu, Mar 10, 2022 at 10:12:40PM +0100, Mark Kettenis wrote: > > Date: Thu, 10 Mar 2022 21:53:13 +0100 > > From: Alexander Bluhm > > > > Hi, > > > > claudio@ mentioned that documentation for membar_enter_after_atomic > > and membar_exit_before_atomic is missing. > > > > ok? > > I think this

Re: Provide memory barriers in refcnt_rele() and refcnt_finalize()

2022-03-13 Thread Visa Hankala
On Sun, Mar 13, 2022 at 04:29:44PM +0100, Mark Kettenis wrote: > > Date: Sun, 13 Mar 2022 12:47:13 + > > From: Visa Hankala > > > > This makes the refcnt implementation issue memory barriers when > > releasing references, splitting memory activity cleanly into preceding > > and succeeding

Re: Swap encrypt under memory pressure

2022-03-13 Thread Mark Kettenis
> Date: Sat, 12 Mar 2022 11:35:09 +0100 > From: Martin Pieuchot > > Try to allocate the buffer before doing the encryption, if it fails we > do not spend time doing the encryption. This reduce the pressure when > swapping with low memory. > > ok? Makes sense to me; ok kettenis@ > Index:

Re: issue with login.conf(5) rtable and su -l user

2022-03-13 Thread Matthew Martin
On Sun, Mar 13, 2022 at 02:30:23PM +0100, Solene Rapenne wrote: > Hi, I'm playing with the new rtable feature in login.conf(5) but it > seems one use case doesn't trigger the rtable change. > > I have an user called alice, if I ssh locally from my user to alice > with ssh alice@localhost, alice

Re: OpenBSD Mentorship

2022-03-13 Thread Ozgur Kara
� 13.03.2022, 18:47, "Katherine Mcmillan" : Hello all, � Hello,� I am interested in working with an expert OpenBSD developer who could mentor me for a defined project. If this could be through the GSoC, that would be ideal, but I am also interested in other mentorship opportunities.

Re: pluart(4): fifo support

2022-03-13 Thread Anton Lindqvist
On Sun, Mar 13, 2022 at 04:17:07PM +0100, Mark Kettenis wrote: > > Date: Fri, 11 Mar 2022 07:53:13 +0100 > > From: Anton Lindqvist > > > > On Tue, Mar 08, 2022 at 01:44:47PM +, Visa Hankala wrote: > > > On Tue, Mar 08, 2022 at 08:04:36AM +0100, Anton Lindqvist wrote: > > > > On Mon, Mar 07,

Re: Provide memory barriers in refcnt_rele() and refcnt_finalize()

2022-03-13 Thread Mark Kettenis
> Date: Sun, 13 Mar 2022 12:47:13 + > From: Visa Hankala > > This makes the refcnt implementation issue memory barriers when > releasing references, splitting memory activity cleanly into preceding > and succeeding stages around refcnt 1->0 transition. > > I think the while loop could be

Re: pluart(4): fifo support

2022-03-13 Thread Mark Kettenis
> Date: Fri, 11 Mar 2022 07:53:13 +0100 > From: Anton Lindqvist > > On Tue, Mar 08, 2022 at 01:44:47PM +, Visa Hankala wrote: > > On Tue, Mar 08, 2022 at 08:04:36AM +0100, Anton Lindqvist wrote: > > > On Mon, Mar 07, 2022 at 07:36:35AM +, Visa Hankala wrote: > > > > I still think that

Re: add -k / --keep for gzip(1)

2022-03-13 Thread Todd C . Miller
On Sun, 13 Mar 2022 13:26:13 +0100, Jeremie Courreges-Anglas wrote: > Works fine. Here's an updated diff with suggestions: > - "k" was not completely removed from compress's struct compressor opt > string, and was not needed in null_method > - try to keep the *flag variables ordered > - rework

OpenBSD Mentorship

2022-03-13 Thread Katherine Mcmillan
Hello all, I am interested in working with an expert OpenBSD developer who could mentor me for a defined project. If this could be through the GSoC, that would be ideal, but I am also interested in other mentorship opportunities. Please let me know if you're available! My skills/interests are

issue with login.conf(5) rtable and su -l user

2022-03-13 Thread Solene Rapenne
Hi, I'm playing with the new rtable feature in login.conf(5) but it seems one use case doesn't trigger the rtable change. I have an user called alice, if I ssh locally from my user to alice with ssh alice@localhost, alice has the correct routing table, if I use as root "su -l alice", then alice

Re: unwind(8): simplify query parsing

2022-03-13 Thread Bjorn Ketelaars
On Sun 13/03/2022 14:06, Florian Obser wrote: > anyone? > > On 2022-03-03 19:57 +01, Florian Obser wrote: > > parse_packet() is used by unbound(8) to parse response packets, not > > queries. There is no need to do all this work just to get access to > > the query id and flags. This is what

Re: unwind(8): simplify query parsing

2022-03-13 Thread Florian Obser
anyone? On 2022-03-03 19:57 +01, Florian Obser wrote: > parse_packet() is used by unbound(8) to parse response packets, not > queries. There is no need to do all this work just to get access to > the query id and flags. This is what unbound(8) is doing. > > OK? > > diff --git frontend.c

Provide memory barriers in refcnt_rele() and refcnt_finalize()

2022-03-13 Thread Visa Hankala
This makes the refcnt implementation issue memory barriers when releasing references, splitting memory activity cleanly into preceding and succeeding stages around refcnt 1->0 transition. I think the while loop could be optimized a little by re-reading r->r_refs just after sleep_finish(). That

Re: initial iwx(4) 11ac patch for testing

2022-03-13 Thread Joel Carnat
On 3/10/22 12:35, Stefan Sperling wrote: On Thu, Mar 10, 2022 at 12:25:17PM +0100, Stefan Sperling wrote: Unless anyone else finds a problem, this patch can be considered ready for review and commit. Of course, I forgot to apply my sysassert fix to the second phy context command function...

Provide memory barriers in FRELE()

2022-03-13 Thread Visa Hankala
This is a slightly tweaked version of the FRELE() memory barrier patch. The barriers aim to provide clearer memory access behaviour around the f_count 1->0 transition. With the barriers, the transition splits the memory activity into preceding and succeeding stages that do not overlap. OK?

Re: add -k / --keep for gzip(1)

2022-03-13 Thread Jeremie Courreges-Anglas
On Sat, Mar 12 2022, Solene Rapenne wrote: > On Sat, 12 Mar 2022 15:49:40 +0100 > Solene Rapenne : > >> On Sat, 05 Mar 2022 19:15:02 -0700 >> "Todd C. Miller" : >> >> > On Sun, 06 Mar 2022 02:58:30 +0100, Jeremie Courreges-Anglas wrote: >> > >> > > I'm not sure what you mean here. Solene's