Re: give cron a sensible default max load_avg for batch jobs

2015-11-14 Thread Benny Lofgren
On 2015-11-14 09:54, li...@wrant.com wrote: >>> I think 8 is way to high. Isn't the point of batch to run things >>> when the machine is mostly idle? >> The problem is (and we've had this discussion several times before at >> least in misc@), that the system load doesn't really tell us that. >

Re: give cron a sensible default max load_avg for batch jobs

2015-11-14 Thread Benny Lofgren
On 2015-11-14 13:57, Todd C. Miller wrote: > The quesion no one seems to be asking here is "who actually runs > batch". Anyone? I gave kind of an answer to that in my original posting. :-) At least I run batch and at, and I do it *all the time*. There is imho no more convenient way of firing of

Re: give cron a sensible default max load_avg for batch jobs

2015-11-13 Thread Benny Lofgren
d to base the default on a value relative to the number of cores - it made sense from my practical point of view. But I understand where Theo's coming from on this. Regards, /Benny -- internetlabbet.se / work: +46 8 551 124 80 / "Words must Benny Lofgren

Re: give cron a sensible default max load_avg for batch jobs

2015-11-13 Thread Benny Lofgren
On 2015-11-14 00:45, Theo de Raadt wrote: >> This patch changes the default setting to 1.5 * >> (number_of_cpus_in_system) instead, which I find better matches modern >> behaviour. > > A larger number is sensible in this position. > > I would propose 8. I don't agree with a calculation like that

give cron a sensible default max load_avg for batch jobs

2015-11-13 Thread Benny Lofgren
Hi tech@, Inspired by the flurry of changes to cron(8) the last couple of days, I finally went to fix an issue that has bitten me numerous times over the years, since I'm a heavy user of batch(1) and at(1): When running a batch/at job, cron looks at the system's current load average to determine

patch: top cpu stats default display

2015-11-06 Thread Benny Lofgren
Hi tech@, I want to suggest a small convenience (for me at least) change to top(1): - Always start with combined cpu stats view (one line) Supporting changes: - Invert behaviour of "top -1" accordingly - Remove then unnecessary "if cpus > 8 then combined_view = 1" - Adjust man page accordingly -

Re: pledge(2) and spamd(8)

2015-10-28 Thread Benny Lofgren
On 2015-10-28 17:47, Theo de Raadt wrote: >> I was just trying to pledge(2) spamd(8), nevertheless came across 2 >> priviliges kern_pledge.c is missing for this to work. >> >> First spamd(8) needs to read sysctl kern.maxfiles in order to see if it >> can launch with that value or not, and second

Re: tame() error handling diff

2015-10-06 Thread Benny Lofgren
Hi Nicholas, On 2015-10-06 09:56, Nicholas Marriott wrote: > I am not convinced, changing errno like this is gratuitous. We actually > do do it elsewhere, but IMO that is unnecessary too. That's fair enough. One can argue whether a certain error code is better suited than another until the cows c

Re: tame() error handling diff

2015-10-05 Thread Benny Lofgren
us programmers against our own mistakes. :-) Regards, /Benny > > On Mon, Oct 05, 2015 at 11:15:33PM +0200, Benny Lofgren wrote: >> Hi guys, >> >> I was playing around with tame() today, and have a couple of minor >> suggestions: >> >> >> -

Re: a few style examples don't comply

2015-10-05 Thread Benny Lofgren
On 2015-10-05 22:21, Rob Pierce wrote: > On Mon, Oct 05, 2015 at 05:38:34PM +0059, Jason McIntyre wrote: >> On Mon, Oct 05, 2015 at 11:50:49AM -0400, Rob Pierce wrote: > Is it KNF compliant to have an exit() or return() at the same indentation as > the closing function brace? For example: > >

tame() error handling diff

2015-10-05 Thread Benny Lofgren
Hi guys, I was playing around with tame() today, and have a couple of minor suggestions: - Return EINVAL instead of ENAMETOOLONG if the request argument string is too long. ENAMETOOLONG translates to "File name too long", which I think is misleading. Maybe E2BIG would be an alternative, but EINV

Re: banner(1): fix SYNOPSIS

2015-09-26 Thread Benny Lofgren
On 2015-09-24 08:11, Jason McIntyre wrote: > On Wed, Sep 23, 2015 at 07:42:54PM -0400, Michael Reed wrote: >> banner(1) without arguments works fine, so denote it as such >> in the manual. >> > > in the context of banner(1), define "works fine". i mean, technically > maybe it does but, practically

Re: lighter sleep

2015-09-22 Thread Benny Lofgren
On 2015-09-21 16:45, Mark Kettenis wrote: >> From: Christian Weisgerber >> Date: Mon, 21 Sep 2015 14:29:03 + (UTC) >> >> On 2015-09-21, Stefan Sperling wrote: >> > You could argue that the thousands separator should be supported though: > > $ sleep 1.000.000 > > if your locale is somethin

Re: Drop a distracting function from locate(1)

2015-09-19 Thread Benny Lofgren
On 2015-09-19 23:57, Michael McConville wrote: >> What's your thinking behind this? To me this seems like a perfectly >> rational and well motivated function to have, both for readability and >> rather than having to repeat the same statements several times over in >> the rest of the code, risking

Re: Drop a distracting function from locate(1)

2015-09-19 Thread Benny Lofgren
On 2015-09-19 20:29, Michael McConville wrote: > Index: locate/fastfind.c > === > RCS file: /cvs/src/usr.bin/locate/locate/fastfind.c,v > retrieving revision 1.12 > diff -u -p -r1.12 fastfind.c > --- locate/fastfind.c 16 Jan 2015 06:40

Re: [PATCH] Enable -f in ndp(8)

2015-08-01 Thread Benny Lofgren
On 2015-08-02 02:09, Benny Lofgren wrote: > This is also a comment to Dmitris' later mail proposing an alternative Apologies Dimitris, I managed to misspell your name. Regards, /Benny

Re: [PATCH] Enable -f in ndp(8)

2015-08-01 Thread Benny Lofgren
On 2015-07-25 21:20, Martin Pieuchot wrote: > On 13/07/15(Mon) 14:04, Dimitris Papastamos wrote: >> Hi, >> >> I noticed -f in ndp(8) did nothing at all so I've enabled it and >> documented the file syntax in the man page. > > If it does nothing, I'd say let's kill it. Looking at the code, that lo

Re: [patch] Disklabel message tweak

2015-07-17 Thread Benny Lofgren
e "No unsaved label changes" instead would make both camps happy? In my mind that wording clearly explains what just went on, while also taking into account what might likely have been done earlier in the edit session. Regards, /Benny -- internetlabbet.se / work: +46 8 551 124 80

Re: IBM-M4 available for getting OpenBSD working with it.

2012-05-16 Thread Benny Lofgren
perhaps this mailing list generally isn't the right place for job offers, I don't know.) Regards, /Benny -- internetlabbet.se / work: +46 8 551 124 80 / "Words must Benny Lofgren/ mobile: +46 70 718 11 90 / be weighed, / f

Re: Making time_t deal with the coming epoch

2012-04-01 Thread Benny Lofgren
rograms to malfunction in unexpected +ways. +If the end of days must be set, consider rebooting the machine for safety. +The end of days kernel code is untested. Regards, /Benny -- internetlabbet.se / work: +46 8 551 124 80 / "Words must Benny Lofgren/ mobile: +46 70 718 11 90 / be weighed, / fax:+46 8 551 124 89/not counted." /email: benny -at- internetlabbet.se

Re: -not for find(1)

2012-02-27 Thread Benny Lofgren
or one as far as I'm concerned, my main issue is as I mentioned that it is wise not to unnecessarily encourage nonportable programming practices by adding stuff without practical or functional gain, and adding a -not operator to find would certainly do just that. Just my two cents (abou

Re: dd(1) support for uppercase size modifiers

2011-10-09 Thread Benny Lofgren
m': >>> + case 'M': >>> t = num; >>> num *= 1048576; >>> if (t > num) >>> @@ -411,6 +413,7 @@ get_off(char *val) >>> ++expr; >>> break; >>> case &

Re: mountd is immortal

2011-07-29 Thread Benny Lofgren
t to kludgily "solve" the problem with an arbitrary sleep and then a SIGKILL in the rc script is wrong, wrong... Regards, /Benny -- internetlabbet.se / work: +46 8 551 124 80 / "Words must Benny Lofgren/ mobile: +46 70 718 11 90 / be weighed, / fax:+46 8 551 124 89/not counted." /email: benny -at- internetlabbet.se

Re: support specifying scheme/method in apache server configs

2011-07-19 Thread Benny Lofgren
se if (strstr(arg, "://") != NULL) >> +return ("unsupported scheme"); >> + >> +part = strstr(arg, ":"); >> +if (part != NULL) { >> +port = (int)strtonum(part + 1, 1, 65536, &err); >> + if

vnode(9) man page

2011-07-17 Thread Benny Lofgren
While reading up on vnodes I found a couple of glitches in the vnode(9) man page (diff below). It refers in one place to the file sys/kern/vnode_if.src which was deleted by this commit: 8<8<8<8<8< (cut) From: Thordur I Bjornsson Subject: [source-changes] CV

Re: Future of ccd(4) and raid(4)?

2011-06-24 Thread Benny Lofgren
On 2011-06-24 18.46, Joel Sing wrote: > On Friday 24 June 2011, Benny Lofgren wrote: >> On 2011-06-24 01.39, Matthew Dempsky wrote: >>> What should be done about ccd(4) and raid(4)? They both seem >>> superseded in functionality by softraid(4), which also has much more

Re: Future of ccd(4) and raid(4)?

2011-06-24 Thread Benny Lofgren
On 2011-06-24 01.39, Matthew Dempsky wrote: > What should be done about ccd(4) and raid(4)? They both seem > superseded in functionality by softraid(4), which also has much more > developer interest and active development. Never used ccd(4) so can't comment on that, but RAIDframe (raid(4)) has a

Re: Small pgrep/pkill enhancement

2011-06-11 Thread Benny Lofgren
On 2011-06-11 23.07, STeve Andre' wrote: >> NetBSD has that since March 2005 (committed by sketch@). >> FreeBSD copied it from NetBSD a few days later. >> procps.cvs.sourceforge.net (used e.g. in Debian) does not have -i. >> OpenSolaris does not have -i. >> >> So I'd say we shouldn't add it. >> >>

Areca ARC-1880 device driver

2011-06-04 Thread Benny Lofgren
Hi, I've got a new server with an Areca ARC-1880 RAID controller. Unfortunately that particular model isn't supported by the arc(4) driver (it is recognized in the PCI scan though). I've looked through the freebsd driver, and it doesn't seem all that difficult to make it work. They call it a "typ

Re: [persg...@gmail.com: Support for size multipliers in newfs/mount_mfs]

2011-05-23 Thread Benny Lofgren
On 2011-05-23 11.43, David Coppa wrote: > I'd like to commit the following diff by Vadim Zhukov. > This patch allows specifing k/m/g/... suffixes in newfs(8) > -S and -s options. Useful for mount_mfs, now you can just say: > > # mount_mfs -s 50m swap /tmp > > And it will do what you want, taking

Re: Tiny newsyslog(8) diff

2011-05-17 Thread Benny Lofgren
On 2011-05-17 11.50, Nathanael Rensen wrote: > Poking around in newsyslog(8) I noticed: > > $ grep MIN_SIZE newsyslog.c > #define MIN_SIZE256 /* Don't rotate if smaller (in > bytes) */ > && ((ent->flags & CE_BINARY) || size >= MIN_SIZE { > > hence: I don'

Re: fsck_ffs diff needs testing

2011-04-07 Thread Benny Lofgren
On 2011-04-07 17.19, Otto Moerbeek wrote: > softdep does not change the layout. But only filesystems which were > mounted with softdep get this optimization. There's a flag in teh > superblock to signal that. Filesystem mounted with softdep have better > guarantees about the cylinder group headers

Re: fsck_ffs diff needs testing

2011-04-07 Thread Benny Lofgren
On 2011-04-07 15.06, Otto Moerbeek wrote: > On Thu, Apr 07, 2011 at 02:34:27PM +0200, Benny Lofgren wrote: > >> On 2011-04-07 11.08, Otto Moerbeek wrote: >>> Hi, >>> >>> I got little feedeback on this diff posed in a rather long thread, so >>> I a

Re: fsck_ffs diff needs testing

2011-04-07 Thread Benny Lofgren
On 2011-04-07 11.08, Otto Moerbeek wrote: > Hi, > > I got little feedeback on this diff posed in a rather long thread, so > I am posting it again. > > Please test this, it makes fsck_ffs much faster (especially with -p) > and less memory hungry in a lot of cases. I've run it on a variety of file

Re: "no really, be quiet" mode for ping{,6}

2011-04-06 Thread Benny Lofgren
On 2011-04-06 13.00, Peter Hessler wrote: > On 2011 Apr 06 (Wed) at 12:47:40 +0200 (+0200), David Vasek wrote: > :On Wed, 6 Apr 2011, Peter Hessler wrote: > :>Sometimes I want ping to be quiet. Not quiet in the "only show me > :>headers" way that the original author thought was cute, but in the >

Re: horribly slow fsck_ffs pass1 performance

2011-04-02 Thread Benny Lofgren
On 2011-04-01 19.03, Amit Kulkarni wrote: > Thank you Arthur and the team for a very fast turnaround! Thank you > for reducing the pain. I will schedule a fsck every month or so, > knowing it won't screw up anything and be done really quick. Why "schedule" fsck runs at all? The file system code is

Re: horribly slow fsck_ffs pass1 performance

2011-04-02 Thread Benny Lofgren
On 2011-04-01 21.48, Amit Kulkarni wrote: >> And jumping up and down after a first successful test is not a sound >> engineering principle either. [...stuff deleted...] > It turns out that I had extracted into the default firefox download > location (/home/amit/downloads I forgot exactly where) all

Re: horribly slow fsck_ffs pass1 performance

2011-03-31 Thread Benny Lofgren
On 2011-03-31 11.13, Stuart Henderson wrote: > On 2011-03-31, Otto Moerbeek wrote: >> On Wed, Mar 30, 2011 at 03:45:02PM -0500, Amit Kulkarni wrote: >>> In fsck_ffs's pass1.c it just takes forever for large sized partitions >>> and also if you have very high number of files stored on that >>> part

Re: ls(1) displays future timestamps improperly

2011-03-21 Thread Benny Lofgren
On 2011-03-21 20.24, Ted Unangst wrote: > On Mon, Mar 21, 2011 at 7:04 AM, Benny Lofgren wrote: >> Realized I was sloppy with KNF. This diff is hopefully neater looking. > > I like this, but 5 seconds is not enough. I would have chosen at > least an hour, for poorly synced NFS

Re: ls(1) displays future timestamps improperly

2011-03-21 Thread Benny Lofgren
secs for (i = 11; i < 16; ++i) (void)putchar(longstring[i]); else { 8<8<8<8<8<8< (cut) -- internetlabbet.se / work: +46 8 551 124 80 / "Words m

ls(1) displays future timestamps improperly

2011-03-21 Thread Benny Lofgren
Hi list, If I touch(1) a file to a future date (or, for example, extract a tar archive from a system with an incorrect system clock), ls -l doesn't indicate that unless you use -T as well. That is, ls shows a misleading timestamp for that use case. All unixes I've worked with (including OpenBSD)

Re: OpenBSD 4.8 RAID 0+1 or 1+0 or 5

2011-02-16 Thread Benny Lofgren
On 2011-02-16 19.04, Stuart Henderson wrote: > On 2011/02/16 12:34, Steven R. Gerber wrote: >> Now, I have an EXPERIMENTAL RAID 5 volume. Not the worst. >> *** >> sd9 at scsibus4 targ 0 lun 0: SCSI2 0/direct fixed >> sd9: 5723178MB, 512 bytes/sec, 11721070081 sec total >> *** >> But, EXPERIMENTAL

Re: expr(1) diff 1 of 3, make it 64-bit capable

2011-01-15 Thread Benny Lofgren
On 2011-01-15 07.05, Philip Guenther wrote: > If you're going to email diffs, you MUST turn off 'format=flowed', as > Thunderbird munged the whitespace on your diffs enough to make them > break with "patch -l". Thunderbird has an option for that; find it > and use it. Check. for (i=0; i<100; i++

Re: expr(1) diff 2 of 3, make it able to accept c-style radix prefixes in integers

2011-01-15 Thread Benny Lofgren
On 2011-01-15 08.29, Philip Guenther wrote: On Fri, Jan 14, 2011 at 10:39 PM, Philip Guenther wrote: On Fri, Jan 14, 2011 at 8:11 PM, Benny Lofgren wrote: + Makes it able to use C-style radix prefixes to integers in order to do calculations in octal and hexadecimal. ... Unfortunately, this

Re: Make expr(1) 64-bit capable and radix-aware

2011-01-15 Thread Benny Lofgren
On 2011-01-15 07.43, Otto Moerbeek wrote: On Fri, Jan 14, 2011 at 08:22:25PM -0700, Theo de Raadt wrote: + Makes it 64-bit capable on 64-bit architectures by changing relevant int:s to long:s. I think this is a problem. I would expect a unix utility of this importance to work exactly the same o

expr(1) diff 3 of 3, make it able to print result in different radixes

2011-01-14 Thread Benny Lofgren
Hi, Third change resubmit for review. Recap: + Makes it able to output calculation results in hex and octal. This is of course the reverse functionality to the previous. Works like this: skynet:/usr/src/bin/expr# expr -x 16383 3fff skynet:/usr/src/bin/expr# expr -o 16383 3777

expr(1) diff 2 of 3, make it able to accept c-style radix prefixes in integers

2011-01-14 Thread Benny Lofgren
Hi, Resubmitting the second change for review. Recap: + Makes it able to use C-style radix prefixes to integers in order to do calculations in octal and hexadecimal. In the olden days, early '80:s to be specific, I worked at a company that produced a unix flavour called D-NIX, which had this

expr(1) diff 1 of 3, make it 64-bit capable

2011-01-14 Thread Benny Lofgren
Hi, Resubmitting the first of my three changes to expr(1) for review. To recap from my original mail: + Makes it 64-bit capable on both 32- and 64-bit architectures by changing relevant int:s to int64_t:s. I often use expr as a quick calculator for example when partitioning disks and such, an

Re: Make expr(1) 64-bit capable and radix-aware

2011-01-14 Thread Benny Lofgren
On 2011-01-15 04.23, Ted Unangst wrote: On Fri, Jan 14, 2011 at 10:11 PM, Benny Lofgren wrote: + Makes it 64-bit capable on 64-bit architectures by changing relevant int:s to long:s. I often use expr as a quick calculator for example when partitioning disks and such, and frequently find myself

Make expr(1) 64-bit capable and radix-aware

2011-01-14 Thread Benny Lofgren
Hi folks, Here's a diff to expr(1) that does three things I feel make it more useful: + Makes it 64-bit capable on 64-bit architectures by changing relevant int:s to long:s. I often use expr as a quick calculator for example when partitioning disks and such, and frequently find myself up again