On 2011-01-15 04.23, Ted Unangst wrote:
On Fri, Jan 14, 2011 at 10:11 PM, Benny Lofgren<bl-li...@lofgren.biz> wrote:
+ Makes it 64-bit capable on 64-bit architectures by changing relevant int:s
to long:s. I often use expr as a quick calculator for example when
partitioning disks and such, and frequently find myself up against the 32
bit signed integer limits.
I consider this a substantial regression actually. There's no reason
for it to be machine dependent like this. Fortunately, the fix should
be easy. Use int64_t everywhere and then everybody wins.
Yes, I considered that variant also but figured that it was suboptimal
to use 64-bit arithmetic on 32-bit platforms in such a frequently used
utility. On the other hand, what are a few machine cycles here and
there... :-)
The other changes seem useful, though others may care more about the
posixness of it all. It'd be best to split this into the three
different parts and submit as separate patches so we can discuss them
individually.
I'll resubmit with the 64-bit stuff addressed.
Thanks,
/Benny
--
internetlabbet.se / work: +46 8 551 124 80 / "Words must
Benny Lvfgren / mobile: +46 70 718 11 90 / be weighed,
/ fax: +46 8 551 124 89 / not counted."
/ email: benny -at- internetlabbet.se
