Re: zskbd_device_lookup is not used anymore

2013-05-10 Thread Mike Belopuhov
Hi, I'll commit it then, if there are no objections. On Sat, May 04, 2013 at 14:09 +0200, Sebastian Reitenbach wrote: On Friday, May 3, 2013 17:16 CEST, Mike Belopuhov m...@belopuhov.com wrote: hi, as far as i can tell these functions are not used anymore. my sparcbook 3gx

Re: check for device_lookup result in vscsi

2013-05-10 Thread Mike Belopuhov
On Fri, May 03, 2013 at 16:19 +0200, Mike Belopuhov wrote: hi, while looking for the device_unref bugs, i found that vscsi doesn't check if device_lookup has returned a valid return value. ok? anyone? diff --git sys/dev/vscsi.c sys/dev/vscsi.c index 3da371c..db65642 100644 --- sys

Re: check for device_lookup result in vscsi

2013-05-10 Thread Mike Belopuhov
On 10 May 2013 14:57, Gerhard Roth gerhard_r...@genua.de wrote: Mike, but it does check in vscsiopen(). Hence no userland program should be able to call vscsiioctl() for a non-existant device because the open() already failed. At least that's true as long as vscsi devices can't disappear

Re: trunk(4) take MTU from first member port.

2013-05-10 Thread Mike Belopuhov
On 10 May 2013 16:43, Chris Cappuccio ch...@nmedia.net wrote: Stuart Henderson [st...@openbsd.org] wrote: On 2013/02/22 12:30, Stuart Henderson wrote: I thought we already had something for this after the misc@ thread a few months ago, but clearly not. Adapted from FreeBSD if_lagg.c

Re: check for device_lookup result in vscsi

2013-05-10 Thread Mike Belopuhov
On Fri, May 10, 2013 at 10:35 -0700, Matthew Dempsky wrote: On Fri, May 10, 2013 at 6:02 AM, Mike Belopuhov m...@belopuhov.com wrote: my intention here is very simple: there's a way you should call device_lookup and everyone has to fulfill it's part of the contract. all our devices do

missing device_unref's

2013-05-03 Thread Mike Belopuhov
hi, looks like we're missing some device_unref's that need to be there after we call device_lookup or disk_lookup or numerous macros that expand to either of those. it would be nice if someone with working hibernate and ahci could test the diff (on either i386 or amd64). i'm also not 100% sure

check for device_lookup result in vscsi

2013-05-03 Thread Mike Belopuhov
hi, while looking for the device_unref bugs, i found that vscsi doesn't check if device_lookup has returned a valid return value. ok? diff --git sys/dev/vscsi.c sys/dev/vscsi.c index 3da371c..db65642 100644 --- sys/dev/vscsi.c +++ sys/dev/vscsi.c @@ -296,6 +296,9 @@ vscsiioctl(dev_t dev, u_long

Re: missing device_unref's

2013-05-03 Thread Mike Belopuhov
On Fri, May 03, 2013 at 15:50 +0200, Mike Belopuhov wrote: diff --git sys/dev/pci/cz.c sys/dev/pci/cz.c index 9f74393..03b0fb5 100644 --- sys/dev/pci/cz.c +++ sys/dev/pci/cz.c @@ -848,23 +848,30 @@ cztty_getttysoftc(dev_t dev) { int i, j, k, u = minor(dev) ~CZTTYDIALOUT_MASK

zskbd_device_lookup is not used anymore

2013-05-03 Thread Mike Belopuhov
hi, as far as i can tell these functions are not used anymore. ok? diff --git sys/arch/sparc/dev/z8530kbd.c sys/arch/sparc/dev/z8530kbd.c index 0a9c364..c746e56 100644 --- sys/arch/sparc/dev/z8530kbd.c +++ sys/arch/sparc/dev/z8530kbd.c @@ -213,8 +213,6 @@ static void zs_modem(struct zskbd_softc

DV_TTY is not used and can be ditched

2013-05-03 Thread Mike Belopuhov
hi, not sure if this is anyhow useful, but we can completely ditch DV_TTY since it's not used in any sensible way. any objections? ok? diff --git sys/arch/alpha/tc/scc.c sys/arch/alpha/tc/scc.c index d25901e..ad37605 100644 --- sys/arch/alpha/tc/scc.c +++ sys/arch/alpha/tc/scc.c @@ -179,7

Re: DV_TTY is not used and can be ditched

2013-05-03 Thread Mike Belopuhov
On 3 May 2013 20:12, Mark Kettenis mark.kette...@xs4all.nl wrote: Date: Fri, 3 May 2013 20:04:11 +0200 From: Mike Belopuhov m...@belopuhov.com hi, not sure if this is anyhow useful, but we can completely ditch DV_TTY since it's not used in any sensible way. any objections? ok? NAK

Re: More 'extern' love: net proto

2013-04-12 Thread Mike Belopuhov
On 12 April 2013 12:26, Martin Pieuchot mpieuc...@nolizard.org wrote: Simple diff to move all the redundant extern declaration into their corresponding header. ok? looks fine to me.

Re: More direct use of IFQ_MAXLEN

2013-03-25 Thread Mike Belopuhov
On Tue, Mar 19, 2013 at 11:50 +0100, Martin Pieuchot wrote: Diff below removes 4 global read-only variables ifqmaxlen, ipqmaxlen, ip6qmaxlen and mplsqmaxlen that are all set to IFQ_MAXLEN and never modified afterward. ok? OK to reduce bogosity.

Re: make bpf(4) and tcpdump(8) useful with queueing

2013-03-19 Thread Mike Belopuhov
On Tue, Mar 19, 2013 at 16:10 +0100, Martin Pelikan wrote: Hi! Yesterday I got sick and tired of guessing what the enormous traffic in our default queue was, and filled an item from my wishlist since OpenBSD 4.7. It works like this: # tcpdump -Q queuename -ni em0 tcpdump: listening on

Re: tedu faith(4) and faithd(8)

2013-03-13 Thread Mike Belopuhov
On 12 March 2013 19:25, Ted Unangst t...@tedunangst.com wrote: On Tue, Mar 12, 2013 at 15:30, Martin Pieuchot wrote: Diffs below kill respectively faith(4) and faithd(8) as suggested some weeks ago after a submission by dhill. ok? I am, of course, implicitly ok will all deletions of

Re: Kill IFAFREE()

2013-03-05 Thread Mike Belopuhov
On 5 March 2013 11:55, Mark Kettenis mark.kette...@xs4all.nl wrote: Date: Tue, 5 Mar 2013 11:36:36 +0100 From: Martin Pieuchot mpieuc...@nolizard.org The ifaddr structure contains a reference counter and two different way to check it before freeing its memory: a macro IFAFREE(), and a

Re: vr(4) baby jumbos

2013-02-09 Thread Mike Belopuhov
On 9 February 2013 16:27, Stuart Henderson s...@spacehopper.org wrote: So I think the vr(4) diff has had a reasonable amount of testing; any objections or ideally OKs to commit it? OK I have also tested sis(4) on a PC Engines WRAP now; despite the DP83815 datasheet indicating that Accept

Re: socket splicing maximum signaling

2013-01-15 Thread Mike Belopuhov
On 15 January 2013 11:34, Alexander Bluhm alexander.bl...@gmx.net wrote: Hi, Some years ago reyk@ mentioned that the current socket splicing semantics is suboptimal. When used with persistent http connections, the kernel does not inform user land when the maximum splicing lenght has been

Re: mbuf tag pool

2012-12-20 Thread Mike Belopuhov
On Wed, Dec 05, 2012 at 13:29 +0100, Mike Belopuhov wrote: converting mallocs to pools has an advantage of getting rid of the malloc in the forwarding path which gives a tiny bit of speed up but the main thing is that it makes life easier for those who have started working on the locking

Re: profiling kernels

2012-12-14 Thread Mike Belopuhov
On 14 December 2012 13:38, Stuart Henderson s...@spacehopper.org wrote: Are profiling kernels known to be broken at the moment? profiling has never worked on MP kernels...

ix: implement sfp+ module attach interrupt handling

2012-12-13 Thread Mike Belopuhov
first this allows you to connect the sfp+ cable after boot and correctly identify and use it, secondly it allows you (supposedly as i've only tested two different types of direct attach cables, i.e. different phys) to switch between copper and fiber w/o rebooting. SDP1 interrupt processing is not

Re: ix: implement sfp+ module attach interrupt handling

2012-12-13 Thread Mike Belopuhov
On Thu, Dec 13, 2012 at 20:49 +0100, Mike Belopuhov wrote: first this allows you to connect the sfp+ cable after boot and correctly identify and use it, secondly it allows you (supposedly as i've only tested two different types of direct attach cables, i.e. different phys) to switch between

Re: X540T: link is not detected

2012-12-12 Thread Mike Belopuhov
On Fri, Nov 30, 2012 at 20:44 +0100, Mike Belopuhov wrote: On Tue, Nov 27, 2012 at 13:50 +0100, mxb wrote: Hi tech@, ix(4) does not detects link then cable is plugged in into already running machine. ix0: flags=28b43UP,BROADCAST,RUNNING,PROMISC,ALLMULTI,SIMPLEX,MULTICAST,NOINET6

mbuf tag pool

2012-12-05 Thread Mike Belopuhov
converting mallocs to pools has an advantage of getting rid of the malloc in the forwarding path which gives a tiny bit of speed up but the main thing is that it makes life easier for those who have started working on the locking in the stack. henning and markus agree that having a single pool

Re: X540T: link is not detected

2012-11-30 Thread Mike Belopuhov
On Tue, Nov 27, 2012 at 13:50 +0100, mxb wrote: Hi tech@, ix(4) does not detects link then cable is plugged in into already running machine. ix0: flags=28b43UP,BROADCAST,RUNNING,PROMISC,ALLMULTI,SIMPLEX,MULTICAST,NOINET6 mtu 1500 lladdr bc:30:5b:f3:60:10 description:

Re: cloneable tun

2012-11-29 Thread Mike Belopuhov
On Wed, Nov 28, 2012 at 10:42 PM, Mark Kettenis mark.kette...@xs4all.nl wrote: From: Mike Belopuhov m...@belopuhov.com Date: Wed, 28 Nov 2012 22:21:07 +0100 On Wed, Nov 28, 2012 at 8:21 PM, Mark Kettenis mark.kette...@xs4all.nl wrote: Date: Wed, 28 Nov 2012 17:39:24 +0100 From: Reyk

Re: X540T: link is not detected

2012-11-29 Thread Mike Belopuhov
On Wed, Nov 28, 2012 at 12:38 PM, mxb m...@alumni.chalmers.se wrote: Compiling if_ix.c with IX_DEBUG yields ../../../../dev/pci/if_ix.c: In function 'ixgbe_print_hw_stats': ../../../../dev/pci/if_ix.c:3525: error: 'struct ix_softc' has no member named 'mbuf_alloc_failed'

Re: set ifp-if_baudrate with IF_Gbps() / IF_Mbps()

2012-11-29 Thread Mike Belopuhov
On Wed, Nov 28, 2012 at 2:25 AM, Brad Smith b...@comstyle.com wrote: On Sat, Nov 24, 2012 at 10:24:00PM -0500, Brad Smith wrote: On Fri, Nov 23, 2012 at 11:57:50AM -0200, Gleydson Soares wrote: set ifp-if_baudrate with IF_Gbps() / IF_Mbps(). OK ? Although it has already been commited its

change if_iqdrops to if_ierrors

2012-11-29 Thread Mike Belopuhov
hi, drivers ex age alc ale jme se vic vte xe upl and octeon/cmac make use of the if_iqdrops counter that is not shown by any of our tools (like netstat). looks like most of its usage comes from freebsd where they show it in the netstat -di output in a new column. do we want to do that or just

tiny fstat(1) output formatting nit

2012-11-29 Thread Mike Belopuhov
makes cloned devices line up well with the rest of the output: _dhcpdhclient 30880 text / 14 -r-xr-xr-x r 283856 _dhcpdhclient 30880 wd /var77953 drwxr-xr-x r 512 _dhcpdhclient 30880 root /var77953 drwxr-xr-x r 512 _dhcp

Re: change if_iqdrops to if_ierrors

2012-11-29 Thread Mike Belopuhov
On 29 November 2012 20:49, Claudio Jeker cje...@diehard.n-r-g.com wrote: On Thu, Nov 29, 2012 at 11:50:09AM -0500, Kenneth R Westerback wrote: On Thu, Nov 29, 2012 at 04:41:09PM +0100, Mike Belopuhov wrote: hi, drivers ex age alc ale jme se vic vte xe upl and octeon/cmac make use

Re: change if_iqdrops to if_ierrors

2012-11-29 Thread Mike Belopuhov
On 29 November 2012 21:21, Mark Kettenis mark.kette...@xs4all.nl wrote: Date: Thu, 29 Nov 2012 20:49:00 +0100 From: Claudio Jeker cje...@diehard.n-r-g.com On Thu, Nov 29, 2012 at 11:50:09AM -0500, Kenneth R Westerback wrote: On Thu, Nov 29, 2012 at 04:41:09PM +0100, Mike Belopuhov wrote

Re: change if_iqdrops to if_ierrors

2012-11-29 Thread Mike Belopuhov
: On Thu, Nov 29, 2012 at 04:41:09PM +0100, Mike Belopuhov wrote: hi, drivers ex age alc ale jme se vic vte xe upl and octeon/cmac make use of the if_iqdrops counter that is not shown by any of our tools (like netstat). looks like most of its usage comes from freebsd where

Re: clonable bpf

2012-11-28 Thread Mike Belopuhov
On Wed, Nov 28, 2012 at 12:43 PM, Reyk Floeter r...@openbsd.org wrote: On Tue, Nov 27, 2012 at 10:17 PM, Mike Belopuhov m...@belopuhov.com wrote: apparently it works just fine. the number of clones is limited by the v_specbitmap which currently allows for 64 clones total (per system, not per

Re: clonable bpf

2012-11-28 Thread Mike Belopuhov
On Wed, Nov 28, 2012 at 11:38 PM, Theo de Raadt dera...@cvs.openbsd.org wrote: there's not supposed to be bpf0,1,2,3... Unfortunately history argues otherwise. no, i meant if we move to the clonable bpf, we will need only one node. sorry for not making it clear.

Re: raw_usrreq - spl diff

2012-11-27 Thread Mike Belopuhov
As you might have already noticed, the diff was committed. Thanks! On Mon, Nov 26, 2012 at 8:34 PM, David Hill dh...@mindcry.org wrote: Any thoughts? On Tue, Nov 13, 2012 at 02:18:35PM -0500, David Hill wrote: Hello - I originally asked mikeb if splnet was needed in net/pfkey.c. He added

clonable bpf

2012-11-27 Thread Mike Belopuhov
apparently it works just fine. the number of clones is limited by the v_specbitmap which currently allows for 64 clones total (per system, not per process). apply the diff and see how all your apps are happily using single device node: /dev/bpf0. thanks to pedro and thib for the spec_open_clone

Re: clonable bpf

2012-11-27 Thread Mike Belopuhov
On Tue, Nov 27, 2012 at 22:17 +0100, Mike Belopuhov wrote: apparently it works just fine. the number of clones is limited by the v_specbitmap which currently allows for 64 clones total (per system, not per process). apply the diff and see how all your apps are happily using single device

Re: rtsock: filter out unwanted rt flags

2012-11-27 Thread Mike Belopuhov
On Tue, Nov 27, 2012 at 11:30 PM, Claudio Jeker cje...@diehard.n-r-g.com wrote: Hi, There are two flags which are not used or only used by the kernel (outgoing to userland). When userlands sends rt messages with these flags they do no harm but show up in route(8) and netstat(1). IMO we should

Re: raw_usrreq - spl diff

2012-11-26 Thread Mike Belopuhov
We've discussed this with claudio and while there are might be some other related issues with pr_usrreq and spls, I think this particular diff needs to be committed. OK? On Tue, Nov 13, 2012 at 14:18 -0500, David Hill wrote: Hello - I originally asked mikeb if splnet was needed in

Re: raw_usrreq - spl diff

2012-11-26 Thread Mike Belopuhov
On Mon, Nov 26, 2012 at 8:54 PM, Mark Kettenis mark.kette...@xs4all.nl wrote: Date: Mon, 26 Nov 2012 20:37:22 +0100 From: Mike Belopuhov m...@belopuhov.com We've discussed this with claudio and while there are might be some other related issues with pr_usrreq and spls, I think

Re: set ifp-if_baudrate with IF_Gbps() / IF_Mbps()

2012-11-25 Thread Mike Belopuhov
On Sun, Nov 25, 2012 at 10:53 AM, Reyk Floeter r...@openbsd.org wrote: Am Sonntag, 25. November 2012 schrieb Brad Smith : I don't think you're understanding what I am trying to say. I am not switching or removing anything per se. The MII framework already takes care of this and has for 12

Re: Display hardmtu with ifconfig hwfeatures

2012-11-23 Thread Mike Belopuhov
On Fri, Nov 23, 2012 at 5:16 PM, Reyk Floeter r...@openbsd.org wrote: On Fri, Nov 23, 2012 at 04:04:20PM +, Stuart Henderson wrote: This adds an ioctl to retrieve if_hardmtu, and adds code to display it via ifconfig hwfeatures. $ ifconfig em0 hwfeatures em0:

pf: fixup stack corruption caused by pf_set_rt_ifp

2012-11-22 Thread Mike Belopuhov
re pf bug on bugs@: apparently the crash is caused by the stack corruption that happens in pf_map_addr as it expects to get an array of struct pf_src_node pointers, not just one pointer. the bug was introduced about four years ago, but somehow (stack layout?) went unnoticed. the proper fix is

Re: TX_/RX_CSUM on Intel I350/X540T

2012-11-22 Thread Mike Belopuhov
On Thu, Nov 22, 2012 at 7:34 PM, mxb m...@alumni.chalmers.se wrote: Hey tech@, I'll more than gladly test any diffs for subject. Regards, Maxim both have rx checksums enabled. tx checksums can't be enabled on i350 right now. tx checksums on ix will need henning's diff to go in first.

Re: pf: fixup stack corruption caused by pf_set_rt_ifp

2012-11-22 Thread Mike Belopuhov
On Thu, Nov 22, 2012 at 16:05 +0100, Mike Belopuhov wrote: re pf bug on bugs@: apparently the crash is caused by the stack corruption that happens in pf_map_addr as it expects to get an array of struct pf_src_node pointers, not just one pointer. the bug was introduced about four years ago

Re: Disable modload(8)

2012-11-21 Thread Mike Belopuhov
On Wed, Nov 21, 2012 at 11:50 AM, Alexey E. Suslikov alexey.susli...@gmail.com wrote: Hello tech@. Following this http://blog.crowdstrike.com/2012/11/http-iframe-injecting-linux-rootkit.html Besides of doing #option LKM, is there any other way to disable modload(8)? Cheers, Alexey

Re: UVM Page Fault with Ralink wlan and Best login/net fs config?

2012-11-16 Thread Mike Belopuhov
On Fri, Nov 16, 2012 at 18:44 +, sbienddr...@googlemail.com wrote: As requested. ddb{0} uvm_fault(0xd0a50760, 0x0, 0, 1) - e kernel: page fault trap, code=0 Stopped atdb_read_bytes+0x14:movzbl0(%esi,%ecx,1),%eax ddb{0} ddb{0} db_read_bytes(0,1,f58ded94,0,2) at

Re: macppc: print uninorth/u3 revision number

2012-11-15 Thread Mike Belopuhov
On Thu, Nov 15, 2012 at 12:18 PM, Martin Pieuchot mpieuc...@nolizard.org wrote: Simple diff to print UniNorth's revision so it becomes easy to know which AGP chipset people have without looking at the 'eeprom -p' output. before: memc0 at mainbus0: uni-n after: memc0 at

Re: ##@!#@# gnu tools

2012-11-15 Thread Mike Belopuhov
On Thu, Nov 15, 2012 at 5:53 PM, Reyk Floeter r...@openbsd.org wrote: On Thu, Nov 15, 2012 at 5:11 PM, Marc Espie es...@nerim.net wrote: external people regularly ask but why you don't want to use GNU/m4 GNU/make GNU/whatever ? External people seem to ask weird questions. I just had to

Re: athn@usb: fixup detach panic

2012-11-09 Thread Mike Belopuhov
On Tue, Nov 06, 2012 at 12:15 +0100, Stefan Sperling wrote: On Tue, Nov 06, 2012 at 11:32:19AM +0100, Mike Belopuhov wrote: attach fails early in case there's no firmware, but athn_detach does ieee80211_ifdetach and if_detach regardless of whether ifnet part got setup correctly leading

ix: IFCAP_CSUM flags are pointless for the rx checksums

2012-11-07 Thread Mike Belopuhov
Remove code that is confusing and wrong: we don't want to disable rx checksumming if IFCAP_CSUM_IPv4 is set. Whatever this code used to mean in FreeBSD it doesn't do any good here. IXGBE_RXCSUM_PCSD is set when you do RSS (and is correctly handled in the visible RSS chunk below). OK? Index:

athn@usb: fixup detach panic

2012-11-06 Thread Mike Belopuhov
attach fails early in case there's no firmware, but athn_detach does ieee80211_ifdetach and if_detach regardless of whether ifnet part got setup correctly leading to a free of an unallocated memory and a panic. the following diff follows an established practice in the other drivers and fixes the

Re: Goodbye to you my file descriptor

2012-10-30 Thread Mike Belopuhov
On Tue, Oct 30, 2012 at 2:58 PM, Christiano F. Haesbaert haesba...@haesbaert.org wrote: On 30 October 2012 14:36, rustyBSD rusty...@gmx.fr wrote: MMmhh... == /usr/src/usr.bin/mg/dired.c == Go look the line 729: if ((fopen(dname,r)) == NULL) { ... Now you can cry What is

ix(4): remove unused flow director code

2012-10-30 Thread Mike Belopuhov
Hi, Flow director is described as a large number of flow affinity filters that direct receive packets by their flows to queues for classification, load balancing, and matching between flows and CPU cores. As we don't support anything like this the code (that is still compiled in but is not

Kill NSC HYPERchannel leftover

2012-10-12 Thread Mike Belopuhov
Hi, Unless Miod objects, I'd like to kill this leftover. We don't seem to be ditching AF_* defines, so AF_HYLINK glory will be preserved. OK? diff --git sys/netinet/in_proto.c sys/netinet/in_proto.c index c146e49..0f7845f 100644 --- sys/netinet/in_proto.c +++ sys/netinet/in_proto.c @@ -322,25

Re: Fix iked's auto-srcid based on the local hostname

2012-10-09 Thread Mike Belopuhov
On Tue, Oct 9, 2012 at 1:23 PM, Reyk Floeter r...@openbsd.org wrote: Hi, the iked.conf(5) manpage says: If srcid is omitted, the default is to use the hostname of the local machine, see hostname(1) to set or print the hostname. This was true but I broke it with a commit about two years ago

Re: Problem in vr_stop()

2012-09-18 Thread Mike Belopuhov
diff looks good to me. ok mikeb On Tue, Sep 18, 2012 at 12:49 +0200, Gerhard Roth wrote: Hi, we observed mysterious panics while stopping vr interfaces. This was due to vr_stop() trying to stop the transfers but then not waiting for them to really finish but rather remove their DMA buffer

Re: PF: match dir ... tag tag; pass tagged { tag, tag } keep state

2012-09-17 Thread Mike Belopuhov
On Mon, Sep 17, 2012 at 5:03 PM, Henning Brauer henn...@openbsd.org wrote: * mxb m...@alumni.chalmers.se [2012-09-10 17:51]: is there any plans to expand 'tagged' keyword in PF into list? not that I am aware of, but it would make sense to have list expansion there as well. would it mean

Re: [Patch] Virtio drivers for OpenBSD V7

2012-08-27 Thread Mike Belopuhov
On Wed, Aug 22, 2012 at 3:55 PM, Stefan Fritsch s...@sfritsch.de wrote: Here is the current version. Changes from v6: - net: rename device vioif - vio - net: don't use watchdog for cleaning up tx descriptors (in fact, remove watchdog completely) - net: various fixes for RingEventIdx mode;

Re: Small change to let mg handle localized characters

2012-08-23 Thread Mike Belopuhov
On Fri, Aug 24, 2012 at 12:55 AM, Stefan Sperling s...@openbsd.org wrote: For some bizarre reason emacs links to libossaudio instead ;) yeah, an sndio backend is yet to be written... another reason to migrate to the superior pulse-audio framework!

Re: [Patch] Virtio drivers for OpenBSD V6

2012-08-21 Thread Mike Belopuhov
On Tue, Aug 21, 2012 at 1:35 PM, Stefan Fritsch s...@sfritsch.de wrote: What do yo suggest then? Use a separate timeout? Accept the lower performance? what is the performance difference in terms of pps on small packets and Mbps for large are we talking about? Resetting the device in the

Re: [Patch] Virtio drivers for OpenBSD V6

2012-08-20 Thread Mike Belopuhov
On Mon, Aug 20, 2012 at 1:28 PM, Stefan Fritsch s...@sfritsch.de wrote: On Fri, 17 Aug 2012, Mike Belopuhov wrote: On Fri, Aug 17, 2012 at 1:17 PM, Stefan Fritsch s...@sfritsch.de wrote: On Thursday 16 August 2012, Mike Belopuhov wrote: could you please tell me if you're using tx interrupt

Re: [Patch] Virtio drivers for OpenBSD V6

2012-08-20 Thread Mike Belopuhov
On Mon, Aug 20, 2012 at 1:42 PM, Stefan Fritsch s...@sfritsch.de wrote: On Mon, 20 Aug 2012, Mike Belopuhov wrote: Always using the tx interrupt decreases performance significantly. On my test system (in MBytes/s): Sending UDP from 75 to 55 Sending TCP from 34 to 25 Why? Because

Re: [Patch] Virtio drivers for OpenBSD V6

2012-08-20 Thread Mike Belopuhov
On Mon, Aug 20, 2012 at 2:42 PM, Stefan Fritsch s...@sfritsch.de wrote: On Mon, 20 Aug 2012, Mike Belopuhov wrote: On Mon, Aug 20, 2012 at 1:42 PM, Stefan Fritsch s...@sfritsch.de wrote: Because the interrupt load increases by approx. 7000 per second. I think the problem is that the backend

Re: [Patch] Virtio drivers for OpenBSD V6

2012-08-16 Thread Mike Belopuhov
On Thu, Aug 16, 2012 at 4:49 PM, Stefan Fritsch s...@sfritsch.de wrote: Here is the next iteration: Changes from V5: - Remove unused code for mutexes - Remove explicit hardware memory barriers. If the host uses non-temporal memory operations like movnti, it will hopefully issue the memory

Re: acpihpet quality

2012-08-15 Thread Mike Belopuhov
On Wed, Aug 15, 2012 at 5:02 PM, Ted Unangst t...@tedunangst.com wrote: The acpihpet timer is, in my testing, lots better than the acpitimer. Faster to read and more precise. They should not have the same quality value. Double acpihpet. as long as acpi subsystem attaches acpitimer earlier

Re: acpihpet quality

2012-08-15 Thread Mike Belopuhov
On Wed, Aug 15, 2012 at 5:36 PM, Mike Belopuhov m...@crypt.org.ru wrote: On Wed, Aug 15, 2012 at 5:02 PM, Ted Unangst t...@tedunangst.com wrote: The acpihpet timer is, in my testing, lots better than the acpitimer. Faster to read and more precise. They should not have the same quality value

Re: [Patch] Virtio drivers for OpenBSD V5

2012-08-13 Thread Mike Belopuhov
On Mon, Aug 13, 2012 at 4:24 PM, Stefan Fritsch stefan_frit...@genua.de wrote: - virtio: use lfence/sfence because __sync_synchronize() is broken on gcc 4.4 please don't. use bus_space_barrier.

Re: [Patch] Virtio drivers for OpenBSD V5

2012-08-13 Thread Mike Belopuhov
On Mon, Aug 13, 2012 at 4:24 PM, Stefan Fritsch stefan_frit...@genua.de wrote: Hi, here is the next iteration of my patch. Changes from V4 include: - virtio: support RING_EVENT_IDX - virtio: use lfence/sfence because __sync_synchronize() is broken on gcc 4.4 - net:

Re: [Patch] Virtio drivers for OpenBSD V5

2012-08-13 Thread Mike Belopuhov
On Mon, Aug 13, 2012 at 5:30 PM, Stefan Fritsch stefan_frit...@genua.de wrote: On Monday 13 August 2012 17:07:41 you wrote: * Note: the i386 does not currently require barriers, but we must * provide the flags to MI code. This is not correct for virtio. We need a memory barrier. sure,

Re: [Patch] Virtio drivers for OpenBSD V5

2012-08-13 Thread Mike Belopuhov
On Mon, Aug 13, 2012 at 5:36 PM, Mike Belopuhov m...@crypt.org.ru wrote: On Mon, Aug 13, 2012 at 5:30 PM, Stefan Fritsch stefan_frit...@genua.de wrote: On Monday 13 August 2012 17:07:41 you wrote: * Note: the i386 does not currently require barriers, but we must * provide the flags to MI

Re: [Patch] Virtio drivers for OpenBSD V5

2012-08-13 Thread Mike Belopuhov
On Mon, Aug 13, 2012 at 5:41 PM, Mike Belopuhov m...@crypt.org.ru wrote: On Mon, Aug 13, 2012 at 5:36 PM, Mike Belopuhov m...@crypt.org.ru wrote: On Mon, Aug 13, 2012 at 5:30 PM, Stefan Fritsch stefan_frit...@genua.de wrote: On Monday 13 August 2012 17:07:41 you wrote: * Note: the i386

Re: use time_uptime for various pf expirations

2012-07-29 Thread Mike Belopuhov
On Sun, Jul 29, 2012 at 5:47 PM, Hrvoje Popovski wrote: Hello, i have tested your patches with torrent box behind 2 firewalls (nat, carp,pfsync). One firewall is patched and second box isn't. Both of them quite often export flows with duration of 429496* is it possible that these flows are

Re: intermittent crash

2012-07-22 Thread Mike Belopuhov
On Sun, Jul 22, 2012 at 11:03 +0100, Stuart Henderson wrote: On 2012/07/21 21:52, Mike Belopuhov wrote: On Sat, Jul 21, 2012 at 19:25 +0100, Stuart Henderson wrote: On 2012/07/21 18:49, Mike Belopuhov wrote: this sppp_clear_ip_addrs_args dance looks totally unneeded if i read

Re: SNMPv3 Support

2012-07-18 Thread Mike Belopuhov
On Wed, Jul 18, 2012 at 4:16 PM, Gerhard Roth wrote: same here, wouldn't it be possible to match the ipsec.conf grammar and ignore the SNMPv3 naming a bit? auth hmac-sha1 authkey fooobar enc aes enckey dkjdkj - instead of - hmac sha authpass foobar cipher aes privpass dkjdkj or maybe

Re: PF_PRIO_NOTSET wasn't such a smart attempt

2012-07-17 Thread Mike Belopuhov
On Wed, Jul 11, 2012 at 13:13 +0200, Henning Brauer wrote: ..because now you had to initialize both set_prio in pf_rule to it everywhere. we did that, at least in some parts of our tree... problem being of course that 0 is a valid value there and can\t easily be used as don't touch indicator.

Re: wbsio: Add support for Winbond W83627UHG

2012-06-29 Thread Mike Belopuhov
On Fri, Jun 29, 2012 at 5:41 AM, Lawrence Teo l...@openbsd.org wrote: This diff adds support for the Winbond W83627UHG chip, as found on the Lanner FW-7539 appliance.  This diff was ported from DragonFly BSD: http://gitweb.dragonflybsd.org/dragonfly.git/commitdiff/245ec76bc1613b22cf282

Re: Bridge rules

2012-06-29 Thread Mike Belopuhov
On Fri, Jun 29, 2012 at 1:36 PM, Henning Brauer lists-openbsdt...@bsws.de wrote: now it's very unclear what your actual problem is - the struct is called ifbreq and used in a number of places, most notably of course the ioctls. he's trying to add patterns to the mac address matching code and

Re: AES-{192,256}-CTR with isakmpd

2012-06-29 Thread Mike Belopuhov
On Fri, Jun 29, 2012 at 7:20 PM, Christian Weisgerber na...@mips.inka.de wrote: And the corresponding bits for iked(8).  I don't think we need to keep aes-ctr for compatibility there, do we? i'm a sitting on a fence a little bit. i don't really mind either way hence my OK for the diff.

Re: bnx(4) flow control support.

2012-06-28 Thread Mike Belopuhov
On Thu, Jun 28, 2012 at 16:07 +0200, Peter Hessler wrote: So we have been running with this diff in the office, and it is working well for us. bnx0 at pci7 dev 0 function 0 Broadcom BCM5709 rev 0x20: apic 0 int 6 bnx0: address 1c:c1:de:e4:5e:b0 brgphy0 at bnx0 phy 1: BCM5709

Re: AES-{192,256}-CTR with isakmpd

2012-06-28 Thread Mike Belopuhov
On Fri, Jun 29, 2012 at 12:09 AM, Christian Weisgerber na...@mips.inka.de wrote: Is there a particular reason we only support AES-128-CTR (AESCTR) with isakmpd(8), but not the 192- and 256-bit variants like we do for AES-CBC and AES-GCM? If not, and I assume it's just a historic oversight,

pfsync fixes

2012-06-27 Thread Mike Belopuhov
hi, one of the last pfsync improvements (r1.180) by yours truly introduced some nasty regressions for those running pfsync over the crossover cable. i apologize for all the inconveniences. peter hessler, kapeatanakis giannis and myself have been trying very hard to get this fixed. we have

Re: cwm tiling

2012-06-09 Thread Mike Belopuhov
On Sat, Jun 9, 2012 at 12:41 PM, Stuart Henderson s...@spacehopper.org wrote: On 2012/06/09 14:09, Alexander Polakov wrote: I appreciate that the defaults would stay the same, but really, what is the point in doing this?  cwm can't be everything to everyone. The point is: when you want

Re: add AMT ports to /etc/services

2012-06-02 Thread Mike Belopuhov
On Sat, Jun 2, 2012 at 11:02 AM, Stuart Henderson s...@spacehopper.org wrote: As with other entries in /etc/services, this adds to the ports to net.inet.tcp.baddynamic, preventing using the associated ports as a valid dynamic source port number. OK? sounds like a reasonable thing to do. ok

Re: Intel AHCI RAID controller in Sony VAIO Z23 laptop

2012-05-31 Thread Mike Belopuhov
On Thu, May 31, 2012 at 10:53 +0200, Paul de Weerd wrote: I've recently bought a new Sony laptop, VPCZ23C5E. Some things on this machine work fine (sound, suspend, wired network), some things don't (X, resume, wireless). One of the problems I have is that -current doesn't find any disks

Re: Intel Atom E600 watchdog(4) support

2012-05-24 Thread Mike Belopuhov
explains why I hadn't seen any others. Anyway, Mike Belopuhov suggested pchpcib as an alternative name so I've renamed the driver to that along with the man pages, etc. Here's the dmesg now: ---8--- pchpcib0 at pci0 dev 31 function 0 Intel E600 LPC rev 0x00: watchdog isa0 at pchpcib0 ---8

Re: Intel Atom E600 watchdog(4) support

2012-05-24 Thread Mike Belopuhov
a couple of private mails stating the same, which explains why I hadn't seen any others. Anyway, Mike Belopuhov suggested pchpcib as an alternative name so I've renamed the driver to that along with the man pages, etc. I'm not sure what it should be but pch seems a bit wrong, as the LPC device

IPsec: support for Extended Sequence Numbers (ESN) - Kernel

2012-05-21 Thread Mike Belopuhov
the following diff adds support for the 64-bit extended sequence numbers specified by RFC 4303. briefly, interesting points are: - only lower 32-bit part is transmitted so packet is not changed; - high-oder part is kept private and is used differently by HMAC and other MAC hashes (such as

IPsec support for Extended Sequence Numbers (ESN) - ipsecctl

2012-05-21 Thread Mike Belopuhov
this allows ipsecctl to print 'esn' flag nicely: # ipsecctl -ssa ah tunnel from 10.2.0.6 to 10.2.0.5 esn spi 0xbeefdead auth hmac-md5 ah tunnel from 10.2.0.5 to 10.2.0.6 esn spi 0xdeadbeef auth hmac-md5 there's no real value in

IPsec: support for Extended Sequence Numbers (ESN) - iked

2012-05-21 Thread Mike Belopuhov
esn is 90% supported in iked and this just adds some missing pieces. works with strongswan and windows (although windows doesn't propose ESN it's also a good test). diff --git sbin/iked/iked.h sbin/iked/iked.h index dc31da4..ce25bb3 100644 --- sbin/iked/iked.h +++ sbin/iked/iked.h @@ -156,6

Re: [patch] em: interrupt starvation

2012-05-10 Thread Mike Belopuhov
On Thu, May 10, 2012 at 15:22 +0200, Erik Lax wrote: Hi, I came across a real-world scenario where network traffic stopped due to interrupt starvation with the em driver, tested with a few different cards (on a network/interface where no packets were received). This is what caused it. I had

sti: support reverse video attribute

2012-05-05 Thread Mike Belopuhov
add support for the WSATTR_REVERSE attribute to sti(4) to make mg, less and others a bit prettier. tested on visualize fx 10 pro where this email was written. tests on other sti's are welcome as well as oks (: Index: dev/ic/sti.c

Re: sti: support reverse video attribute

2012-05-05 Thread Mike Belopuhov
On Sat, May 05, 2012 at 16:07 +, Miod Vallat wrote: add support for the WSATTR_REVERSE attribute to sti(4) to make mg, less and others a bit prettier. tested on visualize fx 10 pro where this email was written. tests on other sti's are welcome as well as oks (: This is a good

print sequence numbers as unsigned

2012-05-02 Thread Mike Belopuhov
sequence numbers in esp and ah are unsigned numbers, so we shouldn't ever be printing them with a minus sign :-) ok? Index: usr.sbin/tcpdump/print-ipsec.c === RCS file: /home/cvs/src/usr.sbin/tcpdump/print-ipsec.c,v retrieving

sys_pipe: take fd table lock after allocating memory

2012-04-21 Thread Mike Belopuhov
there's no apparent need to take a file descriptor table lock before we've done allocating pipe structures and buffers. ok? Index: sys/kern/sys_pipe.c === RCS file: /home/cvs/src/sys/kern/sys_pipe.c,v retrieving revision 1.61 diff -u

Re: IPv6: TLLA must be included with NA sent to multicast address

2012-04-20 Thread Mike Belopuhov
I'm still looking for OKs on this. On Mon, Apr 02, 2012 at 14:28 +0200, Mike Belopuhov wrote: RFC 4861 says: Target link-layer address The link-layer address for the target, i.e., the sender of the advertisement. This option MUST

Re: IPv6: fixup route priorities for RA and redirects

2012-04-20 Thread Mike Belopuhov
I'm still looking for OKs on this. On Mon, Apr 02, 2012 at 14:42 +0200, Mike Belopuhov wrote: When route priorities were added to the RA/redirects code, all of them got set to RTP_CONNECTED. Most importantly, rt6_flush was made to flush only RTP_CONNECTED routes. The purpose of rt6_flush

Re: save and restore %gs and gs.base on context switches

2012-04-19 Thread Mike Belopuhov
On Sat, Apr 14, 2012 at 13:35 +0200, Mike Belopuhov wrote: some software needs fully functional per-thread %gs base address, hence the diff. limited testing shows no regressions. INTR_RESTORE_SELECTORS changes include: - %r11 is used to store curpcb instead of rdx that is used for wrmsr

Re: save and restore %gs and gs.base on context switches

2012-04-14 Thread Mike Belopuhov
On Sat, Apr 14, 2012 at 3:42 PM, Mark Kettenis mark.kette...@xs4all.nl wrote: some software needs fully functional per-thread %gs base address, hence the diff. limited testing shows no regressions. INTR_RESTORE_SELECTORS changes include: - %r11 is used to store curpcb instead of rdx

<    3   4   5   6   7   8   9   10   >