MATHIHALLI,MADHUSUDAN (HP-Cupertino,ex1) wrote:
Okay.. Here it comes (with the changes suggested by Greg), and a couple more
fixes that I'd overseen earlier.
Madhu,
Could you take a look at what's in CVS now and see if there are changes that
should be made to that? I'm sorry if you missed my post
Greg Ames wrote:
MATHIHALLI,MADHUSUDAN (HP-Cupertino,ex1) wrote:
As regards the function names at the end of the function, I sure like
it -
it's a lot easier when you browse through the code.. But then, I
thought it
should be there for all of them or for none of them.. That's the reason I
decided
MATHIHALLI,MADHUSUDAN (HP-Cupertino,ex1) wrote:
As regards the function names at the end of the function, I sure like it -
it's a lot easier when you browse through the code.. But then, I thought it
should be there for all of them or for none of them.. That's the reason I
decided to take it away..
Okay.. Here it comes (with the changes suggested by Greg), and a couple more
fixes that I'd overseen earlier.
-Madhu
-Original Message-
From: Greg Ames [mailto:[EMAIL PROTECTED]
Sent: Wednesday, January 22, 2003 11:26 AM
To: [EMAIL PROTECTED]
Subject: Re: [PATCH] Style polic
2003 11:26 AM
To: [EMAIL PROTECTED]
Subject: Re: [PATCH] Style police for mod_specweb99.c
MATHIHALLI,MADHUSUDAN (HP-Cupertino,ex1) wrote:
> Summary of the patch :
> 1. convert tabs to spaces
> 2. try to follow apache styleguide
Overall, a big improvement...thanks much!
nitpicky comments follo
MATHIHALLI,MADHUSUDAN (HP-Cupertino,ex1) wrote:
Summary of the patch :
1. convert tabs to spaces
2. try to follow apache styleguide
Overall, a big improvement...thanks much!
nitpicky comments follow:
--- mod_specweb99.c 15 Jan 2003 16:15:02 - 1.18
+++ mod_specweb99.c 21 Jan 2003 21
On Wed, 22 Jan 2003, Greg Ames wrote:
> MATHIHALLI,MADHUSUDAN (HP-Cupertino,ex1) wrote:
> > Summary of the patch :
> > 1. convert tabs to spaces
>
> hmmm, I wonder how I missed 'em? IIRC I used "expand -i -t4 mod_specweb99.c"
>
> > 2. try to follow apache styleguide
>
> I plan on reviewing this
MATHIHALLI,MADHUSUDAN (HP-Cupertino,ex1) wrote:
Summary of the patch :
1. convert tabs to spaces
hmmm, I wonder how I missed 'em? IIRC I used "expand -i -t4
mod_specweb99.c"
2. try to follow apache styleguide
I plan on reviewing this, but I'm pretty weak on style other than not liking
tabs. Oth
Summary of the patch :
1. convert tabs to spaces
2. try to follow apache styleguide
[ Please note that there might be long lines because of the old style
followed in mod_specweb99.c ]
Thanks
-Madhu
<>
Index: mod_specweb99.c
===
RC
