Re: FW: Re: Apache::TestRequest + Cookies

2004-12-01 Thread Christopher H. Laco
Ok, here's my first crack at a quick n dirty cookies test. The new test is t/cookies.t, and it's supporting server file is t/htdocs/cgi-bin/cookies.pl. I figured the extra cgi-bin directory was good for sanity sake. I've also included the necessary patches to MANIFEST and extra.conf.in against

Re: FW: Re: Apache::TestRequest + Cookies

2004-12-01 Thread Stas Bekman
Christopher H. Laco wrote: Thanks, Chris, committed with a few small adjustements. You can see the commits here: http://svn.apache.org/viewcvs?view=revrev=109277 http://svn.apache.org/viewcvs?view=revrev=109279 Thanks. Glad to contribute. It looks like the only change was naming the cookies.pl

Re: FW: Re: Apache::TestRequest + Cookies

2004-12-01 Thread Christopher H. Laco
Stas Bekman wrote: Christopher H. Laco wrote: Thanks, Chris, committed with a few small adjustements. You can see the commits here: http://svn.apache.org/viewcvs?view=revrev=109277 http://svn.apache.org/viewcvs?view=revrev=109279 Thanks. Glad to contribute. It looks like the only change was

Re: FW: Re: Apache::TestRequest + Cookies

2004-12-01 Thread Christopher H. Laco
Stas Bekman wrote: Christopher H. Laco wrote: Ok, here's my first crack at a quick n dirty cookies test. The new test is t/cookies.t, and it's supporting server file is t/htdocs/cgi-bin/cookies.pl. I figured the extra cgi-bin directory was good for sanity sake. I've also included the necessary

Re: FW: Re: Apache::TestRequest + Cookies

2004-11-30 Thread Christopher H. Laco
CChristopher H. Laco wrote: Maybe relying on Apache::Session would cover more install scnerios instead. I was trying to avoid writing a custom handler just to accept and toss some cookies in the test environment, but maybe that's better. At least then everyone install should be able to run

Re: FW: Re: Apache::TestRequest + Cookies

2004-11-30 Thread Stas Bekman
Christopher H. Laco wrote: Christopher H. Laco wrote: CChristopher H. Laco wrote: Maybe relying on Apache::Session would cover more install scnerios instead. I was trying to avoid writing a custom handler just to accept and toss some cookies in the test environment, but maybe that's

Re: FW: Re: Apache::TestRequest + Cookies

2004-11-30 Thread Christopher H. Laco
Stas Bekman wrote: [snip] Why don't you first post what you had on your mind. May be your idea doesn't need that at all. Well, here's what I was thinking. First, write a quick and dirty mod_perl handler that looked for a specific cookie; let's say 'ApacheTest'. If it wasn't supplied by the

Re: FW: Re: Apache::TestRequest + Cookies

2004-11-30 Thread Stas Bekman
Christopher H. Laco wrote: Stas Bekman wrote: [snip] Why don't you first post what you had on your mind. May be your idea doesn't need that at all. Well, here's what I was thinking. First, write a quick and dirty mod_perl handler that looked for a specific cookie; let's say 'ApacheTest'. If

Re: FW: Re: Apache::TestRequest + Cookies

2004-11-30 Thread Christopher H. Laco
Stas Bekman wrote: Sounds good. Though it'll probably need to leave in the modperl2's test suite and not Apache-Test's one. but let's see the code first and then see where it's the best to apply it. You can use the http://perl.apache.org/~geoff/Apache-Test-skeleton-mp2.tar.gz to make it easy to

Re: FW: Re: Apache::TestRequest + Cookies

2004-11-30 Thread Stas Bekman
Christopher H. Laco wrote: Stas Bekman wrote: Sounds good. Though it'll probably need to leave in the modperl2's test suite and not Apache-Test's one. but let's see the code first and then see where it's the best to apply it. You can use the

Re: FW: Re: Apache::TestRequest + Cookies

2004-11-30 Thread Michael Peters
Stas Bekman wrote: Christopher H. Laco wrote: Stas Bekman wrote: Sounds good. Though it'll probably need to leave in the modperl2's test suite and not Apache-Test's one. but let's see the code first and then see where it's the best to apply it. You can use the

Re: FW: Re: Apache::TestRequest + Cookies

2004-11-30 Thread Christopher H. Laco
Stas Bekman wrote: Michael Peters wrote: Stas Bekman wrote: Christopher H. Laco wrote: Stas Bekman wrote: Sounds good. Though it'll probably need to leave in the modperl2's test suite and not Apache-Test's one. but let's see the code first and then see where it's the best to apply it. You can