Re: [Tigervnc-devel] [PATCH] Implement Plain in the client

On Thu, Sep 02, 2010 at 08:48:47PM -0600, DRC wrote: > On 9/2/10 9:50 AM, Adam Tkac wrote: > > This type is, by default, disabled on the server. It must be enabled > > via commandline parameter (-SecurityTypes). Client has it disabled as > > well but if user specify he wants to use it (and server h

Re: [Tigervnc-devel] [PATCH] Pam based Plain implementation

On Thu, Sep 02, 2010 at 04:14:20PM +0200, Adam Tkac wrote: > On Thu, Sep 02, 2010 at 09:05:54AM +0200, Martin Koegler wrote: > > Signed-off-by: Martin Koegler > > --- > > > > Windows password validator is contained in the VeNCrypt sources. > > Ok, I will port it to TigerVNC. > > *Plain implemen

Re: [Tigervnc-devel] [PATCH] Workaround for older gnutls

On Thu, Sep 02, 2010 at 10:42:17AM +0200, Adam Tkac wrote: > On Thu, Sep 02, 2010 at 09:05:52AM +0200, Martin Koegler wrote: > > Signed-off-by: Martin Koegler > > --- > > configure.ac |2 ++ > > 1 files changed, 2 insertions(+), 0 deletions(-) > > May I ask you which version of GNUTLS is old

Re: [Tigervnc-devel] [PATCH] Implement Plain in the client

On 9/2/10 9:50 AM, Adam Tkac wrote: > This type is, by default, disabled on the server. It must be enabled > via commandline parameter (-SecurityTypes). Client has it disabled as > well but if user specify he wants to use it (and server has Plain type > enabled) then it is used. If it is client's f

Re: [Tigervnc-devel] [PATCH] Implement Plain in the client

On Thu, Sep 02, 2010 at 09:18:15AM -0600, DRC wrote: > On 9/2/10 6:37 AM, Adam Tkac wrote: > > I would rather disable "Plain" type by default because it is real > > security hazard. I've commited your patch without "Plain" in the > > default list. User can manually select it. > > > > Rest of the pa

Re: [Tigervnc-devel] [PATCH] Implement Plain in the client

On 9/2/10 6:37 AM, Adam Tkac wrote: > I would rather disable "Plain" type by default because it is real > security hazard. I've commited your patch without "Plain" in the > default list. User can manually select it. > > Rest of the patch is OK, I've commited it as r4127. Thank you very > much. I h

Re: [Tigervnc-devel] [PATCH] Pam based Plain implementation

On Thu, Sep 02, 2010 at 09:05:54AM +0200, Martin Koegler wrote: > Signed-off-by: Martin Koegler > --- > > Windows password validator is contained in the VeNCrypt sources. Ok, I will port it to TigerVNC. *Plain implementation with PAM support has been commited as r4128 with little improvements,

Re: [Tigervnc-devel] [PATCH] Implement Plain in the client

On Thu, Sep 02, 2010 at 09:05:53AM +0200, Martin Koegler wrote: > diff --git a/common/rfb/Security.cxx b/common/rfb/Security.cxx > index 71e45de..708c10a 100644 > --- a/common/rfb/Security.cxx > +++ b/common/rfb/Security.cxx > @@ -31,6 +31,7 @@ > #include > #include > #include > +#include >

Re: [Tigervnc-devel] [PATCH] Workaround for older gnutls

On Thu, Sep 02, 2010 at 09:05:52AM +0200, Martin Koegler wrote: > Signed-off-by: Martin Koegler > --- > configure.ac |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) May I ask you which version of GNUTLS is old, please? Did you check this change doesn't break later gnutls_error_is_f

[Tigervnc-devel] [PATCH] Workaround for older gnutls

Signed-off-by: Martin Koegler --- configure.ac |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/configure.ac b/configure.ac index 5acd762..f6dfc10 100644 --- a/configure.ac +++ b/configure.ac @@ -78,6 +78,8 @@ if test "x$enable_gnutls" = xyes; then AC_CHECK_LIB([g

[Tigervnc-devel] [PATCH] Implement Plain in the client

Signed-off-by: Martin Koegler --- common/rfb/CSecurityPlain.cxx | 46 + common/rfb/CSecurityPlain.h | 36 common/rfb/Makefile.am|4 +- common/rfb/Security.cxx | 10 - 4 files changed, 93 ins

[Tigervnc-devel] [PATCH] Pam based Plain implementation

Signed-off-by: Martin Koegler --- Windows password validator is contained in the VeNCrypt sources. common/rfb/Makefile.am |5 ++ common/rfb/Security.cxx | 21 +++ common/rfb/Security.h|3 + common/rfb/UnixPasswordValidator.cxx | 42