Re: patch for tmux on cygwin

2013-05-18 Thread J Raynor
I've attached a new patch. TTY_NAME_MAX is already defined in compat.h, so I didn't need to add it. Gcc didn't define _WIN32, so I used __CYGWIN__ instead. Regarding this: > You should probably fail early if isatty is false (before filling in ttyname > into the identify struct). I believe isa

Re: patch for tmux on cygwin

2013-05-18 Thread Nicholas Marriott
On Sat, May 18, 2013 at 03:35:44AM -0500, J Raynor wrote: > The patch I had sent in was meant for testing, and to see if there was > any interest, so I wasn't putting any effort into getting it into > shape for acceptance. Now that that might be possible, I'll get it > cleaned up, taking into acco

Re: patch for tmux on cygwin

2013-05-18 Thread J Raynor
The patch I had sent in was meant for testing, and to see if there was any interest, so I wasn't putting any effort into getting it into shape for acceptance. Now that that might be possible, I'll get it cleaned up, taking into account your notes. > I guess this obviously won't let other things

Re: patch for tmux on cygwin

2013-05-18 Thread Nicholas Marriott
Thanks - this looks much better, we can probably do something with this. I guess this obviously won't let other things that need file descriptor passing work like "loadb -" or "saveb -". A few things: Why do you need to dup stdin in the client? Can you replace cyg_get_identify_fd by just puttin