Re: Found it - WAS: Memory leak

2004-01-16 Thread David Strupl
A bit off-topic here but: Filip Hanik wrote: I'll try the fix since I am still on the eval period of the profilers :) Check my posts on the tomcat users mailing list. I have also found the leak by using free tools: IBM JDK + HeapRoots http://alphaworks.ibm.com/tech/heaproots Might help after

Re: Found it - WAS: Memory leak

2004-01-15 Thread Remy Maucherat
Filip Hanik wrote: Ok, I think I nailed it. There is a memory leak in Tomcat 5. I downloaded a trial of JProbe (they should provide free licenses for open source! :) There is a class called o.a.coyote.RequestGroupInfo.java, in that class there is a method called addRequestProcessor. This method

Re: Found it - WAS: Memory leak

2004-01-15 Thread Remy Maucherat
Bill Barker wrote: I'd be in favor of just dropping RequestInfo and RequestGroupInfo altogether (and provide RequestListener commented out in web.xml that does the same thing). Then people that want this can still get Request stats via JMX (which I might use on a development site, but never on a

Re: Found it - WAS: Memory leak

2004-01-15 Thread Remy Maucherat
Remy Maucherat wrote: -1. There is no memory leak with this. ByteChunks/CharChunks are always reused. If new ones are created, they will be reused. Arg, I have to find something. I know ! It's all Costin's fault ! I didn't think about the scaling back feature of the thread pool, to be honest. It

RE: Found it - WAS: Memory leak

2004-01-15 Thread Shapira, Yoav
Developers List Subject: Re: Found it - WAS: Memory leak I'd be in favor of just dropping RequestInfo and RequestGroupInfo altogether (and provide RequestListener commented out in web.xml that does the same thing). Then people that want this can still get Request stats via JMX (which I might use

Re: Found it - WAS: Memory leak

2004-01-15 Thread Remy Maucherat
Shapira, Yoav wrote: Howdy, +1 one having a RequestListener -- I've been looking for a non-trivial example to write and ship along with tomcat! -0. This kind of stuff is already in the servlet API to some extent, and all these event notifications will likely introduce overhead. This looks like a

RE: Found it - WAS: Memory leak

2004-01-15 Thread Filip Hanik
[mailto:[EMAIL PROTECTED] Sent: Thursday, January 15, 2004 12:28 AM To: Tomcat Developers List Subject: Re: Found it - WAS: Memory leak Bill Barker wrote: I'd be in favor of just dropping RequestInfo and RequestGroupInfo altogether (and provide RequestListener commented out in web.xml

Re: Found it - WAS: Memory leak

2004-01-15 Thread Remy Maucherat
Filip Hanik wrote: dude, I spent hours on this yesterday with a profiler...how about giving in a little bit :) the leak is pretty bad, I ran up to 512MB in hours of heavy load. For one, I couldn't reproduce the problem. I had to use my imagination and saw that there was an issue when the thread

RE: Found it - WAS: Memory leak

2004-01-15 Thread Filip Hanik
PROTECTED] Sent: Thursday, January 15, 2004 5:24 AM To: Tomcat Developers List Subject: Re: Found it - WAS: Memory leak Remy Maucherat wrote: -1. There is no memory leak with this. ByteChunks/CharChunks are always reused. If new ones are created, they will be reused. Arg, I have to find something

Re: Found it - WAS: Memory leak

2004-01-15 Thread Jess Holle
-Original Message- From: Remy Maucherat [mailto:[EMAIL PROTECTED] Sent: Thursday, January 15, 2004 5:24 AM To: Tomcat Developers List Subject: Re: Found it - WAS: Memory leak Remy Maucherat wrote: -1. There is no memory leak with this. ByteChunks/CharChunks are always reused. If new ones

RE: Found it - WAS: Memory leak

2004-01-15 Thread Filip Hanik
Message- From: Remy Maucherat [mailto:[EMAIL PROTECTED] Sent: Thursday, January 15, 2004 9:41 AM To: Tomcat Developers List Subject: Re: Found it - WAS: Memory leak Filip Hanik wrote: dude, I spent hours on this yesterday with a profiler...how about giving in a little bit :) the leak

Re: Found it - WAS: Memory leak

2004-01-15 Thread Remy Maucherat
Filip Hanik wrote: I ran HTTP client on windows, Tomcat on RH8 AND RH9, both of them have the leak. I ran tomcat through both OptimizeIt and JProbe yesterday, and both of them showed the leak. it should be very easy to reproduce, you just have to be patient...it takes time for the memory to grow,

Re: Found it - WAS: Memory leak

2004-01-15 Thread Filip Hanik
I'll try the fix since I am still on the eval period of the profilers :) thanks Filip - Original Message - From: Remy Maucherat [EMAIL PROTECTED] To: Tomcat Developers List [EMAIL PROTECTED] Sent: Thursday, January 15, 2004 9:56 AM Subject: Re: Found it - WAS: Memory leak Filip Hanik

Re: Found it - WAS: Memory leak

2004-01-15 Thread Remy Maucherat
Filip Hanik wrote: I'll try the fix since I am still on the eval period of the profilers :) Cool :) (crossing all fingers) You know there's also that tomcat-committers mailing list for the issues that make people nervous (security, etc) ;) Rémy

Re: Found it - WAS: Memory leak

2004-01-15 Thread Filip Hanik
From: Remy Maucherat [EMAIL PROTECTED] Filip Hanik wrote: I'll try the fix since I am still on the eval period of the profilers :) Cool :) (crossing all fingers) You know there's also that tomcat-committers mailing list for the issues that make people nervous (security, etc) ;) no, I

Re: Found it - WAS: Memory leak

2004-01-15 Thread Bill Barker
- Original Message - From: Remy Maucherat [EMAIL PROTECTED] To: Tomcat Developers List [EMAIL PROTECTED] Sent: Thursday, January 15, 2004 5:24 AM Subject: Re: Found it - WAS: Memory leak Remy Maucherat wrote: -1. There is no memory leak with this. ByteChunks/CharChunks are always

Re: Found it - WAS: Memory leak

2004-01-15 Thread Remy Maucherat
Bill Barker wrote: Remy Maucherat wrote: -1. There is no memory leak with this. ByteChunks/CharChunks are always reused. If new ones are created, they will be reused. Arg, I have to find something. I know ! It's all Costin's fault ! I didn't think about the scaling back feature of the thread

Re: Found it - WAS: Memory leak

2004-01-15 Thread Bill Barker
- Original Message - From: Remy Maucherat [EMAIL PROTECTED] To: Tomcat Developers List [EMAIL PROTECTED] Sent: Thursday, January 15, 2004 11:41 AM Subject: Re: Found it - WAS: Memory leak Bill Barker wrote: Remy Maucherat wrote: -1. There is no memory leak with this. ByteChunks

Re: Found it - WAS: Memory leak

2004-01-15 Thread Remy Maucherat
Bill Barker wrote: I'm almost certain JK doesn't register the RequestInfo objects. It should (and it's a bug), but actually it doesn't. I tried to have the status servlet work with JK also, and had partial fixes, but in the end, I didn't find the feature too worthwhile (and my fixes were hacks),

Re: Found it - WAS: Memory leak

2004-01-15 Thread Filip Hanik
setting maxSpareThreads==minSpareThreads==maxThreads does take care of the memory leak with the new code, however, going with the default server.xml settings, tomcat is still leaking memory. I will delve into this when I get home tonight, that is when I have access to the profiler. have a good

Re: Found it - WAS: Memory leak

2004-01-15 Thread Bill Barker
- Original Message - From: Remy Maucherat [EMAIL PROTECTED] To: Tomcat Developers List [EMAIL PROTECTED] Sent: Thursday, January 15, 2004 12:33 PM Subject: Re: Found it - WAS: Memory leak Bill Barker wrote: I'm almost certain JK doesn't register the RequestInfo objects. It should

Found it - WAS: Memory leak

2004-01-14 Thread Filip Hanik
Ok, I think I nailed it. There is a memory leak in Tomcat 5. I downloaded a trial of JProbe (they should provide free licenses for open source! :) There is a class called o.a.coyote.RequestGroupInfo.java, in that class there is a method called addRequestProcessor. This method stores a reference

Re: Found it - WAS: Memory leak

2004-01-14 Thread Bill Barker
:). - Original Message - From: Filip Hanik [EMAIL PROTECTED] To: Tomcat Developers List [EMAIL PROTECTED] Sent: Wednesday, January 14, 2004 6:47 PM Subject: Found it - WAS: Memory leak Ok, I think I nailed it. There is a memory leak in Tomcat 5. I downloaded a trial of JProbe

RE: Found it - WAS: Memory leak

2004-01-14 Thread Filip Hanik
:) Filip -Original Message- From: Bill Barker [mailto:[EMAIL PROTECTED] Sent: Wednesday, January 14, 2004 8:07 PM To: Tomcat Developers List Subject: Re: Found it - WAS: Memory leak I'd be in favor of just dropping RequestInfo and RequestGroupInfo altogether (and provide RequestListener