Re: Post B6 modifications...

2001-07-23 Thread Pier P. Fumagalli
Remy Maucherat at [EMAIL PROTECTED] wrote: > >> * I like symmetry :-), so shouldn't there also be some sort of >> shutdown() method that is called after stop() that corresponds to >> initialize() being called before start()? > > Ok, but it wouldn't be that useful. I don't know... If Service

Re: Post B6 modifications...

2001-07-23 Thread Pier P. Fumagalli
Craig R. McClanahan at [EMAIL PROTECTED] wrote: > > I do have two design quibbles: > > * The initialize() method you added throws LifecycleException, but you > are not using the remainder of the Lifecycle family of APIs. This is > not particularly clean, and the obvious answer would be to exten

Re: Post B6 modifications...

2001-07-23 Thread Remy Maucherat
> On Fri, 20 Jul 2001, Pier P. Fumagalli wrote: > > > > > This patch actually starts fixing things, but doesn't break the build > > neither compromises functionality (checked it already), but I would like > > someone (Craig/Remy/Amy/Glenn...) to review it and, if ok, apply it... > > > > I do have

Re: Post B6 modifications...

2001-07-23 Thread Craig R. McClanahan
On Fri, 20 Jul 2001, Pier P. Fumagalli wrote: > > This patch actually starts fixing things, but doesn't break the build > neither compromises functionality (checked it already), but I would like > someone (Craig/Remy/Amy/Glenn...) to review it and, if ok, apply it... > I do have two design q

Re: Post B6 modifications...

2001-07-22 Thread Pier P. Fumagalli
Remy Maucherat at [EMAIL PROTECTED] wrote: >> Remy Maucherat at [EMAIL PROTECTED] wrote: >> >>> http://www.alexandriasc.com/software/JavaService/license.html >> >> It's a post-2000 BSD... We don't have to alter the copyright, but we can >> included it without any other legal matter... Probably

Re: Post B6 modifications...

2001-07-22 Thread Remy Maucherat
> Remy Maucherat at [EMAIL PROTECTED] wrote: > > > http://www.alexandriasc.com/software/JavaService/license.html > > It's a post-2000 BSD... We don't have to alter the copyright, but we can > included it without any other legal matter... Probably the best would be to > start modifying their source

Re: Post B6 modifications...

2001-07-22 Thread Pier P. Fumagalli
Elijah Roberts at [EMAIL PROTECTED] wrote: > > I'd be happy to donate the code, if you want. Just let me know what, if > anything, I need to do. Oh, that's great, I didn't figure out you were on the Mailing List... To give you a little background, I wrote the Service stuff in Tomcat 4.0 to allo

RE: Post B6 modifications...

2001-07-22 Thread Kevin Seguin
> > http://www.alexandriasc.com/software/JavaService/license.html > > It's a post-2000 BSD... We don't have to alter the copyright, > but we can > included it without any other legal matter... Probably the > best would be to > start modifying their sources and update them to our model, > while

Re: Post B6 modifications...

2001-07-22 Thread Pier P. Fumagalli
Pier P. Fumagalli at [EMAIL PROTECTED] wrote: > Pier P. Fumagalli at [EMAIL PROTECTED] wrote: >> Remy Maucherat at [EMAIL PROTECTED] wrote: >> >>> Could you avoid the tabs next time ? Even Craig stopped it in TC 4.0 ;-) >> >> Fuck, I forgot to preprocess the files Doin' it right now :) > >

Re: Post B6 modifications...

2001-07-22 Thread Pier P. Fumagalli
Remy Maucherat at [EMAIL PROTECTED] wrote: > http://www.alexandriasc.com/software/JavaService/license.html It's a post-2000 BSD... We don't have to alter the copyright, but we can included it without any other legal matter... Probably the best would be to start modifying their sources and update

Re: Post B6 modifications...

2001-07-22 Thread Elijah Roberts
On Sunday July 22, 2001 Remy Maucherat wrote: > > > Yes, but BSD != Apache, so I don't think we can cut & paste unless they > > > agree to donate the code ;-) > > > You can try talking to them. I just asked them the permission to > integrate a > > > binary, which they gladly gave me (although the

Re: Post B6 modifications...

2001-07-22 Thread Remy Maucherat
> Remy Maucherat at [EMAIL PROTECTED] wrote: > > > >> Wasn't it BSD? > > > > Yes, but BSD != Apache, so I don't think we can cut & paste unless they > > agree to donate the code ;-) > > You can try talking to them. I just asked them the permission to integrate a > > binary, which they gladly gave

Re: Post B6 modifications...

2001-07-22 Thread Pier P. Fumagalli
Remy Maucherat at [EMAIL PROTECTED] wrote: > >> Wasn't it BSD? > > Yes, but BSD != Apache, so I don't think we can cut & paste unless they > agree to donate the code ;-) > You can try talking to them. I just asked them the permission to integrate a > binary, which they gladly gave me (although th

Re: Post B6 modifications...

2001-07-22 Thread Remy Maucherat
> Remy Maucherat at [EMAIL PROTECTED] wrote: > > > > [...] > > Actually, I think it's ok, esp since you didn't change the Container > > interface (that would have been a lot of trouble). > > Yeah, didn't want to create that many troubles... > > > Could you avoid the tabs next time ? Even Craig sto

Re: Post B6 modifications...

2001-07-22 Thread Pier P. Fumagalli
Pier P. Fumagalli at [EMAIL PROTECTED] wrote: > Remy Maucherat at [EMAIL PROTECTED] wrote: > >> Could you avoid the tabs next time ? Even Craig stopped it in TC 4.0 ;-) > > Fuck, I forgot to preprocess the files Doin' it right now :) I'll run it over all catalina files... :) Pier

Re: Post B6 modifications...

2001-07-22 Thread Pier P. Fumagalli
Remy Maucherat at [EMAIL PROTECTED] wrote: > > [...] > Actually, I think it's ok, esp since you didn't change the Container > interface (that would have been a lot of trouble). Yeah, didn't want to create that many troubles... > Could you avoid the tabs next time ? Even Craig stopped it in TC 4

Re: Post B6 modifications...

2001-07-22 Thread Remy Maucherat
> Pier P. Fumagalli at [EMAIL PROTECTED] wrote: > > > This is the first set of modifications I made to the Catalina code to allow > > port < 1024 binding under Unix. Basically, I added an "initialize()" method > > to Server, Service and Connector, and that gets called appropriately before > > "sta

Re: Post B6 modifications...

2001-07-22 Thread Pier P. Fumagalli
Pier P. Fumagalli at [EMAIL PROTECTED] wrote: > This is the first set of modifications I made to the Catalina code to allow > port < 1024 binding under Unix. Basically, I added an "initialize()" method > to Server, Service and Connector, and that gets called appropriately before > "start()". Now,

Post B6 modifications...

2001-07-20 Thread Pier P. Fumagalli
This is the first set of modifications I made to the Catalina code to allow port < 1024 binding under Unix. Basically, I added an "initialize()" method to Server, Service and Connector, and that gets called appropriately before "start()". Now, the only thing left to do is to move the ServerSocket