Kin-Man Chung wrote:
I think your only valid point is the one about the need to make
errorOnUseBeanInvalidClassAttribute be switchable from Jspc main,
but we are not bundling jspc scripts anymore, so I didn't feel there
is a need for it. Anyway, its value can be set with an ant task.
Otherwise,
Jess Holle wrote:
I'm not arguing with the overall intent of your change. Rather I
believe that calling the constructor during compilation is wasteful and
improper as the environment *can* differ between compilation and
runtime. Also, the fact that a failure to compile in this fashion
I certainly know what a JavaBean is, Remy.
First, *any* constructor can fail and throw an exception due to any
number of factors -- including a JavaBean constructor.
Second, I did not write the beans in question. I'm simply seeking to
maintain reasonable resiliency in their handling. My
.
-Kin-man
Date: Tue, 30 Mar 2004 08:30:05 -0600
From: Jess Holle [EMAIL PROTECTED]
Subject: Re: Tomcat 5.0.20 Issue
To: Tomcat Developers List [EMAIL PROTECTED]
X-OriginalArrivalTime: 30 Mar 2004 14:30:06.0040 (UTC)
FILETIME=[7EEF4580:01C41663]
Kin-Man Chung wrote:
I think your only
Kin-Man Chung wrote:
Your test for bad beans is much weaker than what it is now. For instance,
you do not catch the case where the bean class is abstract.
Ah, yes, you are correct. That can also be easily checked with an
additional line of code, of course.
However, I am sympathetic to your
Jess Holle wrote:
Kin-Man Chung wrote:
Your test for bad beans is much weaker than what it is now. For
instance,
you do not catch the case where the bean class is abstract.
Ah, yes, you are correct. That can also be easily checked with an
additional line of code, of course.
However, I am
Jess Holle wrote:
Works just great in quick testing at least.
I'm still waiting for my precompilation script to return to determine
whether Jasper still compiles everything it used to (and should have).
Unfortunately, Tomcat 5.0.20 cannot compile 6 out our 985 JSP pages
(which Tomcat 5.0.19
Jess Holle wrote:
Jess Holle wrote:
Works just great in quick testing at least.
I'm still waiting for my precompilation script to return to determine
whether Jasper still compiles everything it used to (and should have).
Unfortunately, Tomcat 5.0.20 cannot compile 6 out our 985 JSP pages
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26444
-Tim
Jess Holle wrote:
Jess Holle wrote:
Unfortunately, Tomcat 5.0.20 cannot compile 6 out our 985 JSP pages
(which Tomcat 5.0.19 compiled just fine).
The issue can be traced directly to a single entry in the change log:
Add some
Remy Maucherat wrote:
Well, your pages are invalid. Really, I don't see what's so
mysterious: anything used in useBean must be a JavaBean.
This will not be fixed.
Did I miss something?
Are JavaBean default constructors required to succeed in any/all
environments?
Specifically are they
Based on the given bug id, I would propose a different implementation
than that found in 5.0.20.
Specifically I would suggest that Generator:
1. Try to load the given class.
2. Look up its default (no-args) constructor via reflection. [This
is the key part, look up the constructor but
P.S. Nothing in the quoted spec segments implies that the JSP compiler
should attempt to actually *instantiate* beans at compile time or expect
that that should work.
--
Jess Holle
Jess Holle wrote:
Based on the given bug id, I would propose a different implementation
than that found in
errorOnUseBeanInvalidClassAttribute to false there.
If you have ideas about how to modify Generator that works better, please
submit a patch, and I'll see if it can be incorporated.
-Kin-man
Date: Wed, 24 Mar 2004 09:50:43 -0600
From: Jess Holle [EMAIL PROTECTED]
Subject: Tomcat 5.0.20 Issue
13 matches
Mail list logo
