Re: [Tracker] Meson build instructions for Tracker

2017-04-09 Thread Philip Van Hoof
Hello Michael, I would agree with that. Just like it would be silly to ship the generated .o files in a source package. I think that, given that valac is a compiler like any other, the generated .c files should not be part of the dist tarball. Instead should the build-dependencies include a speci

Re: [Tracker] Meson build instructions for Tracker

2017-04-09 Thread Michael Biebl
2017-04-09 19:31 GMT+02:00 Philip Van Hoof : > I wonder if removing those .stamp files should be part of any > make-target that is ~ standard for packaging tooling? In my opinion > should such generated .c files share the rules of .o files. Well, that would defeat the point of shipping the generat

Re: [Tracker] Meson build instructions for Tracker

2017-04-09 Thread Philip Van Hoof
I wonder if removing those .stamp files should be part of any make-target that is ~ standard for packaging tooling? In my opinion should such generated .c files share the rules of .o files. On Sun, 2017-04-09 at 19:28 +0200, Michael Biebl wrote: > 2017-04-09 19:04 GMT+02:00 Philip Van Hoof : > > C

Re: [Tracker] Meson build instructions for Tracker

2017-04-09 Thread Michael Biebl
2017-04-09 19:04 GMT+02:00 Philip Van Hoof : > Correct. Is there anything holding you back from rerunning valac after > applying a patch during dpkg-buildpackage? No, not really. I guess I would just remove the vala.stamp files to force the regeneration of the .c files. That should be all that's n

Re: [Tracker] Meson build instructions for Tracker

2017-04-09 Thread Philip Van Hoof
On Sun, 2017-04-09 at 18:54 +0200, Michael Biebl wrote: > > Hmmrr. Patching .c files generated by valac sounds absurd. Is there ever > > a circumstance where you want to do that instead of patching the .vapi > > or .vala file? Because if you do, that sounds like a bug in valac > > instead. > Mayb

Re: [Tracker] Meson build instructions for Tracker

2017-04-09 Thread Michael Biebl
2017-04-09 17:36 GMT+02:00 Philip Van Hoof : > On Fri, 2017-03-31 at 00:32 +0200, Michael Biebl wrote: > >> You are right, there is indeed an issue with valac and reproducible builds: >> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=802528 >> >> I guess this should be fixed in vala proper thoug

Re: [Tracker] Meson build instructions for Tracker

2017-04-09 Thread Philip Van Hoof
On Fri, 2017-03-31 at 00:32 +0200, Michael Biebl wrote: > You are right, there is indeed an issue with valac and reproducible builds: > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=802528 > > I guess this should be fixed in vala proper though. nod. > Personally, I'm not a huge fan of shipp