Re: [twsocket] Did I find a bug in THttpCli? (Beta fix availablefor download)

2012-12-31 Thread Arno Garrels
Arno Garrels wrote: > Here is a fix that is briefly tested once without proxy > and once with squid proxy and NTLM authentication in V8 only: > http://delphi.duodata.de/archive/OverbyteIcsHttpProtV7-V8.zip > These units are based on latest svn revision. > Please let us know how it works for you (yo

Re: [twsocket] Did I find a bug in THttpCli? (Beta fix available for download)

2012-12-17 Thread Albert Wiersch
> Arno Garrels wrote: > > Well, I should have said "not enough spare time to test it very > carefully" Here is a fix that is briefly tested once without proxy > and once with squid proxy and NTLM authentication in V8 only: > http://delphi.duodata.de/archive/OverbyteIcsHttpProtV7-V8.zip > These uni

Re: [twsocket] Did I find a bug in THttpCli? (Beta fix available for download)

2012-12-15 Thread Arno Garrels
Arno Garrels wrote: > There are just two 'small' bugs: > 1) property Location doesn't include the port number and> 2) the Host header > lacks the port number as well which is the > reason why your php script reports port 80 though the client > actually is connected to port 8080. > > The fix in st

Re: [twsocket] Did I find a bug in THttpCli?

2012-12-12 Thread RTT
A quick fix that seems to correct the issue is to add a FTargetPort:= FPort to the procedure THttpCli.StartRelocation in the OverbyteIcsHttpProt unit. procedure THttpCli.StartRelocation; ... CleanupSendStream; LoginDelayed; end else begin +FTargetPort:= FPo

Re: [twsocket] Did I find a bug in THttpCli?

2012-12-12 Thread Albert Wiersch
> Please read my previous messages in TWSocket. There are just > two 'small' bugs: > 1) property Location doesn't include the port number and > 2) the Host header lacks the port number as well which is the > reason why your php script reports port 80 though the client > actually is connected to po

Re: [twsocket] Did I find a bug in THttpCli?

2012-12-12 Thread Arno Garrels
Albert Wiersch wrote: > Hi Arno, > > I tested with the ICS-V7 snapshot here: > http://wiki.overbyte.be/wiki/index.php/ICS_Download > > And it didn't work. It requested port 80 when it should have > requested port 8080. It works as expected in Firefox. Please read my previous messages in TWSocket

Re: [twsocket] Did I find a bug in THttpCli?

2012-12-11 Thread RTT
On 11-12-2012 17:30, Arno Garrels wrote: - Original Message - From: "RTT" To: "ICS support mailing" Sent: Tuesday, December 11, 2012 5:59 PM Subject: Re: [twsocket] Did I find a bug in THttpCli? The port after the redirect is the correct 8080. I just don&

Re: [twsocket] Did I find a bug in THttpCli?

2012-12-11 Thread Arno Garrels
- Original Message - From: "Angus Robertson - Magenta Systems Ltd" To: Sent: Tuesday, December 11, 2012 6:33 PM Subject: Re: [twsocket] Did I find a bug in THttpCli? >> Before you try to fix/break something that works, I urge you to >> check with Wireshark that

Re: [twsocket] Did I find a bug in THttpCli?

2012-12-11 Thread Angus Robertson - Magenta Systems Ltd
> Before you try to fix/break something that works, I urge you to > check with Wireshark that the redirection works as expected to port > number 8080, the only problem I see so far is property Location > should likely include the port number in this test case. The first thing I'll do is fix the

Re: [twsocket] Did I find a bug in THttpCli?

2012-12-11 Thread Arno Garrels
- Original Message - From: "RTT" To: "ICS support mailing" Sent: Tuesday, December 11, 2012 5:59 PM Subject: Re: [twsocket] Did I find a bug in THttpCli? > The port after the redirect is the correct 8080. I > just don't understand why the document r

Re: [twsocket] Did I find a bug in THttpCli?

2012-12-11 Thread RTT
On 11-12-2012 16:38, Arno Garrels wrote: - Original Message - From: "Angus Robertson - Magenta Systems Ltd" To: Sent: Tuesday, December 11, 2012 5:25 PM Subject: Re: [twsocket] Did I find a bug in THttpCli? If you GET this URL: http://www.htmlvalidator.com/test/co

Re: [twsocket] Did I find a bug in THttpCli?

2012-12-11 Thread Arno Garrels
- Original Message - From: "Angus Robertson - Magenta Systems Ltd" To: Sent: Tuesday, December 11, 2012 5:25 PM Subject: Re: [twsocket] Did I find a bug in THttpCli? >> If you GET this URL: >> http://www.htmlvalidator.com/test/cookies/test-redirect.php >&

Re: [twsocket] Did I find a bug in THttpCli?

2012-12-11 Thread Angus Robertson - Magenta Systems Ltd
> If you GET this URL: > http://www.htmlvalidator.com/test/cookies/test-redirect.php > > Then you get "Server port is 80." with the ICS demo, but put the > same URL in a browser and you get "Server port is 8080." I have reproduced this using the ICS browser demo, which is useful for testing stuf

Re: [twsocket] Did I find a bug in THttpCli?

2012-12-10 Thread Albert Wiersch
ecember 10, 2012 10:40 AM > To: ICS support mailing > Subject: Re: [twsocket] Did I find a bug in THttpCli? > > > I tested with current ICSv8/v7 and it works perfectly (checked with > Wireshark). > > The only problem is that property Location doesn't include the non-de

Re: [twsocket] Did I find a bug in THttpCli?

2012-12-10 Thread RTT
I tested with current ICSv8/v7 and it works perfectly (checked with Wireshark). The only problem is that property Location doesn't include the non-default port number. A workaround would be to get the Location header manually. In a browser I get an html that says: Server port is 8080. With ICS

Re: [twsocket] Did I find a bug in THttpCli?

2012-12-10 Thread Arno Garrels
Albert Wiersch wrote: >> From: twsocket-boun...@elists.org >> [mailto:twsocket-boun...@elists.org] On Behalf Of Arno Garrels >> >> If you just recognized that string property Location doesn't include >> the port number then that might be a bug. However relocation works >> without problem for me wi

Re: [twsocket] Did I find a bug in THttpCli?

2012-12-10 Thread Albert Wiersch
> From: twsocket-boun...@elists.org [mailto:twsocket-boun...@elists.org] On > Behalf Of Arno Garrels > > If you just recognized that string property Location doesn't include the > port number then that might be a bug. However relocation works without > problem for me with the OverbyteIcsWebServ de

Re: [twsocket] Did I find a bug in THttpCli?

2012-12-08 Thread Arno Garrels
Albert Wiersch wrote: > If a request is redirected and contains a port number, then it seems > that the new request drops the port number. If you just recognized that string property Location doesn't include the port number then that might be a bug. However relocation works without problem for me

[twsocket] Did I find a bug in THttpCli?

2012-12-07 Thread Albert Wiersch
If a request is redirected and contains a port number, then it seems that the new request drops the port number. In the below example, the request is redirected to "http://www.htmlvalidator.com:8080/test/cookies/test-redirect2.php";, but HttpCli1->Location seems to drop the port number. Is this