Re: [PATCH 1/2] efi_loader: move load options to new module

2021-01-18 Thread Ilias Apalodimas
Hi Heinrich, Overall the patch and idea seem fine. Would it make sense to name the file differently? Something similar to what I did on my initrd patches, i.e efi_helper.c, so we can start adding helper functions that have a wider usage? Thanks /Ilias On Fri, Jan 15, 2021 at 07:02:49PM +0100,

RE: [PATCH 4/4] board: keymile: add support for seli8 design based on nxp ls102x soc

2021-01-18 Thread Priyanka Jain (OSS)
>-Original Message- >From: U-Boot On Behalf Of Aleksandar >Gerasimovski >Sent: Wednesday, January 13, 2021 9:51 PM >To: u-boot@lists.denx.de >Cc: Valentin Longchamp ; Holger >Brunck ; Rainer Boschung >; Matteo Ghidoni > >Subject: [PATCH 4/4] board: keymile: add support for seli8 design

RE: [PATCH 3/4] board: keymile: common: fix pnvramaddr and varaddr address calculation

2021-01-18 Thread Priyanka Jain (OSS)
>-Original Message- >From: U-Boot On Behalf Of Aleksandar >Gerasimovski >Sent: Wednesday, January 13, 2021 9:51 PM >To: u-boot@lists.denx.de >Cc: Valentin Longchamp ; Holger >Brunck ; Rainer Boschung >; Matteo Ghidoni > >Subject: [PATCH 3/4] board: keymile: common: fix pnvramaddr and

RE: [v2 01/33] gpio: mpc8xxx_gpio: fix a bug on ls1046ardb

2021-01-18 Thread Priyanka Jain (OSS)
>-Original Message- >From: U-Boot On Behalf Of Biwen Li >Sent: Tuesday, December 8, 2020 2:29 PM >To: Priyanka Jain >Cc: Jiafei Pan ; u-boot@lists.denx.de; Xiaobo Xie >; Biwen Li >Subject: [v2 01/33] gpio: mpc8xxx_gpio: fix a bug on ls1046ardb > >From: Biwen Li > Please provide summary

Re: [PATCH 1/1] dm: core: describe uclass_root_s

2021-01-18 Thread Heinrich Schuchardt
Am 19. Januar 2021 01:49:28 MEZ schrieb Simon Glass : >Hi Bin, > >On Sat, 16 Jan 2021 at 03:59, Bin Meng wrote: >> >> On Sat, Jan 16, 2021 at 6:13 PM Heinrich Schuchardt > wrote: >> > >> > make htmldocs creates a warning: >> > >> > ./include/asm-generic/global_data.h:443: >> > warning: Function

Re: [linux-sunxi] [PATCH] sunxi: Properly check for SATAPWR and MACPWR

2021-01-18 Thread Samuel Holland
On 1/18/21 7:05 PM, Andre Przywara wrote: > The #ifdef CONFIG_xxxPWR conditionals were not working as expected, as > string Kconfig symbols are always "defined" from the preprocessor's > perspective. This lead to unnecessary calls to the GPIO routines, but > also always added a half a second delay

RE: [PATCH 2/2] arm64: dts: imx8mm-beacon: Resync imx8mm-beacon-som with 5.11-rc4

2021-01-18 Thread Peng Fan
> Subject: [PATCH 2/2] arm64: dts: imx8mm-beacon: Resync > imx8mm-beacon-som with 5.11-rc4 > > In order to support the QSPI chip on the SOM, the Flexspi bus needs to be > configured to talk with the SPI chip. > Resync the som device tree with 5.11-rc4 > > Signed-off-by: Adam Ford > > diff

RE: [PATCH 1/2] imx8mm_beacon: Enable QSPI Support

2021-01-18 Thread Peng Fan
> Subject: [PATCH 1/2] imx8mm_beacon: Enable QSPI Support > > There is a QSPI chip connected to the FSPI. Enable the defconfig to support > it. > > Signed-off-by: Adam Ford Reviewed-by: Peng Fan > > diff --git a/configs/imx8mm_beacon_defconfig > b/configs/imx8mm_beacon_defconfig index

RE: [PATCH 1/3] clk: imx: Add ECSPI to iMX8MN

2021-01-18 Thread Peng Fan
> Subject: [PATCH 1/3] clk: imx: Add ECSPI to iMX8MN > > Add ECSPI clock entries to iMX8MN clock driver. Only make those entries > available in case SPI support in U-Boot is enabled at all to conserve space, > esp. > in SPL. > > Signed-off-by: Marek Vasut > Cc: Peng Fan > Cc: Stefano Babic >

[PATCH] sunxi: Properly check for SATAPWR and MACPWR

2021-01-18 Thread Andre Przywara
The #ifdef CONFIG_xxxPWR conditionals were not working as expected, as string Kconfig symbols are always "defined" from the preprocessor's perspective. This lead to unnecessary calls to the GPIO routines, but also always added a half a second delay to wait for a SATA disk to power up. Many thanks

Re: [PATCH] sunxi: don't define MACPWR and SATAPWR to empty strings

2021-01-18 Thread Andre Przywara
On 18/01/2021 00:18, Peter Robinson wrote: Hi Peter, > There's checks in board/sunxi/board.c if either MACPWR or SATAPWR are > defined and they are defined by default to a empty string which means > on vast majority of AllWinner boards when they're not required the > code is still run and with

Re: [PATCH v4 01/23] mips: dts: switch to board defines for dtb for mtmips

2021-01-18 Thread Weijie Gao
On Mon, 2021-01-18 at 22:43 +0100, Daniel Schwierzeck wrote: > Am Montag, den 18.01.2021, 15:54 +0800 schrieb Weijie Gao: > > On Fri, 2020-11-27 at 21:19 +0100, Daniel Schwierzeck wrote: > > > Am Donnerstag, den 12.11.2020, 16:35 +0800 schrieb Weijie Gao: > > > > Previous the dts files for

Re: [PATCH 1/1] dm: core: describe uclass_root_s

2021-01-18 Thread Simon Glass
Hi Bin, On Sat, 16 Jan 2021 at 03:59, Bin Meng wrote: > > On Sat, Jan 16, 2021 at 6:13 PM Heinrich Schuchardt > wrote: > > > > make htmldocs creates a warning: > > > > ./include/asm-generic/global_data.h:443: > > warning: Function parameter or member 'uclass_root_s' > > not described in

Re: Invitation: Regular U-Boot video call (Tuesday 19th)

2021-01-18 Thread Simon Glass
Hi Bin, On Sun, 17 Jan 2021 at 21:41, Bin Meng wrote: > > Hi Simon, > > On Sat, Jan 16, 2021 at 3:24 PM Peng Fan wrote: > > > > Hi Simon, > > > > > Subject: Re: Invitation: Regular U-Boot video call (Tuesday 19th) > > > > > > Hi Peng, > > > > > > On Thu, 14 Jan 2021 at 18:33, Peng Fan wrote: >

[PATCH 3/3] spi: imx: Use clock framework if enabled

2021-01-18 Thread Marek Vasut
In case the clock framework is enabled, enable the SPI controller clock and obtain max frequency from the clock framework. Signed-off-by: Marek Vasut Cc: Jagan Teki Cc: Stefano Babic --- drivers/spi/mxc_spi.c | 12 1 file changed, 12 insertions(+) diff --git

[PATCH 2/3] spi: imx: Define register bits in the driver

2021-01-18 Thread Marek Vasut
The CSPI/ECSPI register bits do not differ between newer SoCs, instead of having multiple copies of the same thing for each iMX SoC, define the bits in the driver. Signed-off-by: Marek Vasut Cc: Jagan Teki Cc: Stefano Babic --- arch/arm/include/asm/arch-mx25/imx-regs.h | 30 -

[PATCH 1/3] clk: imx: Add ECSPI to iMX8MN

2021-01-18 Thread Marek Vasut
Add ECSPI clock entries to iMX8MN clock driver. Only make those entries available in case SPI support in U-Boot is enabled at all to conserve space, esp. in SPL. Signed-off-by: Marek Vasut Cc: Peng Fan Cc: Stefano Babic --- drivers/clk/imx/clk-imx8mn.c | 29 + 1

[PATCH] net: fec: Get rid of FEC_ENET_ENABLE_[TR]XC_DELAY

2021-01-18 Thread Marek Vasut
The FEC_ENET_ENABLE_.XC_DELAY setting is only used by one system which supports OF control, correctly set the rgmii-id PHY mode in the DT and then determine whether or not to enable the FEC RXC/TXC internal delay based on the PHY mode. Signed-off-by: Marek Vasut Cc: Oleksandr Suvorov Cc:

[PATCH 3/3] spi: fsl_qspi: apply the same settings for LS1088 as LS208x

2021-01-18 Thread Mathew McBride
The LS1088 requires the same QUADSPI_QURIK_BASE_INTERNAL workaround as the LS208x and also has a 64 byte TX buffer. With the previous settings SPI-NAND reads over AHB were corrupted. Fixes: 91afd36f3802 ("spi: Transform the FSL QuadSPI driver to use the SPI MEM API") Signed-off-by: Mathew

[PATCH 2/3] spi: fsl_qspi: Ensure width is respected in spi-mem operations

2021-01-18 Thread Mathew McBride
Adapted from kernel commit b0177aca7aea From: Michael Walle Make use of a core helper to ensure the desired width is respected when calling spi-mem operators. Otherwise only the SPI controller will be matched with the flash chip, which might lead to wrong widths. Also consider the width

[PATCH 1/3] mem: spi-mem: define spi_mem_default_supports_op

2021-01-18 Thread Mathew McBride
spi_mem_default_supports_op is used internally by controller drivers to verify operation semantics are correct. Signed-off-by: Mathew McBride --- include/spi-mem.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/include/spi-mem.h b/include/spi-mem.h index ca0f55c8fd..92c640dabe

[PATCH 0/3] Fixes for SPI-NAND issues on LS1088A

2021-01-18 Thread Mathew McBride
This patchset resolves issues seen when using SPI-NAND with the LS1088A's qspi controller. The main issue seen is data corruption when reading SPI-NAND, due to a controller quirk not being applied. Using the same settings as the LS2088A (the bigger brother of LS1088A) solves this issue. In the

Re: [PATCH 04/15] gpio: Rename dm_gpio_get_dir_flags() to dm_gpio_get_flags()

2021-01-18 Thread Pratyush Yadav
On 15/01/21 07:04AM, Simon Glass wrote: > This function can be used to get any flags, not just direction flags. > Rename it to avoid confusion. > > Signed-off-by: Simon Glass > --- > > drivers/gpio/gpio-uclass.c | 2 +- > include/asm-generic/gpio.h | 4 ++-- > test/dm/gpio.c | 12

Re: [PATCH 03/15] dm: gpio: Rename get_dir_flags() method to get_flags()

2021-01-18 Thread Pratyush Yadav
On 15/01/21 07:04AM, Simon Glass wrote: > It is more useful to be able to read all the flags, not just the direction > ones. In fact this is what the STM32 driver does. Update the method name > to reflect this. > > Tweak the docs a little and use 'flagsp' as the return argument, as is > common in

Re: [PATCH v4 01/23] mips: dts: switch to board defines for dtb for mtmips

2021-01-18 Thread Daniel Schwierzeck
Am Montag, den 18.01.2021, 15:54 +0800 schrieb Weijie Gao: > On Fri, 2020-11-27 at 21:19 +0100, Daniel Schwierzeck wrote: > > Am Donnerstag, den 12.11.2020, 16:35 +0800 schrieb Weijie Gao: > > > Previous the dts files for gardena-smart-gateway-mt7688 and > > > linkit-smart-7688 are set to be built

[PATCH 2/2] arm64: dts: imx8mm-beacon: Resync imx8mm-beacon-som with 5.11-rc4

2021-01-18 Thread Adam Ford
In order to support the QSPI chip on the SOM, the Flexspi bus needs to be configured to talk with the SPI chip. Resync the som device tree with 5.11-rc4 Signed-off-by: Adam Ford diff --git a/arch/arm/dts/imx8mm-beacon-som.dtsi b/arch/arm/dts/imx8mm-beacon-som.dtsi index b88c3c99b0..d897913537

[PATCH 1/2] imx8mm_beacon: Enable QSPI Support

2021-01-18 Thread Adam Ford
There is a QSPI chip connected to the FSPI. Enable the defconfig to support it. Signed-off-by: Adam Ford diff --git a/configs/imx8mm_beacon_defconfig b/configs/imx8mm_beacon_defconfig index 49d5453078..2970e5dc71 100644 --- a/configs/imx8mm_beacon_defconfig +++

Re: [PATCH 02/15] dm: gpio: Rename set_dir_flags() method to update_flags()

2021-01-18 Thread Pratyush Yadav
Hi Simon, > Subject: [PATCH 02/15] dm: gpio: Rename set_dir_flags() method to > update_flags() Why not call it set_flags()? Matches up nicely with get_flags() in 03/15. On 15/01/21 07:04AM, Simon Glass wrote: > The current method is a misnomer since it is also used (e.g. by stm32) to > update

[PATCH 2/2] spi: nxp_fspi: Enable support for nxp,imx8mm-fspi

2021-01-18 Thread Adam Ford
The i.MX8M Mini can use the FlexSPI driver. Add support for it to the driver. Signed-off-by: Adam Ford diff --git a/drivers/spi/nxp_fspi.c b/drivers/spi/nxp_fspi.c index d74561578a..6c5bad4c2c 100644 --- a/drivers/spi/nxp_fspi.c +++ b/drivers/spi/nxp_fspi.c @@ -320,6 +320,14 @@ static const

[PATCH 1/2] spi: nxp_fspi: Fix error reporting

2021-01-18 Thread Adam Ford
On the i.MX8M Mini, ret = clk_set_rate() sets ret to the value of the rate the clock was able to set. When checking for errors, it only checks that it is not NULL. Since positive numbers are not errors, only check for negative numbers when handling errors. Fixes: 383fded70c4f ("spi: nxp_fspi:

[PATCH] configs: am335x_evm: enable CONFIG_SPL_ALLOC_BD

2021-01-18 Thread Dario Binacchi
With commit 38d6b7ebdaee ("spl: Drop bd_info in the data section") you need to enable this option to boot from mmc. Signed-off-by: Dario Binacchi --- configs/am335x_evm_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/am335x_evm_defconfig b/configs/am335x_evm_defconfig

Re: [PATCH 01/15] gpio: Disable functions not used with of-platdata

2021-01-18 Thread Pratyush Yadav
On 15/01/21 07:04AM, Simon Glass wrote: > These functions use devicetree and cannot wprl with of-platdata, which has Your right hand's offset is off by one ;-) > no runtime devicetree. > > If they are used, the current linker error is confusing,

[PATCH 1/1] doc: move README.menu to HTML documentation

2021-01-18 Thread Heinrich Schuchardt
Convert README.menu to reStructured text and add it to the HTML documentation. Signed-off-by: Heinrich Schuchardt --- doc/README.menu | 124 --- doc/develop/index.rst | 1 + doc/develop/menus.rst | 131 ++ 3

RE: IMX8MM SD UHS support

2021-01-18 Thread ZHIZHIKIN Andrey
Hello Tim, Sorry it took me quite some time to get this sorted out, but I believe I was able to identify an offending commit that is preventing the USDHC to switch to higher speed modes. It is in fact b5874b552f ("mmc: fsl_esdhc_imx: add wait_dat0() support"), reverting it makes SD Card to

Re: [PATCH] spi: zynqmp_gqspi: support dual and quad mode

2021-01-18 Thread Brandon Maier
On Mon, Jan 18, 2021 at 2:17 AM Michal Simek wrote: > > +Ashok fyi I pushed up a working branch to github[1] where I've cherry-picked commits from Xilinx/xlnx-u-boot for the zynqmp_gqspi.c, and resolved a couple conflicts. In addition it has a fix for the dual-parallel mode needed to work with

[PATCH 3/3] doc: move test/py/README.md to HTML documentation

2021-01-18 Thread Heinrich Schuchardt
Convert test/py/README.md to restructured text and add it to the generated HTML documentation. Signed-off-by: Heinrich Schuchardt --- doc/develop/index.rst | 1 + doc/develop/py_testing.rst | 426 + test/py/README.md | 389

[PATCH 2/3] doc: move test/README to HTML documentation

2021-01-18 Thread Heinrich Schuchardt
Move test/README to the 'Develop U-Boot' chapter of the HTML documentation. Signed-off-by: Heinrich Schuchardt --- doc/develop/index.rst | 1 + doc/develop/testing.rst | 96 + test/README | 96 - 3

[PATCH 1/3] doc: structure doc/develop/index.rst

2021-01-18 Thread Heinrich Schuchardt
Provide sub-chapters for 'Develop U-Boot' Signed-off-by: Heinrich Schuchardt --- doc/develop/index.rst | 22 +++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/doc/develop/index.rst b/doc/develop/index.rst index 0a7e204b34..b108df8e1b 100644 ---

[PATCH 0/3] move test related documentation to HTML

2021-01-18 Thread Heinrich Schuchardt
Restructure doc/develop/index.rst and move test related READMEs to the generated HTML documentation. Heinrich Schuchardt (3): doc: structure doc/develop/index.rst doc: move test/README to HTML documentation doc: move test/py/README.md to HTML documentation doc/develop/index.rst | 24

Re: [PULL] u-boot-sh/master

2021-01-18 Thread Tom Rini
On Mon, Jan 18, 2021 at 03:05:16PM +0100, Marek Vasut wrote: > The following changes since commit 14ea1b3635b4af8d9e283e3671f7ee872d50b859: > > Merge branch '2021-01-15-assorted-improvements' (2021-01-16 11:14:21 > -0500) > > are available in the Git repository at: > >

Re: Pull request: u-boot-riscv/master

2021-01-18 Thread Tom Rini
On Mon, Jan 18, 2021 at 02:55:46PM +0800, ub...@andestech.com wrote: > Hi Tom, > > Please pull some riscv updates: > > - Update qemu-riscv.rst build instructions. > - Add support for SPI on Kendryte K210. > - Add Microchip PolarFire SoC Icicle Kit support. > - Add support for an early timer. >

Re: Pull request for documentation tag doc-2021-04-rc1

2021-01-18 Thread Tom Rini
On Sat, Jan 16, 2021 at 07:03:28PM +0100, Heinrich Schuchardt wrote: > Dear Tom, > > The following changes since commit b0db69b4e1e1bf1109bd9d4a5185cbd4058f4a8b: > > dm: fix build errors generated by last merges (2021-01-15 13:12:38 -0500) > > are available in the Git repository at: > >

Re: [PATCH 4/7] s5p4418_nanopi2: Bring in some dead code

2021-01-18 Thread Stefan Bosch
Hi Simon, thanks a lot for your patch. I have just applied and tested it with the NanoPC-T2 board (is similar to the NanoPi2-board and therefore s5p4418_nanopi2_defconfig can be used). Unfortunately the bootl-cmd is not working out of the box: nanopi2# bootl FDT and ATAGS support not

Re: [PATCH v3 1/8] spl: fit: Drop 'length' argument to board_spl_fit_post_load()

2021-01-18 Thread Tom Rini
On Mon, Jan 18, 2021 at 10:28:45AM -0600, Alex G. wrote: > On 1/15/21 8:33 PM, Tom Rini wrote: > > On Wed, Dec 23, 2020 at 08:44:05AM -0600, Alexandru Gagniuc wrote: > > > > > The size is derived from the FIT image itself. Any alignment > > > requirements are machine-specific and known by the

Re: [PATCH v3 1/8] spl: fit: Drop 'length' argument to board_spl_fit_post_load()

2021-01-18 Thread Alex G.
On 1/15/21 8:33 PM, Tom Rini wrote: On Wed, Dec 23, 2020 at 08:44:05AM -0600, Alexandru Gagniuc wrote: The size is derived from the FIT image itself. Any alignment requirements are machine-specific and known by the board code. Thus the total length can be derived from the FIT image and

Re: [PATCH v4] cmd: Add a pwm command

2021-01-18 Thread Tom Rini
On Sun, Jan 17, 2021 at 05:35:17PM +0530, Pragnesh Patel wrote: > Hi Tom, > > Any comment on this ? I'll likely be picking this up soon, thanks for your patience. -- Tom signature.asc Description: PGP signature

Re: [PATCH 2/2] efi_loader: make the UEFI boot manager configurable

2021-01-18 Thread Tom Rini
On Fri, Jan 15, 2021 at 09:31:19PM +0100, Heinrich Schuchardt wrote: > On 1/15/21 7:43 PM, Tom Rini wrote: > > On Fri, Jan 15, 2021 at 07:02:50PM +0100, Heinrich Schuchardt wrote: > > > > > Some boards are very tight on the binary size. Booting via UEFI is > > > possible > > > without using the

Re: [PATCH 3/3] test: missing build dependency for test_print.c

2021-01-18 Thread Heinrich Schuchardt
On 18.01.21 00:17, Heinrich Schuchardt wrote: > test_print.c requires CONFIG_CONSOLE_RECORD=y. > > Signed-off-by: Heinrich Schuchardt > --- > test/lib/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/test/lib/Makefile b/test/lib/Makefile > index

Re: [PATCH 4/5] log: convert pr_*() to logging

2021-01-18 Thread Tom Rini
On Mon, Jan 18, 2021 at 08:02:41AM -0500, Tom Rini wrote: > On Sun, Jan 17, 2021 at 08:37:15AM +0100, Heinrich Schuchardt wrote: > > On 1/17/21 1:16 AM, Tom Rini wrote: > > > On Mon, Jan 04, 2021 at 08:02:55AM +0100, Heinrich Schuchardt wrote: > > > > > > > In drivers we use a family of printing

Re: Invitation: Regular U-Boot video call (Tuesday 19th)

2021-01-18 Thread Marek Vasut
On 1/14/21 6:42 AM, Bin Meng wrote: Hi Simon, On Thu, Jan 14, 2021 at 5:57 AM Simon Glass wrote: Hi Bin, I added you, Heinrich, Tom and Andy. For others, as mentioned in the doc I can add you to the invitation. Just reply on this thread. I am not sure how Google meet works as I never

[PULL] u-boot-sh/master

2021-01-18 Thread Marek Vasut
The following changes since commit 14ea1b3635b4af8d9e283e3671f7ee872d50b859: Merge branch '2021-01-15-assorted-improvements' (2021-01-16 11:14:21 -0500) are available in the Git repository at: git://git.denx.de/u-boot-sh.git master for you to fetch changes up to

Re: [PATCH] arm64: a37xx: pci: Fix printing debug messages

2021-01-18 Thread Stefan Roese
On 18.01.21 12:09, Pali Rohár wrote: Value pcie->dev in function pcie_advk_probe() is not initialized yet so use dev as argument for dev_dbg()/dev_warn(). Function pcie_advk_wait_pio() itself prints error message on failure so do not print duplicate error message in caller. Signed-off-by: Pali

Re: [PATCH v2] usb: xhci-pci: Check for errors from dm_pci_map_bar()

2021-01-18 Thread Stefan Roese
On 18.01.21 12:30, Pali Rohár wrote: Function dm_pci_map_bar() may fail and returns NULL. Check this to prevent dereferencing a NULL pointer. In xhci-pci this may happen when board does not enable CONFIG_PCI_PNP and PCI_BASE_ADDRESS_0 contains unconfigured zero address. Signed-off-by: Pali

Re: [PATCH] usb: xhci-pci: Check for errors from dm_pci_map_bar()

2021-01-18 Thread Stefan Roese
On 18.01.21 12:13, Pali Rohár wrote: Function dm_pci_map_bar() may fail and returns NULL. Check this to prevent dereferencing a NULL pointer. In xhci-pci this may happen when board does not enable CONFIG_PCI_PNP and PCI_BASE_ADDRESS_0 contains unconfigured zero address. Signed-off-by: Pali

Re: [PATCH] cmd: disk: Remove fit_print_contents API

2021-01-18 Thread Tom Rini
On Fri, Jan 08, 2021 at 09:55:58AM -0800, Ravik Hasija wrote: > fit_print_contents prints similar fit information as printed in bootm stages. > Removing this API reduces redundancy & provides improvement in boottime. > > Signed-off-by: Ravik Hasija > Reviewed-by: Simon Glass Applied to

Re: [PATCH] lib: cosmetic update of CONFIG_LIB_ELF description

2021-01-18 Thread Tom Rini
On Mon, Jan 04, 2021 at 03:33:28PM +0100, Patrick Delaunay wrote: > Change 2 typo error in CONFIG_LIB_ELF description: > - Supoort => Support > - fir => for > > Signed-off-by: Patrick Delaunay > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description:

Re: [PATCH 5/5] test: unit test for pr_err(), pr_cont()

2021-01-18 Thread Tom Rini
On Mon, Jan 04, 2021 at 08:02:56AM +0100, Heinrich Schuchardt wrote: > Provide a unit test for printing via pr_err() and pr_cont(). > > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 4/5] log: convert pr_*() to logging

2021-01-18 Thread Tom Rini
On Sun, Jan 17, 2021 at 08:37:15AM +0100, Heinrich Schuchardt wrote: > On 1/17/21 1:16 AM, Tom Rini wrote: > > On Mon, Jan 04, 2021 at 08:02:55AM +0100, Heinrich Schuchardt wrote: > > > > > In drivers we use a family of printing functions including pr_err() and > > > pr_cont(). CONFIG_LOGLEVEL is

Re: [PATCH 3/5] log: provide missing macros

2021-01-18 Thread Tom Rini
On Mon, Jan 04, 2021 at 08:02:54AM +0100, Heinrich Schuchardt wrote: > With commit d094a0734cee ("log: allow for message continuation") we have > defined a special log level and category for message continuation. Let's > have a macro for using these. > > If logging is enabled log_cont() will

Re: [PATCH 2/5] log: make debug_cond() function like

2021-01-18 Thread Tom Rini
On Mon, Jan 04, 2021 at 08:02:53AM +0100, Heinrich Schuchardt wrote: > Change debug_cond() such that it can be used instead of a function like > debug(). > > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description:

Re: [PATCH 1/5] ram: k3-j721e: rename BIT_MASK()

2021-01-18 Thread Tom Rini
On Mon, Jan 04, 2021 at 08:02:52AM +0100, Heinrich Schuchardt wrote: > The macro BIT_MASK is already defined in include/linux/bitops.h. To avoid > name collisions rename BIT_MASK() in drivers/ram/k3-j721e/lpddr4_private.h > to LPDDR4_BIT_MASK(). > > Remove superfluous parantheses. > Remove

Re: [PATCH 1/1] mtd: misplaced log.h and dm/devres.h

2021-01-18 Thread Tom Rini
On Sun, Jan 03, 2021 at 04:10:45PM +0100, Heinrich Schuchardt wrote: > log.h and dm/devres.h are U-Boot includes. So placing them > behind #ifndef __UBOOT__ does not make any sense. > > Fixes: f7ae49fc4f36 ("common: Drop log.h from common header") > Fixes: 61b29b826838 ("dm: core: Require users

Re: [PATCH] lib: zlib: our putc() takes only one argument

2021-01-18 Thread Tom Rini
On Mon, Dec 28, 2020 at 09:41:40PM +0100, Heinrich Schuchardt wrote: > In contrast to the C99 standard [1] our putc() takes only one argument. > > [1] ISO/IEC 9899:1999 > > Signed-off-by: Heinrich Schuchardt Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 1/1] lib: zlib: include ctype.h

2021-01-18 Thread Tom Rini
On Mon, Dec 28, 2020 at 09:31:43PM +0100, Heinrich Schuchardt wrote: > Our ctype.h is in include/linux/ > > Signed-off-by: Heinrich Schuchardt Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 1/1] lib: aes: build failure with DEBUG=1

2021-01-18 Thread Tom Rini
On Mon, Dec 28, 2020 at 05:56:27PM +0100, Heinrich Schuchardt wrote: > Building fails with DEBUG=1: > > lib/aes.c: In function ‘debug_print_vector’: > lib/aes.c:622:45: error: > cast from pointer to integer of different size > [-Werror=pointer-to-int-cast] > 622 | printf("%s [%d] @0x%08x",

Re: [PATCH 3/3] armv8: Makefile: build cache files when needed

2021-01-18 Thread Tom Rini
On Mon, Dec 28, 2020 at 08:13:13PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > If no need cache support, not build the cache files, such as in SPL. > > Signed-off-by: Peng Fan Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 1/3] common: Makefile: drop duplicated line

2021-01-18 Thread Tom Rini
On Mon, Dec 28, 2020 at 08:13:11PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > obj-$(CONFIG_$(SPL_TPL_)YMODEM_SUPPORT) += xyzModem.o is there, > no need obj-$(CONFIG_SPL_YMODEM_SUPPORT) += xyzModem.o > > Signed-off-by: Peng Fan > Reviewed-by: Simon Glass Applied to u-boot/master,

Re: [PATCH] dts: Log name of expected .dtb file

2021-01-18 Thread Tom Rini
On Sun, Dec 27, 2020 at 09:34:43PM +0100, Florian Klink wrote: > Make it more obvious what .dts file was expected by the build system. > > When adding support for a new board, I kept getting this error message, > assuming I passed a wrong DEVICE_TREE parameter. > > However, what was really the

Re: [PATCH v2] bootmenu: Allow to quit it via ESC/CTRL+C

2021-01-18 Thread Tom Rini
On Sun, Dec 27, 2020 at 01:04:38AM +0100, Pali Rohár wrote: > When ESC/CTRL+C is pressed interrupt bootmenu and jump into U-Boot console. > As the last entry in bootmenu is always U-Boot console just choose the last > entry when ESC or CTRL+C is pressed. > > ESC key is detected when either no

Re: [PATCH v2] string: Use memcpy() within memmove() when we can

2021-01-18 Thread Tom Rini
On Fri, Dec 11, 2020 at 02:59:23PM +0100, Patrick Delaunay wrote: > A common use of memmove() can be handled by memcpy(). Also memcpy() > includes an optimization for large sizes: it copies a word at a time. So > we can get a speed-up by calling memcpy() to handle our move in this case. > >

Re: [PATCH v5 2/2] drivers: serial: probe all uart devices

2021-01-18 Thread Tom Rini
On Wed, Dec 09, 2020 at 10:42:04AM +0530, Vabhav Sharma wrote: > From: Vabhav Sharma > > U-Boot DM model probe only single device at a time > which is enabled and configured using device tree > or platform data method. > > PL011 UART IP is SBSA compliant and firmware does the > serial port

Re: [PATCH v5 1/2] dm: core: add function uclass_probe_all() to probe all devices

2021-01-18 Thread Tom Rini
On Wed, Dec 09, 2020 at 10:42:03AM +0530, Vabhav Sharma wrote: > From: Vabhav Sharma > > Support a common method to probe all devices associated with uclass. > > This includes data structures and code for finding the first device and > looping for remaining devices associated with uclasses

Re: [PATCH] console: cosmetics: remove #if 0

2021-01-18 Thread Tom Rini
On Wed, Dec 02, 2020 at 03:16:13PM +0100, Patrick Delaunay wrote: > Remove the #if 0 present since the first version of console.c > > Signed-off-by: Patrick Delaunay > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 1/1] common: always compile fixup_cmdtable()

2021-01-18 Thread Tom Rini
On Thu, Nov 26, 2020 at 08:46:37PM +0100, Heinrich Schuchardt wrote: > With our optimization settings the linker eliminates unused functions. > > But for debugging it is better to compile with -Og or -O0. With -O0 > compiling the sandbox fails due to the missing function fixup_cmdtable() >

Re: [PATCH] common: spl: spl_fit.c: report an error on hash check fail

2021-01-18 Thread Tom Rini
On Tue, Nov 24, 2020 at 04:15:05PM +0100, Philippe Reynes wrote: > When the hash check fails on a loadable image, the SPL/TPL simply > jump to the next one. This commit changes this behaviour, when the > hash check fails on a loadable image, the function spl_load_simple_fit > stops and report an

Re: [PATCH] cli_readline: Only insert printable chars

2021-01-18 Thread Tom Rini
On Sun, Nov 22, 2020 at 02:58:45PM +1000, Steve Bennett wrote: > There should be no need to insert non-printable characters > and this prevents line editing getting confused. > > Signed-off-by: Steve Bennett Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v3] Add optional salt to AUTOBOOT_STOP_STR_SHA256

2021-01-18 Thread Tom Rini
On Sat, Nov 21, 2020 at 05:18:59PM -0800, Joel Peshkin wrote: > Adds an optional SALT value to AUTOBOOT_STOP_STR_SHA256. If a string > followed by a ":" is prepended to the sha256, the portion to the left > of the colon will be used as a salt and the password will be appended > to the salt

Re: [PATCH 3/3] doc/README.gpt: reflow partition type GUID table

2021-01-18 Thread Tom Rini
On Fri, Nov 20, 2020 at 11:45:37AM +0100, Rasmus Villemoes wrote: > The previous patch made the table look bad. Fix it, and leave some > space for a future element being a bit longer than the current > maximum. > > Signed-off-by: Rasmus Villemoes Applied to u-boot/master, thanks! -- Tom

Re: [PATCH 2/3] doc/README.gpt: define partition type GUID for U-Boot environment

2021-01-18 Thread Tom Rini
On Fri, Nov 20, 2020 at 11:45:36AM +0100, Rasmus Villemoes wrote: > When setting aside a GPT partition for holding the U-Boot environment, > having a partition type GUID [1] indicating "Linux filesystem" (as > most tools default to) is somewhat misleading - and there's no other > well-known type

Re: [PATCH 1/3] lib/uuid.c: change prototype of uuid_guid_get_str()

2021-01-18 Thread Tom Rini
On Fri, Nov 20, 2020 at 11:45:35AM +0100, Rasmus Villemoes wrote: > There's no reason to require an appropriately sized output parameter > for the string, that's error-prone should the table ever grow an > element with a longer string. We can just return the const char* > pointer directly. > >

Re: [PATCH] power: regulator: Kconfig: add a dependency for POWER_SUPPORT for SPL

2021-01-18 Thread Tom Rini
On Thu, Nov 19, 2020 at 10:10:54PM -0600, Nishanth Menon wrote: > power/regulator will not be built if just CONFIG_SPL_DM_REGULATOR is > enabled. It needs CONFIG_SPL_POWER_SUPPORT to be enabled as well. > > For example, if we just need a GPIO regulator in SPL: > CONFIG_DM_REGULATOR=y >

Re: [PATCH 3/3] test: correct the test prefix in ut str

2021-01-18 Thread Tom Rini
On Thu, Nov 19, 2020 at 10:08:43AM +0100, Patrick Delaunay wrote: > Align the prefix used in cmd_ut_category function and name of tests > for ut str. > This patch solves the issues detected by "make qcheck" after previous > patch. > > Fixes: fdc79a6b125d ("lib: Add a function to convert a string

Re: [PATCH 2/3] test: correct the test prefix in ut cmd_mem

2021-01-18 Thread Tom Rini
On Thu, Nov 19, 2020 at 10:08:42AM +0100, Patrick Delaunay wrote: > Align the prefix used in cmd_ut_category function and name of tests > for ut mem. > This patch solves the issues detected by "make qcheck" after previous > patch. > > Fixes: 550a9e7902ce ("cmd: Update the memory-search command")

Re: [PATCH v5 1/1] cmd: gpt: add eMMC and GPT support

2021-01-18 Thread Tom Rini
On Mon, Nov 09, 2020 at 11:49:16AM +0530, Rayagonda Kokatanur wrote: > From: Corneliu Doban > > Add eMMC and GPT support. > - GPT partition list and command to create the GPT added to u-boot > environment > - eMMC boot commands added to u-boot environment > - new gpt commands (enumarate and

Re: [PATCH] Kconfig: simple panel requires backlight

2021-01-18 Thread Tom Rini
On Thu, Nov 05, 2020 at 05:30:26PM +0100, Marcin Juszkiewicz wrote: > During build of simple panel driver backlight is needed so let's enable > it: > > aarch64-linux-gnu-ld.bfd: drivers/built-in.o: in function > `simple_panel_set_backlight': > u-boot/drivers/video/simple_panel.c:43: undefined

Re: [PATCH 1/1] test: test/lib/test_print.c depends on CONSOLE_RECORD

2021-01-18 Thread Tom Rini
On Thu, Nov 05, 2020 at 01:29:06AM +0100, Heinrich Schuchardt wrote: > The tests in test/lib/test_print.c fail without CONFIG_CONSOLE_RECORD=y. > > Add a build dependency. > > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom

Re: [PATCH 1/1] cmd: CMD_CPU depends on CPU

2021-01-18 Thread Tom Rini
On Thu, Nov 05, 2020 at 12:29:11AM +0100, Heinrich Schuchardt wrote: > Compiling with CONFIG_CMD_CPU=y and CONFIG_CPU=n fails with: > > aarch64-linux-gnu-ld.bfd: cmd/built-in.o: in function `print_cpu_list': > /home/user/u-boot/cmd/cpu.c:34: undefined reference to `cpu_get_desc' >

Re: [PATCH v4 0/3] VIM3: add support for checking 'Function' button state

2021-01-18 Thread Neil Armstrong
Hi, On 18/01/2021 13:48, Heinrich Schuchardt wrote: > On 18.01.21 11:24, Neil Armstrong wrote: >> Hi, >> >> On 22/12/2020 09:56, Marek Szyprowski wrote: >>> Hi All, >>> >>> This patchset adds all building blocks needed for checking the 'Function' >>> button state in the boot script on Amlogic

Re: [PATCH 0/2] efi_loader: make the UEFI boot manager configurable

2021-01-18 Thread Heinrich Schuchardt
On 18.01.21 03:33, AKASHI Takahiro wrote: > Heinrich, > > On Fri, Jan 15, 2021 at 07:02:48PM +0100, Heinrich Schuchardt wrote: >> Some boards are very tight on the binary size. Booting via UEFI is possible >> without using the boot manager. >> >> Provide a configuration option to make the boot

Re: [PATCH v4 0/3] VIM3: add support for checking 'Function' button state

2021-01-18 Thread Heinrich Schuchardt
On 18.01.21 11:24, Neil Armstrong wrote: > Hi, > > On 22/12/2020 09:56, Marek Szyprowski wrote: >> Hi All, >> >> This patchset adds all building blocks needed for checking the 'Function' >> button state in the boot script on Amlogic A311D based VIM3 board. This >> button is connected to the ADC

Re: [PATCH v4 1/3] dt-bindings: input: adc-keys bindings documentation

2021-01-18 Thread Heinrich Schuchardt
a form that cannot be >> misinterpreted and reconcile with upstream. This should include >> >> * a results table for the example >> * a definition if keyup-threshold-microvolt must be higher than all >>    press-threshold-microvolt or may be lower than all >>    pr

Re: [PATCH 0/7] zynqmp_gqspi driver updates

2021-01-18 Thread Bin Meng
On Mon, Jan 18, 2021 at 8:35 PM Ashok Reddy Soma wrote: > > This patch series updates xilinx qspi driver with below fixes/enhancements > > - Fix rounding off issue in DMA transfers > - Fix DMA transfers to be word aligned > - Add support for IO mode > - Fix write issues in QSPI single mode >

Re: [PATCH 1/2] spi: mtk_snor: add support for MTK SPI NOR controller

2021-01-18 Thread SkyLake Huang
On Tue, 2020-12-08 at 01:48 +0800, Jagan Teki wrote: > On Fri, Nov 13, 2020 at 8:32 AM SkyLake Huang > wrote: > > > > From: "SkyLake.Huang" > > > > This patch adds support for MTK SPI NOR controller, which you > > can see on mt7622 & mt7629. > > > > This controller is designed only for SPI NOR.

Minor update in U-boot - FIT image check signature tool

2021-01-18 Thread Ilies CHERGUI
Hey guys, I hope you are doing well. Happy new year. I have a small patch to apply in u-boot concerning the tool for FIT image check signature (please see the attached file). Have a nice weekend. Best regards ** *M. Ilies CHERGUI* *Senior Embedded

[PATCH 7/7] spi: zynqmp_gqspi: Update tapdelay value

2021-01-18 Thread Ashok Reddy Soma
From: T Karthik Reddy Update GQSPI_LPBK_DLY_ADJ_DLY_1 tapdelay value for Versal for frequencies above 100MHz. Signed-off-by: T Karthik Reddy Signed-off-by: Ashok Reddy Soma --- drivers/spi/zynqmp_gqspi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 6/7] spi: zynqmp_gqspi: Add tap delays for Versal qspi

2021-01-18 Thread Ashok Reddy Soma
This patch adds tap delays for qspi in Versal platform. Use IS_ENABLED() to address for ZynqMP and Versal and re-align the tapdelays code. Signed-off-by: Ashok Reddy Soma --- drivers/spi/zynqmp_gqspi.c | 54 ++ 1 file changed, 37 insertions(+), 17

[PATCH 5/7] spi: zynqmp_gqspi: Fix write issues in single mode

2021-01-18 Thread Ashok Reddy Soma
Add dummy write to genfifo register in chipselect. Enable manual start in zynqmp_qspi_fill_gen_fifo(). Also enable GQSPI_IXR_GFNFULL_MASK and check for it instead of GQSPI_IXR_GFEMTY_MASK. Signed-off-by: Ashok Reddy Soma --- drivers/spi/zynqmp_gqspi.c | 16 +++- 1 file changed,

[PATCH 4/7] spi: zynqmp_gqspi: Fix tap delay values

2021-01-18 Thread Ashok Reddy Soma
From: Siva Durga Prasad Paladugu There is no need of read modify write for tapdelay settings ans hence remove the read operations while setting tapdelays. Also, correct tapdelay value settings at 40MHZ by modifying the if check to <= instead of <. Signed-off-by: Siva Durga Prasad Paladugu

[PATCH 1/7] spi: zynqmp_gqspi: do not round immediate_data field

2021-01-18 Thread Ashok Reddy Soma
From: Wojciech Tatarski Immediate_data is 8 bit value in generic FIFO command. When fields data_xfer=1 and exponent=0 this field specifies the absolute number of data bytes to read into the RXFIFO. Values from range 0xfd to 0xff are rounded up to 0x100. It causes overwriting the next bit field

[PATCH 3/7] spi: zynqmp_gqspi: Add support for IO mode

2021-01-18 Thread Ashok Reddy Soma
Add support for device tree "has-io-mode" flag. The driver will be in IO mode when "has-io-mode" is passed from device tree instead of DMA. Signed-off-by: Ashok Reddy Soma --- drivers/spi/zynqmp_gqspi.c | 140 - 1 file changed, 123 insertions(+), 17

  1   2   >