[PATCH] efi_loader: Improve the parameter check for QueryVariableInfo()

2021-06-29 Thread Masami Hiramatsu
Improve efi_query_variable_info() to check the parameter settings and return correct error code according to the UEFI spec 2.9. Signed-off-by: Masami Hiramatsu Reported-by: Kazuhiko Sakamoto --- lib/efi_loader/efi_var_common.c | 20 +++- 1 file changed, 19 insertions(+), 1

[PATCH V1] arm: add initial support for the Phytium Pomelo Board

2021-06-29 Thread nicholas_zheng
From: weichangzheng This adds platform code and the device tree for the Phytium Pomelo Board. The initial support comprises the UART and the PCIE. Signed-off-by: weichangzheng Changes since v1: - updated to DT --- arch/arm/Kconfig | 8 ++ arch/arm/dts/Makefile|

[PATCH v8 1/2] board: riscv: add openpiton-riscv64 SoC support

2021-06-29 Thread Tianrui Wei
This patch adds openpiton-riscv64 SOC support. In particular, this board supports a standard bootflow through zsbl->u-boot SPL-> opensbi->u-boot proper->Linux. There are separate defconfigs for building u-boot SPL and u-boot proper - V6 . separate defconfigs for u-boot and SPL . eliminate

[PATCH v8 2/2] mmc: openpiton: add piton_mmc driver

2021-06-29 Thread Tianrui Wei
This commit adds support to piton_mmc driver for OpenPiton-riscv64 This driver has many things set as preconfigured because the hardware automatically configures most of the settings during startup. - V6 . change type of address . move declarations ahead . loop style update - V7 . dm

[PATCH v8 0/2] [RESEND PATCH v7 0/2]

2021-06-29 Thread Tianrui Wei
This patch set is to add OpenPiton board support. Patches are split into several parts: - [PATCH 1/2] add OpenPiton support to mmc driver - [PATCH 2/2] add support for OpenPiton board Description - for mmc driver, it's settings are automatically configured at hardware level. We only need to

Re: [PATCH v2 1/3] mmc: rockchip_sdhci: add phy and clock config for rk3399

2021-06-29 Thread Peng Fan (OSS)
On 2021/6/28 17:19, Yifeng Zhao wrote: Add clock, phy and other configuration, it is convenient to support new controller. Here a short summary of the changes: - Add mmc_of_parse to parse dts config. - Remove OF_PLATDATA related code. - Reorder header inclusion. - Add phy ops. One more

Re: [PATCH v2 1/3] mmc: rockchip_sdhci: add phy and clock config for rk3399

2021-06-29 Thread Peng Fan (OSS)
On 2021/6/28 17:19, Yifeng Zhao wrote: Add clock, phy and other configuration, it is convenient to support new controller. Here a short summary of the changes: - Add mmc_of_parse to parse dts config. - Remove OF_PLATDATA related code. - Reorder header inclusion. - Add phy ops. - add ops

Re: [PATCH] arm: Add (back) VExpress boards support

2021-06-29 Thread Tom Rini
On Wed, Jun 30, 2021 at 01:12:44AM +0100, Andre Przywara wrote: > On Tue, 29 Jun 2021 14:03:23 -0400 > Tom Rini wrote: > > Hi Tom, > > > On Tue, Jun 29, 2021 at 05:52:10PM +0100, Andre Przywara wrote: > > > On Tue, 29 Jun 2021 15:15:52 +0100 > > > Andre Przywara wrote: > > > > > > Hi, > > >

Re: [PATCH] arm: Add (back) VExpress boards support

2021-06-29 Thread Andre Przywara
On Tue, 29 Jun 2021 14:03:23 -0400 Tom Rini wrote: Hi Tom, > On Tue, Jun 29, 2021 at 05:52:10PM +0100, Andre Przywara wrote: > > On Tue, 29 Jun 2021 15:15:52 +0100 > > Andre Przywara wrote: > > > > Hi, > > > > > On Tue, 29 Jun 2021 08:11:22 -0400 > > > Tom Rini wrote: > > > > > > > On

[PATCH] arm: armv8: Fix warning about redeclaring global functions as weak

2021-06-29 Thread Tom Rini
As seen with clang-12: warning: __asm_invalidate_l3_dcache changed binding to STB_WEAK As we indeed use ENTRY and then declare the function weak manually. Use the WEAK declarative from instead. Signed-off-by: Tom Rini --- arch/arm/cpu/armv8/cache.S | 9 +++-- 1 file changed, 3

Re: [PATCH v3 5/7] net: enetc: require a PHY device when probing

2021-06-29 Thread Ramon Fried
On Tue, Jun 29, 2021 at 8:55 PM Vladimir Oltean wrote: > > Given that even a fixed-link has an associated phy_device, there is no > reason to operate in a mode when dm_eth_phy_connect fails. > > Remove the driver checks for a NULL priv->phy and just return -ENODEV > when that happens. > >

Re: [PATCH v3 6/7] net: enetc: force the RGMII MAC speed/duplex instead of using in-band signaling

2021-06-29 Thread Ramon Fried
On Tue, Jun 29, 2021 at 8:55 PM Vladimir Oltean wrote: > > The RGMII spec supports optional in-band status reporting for the speed > and duplex negotiated on the copper side, and the ENETC driver enables > this feature by default. > > However, this does not work when the PHY does not implement

Re: [PATCH v3 4/7] arm: dts: ls1028a: disable enetc-2 by default

2021-06-29 Thread Ramon Fried
On Tue, Jun 29, 2021 at 8:55 PM Vladimir Oltean wrote: > > The enetc-2 port is used as DSA master (connected back-to-back to > mscc_felix_port4). Since the convention is to not enable ports in the > common SoC dtsi unless they are used on the board, then enable enetc-2 > only when

Re: [PATCH v3 7/7] net: enetc: propagate the return code from phy_startup() to eth_ops::start

2021-06-29 Thread Ramon Fried
On Tue, Jun 29, 2021 at 8:55 PM Vladimir Oltean wrote: > > Make sure that errors in the PHY driver .startup() method, such as no > link, are propagated and not ignored. > > Signed-off-by: Vladimir Oltean > --- > v2->v3: patch is new > > drivers/net/fsl_enetc.c | 4 +--- > 1 file changed, 1

Re: [PATCH v3 3/7] arm: dts: ls1028a: declare the fixed-link speeds for the internal ENETC ports

2021-06-29 Thread Ramon Fried
On Tue, Jun 29, 2021 at 8:55 PM Vladimir Oltean wrote: > > To comply with the device tree bindings expectations for an Ethernet > controller, as well as to simplify the driver code, declare fixed-link > nodes for the internal ENETC ports (attached to the mscc_felix switch). > > Signed-off-by:

Re: [PATCH v2 6/6] drivers: net: fsl_enetc: force the RGMII MAC speed/duplex instead of using in-band signaling

2021-06-29 Thread Ramon Fried
On Tue, Jun 22, 2021 at 12:20 PM Vladimir Oltean wrote: > > On Fri, Jun 18, 2021 at 11:19:11AM +0300, Ramon Fried wrote: > > Reviewed-by: Ramon Fried > > Ramon, could you please take these patches through your tree? Thanks. Done.

Re: [PATCH v3 2/7] arm: dts: ls1028a: enable internal RGMII delays for the LS1028A-QDS AR8035 PHY

2021-06-29 Thread Ramon Fried
On Tue, Jun 29, 2021 at 8:55 PM Vladimir Oltean wrote: > > There are no PCB trace delays on this board, so the PHY needs to enable > its internal ones in order to have a proper electrical connection to the > enetc MAC. > > Fixes: b32e9a757837 ("arm: dts: ls1028a updates for network interfaces") >

Re: [PATCH v3 1/7] arm: dts: ls1028a: enable the switch CPU port for the LS1028A-QDS

2021-06-29 Thread Ramon Fried
On Tue, Jun 29, 2021 at 8:55 PM Vladimir Oltean wrote: > > Due to an upstream change, the ls1028a.dtsi bindings for the mscc_felix > switch got accepted with all ports disabled by default and with no link > to the DSA master - this needs to be done on a per board basis. > > Note that enetc-2 is

Re: [PATCH v2 1/6] arm: dts: ls1028a: enable the switch CPU port for the LS1028A-QDS

2021-06-29 Thread Ramon Fried
On Fri, Jun 18, 2021 at 1:26 AM Vladimir Oltean wrote: > > Due to an upstream change, the ls1028a.dtsi bindings for the mscc_felix > switch got accepted with all ports disabled by default and with no link > to the DSA master - this needs to be done on a per board basis. > > Note that enetc-2 is

Re: [PATCH v3 0/7] Fixes for the NXP LS1028A-QDS boards

2021-06-29 Thread Ramon Fried
On Tue, Jun 29, 2021 at 8:55 PM Vladimir Oltean wrote: > > This series fixes through patches 1, 2 and 6 networking issues seen on > the LS1028A-QDS boards: > - Traffic through the RGMII port enetc-1 does not work > - The switch ports are not probed > - RGMII fixed-link connections do not work > >

Re: [PATCH 6/6] net: dsa: felix: propagate the error code from phy_startup()

2021-06-29 Thread Ramon Fried
On Tue, Jun 29, 2021 at 8:09 PM Vladimir Oltean wrote: > > From: Vladimir Oltean > > Make sure that the link status returned by phy_startup() is propagated > to the .start() method of struct eth_ops. > > Signed-off-by: Vladimir Oltean > --- > drivers/net/mscc_eswitch/felix_switch.c | 4 +--- >

Re: [PATCH 5/6] net: dsa: felix: call phy_config at .port_probe() time

2021-06-29 Thread Ramon Fried
On Tue, Jun 29, 2021 at 8:09 PM Vladimir Oltean wrote: > > From: Vladimir Oltean > > It is an unfortunate reality that some PHY settings done by U-Boot > persist even after the PHY is reset and taken over by Linux, and even > more unfortunate that Linux has come to depend on things being set in

Re: [PATCH 4/6] net: dsa: introduce a .port_probe() method in struct dsa_ops

2021-06-29 Thread Ramon Fried
On Tue, Jun 29, 2021 at 8:09 PM Vladimir Oltean wrote: > > From: Vladimir Oltean > > Some drivers might want to execute code for each port at probe time, as > opposed to executing code just-in-time for the port selected for > networking. > > To cater to that use case, introduce a .port_probe()

Re: [PATCH 3/6] net: dsa: refactor the code to set the port MAC address into a dedicated function

2021-06-29 Thread Ramon Fried
On Tue, Jun 29, 2021 at 8:09 PM Vladimir Oltean wrote: > > From: Vladimir Oltean > > This snippet of code has a bothering "if (...) return 0" in it which > assumes it is the last piece of code running in dsa_port_probe(). > > This makes it difficult to add further code at the end of

Re: [PATCH 2/6] net: dsa: use "err" instead of "ret" in dsa_port_probe

2021-06-29 Thread Ramon Fried
On Tue, Jun 29, 2021 at 8:09 PM Vladimir Oltean wrote: > > From: Vladimir Oltean > > DM DSA uses "err" for error code values, so use this consistently. > > Signed-off-by: Vladimir Oltean > --- > net/dsa-uclass.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git

Re: [PATCH 1/6] net: dsa: felix: felix_init() can be static

2021-06-29 Thread Ramon Fried
On Tue, Jun 29, 2021 at 8:09 PM Vladimir Oltean wrote: > > From: Vladimir Oltean > > No one is calling this function from outside felix_switch.c. > > Signed-off-by: Vladimir Oltean > --- > drivers/net/mscc_eswitch/felix_switch.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [PATCH 2/2] net: smc911x: Determine bus width at runtime

2021-06-29 Thread Ramon Fried
On Tue, Jun 29, 2021 at 2:18 PM Ramon Fried wrote: > > On Mon, Jun 28, 2021 at 4:31 PM Andre Przywara wrote: > > > > The SMC911x Ethernet MACs can be integrated using a 16 or 32-bit bus. > > The driver needs to know about this choice, which is the reason for us > > having a Kconfig symbol for

Re: [PATCH 1/2] net: smc911x: Drop redundant CONFIG_SMC911X_16_BIT Kconfig symbol

2021-06-29 Thread Ramon Fried
On Tue, Jun 29, 2021 at 2:18 PM Ramon Fried wrote: > > On Mon, Jun 28, 2021 at 4:31 PM Andre Przywara wrote: > > > > The SMC911x Ethernet driver needs to know which accessor functions it > > can use to access the MMIO registers. For that reason we have a Kconfig > > choice between 16 and 32-bit

Re: [PATCH v3] cmd: net: add a 'net list' command to list network devs

2021-06-29 Thread Ramon Fried
On Sat, Jun 19, 2021 at 1:26 AM Tim Harvey wrote: > > In a system with multiple network controllers it can be difficult > to know the names of the various devices available. This is especially > true for USB ether devices as they do not display device names upon > detection. > > This is being

Re: [RESEND PATCH v7 2/2] mmc: openpiton: add piton_mmc driver

2021-06-29 Thread Jaehoon Chung
On 6/30/21 3:01 AM, Tianrui Wei wrote: > This commit adds support to piton_mmc driver for OpenPiton-riscv64 > This driver has many things set as preconfigured because the hardware > automatically configures most of the settings during startup. > > - V6 > . change type of address > . move

Re: [PULL] u-boot-network/network_master

2021-06-29 Thread Ramon Fried
On Wed, Jun 30, 2021 at 12:56 AM Tom Rini wrote: > > On Wed, Jun 30, 2021 at 12:52:59AM +0300, Ramon Fried wrote: > > On Fri, Jun 18, 2021 at 8:17 PM Tom Rini wrote: > > > > > > On Fri, Jun 18, 2021 at 02:42:50PM +0300, Ramon Fried wrote: > > > > > > > Hi Tom, > > > > > > > > Please pull the

Re: [PATCH] phy: add nxp tja1103 phy driver

2021-06-29 Thread Ramon Fried
On Mon, Jun 28, 2021 at 2:01 AM Ramon Fried wrote: > > On Fri, Jun 18, 2021 at 9:58 PM Radu Pirea (NXP OSS) > wrote: > > > > Add nxp tja1103 phy driver. > > > > Signed-off-by: Radu Pirea (NXP OSS) > > --- > > MAINTAINERS | 5 + > > drivers/net/phy/Kconfig |

Re: [PULL] u-boot-network/network_master

2021-06-29 Thread Tom Rini
On Wed, Jun 30, 2021 at 12:52:59AM +0300, Ramon Fried wrote: > On Fri, Jun 18, 2021 at 8:17 PM Tom Rini wrote: > > > > On Fri, Jun 18, 2021 at 02:42:50PM +0300, Ramon Fried wrote: > > > > > Hi Tom, > > > > > > Please pull the latest patches in u-boot-net tree. > > > > > > The following changes

Re: [PULL] u-boot-network/network_master

2021-06-29 Thread Ramon Fried
On Fri, Jun 18, 2021 at 8:17 PM Tom Rini wrote: > > On Fri, Jun 18, 2021 at 02:42:50PM +0300, Ramon Fried wrote: > > > Hi Tom, > > > > Please pull the latest patches in u-boot-net tree. > > > > The following changes since commit a298d4fbcdba1b38e48ea2af0fc5386cab2070da: > > > > Merge

Re: [PATCH v3 2/3] mmc: rockchip_sdhci: Add support for RK3568

2021-06-29 Thread Jaehoon Chung
On 6/29/21 5:24 PM, Yifeng Zhao wrote: > This patch adds support for the RK3568 platform to this driver. > > Signed-off-by: Yifeng Zhao Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > > Changes in v3: > - Config the interface clock by clk_set_rate directly > > Changes in

Re: [PATCH v3 1/3] mmc: rockchip_sdhci: add phy and clock config for rk3399

2021-06-29 Thread Jaehoon Chung
On 6/29/21 5:24 PM, Yifeng Zhao wrote: > Add clock, phy and other configuration, it is convenient to support > new controller. Here a short summary of the changes: > - Add mmc_of_parse to parse dts config. > - Remove OF_PLATDATA related code. > - Reorder header inclusion. > - Add phy ops. > - add

Re: [PATCH] arm: Add (back) VExpress boards support

2021-06-29 Thread Tom Rini
On Tue, Jun 29, 2021 at 05:52:10PM +0100, Andre Przywara wrote: > On Tue, 29 Jun 2021 15:15:52 +0100 > Andre Przywara wrote: > > Hi, > > > On Tue, 29 Jun 2021 08:11:22 -0400 > > Tom Rini wrote: > > > > > On Tue, Jun 29, 2021 at 12:45:55PM +0100, Andre Przywara wrote: > > > > > > > The

[RESEND PATCH v7 2/2] mmc: openpiton: add piton_mmc driver

2021-06-29 Thread Tianrui Wei
This commit adds support to piton_mmc driver for OpenPiton-riscv64 This driver has many things set as preconfigured because the hardware automatically configures most of the settings during startup. - V6 . change type of address . move declarations ahead . loop style update - V7 . dm

[RESEND PATCH v7 1/2] board: riscv: add openpiton-riscv64 SoC support

2021-06-29 Thread Tianrui Wei
This patch adds openpiton-riscv64 SOC support. In particular, this board supports a standard bootflow through zsbl->u-boot SPL-> opensbi->u-boot proper->Linux. There are separate defconfigs for building u-boot SPL and u-boot proper - V6 . separate defconfigs for u-boot and SPL . eliminate

[RESEND PATCH v7 0/2] Add OpenPiton-riscv64 Board Support

2021-06-29 Thread Tianrui Wei
This patch set is to add OpenPiton board support. Patches are split into several parts: - [PATCH 1/2] add OpenPiton support to mmc driver - [PATCH 2/2] add support for OpenPiton board Description - for mmc driver, it's settings are automatically configured at hardware level. We only need to

[PATCH v3 7/7] net: enetc: propagate the return code from phy_startup() to eth_ops::start

2021-06-29 Thread Vladimir Oltean
Make sure that errors in the PHY driver .startup() method, such as no link, are propagated and not ignored. Signed-off-by: Vladimir Oltean --- v2->v3: patch is new drivers/net/fsl_enetc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/fsl_enetc.c

[PATCH v3 6/7] net: enetc: force the RGMII MAC speed/duplex instead of using in-band signaling

2021-06-29 Thread Vladimir Oltean
The RGMII spec supports optional in-band status reporting for the speed and duplex negotiated on the copper side, and the ENETC driver enables this feature by default. However, this does not work when the PHY does not implement the in-band reporting, or when there is a MAC-to-MAC connection

[PATCH v3 5/7] net: enetc: require a PHY device when probing

2021-06-29 Thread Vladimir Oltean
Given that even a fixed-link has an associated phy_device, there is no reason to operate in a mode when dm_eth_phy_connect fails. Remove the driver checks for a NULL priv->phy and just return -ENODEV when that happens. Copyright updated according to corporate requirements. Signed-off-by:

[PATCH v3 4/7] arm: dts: ls1028a: disable enetc-2 by default

2021-06-29 Thread Vladimir Oltean
The enetc-2 port is used as DSA master (connected back-to-back to mscc_felix_port4). Since the convention is to not enable ports in the common SoC dtsi unless they are used on the board, then enable enetc-2 only when mscc_felix_port4 itself is enabled. All existing device trees appear to adhere

[PATCH v3 3/7] arm: dts: ls1028a: declare the fixed-link speeds for the internal ENETC ports

2021-06-29 Thread Vladimir Oltean
To comply with the device tree bindings expectations for an Ethernet controller, as well as to simplify the driver code, declare fixed-link nodes for the internal ENETC ports (attached to the mscc_felix switch). Signed-off-by: Vladimir Oltean --- v2->v3: none v1->v2: none

[PATCH v3 2/7] arm: dts: ls1028a: enable internal RGMII delays for the LS1028A-QDS AR8035 PHY

2021-06-29 Thread Vladimir Oltean
There are no PCB trace delays on this board, so the PHY needs to enable its internal ones in order to have a proper electrical connection to the enetc MAC. Fixes: b32e9a757837 ("arm: dts: ls1028a updates for network interfaces") Signed-off-by: Vladimir Oltean --- v2->v3: none v1->v2: none

[PATCH v3 1/7] arm: dts: ls1028a: enable the switch CPU port for the LS1028A-QDS

2021-06-29 Thread Vladimir Oltean
Due to an upstream change, the ls1028a.dtsi bindings for the mscc_felix switch got accepted with all ports disabled by default and with no link to the DSA master - this needs to be done on a per board basis. Note that enetc-2 is not currently disabled in the ls1028a.dtsi, but presumably at some

[PATCH v3 0/7] Fixes for the NXP LS1028A-QDS boards

2021-06-29 Thread Vladimir Oltean
This series fixes through patches 1, 2 and 6 networking issues seen on the LS1028A-QDS boards: - Traffic through the RGMII port enetc-1 does not work - The switch ports are not probed - RGMII fixed-link connections do not work Patches 3 and 4 are dependencies for patch 6, as follows: - Forcing

[PATCH 6/6] net: dsa: felix: propagate the error code from phy_startup()

2021-06-29 Thread Vladimir Oltean
From: Vladimir Oltean Make sure that the link status returned by phy_startup() is propagated to the .start() method of struct eth_ops. Signed-off-by: Vladimir Oltean --- drivers/net/mscc_eswitch/felix_switch.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

[PATCH 5/6] net: dsa: felix: call phy_config at .port_probe() time

2021-06-29 Thread Vladimir Oltean
From: Vladimir Oltean It is an unfortunate reality that some PHY settings done by U-Boot persist even after the PHY is reset and taken over by Linux, and even more unfortunate that Linux has come to depend on things being set in a certain way. For example, on the NXP LS1028A-RDB, the felix

[PATCH 4/6] net: dsa: introduce a .port_probe() method in struct dsa_ops

2021-06-29 Thread Vladimir Oltean
From: Vladimir Oltean Some drivers might want to execute code for each port at probe time, as opposed to executing code just-in-time for the port selected for networking. To cater to that use case, introduce a .port_probe() callback method into the DSA switch operations which is called for each

[PATCH 3/6] net: dsa: refactor the code to set the port MAC address into a dedicated function

2021-06-29 Thread Vladimir Oltean
From: Vladimir Oltean This snippet of code has a bothering "if (...) return 0" in it which assumes it is the last piece of code running in dsa_port_probe(). This makes it difficult to add further code at the end of dsa_port_probe() which does not depend on MAC address stuff. So move the code

[PATCH 2/6] net: dsa: use "err" instead of "ret" in dsa_port_probe

2021-06-29 Thread Vladimir Oltean
From: Vladimir Oltean DM DSA uses "err" for error code values, so use this consistently. Signed-off-by: Vladimir Oltean --- net/dsa-uclass.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/net/dsa-uclass.c b/net/dsa-uclass.c index 7ea1cb6949c0..17b33834f585 100644

[PATCH 1/6] net: dsa: felix: felix_init() can be static

2021-06-29 Thread Vladimir Oltean
From: Vladimir Oltean No one is calling this function from outside felix_switch.c. Signed-off-by: Vladimir Oltean --- drivers/net/mscc_eswitch/felix_switch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mscc_eswitch/felix_switch.c

[PATCH 0/6] Call phy_config at port probe time for the Felix DSA driver

2021-06-29 Thread Vladimir Oltean
From: Vladimir Oltean This series makes the Felix DSA driver initialize all its connected PHYs regardless of whether those will be used for networking or not. This is in order to satisfy the expectations of some software in later boot stages. To make this work, it is necessary to introduce a

Re: [PATCH] arm: Add (back) VExpress boards support

2021-06-29 Thread Andre Przywara
On Tue, 29 Jun 2021 15:15:52 +0100 Andre Przywara wrote: Hi, > On Tue, 29 Jun 2021 08:11:22 -0400 > Tom Rini wrote: > > > On Tue, Jun 29, 2021 at 12:45:55PM +0100, Andre Przywara wrote: > > > > > The v2021.07 merge window saw the removal of the Arm Ltd. Versatile > > > Express platform,

[RFC PATCH v2 1/1] cmd: nvedit: Forbid key to be empty.

2021-06-29 Thread Francis Laniel
Before this patch, it was possible to do the following using setenv: setenv '' foo Then, on next reboot, U-Boot will not be able to parse environment due to it having: =foo Now, if the above command is given, an error message is thrown and environment is not modified. Signed-off-by: Francis

[RFC PATCH v2 0/1] cmd: nvedit: Forbid environment key to be empty.

2021-06-29 Thread Francis Laniel
Hi. First of all, I hope you are fine and the same for your relatives. In this patch, I modified the setenv command to decline empty variable name. Indeed, it was strangely possible to give the following to this command: setenv '' foo Which results in the following belonging to environment:

Re: [RFC PATCH 1/1] cmd: nvedit: Forbid key to be empty.

2021-06-29 Thread Francis Laniel
Hi. On Tue, Jun 29, 2021 at 10:29 AM Wolfgang Denk wrote: > Dear Francis, > > In message <20210628193145.796999-2-francis.lan...@amarulasolutions.com> > you wrote: > > Before this patch, it was possible to do the following using setenv: > > setenv '' foo > > Then, on next reboot, U-Boot will

[PATCH] cmd: nand biterr - Add support for nand biterr command

2021-06-29 Thread Balamanikandan Gunasundar
The command shall be used to induce bit errors in the nand page manually. The code flips a bit in the specified offset without changing the ECC. This helps to see how the software handles the error. The patch is ported from https://patchwork.ozlabs.org/project/uboot/patch/\

Re: [PATCH 0/3] cmd: setexpr: add fmt format string operation

2021-06-29 Thread Wolfgang Denk
Dear Sean, In message <19b6eeea-2aad-972b-aeeb-8959aab17...@gmail.com> you wrote: > > The issue with this is twofold. First, there is no portable way to > construct a va_list from C code. So the likely way to do this would be > to set an arbitrary limit, and then just pass the arguments in. E.g.

Re: [PATCH] arm: Add (back) VExpress boards support

2021-06-29 Thread Andre Przywara
On Tue, 29 Jun 2021 08:11:22 -0400 Tom Rini wrote: > On Tue, Jun 29, 2021 at 12:45:55PM +0100, Andre Przywara wrote: > > > The v2021.07 merge window saw the removal of the Arm Ltd. Versatile > > Express platform, along with their CA5, CA9 and TC2 boards. The trigger > > was the missing

Re: [PATCH 0/7] efi: Various tidy-ups and drop the default

2021-06-29 Thread AKASHI Takahiro
On Tue, Jun 29, 2021 at 04:01:38PM +0200, Heinrich Schuchardt wrote: > On 6/29/21 2:56 PM, AKASHI Takahiro wrote: > > On Mon, Jun 28, 2021 at 12:08:27PM -0600, Simon Glass wrote: > > > Hi Tom, > > > > > > On Mon, 28 Jun 2021 at 11:27, Tom Rini wrote: > > > > > > > > On Mon, Jun 28, 2021 at

Re: [PATCH 0/7] efi: Various tidy-ups and drop the default

2021-06-29 Thread Heinrich Schuchardt
On 6/29/21 2:56 PM, AKASHI Takahiro wrote: On Mon, Jun 28, 2021 at 12:08:27PM -0600, Simon Glass wrote: Hi Tom, On Mon, 28 Jun 2021 at 11:27, Tom Rini wrote: On Mon, Jun 28, 2021 at 10:26:35AM -0600, Simon Glass wrote: Hi Heinrich, On Mon, 28 Jun 2021 at 09:20, Heinrich Schuchardt wrote:

Re: [PATCH 0/3] cmd: setexpr: add fmt format string operation

2021-06-29 Thread Sean Anderson
On 6/29/21 4:37 AM, Wolfgang Denk wrote: Dear Roland, In message <20210628151750.572837-1-roland.gaudig-...@weidmueller.com> you wrote: U-Boot uses almost everywhere hexadecimal numbers. But some bootargs passed to Linux are expecting decimal numbers. As long as the values are in the range

Re: [PATCH] sf: Querying write-protect status before operating the flash

2021-06-29 Thread Jagan Teki
On Tue, Jun 22, 2021 at 10:51 AM chao zeng wrote: > > From: Chao Zeng > > When operating the write-protection flash,spi_flash_std_write() and > spi_flash_std_erase() would return wrong result.The flash is protected, > but write or erase the flash would show "OK". > > Check the flash write

Re: [PATCH v9 9/9] mtd: spi-nor-tiny: Add fixups for Cypress s25hl-t/s25hs-t

2021-06-29 Thread Jagan Teki
On Tue, Jun 29, 2021 at 11:31 AM wrote: > > From: Takahiro Kuwano > > Fixes mode clocks for SPINOR_OP_READ_FAST_4B in tiny. > > Signed-off-by: Takahiro Kuwano > --- Reviewed-by: Jagan Teki

Re: [PATCH v9 8/9] mtd: spi-nor-core: Add fixups for Cypress s25hl-t/s25hs-t

2021-06-29 Thread Jagan Teki
On Tue, Jun 29, 2021 at 11:31 AM wrote: > > From: Takahiro Kuwano > > The nor->ready() and spansion_sr_ready() introduced earlier in this > series are used for multi-die package parts. > > The nor->quad_enable() sets the volatile QE bit on each die. > > The nor->erase() is hooked if the device

Re: [PATCH v9 7/9] mtd: spi-nor-core: Add Cypress manufacturer ID in set_4byte

2021-06-29 Thread Jagan Teki
On Tue, Jun 29, 2021 at 11:31 AM wrote: > > From: Takahiro Kuwano > > Cypress chips support SPINOR_OP_EN4B(B7h) to enable 4-byte addressing mode. > > Cypress chips support B8h to disable 4-byte addressing mode instead of > SPINOR_OP_EX4B(E9h). > > This patch defines new opcode and updates

Re: [PATCH v9 6/9] mtd: spi-nor-core: Read status by Read Any Register

2021-06-29 Thread Jagan Teki
On Tue, Jun 29, 2021 at 11:31 AM wrote: > > From: Takahiro Kuwano > > The spansion_sr_ready() reads status register 1 by Read Any Register > commnad. This function is called from Flash specific hook with die address > and dummy cycles to support multi-die package parts from Spansion/Cypress. > >

Re: [PATCH v9 5/9] mtd: spi-nor-core: Add the ->ready() hook

2021-06-29 Thread Jagan Teki
On Tue, Jun 29, 2021 at 11:31 AM wrote: > > From: Takahiro Kuwano > > For dual/quad die package devices from Spansion/Cypress, the device's > status needs to be checked by reading status registers in all dies, by > using Read Any Register command. To support this, a Flash specific hook > that

Re: [PATCH] efi_loader: Allow capsule update on-disk without checking OsIndications

2021-06-29 Thread Ilias Apalodimas
On Tue, 29 Jun 2021 at 16:04, AKASHI Takahiro wrote: > > On Tue, Jun 29, 2021 at 03:45:29PM +0300, Ilias Apalodimas wrote: > > > > > > > [...] > > > > > +config EFI_IGNORE_OSINDICATIONS > > > > > + bool "Ignore OsIndications for CapsuleUpdate on-disk" > > > > > + depends on

Re: [PATCH v9 4/9] mtd: spi-nor-core: Add support for volatile QE bit

2021-06-29 Thread Jagan Teki
On Tue, Jun 29, 2021 at 11:31 AM wrote: > > From: Takahiro Kuwano > > Some of Spansion/Cypress chips support volatile version of configuration > registers and it is recommended to update volatile registers in the field > application due to a risk of the non-volatile registers corruption by >

Re: [PATCH v9 3/9] mtd: spi-nor-core: Add support for Read/Write Any Register

2021-06-29 Thread Jagan Teki
On Tue, Jun 29, 2021 at 11:31 AM wrote: > > From: Takahiro Kuwano > > Some of Spansion/Cypress chips support Read/Write Any Register commands. > These commands are mainly used to write volatile registers and access to > the registers in second and subsequent die for multi-die package parts. > >

Re: [PATCH v9 2/9] mtd: spi-nor-ids: Add Cypress s25hl-t/s25hs-t

2021-06-29 Thread Jagan Teki
On Tue, Jun 29, 2021 at 11:31 AM wrote: > > From: Takahiro Kuwano > > The S25HL-T/S25HS-T family is the Cypress Semper Flash with Quad SPI. > > https://www.cypress.com/file/424146/download (256Mb/512Mb/1Gb, single die) > https://www.cypress.com/file/499246/download (2Gb/4Gb, dual/quad die) > >

Re: [PATCH v9 1/9] mtd: spi-nor: Add Cypress manufacturer ID

2021-06-29 Thread Jagan Teki
On Tue, Jun 29, 2021 at 11:31 AM wrote: > > From: Takahiro Kuwano > > This patch adds Cypress manufacturer ID (34h) definition. > > Signed-off-by: Takahiro Kuwano > Reviewed-by: Pratyush Yadav > --- Reviewed-by: Jagan Teki

Re: [PATCH] patman: Handle PAGER containing arguments

2021-06-29 Thread Paul Barker
On Sat, 26 Jun 2021 12:31:41 -0600 Simon Glass wrote: > Hi Paul, > > On Tue, 15 Jun 2021 at 04:26, Paul Barker > wrote: > > > > When printing full help output from patman, we should be able to > > handle a PAGER variable which includes arguments, e.g. PAGER='less > > -F'. > > > >

Re: [PATCH] efi_loader: Allow capsule update on-disk without checking OsIndications

2021-06-29 Thread AKASHI Takahiro
On Tue, Jun 29, 2021 at 03:45:29PM +0300, Ilias Apalodimas wrote: > > > > > [...] > > > > +config EFI_IGNORE_OSINDICATIONS > > > > + bool "Ignore OsIndications for CapsuleUpdate on-disk" > > > > + depends on EFI_CAPSULE_ON_DISK > > > > + default n > > > > + help > > > > +

Re: [PATCH 0/7] efi: Various tidy-ups and drop the default

2021-06-29 Thread AKASHI Takahiro
On Mon, Jun 28, 2021 at 12:08:27PM -0600, Simon Glass wrote: > Hi Tom, > > On Mon, 28 Jun 2021 at 11:27, Tom Rini wrote: > > > > On Mon, Jun 28, 2021 at 10:26:35AM -0600, Simon Glass wrote: > > > Hi Heinrich, > > > > > > On Mon, 28 Jun 2021 at 09:20, Heinrich Schuchardt > > > wrote: > > > > >

[PATCH v2] efi_loader: Allow capsule update on-disk without checking OsIndications

2021-06-29 Thread Ilias Apalodimas
Although U-Boot supports capsule update on-disk, it's lack of support for SetVariable at runtime prevents applications like fwupd from using it. In order to perform the capsule update on-disk the spec says that the OS must copy the capsule to the \EFI\UpdateCapsule directory and set a bit in the

Re: [PATCH] efi_loader: Allow capsule update on-disk without checking OsIndications

2021-06-29 Thread Ilias Apalodimas
> > > [...] > > > +config EFI_IGNORE_OSINDICATIONS > > > + bool "Ignore OsIndications for CapsuleUpdate on-disk" > > > + depends on EFI_CAPSULE_ON_DISK > > > + default n > > > + help > > > + There are boards were we can't support SetVariable at runtime. > > > + Select this option if you want

Re: [PATCH] efi_loader: Allow capsule update on-disk without checking OsIndications

2021-06-29 Thread AKASHI Takahiro
On Tue, Jun 29, 2021 at 09:43:40AM +0200, Heinrich Schuchardt wrote: > On 6/29/21 6:55 AM, Ilias Apalodimas wrote: > > From: apalos > > > > Although U-Boot supports capsule update on-disk, it's lack of support for > > SetVariable at runtime prevents applications like fwupd from using it. > > >

Re: [PULL] u-boot-sh/next

2021-06-29 Thread Tom Rini
On Fri, Jun 25, 2021 at 03:14:51AM +0200, Marek Vasut wrote: > V3U Falcon board support, for next release. > > The following changes since commit fcf3981161140d265b873a5b609b8867328dc9dc: > > Merge https://source.denx.de/u-boot/custodians/u-boot-x86 (2021-06-23 > 08:46:26 -0400) > > are

Re: Pull request: u-boot-spi/next for next

2021-06-29 Thread Tom Rini
On Mon, Jun 28, 2021 at 09:21:55PM +0530, Jagan Teki wrote: > Hi Tom, > > Please pull this PR for next. > > Summary: > - xSPI Octal DTR support (Pratyush Yadav) > - MXIC SPI driver (Zhengxun) > > CI: > https://source.denx.de/u-boot/custodians/u-boot-spi/-/pipelines/7959 > > thanks, > Jagan. >

Re: [PATCH] arm64: Fix relocation of env_addr if POSITION_INDEPENDENT=y

2021-06-29 Thread Tom Rini
On Tue, Jun 15, 2021 at 03:33:02PM +0900, Kunihiko Hayashi wrote: > If both POSITION_INDEPENDENT and SYS_RELOC_GD_ENV_ADDR are enabled, > wherever original env is placed anywhere, it should be relocated to > the right address. > > Relocation offset gd->reloc_off is calculated with SYS_TEXT_BASE

Re: [PATCH 1/1] efi_loader: fix set_capsule_result()

2021-06-29 Thread AKASHI Takahiro
On Tue, Jun 29, 2021 at 09:40:21AM +0200, Heinrich Schuchardt wrote: > The log category must be LOG_CATEGORY LOGC_EFI. > > efi_set_variable() should be called with EFI_CALL(). Use > efi_set_variable_int() instead. > > A log text "Updating ..." if SetVariable() fails does not make sense for a >

Re: [PATCH] arm: Add (back) VExpress boards support

2021-06-29 Thread Tom Rini
On Tue, Jun 29, 2021 at 12:45:55PM +0100, Andre Przywara wrote: > The v2021.07 merge window saw the removal of the Arm Ltd. Versatile > Express platform, along with their CA5, CA9 and TC2 boards. The trigger > was the missing conversion of the MMC driver. > > Some folks complained about that

[PATCH] arm: Add (back) VExpress boards support

2021-06-29 Thread Andre Przywara
The v2021.07 merge window saw the removal of the Arm Ltd. Versatile Express platform, along with their CA5, CA9 and TC2 boards. The trigger was the missing conversion of the MMC driver. Some folks complained about that internally, so bring those boards back, but better than ever: - Use DM and

[PATCH v5 5/5] rockchip: px30: add support for SFC for Odroid Go Advance

2021-06-29 Thread Jon Lin
From: Chris Morgan The Odroid Go Advance uses a Rockchip Serial Flash Controller with an XT25F128B SPI NOR flash chip. This adds support for both. Note that while both the controller and chip support quad mode, only two lines are connected to the chip. Changing the pinctrl to bus2 and setting tx

[PATCH v5 1/5] spi: rockchip_sfc: add support for Rockchip SFC

2021-06-29 Thread Jon Lin
From: Chris Morgan This patch adds support for the Rockchip serial flash controller found on the PX30 SoC. It should work for versions 3-5 of the SFC IP, however I am only able to test it on v3. This is adapted from the WIP SPI-MEM driver for the SFC on mainline Linux. Note that the main

[PATCH v5 4/5] mtd: spi-nor-ids: Add XTX XT25F128B

2021-06-29 Thread Jon Lin
From: Chris Morgan Adds support for XT25F128B used on Odroid Go Advance. Unfortunately this chip uses a continuation code which I cannot seem to parse, so there are possibly going to be collisions with chips that use the same manufacturer/ID. Signed-off-by: Chris Morgan Signed-off-by: Jon Lin

[PATCH v5 2/5] rockchip: px30: Add support for using SFC

2021-06-29 Thread Jon Lin
From: Chris Morgan This patch adds support for setting the correct pin configuration for the Rockchip Serial Flash Controller found on the PX30. Signed-off-by: Chris Morgan Signed-off-by: Jon Lin --- (no changes since v1) arch/arm/mach-rockchip/px30/px30.c | 64

[PATCH v5 3/5] rockchip: px30: add the serial flash controller

2021-06-29 Thread Jon Lin
From: Chris Morgan Add the serial flash controller to the devicetree for the PX30. Signed-off-by: Chris Morgan Signed-off-by: Jon Lin --- Changes in v5: - px30 use "rockchip, sfc" as compatible id arch/arm/dts/px30.dtsi | 38 ++ 1 file changed, 38

[PATCH v5 0/5] rockchip_sfc: add support for Rockchip SFC

2021-06-29 Thread Jon Lin
Changes in v5: - Support dma transfer - Add CONFIG_IS_ENABLED(CLK) limitation - Support spinand devices - Support SFC ver4 ver5 - Using "rockchip, sfc" as compatible id - Get clock from the index to compatible with those case which's clock-names is not parsed - px30 use "rockchip, sfc" as

[PATCH v3 1/3] mmc: rockchip_sdhci: add phy and clock config for rk3399

2021-06-29 Thread Yifeng Zhao
Add clock, phy and other configuration, it is convenient to support new controller. Here a short summary of the changes: - Add mmc_of_parse to parse dts config. - Remove OF_PLATDATA related code. - Reorder header inclusion. - Add phy ops. - add ops set_ios_post to modify the parameters of phy when

[PATCH v3 2/3] mmc: rockchip_sdhci: Add support for RK3568

2021-06-29 Thread Yifeng Zhao
This patch adds support for the RK3568 platform to this driver. Signed-off-by: Yifeng Zhao --- Changes in v3: - Config the interface clock by clk_set_rate directly Changes in v2: - Used sdhci_set_clock api to set clock. - Used read_poll_timeout api to check dll status.

[PATCH v3 0/3] Add hs400 support for rk3399 and rk3568

2021-06-29 Thread Yifeng Zhao
RK3399 and RK3568 are use different sdhci controllers. The drivers need to be updated to support these two platforms and it's easy to support new platforms. Changes in v3: - Optimize hs200 tuning function. - Add check for callback function. - Add return value for tuning function. - Fixed

[PATCH v3 3/3] rockchip: config: evb-rk3399: add hs400 and SDMA support

2021-06-29 Thread Yifeng Zhao
This enable hs400 and SDMA support for emmc on evb-rk3399. Signed-off-by: Yifeng Zhao --- Changes in v3: - Enable SDMA. configs/evb-rk3399_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configs/evb-rk3399_defconfig b/configs/evb-rk3399_defconfig index 21477719dc..d5eba1d903

回复: [PATCH] arm: add initial support for the Phytium Pomelo Board

2021-06-29 Thread Nicholas zheng
Is this some internal board? Or something China only? Google couldn't find any useful hits about the platform. This board corresponds to Phytium D2000. The name of the public edition has not been announced. For other questions, I will submit a new patch after modifying it. thanks.

Re: Re: [PATCH v2 1/3] mmc: rockchip_sdhci: add phy and clock config for rk3399

2021-06-29 Thread 赵仪峰
Hi Jaehoon, >RK_CLRSETBITS macro is (((clr) | (set))) << 16) | (set). >Which bit is cleared? When (7 << 4) is set, it means that cleared? Yes, this ops clear the bit4-bit6. >> + >> +if (opcode == MMC_CMD_SEND_TUNING_BLOCK_HS200 && >> host->mmc->bus_width == 8) >> +

  1   2   >