Re: [PATCH u-boot-marvell 10/10] tools: kwboot: Update references with public links

2022-03-03 Thread Stefan Roese
On 3/2/22 11:49, Pali Rohár wrote: Public documents about BootROM of some Marvell SoCs are available in the public Web Archive. Put this information into source code. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Tested-by: Stefan Roese Thanks, Stefan --- tools/kwboot.c | 31

Re: [PATCH u-boot-marvell 09/10] tools: kwboot: Update doc about Avanta

2022-03-03 Thread Stefan Roese
On 3/2/22 11:49, Pali Rohár wrote: Testes proved that current kwboot version supports also Avanta SoCs. It looks like that Avanta SoCs are using same kwbimage format as Armada. Signed-off-by: Pali Rohár Tested-by: Tony Dinh Reviewed-by: Stefan Roese Tested-by: Stefan Roese Thanks, Stefan

Re: [PATCH u-boot-marvell 08/10] tools: kwboot: Update manpage

2022-03-03 Thread Stefan Roese
On 3/2/22 11:49, Pali Rohár wrote: Document -D, -b, -d, -q and -s options. Add common examples how to use kwboot. Add information about Armada 38x BootROM bug for debug console mode and how to workaround it. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Tested-by: Stefan Roese

Re: [PATCH u-boot-marvell 07/10] tools: kwboot: Update usage

2022-03-03 Thread Stefan Roese
On 3/2/22 11:49, Pali Rohár wrote: Add all supported Armada SoCs and document -b and -d options in usage. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Tested-by: Stefan Roese Thanks, Stefan --- tools/kwboot.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff

Re: [PATCH u-boot-marvell 06/10] tools: kwboot: Add support for backspace key in mini terminal

2022-03-03 Thread Stefan Roese
On 3/2/22 11:49, Pali Rohár wrote: Marvell BootROM recognize only '\b' byte as backspace. Use terminfo for retrieving current backspace sequence and replace any occurrence of backspace sequence by the '\b' byte. Reading terminfo database is possible via tigetstr() function from system library

Re: [PATCH u-boot-marvell 05/10] tools: kwboot: Fix sending and processing debug message pattern (-d option)

2022-03-03 Thread Stefan Roese
On 3/2/22 11:49, Pali Rohár wrote: -d option is currently broken. In most cases BootROM does not detect this message pattern. For sending debug message pattern it is needed to do same steps as for boot message pattern. Implement sending debug message pattern via same separate thread like it is

Re: [PATCH u-boot-marvell 04/10] tools: kwboot: Use separate thread for sending boot message pattern

2022-03-03 Thread Stefan Roese
On 3/2/22 11:49, Pali Rohár wrote: After BootROM successfully detects boot message pattern on UART it waits until host stop sending data on UART. For example Armada 385 BootROM requires that host does not send anything on UART at least 24 ms. If host is still sending something then BootROM waits

Re: [PATCH u-boot-marvell 03/10] tools: kwboot: Cleanup bootmsg and debugmsg variables

2022-03-03 Thread Stefan Roese
On 3/2/22 11:49, Pali Rohár wrote: Function kwboot_debugmsg() is always called with kwboot_msg_debug as msg and function kwboot_bootmsg() with kwboot_msg_debug as msg. Function kwboot_bootmsg() is never called with NULL msg. Simplify, cleanup and remove dead code. No functional change.

Re: [PATCH u-boot-marvell 02/10] tools: kwboot: Remove msg_req_delay

2022-03-03 Thread Stefan Roese
On 3/2/22 11:49, Pali Rohár wrote: Variable msg_req_delay is set but never used. So completely remove it. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Tested-by: Stefan Roese Thanks, Stefan --- tools/kwboot.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff

Re: [PATCH u-boot-marvell 01/10] tools: kwboot: Check for return value of kwboot_tty_send() and tcflush()

2022-03-03 Thread Stefan Roese
On 3/2/22 11:49, Pali Rohár wrote: Failure of kwboot_tty_send() and tcflush() functions is fatal, it does not make sense to continue. So return error back to the caller like in other places where are called these functions. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Tested-by:

Re: [PATCH u-boot-marvell 00/10] tools: kwboot: Fix boot and terminal mode

2022-03-03 Thread Stefan Roese
Hi Pali, On 3/2/22 11:49, Pali Rohár wrote: This patch series fixes sending boot and debug patterns by doing it in separate thread. Entering BootROM debug mode via '-d' option is now more stable and working fine on Armada 385. There is also support for backspace key and updated documentation.

Re: [PATCH] drivers: rtc: fix null pointer access in armada38x_rtc_reset

2022-03-03 Thread Stefan Roese
On 2/28/22 10:31, fber...@outlook.fr wrote: From: Francois Berder Replace null pointer by pointer to device registers when calling armada38x_rtc_write. Signed-off-by: Francois Berder Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/rtc/armada38x.c | 2 +- 1 file changed, 1

Re: [PATCH] arm: kirkwood: nas220: Add DM Ethernet, SATA, GPIO

2022-03-03 Thread Stefan Roese
Hi Hajo, On 3/1/22 12:57, Hajo Noerenberg wrote: On 02/25/2022 00:19 Tony Dinh wrote: Hi Hajo, I've added Stefan to the reviewers. And please see a couple of minor comments below. On Thu, Feb 24, 2022 at 5:48 AM Hajo Noerenberg wrote: Bring the NAS220 board up to current standards. This

Re: [PATCH u-boot-marvell] arm64: a37xx: pinctrl: Fix PWM pins indexes

2022-03-03 Thread Stefan Roese
On 2/28/22 15:59, Marek Behún wrote: From: Marek Behún Commit 5534fb4f4833 ("arm64: a37xx: pinctrl: Correct PWM pins definitions") introduced bogus definitions os PWM pins: all 4 pins have index 11, instead of having indexes 11, 12, 13, 14. Fix this. Signed-off-by: Marek Behún

Re: [PATCH] ARM: mvebu: x530: clearfog: Add ODT configuration

2022-03-03 Thread Stefan Roese
On 3/1/22 01:53, Chris Packham wrote: Commit 369e532691e0 ("ddr: marvell: a38x: allow board specific ODT configuration") added the odt_config member to struct mv_ddr_topology_map ahead of the clk_enable and ck_delay members. This means that any boards that configured either of clk_enable or

Re: [PATCH] .mailmap: Record all address for main U-Boot contributor

2022-03-03 Thread Stefan Roese
On 3/1/22 12:43, Michal Simek wrote: Based on looking at top contributors it was seen that top statistics from top contributors don't include all contributions from different email addresses. That's why I checked all top contributors are checked it. git shortlog -n $START..$END -e -s The patch

Re: [PATCH u-boot-mvebu] watchdog: armada_37xx: Probe driver also when watchdog is already running

2022-03-03 Thread Stefan Roese
On 2/23/22 14:21, Pali Rohár wrote: If Armada 37xx watchdog is started before U-Boot then CNTR_CTRL_ACTIVE bit is set, U-Boot armada-37xx-wdt.c driver fails to initialize and so U-Boot is unable to use or kick this watchdog. Do not check for CNTR_CTRL_ACTIVE bit and always initialize watchdog.

Re: [PATCH u-boot-marvell] arm: a37xx: pci: Fix a3700_fdt_fix_pcie_regions() function again

2022-03-03 Thread Stefan Roese
On 2/23/22 13:52, Marek Behún wrote: From: Pali Rohár The a3700_fdt_fix_pcie_regions() function still computes nonsense. It computes the fixup offset from the PCI address taken from the first row of the "ranges" array, which means that: - PCI address must equal CPU address (otherwise the

Re: [PATCH 24/27] imx: imx8ulp_evk: enlarge CONFIG_NR_DRAM_BANKS

2022-03-03 Thread Peng Fan (OSS)
On 2022/2/26 21:28, Fabio Estevam wrote: Hi Peng, On Mon, Feb 14, 2022 at 9:09 AM Peng Fan (OSS) wrote: From: Peng Fan When TEE is present, the DRAM maybe split to two parts, so enlarge CONFIG_NR_DRAM_BANKS I think this description is confusing. CONFIG_NR_DRAM_BANKS should be set

Re: [PATCH 02/27] imx: imx8ulp: include pcc/cgc header in clock header

2022-03-03 Thread Peng Fan (OSS)
On 2022/2/26 21:34, Fabio Estevam wrote: On Mon, Feb 14, 2022 at 9:08 AM Peng Fan (OSS) wrote: From: Peng Fan Only including clock.h could simplify header files. Sorry, I don't understand this commit log. Signed-off-by: Peng Fan --- arch/arm/include/asm/arch-imx8ulp/clock.h | 3

Re: [PATCH u-boot-marvell 00/10] tools: kwboot: Fix boot and terminal mode

2022-03-03 Thread Tony Dinh
Hi Pali, It seems the problem was with the ActionTec MI424WR-I board quirk. It has nothing to do with the new kwboot on Avanta SoC. Sorry for the false alarm! I spent a couple hours running with various delays for the option -s, even with 50, and it all works fine! Uhm... So I went back to the

Re: [PATCH] usb: dwc3: Add support for usb3-phy PHY configuration

2022-03-03 Thread Marek Vasut
On 3/3/22 09:40, Bin Meng wrote: On Wed, Feb 23, 2022 at 10:56 PM Michal Simek wrote: When usb3-phy label is found, PHY driver is called and serdes line is initialized. This is preparation for serdes/psgtr driver to configure GT lines based on description in DT. Signed-off-by: Michal Simek

Re: [PATCH 1/2] x86: Add an enum name for the GNVS firmware type

2022-03-03 Thread Simon Glass
Hi Bin, On Thu, 3 Mar 2022 at 01:49, Bin Meng wrote: > > Hi Simon, > > On Tue, Mar 1, 2022 at 6:18 AM Simon Glass wrote: > > > > This enum is currently anonymous. Add a name so it can be used in the > > code. > > > > Signed-off-by: Simon Glass > > --- > > > > arch/x86/include/asm/intel_gnvs.h

Re: [PATCH v2 07/10] tpm: rng: Move the TPM RNG functionality to driver model

2022-03-03 Thread Simon Glass
Hi Sughosh, On Thu, 3 Mar 2022 at 05:07, Sughosh Ganu wrote: > > hi Simon, > > On Thu, 3 Mar 2022 at 09:17, Simon Glass wrote: > > > > Hi Sughosh, > > > > On Tue, 1 Mar 2022 at 21:36, Sughosh Ganu wrote: > > > > > > hi Simon, > > > > > > On Tue, 1 Mar 2022 at 20:28, Simon Glass wrote: > > > >

Re: [PATCH v2 08/10] tpm: Add the RNG child device

2022-03-03 Thread Simon Glass
Hi Sughosh, On Thu, 3 Mar 2022 at 05:11, Sughosh Ganu wrote: > > hi Simon, > > On Thu, 3 Mar 2022 at 09:18, Simon Glass wrote: > > > > Hi Sughosh, > > > > On Tue, 1 Mar 2022 at 21:53, Sughosh Ganu wrote: > > > > > > hi Simon, > > > > > > On Tue, 1 Mar 2022 at 20:29, Simon Glass wrote: > > > >

Re: [PATCH 00/17] arm: semihosting: Cleanups and new features

2022-03-03 Thread Linus Walleij
Hi Sean, I like the ambition in this series! On Thu, Mar 3, 2022 at 9:44 PM Sean Anderson wrote: > The main device affected by these changes is vexpress64, so I'd appreciate > if Linus (or anyone else) could try booting. I am currently on parental leave and pretty far removed from that

Re: [PATCH u-boot-marvell 00/10] tools: kwboot: Fix boot and terminal mode

2022-03-03 Thread Pali Rohár
Hello! On Thursday 03 March 2022 15:58:41 Tony Dinh wrote: > Hi Pali, > > Here is the test report. > > 1. Kirkwood SoC > > Tested with Seagate GoFlex Home board (88F6281): > - Everything is working fine as before. > - kwboot -d also works to get BootROM into debug mode. > - At the BootROM

Re: [PATCH u-boot-marvell 00/10] tools: kwboot: Fix boot and terminal mode

2022-03-03 Thread Tony Dinh
Hi Pali, Here is the test report. 1. Kirkwood SoC Tested with Seagate GoFlex Home board (88F6281): - Everything is working fine as before. - kwboot -d also works to get BootROM into debug mode. - At the BootROM command line, x 0x5 selected boot source NAND, and started booting from u-boot in

[PATCH v3 11/12] arm: dts: rockchip: sync rk3288-veyron DT from Linux

2022-03-03 Thread Johan Jonker
Sync rk3288-veyron DT from Linux version 5.17. Signed-off-by: Johan Jonker --- Changed V3: update change reg size Changed V2: update add label spi_flash veyron --- arch/arm/dts/rk3288-veyron-analog-audio.dtsi | 99 +++ .../dts/rk3288-veyron-broadcom-bluetooth.dtsi | 22 +

[PATCH v3 10/12] arm: dts: rockchip: sync rk3288 DT boards from Linux

2022-03-03 Thread Johan Jonker
Sync rk3288 DT boards that have support both in Linux 5.17 as in U-boot. Signed-off-by: Johan Jonker --- Change V3: update change reg size delete more files Changed V2: update change led labels --- arch/arm/dts/rk3288-firefly-u-boot.dtsi | 4 +- arch/arm/dts/rk3288-firefly.dts

[PATCH v3 12/12] rockchip: fix boot_devices constants

2022-03-03 Thread Johan Jonker
The DT node name pattern in mmc-controller.yaml for mmc is "^mmc(@.*)?$". The Rockchip mmc nodes have been synced with Linux, so update the boot_devices constants as well. Signed-off-by: Johan Jonker Reviewed-by: Simon Glass --- arch/arm/mach-rockchip/rk3188/rk3188.c | 4 ++--

[PATCH v3 09/12] arm: dts: rockchip: sync rk3288.dtsi from Linux

2022-03-03 Thread Johan Jonker
Sync rk3288.dtsi from Linux version 5.17. Signed-off-by: Johan Jonker --- Changed V3: change reg size Changed V2: rename mipi_dsi0 label move io_domains remove hdmi_audio veyron node change memory@0 reg size --- arch/arm/dts/rk3288-evb.dtsi |2 +-

[PATCH v3 04/12] arm: dts: rockchip: sync rk322x.dtsi from Linux

2022-03-03 Thread Johan Jonker
Sync rk322x.dtsi from Linux version 5.17. Signed-off-by: Johan Jonker --- Changed V2: update rename usb20_otg label --- arch/arm/dts/rk3229-evb.dts | 2 +- arch/arm/dts/rk322x.dtsi| 846 +--- 2 files changed, 695 insertions(+), 153 deletions(-) diff

[PATCH v3 08/12] arm: dts: rockchip: move all rk3288 u-boot specific properties in separate dtsi files

2022-03-03 Thread Johan Jonker
In order to sync rk3288.dtsi from Linux it needed to move all u-boot specific properties in separate dtsi files. Signed-off-by: Johan Jonker --- Changed V3: add u-boot,dm-pre-reloc to noc node change reg size rk3288-u-boot.dtsi Changed V2: combine U-boot specific changes add bus_intmem

[PATCH v3 07/12] rockchip: rk3288-cru: sync the clock dt-binding header from Linux

2022-03-03 Thread Johan Jonker
In order to update the DT for rk3288 sync the clock dt-binding header. This is the state as of v5.17 in Linux. Keep SCLK_MAC_PLL in use for rk3288 clock driver. Signed-off-by: Johan Jonker Reviewed-by: Simon Glass --- include/dt-bindings/clock/rk3288-cru.h | 13 - 1 file changed,

[PATCH v3 06/12] rockchip: rk3288-power: sync power domain dt-binding header from Linux

2022-03-03 Thread Johan Jonker
In order to update the DT for rk3288 sync the power domain dt-binding header. This is the state as of v5.17 in Linux. Change location to be more in line with other SoCs. Signed-off-by: Johan Jonker --- Changed V2: changed include rk3288.dtsi --- arch/arm/dts/rk3288.dtsi | 2

[PATCH v3 05/12] arm: dts: rockchip: sync rk3229-evb.dts from Linux

2022-03-03 Thread Johan Jonker
Sync rk3229-evb.dts from Linux version 5.17. Signed-off-by: Johan Jonker --- arch/arm/dts/rk3229-evb.dts | 212 +--- arch/arm/dts/rk3229.dtsi| 52 + 2 files changed, 249 insertions(+), 15 deletions(-) create mode 100644 arch/arm/dts/rk3229.dtsi

[PATCH v3 03/12] arm: dts: rockchip: move all rk322x u-boot specific properties in separate dtsi files

2022-03-03 Thread Johan Jonker
In order to sync rk322x.dtsi from Linux, move all U-boot specific properties in separate dtsi files. Signed-off-by: Johan Jonker --- Changed V3: add include "rockchip-u-boot.dtsi" --- arch/arm/dts/rk3229-evb-u-boot.dtsi | 28 +++ arch/arm/dts/rk3229-evb.dts | 17 -

[PATCH v3 02/12] rockchip: rk3228-cru: sync the clock dt-binding header from Linux

2022-03-03 Thread Johan Jonker
In order to update the DT for rk3228 sync the clock dt-binding header. This is the state as of v5.17 in Linux. Signed-off-by: Johan Jonker Reviewed-by: Simon Glass --- include/dt-bindings/clock/rk3228-cru.h | 54 +- 1 file changed, 52 insertions(+), 2 deletions(-) diff

[PATCH v3 01/12] rockchip: rk3228-power: sync power domain dt-binding header from Linux

2022-03-03 Thread Johan Jonker
In order to update the DT for rk3228 sync the power domain dt-binding header. This is the state as of v5.17 in Linux. Signed-off-by: Johan Jonker Reviewed-by: Simon Glass --- include/dt-bindings/power/rk3228-power.h | 21 + 1 file changed, 21 insertions(+) create mode

Re: [PATCH v2 23/25] rockchip: Support building the all output files in binman

2022-03-03 Thread Peter Geis
On Thu, Mar 3, 2022 at 4:17 PM Alper Nebi Yasak wrote: > > On 03/03/2022 01:16, Peter Geis wrote: > > On Wed, Feb 23, 2022 at 6:04 PM Simon Glass wrote: > >> diff --git a/arch/arm/dts/rockchip-u-boot.dtsi > >> b/arch/arm/dts/rockchip-u-boot.dtsi > >> index eae3ee715d..64e4466489 100644 > >> ---

Re: [RFC] [PATCH] binman: support mkimage split files

2022-03-03 Thread Alper Nebi Yasak
On 01/03/2022 05:48, Peter Geis wrote: > Good Evening, > > I successfully tested your v2 patch series to create a bootable sdcard > image out of the box for rockpro64-rk3399. > Unfortunately, rk356x and rk3399-spi modes are broken, due to the > inability to pass multiple images to mkimage at the

Re: [PATCH v2 23/25] rockchip: Support building the all output files in binman

2022-03-03 Thread Alper Nebi Yasak
On 03/03/2022 01:16, Peter Geis wrote: > On Wed, Feb 23, 2022 at 6:04 PM Simon Glass wrote: >> diff --git a/arch/arm/dts/rockchip-u-boot.dtsi >> b/arch/arm/dts/rockchip-u-boot.dtsi >> index eae3ee715d..64e4466489 100644 >> --- a/arch/arm/dts/rockchip-u-boot.dtsi >> +++

Re: [PATCH v2 22/25] rockchip: Include binman script in 64-bit boards

2022-03-03 Thread Alper Nebi Yasak
On 24/02/2022 02:00, Simon Glass wrote: > Include the rockchip-u-boot.dtsi file with 64-bit boards and enable binman > so that these boards can also use it, rather than using special Makefile > rules and scripts. > > This does not change the Makefile nor remove any scripts, but sets it up > so

Re: [PATCH v2 20/25] binman: Support splitting an ELF file into multiple nodes

2022-03-03 Thread Alper Nebi Yasak
On 24/02/2022 02:00, Simon Glass wrote: > Some boards need to load an ELF file using the 'loadables' property, but > the file has segments at different memory addresses. This means that it > cannot be supplied as a flat binary. > > Allow generating a separate node in the FIT for each segment in

Re: [PATCH v2 19/25] binman: Keep a separate list of entries for fit

2022-03-03 Thread Alper Nebi Yasak
On 24/02/2022 02:00, Simon Glass wrote: > The current implementation sets up the FIT entries but then deletes the > 'generator' ones so they don't appear in the final image. They still show up in the fdtmap if I add one to rockchip-u-boot.dtsi: $ binman ls -i u-boot-rockchip.bin Name

Re: [PATCH v2 18/25] binman: Update fit to use node instead of subnode

2022-03-03 Thread Alper Nebi Yasak
On 24/02/2022 02:00, Simon Glass wrote: > It doesn't make sense to use 'subnode' as a function parameter since it > is just a 'node' so far as the function is concerned. Update two functions > to use 'node' instead. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > >

Re: [PATCH v2 17/25] binman: Add a consistent way to report errors with fit

2022-03-03 Thread Alper Nebi Yasak
On 24/02/2022 02:00, Simon Glass wrote: > Add a new function to handling reporting errors within a particular > subnode of the FIT description. This can be used to make the format of > these errors consistent. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > >

Re: [PATCH v2 16/25] binman: Fix some pylint warnings in fit

2022-03-03 Thread Alper Nebi Yasak
On 24/02/2022 02:00, Simon Glass wrote: > Some warnings have crept in, so fix those that are easy to fix. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > tools/binman/etype/fit.py | 50 +++ > 1 file changed, 25 insertions(+), 25

Re: [PATCH v2 15/25] binman: Read the fit entries only once

2022-03-03 Thread Alper Nebi Yasak
On 24/02/2022 02:00, Simon Glass wrote: > At present the entries are read twice, once by the entry_Section class > and once by the FIT implementation. This is harmless but can be confusing > when debugging. Fix it. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > >

Re: [PATCH v2 14/25] binman: Allow mkimage to use a non-zero fake-blob size

2022-03-03 Thread Alper Nebi Yasak
On 24/02/2022 02:00, Simon Glass wrote: > Unfortunately mkimage gets upset with zero-sized files. Update the > ObtainContents() method to support specifying the size, if a fake blob is > created. > > Signed-off-by: Simon Glass > --- > > Changes in v2: > - Add a patch to allow mkimage to use a

Re: [PATCH v2 13/25] binman: Make fake blobs zero-sized by default

2022-03-03 Thread Alper Nebi Yasak
On 24/02/2022 02:00, Simon Glass wrote: > On x86 devices having even a small amount of data can cause an overlap > between regions. For example, bayleybay complains when the intel-vga > region overlaps with u-boot-ucode: > >ImagePosOffset Size Name > 0080

Re: [PATCH v2 12/25] binman: Change how faked blobs are created

2022-03-03 Thread Alper Nebi Yasak
On 24/02/2022 02:00, Simon Glass wrote: > At present fake blobs are created but internally an empty blob is used. > Change it to use the contents of the faked file. Also return whether the > blob was faked, in case the caller needs to know that. > > Add a TODO to put fake blobs in their own

Re: [PATCH v2 10/25] binman: Refactor fit to generate output at the end

2022-03-03 Thread Alper Nebi Yasak
On 24/02/2022 02:00, Simon Glass wrote: > At present the fit implementation creates the output tree while > scanning the FIT description. Then it updates the tree later when the > data is known. > > This works, but is a bit confusing, since it requires mixing the scanning > code with the

Re: [PATCH v2 11/25] binman: Rename tools parameter to btools

2022-03-03 Thread Alper Nebi Yasak
On 24/02/2022 02:00, Simon Glass wrote: > This shadows the patman.tools library so rename it to avoid a pylint > warning. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > tools/binman/entry.py| 4 ++-- > tools/binman/etype/fit.py| 6 +++--- >

Re: [PATCH v2 09/25] binman: Rename ExpandEntries to gen_entries

2022-03-03 Thread Alper Nebi Yasak
On 24/02/2022 02:00, Simon Glass wrote: > Leave the 'expand' term for use by entry types which have an expanded > version of themselves. Rename this method to indicate that it generates > subentries. > > Signed-off-by: Simon Glass > --- > > Changes in v2: > - Add patch to rename ExpandEntries

Re: [PATCH v2 08/25] binman: Rename ExpandToLimit to extend_to_limit

2022-03-03 Thread Alper Nebi Yasak
On 24/02/2022 02:00, Simon Glass wrote: > The word 'expand' is used for entries which generate subentries. It is > also used for entries that can have an '_expanded' version which is used > to break out its contents. > > Rather than talking about expanding an entry's size, use the term >

Re: [PATCH v2 07/25] binman: Tweak collect_contents_to_file() and docs

2022-03-03 Thread Alper Nebi Yasak
On 24/02/2022 02:00, Simon Glass wrote: > Update the return value of this function, fix the 'create' typo and > update the documentation for clarity. > > Signed-off-by: Simon Glass > Suggested-by: Alper Nebi Yasak > --- > > Changes in v2: > - Add new patch to tweak collect_contents_to_file()

Re: [PATCH v2 06/25] elf: Rename load_segments() and module failure

2022-03-03 Thread Alper Nebi Yasak
On 24/02/2022 02:00, Simon Glass wrote: > Rename this function to make it clear that it only reads loadable > segments. Also update the error for missing module to better match the > message emitted by Python. > > Signed-off-by: Simon Glass > Suggested-by: Alper Nebi Yasak > --- > > Changes in

Re: [PATCH v2 05/25] dtoc: Tidy up implementation of AddStringList()

2022-03-03 Thread Alper Nebi Yasak
On 24/02/2022 02:00, Simon Glass wrote: > Refactor this to avoid a loop. Also add a test for an empty string. > > Signed-off-by: Simon Glass > Suggested-by: Alper Nebi Yasak > --- > > Changes in v2: > - Add new patch to tidy up implementaiton of AddStringList() > > tools/dtoc/fdt.py | 4

Re: [PATCH v2 04/25] spl: Correct Kconfig help for TPL_BINMAN_SYMBOLS

2022-03-03 Thread Alper Nebi Yasak
On 24/02/2022 02:00, Simon Glass wrote: > Fix the help which should refer to TPL, not SPL. > > Signed-off-by: Simon Glass > Suggested-by: Alper Nebi Yasak > --- > > Changes in v2: > - Add new patch to correct Kconfig help for TPL_BINMAN_SYMBOLS > > common/spl/Kconfig | 6 +++--- > 1 file

Re: [PATCH v2 03/25] moveconfig: Use re.fullmatch() to avoid extra check

2022-03-03 Thread Alper Nebi Yasak
On 24/02/2022 02:00, Simon Glass wrote: > Simplify the code by using the available function. > > Signed-off-by: Simon Glass > --- > > Changes in v2: > - Add new patch to use re.fullmatch() to avoid extra check > > tools/moveconfig.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [PATCH v2 02/25] moveconfig: Remove remove_defconfig()

2022-03-03 Thread Alper Nebi Yasak
On 24/02/2022 02:00, Simon Glass wrote: > This is not necessary if simpler code is used. Use the split function and > drop the unnecessary [] > > Signed-off-by: Simon Glass > Suggested-by: Alper Nebi Yasak > --- > > Changes in v2: > - Add new patch to remove remove_defconfig() > >

Re: [PATCH v2 01/25] dtoc: Make GetArgs() more flexible

2022-03-03 Thread Alper Nebi Yasak
On 24/02/2022 02:00, Simon Glass wrote: > At present it is not possible to have arguments whic include spaces. whic -> which > Update the function to only split the args if the property is a single > string. This is a bit inconsistent, but might still be useful. > > Signed-off-by: Simon Glass

Re: [PATCH 20/24] binman: Support splitting an ELF file into multiple nodes

2022-03-03 Thread Alper Nebi Yasak
On 24/02/2022 01:59, Simon Glass wrote: > On Tue, 15 Feb 2022 at 04:53, Alper Nebi Yasak > wrote: >> On 08/02/2022 21:50, Simon Glass wrote: >>> +fit,load >>> +Generates a `load = <...>` property with the load address of the >>> +segmnet >>> + >>> +fit,entry >>> +

Re: [PATCH 09/24] dtoc: Support reading a list of arguments

2022-03-03 Thread Alper Nebi Yasak
On 24/02/2022 01:58, Simon Glass wrote: > On Tue, 15 Feb 2022 at 04:53, Alper Nebi Yasak > wrote: >>> diff --git a/tools/dtoc/fdt_util.py b/tools/dtoc/fdt_util.py >>> index 19eb13aef3..59e065884f 100644 >>> --- a/tools/dtoc/fdt_util.py >>> +++ b/tools/dtoc/fdt_util.py >>> @@ -184,6 +184,18 @@

Re: [PATCH 06/24] dtoc: Support adding a string list to a device tree

2022-03-03 Thread Alper Nebi Yasak
On 24/02/2022 01:58, Simon Glass wrote: > On Tue, 15 Feb 2022 at 04:53, Alper Nebi Yasak > wrote: >> On 08/02/2022 21:49, Simon Glass wrote: >>> diff --git a/tools/dtoc/fdt.py b/tools/dtoc/fdt.py >>> index 32a7aa9829..e7197f8f12 100644 >>> --- a/tools/dtoc/fdt.py >>> +++ b/tools/dtoc/fdt.py >>>

Re: [PATCH 03/24] spl: x86: Correct the binman symbols for SPL

2022-03-03 Thread Alper Nebi Yasak
On 24/02/2022 01:58, Simon Glass wrote: > Hi Alper, > > On Tue, 15 Feb 2022 at 04:52, Alper Nebi Yasak > wrote: >> >> On 08/02/2022 21:49, Simon Glass wrote: >>> These symbols are incorrect, meaning that binman cannot find the >>> associated entry. This leads to errors like: >>> >>> binman:

[PATCH 15/17] serial: Add semihosting driver

2022-03-03 Thread Sean Anderson
This adds a serial driver which uses semihosting calls to read and write to the host's console. For convenience, if CONFIG_DM_SERIAL is enabled, we will instantiate a serial driver. This allows users to enable this driver (which has no physical device) without modifying their device trees or board

[PATCH 17/17] ls1046ardb: Add support for JTAG boot

2022-03-03 Thread Sean Anderson
This adds support for booting entirely from JTAG while using a hard-coded RCW. With these steps, it is not necessary to program a "good" RCW using CodeWarrior. The method here can be performed with any JTAG adapter supported by OpenOCD, including the on-board CMSIS-DAP (albeit very slowly). These

[PATCH 16/17] doc: smh: Update semihosting documentation

2022-03-03 Thread Sean Anderson
This documents the new semihosting features added in the past few commits. Signed-off-by: Sean Anderson --- doc/usage/semihosting.rst | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/doc/usage/semihosting.rst b/doc/usage/semihosting.rst index

[PATCH 13/17] arm: smh: Remove smhload command

2022-03-03 Thread Sean Anderson
This command's functionality is now completely implemented by the standard fs load command. Convert the vexpress64 boot command (which is the only user) and remove the implementation. Signed-off-by: Sean Anderson --- arch/arm/lib/semihosting.c | 76 --

[PATCH 14/17] arm: smh: Add some functions for working with the host console

2022-03-03 Thread Sean Anderson
This adds three wrappers around the semihosting commands for reading and writing to the host console. We use the more standard getc/putc/puts names instead of readc/writec/write0 for familiarity. Signed-off-by: Sean Anderson --- arch/arm/lib/semihosting.c | 18 ++

[PATCH 12/17] cmd: fdt: Use start/size for chosen instead of start/end

2022-03-03 Thread Sean Anderson
Most U-Boot command deal with start/size instead of start/end. Convert the "fdt chosen" command to use these semantics as well. The only user of this subcommand is vexpress, so convert the smhload command to use this as well. We don't bother renaming the variable in vexpress64's bootcommand, since

[PATCH 11/17] fs: Add semihosting filesystem

2022-03-03 Thread Sean Anderson
This adds a filesystem which is backed by the host's filesystem. It is modeled off of sandboxfs, which has very similar aims. Semihosting doesn't support listing directories (except with SYS_SYSTEM), so neither do we. it's possible to optimize a bit for the common case of reading a whole file by

[PATCH 10/17] spl: Add semihosting boot method

2022-03-03 Thread Sean Anderson
This adds a boot method for loading the next stage from the host. It is mostly modeled off of spl_load_image_ext. I am not really sure why/how spl_load_image_fat uses three different methods to load the image, but the simple case seems to work OK for now. To control the presence of this boot

[PATCH 09/17] arm: smh: Add some file manipulation commands

2022-03-03 Thread Sean Anderson
In order to add filesystem support, we will need to be able to seek and write files. Add the appropriate helper functions. Signed-off-by: Sean Anderson --- arch/arm/lib/semihosting.c | 67 +++--- include/semihosting.h | 20 2 files changed, 76

[PATCH 05/17] arm: smh: Export semihosting functions

2022-03-03 Thread Sean Anderson
This exports semihosting functions for use in other files. The header is in include/ and not arm/include/asm because I anticipate that RISC-V may want to add their own implementation at some point. smh_len_fd has been renamed to smh_flen to more closely match the semihosting spec. Signed-off-by:

[PATCH 08/17] arm: smh: Document functions in header

2022-03-03 Thread Sean Anderson
This adds some documentation for semihosting functions in the header. Signed-off-by: Sean Anderson --- arch/arm/lib/semihosting.c | 9 - include/semihosting.h | 32 2 files changed, 32 insertions(+), 9 deletions(-) diff --git

[PATCH 06/17] arm: smh: Use numeric modes for smh_open

2022-03-03 Thread Sean Anderson
There's no point in using string constants for smh_open if we are just going to have to parse them. Instead, use numeric modes. The user needs to be a bit careful with these, since they are much closer semantically to string modes used by fopen(3) than the numeric modes used with open(2).

[PATCH 07/17] arm: smh: Return errno on error

2022-03-03 Thread Sean Anderson
Instead of printing in what are now library functions, try to return a numeric error code. This also adjust some functions (such as read) to behave more similarly to read(2). For example, we now return the number of bytes read instead of failing immediately on a short read. Signed-off-by: Sean

[PATCH 04/17] arm: smh: Add semihosting entry to MAINTAINERS

2022-03-03 Thread Sean Anderson
These files are spread all over the tree, so just use a regex. Orphaned for now, since this is more of a "one-off" series. Though I'll be happy to review patches. Signed-off-by: Sean Anderson --- MAINTAINERS | 4 1 file changed, 4 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS

[PATCH 03/17] doc: ls1046ardb: Expand boot mode section

2022-03-03 Thread Sean Anderson
This adds some additional info about booting from different sources, including the correct switch positions. Signed-off-by: Sean Anderson --- doc/board/nxp/ls1046ardb.rst | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/doc/board/nxp/ls1046ardb.rst

[PATCH 02/17] nxp: ls1046ardb: Convert README to rST

2022-03-03 Thread Sean Anderson
This converts the readme for this board to rST. I have tried not to change any semantics from the original (though I did convert MB to M). Signed-off-by: Sean Anderson --- board/freescale/ls1046ardb/MAINTAINERS | 1 + board/freescale/ls1046ardb/README | 76 ---

[PATCH 00/17] arm: semihosting: Cleanups and new features

2022-03-03 Thread Sean Anderson
This cleans up the semihosting code and adds the following new features: - hostfs support (like sandbox) - support for being used as a SPL boot device - serial device support The main device affected by these changes is vexpress64, so I'd appreciate if Linus (or anyone else) could try booting.

[PATCH 01/17] doc: Convert semihosting readme to rST

2022-03-03 Thread Sean Anderson
This converts the semihosting readme to rST. I have tried to make only cosmetic changes, but I did fix up the first link (which was broken). Signed-off-by: Sean Anderson --- doc/usage/index.rst | 1 + .../semihosting.rst} | 35

Re: [PATCH v2 5/5] clk: scmi: register scmi clocks with CCF

2022-03-03 Thread Tom Rini
On Mon, Feb 21, 2022 at 09:22:42AM +0100, Etienne Carriere wrote: > Implements SCMI APIs to retrieve the number exposed SCMI clocks using > SCMI_PROTOCOL_ATTRIBUTES messages and the names of the clocks using > SCMI_CLOCK_ATTRIBUTES messages. > > This change updates sandbox SCMI clock test driver

Re: [PATCH v2 4/5] firmware: scmi: fix sandbox and related tests for clock discovery

2022-03-03 Thread Tom Rini
On Mon, Feb 21, 2022 at 09:22:41AM +0100, Etienne Carriere wrote: > Updates sandbox SCMI clock driver and tests since enabling CCF will > mandate clock discovery that is all exposed SCMI clocks shall be > discovered at initialization. For this reason, sandbox SCMI clock > driver must emulate all

Re: [PATCH v2 3/5] scmi: change parameter dev in devm_scmi_process_msg

2022-03-03 Thread Tom Rini
On Mon, Feb 21, 2022 at 09:22:40AM +0100, Etienne Carriere wrote: > Changes devm_scmi_process_msg() first argument from target parent device > to current SCMI device and lookup the SCMI agent device among SCMI device > parents for find the SCMI agent operator needed for communication with > the

Re: [PATCH v2 2/5] sandbox: scmi: test against a single scmi agent

2022-03-03 Thread Tom Rini
On Mon, Feb 21, 2022 at 09:22:39AM +0100, Etienne Carriere wrote: > As per DT bindings since Linux kernel v5.14, the device tree can define > only 1 SCMI agent node that is named scmi [1]. As a consequence, change > implementation of the SCMI driver test through sandbox architecture to > reflect

Re: [PATCH v2 1/5] doc: binding: scmi: link to latest Linux kernel binding

2022-03-03 Thread Tom Rini
On Mon, Feb 21, 2022 at 09:22:38AM +0100, Etienne Carriere wrote: > Changes SCMI bindings documentation to relate to Linux kernel > source tree that recently changed the bindings description to YAML > format. > > Reviewed-by: Patrick Delaunay > Signed-off-by: Etienne Carriere Applied to

Re: [PATCH v4 0/5] fs/erofs: new filesystem

2022-03-03 Thread Tom Rini
On Thu, Mar 03, 2022 at 10:51:18PM +0800, Huang Jianan wrote: > Hi Tom, > > Would you mind taking some time to check if this version meets > the requirements ?So we could have a chance to be merged > into the next version ? > > I have triggered a CI via Github PR based on this version : >

Re: [PATCH v2 12/12] rockchip: fix boot_devices constants

2022-03-03 Thread Johan Jonker
On 3/3/22 15:37, Johan Jonker wrote: > Hi Simon, > > Thank you for your test report. > As I don't always have the hardware, could the board maintainers help me > identify u-boot specific property differences with Linux that need to be > moved to a dtsi file. > > Will send a new serie with

Re: [PULL] u-boot-at91-fixes-2022.04-a

2022-03-03 Thread Tom Rini
On Thu, Mar 03, 2022 at 10:08:29AM +, eugen.hris...@microchip.com wrote: > Hello Tom, > > Please pull tag u-boot-at91-fixes-2022.04-a , the first set of at91 > fixes for the next cycle 2022.04 . > > This fixes set includes only a single fix for the Ethernet on sama7g5ek > board which is

Re: pull request of u-boot-fsl-qoriq for v2022.04

2022-03-03 Thread Tom Rini
On Thu, Mar 03, 2022 at 06:05:47AM +, Priyanka Jain wrote: > Dear Tom, > > Please find my pull-request for u-boot-fsl-qoriq/master > https://github.com/u-boot/u-boot/pull/132 > > Summary > > Update and fixes for sl28, lx2, pblimage generation for some powerpc products > > Regards >

Re: [PATCH 06/14] misc: Add support for nvmem cells

2022-03-03 Thread Sean Anderson
Hi Simon, On 3/1/22 9:58 AM, Simon Glass wrote: > Hi Sean, > > On Mon, 28 Feb 2022 at 09:43, Sean Anderson wrote: >> >> >> >> On 2/26/22 1:36 PM, Simon Glass wrote: >> > Hi Sean, >> > >> > On Mon, 7 Feb 2022 at 16:42, Sean Anderson wrote: >> >> >> >> This adds support for "nvmem cells" as seen

Re: [PATCH] arm: Add AM335x based CBC board

2022-03-03 Thread Tom Rini
On Thu, Mar 03, 2022 at 03:48:46PM +0100, Lukasz Majewski wrote: > Hi Tom, > > > On Thu, Mar 03, 2022 at 03:07:47PM +0100, Lukasz Majewski wrote: > > > Hi Tom, > > > > > > > On Thu, Mar 03, 2022 at 10:27:10AM +0100, Lukasz Majewski wrote: > > > > > Hi Tom, > > > > > > > > > > > This

Re: phy_connect_dev calling phy_reset???

2022-03-03 Thread Tim Harvey
On Mon, Feb 28, 2022 at 12:01 PM Tim Harvey wrote: > > Greetings, > > I'm wondering if it is proper in U-Boot for phy_connect_dev() to > always call phy_reset() which generates a soft reset via BMCR_RESET. > > For some (or most?) PHY's this resets specific PHY config such as > RGMII delays and

Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job ring driver model

2022-03-03 Thread Stefano Babic
Hi, On 03.03.22 14:41, Gaurav Jain wrote: Hi Stefano As we have not received any response from imx6dl_mamoj board maintainer. I propose the below solution --- a/arch/arm/mach-imx/Kconfig +++ b/arch/arm/mach-imx/Kconfig @@ -49,8 +49,8 @@ config USE_IMXIMG_PLUGIN config IMX_HAB - select

Re: [PATCH v4 0/5] fs/erofs: new filesystem

2022-03-03 Thread Huang Jianan
Hi Tom, Would you mind taking some time to check if this version meets the requirements ?So we could have a chance to be merged into the next version ? I have triggered a CI via Github PR based on this version : https://github.com/u-boot/u-boot/pull/133 Thanks, Jianan 在 2022/2/26 15:05, Huang

  1   2   >