Re: [PATCH 1/1] cmd: mmc: don't assign unused values

2022-05-03 Thread Minkyu Kang
Hi! 2022년 4월 26일 (화) 06:11, Heinrich Schuchardt < heinrich.schucha...@canonical.com>님이 작성: > Don't assign a value to variable speedmode which is never used. > > Signed-off-by: Heinrich Schuchardt > --- > cmd/mmc.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git

Re: [PATCH v2] spi: npcm-fiu: add NPCM7xx FIU controller driver

2022-05-03 Thread Jim Liu
Hi Jagan Thanks for your reply and correction. If you have any problems please let me know. On Tue, May 3, 2022 at 8:21 PM Jagan Teki wrote: > > From: Jim Liu > > Add Nuvoton NPCM BMC Flash Interface Unit(FIU) SPI master > controller driver using SPI-MEM interface. > > The FIU supports

Re: [PATCH] Convert CONFIG_MTD_CONCAT to Kconfig

2022-05-03 Thread Stefan Roese
On 03.05.22 11:24, Chris Packham wrote: This converts the following to Kconfig: CONFIG_MTD_CONCAT Signed-off-by: Chris Packham --- This touches octeontx_common.h but only to remove a line that is already commented out. Other than that etamin was the only board that had this enabled.

Re: [PATCH] cmd: mvebu: Hide bubt specific options when bubt is disabled

2022-05-03 Thread Stefan Roese
On 03.05.22 11:13, Pali Rohár wrote: CONFIG_MVEBU_NAND_BOOT, CONFIG_MVEBU_SPI_BOOT, CONFIG_MVEBU_MMC_BOOT and CONFIG_MVEBU_UBOOT_DFLT_NAME are unused when CONFIG_CMD_MVEBU_BUBT is not enabled. So hide them. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan ---

Re: [PATCH] arm: mvebu: Espressobin: Add NVMe to boot targets

2022-05-03 Thread Stefan Roese
On 03.05.22 11:01, Pali Rohár wrote: NVMe support is already enabled, so add it into boot targets. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- include/configs/mvebu_armada-37xx.h | 1 + 1 file changed, 1 insertion(+) diff --git

RE: [PATCH 3/8] spi: aspeed: Add ASPEED SPI controller driver

2022-05-03 Thread Chin-Ting Kuo
Hi Jagan, > -Original Message- > From: Jagan Teki > Sent: Tuesday, May 3, 2022 9:23 PM > To: Chin-Ting Kuo > Subject: Re: [PATCH 3/8] spi: aspeed: Add ASPEED SPI controller driver > > On Tue, May 3, 2022 at 6:44 PM Chin-Ting Kuo > wrote: > > > > Hi Jagan, > > > > Thanks for the

Re: [PATCH v3 01/18] virtio: pci: Allow exclusion of legacy driver

2022-05-03 Thread Tom Rini
On Thu, Apr 21, 2022 at 04:10:59PM +, Andrew Scull wrote: > Add a new config to control whether the driver for legacy virtio PCI > devices is included in the build. VIRTIO_PCI_LEGACY is included by > default when VIRTIO_PCI is selected, but it can also be independently > toggled. > >

[PATCH 7/7] sunxi: licheepi_nano: enable SPI flash

2022-05-03 Thread Andre Przywara
Many LicheePi Nano boards come with SPI flash soldered, which already works for booting the SPL and loading U-Boot proper. With the updated DTB, we can now also use the SPI flash from U-Boot proper, so enable the bits in the defconfig, to allow loading binaries from SPI flash. There seem to be

[PATCH 6/7] Revert "sunxi: f1c100s: Drop SYSRESET to enable reset functionality"

2022-05-03 Thread Andre Przywara
The original Allwinner F1C100 .dtsi imported from the Linux kernel tree used the wrong compatible string for the watchdog timer, so the Allwinner DM reset driver was not working properly. We worked around this by disabling the SYSRESET driver, so the hardcoded SPL reset driver took over. Now the

[PATCH 5/7] sunxi: F1C100s: update DT files from Linux

2022-05-03 Thread Andre Przywara
The initial U-Boot F1C100s port was based on the mainline kernel DT files, which were quite basic and were missing the essential MMC and SPI peripherals. While we could work around this in the SPL by hardcoding the required information, this left U-Boot proper without SD card or SPI flash support,

[PATCH 4/7] spi: sunxi: Add support for F1C100s SPI controller

2022-05-03 Thread Andre Przywara
The SPI controllers in the Allwinner F1Cx00 series of SoCs are compatible to the H3 IP. The only difference in the integration is the missing mod clock in the F1C100, instead the SPI clock is directly derived from the AHB clock. We *should* be able to model this through the DT, but the addition of

[PATCH 2/7] spi: sunxi: refactor SPI speed/mode programming

2022-05-03 Thread Andre Przywara
As George rightfully pointed out [1], the spi-sunxi driver programs the speed and mode settings only when the respective functions are called, but this gets lost over a call to release_bus(). That asserts the reset line, thus forces each SPI register back to its default value. Adding to that,

[PATCH 3/7] spi: sunxi: improve SPI clock calculation

2022-05-03 Thread Andre Przywara
The current SPI clock divider calculation has two problems: - We use a normal round-down division, which results in a divider typically being too small, resulting in a too high frequency on the bus. - The calculation for the power-of-two divider is very inaccurate, and again rounds down, which

[PATCH 1/7] clk: sunxi: implement clock driver for suniv f1c100s

2022-05-03 Thread Andre Przywara
From: George Hilliard The f1c100s has a clock tree similar to those of other sunxi parts. Add support for it. Signed-off-by: George Hilliard Signed-off-by: Yifan Gu Acked-by: Sean Anderson [Andre: add PIO and I2C] Signed-off-by: Andre Przywara --- drivers/clk/sunxi/Kconfig | 7

[PATCH 0/7] sunxi: F1C100s: enable MMC and SPI in U-Boot proper

2022-05-03 Thread Andre Przywara
So far the U-Boot proper support for the Allwinner F1C100 family of SoCs was really limited: we could realistically only deal with FEL booting, as there was no storage or network device acessible from U-Boot proper. This series enables the MMC and SPI controller, to be able to actually load

Re: [PATCH 1/1] dm: fix DM_EVENT dependencies

2022-05-03 Thread Tom Rini
On Tue, May 03, 2022 at 09:18:33PM +0200, Heinrich Schuchardt wrote: > CONFIG_DM_EVENT without CONFIG_EVENT is non-functional. Select instead > of imply CONFIG_EVENT. > > Remove superfluous stub in include/event.h. > > Fixes: 5b896ed5856f ("event: Add events for device probe/remove") >

Re: [PATCH] imx8mn_evk: Add the missing spl.bin entry

2022-05-03 Thread Tim Harvey
On Tue, May 3, 2022 at 12:03 PM Fabio Estevam wrote: > > From: Fabio Estevam > > The generated flash.bin does not boot the imx8mn evk LPDDR4 variant > as it misses the spl.bin description in binman. > > Add its entry to fix the boot on the imx8mn evk LPDDR4 variant. > > Signed-off-by: Fabio

[PATCH 1/1] dm: fix DM_EVENT dependencies

2022-05-03 Thread Heinrich Schuchardt
CONFIG_DM_EVENT without CONFIG_EVENT is non-functional. Select instead of imply CONFIG_EVENT. Remove superfluous stub in include/event.h. Fixes: 5b896ed5856f ("event: Add events for device probe/remove") Reported-by: Jan Kiszka Signed-off-by: Heinrich Schuchardt --- drivers/core/Kconfig | 2

Re: [PATCH 04/12] cmd: tlv_eeprom: convert functions used by command to api functions

2022-05-03 Thread Josua Mayer
\o/ Am 03.05.22 um 13:54 schrieb Stefan Roese: Hi Josua, On 03.05.22 09:17, Josua Mayer wrote: Am 03.05.22 um 09:16 schrieb Stefan Roese: On 02.05.22 16:18, Josua Mayer wrote: - prog_eeprom: write_tlvinfo_tlv_eeprom - update_crc: tlvinfo_update_crc - is_valid_tlv: is_valid_tlvinfo_entry -

[PATCH] imx8mn_evk: Add the missing spl.bin entry

2022-05-03 Thread Fabio Estevam
From: Fabio Estevam The generated flash.bin does not boot the imx8mn evk LPDDR4 variant as it misses the spl.bin description in binman. Add its entry to fix the boot on the imx8mn evk LPDDR4 variant. Signed-off-by: Fabio Estevam --- arch/arm/dts/imx8mn-evk-u-boot.dtsi | 4 +++- 1 file

[PATCH] rockchip: rk3328: nanopi-r2s: Use the sdcard for the env

2022-05-03 Thread Emmanuel Vadot
The NanoPi-R2S doesn't have eMMC so use the sdcard as the device to save the environment variables Signed-off-by: Emmanuel Vadot --- configs/nanopi-r2s-rk3328_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/nanopi-r2s-rk3328_defconfig b/configs/nanopi-r2s-rk3328_defconfig

[PATCH V2] nvmem: add driver handling U-Boot environment variables

2022-05-03 Thread Rafał Miłecki
From: Rafał Miłecki U-Boot stores its setup as environment variables. It's a list of key-value pairs stored on flash device with a custom header. This commit adds an NVMEM driver that: 1. Provides NVMEM access to environment vars binary data 2. Extracts variables as NVMEM cells It can be used

Re: [PATCH 09/17] imx: imx8mm/n/p-venice: enable pinctrl_wdog in SPL

2022-05-03 Thread Tim Harvey
On Tue, May 3, 2022 at 4:42 AM Peng Fan (OSS) wrote: > > From: Peng Fan > > Mark pinctrl_wdog as u-boot,dm-spl to clean up board code, > set_wdog_reset function could be handled by imx_watchdog.c driver. > > Signed-off-by: Peng Fan > --- > arch/arm/dts/imx8mm-venice-u-boot.dtsi | 4 >

Re: [PATCH 3/4] configs: imx8m: use common imx8m.h for i.MX8MP

2022-05-03 Thread Tim Harvey
On Tue, May 3, 2022 at 4:39 AM Peng Fan (OSS) wrote: > > From: Peng Fan > > Some SPL definitions could be gerneralized, so use imx8m.h for iMX8MP. > > Signed-off-by: Peng Fan > --- > include/configs/imx8m.h | 8 > include/configs/imx8mp_evk.h | 17 + >

Re: [PATCH 2/4] configs: imx8m: use common imx8m.h for i.MX8MN

2022-05-03 Thread Tim Harvey
On Tue, May 3, 2022 at 4:39 AM Peng Fan (OSS) wrote: > > From: Peng Fan > > Some SPL definitions could be gerneralized, so use imx8m.h for iMX8MN. > Peng, s/gerneralized/generalized (looks like that typo is all the patches in your series) Great cleanup - thanks! This is a great start to

Re: [PATCH 1/4] configs: imx8m: use common imx8m.h for i.MX8MM

2022-05-03 Thread Tim Harvey
On Tue, May 3, 2022 at 4:39 AM Peng Fan (OSS) wrote: > > From: Peng Fan > > Some SPL definitions could be gerneralized, so use imx8m.h for that. > i.MX8MN/Q/P will follow up. > > Signed-off-by: Peng Fan > --- > include/configs/imx8m.h | 29 + >

Re: [PATCH] Convert CONFIG_MTD_CONCAT to Kconfig

2022-05-03 Thread Tom Rini
On Tue, May 03, 2022 at 09:24:57PM +1200, Chris Packham wrote: > This converts the following to Kconfig: > CONFIG_MTD_CONCAT > > Signed-off-by: Chris Packham Reviewed-by: Tom Rini -- Tom signature.asc Description: PGP signature

Re: [PATCH] CI: Azure: Rework how we update MSYS2

2022-05-03 Thread Tom Rini
On Tue, May 03, 2022 at 11:06:24AM -0400, Tom Rini wrote: > On Tue, May 03, 2022 at 08:30:14AM -0400, Tom Rini wrote: > > > Based on reading https://www.msys2.org/docs/ci/ and "Other Systems" > > rework how we update MSYS2 to the current version. We run it once, to > > perform nothing other than

Re: [PATCH] CI: Azure: Rework how we update MSYS2

2022-05-03 Thread Tom Rini
On Tue, May 03, 2022 at 08:30:14AM -0400, Tom Rini wrote: > Based on reading https://www.msys2.org/docs/ci/ and "Other Systems" > rework how we update MSYS2 to the current version. We run it once, to > perform nothing other than being the first run, then we run pacman > twice. > >

Re: [PATCH v8 01/13] doc: Convert SPL documentation to ReST

2022-05-03 Thread Tom Rini
On Sat, Apr 30, 2022 at 12:56:45AM -0600, Simon Glass wrote: > Move this documentation over to .rst format. > > Signed-off-by: Simon Glass For the series, applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: Please pull u-boot-marvell/master

2022-05-03 Thread Tom Rini
On Mon, May 02, 2022 at 05:53:36PM +0200, Stefan Roese wrote: > Hi Tom, > > please pull this next batch of Marvell related patches: > Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 00/12] sunxi: Devicetree sync from Linux v5.18-rc1

2022-05-03 Thread Andre Przywara
On Mon, 2 May 2022 20:57:35 -0500 Samuel Holland wrote: Hi Samuel, > On 4/30/22 7:59 PM, Andre Przywara wrote: > >>> So those DT updates are really only important for mobile devices like > >>> the > >>> Pinephone, which probably don't use UEFI booting. > >> > >> We would really

Re: [PATCH 15/17] imx: phycore_imx8mm/p: clean up board watchdog code

2022-05-03 Thread Teresa Remmet
Am Dienstag, dem 03.05.2022 um 20:24 +0800 schrieb Peng Fan (OSS): > From: Peng Fan > > pinctrl_wdog already marked u-boot,dm-spl, so clean up board code. > set_wdog_reset function could be handled by imx_watchdog.c driver. Thank you for the cleanup! Tested on phyCORE-i.MX8MM and

Re: [PATCH 06/17] imx: imx8mm-data-modul-edm-sbc: enable pinctrl_wdog in SPL

2022-05-03 Thread Marek Vasut
On 5/3/22 14:24, Peng Fan (OSS) wrote: From: Peng Fan Add pinctrl_wdog. Mark pinctrl_wdog as u-boot,dm-spl to clean up board code, set_wdog_reset function could be handled by imx_watchdog.c driver. There is already pinctrl_watchdog_gpio . Any changes to the main DT should really be

Re: [PATCH 3/8] spi: aspeed: Add ASPEED SPI controller driver

2022-05-03 Thread Jagan Teki
On Tue, May 3, 2022 at 6:44 PM Chin-Ting Kuo wrote: > > Hi Jagan, > > Thanks for the review. > > > -Original Message- > > From: Jagan Teki > > Sent: Tuesday, May 3, 2022 8:32 PM > > To: Chin-Ting Kuo > > Subject: Re: [PATCH 3/8] spi: aspeed: Add ASPEED SPI controller driver > > > > On

RE: [PATCH 3/8] spi: aspeed: Add ASPEED SPI controller driver

2022-05-03 Thread Chin-Ting Kuo
Hi Jagan, Thanks for the review. > -Original Message- > From: Jagan Teki > Sent: Tuesday, May 3, 2022 8:32 PM > To: Chin-Ting Kuo > Subject: Re: [PATCH 3/8] spi: aspeed: Add ASPEED SPI controller driver > > On Thu, Apr 14, 2022 at 4:54 PM Chin-Ting Kuo > wrote: > > > > Add ASPEED BMC

[PATCH] common/console.c: prevent pre-console buffer contents from being added to itself

2022-05-03 Thread Rasmus Villemoes
I do not have any non-serial output devices, so a print_pre_console_buffer(PRE_CONSOLE_FLUSHPOINT2_EVERYTHING_BUT_SERIAL) does nothing for me. However, I was manually inspected the pre-console buffer using md.b, and I noticed that the early part of it was repeated. The reason is that the first

[PATCH] common/console.c: use CONFIG_VAL() with PRE_CON_BUF_* variables

2022-05-03 Thread Rasmus Villemoes
There is currently no support for PRE_CONSOLE_BUFFER in SPL, but if and when that gets implemented, one would almost certainly want to use a different address and/or size for the buffer (e.g., U-Boot proper might specify an address in DRAM and a generous buffer, while SPL would be much more

Help porting U-Boot to samsung-espresso3g

2022-05-03 Thread Mighty M
Hello! I am trying to get u boot running on the samsung-espresso3g (https://wiki.postmarketos.org/wiki/Samsung_Galaxy_Tab_2_7.0%22_(samsung-espresso3g)) but it gets stuck at the bootsplash (ie the Samsung logo). Here is my fork https://github.com/MightyM17/u-boot/tree/espresso-dev. Any guidance on

Re: [PATCH 3/8] spi: aspeed: Add ASPEED SPI controller driver

2022-05-03 Thread Jagan Teki
On Thu, Apr 14, 2022 at 4:54 PM Chin-Ting Kuo wrote: > > Add ASPEED BMC FMC/SPI memory controller driver with > spi-mem interface for AST2500 and AST2600 platform. > > There are three SPI memory controllers embedded in an ASPEED SoC. > - FMC: Named as Firmware Memory Controller. After AC on, MCU

[PATCH] CI: Azure: Rework how we update MSYS2

2022-05-03 Thread Tom Rini
Based on reading https://www.msys2.org/docs/ci/ and "Other Systems" rework how we update MSYS2 to the current version. We run it once, to perform nothing other than being the first run, then we run pacman twice. Signed-off-by: Tom Rini --- .azure-pipelines.yml | 5 +++-- 1 file changed, 3

Re: [PATCH v2 0/2] sf: dataflash: add support for AT45DB641E

2022-05-03 Thread Jagan Teki
On Tue, Apr 26, 2022 at 1:54 PM Luca Ellero wrote: > > Since AT45DB641E uses "extended device information" for reading JEDEC ID > we must first introduce support for this feature. > All code is borrowed from Linux kernel source code: > drivers/mtd/devices/mtd_dataflash.c > commit

[PATCH v1] imx: enable ahab on imx8qm-rom7720

2022-05-03 Thread Oliver Graute
enable ahab on imx8qm-rom7720 Signed-off-by: Oliver Graute --- configs/imx8qm_rom7720_a1_4G_defconfig | 1 + include/configs/imx8qm_rom7720.h | 7 +++ 2 files changed, 8 insertions(+) diff --git a/configs/imx8qm_rom7720_a1_4G_defconfig b/configs/imx8qm_rom7720_a1_4G_defconfig index

[PATCH v2] spi: npcm-fiu: add NPCM7xx FIU controller driver

2022-05-03 Thread Jagan Teki
From: Jim Liu Add Nuvoton NPCM BMC Flash Interface Unit(FIU) SPI master controller driver using SPI-MEM interface. The FIU supports single, dual or quad communication interface. The FIU controller driver provides flash access in UMA(User Mode Access) mode by using an indirect address/data

Re: [PATCH] mtd: spi-nor-ids: add Macronix flash entry

2022-05-03 Thread Jagan Teki
On Wed, Apr 27, 2022 at 9:27 AM wrote: > > From: Tien Fong Chee > > Add Macronix mx25u51245g flash entry, so this can be used on > SoCFPGA devices. > > Signed-off-by: Tien Fong Chee > --- Applied to u-boot-spi/master

[PATCH 13/17] imx: imx8mp_rsb7320a1: enable wdog driver model in SPL

2022-05-03 Thread Peng Fan (OSS)
From: Peng Fan Mark wdog1/pinctrl_wdog as u-boot,dm-spl to clean up board code, set_wdog_reset function could be handled by imx_watchdog.c driver. Signed-off-by: Peng Fan --- arch/arm/dts/imx8mp-rsb3720-a1-u-boot.dtsi | 8 board/advantech/imx8mp_rsb3720a1/imx8mp_rsb3720a1.c

Re: [PATCH 07/17] imx: engicam-imx8mm: drop unused macro

2022-05-03 Thread Michael Nazzareno Trimarchi
Hi On Tue, May 3, 2022 at 1:44 PM Peng Fan (OSS) wrote: > > From: Peng Fan > > Drop unused WDOG macro > > Signed-off-by: Peng Fan > --- > board/engicam/imx8mm/spl.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/board/engicam/imx8mm/spl.c b/board/engicam/imx8mm/spl.c > index

[PATCH 16/17] imx: verdin-imx8mm/p: cleanup board watchdog code

2022-05-03 Thread Peng Fan (OSS)
From: Peng Fan pinctrl_wdog already marked u-boot,dm-spl, so clean up board code. set_wdog_reset function could be handled by imx_watchdog.c driver. Signed-off-by: Peng Fan --- board/toradex/verdin-imx8mp/verdin-imx8mp.c | 11 --- 1 file changed, 11 deletions(-) diff --git

[PATCH 17/17] imx: toradex/verdin-imx8mm/p: cleanup board watchdog code

2022-05-03 Thread Peng Fan (OSS)
From: Peng Fan pinctrl_wdog already marked u-boot,dm-spl, so clean up board code. set_wdog_reset function could be handled by imx_watchdog.c driver. Signed-off-by: Peng Fan --- board/toradex/verdin-imx8mm/spl.c | 11 --- 1 file changed, 11 deletions(-) diff --git

[PATCH 15/17] imx: phycore_imx8mm/p: clean up board watchdog code

2022-05-03 Thread Peng Fan (OSS)
From: Peng Fan pinctrl_wdog already marked u-boot,dm-spl, so clean up board code. set_wdog_reset function could be handled by imx_watchdog.c driver. Signed-off-by: Peng Fan --- board/phytec/phycore_imx8mm/spl.c | 19 --- board/phytec/phycore_imx8mp/spl.c | 19

[PATCH 14/17] imx: imx8mn-kontron-n801x: enable pinctrl_wdog in SPL

2022-05-03 Thread Peng Fan (OSS)
From: Peng Fan Mark pinctrl_wdog as u-boot,dm-spl to clean up board code, set_wdog_reset function could be handled by imx_watchdog.c driver. Signed-off-by: Peng Fan --- arch/arm/dts/imx8mm-kontron-n801x-u-boot.dtsi | 4 board/kontron/sl-mx8mm/spl.c | 18

[PATCH 12/17] imx: imx8mn_var_som: clean up board watchdog code

2022-05-03 Thread Peng Fan (OSS)
From: Peng Fan pinctrl_wdog already marked u-boot,dm-spl, so clean up board code. set_wdog_reset function could be handled by imx_watchdog.c driver. Signed-off-by: Peng Fan --- board/variscite/imx8mn_var_som/spl.c | 11 --- 1 file changed, 11 deletions(-) diff --git

[PATCH 11/17] imx: imx8mn_smm_s2: clean up board watchdog code

2022-05-03 Thread Peng Fan (OSS)
From: Peng Fan pinctrl_wdog already marked u-boot,dm-spl, so clean up board code. set_wdog_reset function could be handled by imx_watchdog.c driver. Signed-off-by: Peng Fan --- board/bsh/imx8mn_smm_s2/spl.c | 11 --- 1 file changed, 11 deletions(-) diff --git

[PATCH 10/17] imx: imx8mn-beacon: enable pinctrl_wdog in SPL

2022-05-03 Thread Peng Fan (OSS)
From: Peng Fan Mark pinctrl_wdog as u-boot,dm-spl to clean up board code, set_wdog_reset function could be handled by imx_watchdog.c driver. Signed-off-by: Peng Fan --- arch/arm/dts/imx8mn-beacon-kit-u-boot.dtsi | 4 board/beacon/imx8mn/spl.c | 10 -- 2 files

[PATCH 08/17] imx: imx8mm-mx8menlo: drop unneeded watchdog settings

2022-05-03 Thread Peng Fan (OSS)
From: Peng Fan pinctrl_wdog as u-boot,dm-spl already marked in imx8mm-verdin-u-boot.dtsi, set_wdog_reset function could be handled by imx_watchdog.c driver. Signed-off-by: Peng Fan --- board/menlo/mx8menlo/mx8menlo.c | 12 1 file changed, 12 deletions(-) diff --git

[PATCH 09/17] imx: imx8mm/n/p-venice: enable pinctrl_wdog in SPL

2022-05-03 Thread Peng Fan (OSS)
From: Peng Fan Mark pinctrl_wdog as u-boot,dm-spl to clean up board code, set_wdog_reset function could be handled by imx_watchdog.c driver. Signed-off-by: Peng Fan --- arch/arm/dts/imx8mm-venice-u-boot.dtsi | 4 arch/arm/dts/imx8mn-venice-u-boot.dtsi | 4

[PATCH 07/17] imx: engicam-imx8mm: drop unused macro

2022-05-03 Thread Peng Fan (OSS)
From: Peng Fan Drop unused WDOG macro Signed-off-by: Peng Fan --- board/engicam/imx8mm/spl.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/board/engicam/imx8mm/spl.c b/board/engicam/imx8mm/spl.c index f75f2dc634c..1846134a492 100644 --- a/board/engicam/imx8mm/spl.c +++

[PATCH 06/17] imx: imx8mm-data-modul-edm-sbc: enable pinctrl_wdog in SPL

2022-05-03 Thread Peng Fan (OSS)
From: Peng Fan Add pinctrl_wdog. Mark pinctrl_wdog as u-boot,dm-spl to clean up board code, set_wdog_reset function could be handled by imx_watchdog.c driver. Signed-off-by: Peng Fan --- .../dts/imx8mm-data-modul-edm-sbc-u-boot.dtsi | 4 arch/arm/dts/imx8mm-data-modul-edm-sbc.dts

[PATCH 05/17] imx: imx8mm-cl-iot-gate: enable pinctrl_wdog in SPL

2022-05-03 Thread Peng Fan (OSS)
From: Peng Fan Mark pinctrl_wdog as u-boot,dm-spl to clean up board code, set_wdog_reset function could be handled by imx_watchdog.c driver. Signed-off-by: Peng Fan --- arch/arm/dts/imx8mm-cl-iot-gate-u-boot.dtsi | 4 board/compulab/imx8mm-cl-iot-gate/spl.c | 19 ---

[PATCH 04/17] imx: imx8mm_beacon: enable pinctrl_wdog in SPL

2022-05-03 Thread Peng Fan (OSS)
From: Peng Fan Mark pinctrl_wdog as u-boot,dm-spl to clean up board code, set_wdog_reset function could be handled by imx_watchdog.c driver. Signed-off-by: Peng Fan --- arch/arm/dts/imx8mm-beacon-kit-u-boot.dtsi | 4 board/beacon/imx8mm/spl.c | 19 --- 2

[PATCH 03/17] imx: imx8mp_evk: enable pinctrl_wdog in SPL

2022-05-03 Thread Peng Fan (OSS)
From: Peng Fan Mark pinctrl_wdog as u-boot,dm-spl to clean up board code, set_wdog_reset function could be handled by imx_watchdog.c driver. Signed-off-by: Peng Fan --- arch/arm/dts/imx8mp-evk-u-boot.dtsi | 4 board/freescale/imx8mp_evk/imx8mp_evk.c | 17 -

[PATCH 01/17] imx: imx8mn_evk: enable pinctrl_wdog in SPL

2022-05-03 Thread Peng Fan (OSS)
From: Peng Fan Mark pinctrl_wdog as u-boot,dm-spl to clean up board code, set_wdog_reset function could be handled by imx_watchdog.c driver. Signed-off-by: Peng Fan --- arch/arm/dts/imx8mn-ddr4-evk-u-boot.dtsi | 4 board/freescale/imx8mn_evk/spl.c | 19 --- 2

[PATCH 02/17] imx: imx8mm_evk: enable pinctrl_wdog in SPL

2022-05-03 Thread Peng Fan (OSS)
From: Peng Fan Mark pinctrl_wdog as u-boot,dm-spl to clean up board code, set_wdog_reset function could be handled by imx_watchdog.c driver. Signed-off-by: Peng Fan --- arch/arm/dts/imx8mm-evk-u-boot.dtsi | 4 board/freescale/imx8mm_evk/spl.c| 19 --- 2 files

[PATCH 00/17] imx: imx8m: clean up wdog code

2022-05-03 Thread Peng Fan (OSS)
From: Peng Fan Enable pinctrl wdog to clean up board level code imx_watchdog.c already has function of set_wdog_reset, so after watchdog driver enabled, no need that. Note: I only have NXP EVK board, so please help test if possible. Based on:

[PATCH 4/4] configs: imx8m: use common imx8m.h for i.MX8MQ

2022-05-03 Thread Peng Fan (OSS)
From: Peng Fan Some SPL definitions could be gerneralized, so use imx8m.h for iMX8MQ. Signed-off-by: Peng Fan --- include/configs/imx8m.h | 10 ++ include/configs/imx8mq_cm.h | 24 +--- include/configs/imx8mq_evk.h | 19

[PATCH 3/4] configs: imx8m: use common imx8m.h for i.MX8MP

2022-05-03 Thread Peng Fan (OSS)
From: Peng Fan Some SPL definitions could be gerneralized, so use imx8m.h for iMX8MP. Signed-off-by: Peng Fan --- include/configs/imx8m.h | 8 include/configs/imx8mp_evk.h | 17 + include/configs/imx8mp_rsb3720.h | 16 +---

[PATCH 2/4] configs: imx8m: use common imx8m.h for i.MX8MN

2022-05-03 Thread Peng Fan (OSS)
From: Peng Fan Some SPL definitions could be gerneralized, so use imx8m.h for iMX8MN. Signed-off-by: Peng Fan --- include/configs/imx8m.h| 10 ++ include/configs/imx8mn_bsh_smm_s2_common.h | 17 + include/configs/imx8mn_evk.h | 20

[PATCH 1/4] configs: imx8m: use common imx8m.h for i.MX8MM

2022-05-03 Thread Peng Fan (OSS)
From: Peng Fan Some SPL definitions could be gerneralized, so use imx8m.h for that. i.MX8MN/Q/P will follow up. Signed-off-by: Peng Fan --- include/configs/imx8m.h | 29 + include/configs/imx8mm-cl-iot-gate.h| 17 ++--

Re: [PATCH 04/12] cmd: tlv_eeprom: convert functions used by command to api functions

2022-05-03 Thread Stefan Roese
Hi Josua, On 03.05.22 09:17, Josua Mayer wrote: Am 03.05.22 um 09:16 schrieb Stefan Roese: On 02.05.22 16:18, Josua Mayer wrote: - prog_eeprom: write_tlvinfo_tlv_eeprom - update_crc: tlvinfo_update_crc - is_valid_tlv: is_valid_tlvinfo_entry - is_checksum_valid: tlvinfo_check_crc So while

[PATCH v3] imx: imx8qm: cgtqmx8: switch to binman

2022-05-03 Thread Oliver Graute
Switch to use binman to pack images Signed-off-by: Oliver Graute Reviewed-by: Fabio Estevam Reviewed-by: Simon Glass --- Changes for v3 -added Reviewed-by -rebased on master arch/arm/dts/imx8qm-cgtqmx8.dts | 1 + arch/arm/mach-imx/imx8/Kconfig | 1 +

Re: [RFC] Data structure for information handoff between firmware boot stages

2022-05-03 Thread Simon Glass
Hi Jose, On Tue, 3 May 2022 at 02:26, Jose Marinho wrote: > > Hi Simon, > > Thank you for reviewing the draft proposal! > > Would you be able to share your review comments on the PDF? > Currently the document is not in a markup form and is yet to be hosted in a > repository. That's the intent

[PATCH] Convert CONFIG_MTD_CONCAT to Kconfig

2022-05-03 Thread Chris Packham
This converts the following to Kconfig: CONFIG_MTD_CONCAT Signed-off-by: Chris Packham --- This touches octeontx_common.h but only to remove a line that is already commented out. Other than that etamin was the only board that had this enabled. configs/etamin_defconfig | 1 +

[PATCH] cmd: mvebu: Hide bubt specific options when bubt is disabled

2022-05-03 Thread Pali Rohár
CONFIG_MVEBU_NAND_BOOT, CONFIG_MVEBU_SPI_BOOT, CONFIG_MVEBU_MMC_BOOT and CONFIG_MVEBU_UBOOT_DFLT_NAME are unused when CONFIG_CMD_MVEBU_BUBT is not enabled. So hide them. Signed-off-by: Pali Rohár --- cmd/mvebu/Kconfig | 4 1 file changed, 4 insertions(+) diff --git a/cmd/mvebu/Kconfig

[PATCH] arm: mvebu: Espressobin: Add NVMe to boot targets

2022-05-03 Thread Pali Rohár
NVMe support is already enabled, so add it into boot targets. Signed-off-by: Pali Rohár --- include/configs/mvebu_armada-37xx.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/configs/mvebu_armada-37xx.h b/include/configs/mvebu_armada-37xx.h index 778f8b828aa8..953dfe812558 100644

[PATCH 1/2] pmic: pca9450: add DM_I2C dependencies in Kconfig

2022-05-03 Thread Rasmus Villemoes
The pca9450 driver uses dm_i2c_{read,write}, which are (unsurprisingly) only available with DM_I2C. Make sure one can't create an unbuildable .config by adding proper dependencies. While here, append "in SPL" to the prompt for the SPL_ variant so it doesn't read the same as the one for the

[PATCH 2/2] pmic: pca9450: drop pointless .data entries

2022-05-03 Thread Rasmus Villemoes
These are the i2c addresses of the chips, but that comes from device tree. Having that information duplicated here just adds confusion. Signed-off-by: Rasmus Villemoes --- drivers/power/pmic/pca9450.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [PATCH v3 08/13] misc: Add support for nvmem cells

2022-05-03 Thread Simon Glass
Hi Sean, On Fri, 29 Apr 2022 at 13:40, Sean Anderson wrote: > > Hi Simon, > > On 4/25/22 11:24 AM, Sean Anderson wrote: > > > > > > On 4/25/22 1:48 AM, Simon Glass wrote: > >> Hi Sean, > >> > >> On Mon, 18 Apr 2022 at 13:37, Sean Anderson wrote: > >>> > >>> This adds support for "nvmem cells"

[PATCH] arm: tegra: Update some DT compatibles

2022-05-03 Thread Peter Robinson
Some of the DT compatibles have changed upstream so add new DT compatibles to ensure things continue to keep working if the device trees are updated. Signed-off-by: Peter Robinson --- drivers/i2c/tegra_i2c.c | 1 + drivers/video/tegra124/dp.c | 1 + 2 files changed, 2 insertions(+) diff

[PATCH 2/2] pci: tegra: Update error prints with new lines

2022-05-03 Thread Peter Robinson
Add new lines to make errorr messages easier to read. Signed-off-by: Peter Robinson --- drivers/pci/pci_tegra.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pci/pci_tegra.c b/drivers/pci/pci_tegra.c index f8d66c0e1c6..bc489d5ec85 100644 ---

[PATCH 1/2] ARM: tegra: XUSB padctl: Add new lines for errors

2022-05-03 Thread Peter Robinson
Add new lines for error messages to make them easier to read. Signed-off-by: Peter Robinson --- arch/arm/mach-tegra/xusb-padctl-common.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/arm/mach-tegra/xusb-padctl-common.c

RE: [RFC] Data structure for information handoff between firmware boot stages

2022-05-03 Thread Jose Marinho
Hi Simon, Thank you for reviewing the draft proposal! Would you be able to share your review comments on the PDF? Currently the document is not in a markup form and is yet to be hosted in a repository. That's the intent for the long term. Cheers, Jose > -Original Message- > From:

Re: [PATCH v1] imx: imx8qm-rom7720: switch to binman

2022-05-03 Thread Oliver Graute
On 20/04/22, Tom Rini wrote: > On Wed, Jan 26, 2022 at 04:52:04PM +0100, Oliver Graute wrote: > > > Switch to use binman to pack images > > > > Signed-off-by: Oliver Graute > > --- > > arch/arm/dts/imx8qm-rom7720-a1.dts| 1 + > > arch/arm/dts/imx8qm-u-boot.dtsi |

[PATCH v2] imx: imx8qm-rom7720: switch to binman

2022-05-03 Thread Oliver Graute
Switch to use binman to pack images Signed-off-by: Oliver Graute --- Changes for v2 - just rebased to master arch/arm/dts/imx8qm-rom7720-a1.dts| 1 + arch/arm/dts/imx8qm-u-boot.dtsi | 133 ++ arch/arm/mach-imx/imx8/Kconfig| 1 +

Re: [RFC] Data structure for information handoff between firmware boot stages

2022-05-03 Thread Simon Glass
Hi Jose, On Thu, 7 Apr 2022 at 13:23, Jose Marinho wrote: > > Hi All, > > The topic of information handoff between TF-A’s BL31 and BL33 (e.g. U-boot > proper, EDK2) was discussed last year in the TF-A and U-boot mailing lists > [1], [2]. > > Examples of information to be handed off between

Re: [PATCH v7 0/7] fpga: zynqmp: Adding support of loading authenticated images

2022-05-03 Thread Michal Simek
On 4/11/22 20:00, Adrian Fiergolski wrote: This patchset introduces support for the authenticated FPGA images on ZynqMP boards, besides that introducing common way to pass the compatible property to any fpga driver. It bases on the initial work by Jorge Ramirez-Ortiz

Re: [PATCH v7 6/7] fpga: zynqmp: support loading authenticated images

2022-05-03 Thread Michal Simek
On 4/11/22 20:00, Adrian Fiergolski wrote: From: Oleksandr Suvorov Add supporting new compatible string "u-boot,zynqmp-fpga-ddrauth" to handle loading authenticated images (DDR). Based on solution by Jorge Ramirez-Ortiz Signed-off-by: Oleksandr Suvorov Co-developed-by: Ricardo Salveti

Re: [PATCH v7 5/7] fpga: xilinx: pass xilinx_desc pointer address into load() ops

2022-05-03 Thread Michal Simek
On 4/11/22 20:00, Adrian Fiergolski wrote: From: Oleksandr Suvorov Pass an address of xilinx_desc pointer in an fpga_desc into a load() callback of struct xilinx_fpga_op. It allows getting parent fpga_desc structure members inside xilinx fpga drivers. Signed-off-by: Oleksandr Suvorov

Re: [PATCH v7 4/7] fpga: xilinx: add missed identifier names

2022-05-03 Thread Michal Simek
On 4/11/22 20:00, Adrian Fiergolski wrote: From: Oleksandr Suvorov Function definition arguments should also have identifier names. Add missed ones to struct xilinx_fpga_op callbacks, unifying code. Signed-off-by: Oleksandr Suvorov missing your sob line here. M --- include/xilinx.h

Re: [PATCH v7 2/7] fpga: add fit_fpga_load function

2022-05-03 Thread Michal Simek
On 4/11/22 20:00, Adrian Fiergolski wrote: From: Oleksandr Suvorov Introduce a function which passes an fpga compatible string from FIT images to FPGA drivers. This lets the different implementations decide how to handle it. Some code of Jorge Ramirez-Ortiz is reused. Signed-off-by:

Re: [PATCH] xilinx: Handle board_get_usable_ram_top(0) properly

2022-05-03 Thread Michal Simek
pá 29. 4. 2022 v 11:52 odesílatel Michal Simek napsal: > > board_get_usable_ram_top() was designed for getting the top most location > for U-Boot allocation that's why function itself supports via total_size > parameter to find out where the right location for U-Boot is. > But function itself is

Re: [PATCH 04/12] cmd: tlv_eeprom: convert functions used by command to api functions

2022-05-03 Thread Josua Mayer
Am 03.05.22 um 09:16 schrieb Stefan Roese: On 02.05.22 16:18, Josua Mayer wrote: - prog_eeprom: write_tlvinfo_tlv_eeprom - update_crc: tlvinfo_update_crc - is_valid_tlv: is_valid_tlvinfo_entry - is_checksum_valid: tlvinfo_check_crc So while creating a new API it makes sense to prepend the

Re: [PATCH] Revert "arm64: xilinx: Set CONFIG_ZYNQMP_FIRMWARE config for mini emmc"

2022-05-03 Thread Michal Simek
st 27. 4. 2022 v 10:30 odesílatel Michal Simek napsal: > > From: T Karthik Reddy > > This reverts commit 122ca834f2f4a9d70abeece3d1ff200a3556ab24. > > Disable CONFIG_ZYNQMP_FIRMWARE config from zynqmp & versal mini emmc > defconfig files, as mini emmc does not use any firmware. > >

Re: [PATCH] mmc: zynq_sdhci: Add weak function prototype

2022-05-03 Thread Michal Simek
st 27. 4. 2022 v 10:27 odesílatel Michal Simek napsal: > > From: T Karthik Reddy > > zynqmp_pm_is_function_supported() which checks feature support on som, > which is implemented in firmware_zynqmp.c driver. As mini configuration > does not use firmware driver, so create a weak function to avoid

Re: [PATCH V2] imx: drop CONFIG_MXC_UART_BASE

2022-05-03 Thread Soeren Moch
On 03.05.22 06:14, Peng Fan (OSS) wrote: From: Peng Fan Since these boards has CONFIG_DM_SERIAL and/or CONFIG_SPL_DM_SERIAL, the legacy macro no need to be defined. Reviewed-by: Heiko Schocher Reviewed-by: Fabio Estevam Signed-off-by: Peng Fan For tbs2910: Acked-by: Soeren Moch

Re: [PATCH 01/12] cmd: tlv_eeprom: remove use of global variable current_dev

2022-05-03 Thread Josua Mayer
Hi Stefan, Thank you for starting to review this patchset! Am 03.05.22 um 09:09 schrieb Stefan Roese: Hi Josua, a few general comments about this series: - A cover letter for this patchset would be very helpful, so that   reviewers have a summary of the changes. I have sent a cover-letter

Re: [PATCH 10/15] imx: kontron-sl-mx8mm: enable DM_SERIAL

2022-05-03 Thread Frieder Schrempf
Am 30.04.22 um 14:43 schrieb Peng Fan (OSS): > From: Peng Fan > > Enable CONFIG_DM_SERIAL. uart and its pinmux was already > marked with u-boot,dm-spl. > Move preloader_console_init after spl_init to make sure driver > model work. > > Signed-off-by: Peng Fan Acked-by: Frieder Schrempf > ---

Re: [PATCH 04/12] cmd: tlv_eeprom: convert functions used by command to api functions

2022-05-03 Thread Stefan Roese
On 02.05.22 16:18, Josua Mayer wrote: - prog_eeprom: write_tlvinfo_tlv_eeprom - update_crc: tlvinfo_update_crc - is_valid_tlv: is_valid_tlvinfo_entry - is_checksum_valid: tlvinfo_check_crc So while creating a new API it makes sense to prepend the function names identical IMHO to not "pollute"

Re: [PATCH 03/12] cmd: tlv_eeprom: do_tlv_eeprom: stop using non-api read_eeprom function

2022-05-03 Thread Stefan Roese
On 02.05.22 16:18, Josua Mayer wrote: IN the scope of do_tlv_eeprom, the error-checking provided by the Nitpicking: "In ..." read_eeprom function is not required. Instead use the API function read_tlv_eeprom. Signed-off-by: Josua Mayer Reviewed-by: Stefan Roese Thanks, Stefan ---

Re: [PATCH 02/12] cmd: tlv_eeprom: remove use of global variable has_been_read

2022-05-03 Thread Stefan Roese
On 02.05.22 16:18, Josua Mayer wrote: has_been_read is only used as an optimization for do_tlv_eeprom. Explicitly use and set inside this function, thus making read_eeprom stateless. Signed-off-by: Josua Mayer --- cmd/tlv_eeprom.c | 25 - 1 file changed, 12

Re: [PATCH 01/12] cmd: tlv_eeprom: remove use of global variable current_dev

2022-05-03 Thread Stefan Roese
Hi Josua, a few general comments about this series: - A cover letter for this patchset would be very helpful, so that reviewers have a summary of the changes. - Please Cc the original author of this code Baruch Siach in the next version as well (if there is next version that is). On

  1   2   >