Re: [PATCH v2] imx8*_venice_defconfig: configure default MMC env device

2022-08-11 Thread Peng Fan
On 8/12/2022 2:53 AM, Tim Harvey wrote: When booting from USB/SDP mmc_get_env_dev() returns CONFIG_SYS_MMC_ENV_DEV as the MMC env device (while booting from MMC will call board_mmc_get_env_dev() to get this). Configure CONFIG_SYS_MMC_ENV_DEV for SDHC3 (devno=2) as all Gateworks Venice boards u

Re: [PATCH] arm: dts: imx8mm-venice-gw7902: add LTE modem gpios

2022-08-11 Thread Peng Fan
On 8/12/2022 3:02 AM, Tim Harvey wrote: Add missing LTE_PWR# and LTE_RST gpio pinmux. Signed-off-by: Tim Harvey If this not diverge from Linux dts, Acked-by: Peng Fan --- arch/arm/dts/imx8mm-venice-gw7902.dts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/dts/imx8mm

Re: [PATCH] board: gateworks: venice: poll I2C lines to wait for GSC firmware

2022-08-11 Thread Peng Fan
On 8/12/2022 2:59 AM, Tim Harvey wrote: In some situations the GSC firmware where the EEPROM containing the model and DRAM configuration may not be ready by the time the SoC is ready to talk to it over I2C. Instead of a hard delay, poll the I2C lines to wait until they are released to avoid t

Re: binman warning/failure when blobs are missing

2022-08-11 Thread Tom Rini
On Thu, Aug 11, 2022 at 06:08:51PM -0600, Simon Glass wrote: > Hi, > > On Thu, 11 Aug 2022 at 11:44, Tom Rini wrote: > > > > On Thu, Aug 11, 2022 at 09:59:05AM -0700, Tim Harvey wrote: > > > On Thu, Aug 11, 2022 at 9:48 AM Tom Rini wrote: > > > > > > > > On Thu, Aug 11, 2022 at 09:27:44AM -0700,

Re: [PATCH 23/23] blk: Rename if_type to uclass_id

2022-08-11 Thread Simon Glass
Hi Takahiro, On Sun, 7 Aug 2022 at 20:00, AKASHI Takahiro wrote: > > On Mon, Aug 08, 2022 at 10:32:16AM +0900, AKASHI Takahiro wrote: > > My comment below is not directly related to the change, but > > Another comment, > OK I did a patch for the first comment, but can I please leave you to addre

Re: [PATCH 03/23] blk: Enable CONFIG_BLK for all media

2022-08-11 Thread Simon Glass
Hi Heinrich, On Mon, 8 Aug 2022 at 02:00, Heinrich Schuchardt wrote: > > On 8/7/22 17:46, Simon Glass wrote: > > Enable this option on all boards which support block devices. Drop the > > related depencies on BLK since these are not needed anymore. > > > > Disable BLOCK_CACHE on M5253DEMO as this

Re: [PATCH 10/23] blk: Rename HAVE_BLOCK_DEVICE

2022-08-11 Thread Simon Glass
Hi Takahiro, On Sun, 7 Aug 2022 at 18:49, AKASHI Takahiro wrote: > > On Sun, Aug 07, 2022 at 09:46:55AM -0600, Simon Glass wrote: > > This option is fact really related to SPL. For U-Boot proper we always use > > driver model for block devices, so CONFIG_BLK is enabled if block devices > > are in

Re: [PATCH 13/23] blk: Hide the BLK and SPL_LEGACY_BLOCK options

2022-08-11 Thread Simon Glass
Hi Heinrich, On Mon, 8 Aug 2022 at 02:09, Heinrich Schuchardt wrote: > > On 8/7/22 17:46, Simon Glass wrote: > > We don't want boards to be able to change these. They can be handled > > as dependencies of options that need them, such as SPL_MMC. There is no > > point in enabling the block interfa

[PATCH v2 01/24] disk: Correct help for TPL_PARTITIONS

2022-08-11 Thread Simon Glass
Fix a few typos in this help text. Fix a typo in SPL_PARTITIONS while we are here. Signed-off-by: Simon Glass --- Changes in v2: - Update commit message - Fix SPL_PARTITIONS too disk/Kconfig | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/disk/Kconfig b/disk/Kconfig

[PATCH v2 04/24] sandbox: Avoid defining HAVE_BLOCK_DEVICE in Konfig

2022-08-11 Thread Simon Glass
This is not needed as it is implied or selected by other options anyway. Signed-off-by: Simon Glass --- (no changes since v1) arch/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/Kconfig b/arch/Kconfig index 6495e780fec..d3c5d86fb5b 100644 --- a/arch/Kconfig +++ b/arch/Kconfig

[PATCH v2 03/24] ata: Fix an instance of SPL_SATA_SUPPORT

2022-08-11 Thread Simon Glass
The _SUPPORT suffix should be dropped. This happened because the rename was applied around the same time as this new option, so did not include renaming the new option. The relevant commits are: f7560376ae sata: Rename SATA_SUPPORT to SATA 73059529b2 ata: ahci-pci: Add new option CONFIG_SPL

[PATCH v2 02/24] blk: Enable CONFIG_BLK for all media

2022-08-11 Thread Simon Glass
Enable this option on all boards which support block devices. Drop the related depencies on BLK since these are not needed anymore. Disable BLOCK_CACHE on M5253DEMO as this causes a build error. Signed-off-by: Simon Glass --- Changes in v2: - Add SATA also arch/arm/Kconfig| 1 - c

[PATCH v2 06/24] blk: Use a function for whether block devices are available

2022-08-11 Thread Simon Glass
At present we use HAVE_BLOCK_DEVICE to indicate when block devices are available. This is a very strange option, since it partially duplicates the BLK option used by driver model. It also covers both U-Boot proper and SPL, even though one might have block devices and another not. As a first step

[PATCH v2 07/24] cmd: Drop use of HAVE_BLOCK_DEVICE

2022-08-11 Thread Simon Glass
This condition is not needed for these commands, since BLK is enabled for all boards which use block devices and commands are not available in SPL, so even if SPL_BLK is not enabled, it doesn't affect commands. Signed-off-by: Simon Glass --- (no changes since v1) cmd/Kconfig | 5 - cmd/Ma

[PATCH v2 05/24] disk: Use Makefile to omit partition drivers

2022-08-11 Thread Simon Glass
At present these files have an #ifdef covering the whole file. Move the condition to the Makefile instead. Add BLK to the condition since future patches will adjust things so that HAVE_BLOCK_DEVICE is only for SPL, but the partition drivers are needed in U-Boot proper too. Signed-off-by: Simon Gl

[PATCH v2 08/24] blk: Drop unnecessary #ifdef in in blk_legacy

2022-08-11 Thread Simon Glass
We can rely on the compiler to eliminate any dead code. Signed-off-by: Simon Glass --- (no changes since v1) drivers/block/blk_legacy.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/block/blk_legacy.c b/drivers/block/blk_legacy.c index df9a3597545..bd8a17df6a9 100644 --- a/drive

[PATCH v2 09/24] blk: Rename HAVE_BLOCK_DEVICE

2022-08-11 Thread Simon Glass
This option is fact really related to SPL. For U-Boot proper we always use driver model for block devices, so CONFIG_BLK is enabled if block devices are in use. It is only for SPL that we have two cases: - SPL_BLK is enabled, in which case we use driver model and blk-uclass.c - SPL_BLK is not ena

[PATCH v2 10/24] blk: Select SPL_LEGACY_BLOCK automatically

2022-08-11 Thread Simon Glass
Selecting this option can be handled in the Kconfig option itself, as it is with BLK. Update this an drop the various 'select' clauses. Signed-off-by: Simon Glass --- (no changes since v1) common/spl/Kconfig | 2 -- drivers/ata/Kconfig| 1 - drivers/block/Kconfig | 11 +++ d

[PATCH v2 13/24] blk: Drop IF_TYPE_DOC

2022-08-11 Thread Simon Glass
This doesn't seem to be used for anything and it isn't clear what it is. It dates from the first U-Boot commit. Drop it. Signed-off-by: Simon Glass --- (no changes since v1) disk/part.c| 9 - drivers/block/blk-uclass.c | 2 -- include/blk.h | 1 - 3 files

[PATCH v2 14/24] ide: Use a flag for an ATAPI device

2022-08-11 Thread Simon Glass
Rather than setting a different interface type, use a flag to indicate that a device is ATAPI. Signed-off-by: Simon Glass --- (no changes since v1) drivers/block/ide.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/block/ide.c b/drivers/block/ide.c index 3270

[PATCH v2 15/24] blk: Drop IF_TYPE_ATAPI

2022-08-11 Thread Simon Glass
This is not really needed since it does the same things as IDE. Drop it. Signed-off-by: Simon Glass --- (no changes since v1) disk/part.c| 5 - drivers/block/blk-uclass.c | 2 -- include/blk.h | 1 - 3 files changed, 8 deletions(-) diff --git a/disk/part.c b/d

[PATCH v2 17/24] blk: Rename var in blk_get_devnum_by_typename()

2022-08-11 Thread Simon Glass
At present we use a variable with the same name as the enum. Change this since we plan to #define the enum to uclass_id. Signed-off-by: Simon Glass --- (no changes since v1) drivers/block/blk-uclass.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/bloc

[PATCH v2 19/24] efi: Correct assumption about if_type

2022-08-11 Thread Simon Glass
efi_set_blk_dev_to_system_partition() assumes that 0 is an invalid if_type. This is true now but is about to be false. Fix this bug to avoid a test failure. Signed-off-by: Simon Glass --- (no changes since v1) lib/efi_loader/efi_var_file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH v2 16/24] blk: Drop IF_TYPE_SD

2022-08-11 Thread Simon Glass
This is not really needed since it does the same things as MMC. Drop it. Signed-off-by: Simon Glass --- (no changes since v1) disk/part.c| 2 -- drivers/block/blk-uclass.c | 2 -- include/blk.h | 1 - 3 files changed, 5 deletions(-) diff --git a/disk/part.c b/disk

[PATCH v2 12/24] blk: Hide the BLK and SPL_LEGACY_BLOCK options

2022-08-11 Thread Simon Glass
We don't want boards to be able to change these. They can be handled as dependencies of options that need them, such as SPL_MMC. There is no point in enabling the block interface without any storage devices to create a block device. Hide both options from the 'menuconfig' display and deny their us

[PATCH v2 18/24] blk: Rewrite if_type to name functions

2022-08-11 Thread Simon Glass
These are currently using a simple array lookup in one direction, and relying on if_type being sequential. With the move to uclass IDs this needs to change. Update the code to prepare for the new way. This patch is intended to introduce no functional change. The returning of "(none)" from blk_get

[PATCH v2 21/24] disk: Handle UCLASS_EFI_MEDIA in dev_print()

2022-08-11 Thread Simon Glass
This is currently missing. Add it. Fix the code style for the function while we are here. Suggested-by: AKASHI Takahiro Signed-off-by: Simon Glass --- Changes in v2: - Add new patch to handle UCLASS_EFI_MEDIA in dev_print() disk/part.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-

[PATCH v2 11/24] blk: Drop unnecessary CONFIG_SPL_LEGACY_BLOCK in defconfigs

2022-08-11 Thread Simon Glass
This is defined automatically when needed, so drop it from the few defconfig files that define it manually. Signed-off-by: Simon Glass --- (no changes since v1) configs/axm_defconfig | 1 - configs/bcm968380gerg_ram_defconfig| 1 - configs/gardena-smart-gat

[PATCH v2 22/24] blk: Drop if_type

2022-08-11 Thread Simon Glass
Use the uclass ID instead. Signed-off-by: Simon Glass --- (no changes since v1) cmd/blk_common.c | 2 +- drivers/block/blk-uclass.c | 34 +++ drivers/block/blk_legacy.c | 20 +-- include/blk.h | 41 ++--

[PATCH v2 24/24] blk: Rename if_type to uclass_id

2022-08-11 Thread Simon Glass
Use the word 'uclass' instead of 'if_type' to complete the conversion. Signed-off-by: Simon Glass --- Changes in v2: - Use conv_uclass_id() instead of the confusing uclass_id_to_uclass_id() board/st/common/stm32mp_dfu.c| 2 +- cmd/blk_common.c | 18 +-- c

[PATCH v2 00/24] blk: Rationalise the block interface

2022-08-11 Thread Simon Glass
The block interface has two separate implementations, one using driver model and one not. The latter is really only needed for SPL, where size constraints allegedly don't allow use of driver model. Of course we still need space for filesystems and other code, so it isn't clear that driver model is

Re: [PATCH 21/23] blk: Switch over to using uclass IDs

2022-08-11 Thread Simon Glass
Hi Takahiro, On Sun, 7 Aug 2022 at 19:05, AKASHI Takahiro wrote: > > My comment below is not directly related to the change, but > > On Sun, Aug 07, 2022 at 09:47:06AM -0600, Simon Glass wrote: > > We currently have an if_type (interface type) and a uclass id. These are > > closely related and we

[PATCH v2 20/24] blk: Switch over to using uclass IDs

2022-08-11 Thread Simon Glass
We currently have an if_type (interface type) and a uclass id. These are closely related and we don't need to have both. Drop the if_type values and use the uclass ones instead. Maintain the existing, subtle, one-way conversion between UCLASS_USB and UCLASS_MASS_STORAGE for now, and add a comment

[PATCH v2 23/24] efi: Drop ifname field from struct efi_disk_obj

2022-08-11 Thread Simon Glass
This is not used, so drop it. Suggested-by: AKASHI Takahiro Signed-off-by: Simon Glass --- Changes in v2: - Add new patch to drop ifname field from struct efi_disk_obj lib/efi_loader/efi_disk.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/efi_loader/efi_disk.c b/lib/efi_loader/efi

Re: [RESEND PATCH] arm: kirkwood: nsa310s: Add Distro boot capability

2022-08-11 Thread Stefan Roese
Hi Tony, On 12.08.22 01:40, Tony Dinh wrote: - Add distro boot to board include file and deconfig file - Miscellaneous changes: - Remove Gerald from maintainer list (email bounced) - Add CONFIG_SUPPORT_PASSING_ATAGS and friends to support legacy kernel method of booting (

Re: [RFC PATCH 1/1] net: xilinx: handle internal PHY/PCS

2022-08-11 Thread Michal Simek
Hi Nikita, On 8/2/22 12:53, Nikita Shubin wrote: From: Nikita Shubin In SGMII/1000BaseX Xilinx AXI Ethernet may also have an Internal PHY (PCS) in addition to external PHY, in that case we should also set at least BMCR_ANENABLE. PCS are not visible until axinet bringup, so init should be done

Re: [BISECTED] BeagleBone Black doesn't boot after a58147c2dbbf

2022-08-11 Thread Matwey V. Kornilov
Can somebody please advise me working CONFIG_DEBUG_UART _* values for the board? I think I need to obtain some output from the board to debug it further. чт, 11 авг. 2022 г. в 09:56, Matwey V. Kornilov : > > чт, 11 авг. 2022 г. в 01:52, Nishanth Menon : > > > > On 11:40-20220807, Matwey V. Kornilo

[RFC PATCH 1/1] spl: introduce SPL_XIP to config

2022-08-11 Thread Nikita Shubin
From: Nikita Shubin U-Boot and SPL don't necessary share the same location, so we might end with XIP SPL and U-Boot in "normal" memory. This adds an option special for SPL to behave it in XIP manner and don't use hart_lottery and available_harts_lock. Signed-off-by: Nikita Shubin --- arch/ris

[RFC PATCH 0/1] spl: introduce SPL_XIP to config

2022-08-11 Thread Nikita Shubin
From: Nikita Shubin U-Boot and SPL don't necessary share the same location, so we might end with XIP SPL and U-Boot in "normal" memory. Actually, it seems that we need only hart_lottery and available_harts_lock to function like a R/W memory. May be we should introduce a new section solely for

Re: [PATCH v3 1/3] Convert CONFIG_SYS_L2_PL310 to Kconfig

2022-08-11 Thread Philip Oberfichtner
Hi, following the whole discussion I figured using 'select SYS_l2_PL310 if !SYS_L2CACHE_OFF' is the preferred solution. Now the thing is, if I'd put this line under the ARCH_XXX Kconfig entries, I would change behavior for many boards. Take, for example, ARCH_MVEBU: grep -lr ARCH_MVEBU configs |

[PATCH 0/3] rockchip: Fix RAM training on RK3399 based platforms (Rock Pi 4)

2022-08-11 Thread Lee Jones
This set fixes several issues found on the Rock Pi 4. For full context, please see this initial bug report: "There appear to be a number of issues with the Rockchip rk3399 DDR RAM initialisation sequence in Mainline. Specifically, I'm seeing

[PATCH 1/3] ram: rk3399: Fix .set_rate_index() error handling

2022-08-11 Thread Lee Jones
Functions pointed to by this op pointer can return non-zero values indicating an error. Ensure any error value is propagated back up the call-chain. Signed-off-by: Lee Jones Tested-by: Xavier Drudis Ferran Reviewed-by: Kever Yang --- drivers/ram/rockchip/sdram_rk3399.c | 4 +++- 1 file change

[PATCH 2/3] ram: rk3399: Fix faulty frequency change reports

2022-08-11 Thread Lee Jones
Frequency changes to 400MHz are presently reported as: lpddr4_set_rate_0: change freq to 4 mhz 0, 1 This is obviously wrong by 6 orders of magnitude. Ensure frequency changes are reported accurately. Signed-off-by: Lee Jones Tested-by: Xavier Drudis Ferran Reviewed-by: Kever Yang -

[PATCH 3/3] ram: rk3399: Conduct memory training at 400MHz

2022-08-11 Thread Lee Jones
Currently the default initialisation frequency is 50MHz. Although this does appear to be suitable for some LPDDR4 RAM chips, training at this low frequency has been seen to cause Column errors, leading to Capacity check errors on others. Here we force RAM initialisation to happen at 400MHz before

[PATCH v2 1/6] sandbox: Add function os_flush()

2022-08-11 Thread Pali Rohár
It flushes stdout. Signed-off-by: Pali Rohár --- arch/sandbox/cpu/os.c | 5 + include/os.h | 8 2 files changed, 13 insertions(+) diff --git a/arch/sandbox/cpu/os.c b/arch/sandbox/cpu/os.c index f937991139c9..01845e388d35 100644 --- a/arch/sandbox/cpu/os.c +++ b/arch/sandb

[PATCH v2 5/6] serial: Call flush() before changing baudrate

2022-08-11 Thread Pali Rohár
Changing baudrate is sensitive operation. To ensure that U-Boot messages printed before changing baudrate are not lost, call new U-Boot console flush() function. Signed-off-by: Pali Rohár --- cmd/load.c | 5 + drivers/serial/serial-uclass.c | 1 + drivers/serial/serial.c

[PATCH v2 0/6] console: Implement flush() function

2022-08-11 Thread Pali Rohár
On certain places it is required to flush output print buffers to ensure that text strings were sent to console or serial devices. For example when printing message that U-Boot is going to boot kernel or when U-Boot is going to change baudrate of terminal device. Some console devices, like UART, h

[PATCH v2 6/6] boot: Call flush() before booting

2022-08-11 Thread Pali Rohár
In lot of cases kernel resets UART HW. To ensure that U-Boot messages printed before booting kernel are not lost, call new U-Boot console flush() function. Signed-off-by: Pali Rohár --- boot/bootm_os.c | 1 + cmd/boot.c | 1 + cmd/elf.c | 2 ++ 3 files changed, 4 insertions(+) diff -

[PATCH v2 4/6] serial: Implement serial_flush() function for console flush() fallback

2022-08-11 Thread Pali Rohár
Like in all other console functions, implement also serial_flush() function as a fallback int console flush() function. Flush support is available only when config option CONSOLE_FLUSH_SUPPORT is enabled. So when it is disabled then provides just empty static inline function serial_flush(). Signe

[PATCH v2 3/6] serial: Implement flush callback

2022-08-11 Thread Pali Rohár
UART drivers have putc/puts functions which just put characters into HW transmit queue and do not wait until all data are transmitted. Implement flush callback via serial driver's pending(false) callback which waits until HW transmit all characters from the queue. Signed-off-by: Pali Rohár ---

[PATCH v2 2/6] console: Implement flush() function

2022-08-11 Thread Pali Rohár
On certain places it is required to flush output print buffers to ensure that text strings were sent to console or serial devices. For example when printing message that U-Boot is going to boot kernel or when U-Boot is going to change baudrate of terminal device. Therefore introduce a new flush()

[PATCH] bootstage: Show func name for bootstage_mark/error

2022-08-11 Thread Michal Simek
bootstage_mark() and bootstate_error() are not recording any name and in report it is showing as id=. That's not useful and it is better to show function name which calls it. That's why use macros with passing __func__ as recorded name for bootstage. Origin report looks like this: ZynqMP> bootstag

Re: [BISECTED] BeagleBone Black doesn't boot after a58147c2dbbf

2022-08-11 Thread Tom Rini
On Thu, Aug 11, 2022 at 10:47:18AM +0300, Matwey V. Kornilov wrote: > Can somebody please advise me working CONFIG_DEBUG_UART _* values for > the board? I think I need to obtain some output from the board to > debug it further. Reading arch/arm/dts/am33xx-l4.dtsi isn't as easy to read as I would

Re: [BISECTED] BeagleBone Black doesn't boot after a58147c2dbbf

2022-08-11 Thread Alex Kiernan
On Thu, Aug 11, 2022 at 1:46 PM Tom Rini wrote: > > On Thu, Aug 11, 2022 at 10:47:18AM +0300, Matwey V. Kornilov wrote: > > > Can somebody please advise me working CONFIG_DEBUG_UART _* values for > > the board? I think I need to obtain some output from the board to > > debug it further. > > Readin

[PATCH 00/11] binman: Enhancements to binman mkimage

2022-08-11 Thread Simon Glass
This includes enhancements to binman's 'mkimage' support so that it can provide control over what is passed using the -n (imagename) argument. It also includes various minor fixes and tweaks. The entry-docs must be regenerated regularly with binman and this is very slow now. A patch is included t

[PATCH 02/11] patman: Put the coverage command-line last

2022-08-11 Thread Simon Glass
Put this at the end so it is easier to copy it from the terminal. Signed-off-by: Simon Glass --- tools/patman/test_util.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/patman/test_util.py b/tools/patman/test_util.py index c27e0b39e5f..7df2aec6705 100644 --- a/tool

[PATCH 01/11] doc: Build documentation in parallel

2022-08-11 Thread Simon Glass
With the addition of the revision stats this now takes over a minute. Use a parallel build to reduce it a bit (24 seconds for me). Signed-off-by: Simon Glass --- doc/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/Makefile b/doc/Makefile index 050d9dd2391..008a516cb64 100644 --

[PATCH 03/11] patman: Don't buffer test output with a single test

2022-08-11 Thread Simon Glass
When a single test is run we don't need to buffer the test output. This has the unfortunate side effect of suppressing test output, in particular the binman output directory normally printed with the -X option. This is a huge problem since it blocks debugging of tests. We don't actually know how m

[PATCH 04/11] binman: Fix up the entry-docs for Entry_pre_load

2022-08-11 Thread Simon Glass
This has got out of sync and needs a line wrap. Fix it. Signed-off-by: Simon Glass --- tools/binman/entries.rst | 3 ++- tools/binman/etype/pre_load.py | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/binman/entries.rst b/tools/binman/entries.rst index ae4305c

[PATCH 05/11] binman: Add a function to check for missing properties

2022-08-11 Thread Simon Glass
Add a new function to Entry to check for missing properties, since this is likely to be come a common requirement. Signed-off-by: Simon Glass --- tools/binman/entry.py | 16 tools/binman/etype/fill.py | 3 +-- tools/binman/ftest.py | 2 +- 3 files changed, 18 insert

[PATCH 06/11] binman: Adjust mkimage etype node reading

2022-08-11 Thread Simon Glass
Since this is implemented as a section, it should really be split into several functions, one to read the node and one to read the entries. Do this so that it matches how Entry_section works. Signed-off-by: Simon Glass --- tools/binman/etype/mkimage.py | 19 +++ 1 file changed,

[PATCH 07/11] binman: Avoid use of expected failure

2022-08-11 Thread Simon Glass
The testReplaceSectionSimple() test is the only one which expects failure. It looks odd in the output and takes time to glance at it to see that all is in fact well. Also it does not check that the right exception is generated. Use the more common (in binman) approach of checking for an exception.

[PATCH 09/11] binman: Allow the image name to be the data file

2022-08-11 Thread Simon Glass
Some image types use the -n parameter to pass in the data file. Add support for this, with a new property. Signed-off-by: Simon Glass --- tools/binman/entries.rst | 15 +++ tools/binman/etype/mkimage.py | 26 -- tools/binman/ftest.py

[PATCH 08/11] binman: Improve mkimage documentation

2022-08-11 Thread Simon Glass
Expand this a little to make things clearer. Also drop the invalid entry arg. Signed-off-by: Simon Glass --- tools/binman/entries.rst | 28 +--- tools/binman/etype/mkimage.py | 28 +--- 2 files changed, 42 insertions(+), 14 deletions(-) diff

[PATCH 11/11] binman: Allow collection to use entries from other sections

2022-08-11 Thread Simon Glass
At present the collections etype only works with entries in the same section. This can be limiting, since in some cases the data may be inside a subsection, e.g. if there are alignment constraints. Add a function to find the entries in an etype and have it search recursively. Make use of this for

[PATCH 10/11] binman: Allow passing entries using -n

2022-08-11 Thread Simon Glass
Also control over what goes in the file passed with -n using a separate imagename subnode. This can include a section or any other entry type. Signed-off-by: Simon Glass --- tools/binman/entries.rst | 18 + tools/binman/etype/mkimage.py | 39

Re: [PATCH 01/11] doc: Build documentation in parallel

2022-08-11 Thread Quentin Schulz
Hi Simon, On 8/11/22 16:04, Simon Glass wrote: With the addition of the revision stats this now takes over a minute. Use a parallel build to reduce it a bit (24 seconds for me). Signed-off-by: Simon Glass --- doc/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/Makefile b/d

[PATCH v2] Restore pcm051_rev3_defconfig config

2022-08-11 Thread Matwey V. Kornilov
pcm051_rev3_defconfig config (Phytec Wega board) has been dropped in 64efd11d ("arm: Remove pcm051 board") due to expired migration deadlines. Here, pcm051_rev3_defconfig support is reintroduced. Signed-off-by: Matwey V. Kornilov --- Changes since v1: - Do not add symbols to whitelist a

Re: [PATCH 3/3] ram: rk3399: Conduct memory training at 400MHz

2022-08-11 Thread Michal Suchánek
On Thu, Aug 11, 2022 at 08:58:48AM +0100, Lee Jones wrote: > Currently the default initialisation frequency is 50MHz. Although > this does appear to be suitable for some LPDDR4 RAM chips, training at > this low frequency has been seen to cause Column errors, leading to > Capacity check errors on o

Re: [RESEND 1/3] ram: rk3399: Fix .set_rate_index() error handling

2022-08-11 Thread Simon Glass
On Thu, 11 Aug 2022 at 05:09, Lee Jones wrote: > > Functions pointed to by this op pointer can return non-zero values > indicating an error. Ensure any error value is propagated back up the > call-chain. > > Signed-off-by: Lee Jones > Tested-by: Xavier Drudis Ferran > Reviewed-by: Kever Yang >

Re: [PATCH v2 1/6] sandbox: Add function os_flush()

2022-08-11 Thread Simon Glass
On Thu, 11 Aug 2022 at 06:39, Pali Rohár wrote: > > It flushes stdout. > > Signed-off-by: Pali Rohár > --- > arch/sandbox/cpu/os.c | 5 + > include/os.h | 8 > 2 files changed, 13 insertions(+) Reviewed-by: Simon Glass

Re: [RESEND 2/3] ram: rk3399: Fix faulty frequency change reports

2022-08-11 Thread Simon Glass
On Thu, 11 Aug 2022 at 05:09, Lee Jones wrote: > > Frequency changes to 400MHz are presently reported as: > > lpddr4_set_rate_0: change freq to 4 mhz 0, 1 > > This is obviously wrong by 6 orders of magnitude. > > Ensure frequency changes are reported accurately. > > Signed-off-by: Lee Jo

Re: [PATCH] bootstage: Show func name for bootstage_mark/error

2022-08-11 Thread Simon Glass
Hi Michal, On Thu, 11 Aug 2022 at 06:46, Michal Simek wrote: > > bootstage_mark() and bootstate_error() are not recording any name and in > report it is showing as id=. That's not useful and it is better to > show function name which calls it. > That's why use macros with passing __func__ as reco

Re: [RESEND 3/3] ram: rk3399: Conduct memory training at 400MHz

2022-08-11 Thread Simon Glass
On Thu, 11 Aug 2022 at 05:09, Lee Jones wrote: > > Currently the default initialisation frequency is 50MHz. Although > this does appear to be suitable for some LPDDR4 RAM chips, training at > this low frequency has been seen to cause Column errors, leading to > Capacity check errors on others. >

Re: [PATCH v2 4/6] serial: Implement serial_flush() function for console flush() fallback

2022-08-11 Thread Simon Glass
Hi Pali, On Thu, 11 Aug 2022 at 06:39, Pali Rohár wrote: > > Like in all other console functions, implement also serial_flush() function > as a fallback int console flush() function. > > Flush support is available only when config option CONSOLE_FLUSH_SUPPORT is > enabled. So when it is disabled

Re: [PATCH v2 3/6] serial: Implement flush callback

2022-08-11 Thread Simon Glass
On Thu, 11 Aug 2022 at 06:39, Pali Rohár wrote: > > UART drivers have putc/puts functions which just put characters into HW > transmit queue and do not wait until all data are transmitted. > > Implement flush callback via serial driver's pending(false) callback which > waits until HW transmit all

Re: [PATCH v2 5/6] serial: Call flush() before changing baudrate

2022-08-11 Thread Simon Glass
On Thu, 11 Aug 2022 at 06:39, Pali Rohár wrote: > > Changing baudrate is sensitive operation. To ensure that U-Boot messages is a sensitive > printed before changing baudrate are not lost, call new U-Boot console > flush() function. > > Signed-off-by: Pali Rohár > --- > cmd/load.c

Re: [PATCH v2 2/6] console: Implement flush() function

2022-08-11 Thread Simon Glass
Hi Pali, On Thu, 11 Aug 2022 at 06:39, Pali Rohár wrote: > > On certain places it is required to flush output print buffers to ensure > that text strings were sent to console or serial devices. For example when > printing message that U-Boot is going to boot kernel or when U-Boot is > going to ch

Re: [PATCH v2 6/6] boot: Call flush() before booting

2022-08-11 Thread Simon Glass
On Thu, 11 Aug 2022 at 06:39, Pali Rohár wrote: > > In lot of cases kernel resets UART HW. To ensure that U-Boot messages In a lot > printed before booting kernel are not lost, call new U-Boot console flush() booting the kernel > function. > > Signed-off-by: Pali Rohár > --- > boot/bootm_os.

Re: u-boot patch "[v2,02/16] arm: qemu: Add an SPL build" issue help

2022-08-11 Thread Simon Glass
Hi ziheng, On Thu, 11 Aug 2022 at 00:26, 曹子恒 wrote: > > Hi, Simon Glass: > we have an issue based on this patch below, can you help us ? > > Patch:https://patchwork.ozlabs.org/project/uboot/patch/20220117150428.1580273-2-...@chromium.org/ > > Our Environment: > Qemu Version:7.0.0

Re: [PATCH v2 2/6] console: Implement flush() function

2022-08-11 Thread Pali Rohár
On Thursday 11 August 2022 08:47:50 Simon Glass wrote: > > diff --git a/include/stdio_dev.h b/include/stdio_dev.h > > index 270fa2729fb2..06278366ae88 100644 > > --- a/include/stdio_dev.h > > +++ b/include/stdio_dev.h > > @@ -37,6 +37,10 @@ struct stdio_dev { > > void (*putc)(struct stdio_d

Re: [PATCH v2 5/6] serial: Call flush() before changing baudrate

2022-08-11 Thread Pali Rohár
On Thursday 11 August 2022 08:47:53 Simon Glass wrote: > On Thu, 11 Aug 2022 at 06:39, Pali Rohár wrote: > > > > Changing baudrate is sensitive operation. To ensure that U-Boot messages > > is a sensitive > > > printed before changing baudrate are not lost, call new U-Boot console > > flush() fu

[PATCH 11/11] binman: Allow collection to use entries from other sections

2022-08-11 Thread Simon Glass
At present the collections etype only works with entries in the same section. This can be limiting, since in some cases the data may be inside a subsection, e.g. if there are alignment constraints. Add a function to find the entries in an etype and have it search recursively. Make use of this for

Re: [PATCH 09/11] binman: Allow the image name to be the data file

2022-08-11 Thread Quentin Schulz
Hi Simon, On 8/11/22 16:04, Simon Glass wrote: Some image types use the -n parameter to pass in the data file. Add support for this, with a new property. Signed-off-by: Simon Glass --- tools/binman/entries.rst | 15 +++ tools/binman/etype/mkimage.py | 26

Re: [PATCH 08/11] binman: Improve mkimage documentation

2022-08-11 Thread Quentin Schulz
Hi Simon, On 8/11/22 16:04, Simon Glass wrote: Expand this a little to make things clearer. Also drop the invalid entry arg. Signed-off-by: Simon Glass --- tools/binman/entries.rst | 28 +--- tools/binman/etype/mkimage.py | 28 +--- 2 f

Re: [PATCH 05/11] binman: Add a function to check for missing properties

2022-08-11 Thread Quentin Schulz
Hi Simon, On 8/11/22 16:04, Simon Glass wrote: Add a new function to Entry to check for missing properties, since this is likely to be come a common requirement. Signed-off-by: Simon Glass --- tools/binman/entry.py | 16 tools/binman/etype/fill.py | 3 +-- tools/bin

Re: [BISECTED] BeagleBone Black doesn't boot after a58147c2dbbf

2022-08-11 Thread Matwey V. Kornilov
чт, 11 авг. 2022 г. в 15:53, Alex Kiernan : > > On Thu, Aug 11, 2022 at 1:46 PM Tom Rini wrote: > > > > On Thu, Aug 11, 2022 at 10:47:18AM +0300, Matwey V. Kornilov wrote: > > > > > Can somebody please advise me working CONFIG_DEBUG_UART _* values for > > > the board? I think I need to obtain some

Re: Please pull u-boot-dm

2022-08-11 Thread Tom Rini
On Wed, Aug 10, 2022 at 09:18:11PM -0600, Simon Glass wrote: > Hi Tom, > > I've dropped the setuptools patch and will look at it later. > > https://source.denx.de/u-boot/custodians/u-boot-dm/-/pipelines/13113 > > > The following changes since commit 3dd4e916324efc825a7ee8e412f5cf1ded839021: >

binman warning/failure when blobs are missing

2022-08-11 Thread Tim Harvey
Greetings, After a couple of hours troubleshooting a bad boot image today I realized the issue was that I had some 0 byte files for the lpddr4 training blobs that are part of the imx8mp binman created image. Digging in I found that if a blob referenced in the binman node is missing a warning will

Re: binman warning/failure when blobs are missing

2022-08-11 Thread Tom Rini
On Thu, Aug 11, 2022 at 09:27:44AM -0700, Tim Harvey wrote: > Greetings, > > After a couple of hours troubleshooting a bad boot image today I > realized the issue was that I had some 0 byte files for the lpddr4 > training blobs that are part of the imx8mp binman created image. > > Digging in I f

Re: [PATCH v2] Restore pcm051_rev3_defconfig config

2022-08-11 Thread Tom Rini
On Thu, Aug 11, 2022 at 05:18:12PM +0300, Matwey V. Kornilov wrote: > pcm051_rev3_defconfig config (Phytec Wega board) has been dropped in > > 64efd11d ("arm: Remove pcm051 board") > > due to expired migration deadlines. Here, pcm051_rev3_defconfig support is > reintroduced. > > Signed-off-

Re: binman warning/failure when blobs are missing

2022-08-11 Thread Tim Harvey
On Thu, Aug 11, 2022 at 9:48 AM Tom Rini wrote: > > On Thu, Aug 11, 2022 at 09:27:44AM -0700, Tim Harvey wrote: > > > Greetings, > > > > After a couple of hours troubleshooting a bad boot image today I > > realized the issue was that I had some 0 byte files for the lpddr4 > > training blobs that a

Re: Submitting patches

2022-08-11 Thread Tom Rini
On Wed, Aug 03, 2022 at 11:04:45AM +0100, Martin Bonner wrote: > I and my colleagues have a number of patches we would like to > contribute back to the community, however for various reasons > (principally operating inside corporate firewalls), it isn't possible > to use `git send-email`, and I ha

Re: binman warning/failure when blobs are missing

2022-08-11 Thread Tom Rini
On Thu, Aug 11, 2022 at 09:59:05AM -0700, Tim Harvey wrote: > On Thu, Aug 11, 2022 at 9:48 AM Tom Rini wrote: > > > > On Thu, Aug 11, 2022 at 09:27:44AM -0700, Tim Harvey wrote: > > > > > Greetings, > > > > > > After a couple of hours troubleshooting a bad boot image today I > > > realized the iss

[PATCH] [RFC] cmd: i2c: fix default address len for DM_I2C

2022-08-11 Thread Tim Harvey
According to the comment block "The default {addr} parameter is one byte (.1) which works well for memories and registers with 8 bits of address space." While this is true for legacy I2C a default length of -1 is being passed for DM_I2C which results in a usage error. Restore the documented behav

[PATCH v2] imx8*_venice_defconfig: configure default MMC env device

2022-08-11 Thread Tim Harvey
When booting from USB/SDP mmc_get_env_dev() returns CONFIG_SYS_MMC_ENV_DEV as the MMC env device (while booting from MMC will call board_mmc_get_env_dev() to get this). Configure CONFIG_SYS_MMC_ENV_DEV for SDHC3 (devno=2) as all Gateworks Venice boards use SDHC3 as eMMC so that persistent env works

[RESEND PATCH] board: gateworks: venice: add fixup for GW73xx-C+

2022-08-11 Thread Tim Harvey
The GW73xx-C revision and onward replaced the 5-port PCIe switch with a 4-port (dropping PCIe to one of the miniPCIe sockets) due to part availability. This moved the PCI bus of the GbE eth1 device. Use a fixup to adjust the dt accordingly so that local-mac-address assigned from dt works on new rev

[PATCH v3] board: gateworks: venice: add GW7903 PMIC

2022-08-11 Thread Tim Harvey
The GW7903 has a BD71847 PMIC on I2C1. Adjust the model compare strings to add it. Signed-off-by: Tim Harvey Reviewed-by: Fabio Estevam Reviewed-by: Jaehoon Chung --- v3: add Jaehoon's Reviewed-By tag v2: fixed typo in commit log and added Fabio's rb tag --- board/gateworks/venice/spl.c | 9 ++

[PATCH] board: gateworks: venice: poll I2C lines to wait for GSC firmware

2022-08-11 Thread Tim Harvey
In some situations the GSC firmware where the EEPROM containing the model and DRAM configuration may not be ready by the time the SoC is ready to talk to it over I2C. Instead of a hard delay, poll the I2C lines to wait until they are released to avoid the I2C drivers 'Arbitation lost' error messag

[PATCH] arm: dts: imx8mm-venice-gw7902: add LTE modem gpios

2022-08-11 Thread Tim Harvey
Add missing LTE_PWR# and LTE_RST gpio pinmux. Signed-off-by: Tim Harvey --- arch/arm/dts/imx8mm-venice-gw7902.dts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/dts/imx8mm-venice-gw7902.dts b/arch/arm/dts/imx8mm-venice-gw7902.dts index 407ab4592b4c..8e8d0d34c237 100644 --- a/ar

  1   2   >