Re: [PATCH 4/5] arm64: dts: qcom: Fix SPMI arbiter regs and reg-names

2023-01-20 Thread Alexey Minnekhanov
On 2023-01-19 11:47, Sumit Garg wrote: On Mon, 16 Jan 2023 at 06:04, Alexey Minnekhanov wrote: Now that reg-names is required, specify them, and use correct addresses for SPMI arbiter regs, taken from Linux dts [1] [2]. [1]

Re: [PATCH 3/5] doc: spmi-msm: Update docs to reflect current state

2023-01-20 Thread Alexey Minnekhanov
On 2023-01-19 11:44, Sumit Garg wrote: On Mon, 16 Jan 2023 at 06:04, Alexey Minnekhanov wrote: Update spmi-msm documentation and example to reflect the current state of the driver. Since our long term goal is to align with Linux DT bindings and use the DTS imported from Linux as is. So we

Re: [PATCH 2/5] spmi: msm: Fix parsing FDT and reading ARB version

2023-01-20 Thread Alexey Minnekhanov
On 2023-01-19 11:36, Sumit Garg wrote: On Mon, 16 Jan 2023 at 06:03, Alexey Minnekhanov wrote: ... - config_addr = dev_read_addr_index(dev, 0); - priv->spmi_core = dev_read_addr_index(dev, 1); - priv->spmi_obs = dev_read_addr_index(dev, 2); + /* DTS bindings: reg-names

Re: [PATCH v2 1/4] gpio: qcom: add direction functions for pwrkey

2023-01-20 Thread Alexey Minnekhanov
Hi! On 2023-01-19 20:18, Dzmitry Sankouski wrote: GPIO button driver requires direction functions to probe button gpio. Those functions are blank, since pwrkey gpio configured earlier not by u-boot. ... +/* + * Power button already configured as input by previous bootloader. + */ +static

[PATCH v2] sunxi: eMMC: support TOC0 on boot partitions

2023-01-20 Thread Andre Przywara
To determine whether we have been booted from an eMMC boot partition, we replay some of the checks that the BROM must have done to successfully load the SPL. This involves a checksum check, which currently relies on the SPL being wrapped in an "eGON" header. If a board has secure boot enabled,

[PATCH] sunxi: dts: arm: update devicetree files

2023-01-20 Thread Andre Przywara
Sync the devicetree files from the Linux kernel repo, v6.2-rc2. This enables some new devices for the F1C100s family, though this is of little relevance to U-Boot itself. The H3 gains the "phys" property for the first USB controller, which prevents an error message when U-Boot's USB stack comes

[PATCH] sunxi: dts: arm64: update devicetree files

2023-01-20 Thread Andre Przywara
Sync the devicetree files from the Linux kernel repo, v6.2-rc2. This enables GPU power management in the kernel for the H6, enables Bluetooth on the Pinebook, and enables USB on the H616 devices (just for newer Linux kernels at the moment, U-Boot support is pending). As before, this omits the

Re: [PATCH 2/2] event: Correct dependencies on the EVENT framework

2023-01-20 Thread Simon Glass
Hi Tom, On Sun, 15 Jan 2023 at 15:04, Tom Rini wrote: > > On Sun, Jan 15, 2023 at 02:52:35PM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Sun, 15 Jan 2023 at 06:45, Tom Rini wrote: > > > > > > On Sat, Jan 14, 2023 at 06:31:05PM -0700, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On

RE: [PATCH v2 1/1] i2c:aspeed:support ast2600 i2c new register mode driver

2023-01-20 Thread Ryan Chen
> -Original Message- > From: Simon Glass > Sent: Saturday, January 21, 2023 5:58 AM > To: Ryan Chen > Cc: Heiko Schocher ; BMC-SW ; > u-boot@lists.denx.de > Subject: Re: [PATCH v2 1/1] i2c:aspeed:support ast2600 i2c new register mode > driver > > Hi Ryan, > > On Thu, 19 Jan 2023 at

Re: Pull request for efi-2023-04-rc1-2

2023-01-20 Thread Tom Rini
On Fri, Jan 20, 2023 at 07:57:18PM +0100, Heinrich Schuchardt wrote: > Dear Tom, > > The following changes since commit 53c47c59e638cc118c272235db516bb541dad0ac: > > Merge tag 'dm-pull-18jan23' of > https://source.denx.de/u-boot/custodians/u-boot-dm (2023-01-19 09:46:57 > -0500) > > are

Re: [PATCH] Revert "config: tools only: add VIDEO to build bmp_logo"

2023-01-20 Thread Tom Rini
On Wed, Jan 18, 2023 at 10:23:21PM -0300, Fabio Estevam wrote: > This reverts commit 1cfba53ca46cade2dbf4e067afc8c19e72909a4b. > > Since commit 1cfba53ca46c ("config: tools only: add VIDEO to build > bmp_logo") the build of tools-only_defconfig fails: > > | /bin/sh: line 1: tools/bmp_logo: No

Re: [PATCH 01/19] global: Remove unused CONFIG defines

2023-01-20 Thread Tom Rini
On Tue, Jan 10, 2023 at 11:19:28AM -0500, Tom Rini wrote: > Remove some CONFIG symbols and related comments, etc, that are unused > within the code itself at this point. > > Signed-off-by: Tom Rini For the series (and v2 of #5), applied to u-boot/master, thanks! -- Tom signature.asc

[PATCH] odroid: add CROS_EC to odroid_defconfig

2023-01-20 Thread Joost van Zwieten
As of commit e44d7e73fe ("dm: core: Switch uclass_*_device_err to use uclass_*_device_check") U-Boot built with `odroid_defconfig` fails to initialize on an Odroid U2: `board_late_init()` (board/samsung/common/board.c) returns with an error due to the absence of the CROS_EC uclass, and the

Re: [RFC PATCH 1/1] efi_loader: get rid of ad-hoc EFI subsystem init

2023-01-20 Thread Simon Glass
Hi Heinrich, On Fri, 20 Jan 2023 at 13:36, Heinrich Schuchardt wrote: > > On 1/20/23 20:19, Simon Glass wrote: > > Hi, > > > > On Fri, 20 Jan 2023 at 06:03, Heinrich Schuchardt > > wrote: > >> > >> Am 20. Januar 2023 13:31:19 MEZ schrieb Ilias Apalodimas > >> : > >>> Up to now the EFI

Re: reset-loop on Odroid U2: cros-ec communications failure

2023-01-20 Thread Simon Glass
Hi Joost, On Fri, 20 Jan 2023 at 15:00, Joost van Zwieten wrote: > > > > On Fri, Jan 13, 2023 at 11:00, Simon Glass wrote: > > Hi Joost, > > > > On Mon, 9 Jan 2023 at 06:31, Joost van Zwieten > > wrote: > >> > >> Dear maintainers, > >> > >> U-Boot on my Odroid U2 fails to initialize as of

Re: [v3 2/2] event: Correct dependencies on the EVENT framework

2023-01-20 Thread Simon Glass
Hi Tom, On Mon, 16 Jan 2023 at 14:04, Tom Rini wrote: > > On Mon, Jan 16, 2023 at 10:01:47PM +0100, Heinrich Schuchardt wrote: > > On 1/16/23 21:46, Tom Rini wrote: > > > The event framework is just that, a framework. Enabling it by itself > > > does nothing, so we shouldn't ask the user about

Re: [PATCH v8 03/10] arm_ffa: introduce Arm FF-A low-level driver

2023-01-20 Thread Simon Glass
Hi Rob, On Thu, 19 Jan 2023 at 11:11, Rob Herring wrote: > > On Thu, Jan 19, 2023 at 10:41 AM Simon Glass wrote: > > > > Hi Abdellatif, > > > > On Thu, 19 Jan 2023 at 09:32, Abdellatif El Khlifi > > wrote: > > > > > > On Wed, Jan 18, 2023 at 08:59:32AM -0500, Tom Rini wrote: > > > > On Wed,

Re: reset-loop on Odroid U2: cros-ec communications failure

2023-01-20 Thread Joost van Zwieten
On Fri, Jan 13, 2023 at 11:00, Simon Glass wrote: Hi Joost, On Mon, 9 Jan 2023 at 06:31, Joost van Zwieten wrote: Dear maintainers, U-Boot on my Odroid U2 fails to initialize as of commit e44d7e73fe0d649693d8d0a110cd7632bc919273 (introduced after v2022.10). I get the following

Re: [PATCH v2 1/1] i2c:aspeed:support ast2600 i2c new register mode driver

2023-01-20 Thread Simon Glass
Hi Ryan, On Thu, 19 Jan 2023 at 20:12, Ryan Chen wrote: > > Hello Simon, > Sorry, do you have time to check v2 patch? I did not see a change log on it, so was not sure anything was needed? Were there changes from the previous version? Regards, Simon

[PATCH] event: Document dynamic event handlers

2023-01-20 Thread Simon Glass
Add mention of this feature in the event documentation. Signed-off-by: Simon Glass --- doc/develop/event.rst | 23 +++ 1 file changed, 23 insertions(+) diff --git a/doc/develop/event.rst b/doc/develop/event.rst index 6951ec97e77..4ff59348371 100644 ---

Re: [PATCH v2 5/6] binman: Add support for prepending loadables with split-elf

2023-01-20 Thread Simon Glass
Hi Jonas, On Fri, 20 Jan 2023 at 13:47, Jonas Karlman wrote: > > Hi Simon, > > On 2023-01-20 20:19, Simon Glass wrote: > > Hi Jonas, > > > > On Fri, 20 Jan 2023 at 01:26, Jonas Karlman wrote: > >> > >> In some cases it is desired for SPL to start TF-A instead of U-Boot > >> proper. Add support

Re: [PATCH v2 5/6] binman: Add support for prepending loadables with split-elf

2023-01-20 Thread Jonas Karlman
Hi Simon, On 2023-01-20 20:19, Simon Glass wrote: > Hi Jonas, > > On Fri, 20 Jan 2023 at 01:26, Jonas Karlman wrote: >> >> In some cases it is desired for SPL to start TF-A instead of U-Boot >> proper. Add support to prepend a list of strings to the loadables list >> generated by the split-elf

Re: [RFC PATCH 1/1] efi_loader: get rid of ad-hoc EFI subsystem init

2023-01-20 Thread Heinrich Schuchardt
On 1/20/23 20:19, Simon Glass wrote: Hi, On Fri, 20 Jan 2023 at 06:03, Heinrich Schuchardt wrote: Am 20. Januar 2023 13:31:19 MEZ schrieb Ilias Apalodimas : Up to now the EFI subsystem was left out of the main U-Boot init process. This has led to various hacks over the years, with the

Re: [PATCH 03/21] tools: binman: add ti-secure entry type

2023-01-20 Thread Simon Glass
Hi Neha, \ On Fri, 20 Jan 2023 at 03:19, Neha Malcom Francis wrote: > > This entry type is used to create a secured binary > for use with K3 High Security (HS) devices. > > This allows us to no longer depend on k3_fit_atf.sh for > A53 SPL and u-boot image generation even for HS devices. > > We

Re: [PATCH 00/21] Migration to using binman to generate bootloader

2023-01-20 Thread Simon Glass
Hi Neha, On Fri, 20 Jan 2023 at 03:19, Neha Malcom Francis wrote: > > This series aims to eliminate the use of additional custom repositories > such as k3-image-gen (K3 Image Generation) repo that was plumbed into > the U-Boot build flow to generate boot images for TI K3 platform devices. > And

Re: [PATCH 01/21] ti: tools: config: Add board config class to generate config binaries

2023-01-20 Thread Simon Glass
Hi Neha, On Fri, 20 Jan 2023 at 03:19, Neha Malcom Francis wrote: > > For validating config files and generating binary config artifacts, here > board specific config class is added. > > Add function cfgBinaryGen() in tibcfg_gen.py. It uses TIBoardConfig > class to load given schema and config

Re: [PATCH 15/21] j721s2: dts: binman: Package tiboot3.bin, tispl.bin and u-boot.img

2023-01-20 Thread Simon Glass
Hi, On Fri, 20 Jan 2023 at 03:19, Neha Malcom Francis wrote: > > Support added for HS and GP boot binaries for J721S2. > > tiboot3.bin, tispl.bin and u-boot.img: For HS devices > tiboot3.bin_unsigned, tispl.bin_unsigned, u-boot.img_unsigned: For GP > devices > > It is to be noted that the

Re: [PATCH 13/21] Makefile: Add DM, SYSFW_PATH, SYSFW_HS_INNER_CERT_PATH to BINMAN_INDIRS

2023-01-20 Thread Simon Glass
Hi Neha, On Fri, 20 Jan 2023 at 03:19, Neha Malcom Francis wrote: > > To remain consistent with the build commands utilised for K3 devices, > we add the paths where component binaries are located to BINMAN_INDIRS. > Adding SYSFW_PATH for system firmware binaries, SYSFW_HS_INNER_CERT_PATH > for

Re: [PATCH v2 5/6] binman: Add support for prepending loadables with split-elf

2023-01-20 Thread Simon Glass
Hi Jonas, On Fri, 20 Jan 2023 at 01:26, Jonas Karlman wrote: > > In some cases it is desired for SPL to start TF-A instead of U-Boot > proper. Add support to prepend a list of strings to the loadables list > generated by the split-elf generator. > > Signed-off-by: Jonas Karlman > --- > v2: > -

Re: [PATCH v2 1/6] binman: Add support for align argument to mkimage tool

2023-01-20 Thread Simon Glass
On Fri, 20 Jan 2023 at 01:26, Jonas Karlman wrote: > > Add support to indicate what alignment to use for the FIT and its > external data. Pass the alignment to mkimage via the -B flag. > > Signed-off-by: Jonas Karlman > --- > v2: > - Add test > - Update entries.rst > >

Re: [PATCH v2 3/6] binman: Add special subnodes to the nodes generated by split-elf

2023-01-20 Thread Simon Glass
On Fri, 20 Jan 2023 at 01:26, Jonas Karlman wrote: > > Special nodes, hash and signature, is not being added to the nodes > generated for each segment in split-elf operation. > > Copy the subnode logic used in _gen_fdt_nodes to _gen_split_elf to > ensure special nodes are added to the generated

Re: [RFC PATCH 1/1] efi_loader: get rid of ad-hoc EFI subsystem init

2023-01-20 Thread Simon Glass
Hi, On Fri, 20 Jan 2023 at 06:03, Heinrich Schuchardt wrote: > > Am 20. Januar 2023 13:31:19 MEZ schrieb Ilias Apalodimas > : > >Up to now the EFI subsystem was left out of the main U-Boot init > >process. This has led to various hacks over the years, with the most > >notable one being

Pull request for efi-2023-04-rc1-2

2023-01-20 Thread Heinrich Schuchardt
Dear Tom, The following changes since commit 53c47c59e638cc118c272235db516bb541dad0ac: Merge tag 'dm-pull-18jan23' of https://source.denx.de/u-boot/custodians/u-boot-dm (2023-01-19 09:46:57 -0500) are available in the Git repository at:

Re: [PATCH v2] usb: gadget: ether: split start/stop from init/halt

2023-01-20 Thread Marek Vasut
On 1/20/23 18:15, Niel Fourie wrote: [...] Same question as in V1 below. +static int _usb_eth_start(struct ether_priv *priv) +{ + unsigned long timeout = USB_CONNECT_TIMEOUT; + struct eth_dev *dev = >ethdev; + unsigned long ts; + if (!dev->gadget) + return

Re: [PATCH] usb: gadget: ether: split start/stop from init/halt

2023-01-20 Thread Marek Vasut
On 1/20/23 18:26, Niel Fourie wrote: Hi Marek Hi, On 18/12/2022 02:51, Marek Vasut wrote: On 12/16/22 17:35, lu...@denx.de wrote: Hi Marek, Hi, [...] Should "[PATCH v2] net: eth-uclass: revalidate priv after stop() in eth_halt()" be dropped ? It seems this patch fully replaces it.

Re: Pull request for tpm-20012023

2023-01-20 Thread Tom Rini
On Fri, Jan 20, 2023 at 11:18:59AM +0200, Ilias Apalodimas wrote: > Hi Tom, > > The following changes since commit 53c47c59e638cc118c272235db516bb541dad0ac: > > Merge tag 'dm-pull-18jan23' of > https://source.denx.de/u-boot/custodians/u-boot-dm (2023-01-19 09:46:57 -0500) > > are available

Re: [PATCH] usb: gadget: ether: split start/stop from init/halt

2023-01-20 Thread Niel Fourie
Hi Marek On 18/12/2022 02:51, Marek Vasut wrote: On 12/16/22 17:35, lu...@denx.de wrote: Hi Marek, Hi, [...] Should "[PATCH v2] net: eth-uclass: revalidate priv after stop() in eth_halt()" be dropped ? It seems this patch fully replaces it. That old patch only exists for in case there

[PATCH v2] usb: gadget: ether: split start/stop from init/halt

2023-01-20 Thread Niel Fourie
Split out _usb_eth_start() from _usb_eth_init() and usb_eth_stop() from _usb_eth_halt(). Now _usb_eth_init() only initialises and registers the gadget device, which _usb_eth_halt() reverses, and together are used for probing and removing the device. The _usb_eth_start() and _usb_eth_stop()

Re: [BUG] Re: [PATCHv2 03/17] Convert CONFIG_SYS_NS16550_MEM32 et al to Kconfig

2023-01-20 Thread Tom Rini
On Fri, Jan 20, 2023 at 04:32:00PM +, Andre Przywara wrote: > On Fri, 20 Jan 2023 16:24:36 + > Andre Przywara wrote: > > > On Fri, 20 Jan 2023 17:09:01 +0100 > > Heinrich Schuchardt wrote: > > > > Hi Heinrich, > > > > > On 12/4/22 15:39, Tom Rini wrote: > > > > This converts the

Re: [BUG] Re: [PATCHv2 03/17] Convert CONFIG_SYS_NS16550_MEM32 et al to Kconfig

2023-01-20 Thread Andre Przywara
On Fri, 20 Jan 2023 16:24:36 + Andre Przywara wrote: > On Fri, 20 Jan 2023 17:09:01 +0100 > Heinrich Schuchardt wrote: > > Hi Heinrich, > > > On 12/4/22 15:39, Tom Rini wrote: > > > This converts the following to Kconfig: > > > CONFIG_SPL_NS16550_MIN_FUNCTIONS > > >

Re: [BUG] Re: [PATCHv2 03/17] Convert CONFIG_SYS_NS16550_MEM32 et al to Kconfig

2023-01-20 Thread Andre Przywara
On Fri, 20 Jan 2023 17:09:01 +0100 Heinrich Schuchardt wrote: Hi Heinrich, > On 12/4/22 15:39, Tom Rini wrote: > > This converts the following to Kconfig: > > CONFIG_SPL_NS16550_MIN_FUNCTIONS > > CONFIG_SYS_NS16550_MEM32 > > CONFIG_SYS_NS16550_PORT_MAPPED > >

[BUG] Re: [PATCHv2 03/17] Convert CONFIG_SYS_NS16550_MEM32 et al to Kconfig

2023-01-20 Thread Heinrich Schuchardt
On 12/4/22 15:39, Tom Rini wrote: This converts the following to Kconfig: CONFIG_SPL_NS16550_MIN_FUNCTIONS CONFIG_SYS_NS16550_MEM32 CONFIG_SYS_NS16550_PORT_MAPPED CONFIG_SYS_NS16550_REG_SIZE CONFIG_SYS_NS16550_SERIAL To do this we also introduce CONFIG_SPL_SYS_NS16550_SERIAL

Re: [PATCH 0/5] dm: Move to new driver model schema for device tree tags

2023-01-20 Thread Simon Glass
Hi Marek, On Thu, 19 Jan 2023 at 17:12, Tom Rini wrote: > > On Fri, Jan 20, 2023 at 01:07:50AM +0100, Marek Vasut wrote: > > On 1/20/23 00:26, Simon Glass wrote: > > > Now that a new schema has been accepted upstream, press it into service in > > > U-Boot. > > > > git grep in latest linux-next

Re: [PATCH] Revert "config: tools only: add VIDEO to build bmp_logo"

2023-01-20 Thread Tom Rini
On Fri, Jan 20, 2023 at 08:30:27AM +, Peter Robinson wrote: > On Thu, Jan 19, 2023 at 2:02 PM Tom Rini wrote: > > > > On Thu, Jan 19, 2023 at 11:52:11AM +, Peter Robinson wrote: > > > On Thu, Jan 19, 2023 at 11:33 AM Fabio Estevam wrote: > > > > > > > > On Thu, Jan 19, 2023 at 8:18 AM

Re: [PATCH 0/2] mach-meson: port GXL & AXG dwc2_otg usage to CONFIG_DM_USB_GADGET=y

2023-01-20 Thread Neil Armstrong
Hi, On Tue, 17 Jan 2023 10:11:45 +0100, Neil Armstrong wrote: > This is the port of Mattijs work at [1] for G12A over GXL & AXG. > > It uses the same design and should work as-is, it still needs to be > be extensively tested over the main GXL & AXG boards. > > [1] >

Re: [PATCH 13/14] i2c: Add support for Qualcomm I2C driver

2023-01-20 Thread Stephan Gerhold
On Fri, Jan 20, 2023 at 05:55:35PM +0530, Sumit Garg wrote: > On Fri, 20 Jan 2023 at 14:16, Heiko Schocher wrote: > > On 20.01.23 08:17, Sumit Garg wrote: > > > Add support for Qualcomm I2C QUP driver which is inspired from > > > corresponding driver in Linux: drivers/i2c/busses/i2c-qup.c. > > >

Re: [RFC PATCH 1/1] efi_loader: get rid of ad-hoc EFI subsystem init

2023-01-20 Thread Heinrich Schuchardt
Am 20. Januar 2023 13:31:19 MEZ schrieb Ilias Apalodimas : >Up to now the EFI subsystem was left out of the main U-Boot init >process. This has led to various hacks over the years, with the most >notable one being sprinkling around the efi init call to various places >such as U-Boot commands,

Re: [RFC PATCH 1/1] efi_loader: get rid of ad-hoc EFI subsystem init

2023-01-20 Thread Ilias Apalodimas
Just a small correction on the commit log On Fri, 20 Jan 2023 at 14:31, Ilias Apalodimas wrote: > > Up to now the EFI subsystem was left out of the main U-Boot init > process. This has led to various hacks over the years, with the most > notable one being sprinkling around the efi init call to

[RFC PATCH 1/1] efi_loader: get rid of ad-hoc EFI subsystem init

2023-01-20 Thread Ilias Apalodimas
Up to now the EFI subsystem was left out of the main U-Boot init process. This has led to various hacks over the years, with the most notable one being sprinkling around the efi init call to various places such as U-Boot commands, the early boot code etc. Since EFI has it's own Kconfig option

Re: [PATCH 13/14] i2c: Add support for Qualcomm I2C driver

2023-01-20 Thread Sumit Garg
Hi Heiko, Thanks for your review. On Fri, 20 Jan 2023 at 14:16, Heiko Schocher wrote: > > Helo Sumit Garg, > > On 20.01.23 08:17, Sumit Garg wrote: > > Add support for Qualcomm I2C QUP driver which is inspired from > > corresponding driver in Linux: drivers/i2c/busses/i2c-qup.c. > > > >

[PATCH 05/21] j721e: schema: yaml: Add general schema and J721E board config files

2023-01-20 Thread Neha Malcom Francis
Schema file in YAML must be provided in board/ti/common for validating input config files and packaging system firmware. The schema includes entries for rm-cfg, board-cfg, pm-cfg and sec-cfg. Board config file must be provided in board/ti/ in YAML. These can then be consumed for generation of

Re: [PATCH v2 2/2] mtd: spi-nor-core: Make CFRx reg fields generic

2023-01-20 Thread Tudor Ambarus
On 1/20/23 03:28, tkuw584...@gmail.com wrote: From: Takahiro Kuwano Cypress defines two flavors of configuration registers, volatile and non volatile, and both use the same bit fields. Rename the bitfields in the configuration registers so that they can be used for both flavors.

Re: [PATCH v2 1/2] mtd: spi-nor-core: Consider reserved bits in CFR5 register

2023-01-20 Thread Tudor Ambarus
On 1/20/23 03:28, tkuw584...@gmail.com wrote: From: Takahiro Kuwano CFR5[6] is reserved bit and must be always 1. Set it to comply with flash requirements. While fixing SPINOR_REG_CYPRESS_CFR5V_OCT_DTR_EN definition, stop using magic numbers and describe the missing bit fields in CFR5

Re: [PATCH 5/5] gpio/rockchip: rk_gpio support v2 gpio controller

2023-01-20 Thread Chris Morgan
On Thu, Jan 05, 2023 at 07:01:40PM +0100, Quentin Schulz wrote: > Hi Chris, > > Cc'ing the new mail address of Heiko so he receives this mail :) > > On 1/5/23 16:34, Chris Morgan wrote: > > From: Chris Morgan > > > > Add support for the newer GPIO controller used by the rk356x series, > > as

[PATCH] efi_loader: fix CapsuleMax variable reporting

2023-01-20 Thread Ilias Apalodimas
Currently the code that adds the CapsuleMax variable is under a Kconfig named 'EFI_HAVE_CAPSULE_UPDATE. Git history only shows a single occurrence of that. The IS_ENABLED should be checking for EFI_HAVE_CAPSULE_SUPPORT Reported-by: Heinrich Schuchardt Signed-off-by: Ilias Apalodimas ---

Re: [PATCH v8 03/10] arm_ffa: introduce Arm FF-A low-level driver

2023-01-20 Thread Sudeep Holla
On Thu, Jan 19, 2023 at 10:22:07AM -0700, Simon Glass wrote: > Hi Sudeep, > > On Thu, 19 Jan 2023 at 10:09, Sudeep Holla wrote: > > > > On Thu, Jan 19, 2023 at 11:57:44AM -0500, Tom Rini wrote: > > > > > > But it's also true that at run-time, within U-Boot, we can modify the > > > device tree we

Re: [PATCH v8 03/10] arm_ffa: introduce Arm FF-A low-level driver

2023-01-20 Thread Sudeep Holla
Hi Simon, On Thu, Jan 19, 2023 at 11:04:16AM -0700, Simon Glass wrote: [...] > > Well we already have the code, right...? > Correct, that what we would like to see. > The entire device tree is optional. We could just use platform data or > even C function calls to set up devices. We could call

Re: [PATCH v8 03/10] arm_ffa: introduce Arm FF-A low-level driver

2023-01-20 Thread Sudeep Holla
On Thu, Jan 19, 2023 at 12:11:34PM -0600, Rob Herring wrote: > On Thu, Jan 19, 2023 at 10:41 AM Simon Glass wrote: > > > > Can you add a DT node for the 'FF-A SW interfaces' and attach some > > sort of top-level driver to that? Perhaps simple-bus, or your own > > thing? You don't need to add

[PATCH 19/21] am62a: dts: binman: Package tiboot3.bin, tispl.bin, u-boot.img

2023-01-20 Thread Neha Malcom Francis
Support added for HS and GP boot binaries for AM62ax. tiboot3.bin, tispl.bin and u-boot.img: For HS devices tiboot3.bin_unsigned, tispl.bin_unsigned and u-boot.img_unsigned: For GP devices It is to be noted that the bootflow followed by AM62ax requires: tiboot3.bin: * R5 SPL *

[PATCH 20/21] k3: tools: config.mk: Update makefile and remove scripts

2023-01-20 Thread Neha Malcom Francis
Since binman is used to package bootloader images for all K3 devices, we do not have to rely on the earlier methods to package them. config.mk has been edited to only have binman required make commands. Scripts that were used to generate x509 certificate for tiboot3.bin and generate tispl.bin

[PATCH 14/21] j721s2: yaml: Add board config for J721S2

2023-01-20 Thread Neha Malcom Francis
Added YAML config for J721S2 Signed-off-by: Neha Malcom Francis --- board/ti/j721s2/config.yaml | 3303 +++ 1 file changed, 3303 insertions(+) create mode 100644 board/ti/j721s2/config.yaml diff --git a/board/ti/j721s2/config.yaml b/board/ti/j721s2/config.yaml

[PATCH 16/21] am62: yaml: Add board config for AM62

2023-01-20 Thread Neha Malcom Francis
Added YAML config for AM62 Signed-off-by: Neha Malcom Francis --- board/ti/am62x/config.yaml | 1490 board/ti/am65x/config.yaml | 144 ++-- 2 files changed, 1562 insertions(+), 72 deletions(-) create mode 100644 board/ti/am62x/config.yaml diff --git

[PATCH 17/21] am625: dts: binman: Package tiboot3.bin, tispl.bin and u-boot.img

2023-01-20 Thread Neha Malcom Francis
Support added for HS and GP boot binaries for AM62 tiboot3.bin, tispl.bin and u-boot.img: For HS devices tiboot3.bin_unsigned, tispl.bin_unsigned, u-boot.img_unsigned: For GP devices It is to be noted that the bootflow followed by AM62 requires: tiboot3.bin: * R5 SPL * R5 SPL

[PATCH 21/21] doc: board: ti: Update documentation for binman flow

2023-01-20 Thread Neha Malcom Francis
Earlier documentation specified builds for generating bootloader images using an external TI repository k3-image-gen and shell scripts within U-Boot. Modify this to using the binman flow so that user understands how to build the final boot images. Signed-off-by: Neha Malcom Francis ---

[PATCH 18/21] am62a: yaml: Add board config for AM62ax

2023-01-20 Thread Neha Malcom Francis
Added YAML config for AM62ax Signed-off-by: Neha Malcom Francis --- board/ti/am62ax/config.yaml | 1553 +++ 1 file changed, 1553 insertions(+) create mode 100644 board/ti/am62ax/config.yaml diff --git a/board/ti/am62ax/config.yaml b/board/ti/am62ax/config.yaml

[PATCH 15/21] j721s2: dts: binman: Package tiboot3.bin, tispl.bin and u-boot.img

2023-01-20 Thread Neha Malcom Francis
Support added for HS and GP boot binaries for J721S2. tiboot3.bin, tispl.bin and u-boot.img: For HS devices tiboot3.bin_unsigned, tispl.bin_unsigned, u-boot.img_unsigned: For GP devices It is to be noted that the bootflow followed by J721S2 requires: tiboot3.bin: * R5 SPL * R5

[PATCH 13/21] Makefile: Add DM, SYSFW_PATH, SYSFW_HS_INNER_CERT_PATH to BINMAN_INDIRS

2023-01-20 Thread Neha Malcom Francis
To remain consistent with the build commands utilised for K3 devices, we add the paths where component binaries are located to BINMAN_INDIRS. Adding SYSFW_PATH for system firmware binaries, SYSFW_HS_INNER_CERT_PATH for HS device certificate and DM for Device Manager firmware. This way, the

[PATCH 11/21] config: am64x: Add board config for AM64x

2023-01-20 Thread Neha Malcom Francis
Added YAML config for AM64xx Signed-off-by: Neha Malcom Francis --- board/ti/am64x/config.yaml | 1805 1 file changed, 1805 insertions(+) create mode 100644 board/ti/am64x/config.yaml diff --git a/board/ti/am64x/config.yaml b/board/ti/am64x/config.yaml new

[PATCH 09/21] am65x: yaml: Add AM65x board config files

2023-01-20 Thread Neha Malcom Francis
Added YAML config for AM65x Signed-off-by: Neha Malcom Francis --- board/ti/am65x/config.yaml | 2469 1 file changed, 2469 insertions(+) create mode 100644 board/ti/am65x/config.yaml diff --git a/board/ti/am65x/config.yaml b/board/ti/am65x/config.yaml new

[PATCH 12/21] am64x: dts: binman: Package tiboot3.bin, tispl.bin u-boot.img

2023-01-20 Thread Neha Malcom Francis
Support added for HS and GP boot binaries for AM64x. tiboot3.bin, tispl.bin and u-boot.img: For HS devices tiboot3.bin_unsigned, tispl.bin_unsigned, u-boot.img_unsigned: For GP devices Note that the bootflow followed by AM64x requires: tiboot3.bin: * R5 SPL * R5 SPL dtbs

[PATCH 10/21] am65: dts: binman: Package tiboot3.bin, sysfw.itb, tispl.bin, u-boot.img

2023-01-20 Thread Neha Malcom Francis
Support added for HS and GP boot binaries for AM65x. tiboot3.bin, sysfw.itb, tispl.bin and u-boot.img: For HS devices tiboot3.bin_unsigned, sysfw.itb, tispl.bin_unsigned, u-boot.img_unsigned: For GP devices Note that the bootflow followed by AM65x requires: tiboot3.bin: * R5 SPL

[PATCH 07/21] j7200: yaml: Add J7200 board config files

2023-01-20 Thread Neha Malcom Francis
Added YAML config for J7200 Signed-off-by: Neha Malcom Francis --- arch/arm/mach-k3/config.mk |5 + board/ti/j721e/config_j7200.yaml | 2467 ++ 2 files changed, 2472 insertions(+) create mode 100644 board/ti/j721e/config_j7200.yaml diff --git

[PATCH 08/21] j7200: dts: binman: Package tiboot3.bin, tispl.bin, u-boot.img

2023-01-20 Thread Neha Malcom Francis
Support added for HS and GP boot binaries for J7200. tiboot3.bin, tispl.bin and u-boot.img: For HS devices tiboot3.bin_unsigned, tispl.bin_unsigned and u-boot.img_unsigned: For GP devices It is to be noted that the bootflow followed by J7200 requires: tiboot3.bin: * R5 SPL * R5

[PATCH 06/21] j721e: dts: binman: Package tiboot3.bin, sysfw.itb, tispl.bin, u-boot.img

2023-01-20 Thread Neha Malcom Francis
By providing entries in the binman node of the device tree, binman will be able to find and package board config artifacts generated by TIBoardConfig with sysfw.bin and generate the final image sysfw.itb. It will also pick out the R5 SPL and sign it with the help of TI signing entry and generate

[PATCH 04/21] ti: sysfw: tiboot3: Add support for packaging sysfw.itb and tiboot3.bin

2023-01-20 Thread Neha Malcom Francis
Board config binary artifacts must be populated in the R5 output directory to be used by binman to package sysfw.itb and tiboot3.bin. For devices that follow combined flow, these board configuration binaries must again be packaged into a combined board configuration blobs to be used by binman to

[PATCH 03/21] tools: binman: add ti-secure entry type

2023-01-20 Thread Neha Malcom Francis
This entry type is used to create a secured binary for use with K3 High Security (HS) devices. This allows us to no longer depend on k3_fit_atf.sh for A53 SPL and u-boot image generation even for HS devices. We still depend on the availability of an external tool provided by the

[PATCH 02/21] tools: sysfw: Add script for generating configuration blobs

2023-01-20 Thread Neha Malcom Francis
Certain devices in the K3 architecture such as AM64x require board configuration binaries packed along with their descriptions into a sysfw_data binary. The final binary is required to be packed into the final system firmware images. Signed-off-by: Neha Malcom Francis ---

[PATCH 01/21] ti: tools: config: Add board config class to generate config binaries

2023-01-20 Thread Neha Malcom Francis
For validating config files and generating binary config artifacts, here board specific config class is added. Add function cfgBinaryGen() in tibcfg_gen.py. It uses TIBoardConfig class to load given schema and config files in YAML, validate them and generate binaries. Signed-off-by: Tarun Sahu

[PATCH 00/21] Migration to using binman to generate bootloader

2023-01-20 Thread Neha Malcom Francis
This series aims to eliminate the use of additional custom repositories such as k3-image-gen (K3 Image Generation) repo that was plumbed into the U-Boot build flow to generate boot images for TI K3 platform devices. And instead, we move towards using binman that aligns better with the community

Re: [PATCH v8 03/10] arm_ffa: introduce Arm FF-A low-level driver

2023-01-20 Thread Abdellatif El Khlifi
On Thu, Jan 19, 2023 at 04:56:09PM +, Sudeep Holla wrote: > Hi Simon, > > (sorry we just crossed the emails) > > On Thu, Jan 19, 2023 at 09:41:12AM -0700, Simon Glass wrote: > > > > Can you add a DT node for the 'FF-A SW interfaces' and attach some > > sort of top-level driver to that?

Pull request for tpm-20012023

2023-01-20 Thread Ilias Apalodimas
Hi Tom, The following changes since commit 53c47c59e638cc118c272235db516bb541dad0ac: Merge tag 'dm-pull-18jan23' of https://source.denx.de/u-boot/custodians/u-boot-dm (2023-01-19 09:46:57 -0500) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-tpm/

Re: [PATCH 13/14] i2c: Add support for Qualcomm I2C driver

2023-01-20 Thread Heiko Schocher
Helo Sumit Garg, On 20.01.23 08:17, Sumit Garg wrote: > Add support for Qualcomm I2C QUP driver which is inspired from > corresponding driver in Linux: drivers/i2c/busses/i2c-qup.c. > > Currently this driver only support FIFO polling mode which is sufficient > to support devices like eeprom, rtc

[PATCH v4 4/4] eficonfig: increase the number of menu entries

2023-01-20 Thread Masahisa Kojima
Current eficonfig has the maximum number of menu entries and it is 99. If there are more EFI load options and files in the system, eficonfig can not handle it. This commit increases this maximum number of menu entries to INT_MAX. Signed-off-by: Masahisa Kojima --- Newly created in v4

[PATCH v4 3/4] eficonfig: add vertical scroll support

2023-01-20 Thread Masahisa Kojima
The current eficonfig menu does not support vertical scroll, so it can not display the menu entries greater than the console row size. This commit add the vertial scroll support. The console size is retrieved by SIMPLE_TEXT_OUTPUT_PROTOCOL.QueryMode() service, then calculates the row size for

[PATCH v4 2/4] eficonfig: refactor change boot order implementation

2023-01-20 Thread Masahisa Kojima
This commit removes the change boot order specific menu implementation. The change boot order implementation calls eficonfig_process_common() same as other menus. The change boot order menu requires own item_data_print and item_choice implementation, but display_statusline function can be a same

[PATCH v4 1/4] eficonfig: refactor eficonfig_process_common function

2023-01-20 Thread Masahisa Kojima
Current change boot order implementation does not call eficonfig_process_common() and call own menu functions for display_statusline, item_data_print and item_choice. Change boot order functionality should call eficonfig_process_common() to improve maintenanceability. This commit is a preparation

[PATCH v4 0/4] eficonfig: add vertical scroll support and refactoring

2023-01-20 Thread Masahisa Kojima
This series aims to add the vertical scroll for the eficonfig menu. Before adding scroll support, this series does the refactoring of change boot order implementation since it has own menu handling and it should be removed to improve maintainability. The eficonfig menu handles file selection for

Re: [PATCH] Revert "config: tools only: add VIDEO to build bmp_logo"

2023-01-20 Thread Peter Robinson
On Thu, Jan 19, 2023 at 2:02 PM Tom Rini wrote: > > On Thu, Jan 19, 2023 at 11:52:11AM +, Peter Robinson wrote: > > On Thu, Jan 19, 2023 at 11:33 AM Fabio Estevam wrote: > > > > > > On Thu, Jan 19, 2023 at 8:18 AM Peter Robinson > > > wrote: > > > > > > > Did you read the original thread?

[PATCH v2 6/6] rockchip: Use atf as firmware and move u-boot to loadables in FIT

2023-01-20 Thread Jonas Karlman
The FIT generated after the switch to using binman is using different values for firmware and loadables properties compared to the old script. With the old script: firmware = "atf-1"; loadables = "u-boot", "atf-2", ...; After switch to binman: firmware = "u-boot"; loadables = "atf-1",

[PATCH v2 5/6] binman: Add support for prepending loadables with split-elf

2023-01-20 Thread Jonas Karlman
In some cases it is desired for SPL to start TF-A instead of U-Boot proper. Add support to prepend a list of strings to the loadables list generated by the split-elf generator. Signed-off-by: Jonas Karlman --- v2: - New patch tools/binman/entries.rst| 5 +-

[PATCH v2 4/6] rockchip: Add sha256 hash to FIT images

2023-01-20 Thread Jonas Karlman
Add sha256 hash to FIT images when CONFIG_SPL_FIT_SIGNATURE=y. Signed-off-by: Jonas Karlman Reviewed-by: Simon Glass --- v2: - Collect r-b tag arch/arm/dts/rockchip-u-boot.dtsi | 20 1 file changed, 20 insertions(+) diff --git a/arch/arm/dts/rockchip-u-boot.dtsi

[PATCH v2 3/6] binman: Add special subnodes to the nodes generated by split-elf

2023-01-20 Thread Jonas Karlman
Special nodes, hash and signature, is not being added to the nodes generated for each segment in split-elf operation. Copy the subnode logic used in _gen_fdt_nodes to _gen_split_elf to ensure special nodes are added to the generated nodes. Signed-off-by: Jonas Karlman --- v2: - Add test -

[PATCH v2 2/6] rockchip: Align FIT image data to SD/MMC block length

2023-01-20 Thread Jonas Karlman
SPL load FIT images by reading the data aligned to block length. Block length aligned image data is read directly to the load address. Unaligned image data is written to an offset of the load address and then the data is memcpy to the load address. This adds a small overhead of having to memcpy

[PATCH v2 1/6] binman: Add support for align argument to mkimage tool

2023-01-20 Thread Jonas Karlman
Add support to indicate what alignment to use for the FIT and its external data. Pass the alignment to mkimage via the -B flag. Signed-off-by: Jonas Karlman --- v2: - Add test - Update entries.rst tools/binman/btool/mkimage.py | 5 ++- tools/binman/entries.rst| 5 +++

[PATCH v2 0/6] rockchip: Align FIT images to SD/MMC block length

2023-01-20 Thread Jonas Karlman
When I was trying to run mainline U-Boot on my new Rockchip RK3568 board I discovered that one segment of vendor TF-A could not successfully be loaded into SRAM, validation of the image sha256 hash failed. The issue with loading the data turned out to be because of how SPL load FIT images. It

Re: [PATCH] efi_loader: silence 'Failed to load EFI variables' if the file is missing

2023-01-20 Thread Etienne Carriere
On Thu, 19 Jan 2023 at 14:47, Ilias Apalodimas wrote: > > Right, > I'll answer to myself here. > > On Thu, 19 Jan 2023 at 15:26, Ilias Apalodimas > wrote: > > > > Hi Etienne, > > > > On Thu, 19 Jan 2023 at 15:15, Etienne Carriere > > wrote: > > > > > > On Thu, 19 Jan 2023 at 13:53, Ilias