Re: [PATCH 03/15] rockchip: rk3328-rock64: Update defconfig

2024-02-06 Thread Matwey V. Kornilov
ср, 7 февр. 2024 г. в 03:14, Jonas Karlman : > > Update defconfig for rk3328-rock64 with new defaults. > > Remove the SPL_DRIVERS_MISC=y option, no misc driver is used in SPL. What is abould rockchip-efuse? > > Add CONFIG_SPL_FIT_SIGNATURE=y to let SPL verify an auto generated hash > of FIT

Re: [PATCH 04/15] rockchip: rk3328-roc-cc: Update defconfig

2024-02-06 Thread Chen-Yu Tsai
(Resend from subscribed address.) On Wed, Feb 7, 2024 at 8:04 AM Jonas Karlman wrote: > > Update defconfig for rk3328-roc-cc with new defaults. > > Remove the SPL_DRIVERS_MISC=y option, no misc driver is used in SPL. > > Add CONFIG_SPL_FIT_SIGNATURE=y to let SPL verify an auto generated hash >

Re: [PATCH 10/15] rng: rockchip: Use same compatible as linux

2024-02-06 Thread Dragan Simic
Hello Heinrich, On 2024-02-07 08:12, Heinrich Schuchardt wrote: On 2/7/24 01:02, Jonas Karlman wrote: Replace the rockchip,cryptov1-rng compatible with compatibles used in the linux device tree for RK3288, RK3328 and RK3399 to ease sync of SoC device tree from linux. Signed-off-by: Jonas

Re: [PATCH v4] remoteproc: uclass: Add methods to load firmware to rproc and boot rproc

2024-02-06 Thread MD Danish Anwar
Hi Roger On 06/02/24 7:11 pm, Roger Quadros wrote: > > > On 06/02/2024 07:31, MD Danish Anwar wrote: >> >> >> On 05/02/24 6:07 pm, Roger Quadros wrote: >>> >>> >>> On 05/02/2024 12:20, MD Danish Anwar wrote: On 05/02/24 3:36 pm, Roger Quadros wrote: > > > On

Re: [PATCH 10/15] rng: rockchip: Use same compatible as linux

2024-02-06 Thread Heinrich Schuchardt
On 2/7/24 01:02, Jonas Karlman wrote: Replace the rockchip,cryptov1-rng compatible with compatibles used in the linux device tree for RK3288, RK3328 and RK3399 to ease sync of SoC device tree from linux. Signed-off-by: Jonas Karlman It is strange that U-Boot only uses the random number

Re: [PATCH] arm: mach-k3: Refactor QoS settings

2024-02-06 Thread Aradhya Bhatia
On 06-Feb-24 22:58, Andrew Davis wrote: > On 2/6/24 2:56 AM, Aradhya Bhatia wrote: >> Refactor common QoS code into a new common header file, and the soc >> specific setup_qos functions into a common API. >> >> Rename $(soc)_qos_count and $(soc)_qos_data variables to qos_count and >> qos_data.

Re: [PATCH 03/15] rockchip: rk3328-rock64: Update defconfig

2024-02-06 Thread Dragan Simic
On 2024-02-07 01:02, Jonas Karlman wrote: Update defconfig for rk3328-rock64 with new defaults. Remove the SPL_DRIVERS_MISC=y option, no misc driver is used in SPL. Add CONFIG_SPL_FIT_SIGNATURE=y to let SPL verify an auto generated hash of FIT images. This help indicate if there is an issue

Re: [PATCH 01/15] rockchip: rk3328: Update default u-boot, spl-boot-order prop

2024-02-06 Thread Dragan Simic
On 2024-02-07 01:02, Jonas Karlman wrote: Change to use a common FIT load order, same-as-spl > SD-card > eMMC on RK3328 boards. Only EVB and Radxa ROCK Pi E is affected by this change. Signed-off-by: Jonas Karlman Looking good to me. Reviewed-by: Dragan Simic ---

[PATCH 11/15] rockchip: rk3328: Sync device tree from linux v6.8-rc1

2024-02-06 Thread Jonas Karlman
Sync rk3328 device tree from linux v6.8-rc1. Signed-off-by: Jonas Karlman --- arch/arm/dts/rk3328-evb.dts | 1 + arch/arm/dts/rk3328-nanopi-r2s.dts | 3 +- arch/arm/dts/rk3328-orangepi-r1-plus-lts.dts | 4 +- arch/arm/dts/rk3328-orangepi-r1-plus.dts | 1 +

[PATCH 08/15] rockchip: rk3328: Fix loading FIT from SD-card when booting from eMMC

2024-02-06 Thread Jonas Karlman
When RK3328 boards run SPL from eMMC and fail to load FIT from eMMC due to it being missing or checksum validation fails there is a fallback to read FIT from SD-card. However, without proper pinctrl configuration reading FIT from SD-card will fail: U-Boot SPL 2024.04-rc1 (Feb 05 2024 - 22:18:22

[PATCH 09/15] gpio: rockchip: Use gpio alias id as gpio bank id

2024-02-06 Thread Jonas Karlman
The U-Boot driver try to base the gpio bank id on the gpio-ranges prop and fall back to base the bank id on the node name. However, the linux driver try to base the bank id on the gpio alias id and fall back on node order. This can cause issues when SoC DT is synced from linux and gpioX@ nodes

[PATCH 10/15] rng: rockchip: Use same compatible as linux

2024-02-06 Thread Jonas Karlman
Replace the rockchip,cryptov1-rng compatible with compatibles used in the linux device tree for RK3288, RK3328 and RK3399 to ease sync of SoC device tree from linux. Signed-off-by: Jonas Karlman --- arch/arm/dts/rk3328-u-boot.dtsi | 2 +- arch/arm/dts/rk3399-u-boot.dtsi | 2 +-

[PATCH 06/15] rockchip: rk3328-nanopi-r2: Update defconfig

2024-02-06 Thread Jonas Karlman
Update defconfig for rk3328-nanopi-r2* boards with new defaults. Remove the SPL_DRIVERS_MISC=y option, no misc driver is used in SPL. Add CONFIG_SPL_FIT_SIGNATURE=y to let SPL verify an auto generated hash of FIT images. This help indicate if there is an issue loading any of the images to DRAM

[PATCH 03/15] rockchip: rk3328-rock64: Update defconfig

2024-02-06 Thread Jonas Karlman
Update defconfig for rk3328-rock64 with new defaults. Remove the SPL_DRIVERS_MISC=y option, no misc driver is used in SPL. Add CONFIG_SPL_FIT_SIGNATURE=y to let SPL verify an auto generated hash of FIT images. This help indicate if there is an issue loading any of the images to DRAM or SRAM.

[PATCH 07/15] rockchip: rk3328-orangepi-r1-plus: Update defconfig

2024-02-06 Thread Jonas Karlman
Update defconfig for rk3328-orangepi-r1-plus boards with new defaults. Remove the SPL_DRIVERS_MISC=y option, no misc driver is used in SPL. Add CONFIG_SPL_FIT_SIGNATURE=y to let SPL verify an auto generated hash of FIT images. This help indicate if there is an issue loading any of the images to

[PATCH 14/15] rockchip: rk3328-rock64: Enable boot from SPI NOR flash

2024-02-06 Thread Jonas Karlman
Add Kconfig options to enable support for booting from SPI NOR flash on Pine64 Rock64. The generated bootable u-boot-rockchip-spi.bin that can be written to 0x0 of SPI NOR flash. The FIT image is loaded from 0x6, same as on RK35xx boards. => sf probe SF: Detected gd25q128 with page size

[PATCH 12/15] Revert "rockchip: Allow booting from SPI"

2024-02-06 Thread Jonas Karlman
This reverts commit 3523c07867b403d5b3b68812aebac8a5afa5be4c. Booting from SPI was already allowed before this commit was first introduced. A few lines further down the exact same code already existed and still does. Signed-off-by: Jonas Karlman --- arch/arm/mach-rockchip/spl-boot-order.c | 3

[PATCH 15/15] rockchip: rk3328-orangepi-r1-plus: Enable boot from SPI NOR flash

2024-02-06 Thread Jonas Karlman
Add Kconfig options to enable support for booting from SPI NOR flash on Orange Pi R1 Plus boards. The generated bootable u-boot-rockchip-spi.bin that can be written to 0x0 of SPI NOR flash. The FIT image is loaded from 0x6, same as on RK35xx boards. Signed-off-by: Jonas Karlman ---

[PATCH 13/15] rockchip: rk3328: Add support to build bootable SPI image

2024-02-06 Thread Jonas Karlman
Similar to RK35xx the BootRom in RK3328 can read all data and look for idbloader at 0x8000, same as on SD and eMMC. Use the rksd format and modify the mkimage offset to generate a bootable u-boot-rockchip-spi.bin that can be written to 0x0 of SPI NOR flash. Signed-off-by: Jonas Karlman ---

[PATCH 04/15] rockchip: rk3328-roc-cc: Update defconfig

2024-02-06 Thread Jonas Karlman
Update defconfig for rk3328-roc-cc with new defaults. Remove the SPL_DRIVERS_MISC=y option, no misc driver is used in SPL. Add CONFIG_SPL_FIT_SIGNATURE=y to let SPL verify an auto generated hash of FIT images. This help indicate if there is an issue loading any of the images to DRAM or SRAM.

[PATCH 05/15] rockchip: rk3328-rock-pi-e: Update defconfig

2024-02-06 Thread Jonas Karlman
Update defconfig for rk3328-rock-pi-e with new defaults. Remove the xPL_DRIVERS_MISC=y option, no misc driver is used in xPL. Add CONFIG_SPL_FIT_SIGNATURE=y to let SPL verify an auto generated hash of FIT images. This help indicate if there is an issue loading any of the images to DRAM or SRAM.

[PATCH 01/15] rockchip: rk3328: Update default u-boot, spl-boot-order prop

2024-02-06 Thread Jonas Karlman
Change to use a common FIT load order, same-as-spl > SD-card > eMMC on RK3328 boards. Only EVB and Radxa ROCK Pi E is affected by this change. Signed-off-by: Jonas Karlman --- arch/arm/dts/rk3328-nanopi-r2c-plus-u-boot.dtsi | 6 -- arch/arm/dts/rk3328-nanopi-r2s-u-boot.dtsi |

[PATCH 02/15] rockchip: rk3328-evb: Update defconfig

2024-02-06 Thread Jonas Karlman
Update defconfig for rk3328-evb with new defaults. Remove the xPL_DRIVERS_MISC=y option, no misc driver is used in xPL. Add CONFIG_SPL_FIT_SIGNATURE=y to let SPL verify an auto generated hash of FIT images. This help indicate if there is an issue loading any of the images to DRAM or SRAM. Also

[PATCH 00/15] rockchip: rk3328: Update defconfigs, DTs and enable boot from SPI

2024-02-06 Thread Jonas Karlman
This series contains miscellaneous updates to defconfigs, syncs latest device trees from linux, fixes an issue loading FIT from SD-card when running SPL from eMMC and enables building a bootable SPI image on RK3328 boards. I am also adding myself as a reviewer for the three RK3328 boards I own.

[PATCH v1] cmd: hash: fix param count check

2024-02-06 Thread Igor Opaniuk
From: Igor Opaniuk Add correct check for parameter count. This fixes this issue when `hash` cmd is invoked without params: => hash data abort pc : [] lr : [] reloc pc : [<60019204>]lr : [<5afcffa8>] sp : ba6dd9c8 ip : bf7391f0 fp : bf74ec14 r10: 0001 r9 : ba6dfea0 r8

[PATCH v1 7/7] doc: android: avb: add slot_suffix param details

2024-02-06 Thread Igor Opaniuk
From: Igor Opaniuk Add info about slot_suffix param for avb verify. Signed-off-by: Igor Opaniuk --- doc/android/avb2.rst | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/doc/android/avb2.rst b/doc/android/avb2.rst index a072119574f..c0b2bedb831 100644 ---

[PATCH v1 6/7] cmd: avb: rework do_avb_verify_part

2024-02-06 Thread Igor Opaniuk
From: Igor Opaniuk Use existing str_avb_slot_error() function for obtaining verification fail reason details. Take into account device lock state for setting correct androidboot.verifiedbootstate kernel cmdline parameter. Signed-off-by: Igor Opaniuk --- cmd/avb.c | 50

[PATCH v1 5/7] common: avb_verify: add str_avb_io_error/str_avb_slot_error

2024-02-06 Thread Igor Opaniuk
From: Igor Opaniuk Introduce str_avb_io_error() and str_avb_slot_error() functions, that provide a pointer to AVB runtime error message. Signed-off-by: Igor Opaniuk --- common/avb_verify.c | 49 include/avb_verify.h | 3 ++- 2 files changed, 51

[PATCH v1 4/7] cmd: avb: rework prints

2024-02-06 Thread Igor Opaniuk
From: Igor Opaniuk Introduce AVB_OPS_CHECK macro for checking AvbOps before using it to avoid code duplication. Simplify and add more context for prints where it's needed. Signed-off-by: Igor Opaniuk --- cmd/avb.c | 156 -- 1 file changed,

[PATCH v1 3/7] common: avb_verify: rework error/debug prints

2024-02-06 Thread Igor Opaniuk
From: Igor Opaniuk Make error prints more verbose with additional context. Also s/print/debug/g for prints, which might be relevant only for debugging purposes. Signed-off-by: Igor Opaniuk --- common/avb_verify.c | 31 ++- 1 file changed, 18 insertions(+), 13

[PATCH v1 2/7] avb: move SPDX license itdentifiers to the first line

2024-02-06 Thread Igor Opaniuk
From: Igor Opaniuk Move SPDX license identifiers to the first line, so it conforms to license placement rule [1]: Placement: The SPDX license identifier in kernel files shall be added at the first possible line in a file which can contain a comment. For the majority of files this is the first

[PATCH v1 1/7] common: avb_verify: don't call mmc_switch_part for SD

2024-02-06 Thread Igor Opaniuk
From: Igor Opaniuk mmc_switch_part() is used for switching between hw partitions on eMMC (boot0, boot1, user, rpmb). There is no need to do that for SD card. Signed-off-by: Igor Opaniuk --- common/avb_verify.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git

[PATCH v1 0/7] AVB: cosmetic adjustments/improvements

2024-02-06 Thread Igor Opaniuk
This patch series include: - Simplify and add more context for debug/error prints where it's needed. - Move SPDX license identifiers to the first line, so it conforms to license placement rule. - Use mmc_switch_part() only for eMMC. - Rework do_avb_verify_part, take into account device lock

Re: [PATCH 1/5] usb: dwc3-generic: implement Qualcomm wrapper

2024-02-06 Thread Marek Vasut
On 1/31/24 15:57, Caleb Connolly wrote: The Qualcomm specific dwc3 wrapper isn't hugely complicated, implemented the missing initialisation for host and gadget mode. Signed-off-by: Caleb Connolly --- drivers/usb/dwc3/dwc3-generic.c | 99 - 1 file

[PATCH] net: macb: Add support for fixed link

2024-02-06 Thread belouargamohamed
From: BELOUARGA Mohamed The actual driver does not work when there is no linked PHY. These changes add support for fixed-link feature in the device tree. Signed-off-by: BELOUARGA Mohamed --- drivers/net/macb.c | 189 - 1 file changed, 117

Re: [PATCH 02/10] arm: dts: k3-am68*: Sync with 6.8-rc1

2024-02-06 Thread Andrew Davis
On 2/6/24 6:21 AM, Manorit Chawdhry wrote: Syncs the DT from Linux v6.8-rc1. Remove udmap overrides and handle location change of chipid node. Message doesn't match the patch. This patch should just be squashed into the previous one anyway. Andrew Signed-off-by: Manorit Chawdhry ---

Re: [PATCH] arm: mach-k3: Refactor QoS settings

2024-02-06 Thread Andrew Davis
On 2/6/24 2:56 AM, Aradhya Bhatia wrote: Refactor common QoS code into a new common header file, and the soc specific setup_qos functions into a common API. Rename $(soc)_qos_count and $(soc)_qos_data variables to qos_count and qos_data. When QoS settings of more SoCs are added, only one pair

Re: [PATCH v7] fdt: Allow the devicetree to come from a bloblist

2024-02-06 Thread Conor Dooley
On Tue, Jan 23, 2024 at 01:03:00PM -0500, Tom Rini wrote: > On Tue, Jan 23, 2024 at 11:27:57AM +, Conor Dooley wrote: > > On Mon, Jan 22, 2024 at 06:55:01PM +, Conor Dooley wrote: > > > On Mon, Jan 22, 2024 at 01:47:17PM -0500, Tom Rini wrote: > > > > On Mon, Jan 22, 2024 at 06:36:31PM

Re: [PATCH v3 3/3] board: Add support for Conclusive WHLE-LS1088A

2024-02-06 Thread Sean Anderson
On 11/28/23 05:34, Artur Rojek wrote: > Introduce support for Conclusive WHLE-LS1088A Single Board Computer. > > Co-developed-by: Jakub Klama > Signed-off-by: Jakub Klama > Signed-off-by: Artur Rojek > --- > > v3: new patch > > arch/arm/Kconfig | 19 ++ >

[PATCH v2 1/2] imx: imxrt1050-evk: Add support for SPI flash booting

2024-02-06 Thread Jesse Taube
Add support for booting the imxrt1050-evk from spi. Add imximage config and the ability for SPL to boot from NOR. Signed-off-by: Jesse Taube --- V1 -> V2: - Add defconfig to MAINTAINERS - Change Copyright of imximage-nor.cfg to myself - Fix spelling and grammar - Use imperative mood ---

[PATCH v2 2/2] imx: imxrt1050-evk: Add documentation for SPI boot

2024-02-06 Thread Jesse Taube
Add documentation for SPI boot. Signed-off-by: Jesse Taube --- V1 -> V2: - Change s/Adds/Add - Change imxrt1050-evk_spi to fspi - Fix spelling and grammar - Mention the SPI NOR flash part number --- doc/board/nxp/imxrt1050-evk.rst | 30 ++ 1 file changed, 30

Re: [PATCH v3 2/3] board: Add support for Conclusive WHLE-LS1046A

2024-02-06 Thread Sean Anderson
On 11/28/23 05:34, Artur Rojek wrote: > Introduce support for Conclusive WHLE-LS1046A Single Board Computer. > > Co-developed-by: Jakub Klama > Signed-off-by: Jakub Klama > Signed-off-by: Artur Rojek > --- > > v3: no change > > v2: - drop non-DM_ETH case > - clean-up defines in

Re: [PATCH v2] arm: Add OVERLAY command to BSS section on ARM64

2024-02-06 Thread Ilias Apalodimas
On Tue, 6 Feb 2024 at 16:44, Ilias Apalodimas wrote: > > Hi Marek, > > On Sun, Dec 17, 2023 at 01:33:39AM +0100, Marek Vasut wrote: > > Avoid allocating and loading the BSS section. > > > > Can we elaborate a bit more on why we need this? AFAICT there's no code > loading those segments in memory

Re: [PATCH v2] rng: Add Turris Mox rWTM RNG driver

2024-02-06 Thread Max Resch
Hi there Marek, Am 05/02/2024 um 12.40 schrieb Marek Behún: Hello Max, Out of curiousity, what is your use case for having these random numbers on this platform in U-Boot? I use 2 EspressoBin (Armada 3720) as routers, both of them use the TurrisMox firmware. RNG enables the EFI RNG protocol

imx93-var-som: ahab: U-boot is hanging

2024-02-06 Thread Mathieu Othacehe
Hello, I am using the imx93-var-som_defconfig configuration on commit v2024.04-rc1. When producing signed or unsigned images on an unclosed board everything works fine. However, once the board is closed (ahab_close command is issued), u-boot hangs this way: --8<---cut

Re: [PATCH v2] arm: Add OVERLAY command to BSS section on ARM64

2024-02-06 Thread Ilias Apalodimas
Hi Marek, On Sun, Dec 17, 2023 at 01:33:39AM +0100, Marek Vasut wrote: > Avoid allocating and loading the BSS section. > Can we elaborate a bit more on why we need this? AFAICT there's no code loading those segments in memory and swapping them, so why do we need the OVERLAY? On top of that the

Re: [PATCH] xyzModem: Correct xmodem blk verification conditions

2024-02-06 Thread Tom Rini
On Tue, Feb 06, 2024 at 09:05:33PM +0800, jihongbin wrote: > It may be that there are relatively few people using this function, or the > length of the transmitted data is less than 128byte * 255 byte, so the > triggering conditions for the above problems are not encountered; > > I actually

Re: [PATCH 09/10] DONOTMERGE: arm: dts: j721s2: Fix Power domain for VTM node.

2024-02-06 Thread Kumar, Udit
On 2/6/2024 5:51 PM, Manorit Chawdhry wrote: Patch is sent to upstream linux [0]. [0]: https://lore.kernel.org/all/20240201-b4-upstream-j721s2-fix-vtm-devid-v2-0-85fd568b7...@ti.com/ Signed-off-by: Manorit Chawdhry --- arch/arm/dts/k3-j721s2-mcu-wakeup.dtsi | 2 +- 1 file changed, 1

Re: [PATCH] xyzModem: Correct xmodem blk verification conditions

2024-02-06 Thread Dan Carpenter
On Tue, Feb 06, 2024 at 09:05:33PM +0800, jihongbin wrote: > It may be that there are relatively few people using this function, or the > length of the transmitted data is less than 128byte * 255 byte, so the > triggering conditions for the above problems are not encountered; > > I actually

[PATCH] memory: ti-gpmc: Fix lock up at A53 SPL during NAND boot on AM64-EVM

2024-02-06 Thread Roger Quadros
AM64 ES2.0 bootrom seems to enable WAIT0EDGEDETECTION interrupt. This causes a lockup at A53 SPL when accessing NAND controller or ELM registers. A good option would be to softrest GPMC block at probe but this cannot be done for AM64 as SOFTRESET bit is marked as reserved in SYSCONFIG register.

Re: [PATCH] xyzModem: Correct xmodem blk verification conditions

2024-02-06 Thread jihongbin
It may be that there are relatively few people using this function, or the length of the transmitted data is less than 128byte * 255 byte, so the triggering conditions for the above problems are not encountered; I actually discovered this problem during testing. Continuous transmission always

Re: [PATCH] xyzModem: Correct xmodem blk verification conditions

2024-02-06 Thread jihongbin
This is a duplicate, please ignore 在 2024/2/6 10:49, Hongbin Ji 写道: When the blk sequence number is 255 and cblk is 0, the original XOR condition produces a result of 0,and the judgment condition will be unsuccessful. Signed-off-by: Hongbin Ji --- common/xyzModem.c | 2 +- 1 file changed,

Re: [PATCH] xyzModem: Correct xmodem blk verification conditions

2024-02-06 Thread Tom Rini
On Tue, Feb 06, 2024 at 10:49:25AM +0800, Hongbin Ji wrote: > When the blk sequence number is 255 and cblk is 0, the original XOR condition > produces a result of 0,and the judgment condition will be unsuccessful. > > Signed-off-by: Hongbin Ji > --- > common/xyzModem.c | 2 +- > 1 file

Re: [PATCH 00/10] Add AVS support for J721S2

2024-02-06 Thread Tom Rini
On Tue, Feb 06, 2024 at 05:51:07PM +0530, Manorit Chawdhry wrote: > This series does the DT sync with Linux 6.8-rc1 as that has the pmic > nodes required for AVS support and then adds AVS Support for J721S2. > > AVS Test for J721S2: >

Re: [PATCH v4] remoteproc: uclass: Add methods to load firmware to rproc and boot rproc

2024-02-06 Thread Roger Quadros
On 06/02/2024 07:31, MD Danish Anwar wrote: > > > On 05/02/24 6:07 pm, Roger Quadros wrote: >> >> >> On 05/02/2024 12:20, MD Danish Anwar wrote: >>> >>> >>> On 05/02/24 3:36 pm, Roger Quadros wrote: On 02/02/2024 18:40, Anwar, Md Danish wrote: > Hi Roger, > > On

Re: [PATCH v5 00/11] An effort to bring DT bindings compliance within U-Boot

2024-02-06 Thread Tom Rini
On Tue, Feb 06, 2024 at 10:57:12AM +0530, Sumit Garg wrote: > Hi Tom, > > On Fri, 2 Feb 2024 at 23:32, Tom Rini wrote: > > > > On Fri, Feb 02, 2024 at 06:35:23PM +0530, Sumit Garg wrote: > > > > > Changes in v5: > > > -- > > > - Rebased on tip of master

Re: [PATCH] lib: sparse: Fix error checking for write_sparse_chunk_raw

2024-02-06 Thread Mattijs Korpershoek
Hi, On Thu, 01 Feb 2024 13:18:51 -0500, Sean Anderson wrote: > The return value of write_sparse_chunk_raw is unsigned, so the existing > check has no effect. Use IS_ERR_VALUE to detect error instead, which is > what write_sparse_chunk_raw does itself. > > Thanks, Applied to

Re: [PATCH 08/18] rockchip: pine64: rockpro64: migrate to rockchip_early_misc_init_r

2024-02-06 Thread Dragan Simic
On 2024-02-06 13:37, Quentin Schulz wrote: On 2/6/24 13:33, Dragan Simic wrote: On 2024-02-06 13:26, Quentin Schulz wrote: On 2/4/24 11:39, Dragan Simic wrote: On 2024-02-04 10:46, Jonas Karlman wrote: On 2024-02-04 05:21, Dragan Simic wrote: On 2024-02-03 16:18, Dragan Simic wrote: On

Re: [PATCH 08/18] rockchip: pine64: rockpro64: migrate to rockchip_early_misc_init_r

2024-02-06 Thread Quentin Schulz
Hi Dragan, On 2/6/24 13:33, Dragan Simic wrote: [Some people who received this message don't often get email from dsi...@manjaro.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] Hello Quentin, On 2024-02-06 13:26, Quentin Schulz wrote: On 2/4/24 11:39,

Re: [PATCH 08/18] rockchip: pine64: rockpro64: migrate to rockchip_early_misc_init_r

2024-02-06 Thread Dragan Simic
Hello Quentin, On 2024-02-06 13:26, Quentin Schulz wrote: On 2/4/24 11:39, Dragan Simic wrote: On 2024-02-04 10:46, Jonas Karlman wrote: On 2024-02-04 05:21, Dragan Simic wrote: On 2024-02-03 16:18, Dragan Simic wrote: On 2024-02-03 15:18, Jonas Karlman wrote: On 2024-02-03 14:19, Dragan

Re: [PATCH 08/18] rockchip: pine64: rockpro64: migrate to rockchip_early_misc_init_r

2024-02-06 Thread Quentin Schulz
Hi Dragan, Jonas, On 2/4/24 11:39, Dragan Simic wrote: [Some people who received this message don't often get email from dsi...@manjaro.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] Hello Jonas, On 2024-02-04 10:46, Jonas Karlman wrote: On 2024-02-04

[PATCH 10/10] configs: j721s2_evm_r5_defconfig: Add AVS Configs

2024-02-06 Thread Manorit Chawdhry
Add AVS and PMIC regulator configs Signed-off-by: Manorit Chawdhry --- configs/j721s2_evm_r5_defconfig | 6 ++ 1 file changed, 6 insertions(+) diff --git a/configs/j721s2_evm_r5_defconfig b/configs/j721s2_evm_r5_defconfig index b180f6c48c0e..847758bb5334 100644 ---

[PATCH 09/10] DONOTMERGE: arm: dts: j721s2: Fix Power domain for VTM node.

2024-02-06 Thread Manorit Chawdhry
Patch is sent to upstream linux [0]. [0]: https://lore.kernel.org/all/20240201-b4-upstream-j721s2-fix-vtm-devid-v2-0-85fd568b7...@ti.com/ Signed-off-by: Manorit Chawdhry --- arch/arm/dts/k3-j721s2-mcu-wakeup.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 08/10] arm: dts: j721s2: Add VTM node in R5

2024-02-06 Thread Manorit Chawdhry
Add bootph-pre-ram property to VTM node and the pmic node. Signed-off-by: Manorit Chawdhry --- arch/arm/dts/k3-j721s2-r5-common-proc-board.dts | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm/dts/k3-j721s2-r5-common-proc-board.dts

[PATCH 07/10] arm: mach-k3: j721s2_init: Initialize AVS Class 0

2024-02-06 Thread Manorit Chawdhry
Initialize AVS Class 0. Signed-off-by: Manorit Chawdhry --- arch/arm/mach-k3/j721s2_init.c | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/mach-k3/j721s2_init.c b/arch/arm/mach-k3/j721s2_init.c index fb0708bae162..7080c519cf4c 100644 --- a/arch/arm/mach-k3/j721s2_init.c +++

[PATCH 06/10] drivers: power: pmic: Fix compatible for J721S2

2024-02-06 Thread Manorit Chawdhry
The other compatible is not in use by any other DT node. Sync the compatible with the compatible present in Linux DT to help with DT Sync from Linux as well. Signed-off-by: Manorit Chawdhry --- drivers/power/pmic/tps65941.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 05/10] drivers: misc: k3_avs: Add AVS Support for J721S2.

2024-02-06 Thread Manorit Chawdhry
Add AVS Support for J721S2. Signed-off-by: Manorit Chawdhry --- drivers/misc/k3_avs.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/misc/k3_avs.c b/drivers/misc/k3_avs.c index e20dc6755c29..28e59fcf41d4 100644 --- a/drivers/misc/k3_avs.c +++

[PATCH 04/10] drivers: misc: k3_avs: Check return code while programming AVS

2024-02-06 Thread Manorit Chawdhry
Check if AVS could not be programmed and print a warning. Signed-off-by: Manorit Chawdhry --- drivers/misc/k3_avs.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/misc/k3_avs.c b/drivers/misc/k3_avs.c index 02cd90f9d12c..e20dc6755c29 100644 ---

[PATCH 03/10] drivers: misc: k3_avs: Use soc_match_device instead of compatible.

2024-02-06 Thread Manorit Chawdhry
vd_data remains the same for most of the SoCs but there are some differences in power domains and clocks that don't need a change to compatible and can be handled at SoC level. Change the data population logic from compatible to soc_match_device to add support for newer devices. Signed-off-by:

[PATCH 02/10] arm: dts: k3-am68*: Sync with 6.8-rc1

2024-02-06 Thread Manorit Chawdhry
Syncs the DT from Linux v6.8-rc1. Remove udmap overrides and handle location change of chipid node. Signed-off-by: Manorit Chawdhry --- arch/arm/dts/k3-am68-sk-base-board.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/dts/k3-am68-sk-base-board.dts

[PATCH 01/10] arm: dts: k3-j721s2*: Sync with 6.8-rc1

2024-02-06 Thread Manorit Chawdhry
Syncs the DT from Linux v6.8-rc1. Remove udmap overrides and handle location change of chipid node. Signed-off-by: Manorit Chawdhry --- arch/arm/dts/k3-am68-sk-base-board-u-boot.dtsi | 18 +- .../dts/k3-j721s2-common-proc-board-u-boot.dtsi| 18 +- arch/arm/dts/k3-j721s2-main.dtsi

[PATCH 00/10] Add AVS support for J721S2

2024-02-06 Thread Manorit Chawdhry
This series does the DT sync with Linux 6.8-rc1 as that has the pmic nodes required for AVS support and then adds AVS Support for J721S2. AVS Test for J721S2: https://gist.github.com/manorit2001/d7690ded6ef685aa8ffa5b16746cc529 Boot Test results:

[PATCH] arm64: versal-net: Setup correct addresses of GICR/GICD

2024-02-06 Thread Michal Simek
Previous addresses where used in past in emulation environment but never gets to silicon that's why use correct addresses. Signed-off-by: Michal Simek --- include/configs/xilinx_versal_net.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH 1/5] xilinx: Fix fpga region DT nodes name

2024-02-06 Thread Michal Simek
On 2/1/24 13:38, Michal Simek wrote: fpga-full is not aligned with the latest dt-schema. Generic name fpga-region should be used. Signed-off-by: Michal Simek --- Aligned with fpga-region dt schema

Re: [PATCH] arm64: zynqmp: Fix kr260 clock wiring

2024-02-06 Thread Michal Simek
On 1/30/24 15:51, Michal Simek wrote: kr260 revA/revA01 is using discrete oscilator for DP (27MHz) and si5332 for other clocks but clocks are different compare to kv260 that's why fix it to aligned with the latest schematics. On the other handle kr260 revB/revA03 also contains 74.25 MHz

Re: [PATCH] arm64: zynqmp: Describe 25MHz fixed clock for PL GEMs

2024-02-06 Thread Michal Simek
On 1/29/24 08:46, Michal Simek wrote: Describe 25Mhz fixed oscilator which is providing clock for PL based ethernet IPs. Physicially it is one chip but it is described as 2 fixed clock to be aligned with other SOM versions which were using integrated clock generators where clocks could be

Re: [PATCH] configs: versal: Enable CONFIG_LTO for mini qspi/ospi

2024-02-06 Thread Michal Simek
On 1/26/24 09:09, Venkatesh Yadav Abbarapu wrote: Adding a tiny bit more code for mini u-boot leads to a OCM image overflow. Fix this by enabling LTO for this board, so that such changes still can be made to the common U-Boot code. Enable building mini u-boot image with LTO, which results in

Re: [PATCH] configs: versal_net: Enable CONFIG_LTO for mini qspi/ospi

2024-02-06 Thread Michal Simek
On 1/26/24 09:11, Venkatesh Yadav Abbarapu wrote: Adding a tiny bit more code for mini u-boot leads to a OCM image overflow. Fix this by enabling LTO for this board, so that such changes still can be made to the common U-Boot code. Enable building mini u-boot image with LTO, which results in

Re: [PATCH] arm64: zynqmp: Sync clock labels with kr260 revB

2024-02-06 Thread Michal Simek
On 1/26/24 08:24, Michal Simek wrote: Board description describes the hard part of chip (PS) but programmable logic (PL) part is not described in this file. But clocks on the board are not only connected to PS but also wired to PL. And because two revisions are available where revA is using

Re: [PATCH] arm64: zynqmp: Add 'silabs, skip-recall' to all si570 clk nodes

2024-02-06 Thread Michal Simek
On 1/25/24 09:07, Michal Simek wrote: From: Saeed Nowshadi Without 'silabs,skip-recall' property, the driver on System Controller re-calibrates the output clock frequency at probe() time based on the NVRAM setting. This re-calibration causes a glitch on the output clock. At power-on,

Re: [PATCH] arm64: xilinx: Enable EFI_HTTP_BOOT by default

2024-02-06 Thread Michal Simek
On 1/24/24 11:58, Michal Simek wrote: Enable EFI_HTTP_BOOT to be able to booting OS via http. In case of that dhcp server is not providing dns server IP set it up via setenv dnsip . Signed-off-by: Michal Simek --- I am ignoring defconfig sync because it needs to done because of

Re: [PATCH] soc: zynqmp: Add the IDcode for dr_SE and eg_SE variants

2024-02-06 Thread Michal Simek
On 1/23/24 05:57, Venkatesh Yadav Abbarapu wrote: ID code is added for zu67dr_SE, zu11eg_SE, zu19eg_SE and zu47dr_SE variants. SE is the select edition of restricted devices with the capabilities. Signed-off-by: Venkatesh Yadav Abbarapu --- drivers/soc/soc_xilinx_zynqmp.c | 28

[PATCH v2] scripts: dtc-version: Don't show error messages

2024-02-06 Thread Dragan Simic
Prevent the error messages produced by which(1), such as the one quoted below, from being visible in the build outputs. which: no dtc in (./scripts/dtc) This makes the build outputs look a tiny bit cleaner. Signed-off-by: Dragan Simic Reviewed-by: Quentin Schulz --- Notes: Version 2

Re: [PATCH v2 1/4] imx8mp-phyboard-pollux-rdk: sync with kernel devicetree from v6.8-rc2

2024-02-06 Thread Dan Carpenter
On Tue, Feb 06, 2024 at 10:36:33AM +, Teresa Remmet wrote: > Hello Benjamin, > > > Am Mittwoch, dem 31.01.2024 um 09:45 +0100 schrieb Benjamin Hahn: > > Signed-off-by: Benjamin Hahn > > please add a proper patch description. Adding only a subject line > ist not enough. > One idea that I

Re: [PATCH] scripts: dtc-version: Don't show error messages

2024-02-06 Thread Dragan Simic
On 2024-02-06 11:41, Quentin Schulz wrote: On 2/6/24 11:37, Dragan Simic wrote: On 2024-02-06 11:25, Quentin Schulz wrote: On 2/6/24 04:56, Dragan Simic wrote: Prevent the error messages produced by which(1), such as the one quoted below, from being visible in the build outputs. which:

Re: [PATCH] scripts: dtc-version: Don't show error messages

2024-02-06 Thread Quentin Schulz
Hi Dragan, On 2/6/24 11:37, Dragan Simic wrote: [You don't often get email from dsi...@manjaro.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] Hello Quentin, On 2024-02-06 11:25, Quentin Schulz wrote: On 2/6/24 04:56, Dragan Simic wrote: Prevent the

Re: [PATCH] scripts: dtc-version: Don't show error messages

2024-02-06 Thread Dragan Simic
Hello Quentin, On 2024-02-06 11:25, Quentin Schulz wrote: On 2/6/24 04:56, Dragan Simic wrote: Prevent the error messages produced by which(1), such as the one quoted below, from being visible in the build outputs. which: no dtc in (./scripts/dtc) This makes the build outputs look a

Re: [PATCH v2 1/4] imx8mp-phyboard-pollux-rdk: sync with kernel devicetree from v6.8-rc2

2024-02-06 Thread Teresa Remmet
Hello Benjamin, Am Mittwoch, dem 31.01.2024 um 09:45 +0100 schrieb Benjamin Hahn: > Signed-off-by: Benjamin Hahn please add a proper patch description. Adding only a subject line ist not enough. Thanks, Teresa > --- >  arch/arm/dts/imx8mp-phyboard-pollux-rdk.dts | 162 >

Re: [PATCH] scripts: dtc-version: Don't show error messages

2024-02-06 Thread Quentin Schulz
Hi Dragan, On 2/6/24 04:56, Dragan Simic wrote: [You don't often get email from dsi...@manjaro.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] Prevent the error messages produced by which(1), such as the one quoted below, from being visible in the build

[PATCH] arm: mach-k3: Refactor QoS settings

2024-02-06 Thread Aradhya Bhatia
Refactor common QoS code into a new common header file, and the soc specific setup_qos functions into a common API. Rename $(soc)_qos_count and $(soc)_qos_data variables to qos_count and qos_data. When QoS settings of more SoCs are added, only one pair will be defined at a time, based on the

Re: [PATCH v3 3/3] cmd: rng: Add rng list command

2024-02-06 Thread Weizhao Ouyang
Hi Tom, On Tue, Feb 6, 2024 at 2:14 AM Tom Rini wrote: > > On Wed, Jan 31, 2024 at 02:14:26PM +, Weizhao Ouyang wrote: > > > The 'rng list' command probes all RNG devices and list those devices > > that are successfully probed. Also update the help info. > > > > Reviewed-by: Heinrich