Re: [PATCH v2 0/3] dt-bindings: arm: bcm: raspberrypi,bcm2835-firmware: Drive-by fixes

2024-04-02 Thread Ivan T. Ivanov
Hi, On 2024-03-28 01:37, Laurent Pinchart wrote: On Wed, Mar 27, 2024 at 07:49:38AM +0100, Stefan Wahren wrote: Hi, [add Peter and Ivan] Am 26.03.24 um 20:58 schrieb Laurent Pinchart: > Hello, > > This small series includes a few drive-by fixes for DT validation > errors. > > The first

Re: [PATCH v2 0/3] dt-bindings: arm: bcm: raspberrypi,bcm2835-firmware: Drive-by fixes

2024-03-28 Thread Ivan T. Ivanov
Hi, > On 28 Mar 2024, at 1:37, Laurent Pinchart > wrote: > > On Wed, Mar 27, 2024 at 07:49:38AM +0100, Stefan Wahren wrote: >> Hi, >> >> [add Peter and Ivan] >> >> Am 26.03.24 um 20:58 schrieb Laurent Pinchart: >>> Hello, >>> >>> This small series includes a few drive-by fixes for DT

Re: Booting RPi5B with latest git

2024-02-19 Thread Ivan T. Ivanov
Hi, > On 17 Feb 2024, at 20:55, Jojan wrote: > > For RPi 5B you need bcm2712 device tree . RPi4 uses 2711.So the e > rpi_arm64_confi does not work for RPi5 > Also make sure that you have the changes discussed here.[GIT PULL] rpi: > updates for v2024.04 (mail-archive.com) You don’t have to

[PATCH v5 7/7] configs: rpi_arm64: build position independent code

2024-01-23 Thread Ivan T. Ivanov
5 Model B Rev 1.0 Raspberry Pi 4 Model B Rev 1.1 Raspberry Pi 3 Model B Plus Rev 1.3 Raspberry Pi Zero 2 W Rev 1.0 Raspberry Pi 2 Model B Rev 1.2 Raspberry Pi Compute Module 4 Rev 1.0 Raspberry Pi Compute Module 3 Rev 1.0 Signed-off-by: Ivan T. Ivanov --- configs/rpi_arm64_defconfig | 2 +- 1 fi

[PATCH v5 6/7] configs: rpi_arm64: enable SDHCI BCMSTB driver

2024-01-23 Thread Ivan T. Ivanov
RPi5 have "brcm,bcm2712-sdhci" controller which is handled by "sdhci-bcmstb" driver, so enable it. Signed-off-by: Ivan T. Ivanov --- configs/rpi_arm64_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/rpi_arm64_defconfig b/configs/rpi_arm64_defcon

[PATCH v5 5/7] mmc: bcmstb: Add support for bcm2712 SD controller

2024-01-23 Thread Ivan T. Ivanov
Make sure that core SDHCI accessors are used and add device specific card detection initialization, which is borrowed from vendor Linux driver code. Signed-off-by: Ivan T. Ivanov --- drivers/mmc/bcmstb_sdhci.c | 64 +++--- 1 file changed, 60 insertions(+), 4

[PATCH v5 4/7] bcm2835: Dynamically calculate bytes per pixel parameter

2024-01-23 Thread Ivan T. Ivanov
brcm,bcm2708-fb device provided by firmware on RPi5 uses 16 bits per pixel, so lets calculate framebuffer bytes per pixel dynamically based on queried information. Tested to work for RPi2b v1.2, RPi3b v1.3, RPi4b v1.1, RPi2 Zero W, RPi5b v1.0. Reviewed-by: Matthias Brugger Signed-off-by: Ivan T

[PATCH v5 3/7] rpi5: Use devicetree to retrieve board revision

2024-01-23 Thread Ivan T. Ivanov
linux,serial = <0x6cf44e80 0x3c533ede>; }; Reviewed-by: Matthias Brugger Signed-off-by: Ivan T. Ivanov --- board/raspberrypi/rpi/rpi.c | 22 +++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/board/raspberrypi/rpi/rpi.c b/board/raspberrypi/rpi/rpi.c ind

[PATCH v5 2/7] rpi5: Use devicetree as alternative way to read IO base addresses

2024-01-23 Thread Ivan T. Ivanov
From: Dmitry Malkin MBOX and Watchdog on RPi5/bcm2712 have a different base IO offsets. Find them via devicetree blob passed by bootloader. Signed-off-by: Dmitry Malkin Reviewed-by: Matthias Brugger Signed-off-by: Ivan T. Ivanov --- arch/arm/mach-bcm283x/include/mach/base.h | 5 ++- arch

[PATCH v5 1/7] rpi5: add initial memory map for bcm2712

2024-01-23 Thread Ivan T. Ivanov
l properly reserve framebuffer region. When no HDMI cable is plugged in the size of the region will be 0x3fc0UL. Signed-off-by: Dmitry Malkin Signed-off-by: Ivan T. Ivanov --- arch/arm/mach-bcm283x/init.c | 31 +++ 1 file changed, 31 insertions(+) diff --git

[PATCH v5 0/7] rpi5: initial support

2024-01-23 Thread Ivan T. Ivanov
memory map for bcm2712 rpi5: Use devicetree as alternative way to read IO base addresses Ivan T. Ivanov (5): rpi5: Use devicetree to retrieve board revision bcm2835: Dynamically calculate bytes per pixel parameter mmc: bcmstb: Add support for bcm2712 SD controller configs: rpi_arm64: enable SD

Re: Re: [PATCH v4 0/6] rpi5: initial support

2024-01-22 Thread Ivan T. Ivanov
Hi, On 01-22 13:57, Ivan T. Ivanov wrote: > > Am 20.01.24 um 10:48 schrieb Jens Maus: > >> Hi, > >> > >>> Am 20.01.2024 um 10:22 schrieb Stefan Wahren : > >>> > >>> Am 19.01.24 um 22:26 schrieb Jens Maus: > >>>> I ac

Re: [PATCH v4 0/6] rpi5: initial support

2024-01-22 Thread Ivan T. Ivanov
Hi, > On 20 Jan 2024, at 12:50, Stefan Wahren wrote: > > Hi, > > Am 20.01.24 um 10:48 schrieb Jens Maus: >> Hi, >> >>> Am 20.01.2024 um 10:22 schrieb Stefan Wahren : >>> >>> Am 19.01.24 um 22:26 schrieb Jens Maus: I actually do have some good and bad news: 1. Good news: I got

Re: Re: [PATCH v4 0/6] rpi5: initial support

2024-01-19 Thread Ivan T. Ivanov
On 01-19 17:12, Jens Maus wrote: > >> > >> On the HDMI port, right? But what about the serial UART output? > > > > Yes, I can see serial output from U-Boot. I am using one of these > > simple USB<->UART cables. You can see serial output when you boot > > with RPiOS, when you use "Raspberry Pi

Re: [PATCH v4 0/6] rpi5: initial support

2024-01-19 Thread Ivan T. Ivanov
> On 19 Jan 2024, at 16:08, Jens Maus wrote: > > >> Am 19.01.2024 um 15:06 schrieb Ivan T. Ivanov : >> >> On 01-19 14:54, Jens Maus wrote: >>> >>>> Am 19.01.2024 um 14:46 schrieb Ivan T. Ivanov : >>>> >>>> Same he

Re: Re: [PATCH v4 0/6] rpi5: initial support

2024-01-19 Thread Ivan T. Ivanov
Hi, On 01-19 14:54, Jens Maus wrote: > > > Am 19.01.2024 um 14:46 schrieb Ivan T. Ivanov : > > > > Same here, expect that they are more memory banks, of course. > > It is really strange that you don't seen even single message > > from the U-Boot.. > > In

Re: Re: [PATCH v4 0/6] rpi5: initial support

2024-01-19 Thread Ivan T. Ivanov
+ u-boot@lists.denx.de I am not sure how I drop the list in my last email, sorry. On 01-19 12:56, Jens Maus wrote: > Hi Ivan, > > > Am 19.01.2024 um 12:22 schrieb Ivan T. Ivanov : > > > > On 01-19 11:49, Jens Maus wrote: > >>> Am 19.01.2024 um 10:20 schrieb

Re: Re: [PATCH v4 0/6] rpi5: initial support

2024-01-18 Thread Ivan T. Ivanov
to the board and one when cable is unplugged. Regards, Ivan >From f9e039d3febbb046fe06f72731e7ba558927aa55 Mon Sep 17 00:00:00 2001 From: "Ivan T. Ivanov" Date: Fri, 19 Jan 2024 07:22:39 +0200 Subject: [PATCH] fdtdec: hack: Show DRAM size parameters --- lib/fdtdec.c | 2 +- 1 file c

Re: [PATCH v4 0/6] rpi5: initial support

2024-01-18 Thread Ivan T. Ivanov
Hi, > On 18 Jan 2024, at 1:06, Jens Maus wrote: > > Hi, > >> Am 17.01.2024 um 17:45 schrieb Ivan T. Ivanov : >> >> I have aarch64 based machine at hand running openSUSE, >> thus I am building U-boot “natively”, no cross-compiling. >> >> $

Re: [PATCH v4 0/6] rpi5: initial support

2024-01-17 Thread Ivan T. Ivanov
Hi, > On 17 Jan 2024, at 17:30, Jens Maus wrote: > > Hi, > >> Am 17.01.2024 um 16:23 schrieb Ivan T. Ivanov : >> >>> That’s in fact exactly what I was also trying in addition to get u-boot >>> running with your patches in my own buildroot-based env

Re: [PATCH v4 0/6] rpi5: initial support

2024-01-17 Thread Ivan T. Ivanov
Hi, > On 17 Jan 2024, at 17:13, Jens Maus wrote: > > Hi, > >> Am 17.01.2024 um 16:07 schrieb Ivan T. Ivanov : >> >> On 01-12 14:10, Jens Maus wrote: >>> >>> Hi Ivan, >>> >>> first of all, thanks for the updated rpi5 pa

Re: Re: [PATCH v4 0/6] rpi5: initial support

2024-01-17 Thread Ivan T. Ivanov
Hi, On 01-12 14:10, Jens Maus wrote: > > Hi Ivan, > > first of all, thanks for the updated rpi5 patchset. However, I am unable to > reproduce that it is actually working as you suggest. Could you please > quickly elaborate on your test environment and the test config.txt for the >

Re: Re: Re: [PATCH v4 5/6] mmc: bcmstb: Add support for bcm2712 SD controller

2024-01-16 Thread Ivan T. Ivanov
Hi, > On 01-12 09:44, Ivan T. Ivanov wrote: > On 01-11 23:07, Stefan Wahren wrote: > > > > Hi Ivan, > > > > Am 10.01.24 um 13:29 schrieb Ivan T. Ivanov: > > > Borrow SD quirks from vendor Linux driver. > > > > > > "BCM

Re: Re: [PATCH v4 2/6] rpi5: Use devicetree as alternative way to read IO base addresses

2024-01-16 Thread Ivan T. Ivanov
On 01-10 10:00, Florian Fainelli wrote: > On 1/10/24 04:29, Ivan T. Ivanov wrote: > > From: Dmitry Malkin > > > > MBOX and Watchdog on RPi5/bcm2712 has a different base IO offsets. > > s/has a/have a / > Thanks! > > Find them via devicetree blob passe

Re: Re: [PATCH v4 5/6] mmc: bcmstb: Add support for bcm2712 SD controller

2024-01-11 Thread Ivan T. Ivanov
On 01-11 23:07, Stefan Wahren wrote: > > Hi Ivan, > > Am 10.01.24 um 13:29 schrieb Ivan T. Ivanov: > > Borrow SD quirks from vendor Linux driver. > > > > "BCM2712 unfortunately carries with it a perennial bug with the SD > > controller register inter

[PATCH v4 5/6] mmc: bcmstb: Add support for bcm2712 SD controller

2024-01-10 Thread Ivan T. Ivanov
MMAND, TRANSFER_MODE, BLOCK_SIZE and BLOCK_COUNT registers tramples the upper/lower 16 bits of data written. BCM2712 does not seem to need the extreme delay between each write as on previous chips, just the serialisation of writes to these registers in a single 32-bit operation." Signed-off-by: Ivan

[PATCH v4 4/6] bcm2835: Dynamically calculate bytes per pixel parameter

2024-01-10 Thread Ivan T. Ivanov
brcm,bcm2708-fb device provided by firmware on RPi5 uses 16 bits per pixel, so lets calculate framebuffer bytes per pixel dynamically based on queried information. Tested to work for RPi2b v1.2, RPi3b v1.3, RPi4b v1.1, RPi2 Zero W, RPi5b v1.0. Signed-off-by: Ivan T. Ivanov --- drivers/video

[PATCH v4 6/6] configs: rpi_arm64: enable SDHCI BCMSTB driver

2024-01-10 Thread Ivan T. Ivanov
RPi5 have "brcm,bcm2712-sdhci" controller which is handled by "sdhci-bcmstb" driver, so enable it. Signed-off-by: Ivan T. Ivanov --- configs/rpi_arm64_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/rpi_arm64_defconfig b/configs/rpi_arm64_defcon

[PATCH v4 3/6] rpi5: Use devicetree to retrieve board revision

2024-01-10 Thread Ivan T. Ivanov
linux,serial = <0x6cf44e80 0x3c533ede>; }; Reviewed-by: Matthias Brugger Signed-off-by: Ivan T. Ivanov --- board/raspberrypi/rpi/rpi.c | 22 +++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/board/raspberrypi/rpi/rpi.c b/board/raspberrypi/rpi/rpi.c ind

[PATCH v4 2/6] rpi5: Use devicetree as alternative way to read IO base addresses

2024-01-10 Thread Ivan T. Ivanov
From: Dmitry Malkin MBOX and Watchdog on RPi5/bcm2712 has a different base IO offsets. Find them via devicetree blob passed by bootloader. Signed-off-by: Dmitry Malkin Reviewed-by: Matthias Brugger Signed-off-by: Ivan T. Ivanov --- arch/arm/mach-bcm283x/include/mach/base.h | 5 ++- arch

[PATCH v4 1/6] rpi5: add initial memory map for bcm2712

2024-01-10 Thread Ivan T. Ivanov
l properly reserve frameboofer region. When no HDMI cable is plugged in size of the region will be 0x3fc0UL. Signed-off-by: Dmitry Malkin Signed-off-by: Ivan T. Ivanov --- arch/arm/mach-bcm283x/init.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/arc

[PATCH v4 0/6] rpi5: initial support

2024-01-10 Thread Ivan T. Ivanov
e consider for inclusion. Thanks, Ivan [1] https://lore.kernel.org/all/20231218210341.30073-1-iiva...@suse.de/ [2] https://lore.kernel.org/all/CAKRNjQ0dsWozGo4n8g58m4cCEk3n=qx1r+l24wbgpo-ip1y...@mail.gmail.com/ Dmitry Malkin (2): rpi5: add initial memory map for bcm2712 rpi5: Use devicetree as alternativ

Re: [PATCH v3 0/7] rpi5: initial support

2023-12-22 Thread Ivan T. Ivanov
On 12-22 12:19, Marc Zyngier wrote: > > Hi Ivan, > > On 2023-12-18 21:03, Ivan T. Ivanov wrote: > > Hi, > > > > These patches are adding basic support for RPi5. > > They are based on v2 series from Dmitry Malkin[1]. > > > > With them I am able to

Re: [PATCH v3 5/7] mmc: bcmstb: Add support for bcm2712 SD controller

2023-12-22 Thread Ivan T. Ivanov
On 12-21 16:39, Stefan Wahren wrote: > To: Florian Fainelli , "Ivan T. Ivanov" > > > > On 12/18/2023 10:03 PM, Ivan T. Ivanov wrote: > > > Borrow SD quirks from vendor Linux driver. > > > > > > "BCM2712 unfortunately carries with

Re: [PATCH v3 4/7] bcm2835: brcm,bcm2708-fb device is using r5g6b5 format

2023-12-21 Thread Ivan T. Ivanov
On 12-20 09:51, Matthias Brugger wrote: > > > > > > > >static const struct udevice_id bcm2835_video_ids[] = { > > > > - { .compatible = "brcm,bcm2835-hdmi" }, > > > > - { .compatible = "brcm,bcm2711-hdmi0" }, > > > > - { .compatible = "brcm,bcm2708-fb" }, > > > > + {

Re: [PATCH v3 1/7] rpi5: add initial memory map for bcm2712

2023-12-20 Thread Ivan T . Ivanov
Hi, On 12-18 23:03, Ivan T. Ivanov wrote: > > +static struct mm_region bcm2712_mem_map[MEM_MAP_MAX_ENTRIES] = { > + { > + .virt = 0xUL, > + .phys = 0xUL, > + .size = 0x3f80UL, Something that I realized just no

Re: [PATCH v3 1/7] rpi5: add initial memory map for bcm2712

2023-12-20 Thread Ivan T. Ivanov
On 12-19 21:45, Simon Glass wrote: > > > > +static struct mm_region bcm2712_mem_map[MEM_MAP_MAX_ENTRIES] = { > > Would it be possible to read these from the devicetree? If there is a devicetree passed, yes, it will be possible. I have not done this just because I can't test all possible

Re: [PATCH v3 4/7] bcm2835: brcm,bcm2708-fb device is using r5g6b5 format

2023-12-19 Thread Ivan T. Ivanov
On 12-18 23:32, Stefan Wahren wrote: > > > > static const struct udevice_id bcm2835_video_ids[] = { > > - { .compatible = "brcm,bcm2835-hdmi" }, > > - { .compatible = "brcm,bcm2711-hdmi0" }, > > - { .compatible = "brcm,bcm2708-fb" }, > > + { .compatible = "brcm,bcm2835-hdmi", .data =

Re: [PATCH v3 1/7] rpi5: add initial memory map for bcm2712

2023-12-19 Thread Ivan T. Ivanov
On 12-18 23:25, Stefan Wahren wrote: > > > > +static struct mm_region bcm2712_mem_map[MEM_MAP_MAX_ENTRIES] = { > > + { > in comparison to mach-imx/imx9/soc.c most of the memory maps doesn't > have a describing comment. Yep, I have thinking to add more comments, but decided to not modify too

[PATCH v3 7/7] pci: pcie-brcmstb: Add bcm2712 PCIe controller support

2023-12-18 Thread Ivan T. Ivanov
PCIe controller have minor register map difference compared to bcm2711 variant. Handle this using device specific register offset. Signed-off-by: Ivan T. Ivanov --- drivers/pci/pcie_brcmstb.c | 23 +++ 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/drivers

[PATCH v3 6/7] configs: rpi_arm64: enable SDHCI BCMSTB driver

2023-12-18 Thread Ivan T. Ivanov
RPi5 have "brcm,bcm2712-sdhci" controller which is handled by "sdhci-bcmstb" driver, so enable it. Signed-off-by: Ivan T. Ivanov --- configs/rpi_arm64_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/rpi_arm64_defconfig b/configs/rpi_arm64_defcon

[PATCH v3 5/7] mmc: bcmstb: Add support for bcm2712 SD controller

2023-12-18 Thread Ivan T. Ivanov
MMAND, TRANSFER_MODE, BLOCK_SIZE and BLOCK_COUNT registers tramples the upper/lower 16 bits of data written. BCM2712 does not seem to need the extreme delay between each write as on previous chips, just the serialisation of writes to these registers in a single 32-bit operation." Signed-off-by: Ivan

[PATCH v3 3/7] rpi5: Use devicetree to retrieve board revision

2023-12-18 Thread Ivan T. Ivanov
linux,serial = <0x6cf44e80 0x3c533ede>; }; Signed-off-by: Ivan T. Ivanov --- board/raspberrypi/rpi/rpi.c | 22 +++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/board/raspberrypi/rpi/rpi.c b/board/raspberrypi/rpi/rpi.c index cd823ad746..2851ebc985 100644 -

[PATCH v3 4/7] bcm2835: brcm, bcm2708-fb device is using r5g6b5 format

2023-12-18 Thread Ivan T. Ivanov
brcm,bcm2708-fb device provided by firmware on RPi5 uses 16 bits per pixel. Update driver to properly handle this. Signed-off-by: Ivan T. Ivanov --- drivers/video/bcm2835.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/video/bcm2835.c b/drivers/video

[PATCH v3 2/7] rpi5: Use devicetree as alternative way to read IO base addresses

2023-12-18 Thread Ivan T. Ivanov
From: Dmitry Malkin MBOX and Watchdog on RPi5/bcm2712 has a different base IO offsets. Find them via devicetree blob passed by bootloader. Signed-off-by: Dmitry Malkin Signed-off-by: Ivan T. Ivanov --- arch/arm/mach-bcm283x/include/mach/base.h | 5 ++- arch/arm/mach-bcm283x/include/mach

[PATCH v3 1/7] rpi5: add initial memory map for bcm2712

2023-12-18 Thread Ivan T. Ivanov
From: Dmitry Malkin includes: * 1GB of RAM (from 4GB or 8GB total) * VPU memory interface * AXI ranges (main peripherals) Signed-off-by: Dmitry Malkin Signed-off-by: Ivan T. Ivanov --- arch/arm/mach-bcm283x/init.c | 38 +++- 1 file changed, 37 insertions(+), 1

[PATCH v3 0/7] rpi5: initial support

2023-12-18 Thread Ivan T. Ivanov
easily. Happy hacking! Regards, Ivan [1] https://lore.kernel.org/all/CAKRNjQ0dsWozGo4n8g58m4cCEk3n=qx1r+l24wbgpo-ip1y...@mail.gmail.com/ Dmitry Malkin (2): rpi5: add initial memory map for bcm2712 rpi5: Use devicetree as alternative way to read IO base addresses Ivan T. Ivanov (5): rpi5

Re: [PATCH 0/4] bootstd: Test and boot_targets improvements

2023-10-23 Thread Ivan T. Ivanov
On 10-23 00:02, Simon Glass wrote: > > This series makes another attempt to support things like "mmc" in the > boot_targets variable. The previous attempt introduced a bug which made > iteration fail. > > New test coverage is provided for some previously untested behaviour, to > prevent

Re: [External] - Slow MMC IO with Raspberry CM3+ Module

2021-11-10 Thread Ivan T. Ivanov
On 11-03 20:57, Vincent Fazio wrote: > Date: Wed, 3 Nov 2021 20:57:13 + > From: Vincent Fazio > To: Mario Lombardo , "u-boot@lists.denx.de" > > Subject: RE: [External] - Slow MMC IO with Raspberry CM3+ Module > Message-ID: > Tags: all uboot Hi Vincent, > > Mario, > > > -Original

Re: [PATCH] rpi: Conditionally add simple-framebuffer node

2021-08-13 Thread Ivan T . Ivanov
Hi, Quoting Ivan T. Ivanov (2021-08-10 17:31:14) > It appears that RPi firmware has already added framebuffer > node under /chosen, at least on RPi 2 versions. So check > for this and don't add duplicate node. > > Signed-off-by: Ivan T. Ivanov > --- > board/raspb

[PATCH] rpi: Conditionally add simple-framebuffer node

2021-08-10 Thread Ivan T. Ivanov
It appears that RPi firmware has already added framebuffer node under /chosen, at least on RPi 2 versions. So check for this and don't add duplicate node. Signed-off-by: Ivan T. Ivanov --- board/raspberrypi/rpi/rpi.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git