Re: [PATCH v2 2/5] clk: rk3588: Add 742.5M parameter for PLL

2023-10-13 Thread Kever Yang
On 2023/10/11 18:29, Elaine Zhang wrote: From: Guochun Huang For a specific frequency. Signed-off-by: Guochun Huang Signed-off-by: Elaine Zhang Reviewed-by: Kever Yang Thanks, - Kever --- drivers/clk/rockchip/clk_rk3588.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers

Re: [PATCH v2 1/5] clk: rockchip: rk3568: support dclk_vop select more parent clks

2023-10-13 Thread Kever Yang
On 2023/10/11 18:29, Elaine Zhang wrote: For dclk_vop to support more frequencies. Signed-off-by: Elaine Zhang Reviewed-by: Kever Yang Thanks, - Kever --- drivers/clk/rockchip/clk_rk3568.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/clk

Re: [PATCH] rockchip: dts: rk3328: Sync rock64 device tree file from Linux

2023-10-13 Thread Kever Yang
On 2023/10/11 02:27, Matwey V. Kornilov wrote: Sync the rk3328-rock64 dts from v6.6-rc5. See Linux kernel commit for details: 03633c4ef1fb ("arm64: dts: rockchip: fix USB regulator on ROCK64") Signed-off-by: Matwey V. Kornilov Reviewed-by: Kever Yang Thanks, - Kever ---

Re: [PATCH v3 7/7] rockchip: doc: add rkmtd.rst

2023-10-13 Thread Kever Yang
On 2023/10/13 04:52, Johan Jonker wrote: Add documention for Rockchip rkmtd virtual block device. Signed-off-by: Johan Jonker Reviewed-by: Kever Yang Thanks, - Kever --- Changed V3: New patch --- doc/board/rockchip/index.rst | 1 + doc/board/rockchip/rkmtd.rst | 105

Re: [PATCH v3 6/7] rockchip: test: dm: add rkmtd test

2023-10-13 Thread Kever Yang
On 2023/10/13 04:52, Johan Jonker wrote: Add Rockchip rkmtd test: Create/attach/detach RKMTD device. Send/read data with Rockchip boot block header. Test that reusing the same label should work. Basic test of 'rkmtd' commands. Signed-off-by: Johan Jonker Reviewed-by: Kever Yang Thanks

Re: [PATCH v3 4/7] rockchip: block: blk-uclass: disable bounce buffer support for rkmtd

2023-10-13 Thread Kever Yang
On 2023/10/13 04:51, Johan Jonker wrote: Disable bounce buffer support for rkmtd. Signed-off-by: Johan Jonker Reviewed-by: Kever Yang Thanks, - Kever --- Changed V3: New patch --- drivers/block/blk-uclass.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [PATCH v3 3/7] rockchip: block: add rkmtd class and drivers

2023-10-13 Thread Kever Yang
On 2023/10/13 04:51, Johan Jonker wrote: Add rkmtd class and drivers to create a virtual block device to transfer Rockchip boot block data to and from NAND with block orientated tools like "ums" and "rockusb". Signed-off-by: Johan Jonker Reviewed-by: Kever Ya

Re: [PATCH v4 1/1] board: rockchip: add FriendlyElec NanoPC-T6 rk3588 board

2023-10-13 Thread Kever Yang
quot;arm64: dts: rockchip: Add NanoPC T6 PCIe Ethernet support") ac76b786cc37 ("arm64: dts: rockchip: Add NanoPC T6 PCIe e-key support") Signed-off-by: John Clark Reviewed-by: Kever Yang Thanks, - Kever --- Changes in v4: - removed SPI support as Jonas Karlman will be provi

Re: [PATCH 4/4] usb: dwc3-generic: Use combined glue and ctrl node for RK3588

2023-10-11 Thread Kever Yang
On 2023/10/11 06:23, Jonas Karlman wrote: Like Rockchip RK3328 and RK3568, the RK3588 also have single node to represent the glue and ctrl for USB 3.0. Use rk_ops as driver data to select correct ctrl node for RK3588 DWC3. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks

Re: [PATCH 2/4] rockchip: rk3588-rock-5b: Enable support for PCIe SATA cards

2023-10-11 Thread Kever Yang
-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- Cc: Christopher Obbard --- configs/rock5b-rk3588_defconfig | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/configs/rock5b-rk3588_defconfig b/configs/rock5b-rk3588_defconfig index 447913faccc4

Re: [PATCH 1/4] rockchip: rk3588: Sync device tree from linux maintainer tree

2023-10-11 Thread Kever Yang
definitions to rk3588s") 3d77a3e51b0f ("arm64: dts: rockchip: Add UART9 M0 pin definitions to rk3588s") Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/rk3588-evb1-v10-u-boot.dtsi | 11 +- arch/arm/dts/rk3588-evb1-v10.dts | 98 +

Re: [PATCH v1 2/7] clk: rockchip: rk3568: add i2s3 clk

2023-10-10 Thread Kever Yang
Hi Elaine,     Please add commit message, and remove the change id.     same for other patches. Thanks, - Kever On 2023/10/10 16:51, Elaine Zhang wrote: Change-Id: If20fe16260d2b584d4216d1dbabffcb25478fb1d Signed-off-by: Elaine Zhang --- .../include/asm/arch-rockchip/cru_rk3568.h|

Re: [PATCH] board: rockchip: add FriendlyElec NanoPC-T6 rk3588 board

2023-10-08 Thread Kever Yang
On 2023/10/8 05:25, John Clark wrote: NanoPC-T6 is a Rockchip RK3588 based SBC by FriendlyElec. There are four variants depending on the DRAM size: 4G/32GB eMMC, 8G/64GB eMMC, 16G/16MB SPI NOR, and 16G/256GB eMMC/16MB SPI NOR So the board is using SPI NOR flash. [...] diff --git

Re: [PATCH v2 RESEND] mmc: dw_mmc: reset controller after data error

2023-10-07 Thread Kever Yang
...@collabora.com: modified a bit the variables initialization] Signed-off-by: Eugen Hristev Reviewed-by: Kever Yang Thanks, - Kever --- drivers/mmc/dw_mmc.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c index

Re: [PATCH v2 RESEND] mmc: dw_mmc: reset controller after data error

2023-10-07 Thread Kever Yang
Hi Tom,     Could you have a try with rockchip vendor U-Boot, maybe still some other fixes are missing in mainline U-Boot mmc driver. Thanks, - Kever On 2023/10/7 22:37, Tom Fitzhenry wrote: I am able to reproduce this on RK3588 QuartzPro64. I thought "[PATCH v2 RESEND] mmc: dw_mmc:

Re: Pull request: u-boot-rockchip-20231007

2023-10-07 Thread Kever Yang
of PCIe bifurcation Do you want me to send it as a new separate patch? Regards, Jonas On 2023-10-07 12:26, Kever Yang wrote: Hi Tom, Please pull the updates for rockchip platform: - Add Board: rk3568 Bananapi R2Pro; - Update pcie bifurcation support; - dwc_eth_qos controller support for rk3568

Pull request: u-boot-rockchip-20231007

2023-10-07 Thread Kever Yang
Hi Tom, Please pull the updates for rockchip platform: - Add Board: rk3568 Bananapi R2Pro; - Update pcie bifurcation support; - dwc_eth_qos controller support for rk3568 and rk3588; - Compressed binary support for U-Boot on rockchip platform; - dts and config updates for different board and soc;

Re: Pull request: u-boot-rockchip-20231007

2023-10-07 Thread Kever Yang
Hi Tom,     Please ignore this PR, two patches are missing, sorry.     I will update a new version and send a new PR. Thanks, - Kever On 2023/10/7 16:47, Kever Yang wrote: Hi Tom, Please pull the updates for rockchip platform: - Add Board: rk3568 Bananapi R2Pro; - Update pcie bifurcation

Pull request: u-boot-rockchip-20231007

2023-10-07 Thread Kever Yang
Hi Tom, Please pull the updates for rockchip platform: - Add Board: rk3568 Bananapi R2Pro; - Update pcie bifurcation support; - dwc_eth_qos controller support for rk3568 and rk3588; - Compressed binary support for U-Boot on rockchip platform; - dts and config updates for different board and soc;

Re: [PATCH 2/2] configs: rockchip: rk3308: enable CONFIG_OF_LIBFDT_OVERLAY

2023-10-06 Thread Kever Yang
On 2023/9/11 18:01, FUKAUMI Naoki wrote: enable CONFIG_OF_LIBFDT_OVERLAY and use it on Radxa ROCK Pi S. Signed-off-by: FUKAUMI Naoki Reviewed-by: Kever Yang Thanks, - Kever --- configs/rock-pi-s-rk3308_defconfig | 1 + include/configs/rk3308_common.h| 1 + 2 files changed, 2

Re: [PATCH 1/2] configs: rockchip: rk3308: use CONFIG_DEFAULT_FDT_FILE

2023-10-06 Thread Kever Yang
Signed-off-by: FUKAUMI Naoki Reviewed-by: Kever Yang Thanks, - Kever --- configs/evb-rk3308_defconfig | 1 + configs/roc-cc-rk3308_defconfig| 1 + configs/rock-pi-s-rk3308_defconfig | 1 + include/configs/rk3308_common.h| 3 ++- 4 files changed, 5 insertions(+), 1 deletion(-)

Re: [PATCH v2 2/2] arm: dts: rockchip: rock-5b: add support for PCIe3 and NVMe

2023-10-06 Thread Kever Yang
A20WPKRYN Type: Hard Disk Capacity: 488386.3 MB = 476.9 GB (1000215216 x 512) Signed-off-by: FUKAUMI Naoki Reviewed-by: Kever Yang Thanks, - Kever this patch depends: - "rockchip: rk3568: Fix use of PCIe bifurcation" [1] [1] https://patchwork.ozlabs.org/project

Re: [PATCH v2 1/2] arm: dts: rockchip: sync DT for RK3588 series with Linux

2023-10-06 Thread Kever Yang
On 2023/9/5 19:47, FUKAUMI Naoki wrote: Sync the device tree for RK3588 series with Linux 6.6-rc1. Signed-off-by: FUKAUMI Naoki Reviewed-by: Kever Yang Thanks, - Kever --- .../dts/rk3588-edgeble-neu6a-io-u-boot.dtsi | 1 - arch/arm/dts/rk3588-edgeble-neu6a.dtsi| 1

Re: [PATCH] board: rockchip: add Pine64 QuartzPro64 RK3588 board

2023-10-06 Thread Kever Yang
Hi Tom,     Please add the info about where is the dts from in you v2, eg. a tag in mainline kernel. Thanks, - Kever On 2023/10/3 23:34, Tom Fitzhenry wrote: Tom Fitzhenry writes: QuartzPro64 is a Rockchip RK3588 based SBC by Pine64. UART and booting over SD card are tested to work.

Re: [PATCH] configs: rockchip: rock-pi-s: use default bootdelay (2s)

2023-10-06 Thread Kever Yang
On 2023/9/11 18:05, FUKAUMI Naoki wrote: align with other boards. Signed-off-by: FUKAUMI Naoki Reviewed-by: Kever Yang Thanks, - Kever --- configs/rock-pi-s-rk3308_defconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/configs/rock-pi-s-rk3308_defconfig b/configs/rock-pi-s

Re: [PATCH v2] configs: rockchip: add DOS_PARTITION to RK3308 boards defconfig

2023-10-06 Thread Kever Yang
roc-rk3308-cc boards: they are the only RK boards missing of DOS_PARTITION. Reported-by: Jayantajit Gogoi Signed-off-by: Massimo Pegorer Reviewed-by: Kever Yang Thanks, - Kever --- configs/evb-rk3308_defconfig | 2 +- configs/roc-cc-rk3308_defconfig| 2 +- configs/rock-pi-s

Re: [PATCH v1 3/3] rockchip: cmd: add rockmtd command

2023-09-27 Thread Kever Yang
Hi Johan, On 2023/8/24 21:29, Johan Jonker wrote: Rockmtd creates a virtual block device to transfer Rockchip boot block data to and from NAND with block orientated tools like "ums" and "rockusb". It uses the Rockchip MTD driver to scan for boot blocks and copies data from the first block in a

Re: [PATCH v1 2/3] dm: prepare rkmtd UCLASS

2023-09-27 Thread Kever Yang
On 2023/8/24 21:29, Johan Jonker wrote: Prepare a rkmtd UCLASS in use for writing Rockchip boot blocks in combination with existing userspace tools and rockusb command. Signed-off-by: Johan Jonker Reviewed-by: Kever Yang Thanks, - Kever --- disk/part.c| 4 drivers

Re: [PATCH v1 1/3] mtd: nand: raw: rockchip_nfc: add NAND_SKIP_BBTSCAN option

2023-09-27 Thread Kever Yang
and to let the original data unchanged. Signed-off-by: Johan Jonker Reviewed-by: Kever Yang Thanks, - Kever --- drivers/mtd/nand/raw/Kconfig| 9 + drivers/mtd/nand/raw/rockchip_nfc.c | 3 +++ 2 files changed, 12 insertions(+) diff --git a/drivers/mtd/nand/raw/Kconfig b

Re: [RESEND PATCH v2] rockchip: include: asm: fix entering download mode rk3066

2023-09-27 Thread Kever Yang
Hi Johan, On 2023/9/19 23:28, Johan Jonker wrote: Keep track of the re-entries with help of the lr register. This binary can be re-used and called from various BROM functions. Only when it's called from the part that handles SPI, NAND or EMMC hardware it needs to early return to BROM ones. In

Re: [PATCH 2/2] configs: rockchip: add DOS_PARTITION to RK3308 boards defconfig

2023-09-26 Thread Kever Yang
Hi Massimo,     This patch is fine to me, but you can merge these two patch into one, because they are all rk3308 boards.     And if you have more than one patch, it'd better to use --in-reply-to for follow up patches so that the mail system know this is a patch set and grab them

Re: [PATCH 7/7] configs: rockchip: Enable ethernet driver on RK3588 boards

2023-09-26 Thread Kever Yang
On 2023/8/7 08:08, Jonas Karlman wrote: Enable DWC_ETH_QOS_ROCKCHIP and related PHY driver on RK3588 boards that have an enabled gmac node and drop ETH_DESIGNWARE and GMAC_ROCKCHIP for remaining RK3588 boards. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever

Re: [PATCH 6/7] configs: rockchip: Enable ethernet driver on RK356x boards

2023-09-26 Thread Kever Yang
On 2023/8/7 08:08, Jonas Karlman wrote: Enable DWC_ETH_QOS_ROCKCHIP and related PHY driver on RK356x boards that have an enabled gmac node. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- configs/evb-rk3568_defconfig | 5 +++-- configs/nanopi-r5s

Re: [PATCH 5/7] net: dwc_eth_qos_rockchip: Add support for RK3588

2023-09-26 Thread Kever Yang
: rk3588: Allow multiple gmac controller") Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- Cc: David Wu Cc: Sebastian Reichel Cc: Benjamin Gaignard --- drivers/net/dwc_eth_qos.c | 4 + drivers/net/dwc_eth_qos_rockchip.c | 182 +++

Re: [PATCH 4/7] net: dwc_eth_qos: Add glue driver for GMAC on Rockchip RK3568

2023-09-26 Thread Kever Yang
Reviewed-by: Kever Yang Thanks, - Kever --- Cc: David Wu Cc: Ezequiel Garcia --- drivers/net/Kconfig| 8 + drivers/net/Makefile | 1 + drivers/net/dwc_eth_qos.c | 8 +- drivers/net/dwc_eth_qos.h | 2 + drivers/net/dwc_eth_qos_rockch

Re: [PATCH 3/7] net: dwc_eth_qos: Stop spam of RX packet not available message

2023-09-26 Thread Kever Yang
On 2023/8/7 08:08, Jonas Karlman wrote: Remove spam of RX packet not available debug messages when waiting to receive a packet. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- drivers/net/dwc_eth_qos.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions

Re: [PATCH 2/7] net: dwc_eth_qos: Return error code when start fails

2023-09-26 Thread Kever Yang
On 2023/8/7 08:08, Jonas Karlman wrote: Return error code when phy_connect fails or no link can be established. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- drivers/net/dwc_eth_qos.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net

Re: [PATCH 1/7] net: dwc_eth_qos: Drop unused rx_pkt from eqos_priv

2023-09-26 Thread Kever Yang
On 2023/8/7 08:08, Jonas Karlman wrote: rx_pkt is allocated and not used for anything, remove it. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- drivers/net/dwc_eth_qos.c | 11 --- drivers/net/dwc_eth_qos.h | 1 - 2 files changed, 12 deletions

Re: [PATCH 2/2] rockchip: rk356x-u-boot: Add bootph-all to i2c0_xfer pinctrl node

2023-09-26 Thread Kever Yang
-pre-ram; }; }; Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/rk356x-u-boot.dtsi | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/dts/rk356x-u-boot.dtsi b/arch/arm/dts/rk356x-u-boot.dtsi index d21b18205220..fe7de0dd4bc8

Re: [PATCH 2/2] rockchip: rk3568-nanopi-r5: Enable PCIe on NanoPi R5C and R5S

2023-09-26 Thread Kever Yang
On 2023/8/3 03:49, Jonas Karlman wrote: Enable missing PCIe Kconfig options now that PCIe bifurcation is fixed to make use of the two on-board RTL8125B and the M.2 slot on NanoPi R5C and NanoPi R5S. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts

Re: [PATCH 1/2] rockchip: rk3568-nanopi-r5: Update defconfig for NanoPi R5C and R5S

2023-09-26 Thread Kever Yang
device tree from linux v6.4 and drop u-boot,spl-boot-order and use the default from rk356x-u-boot.dtsi. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- The addition of SPL_FIT_SIGNATURE add an important integrity check that slow down boot time by a second or two. Enabled

Re: [PATCH v2 5/5] rockchip: board: Add minimal generic RK3566/RK3568 board

2023-09-26 Thread Kever Yang
On 2023/8/22 06:30, Jonas Karlman wrote: Add a minimal generic RK3566/RK3568 board that only have eMMC and SDMMC enabled. This defconfig can be used to boot from eMMC or SD-card on most RK3566/RK3568 boards that follow reference board design. Signed-off-by: Jonas Karlman Reviewed-by: Kever

Re: [PATCH v2 4/5] rockchip: Port IO-domain driver for RK3568 from linux

2023-09-26 Thread Kever Yang
as Karlman Reviewed-by: Simon Glass --- Cc: Jianqun Xu Cc: Heiko Stuebner Cc: Doug Anderson Reviewed-by: Kever Yang Thanks, - Kever --- v2: - Add probe after bind comment - Drop parenthesis - Collect r-b tag drivers/misc/Kconfig | 9 ++ drivers/misc/Makefile

Re: [PATCH v2 3/5] regulator: rk8xx: Return correct voltage for switchout converters

2023-09-26 Thread Kever Yang
pmic: rk809: support rk809 pmic") Signed-off-by: shengfei Xu [jo...@kwiboo.se: fix checkpatch error, update commit message] Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v2: - New patch drivers/power/regulator/rk8xx.c | 19 +++ 1 file c

Re: [PATCH v2 2/5] regulator: rk8xx: Return correct voltage for buck converters

2023-09-26 Thread Kever Yang
c") Signed-off-by: Joseph Chen [jo...@kwiboo.se: fix checkpatch error, simplify buck get_value, update commit message] Signed-off-by: Jonas Karlman Reviewed-by: Simon Glass Reviewed-by: Kever Yang Thanks, - Kever --- v2: - Simplify locating correct rk8xx_reg_info - Update max_sel to inc

Re: [PATCH v2 1/5] power: regulator: Only run autoset once for each regulator

2023-09-26 Thread Kever Yang
cba5d556b4 ("regulator: implement basic reference counter") Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- Cc: Svyatoslav Ryhel --- v2: - No change drivers/power/regulator/regulator-uclass.c | 18 ++ include/power/regulator.h | 1

Re: [PATCH v2 7/7] rockchip: rk3568-radxa-e25: Enable pcie3x1 node

2023-09-26 Thread Kever Yang
as this option is not required for a functional M.2 SATA drive slot. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v2: - No change arch/arm/dts/rk3568-radxa-e25-u-boot.dtsi | 11 +-- configs/radxa-e25-rk3568_defconfig| 1 - 2 files changed, 9

Re: [PATCH v2 6/7] phy: rockchip: naneng-combphy: Use signal from comb PHY on RK3588

2023-09-26 Thread Kever Yang
as Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v2: - New patch drivers/phy/rockchip/phy-rockchip-naneng-combphy.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c b/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c index d5

Re: [PATCH v2 5/7] phy: rockchip: snps-pcie3: Add support for RK3588

2023-09-26 Thread Kever Yang
On 2023/8/3 03:04, Jonas Karlman wrote: Add support for the RK3588 variant to the driver. Code imported almost 1:1 from mainline linux driver. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v2: - No change .../phy/rockchip/phy-rockchip-snps-pcie3.c| 85

Re: [PATCH v2 4/7] phy: rockchip: snps-pcie3: Add bifurcation support for RK3568

2023-09-26 Thread Kever Yang
as Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v2: - Add fixes tag .../phy/rockchip/phy-rockchip-snps-pcie3.c| 65 +-- 1 file changed, 59 insertions(+), 6 deletions(-) diff --git a/drivers/phy/rockchip/phy-rockchip-snps-pcie3.c b/drivers/phy/rockchip/phy-roc

Re: [PATCH v2 3/7] phy: rockchip: snps-pcie3: Refactor to use a phy_init ops

2023-09-26 Thread Kever Yang
On 2023/8/3 03:04, Jonas Karlman wrote: Add a phy_init ops in preparation for upcoming support of a RK3588 variant in the driver. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v2: - No change .../phy/rockchip/phy-rockchip-snps-pcie3.c| 40

Re: [PATCH v2 2/7] phy: rockchip: snps-pcie3: Refactor to use clk_bulk API

2023-09-26 Thread Kever Yang
On 2023/8/3 03:04, Jonas Karlman wrote: Change to use clk_bulk API and syscon_regmap_lookup_by_phandle to simplify in preparation for upcoming support of a RK3588 variant. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v2: - No change .../phy/rockchip/phy

Re: [PATCH v2 1/7] pci: pcie_dw_rockchip: Configure number of lanes and link width speed

2023-09-26 Thread Kever Yang
On 2023/8/3 03:04, Jonas Karlman wrote: Set number of lanes and link width speed control register based on the num-lanes property. Code imported almost 1:1 from dw_pcie_setup in mainline linux. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v2: - No change

Re: [PATCH v5] board: rockchip: Add Bananapi R2Pro Board

2023-09-26 Thread Kever Yang
Reviewed-by: Kever Yang Thanks, - Kever --- because iodomain is different to evb and now iodomain driver is sent as patch we need to separate between EVB and R2Pro else board can be bricked. ethernet support depends on these series from jonas: rockchip: Port IO-domain driver for RK3568 from

Re: [PATCH v2 0/7] rockchip: rk3568: Fix use of PCIe bifurcation

2023-09-26 Thread Kever Yang
Hi Jonas,     Basically these patches are feature update and should be merge and send in next MW. I have question about PCIe bifurcation, does this also merged in linux kernel? I do check the status in kernel mailing list but forget to feedback with you, I didn't see the pcie node in

Re: [PATCH] mmc: Add SPL_MMC_PWRSEQ to fix link issue when building SPL

2023-09-26 Thread Kever Yang
: undefined reference to `gpio_request_by_name' aarch64-linux-gnu-ld.bfd: drivers/mmc/mmc-pwrseq.c:29: undefined reference to `dm_gpio_set_value' aarch64-linux-gnu-ld.bfd: drivers/mmc/mmc-pwrseq.c:31: undefined reference to `dm_gpio_set_value' Signed-off-by: Jonas Karlman Reviewed-by: Kever

Re: [PATCH v2 00/10] rockchip: rk3588: add support for DFU in SPL

2023-09-21 Thread Kever Yang
On 2023/9/21 22:47, Eugen Hristev wrote: On 8/1/23 10:28, Eugen Hristev wrote: This series adds support for DFU in SPL for rockchip rk3588 on rock5b board. Namely, when SPL is loaded via rockusb (thus via USB), having the `same-as-spl` boot order item, after having detected that it was

Re: [PATCH v2 2/2] doc: rockchip: Update and improve info on rk3308, TPL and TF-A

2023-09-19 Thread Kever Yang
improvements. Signed-off-by: Massimo Pegorer Reviewed-by: Kever Yang Thanks, - Kever --- doc/README.rockchip | 10 +--- doc/board/rockchip/rockchip.rst | 43 +++-- 2 files changed, 36 insertions(+), 17 deletions(-) diff --git a/doc/README.rockchip b/doc

Re: [PATCH v1] rockchip: include: asm: fix entering download mode rk3066

2023-09-14 Thread Kever Yang
Hi Johan, On 2023/9/13 19:00, Johan Jonker wrote: Hi, Maybe put this Rockchip rk3066 patch on hold, if we can find a better solution. Any insider help is appreciated here. The solution is to handle the BOOT_BROM_DOWNLOAD TAG in the ddr init binary, and the method is the same with return

Re: [PATCH v2 1/2] rockchip: Kconfig: Enable external TPL binary for rk3308

2023-09-11 Thread Kever Yang
TPL_SERIAL. Signed-off-by: Massimo Pegorer Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/mach-rockchip/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig index a279582f4f..3b044269bd 100644

Re: [PATCH 1/2] rockchip: Use an external TPL binary on RK3308

2023-09-03 Thread Kever Yang
Hi Massimo, On 2023/9/3 18:04, Massimo Pegorer wrote: Il giorno sab 2 set 2023 alle ore 18:32 Massimo Pegorer ha scritto: There is no support to initialize DRAM on RK3308 SoC using U-Boot TPL and therefore an external TPL binary must be used to generate a bootable u-boot-rockchip.bin image.

Re: [PATCH 6/6] video: rockchip: dw_mipi_dsi: Use generic_phy_valid() helper

2023-09-01 Thread Kever Yang
eck if phy is valid. Fixes: b7d8d40346f2 ("video: rockchip: dw_mipi_dsi: Fix external phy existence check") Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- drivers/video/rockchip/dw_mipi_dsi_rockchip.c | 6 +++--- 1 file changed, 3 insertions(+), 3 dele

Re: [PATCH] rockchip: rk3566-anbernic-rgxx3: Rename defconfig to include SoC name

2023-08-17 Thread Kever Yang
On 2023/8/18 05:52, Jonas Karlman wrote: Rename defconfig to include SoC name, use similar pattern as other RK356x boards: -.dts -> -_defconfig Suggested-by: Kever Yang Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- board/anbernic/rgxx3_rk3566/MAINTAIN

Re: [PATCH 1/3] doc: rockchip: Add supported RK3566/RK3568 boards

2023-08-17 Thread Kever Yang
Hi Jonas,     Thanks for your patch. On 2023/8/17 14:04, Jonas Karlman wrote: Update Rockchip documentation to include RK3566/RK3568 boards already supported. Also list Pine64 boards under RK3566 and drop defconfig to match other listed boards. Signed-off-by: Jonas Karlman ---

Re: [PATCH v2 2/2] rockchip: rk356x: Enable poweroff command

2023-08-17 Thread Kever Yang
pwron. Signed-off-by: Jonas Karlman Reviewed-by: Simon Glass Reviewed-by: Kever Yang Thanks, - Kever --- v2: - Split patch - Collect r-b tag configs/quartz64-a-rk3566_defconfig | 1 + configs/quartz64-b-rk3566_defconfig | 1 + configs/rock-3a-rk3568_defconfig | 1

Re: [PATCH v2 1/2] power: pmic: rk8xx: Use sysreset implementation of the poweroff command

2023-08-17 Thread Kever Yang
On 2023/8/17 13:45, Jonas Karlman wrote: Select SYSRESET_CMD_POWEROFF to use the sysreset implementation of the poweroff command when PMIC_RK8XX is enabled. Signed-off-by: Jonas Karlman Reviewed-by: Simon Glass Reviewed-by: Kever Yang Thanks, - Kever --- v2: - Split patch - Collect r-b

Pull request: u-boot-rockchip-20230814

2023-08-14 Thread Kever Yang
Hi Tom, Please pull the updates for rockchip platform: - Add board: rk3568 EmbedFire Lubancat 2 - Fixes for rk3568 clock and pinctrl; - Fixes for rk3308 clock and uart; - rk3328 rock64 updates; - Video fix on veyron board; CI:

Re: [PATCH] rockchip: rk356x: Enable poweroff command

2023-08-13 Thread Kever Yang
Hi Jonas,     Please split this patch into two patch, one for update defconfig and one for update pmic Kconfig. Thanks, - Kever On 2023/8/4 03:54, Jonas Karlman wrote: With PMIC_RK8XX, SYSRESET and CMD_POWEROFF options enabled it is possible to power down a board using the poweroff

Re: [PATCH v2] pinctrl: rockchip: Fix drive and input schmitt on RK3568

2023-08-13 Thread Kever Yang
for the second reg to configure drive strength level 6-11. Also write correct values for input schmitt setting. Fixes: 1977d746aa54 ("rockchip: rk3568: add rk3568 pinctrl driver") Signed-off-by: Jonas Karlman Reviewed-by: Simon Glass Reviewed-by: Kever Yang Thanks, - Kever --- Cha

Re: [PATCH 0/7] rockchip: Add GMAC support for RK3568 and RK3588

2023-08-11 Thread Kever Yang
Add David, Hi David,     Please help to review this patch set for dwc_eth_qos for rk3568/rk3588. Thanks, - Kever On 2023/8/7 08:08, Jonas Karlman wrote: This series adds a glue driver, dwc_eth_qos_rockchip, to support GMAC on RK356x and RK3588. rk_gmac_ops used in this series has been

Re: [PATCH v2 1/4] rockchip: Add support to generate GZIP compressed U-boot binary

2023-08-11 Thread Kever Yang
Hi Manoj,     This patch need rebase, and could you please address the comment from Jonas in new version is possible. Thanks, - Kever On 2023/7/25 11:50, Manoj Sai wrote: Add support for generating a GZIP-compressed U-boot binary with the help of binman, if CONFIG_SPL_GZIP is selected.

Re: [PATCH v2 10/10] configs: rockchip: rock5b-rk3588: enable DFU and related configs

2023-08-11 Thread Kever Yang
On 2023/8/1 15:28, Eugen Hristev wrote: Enable DFU and related configs, expand stack and buffers to hold downloaded image. Signed-off-by: Eugen Hristev Reviewed-by: Kever Yang Thanks, - Kever --- Changes in v2: - added # CONFIG_SPL_BINMAN_UBOOT_SYMBOLS is not set because with the configs

Re: [PATCH v2 06/10] ARM: dts: rockchip: rk3588-rock-5b-u-boot: add bootph-all to gadget nodes

2023-08-11 Thread Kever Yang
Hi Eugen, On 2023/8/1 15:28, Eugen Hristev wrote: Add bootph-all to gadget nodes to have the gadget available in SPL. Does this gadget available on both USB2 and USB3? I think only USB2 is enough? Thanks, - Kever Signed-off-by: Eugen Hristev ---

Re: [PATCH v2 07/10] ARM: mach-rockchip: spl-boot-order: add possibility to DFU

2023-08-11 Thread Kever Yang
On 2023/8/1 15:28, Eugen Hristev wrote: Add DFU as a possible SPL boot media if the boot device is a gadget device. Signed-off-by: Eugen Hristev Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/mach-rockchip/spl-boot-order.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [PATCH] pinctrl: rockchip: Fix drive and input schmitt on RK3568

2023-08-11 Thread Kever Yang
Add Steven Liu, Hi Steven,     Please help to review this patch. On 2023/8/4 01:44, Jonas Karlman wrote: rk3568_set_drive configures a second reg for specific pins. Mainline linux does not do this and vendor U-Boot only run similar code when bit 14 and 15 are both 0 in PMU_GRF_SOC_CON0.

Re: [PATCH v2 01/10] rockchip: allow env defines for SPL build

2023-08-11 Thread Kever Yang
| ^~ In file included from env/common.c:32: [...] Environment in SPL is needed e.g. for DFU, as dfu_alt is kept as env variable. Signed-off-by: Eugen Hristev Reviewed-by: Kever Yang Thanks, - Kever --- include/configs/rockchip-common.h | 4 1 file changed, 4 deletions(-) diff --git a/include

Re: [PATCH] rockchip: MAINTAINERS: fix board name for Radxa ROCK 4C+

2023-08-11 Thread Kever Yang
On 2023/8/3 16:04, FUKAUMI Naoki wrote: align with other ROCK series. Fixes: 2b506407c8 ("rockchip: Add MAINTAINERS entry for Radxa Rock 4C+") Signed-off-by: FUKAUMI Naoki Reviewed-by: Kever Yang Thanks, - Kever --- board/rockchip/evb_rk3399/MAINTAINERS | 2 +- 1 file

Re: [PATCH 2/2] rockchip: spl: Drop out of scope debug message related to uart init

2023-08-11 Thread Kever Yang
-by: Massimo Pegorer Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/mach-rockchip/spl.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/arch/arm/mach-rockchip/spl.c b/arch/arm/mach-rockchip/spl.c index a6396b3c42..87280e2ba7 100644 --- a/arch/arm/mach-rockchip/spl.c +++ b/arch/arm

Re: [PATCH 1/2] rockchip: spl: Drop useless call to debug_uart_init

2023-08-11 Thread Kever Yang
chip/spl.c. Signed-off-by: Massimo Pegorer Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/mach-rockchip/spl.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/arm/mach-rockchip/spl.c b/arch/arm/mach-rockchip/spl.c index 30be640425..a6396b3c42 100644 --- a/arch/arm/mach-rockchip/s

Re: [PATCH] [*] fix RK3568 build under CONFIG_DISPLAY_CPUINFO flag

2023-08-11 Thread Kever Yang
HI Anton,     Thanks for your patch.     I will help to format the patch under the requirement of U-Boot[1] this time, but you will need to do it by yourself if you have follow up patches. Thanks, - Kever [1] https://u-boot.readthedocs.io/en/latest/develop/codingstyle.html On 2023/8/7

[PATCH v2] rockchip: cru: Enable cpu info support for rk3568

2023-08-11 Thread Kever Yang
From: Anton Add cru structure definition in head file to support cpu_info driver. Signed-off-by: Anton Signed-off-by: Kever Yang --- Changes in v2: Format the patch header, add commit message and signature. arch/arm/include/asm/arch-rockchip/cru.h| 2 ++ arch/arm/include/asm/arch

Re: [PATCH 1/1] video: avoid build failure on veyron board

2023-08-11 Thread Kever Yang
On 2023/8/4 08:35, Alvaro Fernando García wrote: 533ad9dc avoided an overflow but causes compilation failure on 32bit boards (eg. veyron speedy) this commit uses div_u64 which has a fallback codepath for 32bit platforms Signed-off-by: Alvaro Fernando García Reviewed-by: Kever Yang

Re: [PATCH v2 1/2] arm64: dts: rockchip: Sync DT from linux-next

2023-08-11 Thread Kever Yang
Hi Jagan, On 2023/8/9 20:34, Jagan Teki wrote: Hi Kever, On Wed, 26 Jul 2023 at 13:55, Jagan Teki wrote: On Wed, 26 Jul 2023 at 13:42, Kever Yang wrote: Hi Jagan, On 2023/7/19 16:17, Jagan Teki wrote: Sync the linux-next from below commit, commit <1642bf66e270> ("arm64: dt

Re: [PATCH v1] board: rockchip: Add Bananapi R2Pro Board

2023-08-11 Thread Kever Yang
Hi Frank, On 2023/8/8 01:14, Frank Wunderlich wrote: From: Frank Wunderlich Add rk3568 based Bananapi R2 Pro board. Signed-off-by: Frank Wunderlich --- because iodomain is different to evb and now iodomain driver is sent as patch we need to separate between EVB and R2Pro else board can be

[PATCH] MAINTAINERS: Update rockchip platform maintain files

2023-08-07 Thread Kever Yang
Add px30, rv1126 soc, and rockchip soc based boards. Signed-off-by: Kever Yang --- MAINTAINERS | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 47581cf6fb..1f6f0aa4d1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -473,12 +473,24

Re: [PATCH 5/5] rockchip: rk356x-u-boot: Set max-frequency prop in sdhci node

2023-08-06 Thread Kever Yang
e nodes. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/rk356x-u-boot.dtsi | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm/dts/rk356x-u-boot.dtsi b/arch/arm/dts/rk356x-u-boot.dtsi index d21b18205220..32f687f2924b 100644 --

Re: [PATCH 4/5] clk: rockchip: rk3568: Add dummy support for GMAC speed clocks

2023-08-06 Thread Kever Yang
clk_set_rate of the tx_rx clock and not using clk_set_parent of the speed clock. Add dummy support for SCLK_GMAC1_RGMII_SPEED and similar clocks to clk driver to allow a driver for gmac node to probe. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- drivers/clk/rockchip

Re: [PATCH 2/5] clk: rockchip: rk3568: Fix mask for clk_cpll_div_25m_div

2023-08-06 Thread Kever Yang
clock driver") Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/include/asm/arch-rockchip/cru_rk3568.h | 2 +- drivers/clk/rockchip/clk_rk3568.c | 5 - 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/arch/arm/includ

Re: [PATCH 3/5] clk: rockchip: rk3568: Include UART clocks in SPL

2023-08-06 Thread Kever Yang
this by including support for UART clocks in SPL. Fixes: 4a262feba3a5 ("rockchip: rk3568: add clock driver") Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- drivers/clk/rockchip/clk_rk3568.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

Re: [PATCH v4] rockchip: rk3568: Add EmbedFire Lubancat 2 support

2023-08-06 Thread Kever Yang
interface for WIFI/BT module - M.2 key for 2280 NVME - 40 pin header The dts file is sync from linux mainline. Signed-off-by: Andy Yan Reviewed-by: Kever Yang Thanks, - Kever --- Changes in v4: - Add entry for this board to evb_rk3568/MAINTAINERS - document this board at doc/board/rockchip

Re: [PATCH 1/5] clk: rockchip: rk3568: Fix clk selection in rk3568_pwm_get_clk

2023-08-04 Thread Kever Yang
On 2023/8/4 17:33, Jonas Karlman wrote: From: Damon Ding Fix use of wrong clk selection for CLK_PWM1 on RK3568. Fixes: 4a262feba3a5 ("rockchip: rk3568: add clock driver") Signed-off-by: Damon Ding Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- d

Re: [PATCH] rockchip: rk356x: Enable poweroff command

2023-08-03 Thread Kever Yang
Hi Jonas, On 2023/8/4 03:54, Jonas Karlman wrote: With PMIC_RK8XX, SYSRESET and CMD_POWEROFF options enabled it is possible to power down a board using the poweroff command and turn the board back on using a power button. I'm confuse about the use case, when will people need to do this(other

Re: [PATCH 1/4] config: rock64: start USB to make storage usable

2023-08-03 Thread Kever Yang
Hi Peter, On 2023/8/3 15:44, Peter Robinson wrote: On Tue, Aug 1, 2023 at 4:17 AM Kever Yang wrote: Hi Peter, Could you update the patchset with patches you still want to send? Can you just drop this patch and take the rest from the set? Yes, it's OK if there no other change, I can

Re: [PATCH 3/3] dts: rockchip: rk3308: Avoid warning for serial probe on prereloc

2023-08-03 Thread Kever Yang
: none of these failures is fatal nor causing issues). Add to *-u-boot.dtsi all required nodes with the 'bootph-some-ram' attribute. Signed-off-by: Massimo Pegorer Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/rk3308-rock-pi-s-u-boot.dtsi | 27 +++ 1 file

Re: [PATCH 2/3] clk: rockchip: rk3308: Support reading UART rate and clock registers

2023-08-03 Thread Kever Yang
for UART nodes in *-u-boot.dtsi files for all cases where UART is not inited by U-Boot proper or by SPL o by TPL code but by a preliminary external boot phase (for Rock PI S, UART is inited by external TPL). Signed-off-by: Massimo Pegorer Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts

Re: [PATCH 1/3] clk: rockchip: rk3308: Fix ordering between masking and shifting

2023-08-03 Thread Kever Yang
Pegorer Reviewed-by: Kever Yang Thanks, - Kever --- drivers/clk/rockchip/clk_rk3308.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/clk/rockchip/clk_rk3308.c b/drivers/clk/rockchip/clk_rk3308.c index 64f33587e2..d27673c454 100644 --- a/drivers/clk

Re: [PATCH 1/4] config: rock64: start USB to make storage usable

2023-07-31 Thread Kever Yang
Hi Peter,     Could you update the patchset with patches you still want to send? Thanks, - Kever On 2023/6/14 20:43, Peter Robinson wrote: Start the USB stack so usb storage can be used. Adding the command as usb keyboard isn't enabled as there's not currently display output.

Re: [PATCH] rockchip: rk3399: nanopc-t4: use 1600MHz sdram config

2023-07-31 Thread Kever Yang
Hi Lu jicong,     Does the 1866M worked for your board before?     I think this config should be fine for other people, it has been submit for 4 years. Thanks, - Kever On 2023/7/5 21:58, Lu jicong wrote: Current 1866MHz sdram config is too high for NanoPC-T4. On this frequency, its

Re: Pull request: u-boot-rockchip-20230731

2023-07-31 Thread Kever Yang
Hi Tom, On 2023/8/1 02:15, Tom Rini wrote: On Mon, Jul 31, 2023 at 09:54:14PM +0800, Kever Yang wrote: Hi Tom, Please pull the updates for rockchip platform: - Update dwc3 generic driver and update support for rk3568/rk3328; - Add boards: rk3566: Pine64 Quartz64-A/B, SOQuartz

Pull request: u-boot-rockchip-20230731

2023-07-31 Thread Kever Yang
Hi Tom, Please pull the updates for rockchip platform: - Update dwc3 generic driver and update support for rk3568/rk3328; - Add boards: rk3566: Pine64 Quartz64-A/B, SOQuartz on Model A/Blade/CM4-IO rk3568: Radxa E25 Carrier Board rk3588: Radxa ROCK5A - Fixes and updates

<    1   2   3   4   5   6   7   8   9   10   >