Re: [PATCH 1/7] pci: pcie_dw_rockchip: Add rk3588 compatible

On 2023/4/17 17:19, Eugen Hristev wrote: From: Jon Lin Add compatible for RK3588 SoC. Signed-off-by: Jon Lin Reviewed-by: Kever Yang Thanks, - Kever --- drivers/pci/pcie_dw_rockchip.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pci/pcie_dw_rockchip.c b/drivers/pci

Re: [PATCH v2 4/4] configs: rockchip: radxa-cm3-io: drop CONFIG_USB_DWC3_GENERIC

On 2023/4/20 20:00, FUKAUMI Naoki wrote: it's not used by rk35xx Signed-off-by: FUKAUMI Naoki Reviewed-by: Kever Yang Thanks, - Kever --- v2: - new patch configs/radxa-cm3-io-rk3566_defconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/configs/radxa-cm3-io-rk3566_defconfig b

Re: [PATCH v2 1/4] configs: rockchip: rock-3a: make usb host work

On 2023/4/20 20:00, FUKAUMI Naoki wrote: add support for USB host function on ROCK 3A Signed-off-by: FUKAUMI Naoki Reviewed-by: Kever Yang Thanks, - Kever --- v2: - drop CONFIG_USB_DWC3_GENERIC configs/rock-3a-rk3568_defconfig | 11 +++ 1 file changed, 11 insertions(+) diff

Re: [PATCH v3 08/10] pinctrl: rockchip: Fix IO mux selection on RK3568

k3568 pinctrl driver") Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v3: - Patch picked from [1] [1] https://patchwork.ozlabs.org/project/uboot/patch/20230318233039.799975-1-jo...@kwiboo.se/ drivers/pinctrl/rockchip/pinctrl-rk3568.c | 66 +

Re: [PATCH v8 00/24] Fixes for Rockchip NFC driver part 1

Hi Johan,     I got below error report from CI test, I think it should be relate to this patch set. === FAILURES === 1107 _

Re: [PATCH] board: rockchip: add Anbernic RGXX3 Series Devices

Hi Chris, On 2023/3/17 01:46, Chris Morgan wrote: + + { + clock-frequency = <2400>; + u-boot,dm-spl; Please rebase the patch, this has been migrate to bootph. Thanks, - Kever

Re: [PATCH] board: rockchip: add Anbernic RGXX3 Series Devices

Hi Chris, I got below CI error report for this patch: Warning, treated as error: /builds/u-boot/custodians/u-boot-rockchip/doc/board/anbernic/index.rst:4:Title underline too short. Anbernic = make[1]: *** [doc/Makefile:70: htmldocs] Error 2 make: *** [Makefile:2373: htmldocs] Error 2

Re: [PATCH 2/2] rockchip: rk3328: Add support for Orange Pi R1 Plus LTS

On 2023/4/21 05:08, Tianling Shen wrote: The OrangePi R1 Plus LTS is a minor variant of OrangePi R1 Plus with the on-board NIC chip changed from rtl8211e to yt8531c, and RAM type changed from DDR4 to LPDDR3. There is no difference in U-Boot, and these two board can use the same U-Boot,

Re: [PATCH 1/2] rockchip: rk3328: Add support for Orange Pi R1 Plus

independent MAC addresses. The device tree and description are taken from kernel v6.3-rc1: https://github.com/torvalds/linux/commit/51712e1d0144c6e1e7e84932d58b5c0f59ed Signed-off-by: Tianling Shen Reviewed-by: Kever Yang Thanks, - Kever --- Please note this patch is based on my previous

Re: [PATCH v2 06/17] mmc: rockchip_sdhci: Use set_clock and config_dll sdhci_ops

Hi Tom, I got error report like below log when apply many of this patchset with "git-pw patch apply 1770392", did you met this kind of issue and do you know why? error: sha1 information is lacking or useless (drivers/mmc/rockchip_sdhci.c). error: could not build fake ancestor hint: Use

Re: [PATCH v3 03/10] rockchip: rk35xx: Fix boot with a large fdt blob

recent sync of device tree. Fixes: 073d911ae64a ("rockchip: rk3568-rock-3a: Sync device tree from linux") Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v3: - No change v2: - New patch arch/arm/mach-rockchip/Kconfig | 2 ++ 1 file changed, 2 insertion

Re: [PATCH 3/3] arm: dts: rockchip: radxa-cm3-io, rock-3a: enable regulators for usb

On 2023/4/20 17:56, FUKAUMI Naoki wrote: enable regulators for usb host function Signed-off-by: FUKAUMI Naoki Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi | 4 arch/arm/dts/rk3568-rock-3a-u-boot.dtsi | 8 2 files changed

Re: [PATCH 2/3] configs: rockchip: radxa-cm3-io, rock-3a: enable commands for i2c/pmic/regulator

On 2023/4/20 17:56, FUKAUMI Naoki wrote: enable commands for i2c/pmic/regulator and relevant configs. also drop configs for unused regulators. Signed-off-by: FUKAUMI Naoki Reviewed-by: Kever Yang Thanks, - Kever --- configs/radxa-cm3-io-rk3566_defconfig | 8 ++-- configs/rock-3a

Re: [PATCH 1/3] configs: rockchip: rock-3a: make usb host work

On 2023/4/20 17:56, FUKAUMI Naoki wrote: add support for USB host function on ROCK 3A Signed-off-by: FUKAUMI Naoki Reviewed-by: Kever Yang Thanks, - Kever --- configs/rock-3a-rk3568_defconfig | 12 1 file changed, 12 insertions(+) diff --git a/configs/rock-3a

Re: [PATCH] arm: dts: rockchip: rock-3a: drop u-boot,spl-boot-order

On 2023/4/20 17:42, FUKAUMI Naoki wrote: use common one defined in rk356x-u-boot.dtsi. Signed-off-by: FUKAUMI Naoki Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/rk3568-rock-3a-u-boot.dtsi | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/dts/rk3568-rock-3a-u

Re: [PATCH v2 17/17] mmc: rockchip_sdhci: Limit number of blocks read in a single command

(ret = -1) mmc_load_image_raw_sector: mmc block read error Fix this by using PIO mode in SPL and limit the number of blocks used in a single read command to avoid triggering Data End Bit Error interrupt. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v2

Re: [PATCH v2 15/17] clk: rockchip: rk3588: Add limited TMCLK_EMMC clock support

On 2023/4/19 00:46, Jonas Karlman wrote: The device tree sdhci node reference the TMCLK_EMMC clock, add limited support this clock to rk3588 cru driver. Fixes probe of sdhci driver. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v2: - No change drivers/clk

Re: [PATCH v2 14/17] rockchip: rk3588-rock-5b: Include eMMC node in SPL dtb

On 2023/4/19 00:46, Jonas Karlman wrote: Add sdhci node to SPL and u-boot,spl-boot-order. Also add more supported mmc modes and pinctrl. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v2: - Change u-boot,dm-spl to bootph-pre-ram arch/arm/dts/rk3588-rock-5b-u

Re: [PATCH v2 13/17] mmc: rockchip_sdhci: Add support for RK3588

Jonas Karlman Reviewed-by: Shawn Lin Reviewed-by: Kever Yang Thanks, - Kever --- v2: - Add Signed-off-by tag - Update commit message - Rename quirks to flags - Save HS200/HS400 txclk_tapnum as driver data - Remove use of rockchip,txclk-tapnum prop - Collect r-b tag drivers/mmc/rockchip_sdhc

Re: [PATCH v2 12/17] rockchip: rk3568-rock-3a: Enable support for more eMMC modes

On 2023/4/19 00:46, Jonas Karlman wrote: Add supported mmc modes to rk3568-rock-3a device tree. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v2: - No change arch/arm/dts/rk3568-rock-3a-u-boot.dtsi | 8 1 file changed, 8 insertions(+) diff --git

Re: [PATCH v2 11/17] mmc: rockchip_sdhci: Fix HS400 and HS400ES mode on RK3568

r each of the modes below. 0 = MMC legacy 1 = MMC High Speed (26MHz) 3 = MMC High Speed (52MHz) 4 = MMC DDR52 (52MHz) 10 = HS200 (200MHz) 11 = HS400 (200MHz) 12 = HS400ES (200MHz) Signed-off-by: Yifeng Zhao Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Ke

Re: [PATCH v2 10/17] mmc: rockchip_sdhci: Rearrange and simplify used regs and flags

removes use of the misspelled const for the RK3588 CMDOUT reg, it will be re-added when support for RK3588 is introduced. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v2: - No change drivers/mmc/rockchip_sdhci.c | 40 1 file

Re: [PATCH v2 09/17] mmc: rockchip_sdhci: Remove empty get_phy and set_enhanced_strobe ops

On 2023/4/19 00:46, Jonas Karlman wrote: Remove empty implementations of get_phy and set_enhanced_strobe ops. Change driver set_enhanced_strobe to return 0 in order to allow missing implementation of the ops. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v2

Re: [PATCH v2 08/17] mmc: rockchip_sdhci: Update speed mode controls in set_ios_post

mode. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v2: - No change drivers/mmc/rockchip_sdhci.c | 68 ++-- 1 file changed, 42 insertions(+), 26 deletions(-) diff --git a/drivers/mmc/rockchip_sdhci.c b/drivers/mmc

Re: [PATCH v2 07/17] mmc: rockchip_sdhci: Refactor execute tuning error handling

On 2023/4/19 00:46, Jonas Karlman wrote: Check return value from mmc_send_cmd and clear HOST_CONTROL2 when there is an error. Also skip enable of interrupt signaling and remove a delay, a delay is already happening in sdhci_send_command. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang

Re: [PATCH v2 06/17] mmc: rockchip_sdhci: Use set_clock and config_dll sdhci_ops

Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v2: - No change drivers/mmc/rockchip_sdhci.c | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/drivers/mmc/rockchip_sdhci.c b/drivers/mmc/rockchip_sdhci.c index bc9838ac7c45..fdf48f4066c9 100644

Re: [PATCH v2 05/17] mmc: rockchip_sdhci: Add set_clock and config_dll sdhci_ops

On 2023/4/19 00:46, Jonas Karlman wrote: Add support for the set_clock and config_dll sdhci_ops. Use of these ops will allow configuration of DLL while the output clock is disabled. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v2: - No change drivers/mmc

Re: [PATCH v2 04/17] mmc: rockchip_sdhci: Remove unneeded emmc_phy_init

On 2023/4/19 00:46, Jonas Karlman wrote: Remove the unneeded emmc_phy_init now that the no-inverter flag is handled correctly after commit 2321a991bbb5 ("rockchip: sdhci: rk3568: bypass DLL when clk <= 52 MHz"). Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - K

Re: [PATCH v2 03/17] mmc: rockchip_sdhci: Fix use of device private data

man Reviewed-by: Kever Yang Thanks, - Kever --- v2: - No change drivers/mmc/rockchip_sdhci.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/mmc/rockchip_sdhci.c b/drivers/mmc/rockchip_sdhci.c index e1409dd2c749..ae28840f6081 100644 --- a/drivers/

Re: [PATCH v2 02/17] mmc: sdhci: Set UHS Mode Select field for UHS SDR25 mode

On 2023/4/19 00:46, Jonas Karlman wrote: Set correct UHS Mode Select field value for UHS SDR25 (50MHz) mode. Fixes: d1c0a2200afb ("mmc: sdhci: Add support for HOST_CONTROL2 and setting UHS timings") Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Keve

Re: [PATCH v2 01/17] mmc: sdhci: Fix HISPD bit handling for MMC HS 52MHz mode

On 2023/4/19 00:46, Jonas Karlman wrote: Set High Speed Enable bit for MMC High Speed (52MHz) mode. Fixes: f12341a95295 ("mmc: sdhci: Fix HISPD bit handling") Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v2: - No change drivers/mmc/sdhci.c | 1

Re: [PATCH v3 1/2] ARM: dts: rk3588-rock-5b-u-boot: add bootph-all to pinctrl for sdmmc

On 2023/4/17 18:06, Eugen Hristev wrote: To be able to initialize the pinctrl correctly at SPL level and read u-boot proper from SD-Card, the pinctrl must be initialized. Signed-off-by: Eugen Hristev Reviewed-by: Kever Yang Thanks, - Kever --- Changes in v3: - change to bootph-all props

Re: [PATCH v3 2/2] configs: rockchip: rock5b-rk3588: add pinctrl to SPL

On 2023/4/17 18:06, Eugen Hristev wrote: Add pinctrl driver in SPL. Do not remove pinctrl properties for SPL dtb. Signed-off-by: Eugen Hristev Reviewed-by: Kever Yang Thanks, - Kever --- Changes in v2,v3: - no change configs/rock5b-rk3588_defconfig | 3 ++- 1 file changed, 2

Re: [PATCH v2 1/2] ARM: dts: rk3588-rock-5b-u-boot: add u-boot, dm-spl to pinctrl for sdmmc

On 2023/4/14 17:45, Eugen Hristev wrote: On 4/14/23 11:55, Kever Yang wrote: On 2023/3/18 00:29, Eugen Hristev wrote: To be able to initialize the pinctrl correctly at SPL level and read u-boot proper from SD-Card, the pinctrl must be initialized. Signed-off-by: Eugen Hristev Reviewed

Re: [PATCH 2/2] reset: rockchip: implement rk3588 lookup table

3588.c has been copied as much as possible from Linux. Adapt the clk rk3588 driver as well to bind the reset driver with the lookup table. Signed-off-by: Eugen Hristev Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/include/asm/arch-rockchip/clock.h | 21 + drivers/clk/rockchip/cl

Re: [PATCH 1/2] clk: rockchip: rk3588: add hardcoded assigned clocks values

for Uboot operations, there is no need to do any different kind of initialization. Signed-off-by: Eugen Hristev Reviewed-by: Kever Yang Thanks, - Kever --- drivers/clk/rockchip/clk_rk3588.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/clk/rockchip

Re: [PATCH 2/2] reset: rockchip: implement rk3588 lookup table

Hi Sebastian and Eugen,     Thanks for your information. On 2023/4/14 21:15, Sebastian Reichel wrote: Hi Kever, On Fri, Apr 14, 2023 at 12:03:00PM +0300, Eugen Hristev wrote: On 4/14/23 10:02, Kever Yang wrote: On 2023/4/13 19:36, Eugen Hristev wrote: The current DT bindings for the rk3588

Re: [PATCH] ram: rk3399: add missing high row detection

Add missing high row detection so that U-Boot TPL prints Row=16, same as the Rockchip ddr init bin: "BW=32 Col=10 Bk=8 CS0 Row=16 CS=1 Die BW=16 Size=2048MB" Signed-off-by: Jonathan Liu Reviewed-by: Kever Yang Thanks, - Kever --- drivers/ram/rockchip/sdram_rk3399.c | 2 ++ 1 file

Re: [PATCH v2 3/3] rk3566: radxa-cm3: Enable USB OTG

On 2023/2/26 21:22, Manoj Sai wrote: Enable USB OTG support and update the fastboot buffer address for Radxa Compute Module 3 IO Board. This would help to use fastboot by default. Signed-off-by: Manoj Sai --- Changes for v2 :- - Updated the fastboot buffer address in

Re: [PATCH v2 2/3] rockchip: rk356x: update the dwc3_device register offset

Hi Manoj, This functions has been update, please check the latest version. Thanks, - Kever On 2023/2/26 21:22, Manoj Sai wrote: update the dwc3_device register offset in board_usb_init() for rk3568 platforms. Signed-off-by: Manoj Sai Reviewed-by: Jagan Teki --- Changes for v2:- - None

Re: [PATCH v2 1/3] arm: dts: rockchip: rk3566: Enable USB OTG for Radxa CM3

On 2023/2/26 21:22, Manoj Sai wrote: Enable USB OTG support for Radxa Compute Module 3 IO Board Signed-off-by: Manoj Sai Reviewed-by: Kever Yang Thanks, - Kever --- Changes for v2 :- - None. Note: Above changeset has sent to kernel mailing list, which is currently under review. https

Re: [PATCH 2/2] rockchip: ringneck-px30: enforce ENV_IS_NOWHERE with Kconfig select

and the configuration is always valid. Suggested-by: Tom Rini Cc: Quentin Schulz Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- board/theobroma-systems/ringneck_px30/Kconfig | 1 + board/theobroma-systems/ringneck_px30/ringneck-px30.c | 4 configs/ringneck

Re: [PATCH 1/2] rockchip: puma-rk3399: enforce ENV_IS_NOWHERE with Kconfig select

and the configuration is always valid. Suggested-by: Tom Rini Cc: Quentin Schulz Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- board/theobroma-systems/puma_rk3399/Kconfig | 1 + board/theobroma-systems/puma_rk3399/puma-rk3399.c | 4 configs/puma-rk3399_defconfig

Re: [PATCH] board: rockchip: add Anbernic RGXX3 Series Devices

ing of DSI controller driver and DSI-DPHY driver to send DSI commands to the panel). Signed-off-by: Chris Morgan Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/Makefile | 1 + .../arm/dts/rk3566-anbernic-rgxx3-u-boot.dtsi | 85 ++ arch/arm/dts/rk3566-anbernic

Re: [PATCH v2 2/2] configs: rockchip: rock5b-rk3588: add pinctrl to SPL

On 2023/3/18 00:29, Eugen Hristev wrote: Add pinctrl driver in SPL. Do not remove pinctrl properties for SPL dtb. Signed-off-by: Eugen Hristev Reviewed-by: Kever Yang Thanks, - Kever --- configs/rock5b-rk3588_defconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

Re: [PATCH v2 1/2] ARM: dts: rk3588-rock-5b-u-boot: add u-boot, dm-spl to pinctrl for sdmmc

On 2023/3/18 00:29, Eugen Hristev wrote: To be able to initialize the pinctrl correctly at SPL level and read u-boot proper from SD-Card, the pinctrl must be initialized. Signed-off-by: Eugen Hristev Reviewed-by: Kever Yang Thanks, - Kever --- Changes in v2: - add u-boot,dm-spl to pull

Re: [PATCH 2/2] rockchip: video: Add support for RK3568 DSI Host

as the only missing component from the mainline driver is setting the VOP big or VOP little (which the rk3568 does not have). Driver was tested for use in sending commands to a DSI panel in order to obtain the panel ID. Signed-off-by: Chris Morgan Reviewed-by: Kever Yang Thanks, - Kever

Re: [PATCH 1/2] drivers: phy: add Innosilicon DSI-DPHY driver

-by: Kever Yang Thanks, - Kever --- drivers/phy/rockchip/Kconfig | 8 + drivers/phy/rockchip/Makefile | 1 + .../phy/rockchip/phy-rockchip-inno-dsidphy.c | 680 ++ 3 files changed, 689 insertions(+) create mode 100644 drivers/phy/rockchip/phy

Re: [PATCH v3 3/3] rockchip: otp: fix misc_read() return values

that the driver follows the usual contract for read operations. Reviewed-by: Simon Glass Reviewed-by: Jonas Karlman Signed-off-by: John Keeping Reviewed-by: Kever Yang Thanks, - Kever --- v3: unchanged v2: new patch drivers/misc/rockchip-otp.c | 12 1 file changed, 8 insertions(+), 4

Re: [PATCH v3 2/3] rockchip: efuse: fix misc_read() return values

that the driver follows the usual contract for read operations. Reviewed-by: Simon Glass Reviewed-by: Jonas Karlman Signed-off-by: John Keeping Reviewed-by: Kever Yang Thanks, - Kever --- v3: unchanged v2: - Fix when block_size > 1 by moving the return value to the main rockchip_efuse_read() wrap

Re: [PATCH v3 1/3] rockchip: misc: fix misc_read() return check

, fix the condition here to only error on negative values. Suggested-by: Jonas Karlman Signed-off-by: John Keeping Reviewed-by: Kever Yang Thanks, - Kever --- v3: new patch arch/arm/mach-rockchip/misc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach

Re: [PATCH] clk: rockchip: rk3568: Add dummy I2S1_MCLKOUT_TX clock support

and rk3568-rock-3a. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- drivers/clk/rockchip/clk_rk3568.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/clk/rockchip/clk_rk3568.c b/drivers/clk/rockchip/clk_rk3568.c index 1c6adc56f913..cefc263971a6 100644

Re: [PATCH v2] mmc: dw_mmc: reset controller after data error

...@collabora.com: modified a bit the variables initialization] Signed-off-by: Eugen Hristev Reviewed-by: Kever Yang Thanks, - Kever --- Changes in v2: - actually decrement the reset timeout timer drivers/mmc/dw_mmc.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff

Re: [PATCH 2/2] reset: rockchip: implement rk3588 lookup table

+ Heiko and Elaine, Hi Eugen, On 2023/4/13 19:36, Eugen Hristev wrote: The current DT bindings for the rk3588 clock use a different ID than the one that is supposed to be written to the hardware registers. Thus, we cannot use directly the id provided in the phandle, but rather use a lookup

Re: [PATCH V2 2/2] ARM: dts: rockchip: rk3588s-u-boot: Add rng node

On 2023/4/8 05:32, Chris Morgan wrote: From: Chris Morgan Add a node for the trng found on RK3588 SoCs. Changes in V2: - None Signed-off-by: Chris Morgan Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/rk3588s-u-boot.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff

Re: [PATCH V2 1/2] rockchip: rng: add trngv1 for rk3588

: https://github.com/rockchip-linux/u-boot/commit/09f31aed858c36a8a5ee20789712e65bb4762068 Tested on an Indiedroid Nova with an RK3588s. This code info and test info should be present at cover letter instead of patch commit message, please update it. otherwise Reviewed-by: Kever Yang Thanks

Re: [PATCH 2/2] configs: rk3399: add Radxa ROCK Pi 4 variants

On 2023/4/8 17:11, FUKAUMI Naoki wrote: compared to ROCK Pi 4B, - ROCK Pi 4A: without Wi-Fi/BT - ROCK Pi 4A+: with OP1, without Wi-Fi/BT - ROCK Pi 4B+: with OP1 It will be better to re-use one defconfig all the board in one series, the peripheral difference like  Wi-Fi/BT are identified by

Re: [PATCH 1/2] arm: dts: rk3399: rock-pi-4: sync with Linux 6.3-rc5

On 2023/4/8 17:11, FUKAUMI Naoki wrote: sync *.dts{,i} files for Radxa ROCK Pi 4 series with Linux 6.3-rc5. Signed-off-by: FUKAUMI Naoki Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/Makefile | 2 + arch/arm/dts/rk3399-rock-pi-4.dtsi

Re: [PATCH] arm: dts: rk356x: Makefile: sort

On 2023/4/8 17:33, FUKAUMI Naoki wrote: sort alphanumerically. Signed-off-by: FUKAUMI Naoki Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile index

Re: [PATCH v2] rockchip: rk3328: Add support for FriendlyARM NanoPi R2C

/next/linux-next.git/commit/?id=004589ff9df5b75672a78b6c3c4cba93202b14c9 Signed-off-by: Tianling Shen Reviewed-by: Kever Yang Thanks, - Kever --- Changes in v2: Added missing defconfig. --- arch/arm/dts/Makefile | 1 + arch/arm/dts/rk3328-nanopi-r2c-u-boot.dtsi | 3

Re: [PATCH 2/2] rockchip: handle peripheral as well as otg dr_mode

ired if the mode detection pin is not set up correctly and the device controller needs to be programmed to override this. Signed-off-by: John Keeping Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/mach-rockchip/board.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-ro

Re: [PATCH 1/2] rockchip: use standard dr_mode parsing function

. Signed-off-by: John Keeping Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/mach-rockchip/board.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-rockchip/board.c b/arch/arm/mach-rockchip/board.c index f1f70c81d0..6d33d65780 100644

Re: [PATCH] configs: rk3588: rename defconfig for rock-5b

Hi, On 2023/4/8 17:33, FUKAUMI Naoki wrote: it should be rock-5b-rk3588_defconfig. Why it should be rock-5b? Its seems rock pi has many boards and with different name, I thinks rock5b is a reasonable config name because there is no name rule for rock pi boards till now.

Re: [PATCH 00/17] rockchip: eMMC fixes for RK3568 and support for RK3588

Hi Jonas,     If there is part of the source code in patch come from vendor U-Boot, it will be better to add "signed-off-by" for original author, eg. you can reference the patch from Eugen Hristev [1] Thanks, - Kever [1]

Re: [PATCH 13/17] mmc: rockchip_sdhci: Add support for RK3588

Add Shawn and Yifeng. Please help review this patch. Thanks, - Kever On 2023/4/4 04:48, Jonas Karlman wrote: Add support for RK3588 to the sdhci driver. RK3588 has the inverter flag in TXCLK reg instead of RXCLK and also make use of a new CMDOUT reg. Add and use a quirks field to support such

Re: rk3399 issue: no DMA in Linux with mainline TF-A and U-Boot SPL

Hi Christoph,     The ARM PL330 DMA driver in kernel only relate to: - DTS kernel used, can be check in /proc/device-tree/ - kernel driver which should mach the compatible name. This driver should has nothing to do with U-Boot SPL or TF-A, because we don't have any special setting for PL330

Re: [PATCH 2/2] configs: rockchip: rock5b-rk3588: add pinctrl to SPL

On 2023/3/13 20:53, Eugen Hristev wrote: Add pinctrl driver in SPL. Do not remove pinctrl properties for SPL dtb. Signed-off-by: Eugen Hristev Reviewed-by: Kever Yang Thanks, - Kever --- configs/rock5b-rk3588_defconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

Re: [PATCH 1/2] ARM: dts: rk3588-rock-5b-u-boot: add u-boot, dm-spl to pinctrl for sdmmc

On 2023/3/13 20:53, Eugen Hristev wrote: To be able to initialize the pinctrl correctly at SPL level and read u-boot proper from SD-Card, the pinctrl must be initialized. Signed-off-by: Eugen Hristev Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/rk3588-rock-5b-u-boot.dtsi

Re: [PATCH v4] pinctrl: rockchip: support rk3588 pinctrl

values table] Signed-off-by: Eugen Hristev Reviewed-by: Kever Yang Thanks, - Kever --- Changes in v4: - After checking with what happens in Linux, it appears that the gpio4 D0-D5 also work using VCCIO2, just that the value written by Uboot appears to be wrongly computed. Linux and other drivers like

Re: [PATCH v2 7/7] arm: dts: rockchip: rk3288: partial sync pwm nodes

On 2023/3/16 02:34, Johan Jonker wrote: In order to better compare the Linux rk3288.dtsi version 6.3 -rc2 with the U-Boot version partial sync the pwm nodes. Signed-off-by: Johan Jonker Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/rk3288.dtsi | 18 +- 1

Re: [PATCH v2 6/7] clk: rockchip: clk_rk3288: add PCLK_RKPWM

# chromebook-jerry Reviewed-by: Kever Yang Thanks, - Kever --- drivers/clk/rockchip/clk_rk3288.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/rockchip/clk_rk3288.c b/drivers/clk/rockchip/clk_rk3288.c index 3b29992c..ef744c06 100644 --- a/drivers/clk/rockchip/clk_rk3288.c +++ b

Re: [PATCH v2 5/7] arm: dts: rockchip: rk3288: partial sync vop/lvds/mipi/hdmi nodes

On 2023/3/16 02:34, Johan Jonker wrote: In order to better compare the Linux rk3288.dtsi version 6.3 -rc2 with the U-Boot version partial sync the vop/lvds/mipi/hdmi nodes. Signed-off-by: Johan Jonker Reviewed-by: Simon Glass Tested-by: Simon Glass # chromebook-jerry Reviewed-by: Kever

Re: [PATCH v2 4/7] arm: dts: rockchip: rk3288: partial sync edp node

Jonker Reviewed-by: Simon Glass Tested-by: Simon Glass # chromebook-jerry Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/rk3288-u-boot.dtsi | 5 + arch/arm/dts/rk3288.dtsi| 17 +++-- 2 files changed, 16 insertions(+), 6 deletions(-) diff --git a/arch/arm

Re: [PATCH v2 3/7] video: rockchip: rk_vop: add rk3288-dp compare string

are string to select vop_id. Signed-off-by: Johan Jonker Reviewed-by: Simon Glass Tested-by: Simon Glass # chromebook-jerry Reviewed-by: Kever Yang Thanks, - Kever --- drivers/video/rockchip/rk_vop.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/video/ro

Re: [PATCH v2 2/7] arm: dts: rockchip: rk3288: partial sync grf and pmu nodes

On 2023/3/16 02:33, Johan Jonker wrote: In order to better compare the Linux rk3288.dtsi version 6.3 -rc2 with the U-Boot version partial sync the grf and pmu nodes. Signed-off-by: Johan Jonker Reviewed-by: Simon Glass Tested-by: Simon Glass # chromebook-jerry Reviewed-by: Kever Yang

Re: [PATCH v2 1/7] arm: dts: rockchip: rk3288: move io-domains nodes

On 2023/3/16 02:31, Johan Jonker wrote: In order to better compare the Linux rk3288.dtsi version with the U-Boot version move the io-domains nodes. Signed-off-by: Johan Jonker Reviewed-by: John Keeping Reviewed-by: Simon Glass Tested-by: Simon Glass # chromebook-jerry Reviewed-by: Kever

Re: [PATCH 3/3] rockchip: rk3588: Sync sdmmc node from linux-next

-A is loaded, scru regs is configured, in U-Boot proper a SCMI message is sent to TF-A. Fixes: 95c8656b72dc ("ARM: dts: rockchip: rk3588s-u-boot: Add sdmmc node") Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- .../dts/rk3588-edgeble-neu6a-io-u-boot.d

Re: [PATCH 2/3] rockchip: rk3588: Add support for sdmmc clocks in SPL

to the rk3588_scru driver in SPL. Fixes: 7a474df74023 ("clk: rockchip: Add rk3588 clk support") Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/include/asm/arch-rockchip/clock.h| 1 - .../include/asm/arch-rockchip/cru_rk3588.h| 19 ++- d

Re: [PATCH 1/3] clk: scmi: Add Kconfig option for SPL

:157: undefined reference to `devm_scmi_of_get_channel' make[1]: *** [scripts/Makefile.spl:527: spl/u-boot-spl] Error 1 make: *** [Makefile:2043: spl/u-boot-spl] Error 2 Add Kconfig option so that CLK_SCMI can be disabled in SPL to fix this. Signed-off-by: Jonas Karlman Reviewed-by: Kever

Re: [PATCH v2] gpio: rockchip: Add support for RK3568 and RK3588 banks

to determine when the driver should use new or old register offsets and values. Earlier generation return 0x0 from this offset. Refactor code and add support for the GPIO V2 controller used in RK3568 and RK3588. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- Changes in v2

Re: [PATCH v2 6/6] rockchip: configs: mk808: enable usb support

On 2023/3/19 23:06, Johan Jonker wrote: Enable usb support in the mk808_defconfig. Signed-off-by: Johan Jonker Reviewed-by: Simon Glass Reviewed-by: Kever Yang Thanks, - Kever --- configs/mk808_defconfig | 10 ++ 1 file changed, 10 insertions(+) diff --git a/configs

Re: [PATCH v2 5/6] rockchip: configs: mk808: change CONFIG_TPL_TEXT_BASE

Signed-off-by: Johan Jonker Reviewed-by: Simon Glass Reviewed-by: Kever Yang Thanks, - Kever --- Changed V2: use lower case hex --- configs/mk808_defconfig | 2 +- doc/board/rockchip/rockchip.rst | 7 +++ 2 files changed, 4 insertions(+), 5 deletions(-) diff --git

Re: [PATCH v2 4/6] arm: dts: rockchip: sync rk3066/rk3188 DT files from linux-next v6.2-rc4

file. Signed-off-by: Johan Jonker Reviewed-by: Simon Glass Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/rk3066a-mk808.dts| 27 ++- arch/arm/dts/rk3066a.dtsi | 3 ++- arch/arm/dts/rk3188-radxarock.dts | 24 +--- arch/arm

Re: [PATCH v2 2/6] arm: dts: rockchip: rk3066a-u-boot: add gpio-ranges

-by: Simon Glass Reviewed-by: Kever Yang Thanks, - Kever --- Changed V2: disable gpio6 --- arch/arm/dts/rk3066a-u-boot.dtsi | 25 + 1 file changed, 25 insertions(+) diff --git a/arch/arm/dts/rk3066a-u-boot.dtsi b/arch/arm/dts/rk3066a-u-boot.dtsi index bc6e609d

Re: [PATCH v2 3/6] arm: dts: rockchip: rk3188-u-boot: add gpio-ranges

On 2023/3/19 23:05, Johan Jonker wrote: The gpio node names are made generic, but without gpio bank ID. Add gpio-ranges to rk3188-u-boot.dtsi for now till a better method is found. Signed-off-by: Johan Jonker Reviewed-by: Simon Glass Reviewed-by: Kever Yang Thanks, - Kever --- arch

Re: [PATCH v2 1/6] rockchip: gpio: rk_gpio: use ROCKCHIP_GPIOS_PER_BANK as divider

ed divider. Signed-off-by: Johan Jonker Reviewed-by: Simon Glass Reviewed-by: Kever Yang Thanks, - Kever --- drivers/gpio/rk_gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/rk_gpio.c b/drivers/gpio/rk_gpio.c index f7ad4d68..0a2acf18 100644 --- a/dr

Re: [PATCH 0/3] rockchip: gpio: Add support for RK3568 and RK3588

Hi Jonas, On 2023/3/19 07:56, Jonas Karlman wrote: This series adds support for RK3568 and RK3588 in the rk gpio driver. It also reverts the use of gpio-ranges to set gpio bank id and instead add gpio aliases and instead use the alias sequence as the bank id. There is another patch set from

Re: [PATCH v1 1/6] rockchip: gpio: rk_gpio: use ROCKCHIP_GPIOS_PER_BANK as divider

Hi Johan, On 2023/3/19 19:34, Johan Jonker wrote: On 3/18/23 21:20, Simon Glass wrote: Hi Johan, On Thu, 16 Mar 2023 at 10:46, Johan Jonker wrote: The current divider to calculate the bank ID can change. Use a constant ROCKCHIP_GPIOS_PER_BANK as fixed divider. What is the motivation for

Pull request: u-boot-rockchip-20230319

Hi Tom, Please pull the fixes for rockchip platform: - Fix for rockchip timer driver; - Fix for rk3568 and rk3588 boot device and clock driver; - Fix for rk3568 reset handler; - Fix for rk3568 sdhci DLL at 52MHz; CI: https://source.denx.de/u-boot/custodians/u-boot-rockchip/-/pipelines/15648

Re: [PATCH 12/12] rockchip: Convert rk35xx to use standard boot

Hi Jonas,     I will pick other patches for fix of this series, and leave this one after the patch set[0] from Simon get land. Thanks, - Kever https://patchwork.ozlabs.org/project/uboot/patch/20230302033930.2546548-7-...@chromium.org/ On 2023/3/14 08:38, Jonas Karlman wrote: Imply use of

Re: [PATCH] rockchip: sdhci: rk3568: fix clock setting logic

first initialization sets mmc->mmc_tran speed to non-zero value (26MHz in my case), and on subsequent re-init when mmc layer asks for 400KHz it sets 26MHz instead. Fix it by using MAX(mmc->tran_speed, mmc->clock) Signed-off-by: Vasily Khoruzhick Reviewed-by: Kever Yang Thanks, - Kever

Re: [PATCH] mmc: dw_mmc: reset controller after data error

...@collabora.com: modified a bit the variables initialization] Signed-off-by: Eugen Hristev Reviewed-by: Kever Yang Thanks, - Kever --- drivers/mmc/dw_mmc.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c index

Re: [PATCH 11/12] rockchip: include: configs: Remove unused SDRAM_BANK_SIZE

On 2023/3/14 08:38, Jonas Karlman wrote: Remove unused SDRAM_BANK_SIZE define. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- include/configs/evb_rk3328.h | 2 -- include/configs/evb_rk3399.h | 2 -- include/configs/pinebook-pro-rk3399.h

Re: [PATCH 10/12] rockchip: include: configs: Remove dangling comments

On 2023/3/14 08:38, Jonas Karlman wrote: This removes dangling comments that no longer serve a purpose and has been left after conversion of defines to Kconfig option. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- include/configs/rk3128_common.h | 4

Re: [PATCH 08/12] rockchip: tinker-rk3288: Use common BOOT_TARGET_DEVICES

RGET_DEVICES defined in rockchip-common.h include the same devices as defined in tinker_rk3288.h, remove the board specific one to fix building with USB or NET option disabled. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- include/configs/tinker_rk3288.h | 9 -

Re: [PATCH 09/12] mmc: rockchip_dw_mmc: Fix get_mmc_clk return value

rate and tries to configure a divider based on this bogus clock rate. Use 0 as the return value when setting clock rate fails, the mmc core will configure to use bypass mode instead of using a bogus divider. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- drivers

Re: [PATCH 07/12] rockchip: rk3588: Add boot device detection

On 2023/3/14 08:38, Jonas Karlman wrote: Enable SPL on RK3588 to detect which device it was booted from. Fixes use of same-as-spl in u-boot,spl-boot-order prop. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/mach-rockchip/rk3588/rk3588.c | 7

Re: [PATCH 06/12] rockchip: rk3588-rock-5b: Fix sdmmc boot

, add same-as-spl to boot-order and remove DEBUG_UART_ANNOUNCE option to fix this. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/rk3588-rock-5b-u-boot.dtsi | 3 ++- configs/rock5b-rk3588_defconfig | 1 - 2 files changed, 2 insertions(+), 2

Re: [PATCH 05/12] clk: rockchip: rk3588: Fix clk_aux16m in clock driver

On 2023/3/14 08:38, Jonas Karlman wrote: The rate and error value is not returned for aux16m clocks, fix this. Fixes: 7a474df74023 ("clk: rockchip: Add rk3588 clk support") Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- drivers/clk/rockchip/clk_rk

Re: [PATCH 03/12] rockchip: rk3568-rock-3a: Sync device tree from linux

: b44c54f600ab ("arm64: dts: rockchip: rk3568: Add Radxa ROCK 3 Model A board support") Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/rk3568-rock-3a-u-boot.dtsi | 10 +- arch/arm/dts/rk3568-rock-3a.dts | 261 +++- 2 fil

<    4   5   6   7   8   9   10   11   12   13   >