Re: [U-Boot] [PATCH] tools: imx8mimage: fix HDMI/FIT parsing

2019-08-08 Thread Lukasz Majewski
break; > case CFG_REG_SIZE: > parse_cfg_cmd(*cmd, token, name, lineno); Reviewed-by: Lukasz Majewski Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell

Re: [U-Boot] [PATCH 4/4] clk: imx: add i.MX8MM clk driver

2019-08-08 Thread Lukasz Majewski
; 0xad00)); > + clk_dm(IMX8MM_CLK_I2C2, > +imx8m_clk_composite("i2c2", imx8mm_i2c2_sels, base + > 0xad80)); > + clk_dm(IMX8MM_CLK_I2C3, > +imx8m_clk_composite("i2c3", imx8mm_i2c3_sels, base + > 0xae00)); > + clk_dm(IMX8MM_CLK

Re: [U-Boot] [PATCH 3/4] clk: imx: add i.MX8M composite clk support

2019-08-08 Thread Lukasz Majewski
gt;reg = reg; > + div->shift = PCG_PREDIV_SHIFT; > + div->width = PCG_PREDIV_WIDTH; > + div->flags = CLK_DIVIDER_ROUND_CLOSEST | flags; > + > + gate = kzalloc(sizeof(*gate), GFP_KERNEL); > + if (!gate) > + goto fail; > + > + ga

Re: [U-Boot] [PATCH] clk: correct spelling of bound

2019-08-03 Thread Lukasz Majewski
return true; > diff --git a/include/clk.h b/include/clk.h > index 2ebc905e04..64e4bcd048 100644 > --- a/include/clk.h > +++ b/include/clk.h > @@ -358,11 +358,11 @@ static inline bool clk_valid(struct clk *clk) > int clk_get_by_id(ulong id, struct clk **clkp); >

Re: [U-Boot] [PATCH 3/3] mtd: spi: Drop sf.c

2019-08-02 Thread Lukasz Majewski
t data_len); > - > -/* > - * Send a multi-byte command to the device followed by (optional) > - * data. Used for programming the flash array, etc. > - */ > -int spi_flash_cmd_write(struct spi_slave *spi, const u8 *cmd, size_t > cmd_len, > - const void *data, size_t dat

[U-Boot] [PATCH] Revert "spi: Kconfig: Mark MXS_SPI has DEPRECATED"

2019-08-01 Thread Lukasz Majewski
fig symbol can be now removed. Signed-off-by: Lukasz Majewski --- drivers/spi/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index f459c0a411..8dd3213d48 100644 --- a/drivers/spi/Kconfig +++ b/drivers/spi/Kconfig @@ -419,7 +419,6 @@ conf

[U-Boot] [GIT] Pull request: u-boot-clk (31.07.2019)

2019-07-31 Thread Lukasz Majewski
deletions(-) create mode 100644 drivers/clk/clk-composite.cc create mode 100644 drivers/clk/clk-gate.c Travis-CI: https://travis-ci.org/lmajewski/u-boot-dfu/builds/565844770 Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235

[U-Boot] [PATCH v2 11/11] imx: config: Update KP's TPC70 config to support SWUpdate

2019-07-30 Thread Lukasz Majewski
This patch updates envs responsible for using USB pendrive as a SWUpdate based tool for recovery and update. Signed-off-by: Lukasz Majewski --- include/configs/kp_imx6q_tpc.h | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/include/configs/kp_imx6q_tpc.h b/include

[U-Boot] [PATCH v2 09/11] imx: tpc70: Convert TPC70 (imx6q) board to use DM/DTS in SPL and u-boot

2019-07-30 Thread Lukasz Majewski
-by: Lukasz Majewski --- arch/arm/mach-imx/mx6/Kconfig | 10 ++ board/k+p/kp_imx6q_tpc/kp_imx6q_tpc.c | 165 +- board/k+p/kp_imx6q_tpc/kp_imx6q_tpc_spl.c | 133 +--- configs/kp_imx6q_tpc_defconfig| 34 +- include/configs

[U-Boot] [PATCH v2 10/11] imx: spl: tpc70: Do not remove clock related properties from DTS

2019-07-30 Thread Lukasz Majewski
Those properties will be reused in the SPL to provide proper clock setting. Signed-off-by: Lukasz Majewski --- configs/kp_imx6q_tpc_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configs/kp_imx6q_tpc_defconfig b/configs/kp_imx6q_tpc_defconfig index abf957f158

[U-Boot] [PATCH v2 07/11] imx: tpc70: dts: Add TPC70 board (imx6q based) device tree description

2019-07-30 Thread Lukasz Majewski
This commit defines the TPC70 imx6q board with device tree description. Signed-off-by: Lukasz Majewski --- arch/arm/dts/imx6q-kp.dts | 219 ++ 1 file changed, 219 insertions(+) create mode 100644 arch/arm/dts/imx6q-kp.dts diff --git a/arch/arm/dts

[U-Boot] [PATCH v2 04/11] imx: tpc70: DTS: Explicitly add imx6q-kp.dtb to Makefile for DTB compilation

2019-07-30 Thread Lukasz Majewski
This commit is necessary to fix following error: Device Tree Source is not correctly specified. Please define 'CONFIG_DEFAULT_DEVICE_TREE' or build with 'DEVICE_TREE=' argument dts/Makefile:28: recipe for target 'arch/arm/dts/imx6q-kp.dtb' failed Signed-off-by: Lukasz Majewski --- arch/arm

[U-Boot] [PATCH v2 08/11] imx: dts: Add u-boot specific set of device tree properties for tpc70

2019-07-30 Thread Lukasz Majewski
This commit adds new file - imx6q-kp-u-boot.dtsi with a set of u-boot specific properties for imx6q KP device. Signed-off-by: Lukasz Majewski --- arch/arm/dts/imx6q-kp-u-boot.dtsi | 59 +++ 1 file changed, 59 insertions(+) create mode 100644 arch/arm/dts

[U-Boot] [PATCH v2 03/11] imx: tpc70: Add board_boot_order() to distinguish between eMMC and SD boot

2019-07-30 Thread Lukasz Majewski
or working properly. Signed-off-by: Lukasz Majewski --- board/k+p/kp_imx6q_tpc/kp_imx6q_tpc_spl.c | 20 1 file changed, 20 insertions(+) diff --git a/board/k+p/kp_imx6q_tpc/kp_imx6q_tpc_spl.c b/board/k+p/kp_imx6q_tpc/kp_imx6q_tpc_spl.c index e284d5ec57..e48a577f79 100644

[U-Boot] [PATCH v2 06/11] imx: tpc70: led: Enable LED default state

2019-07-30 Thread Lukasz Majewski
This change sets the default state of LEDs on TPC70. Signed-off-by: Lukasz Majewski --- board/k+p/kp_imx6q_tpc/kp_imx6q_tpc.c | 4 1 file changed, 4 insertions(+) diff --git a/board/k+p/kp_imx6q_tpc/kp_imx6q_tpc.c b/board/k+p/kp_imx6q_tpc/kp_imx6q_tpc.c index 1dbd03efd8..97af6bd65b

[U-Boot] [PATCH v2 00/11] dm: Convert TPC70 to use DM and DTS in SPL and u-boot proper

2019-07-30 Thread Lukasz Majewski
: https://travis-ci.org/lmajewski/u-boot-dfu/builds/565198753 Those patches are applied on top of -master: SHA1: 75551c8bfc9545e31ec2ce238cac3857904007b8 Lukasz Majewski (11): imx: tpc70: config: Add script commands to update u-boot and OE's wic imx: tpc70: config: Update TPC70 config

[U-Boot] [PATCH v2 05/11] imx: tpc70: cosmetic: Replace magic numbers when setting ENET clock

2019-07-30 Thread Lukasz Majewski
This is a cosmetic change, just to use proper define instead of magic numbers. Signed-off-by: Lukasz Majewski --- board/k+p/kp_imx6q_tpc/kp_imx6q_tpc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/board/k+p/kp_imx6q_tpc/kp_imx6q_tpc.c b/board/k+p/kp_imx6q_tpc

[U-Boot] [PATCH v2 02/11] imx: tpc70: config: Update TPC70 config to support eMMC's boot0 SPL update

2019-07-30 Thread Lukasz Majewski
The TPC70 can boot from eMMC's boot0. This patch allows it to update this HW partition's SPL. Signed-off-by: Lukasz Majewski --- include/configs/kp_imx6q_tpc.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/configs/kp_imx6q_tpc.h b/include/configs/kp_imx6q_tpc.h index

[U-Boot] [PATCH v2 01/11] imx: tpc70: config: Add script commands to update u-boot and OE's wic

2019-07-30 Thread Lukasz Majewski
Signed-off-by: Lukasz Majewski --- include/configs/kp_imx6q_tpc.h | 21 + 1 file changed, 21 insertions(+) diff --git a/include/configs/kp_imx6q_tpc.h b/include/configs/kp_imx6q_tpc.h index dbae276121..92f2bbb75b 100644 --- a/include/configs/kp_imx6q_tpc.h +++ b/include

Re: [U-Boot] [PATCH 01/16] clk: introduce clk_dev_binded

2019-07-30 Thread Lukasz Majewski
> +++ b/include/clk.h > > > @@ -356,4 +356,13 @@ static inline bool clk_valid(struct clk *clk) > > > * @return zero on success, or -ENOENT on error > > > */ > > > int clk_get_by_id(ulong id, struct clk **clkp); > > > + > > > +/** > > > + *

Re: [U-Boot] [PATCH 01/16] clk: introduce clk_dev_binded

2019-07-29 Thread Lukasz Majewski
t; > @@ -356,4 +356,13 @@ static inline bool clk_valid(struct clk *clk) > > * @return zero on success, or -ENOENT on error > > */ > > int clk_get_by_id(ulong id, struct clk **clkp); > > + > > +/** > > + * clk_dev_binded() - Check whether the clk has a devi

[U-Boot] [PATCH] imx: bk4: Print proper HW revision of VF610's BK4 board

2019-07-27 Thread Lukasz Majewski
This code uses HW difference on the USB_RESET pin (added PULL UP resistor on the L333 rev) to distinguish between two BK4 HW revisions. Signed-off-by: Lukasz Majewski --- board/phytec/pcm052/pcm052.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/board

Re: [U-Boot] [PATCH 1/4] imx: add module fuse support

2019-07-24 Thread Lukasz Majewski
1.1, which describes the > features for the different types and the corresponding part numbers. > And the part numbers are printed on the chips. Thanks for the info. > > Regards, > Frieder > > [1] https://www.nxp.com/docs/en/data-sheet/IMX6ULLCEC.pdf > [2] https://www.nxp.com

Re: [U-Boot] [PATCH v2 1/3] pinctrl: nxp: DM_FLAG_PRE_RELOC by default

2019-07-24 Thread Lukasz Majewski
To achieve this we need to force appropriate pinctrl drivers to get > probed before relocation. > > Fixes: cd69e8ef9b ("colibri-imx6ull: migrate pinctrl and regulators > to dtb/dm") Signed-off-by: Igor Opaniuk > --- > Reviewed-by: Lukasz Majewski BTW: I did the same fo

Re: [U-Boot] [PATCH 1/4] imx: add module fuse support

2019-07-24 Thread Lukasz Majewski
> > + {MODULE_PWM5, "/soc/aips-bus@0200/pwm@020f", > > > 0x440, 27}, > > > + {MODULE_PWM6, "/soc/aips-bus@0200/pwm@020f4000", > > > 0x440, 27}, > > > + {MODULE_PWM7, "/soc/aips-bus@0200/pwm@020f8000", > > &g

Re: [U-Boot] [PATCH v4 2/2] board: Add support for iMX8QXP AI_ML board

2019-07-24 Thread Lukasz Majewski
> + "fdtfile=imx8qxp-ai_ml.dtb\0" \ > + "fdt_high=0xffff\0" \ > + "image=Image\0" \ > + "initrd_addr=0x8380\0" \ > + "initrd_high=0x\0" \ > + "netargs=setenv boo

Re: [U-Boot] [PATCH v4 1/2] arm: dts: Add devicetree support for iMXQXP AI_ML board

2019-07-24 Thread Lukasz Majewski
8qm-mek.dtb \ > + fsl-imx8qxp-ai_ml.dtb \ > fsl-imx8qxp-colibri.dtb \ > fsl-imx8qxp-mek.dtb > Reviewed-by: Lukasz Majewski Just out of curiosity - why ARM8 devices from iMX have dtb naming convention starting from 'fsl-' ? With other boards we strive to have 'imx6q

Re: [U-Boot] [PATCH v4 0/2] Add board support for iMX8QXP AI_ML board

2019-07-24 Thread Lukasz Majewski
nfochips/imx8qxp_ai_ml/imximage.cfg > create mode 100644 board/einfochips/imx8qxp_ai_ml/spl.c > create mode 100644 configs/imx8qxp_ai_ml_defconfig > create mode 100644 include/configs/imx8qxp_ai_ml.h > Best regards, Lukasz Majewski -- DENX Software Engineering GmbH,

Re: [U-Boot] [PATCH 1/4] imx: add module fuse support

2019-07-24 Thread Lukasz Majewski
continue; /* Not found, skip it */ > +add_status: > + rc = fdt_setprop(blob, nodeoff, "status", > status, > + strlen(status) + 1); > + if (rc) { > + if (rc == -FDT

Re: [U-Boot] [PATCH v2 00/18] autoboot: Tidy up autoboot code

2019-07-23 Thread Lukasz Majewski
Hi Simon, > This series cleans up autoboot.c a bit to: > > - Convert options to Kconfig > - Use C code instead of C preprocessor where possible > - Add a few comments > Thanks Simon for this clean up series. Reviewed-by: Lukasz Majewski > Changes in v2: > - Rebase to

Re: [U-Boot] [PATCH 00/52] Support i.MX8MM/N

2019-07-22 Thread Lukasz Majewski
On Thu, 18 Jul 2019 09:12:02 +0200 Lukasz Majewski wrote: > Hi Peng, > > > Hi Lukasz, Stefano, > > > > > > > > > > > > > > Subject: Re: [U-Boot] [PATCH 00/52] Support i.MX8MM/N > > [] > > > >

Re: [U-Boot] [PATCH v2 3/3] usb: gadget: f_sdp: Allow SPL to load and boot FIT via SDP

2019-07-22 Thread Lukasz Majewski
Hi Fabio, Stefano, > Hi Lukasz and Stefano, > > On Tue, Jun 11, 2019 at 10:53 AM Lukasz Majewski > wrote: > > > > Hi Fabio, Stefano, > > > > > Hi Stefano, > > > > > > On Tue, Jun 11, 2019 at 10:11 AM Stefano Babic > > >

[U-Boot] [GIT] Pull request: u-boot-dfu (22.07.2019)

2019-07-22 Thread Lukasz Majewski
i/boot.h | 4 +++- 5 files changed, 24 insertions(+), 20 deletions(-) Travis-CI: https://travis-ci.org/lmajewski/u-boot-dfu Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, German

Re: [U-Boot] [RFC PATCH 00/14] dfu: update dfu stack and use them for stm32mp1

2019-07-22 Thread Lukasz Majewski
u/dfu_virt.c | 49 ++ > include/configs/stm32mp1.h | 38 - > include/dfu.h | 51 ++ 13 files changed, > 939 insertions(+), 29 deletions(-) create mode 100644 > drivers/dfu/dfu_mtd.c create mode 100644 drivers/dfu/dfu_virt.c >

Re: [U-Boot] [RFC PATCH 09/14] dfu: add callback for flush and initiated operation

2019-07-22 Thread Lukasz Majewski
ool dfu_usb_get_reset(void); > int dfu_read(struct dfu_entity *de, void *buf, int size, int > blk_seq_num); int dfu_write(struct dfu_entity *de, void *buf, int > size, int blk_seq_num); int dfu_flush(struct dfu_entity *de, void > *buf, int size, int blk_seq_num); +void dfu_flush

Re: [U-Boot] [RFC PATCH 08/14] dfu: add DFU virtual backend

2019-07-22 Thread Lukasz Majewski
> +#ifdef CONFIG_DFU_VIRT > +int dfu_fill_entity_virt(struct dfu_entity *dfu, char *devstr, char > *s); +int dfu_write_medium_virt(struct dfu_entity *dfu, u64 offset, > + void *buf, long *len); > +int dfu_get_medium_size_virt(struct dfu_entity *dfu, u64

Re: [U-Boot] [RFC PATCH 07/14] dfu: add partition support for MTD backend

2019-07-22 Thread Lukasz Majewski
aligned with a block (0x%x)\n", > +mtd->erasesize); > + return -EINVAL; > + } > + > dfu->get_medium_size = dfu_get_medium_size_mtd; > dfu->read_medium = dfu_read_medium_mtd; > dfu->write_medium = dfu_wr

Re: [U-Boot] [RFC PATCH 06/14] dfu: add backend for MTD device

2019-07-22 Thread Lukasz Majewski
; + dfu->inited = 0; > + > + return 0; > +} > diff --git a/include/dfu.h b/include/dfu.h > index 7d60ffc..924952f 100644 > --- a/include/dfu.h > +++ b/include/dfu.h > @@ -22,6 +22,7 @@ enum dfu_device_type { > DFU_DEV_NAND, > DFU_DEV_RAM, >

Re: [U-Boot] [RFC PATCH 05/14] dfu: allow read with 0 data for EOF indication

2019-07-22 Thread Lukasz Majewski
break; > dfu->offset += dfu->b_left; > dfu->r_left -= dfu->b_left; > Reviewed-by: Lukasz Majewski Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kir

Re: [U-Boot] [RFC PATCH 04/14] dfu: allow to manage DFU on several devices

2019-07-22 Thread Lukasz Majewski
> + if (!interface && !devstr) > + ret = dfu_config_interfaces(env_bkp); > + else > + ret = dfu_config_entities(env_bkp, interface, > devstr); + > if (ret) { > pr_err("DFU entities configuration failed!\n"); &g

Re: [U-Boot] [RFC PATCH 03/14] dfu: prepare the support of multiple interface

2019-07-22 Thread Lukasz Majewski
alt_num_cnt++; > } > > return 0; > diff --git a/include/dfu.h b/include/dfu.h > index bf51ab7..7d60ffc 100644 > --- a/include/dfu.h > +++ b/include/dfu.h > @@ -143,6 +143,8 @@ struct dfu_entity { > #ifdef CONFIG_SET_DFU_ALT_INFO > void set_dfu_alt_info(char *in

Re: [U-Boot] [RFC PATCH 02/14] dfu: sf: add partition support for nor backend

2019-07-22 Thread Lukasz Majewski
} > + dfu->data.sf.start = pi->offset; > + dfu->data.sf.size = pi->size; > + if (!strcmp(st, "partubi")) > + dfu->data.sf.ubi = 1; > } else { > printf("%s: Memory layout (%

Re: [U-Boot] [RFC PATCH 01/14] dfu: cosmetic: cleanup sf to avoid checkpatch error

2019-07-22 Thread Lukasz Majewski
long *len) > + long *len) > { > return spi_flash_read(dfu->data.sf.dev, dfu->data.sf.start + > offset, *len, buf); > @@ -32,7 +32,7 @@ static u64 find_sector(struct dfu_entity *dfu, u64 > start, u64 offset) } > > static int dfu_write_me

Re: [U-Boot] [PATCH 1/4] imx: spl: Change USB boot device type

2019-07-18 Thread Lukasz Majewski
nto the source code and this fix is indeed for IMX7/8. That was not apparent from either the code nor commit message. Please prepare more detailed commit messages, so we would know much more from the patch without the need to see the relevant source code. > > Regards, > Peng. >

Re: [U-Boot] [PATCH 1/4] imx: spl: Change USB boot device type

2019-07-18 Thread Lukasz Majewski
); My point is why this error was not apparent earlier (or when I was using the uuu with newest u-boot)? I'm just curious why let's say "average" uuu/SDP user did not encountered this problem (as I had also to recover SPL on my i.MX6 board). > > Regards, > Peng. > >

Re: [U-Boot] [PATCH 4/4] SDP: Call usb_gadget_initialize and usb_gadget_release to support UDC

2019-07-18 Thread Lukasz Majewski
*spl_image, ret = spl_sdp_handle(controller_index, spl_image); > debug("SDP ended\n"); > > + usb_gadget_release(controller_index); > + > return ret; > } > SPL_LOAD_IMAGE_METHOD("USB SDP", 0, BOOT_DEVICE_BOARD, > spl_sdp_load_image);

Re: [U-Boot] [PATCH 3/4] SDP: fix wrong usb request size and add high speed endpoint descriptor

2019-07-18 Thread Lukasz Majewski
= sdp_unbind; > @@ -724,6 +750,7 @@ static void sdp_handle_in_ep(struct > spl_image_info *spl_image) /* In SPL, allow jumps to U-Boot images */ > struct spl_image_info spl_image = {}; > spl_parse_image_header(_image, header); > + >

Re: [U-Boot] [PATCH 2/4] SDP: use CONFIG_SDP_LOADADDR as default load address

2019-07-18 Thread Lukasz Majewski
sdp->jmp_address = be32_to_cpu(cmd->addr); > + sdp->jmp_address = cmd->addr ? > be32_to_cpu(cmd->addr) : > + CONFIG_SDP_LOADADDR; > sdp->state = SDP_STATE_TX_SEC_CONF; > sdp->next

Re: [U-Boot] [PATCH 1/4] imx: spl: Change USB boot device type

2019-07-18 Thread Lukasz Majewski
d description of the problem in the commit message). I've been using recently SDP (with uuu on imx6q) and I did not experience any issues. > default: > return BOOT_DEVICE_NONE; > } Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Man

Re: [U-Boot] [PATCH 00/52] Support i.MX8MM/N

2019-07-18 Thread Lukasz Majewski
gt; 168 ++ drivers/ddr/imx/imx8m/ddrphy_utils.c > > > > > > > |4 + > > > > > > > drivers/ddr/imx/imx8m/helper.c | 22 > > > > > > > +- drivers/ddr/imx/imx8m/lpddr4_init.c| > > > > >

Re: [U-Boot] [EXT] Re: [PATCH v4] rtc: Add DM support to ds3231

2019-07-16 Thread Lukasz Majewski
Hi Chuanhua, > Hi, Lukasz Majewski > > > -Original Message- > > From: Lukasz Majewski > > Sent: 2019年6月21日 19:33 > > To: Chuanhua Han > > Cc: Prabhakar Kushwaha ; > > u-boot@lists.denx.de > > Subject: [EXT] Re: [PATCH v4] rtc: Add DM supp

Re: [U-Boot] [PATCH V2 51/51] imx: add i.MX8MN DDR4 board support

2019-07-10 Thread Lukasz Majewski
gt; > > + "netboot=echo Booting from net ...; " \ > > > + "run netargs; " \ > > > + "if test ${ip_dyn} = yes; then " \ > > > + "setenv get_cmd dhcp; " \ > > > + "else "

Re: [U-Boot] [PATCH V2 18/51] imx8m: add clk support for i.MX8MM

2019-07-10 Thread Lukasz Majewski
Hi Peng, > > Subject: Re: [U-Boot] [PATCH V2 18/51] imx8m: add clk support for > > i.MX8MM > > > > Hi Peng, > > > > > Hi Stefano, > > > > > > > Subject: Re: [U-Boot] [PATCH V2 18/51] imx8m: add clk support > > > > for i.MX8MM > > > > > > > > Hi Peng, > > > > > > > > > Introduce clk

Re: [U-Boot] [EXT] Re: [PATCH 3/5] clk: imx8: Update imx8 clock driver

2019-07-10 Thread Lukasz Majewski
On Wed, 10 Jul 2019 08:25:13 + Ye Li wrote: > Hi Lukasz, > > > Hi Ye, > > > >> Hi Lukasz, > >> > >>> Hi Ye, > >>> > Update imx8 clock driver to support LPCG and full clocks tree for > some modules aligned with kernel. > > We classify the clock into serveral

Re: [U-Boot] [PATCH V2 50/51] imx: add dtsi for i.MX8MN

2019-07-10 Thread Lukasz Majewski
Hi Peng, > > Subject: Re: [U-Boot] [PATCH V2 50/51] imx: add dtsi for i.MX8MN > > > > Hi Peng, > > > > > Add dtsi for i.MX8MN > > > > Please add SHA ID for the exact commit from which you ported DTS > > files. > > The patchset has not been merged into Shawn's tree, I took > from Linux

Re: [U-Boot] [PATCH V2 51/51] imx: add i.MX8MN DDR4 board support

2019-07-10 Thread Lukasz Majewski
Hi Peng, > Support pinctrl/clk/sdhc, include ddr4 timing data. > > Log: > U-Boot SPL 2019.07-rc4-00310-geff364e1d0 (Jul 02 2019 - 09:47:06 > +0800) DDRINFO: start DRAM init > DDRINFO:ddrphy calibration done > DDRINFO: ddrmix config done > Normal Boot > Trying to boot from BOOTROM > image offset

Re: [U-Boot] [PATCH V2 50/51] imx: add dtsi for i.MX8MN

2019-07-10 Thread Lukasz Majewski
Hi Peng, > Add dtsi for i.MX8MN Please add SHA ID for the exact commit from which you ported DTS files. > > Signed-off-by: Peng Fan > --- > arch/arm/dts/imx8mn-pinfunc.h| 646 > arch/arm/dts/imx8mn.dtsi > | 712 +++ >

Re: [U-Boot] [PATCH V2 04/51] i2c: mxc: add CONFIG_CLK support

2019-07-10 Thread Lukasz Majewski
ee Documentation/devicetree/bindings/i2c/i2c-imx.txt > @@ -919,7 +932,11 @@ static int mxc_i2c_probe(struct udevice *bus) > ret = i2c_idle_bus(i2c_bus); > if (ret < 0) { > /* Disable clk */ > +#if CONFIG_IS_ENABLED(CLK) > + clk_disable(_bus->per_clk); >

Re: [U-Boot] [PATCH v5 00/18] clk: Port Linux common clock framework [CCF] to U-boot (tag: v5.1.12)

2019-07-10 Thread Lukasz Majewski
Hi Simon, Would you find time to review the v5 of CCF? https://patchwork.ozlabs.org/cover/1121348/ Thanks in advance, Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Re: [U-Boot] [EXT] Re: [PATCH 3/5] clk: imx8: Update imx8 clock driver

2019-07-10 Thread Lukasz Majewski
Hi Ye, > Hi Lukasz, > > > Hi Ye, > > > >> Update imx8 clock driver to support LPCG and full clocks tree for > >> some modules aligned with kernel. > >> > >> We classify the clock into serveral types: slice, fixed, lpcg, gpr > >> and mux. > > > > Is this code in sync with Linux kernel? Does

Re: [U-Boot] [PATCH V2 18/51] imx8m: add clk support for i.MX8MM

2019-07-10 Thread Lukasz Majewski
CLK, SYSTEM_PLL2_50M_CLK, > > > + SYSTEM_PLL3_CLK, AUDIO_PLL1_CLK, VIDEO_PLL_CLK, > > > + AUDIO_PLL2_CLK, SYSTEM_PLL1_133M_CLK} > > > + }, > > > + {UART1_CLK_ROOT, IP_CLOCK_SLICE, 30, > > > + {OSC_24M_CLK, SYSTEM_PLL1_80M_CLK, SYSTEM_PLL2_200M_CLK, > &

Re: [U-Boot] [PATCH] FIX: ARM: IMX: Add compatible 'fsl, imx53-uart' to NXP's serial driver

2019-07-09 Thread Lukasz Majewski
Hi Marek, > On 7/9/19 4:04 PM, Lukasz Majewski wrote: > > This patch fixes not enabled uart2 (and hence serial console) on > > i.MX53 devices. After following commit 1d255904c306 ("ARM: dts: > > imx: imx53: Synchronize iMX53 DT with Linux") from the uart2 > >

[U-Boot] [PATCH v2] serial: mxc: Add compatibles to NXP's serial driver (for imx21 and imx53)

2019-07-09 Thread Lukasz Majewski
mxc.c file. The fix is to add 'fsl,imx53-uart' and 'fsl,imx21-uart' as compatibles for the aforementioned serial driver (those are also defined in the Linux kernel). Signed-off-by: Lukasz Majewski --- Changes in v2: - Add 'fsl,imx21-uart' to the compatible table - Change the subject tags to 'ser

[U-Boot] [PATCH] FIX: ARM: IMX: Add compatible 'fsl, imx53-uart' to NXP's serial driver

2019-07-09 Thread Lukasz Majewski
mxc.c file. The fix is to add 'fsl,imx53-uart' as a compatible for the aforementioned serial driver (it is also defined in the Linux kernel). Signed-off-by: Lukasz Majewski --- drivers/serial/serial_mxc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/serial/serial_mxc.c b/drivers

[U-Boot] [PATCH] config: imx53: Disable support for EFI on HSC|DDC boards

2019-07-09 Thread Lukasz Majewski
This patch disables support for running EFI applications on HSC|DDC boards. As a result - considerable size reduction (~14%) has been observed (for for u-boot-dtb.imx 475KiB to 407KiB). Signed-off-by: Lukasz Majewski --- configs/kp_imx53_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff

Re: [U-Boot] [PATCH V2 18/51] imx8m: add clk support for i.MX8MM

2019-07-08 Thread Lukasz Majewski
Hi Peng, > > Subject: Re: [U-Boot] [PATCH V2 18/51] imx8m: add clk support for > > i.MX8MM > > > > Hi Peng, > > > > > Introduce clk implementation for i.MX8MM, including pll > > > configuration, ccm configuration. Export get_root_clk for CLK > > > UCLASS driver usage. > > > > > >

Re: [U-Boot] [PATCH V2 18/51] imx8m: add clk support for i.MX8MM

2019-07-08 Thread Lukasz Majewski
Hi Peng, > Introduce clk implementation for i.MX8MM, including pll configuration, > ccm configuration. Export get_root_clk for CLK UCLASS driver usage. > > Signed-off-by: Peng Fan > --- > arch/arm/include/asm/arch-imx8m/clock.h| 3 + > arch/arm/include/asm/arch-imx8m/clock_imx8mm.h |

Re: [U-Boot] [PATCH 00/52] Support i.MX8MM/N

2019-07-08 Thread Lukasz Majewski
> > include/power/pmic.h |2 +- > > > > > include/spl.h |3 +- > > > > > tools/imx8m_image.sh | 15 +- > > > > > tools/imx8mimage.c

Re: [U-Boot] [PATCH 00/52] Support i.MX8MM/N

2019-07-08 Thread Lukasz Majewski
asm/arch-imx8m/imx8mn_pins.h create mode 100644 > > > arch/arm/mach-imx/imx8m/clock_imx8mm.c rename > > > arch/arm/mach-imx/imx8m/{clock.c => clock_imx8mq.c} (99%) create > > mode > > > 100644 arch/arm/mach-imx/imx8m/imximage-8mm-lpddr4.cfg create > > mode

Re: [U-Boot] [PATCH 5/5] net: fec_mxc: Update driver to use full clks for iMX8

2019-07-06 Thread Lukasz Majewski
> fecmxc_ids[] = { { .compatible = "fsl,imx53-fec" }, > { .compatible = "fsl,imx7d-fec" }, > { .compatible = "fsl,mvf600-fec" }, > + { .compatible = "fsl,imx8qm-fec" }, Could you check if this patch doesn't break existing i.MX53, i.MX

Re: [U-Boot] [PATCH 3/5] clk: imx8: Update imx8 clock driver

2019-07-06 Thread Lukasz Majewski
Hi Ye, > Update imx8 clock driver to support LPCG and full clocks tree for some > modules aligned with kernel. > > We classify the clock into serveral types: slice, fixed, lpcg, gpr > and mux. Is this code in sync with Linux kernel? Does the imx8 (in Linux kernel) use the Common Clock

Re: [U-Boot] [PATCH 00/52] Support i.MX8MM/N

2019-07-06 Thread Lukasz Majewski
mode 100644 > board/freescale/imx8mn_evk/Makefile create mode 100644 > board/freescale/imx8mn_evk/ddr4_timing.c create mode 100644 > board/freescale/imx8mn_evk/imx8mn_evk.c create mode 100644 > board/freescale/imx8mn_evk/spl.c create mode 100644 > configs/imx8mm_evk_defconfig cre

Re: [U-Boot] Question regarding the Common Clock Framework CCF v5 patches

2019-07-04 Thread Lukasz Majewski
Hi Stefano, > Hi Lukasz, > > On 04/07/19 13:31, Tom Rini wrote: > > On Thu, Jul 04, 2019 at 10:37:42AM +0200, Lukasz Majewski wrote: > > > >> Hi Tom, > >> > >> I'm a bit puzzled about the CCF v5 patches for i.MX6 (the series > >> ca

[U-Boot] Question regarding the Common Clock Framework CCF v5 patches

2019-07-04 Thread Lukasz Majewski
it myself with your permission) to Stefano (CC'ed) as the v4 was also delegated to him. In the v5 I've added myself as a maintainer of CLK subsystem, so maybe that is why it has changed the delegation. After those changes are merged I'm more than happy to look over this subsystem. Best regards, Lukasz

Re: [U-Boot] [PATCH] usb: gadget: f_dfu.c: fix memory leak

2019-07-04 Thread Lukasz Majewski
free(f_dfu->function[--i]); > f_dfu->function[i] = NULL; Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+

Re: [U-Boot] [PATCH v2 2/2] regulator: Allow enabling GPIO regulator

2019-06-28 Thread Lukasz Majewski
> static const struct dm_regulator_ops gpio_regulator_ops = { > .get_value = gpio_regulator_get_value, > .set_value = gpio_regulator_set_value, > + .get_enable = gpio_regulator_get_enable, > + .set_enable = gpio_regulator_set_enable, > }; > >

Re: [U-Boot] [PATCH v2 1/2] regulator: Factor out common enable code

2019-06-28 Thread Lukasz Majewski
us) > + udelay(dev_pdata->startup_delay_us); > + debug("%s: done\n", __func__); > + > + if (!enable && dev_pdata->off_on_delay_us) > + udelay(dev_pdata->off_on_delay_us); > + > + return 0; > +} > diff -

Re: [U-Boot] Das U-Boot 'bootaux' command breaks USB communication from and to main CPU

2019-06-26 Thread Lukasz Majewski
;http://www.quby.com/> | > subscribe to our newsletter<https://mailchi.mp/66cc8a1f175c/subscribe> > > Quby is hiring! Join our ambitious team to outsmart energy - > https://www.quby.com/careers > > > > > ___ &g

Re: [U-Boot] [PATCH V2] usb: ehci-mx6: Fix bus enumeration for DM case

2019-06-26 Thread Lukasz Majewski
gt; struct usb_platdata *plat = dev_get_platdata(dev); > @@ -564,6 +600,7 @@ U_BOOT_DRIVER(usb_mx6) = { > .id = UCLASS_USB, > .of_match = mx6_usb_ids, > .ofdata_to_platdata = ehci_usb_ofdata_to_platdata, > + .bind = ehci_usb_bind, > .probe = ehci_usb_pro

Re: [U-Boot] [PATCH v5 00/18] clk: Port Linux common clock framework [CCF] to U-boot (tag: v5.1.12)

2019-06-25 Thread Lukasz Majewski
Hi Frieder, > Hi Lukasz, > > On 24.06.19 15:50, Lukasz Majewski wrote: > > This patch series brings the files from Linux kernel (SHA1: > > 5752b50477da Linux 5.1.12 to provide clocks support as it is used > > on the Linux kernel with Common Clock Framework [CCF] setup

[U-Boot] [PATCH v5 00/18] clk: Port Linux common clock framework [CCF] to U-boot (tag: v5.1.12)

2019-06-24 Thread Lukasz Majewski
lk - Replace -ENODEV with -ENOENT - Use **clkp instead of **c - Replace dev->driver_data with dev_get_clk_ptr() wrapper on uclas_priv Lukasz Majewski (18): clk: doc: Add documentation entry for Common Clock Framework [CCF] (i.MX) dm: Fix documentation entry as there is no UCLASS_CLOCK uclas

[U-Boot] [PATCH v5 17/18] defconfig: sandbox: Enable SANDBOX_CLK_CCF to reuse generic CCF code

2019-06-24 Thread Lukasz Majewski
Enable by default the Common Clock Framework [CCF] clock code for sandbox. Signed-off-by: Lukasz Majewski --- Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: None configs/sandbox_defconfig | 1 + configs/sandbox_flattree_defconfig | 1 + 2 files changed, 2

[U-Boot] [PATCH v5 13/18] dts: sandbox: Add 'osc' clock for Common Clock Framework [CCF] testing

2019-06-24 Thread Lukasz Majewski
This patch adds the 'osc' fixed clock to facilitate the CCF testing in the sandbox U-Boot. It is a starting point for building CCF hierarchy of clocks. Signed-off-by: Lukasz Majewski --- Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: None arch/sandbox/dts/test.dts

[U-Boot] [PATCH v5 16/18] clk: sandbox: Add sandbox test code for Common Clock Framework [CCF]

2019-06-24 Thread Lukasz Majewski
() and clk_get_parent_rate() are tested in their natural work environment. Usage (sandbox_defconfig and sandbox_flattree_defconfig): ./u-boot --fdt arch/sandbox/dts/test.dtb --command "ut dm clk_ccf" Signed-off-by: Lukasz Majewski --- Changes in v6: None Changes in v5: None Changes in v4: No

[U-Boot] [PATCH v5 11/18] clk: Port Linux common clock framework [CCF] for imx6q to U-boot (tag: v5.1.12)

2019-06-24 Thread Lukasz Majewski
. If needed, the code can be extended to support the "set" part of the clock management. Signed-off-by: Lukasz Majewski --- Changes in v6: None Changes in v5: - s/U-boot/U-Boot/g - Check if the relevant code has changed between Linux tag v5.0-rc3 and v5.1.12 (no changes - the v

[U-Boot] [PATCH v5 14/18] clk: sandbox: Adjust clk-divider to emulate reading its value from HW

2019-06-24 Thread Lukasz Majewski
for this purpose. Signed-off-by: Lukasz Majewski --- Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: None drivers/clk/clk-divider.c| 10 +- include/linux/clk-provider.h | 3 +++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/clk/clk

[U-Boot] [PATCH v5 15/18] clk: sandbox: Adjust clk-mux.c to emulate reading divider value from HW

2019-06-24 Thread Lukasz Majewski
for this purpose. Signed-off-by: Lukasz Majewski --- Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: None drivers/clk/clk-mux.c| 10 +- include/linux/clk-provider.h | 4 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/clk/clk

[U-Boot] [PATCH v5 07/18] clk: Introduce clk-provider.h to store Common Clock Framework's internals

2019-06-24 Thread Lukasz Majewski
This file now stores the dev_get_clk_ptr() wrapper on the dev_get_uclass_priv() function. Signed-off-by: Lukasz Majewski --- Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: None include/linux/clk-provider.h | 16 1 file changed, 16 insertions

[U-Boot] [PATCH v5 08/18] dm: clk: Define clk_get_parent() for clk operations

2019-06-24 Thread Lukasz Majewski
clk of parent the pdev->uclass_priv field is read via dev_get_clk_ptr() wrapper. Signed-off-by: Lukasz Majewski Reviewed-by: Peng Fan --- Changes in v6: None Changes in v5: - s/U-boot/U-Boot/g - Replace dev->driver_data with dev_get_clk_ptr() wrapper on uclass_priv Changes in v4: None C

[U-Boot] [PATCH v5 09/18] dm: clk: Define clk_get_parent_rate() for clk operations

2019-06-24 Thread Lukasz Majewski
this problem - the clk_get_parent_rate() function has been introduced to clk-uclass.c. Signed-off-by: Lukasz Majewski Reviewed-by: Peng Fan --- Changes in v6: None Changes in v5: - Replace ulong with long long (to accommodate large freqs and return errors) Changes in v4: None Changes in v3: - The rate

[U-Boot] [PATCH v5 10/18] dm: clk: Define clk_get_by_id() for clk operations

2019-06-24 Thread Lukasz Majewski
ook for UCLASS_CLK related udevices. Signed-off-by: Lukasz Majewski Reviewed-by: Peng Fan --- Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: - Replace -ENODEV with -ENOENT - Use **clkp instead of **c - Replace dev->driver_data with dev_get_clk_ptr() wrapper on ucla

[U-Boot] [PATCH v5 18/18] clk: Add MAINTAINERS entry for clocks (./drivers/clk/)

2019-06-24 Thread Lukasz Majewski
The clock subsystem needs active maintenance as it steadily grows. I do offer my help for this task. Signed-off-by: Lukasz Majewski --- Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: None MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git

[U-Boot] [PATCH v5 12/18] dm: clk: Extend clk_get_parent_rate() to support CLK_GET_RATE_NOCACHE flag

2019-06-24 Thread Lukasz Majewski
-by: Lukasz Majewski Reviewed-by: Peng Fan --- Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: None drivers/clk/clk-uclass.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/clk-uclass.c b/drivers/clk/clk-uclass.c index 506ba6014c..5acf186b01

[U-Boot] [PATCH v5 06/18] clk: Provide struct clk for fixed rate clock (clk_fixed_rate.c)

2019-06-24 Thread Lukasz Majewski
this change struct clk is accessible from udevice and udevice from struct clk. Signed-off-by: Lukasz Majewski Reviewed-by: Peng Fan --- Changes in v6: - Use dev->uclass_priv pointer to store pointer to clk Changes in v5: None Changes in v4: None Changes in v3: None drivers/clk/clk_fixed_rat

[U-Boot] [PATCH v5 05/18] clk: Extend struct clk to provide clock type agnostic flags

2019-06-24 Thread Lukasz Majewski
This commit extends the struct clk to provide information regarding the flags related to this devices. Those flags are clk device agnostic and indicate generic features (like e.g. CLK_GET_RATE_NOCACHE - the need to always recalculate the rate). Signed-off-by: Lukasz Majewski Reviewed-by: Peng

[U-Boot] [PATCH v5 03/18] clk: Remove clock ID check in .get_rate() of clk_fixed_*

2019-06-24 Thread Lukasz Majewski
This check requires the struct clk passed to .get_rate() to be always cleared out as any clock with valid ID causes -EINVAL return value. The return code of fixed clocks shall always be returned. Signed-off-by: Lukasz Majewski Reviewed-by: Peng Fan --- Changes in v6: None Changes in v5: None

[U-Boot] [PATCH v5 04/18] clk: Extend struct clk to provide information regarding clock rate

2019-06-24 Thread Lukasz Majewski
This commit extends the struct clk to provide information regarding the clock rate. As a result the clock tree traversal is performed at most once, and further reads are using the cached value. Signed-off-by: Lukasz Majewski --- Changes in v6: None Changes in v5: - Use long long to store rate

[U-Boot] [PATCH v5 02/18] dm: Fix documentation entry as there is no UCLASS_CLOCK uclass

2019-06-24 Thread Lukasz Majewski
There is no UCLASS_CLOCK uclass defined. Instead we do use the UCLASS_CLK. Signed-off-by: Lukasz Majewski Reviewed-by: Simon Glass Reviewed-by: Peng Fan --- Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: None include/clk.h | 2 +- 1 file changed, 1 insertion

[U-Boot] [PATCH v5 01/18] clk: doc: Add documentation entry for Common Clock Framework [CCF] (i.MX)

2019-06-24 Thread Lukasz Majewski
This patch describes the design decisions considerations and taken approach for porting in a separate documentation entry. Signed-off-by: Lukasz Majewski --- Changes in v6: None Changes in v5: - s/U-boot/U-Boot/g - Update Linux version to 5.1.12 - Add paragraph regarding sandbox CCF testing

Re: [U-Boot] [PATCH] usb: ehci-mx6: Fix bus enumeration for DM case

2019-06-24 Thread Lukasz Majewski
Hi Marek, > On 6/24/19 1:57 PM, Lukasz Majewski wrote: > > Hi Marek, > > > >> On 6/24/19 12:26 PM, Lukasz Majewski wrote: > >>> On Mon, 24 Jun 2019 12:06:28 +0200 > >>> Marek Vasut wrote: > >>> >

<    2   3   4   5   6   7   8   9   10   11   >