[PATCH 5/5] dma: ti: k3-udma: invalidate prepared buffers before pushing to recv ring

2024-04-26 Thread Matthias Schiffer
-by: Matthias Schiffer --- drivers/dma/ti/k3-udma.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c index 4e6f7f570c5..8f6d396653e 100644 --- a/drivers/dma/ti/k3-udma.c +++ b/drivers/dma/ti/k3-udma.c @@ -2678,6 +2678,9 @@ int

[PATCH 4/5] dma: ti: k3-udma: add missing include

2024-04-26 Thread Matthias Schiffer
net.h is needed for PKTBUFSRX. Without this definition, the driver will always use 4 RX buffers, causing am65-cpsw-nuss initialization to fail when a higher number of buffers is requested. Signed-off-by: Matthias Schiffer --- drivers/dma/ti/k3-udma.c | 1 + 1 file changed, 1 insertion(+) diff

[PATCH 3/5] net: ti: am65-cpsw-nuss: fix error handling for "RX dma add buf failed"

2024-04-26 Thread Matthias Schiffer
The RX DMA channel has been requested at this point already, so it must be freed. Signed-off-by: Matthias Schiffer --- drivers/net/ti/am65-cpsw-nuss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ti/am65-cpsw-nuss.c b/drivers/net/ti/am65-cpsw-nuss.c index

[PATCH 2/5] net: ti: am65-cpsw-nuss: avoid errors due to imbalanced start()/stop()

2024-04-26 Thread Matthias Schiffer
during bootm. Signed-off-by: Matthias Schiffer --- drivers/net/ti/am65-cpsw-nuss.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/ti/am65-cpsw-nuss.c b/drivers/net/ti/am65-cpsw-nuss.c index b151e25d6a4..4a57e945a3a 100644 --- a/drivers/net/ti/am65-cpsw-nuss.c +++ b/drivers

[PATCH 1/5] net: eth-uclass: guard against reentrant eth_init()/eth_halt() calls

2024-04-26 Thread Matthias Schiffer
etconsole -> eth_init() Rather than expecting every single Ethernet driver to handle this case, prevent the reentrant calls in eth_init() and eth_halt(). The issue was noticed on an AM62x board, where a bootm after simultaneous netconsole and TFTP would result in a crash. Signed-off-by: Matthia

Re: [PATCH 3/4] arm: dts: k3-*-binman.dtsi: Clean up and templatize boot binaries

2024-04-04 Thread Matthias Schiffer
On Wed, 2024-04-03 at 17:51 +0200, Michael Walle wrote: > Hi, > > > > > > > And on top of that, it will just be a base board and there will > > > > > > likely be some carrier device trees (overlay? I'm not sure yet). > > > > > > > > > > > > As far as I can tell, you've put the memory

Re: [PATCH] boot: add support for fdt_fixup command in environment

2023-12-15 Thread Matthias Schiffer
pdesk weiter. > Attention external email: Open attachments and links only if you know that > they are from a secure source and are safe. In doubt forward the email to the > IT-Helpdesk to check it. > > > On Mon, 11 Dec 2023 at 04:04, Matthias Schiffer >

[PATCH] boot: add support for fdt_fixup command in environment

2023-12-11 Thread Matthias Schiffer
a command "fdt_fixup" from the environment at the beginning of image_setup_libfdt() (after overlays are applied, and before the other fixups). Signed-off-by: Matthias Schiffer --- boot/Kconfig | 9 + boot/image-fdt.c | 19 +-- 2 files changed, 26 insert

[PATCH] arm: mach-k3: common: fix compile warnings with PHYS_64BIT on 32bit

2023-09-27 Thread Matthias Schiffer
->bd->bi_dram to fdt_fixup_memory_banks() etc., so PHYS_64BIT is needed for fixing up the upper bank). Signed-off-by: Matthias Schiffer --- arch/arm/mach-k3/common.c | 4 ++-- arch/arm/mach-k3/common.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-k3/co

[PATCH 4/5] pinctrl: single: fix compile warnings with PHYS_64BIT on 32bit

2023-09-27 Thread Matthias Schiffer
and single_get_pin_muxing()). Signed-off-by: Matthias Schiffer --- Tested on x86 sandbox and TI AM62x. No new unit test failures in sandbox. drivers/pinctrl/pinctrl-single.c | 33 +--- 1 file changed, 18 insertions(+), 15 deletions(-) diff --git a/drivers/pinctrl/pinctrl-single.c b

[PATCH 5/5] treewide: use dev_read_addr_*_ptr() where appropriate

2023-09-27 Thread Matthias Schiffer
HYS_64BIT=y. In some places, it also fixes error handling where the return value of dev_read_addr() etc. was checked for NULL instead of FDT_ADDR_T_NONE. Signed-off-by: Matthias Schiffer --- This seems to work correctly (tested on x86 sandbox and TI AM62x; I have not tested the Tegra, Sun4i and

[PATCH 3/5] core: introduce dev_read_addr_name[_size]_ptr() functions

2023-09-27 Thread Matthias Schiffer
Same as dev_read_addr_name[_size](), but returns a pointer, cast through map_sysmem(). Signed-off-by: Matthias Schiffer --- drivers/core/fdtaddr.c | 21 + drivers/core/read.c| 21 + include/dm/fdtaddr.h | 31 +++ include

[PATCH 2/5] core: return FDT_ADDR_T_NONE from devfdt_get_addr_[size_]name() on errors

2023-09-27 Thread Matthias Schiffer
the expectation. Signed-off-by: Matthias Schiffer --- drivers/core/fdtaddr.c | 4 ++-- include/dm/fdtaddr.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/core/fdtaddr.c b/drivers/core/fdtaddr.c index 546db675aaf..426bb762754 100644 --- a/drivers/core/fdtaddr.c +++ b

[PATCH 1/5] core: fix doc comments of dev_read_addr*() and related functions

2023-09-27 Thread Matthias Schiffer
- The dev_read_addr_name*() family of functions has no "index" argument, doc comments should refer to "name" - Specify the error return for several devfdt_get_addr*() functions Signed-off-by: Matthias Schiffer --- include/dm/fdtaddr.h | 12 ++-- include/dm/read

[PATCH] mailbox: k3-sec-proxy: fix error handling for missing scfg in FDT

2023-09-26 Thread Matthias Schiffer
The wrong field was checked. Fixes: f9aa41023bd9 ("mailbox: Introduce K3 Secure Proxy Driver") Signed-off-by: Matthias Schiffer --- drivers/mailbox/k3-sec-proxy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mailbox/k3-sec-proxy.c b/drivers/mailbox/k3-s

Re: [PATCH 1/2] Revert "lib: string: Fix strlcpy return value", fix callers

2023-08-02 Thread Matthias Schiffer
On Fri, 2023-07-14 at 13:24 +0200, Matthias Schiffer wrote: > Both the Linux kernel and libbsd agree that strlcpy() should always > return strlen(src) and not include the NUL termination. The incorrect > U-Boot implementation makes it impossible to check the return value for >

[PATCH 1/2] Revert "lib: string: Fix strlcpy return value", fix callers

2023-07-14 Thread Matthias Schiffer
: Fix strlcpy return value") Signed-off-by: Matthias Schiffer --- board/amlogic/vim3/vim3.c| 6 +++--- drivers/fastboot/fb_getvar.c | 2 +- lib/string.c | 14 +++--- test/lib/strlcat.c | 4 ++-- 4 files changed, 13 insertions(+), 13 deletions(-) diff --g

[PATCH 2/2] lib/charset: fix u16_strlcat() return value

2023-07-14 Thread Matthias Schiffer
strlcat returns min(strlen(dest), count)+strlen(src). Make u16_strlcat's behaviour the same for consistency. Fixes: eca08ce94ceb ("lib/charset: add u16_strlcat() function") Signed-off-by: Matthias Schiffer --- lib/charset.c | 8 test/unicode_ut.c | 8 2 files

[PATCH] video: backlight: pwm: avoid integer overflow in duty cycle calculation

2023-06-30 Thread Matthias Schiffer
The intermediate value could overflow for large periods and levels. Signed-off-by: Matthias Schiffer --- drivers/video/pwm_backlight.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/pwm_backlight.c b/drivers/video/pwm_backlight.c index d7c096923b3..46c16a8f447

Re: [PATCH] ARM: mx7: psci: fix suspend/resume e10133 workaround

2022-11-08 Thread Matthias Schiffer
On Mon, 2022-09-26 at 10:31 +0200, Matthias Schiffer wrote: > The e10133 workaround was broken in two places: > > - The code intended to temporarily mask all interrupts in GPC_IMRx_CORE0. > While the old register values were saved, the actual masking was > missing. > - im

[PATCH] ARM: mx7: psci: fix suspend/resume e10133 workaround

2022-09-26 Thread Matthias Schiffer
: 57b620255e ("imx: mx7: add system suspend/resume support") Signed-off-by: Matthias Schiffer --- arch/arm/mach-imx/mx7/psci-mx7.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-imx/mx7/psci-mx7.c b/arch/arm/mach-imx/mx7/psci-mx7.c index f32945ea37..

[PATCH] common: fdt_support: add support for "partitions" subnode to fdt_fixup_mtdparts()

2022-02-03 Thread Matthias Schiffer
practices can be fixed up. Signed-off-by: Matthias Schiffer --- common/fdt_support.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/common/fdt_support.c b/common/fdt_support.c index daa24d4c10..ea18ea3f04 100644 --- a/common/fdt_support.c +++ b/common/fdt_support.c

Re: [PATCH] fastboot: only look up real partition names when no alias exists

2022-01-26 Thread Matthias Schiffer
On Fri, 2021-12-17 at 18:20 -0500, Sean Anderson wrote: > Hi Matthias, > > On 12/16/21 5:26 AM, Matthias Schiffer wrote: > > Having U-Boot look up the passed partition name even though an > > alias > > exists is unexpected, leading to warning messages (when the alias

[PATCH] fastboot: only look up real partition names when no alias exists

2021-12-16 Thread Matthias Schiffer
if no alias of the same name exists, allowing to use aliases to override the configuration for existing partition names. Also change one use of strcpy() to strlcpy(). Signed-off-by: Matthias Schiffer --- drivers/fastboot/fb_mmc.c | 29 - 1 file changed, 12 insertions

Simultaneous support of CONFIG_MX6UL and CONFIG_MX6ULL

2021-11-08 Thread Matthias Schiffer
Hi everyone, for the submission of support for our TQMa6UL/TQMa6ULL SoM family I've been wondering if it would be desirable to allow U-Boot configs that support both i.MX6UL and i.MX6ULL. This would allow us to reduce the number of required defconfig variants for our SoMs significantly. I had a

[PATCH 2/2] board: tq: fix spelling of "TQ-Systems"

2021-11-02 Thread Matthias Schiffer
"TQ-Systems" is written with a dash. Signed-off-by: Matthias Schiffer --- arch/arm/mach-imx/mx6/Kconfig | 2 +- board/tq/tqma6/MAINTAINERS| 2 +- board/tq/tqma6/README | 6 +++--- board/tq/tqma6/tqma6.c| 2 +- board/tq/tqma6/tqma6_bb.h | 2 +- board/tq/tqma6/tq

[PATCH 1/2] board: rename "tqc" vendor to "tq"

2021-11-02 Thread Matthias Schiffer
The subdivision name "TQ Components" hasn't been in use for a long time. Rename the vendor directory to "tq", which also matches our Device Tree vendor prefix. Signed-off-by: Matthias Schiffer --- Take care of the renaming first, in preparation for a larger round of c

Re: [PATCH] fastboot: fix partition name truncation in environment lookup

2021-09-28 Thread Matthias Schiffer
On Fri, 2021-07-30 at 10:04 -0400, Sean Anderson wrote: > On 7/30/21 8:23 AM, Matthias Schiffer wrote: > > strlcat() need to be passed the full buffer length. The incorrect call > > caused truncation of partition names for fastboot_raw_partition_... and > > fastboot_partition

[PATCH] imx: mx7: spl: fix CONFIG_SPL_MAX_SIZE definition

2021-09-28 Thread Matthias Schiffer
The CONFIG_SPL_MAX_SIZE definition did not account for all areas that are used by the boot ROM according to the manual, causing boot failures due to truncated SPL images when actually hitting this limit. Signed-off-by: Matthias Schiffer --- include/configs/imx7_spl.h | 20

Re: [PATCH 1/2] mmc: add helper to query max enhanced part size

2021-09-23 Thread Matthias Schiffer
On Thu, 2021-09-23 at 20:58 +0900, Jaehoon Chung wrote: > Hi, > > On 9/22/21 9:30 PM, Matthias Schiffer wrote: > > From: Markus Niebel > > > > This helper will be used later on in an extension of the mmc > > command. > > > > Signed-off-by: Markus

[PATCH 2/2] cmd/mmc: add subcommand to query max enhanced partition size

2021-09-22 Thread Matthias Schiffer
partitioning scripts, for example the following would convert a whole eMMC to pSLC mode: mmc maxhwpartsectors mmc hwpartition user enh 0 ${maxhwpartsectors} wrrel on complete Signed-off-by: Markus Niebel Signed-off-by: Matthias Schiffer --- The human-readable output of the command could

[PATCH 1/2] mmc: add helper to query max enhanced part size

2021-09-22 Thread Matthias Schiffer
From: Markus Niebel This helper will be used later on in an extension of the mmc command. Signed-off-by: Markus Niebel Signed-off-by: Matthias Schiffer --- drivers/mmc/mmc.c | 38 ++ include/mmc.h | 1 + 2 files changed, 39 insertions(+) diff --git

[PATCH 3/4] usb: ehci-ci: remove redundant PORTSC flag definitions

2021-09-20 Thread Matthias Schiffer
These definitions are unused, all boards that define portsc flags use the equivalent PORT_* definitions instead. Signed-off-by: Markus Niebel Signed-off-by: Matthias Schiffer --- include/usb/ehci-ci.h | 11 --- 1 file changed, 11 deletions(-) diff --git a/include/usb/ehci-ci.h b

[PATCH 4/4] usb: ehci-mx6: use phy_type from device tree

2021-09-20 Thread Matthias Schiffer
-by: Matthias Schiffer --- drivers/usb/host/ehci-mx6.c | 25 +++-- include/usb/ehci-ci.h | 1 + 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/ehci-mx6.c b/drivers/usb/host/ehci-mx6.c index c3e4170513e..1bd6147c76a 100644 --- a/drivers/usb

[PATCH 2/4] include/configs: replace MXC_EHCI_MODE_SERIAL with PORT_PTS_SERIAL

2021-09-20 Thread Matthias Schiffer
The MXC_EHCI_MODE_ definitions are redundant. Replace MXC_EHCI_MODE_SERIAL with the equivalent PORT_PTS_SERIAL. Only the zmx25 platform is affected. Signed-off-by: Markus Niebel Signed-off-by: Matthias Schiffer --- include/configs/zmx25.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH 1/4] usb: add support for ULPI/SERIAL/HSIC PHY modes

2021-09-20 Thread Matthias Schiffer
Import usb_phy_interface enum values and DT match strings from the Linux kernel. Signed-off-by: Markus Niebel Signed-off-by: Matthias Schiffer --- drivers/usb/common/common.c | 3 +++ include/linux/usb/phy.h | 3 +++ 2 files changed, 6 insertions(+) diff --git a/drivers/usb/common

[PATCH] fastboot: fix partition name truncation in environment lookup

2021-07-30 Thread Matthias Schiffer
Signed-off-by: Matthias Schiffer --- drivers/fastboot/fb_mmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/fastboot/fb_mmc.c b/drivers/fastboot/fb_mmc.c index 2f3837e559..33fd6c21af 100644 --- a/drivers/fastboot/fb_mmc.c +++ b/drivers/fastboot/fb_mmc.c @@ -40,7 +40,7 @@

[PATCH] net: eth-uclass: avoid running start() twice without stop()

2020-11-04 Thread Matthias Schiffer
ftp) while netconsole is active. Add an additional "running" flag that reflects the actual state of the driver and use it to ensure that eth_halt() actually stops the device as it is supposed to. Fixes: 68acb51f442f ("net: Only call halt on a driver that has been init'ed") Si

[PATCH] tools/imximage: fix DCD Blocks message output order

2020-07-28 Thread Matthias Schiffer
The correct order is load address, offset, length. The order was accidentally switched a while ago; make it match the HAB Blocks output and what CST expects again. Fixes: e97bdfa5da70 ("tools/imximage: share DCD information via Kconfig") Signed-off-by: Matthias Schiffer --- tools/imxi

Re: [U-Boot] [PATCH] MIPS: fix mips_cache fallback without __builtin_mips_cache

2016-03-06 Thread Matthias Schiffer
On 03/06/2016 08:38 PM, Daniel Schwierzeck wrote: > > > Am 05.03.2016 um 04:15 schrieb Matthias Schiffer: >> The "R" constraint supplies the address of an variable in a register. Use >> "r" instead and adjust asm to supply the content of addr in a r

[U-Boot] [PATCH] MIPS: fix mips_cache fallback without __builtin_mips_cache

2016-03-05 Thread Matthias Schiffer
The "R" constraint supplies the address of an variable in a register. Use "r" instead and adjust asm to supply the content of addr in a register instead. Fixes: 2b8bcc5a ("MIPS: avoid .set ISA for cache operations") Signed-off-by: Matthias Schiffer <mschif...@univ