[PATCH v8] board: mntre: imx8mq: Add MNT Reform 2 board support

2023-02-05 Thread Patrick Wildt
The MNT Reform 2 is a modular DIY laptop. In its initial version it is based on the BoundaryDevices i.MX8MQ SoM. Some parts have been lifted from BoundaryDevices official U-Boot downstream project. Signed-off-by: Patrick Wildt --- Changes since v7: - Re-added lost ramdisk_addr_r. Changes since

[PATCH v7] board: mntre: imx8mq: Add MNT Reform 2 board support

2023-01-31 Thread Patrick Wildt
The MNT Reform 2 is a modular DIY laptop. In its initial version it is based on the BoundaryDevices i.MX8MQ SoM. Some parts have been lifted from BoundaryDevices official U-Boot downstream project. Signed-off-by: Patrick Wildt --- Changes since v6: - Cleaned up some CONFIG_* pollution. Changes

Re: [PATCH v6] board: mntre: imx8mq: Add MNT Reform 2 board support

2023-01-31 Thread Patrick Wildt
Am Tue, Jan 31, 2023 at 06:00:31PM +0100 schrieb Stefano Babic: > On 19.01.23 20:56, Patrick Wildt wrote: > > The MNT Reform 2 is a modular DIY laptop. In its initial version it > > is based on the BoundaryDevices i.MX8MQ SoM. Some parts have been > > lifted from BoundaryDe

Re: [PATCH] imx: power-domain: enable parent power domain

2023-01-29 Thread Patrick Wildt
On Sun, Jan 29, 2023 at 05:00:15AM +0100, Marek Vasut wrote: > On 1/29/23 04:28, Patrick Wildt wrote: > > Am Sun, Jan 29, 2023 at 02:46:36AM +0100 schrieb Marek Vasut: > > > On 1/28/23 23:14, Patrick Wildt wrote: > > > > The PCIe power domains are dependa

Re: [PATCH] imx: power-domain: enable parent power domain

2023-01-28 Thread Patrick Wildt
Am Sun, Jan 29, 2023 at 02:46:36AM +0100 schrieb Marek Vasut: > On 1/28/23 23:14, Patrick Wildt wrote: > > The PCIe power domains are dependant on each other, which is why > > the device tree makes both PCIe controllers reference the PCIe1 > > power domain, which then depen

[PATCH] imx: power-domain: enable parent power domain

2023-01-28 Thread Patrick Wildt
the enable call back to be able to power up PCIe2. Signed-off-by: Patrick Wildt --- drivers/power/domain/imx8m-power-domain.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/power/domain/imx8m-power-domain.c b/drivers/power/domain/imx8m-power-domain.c index 145f6ec0cd..d8e9ce3291

[PATCH v6] board: mntre: imx8mq: Add MNT Reform 2 board support

2023-01-19 Thread Patrick Wildt
The MNT Reform 2 is a modular DIY laptop. In its initial version it is based on the BoundaryDevices i.MX8MQ SoM. Some parts have been lifted from BoundaryDevices official U-Boot downstream project. Signed-off-by: Patrick Wildt --- Changes since v5: - Adjusted to further Binman changes

[PATCH v5 2/2] board: mntre: imx8mq: Add MNT Reform 2 board support

2022-06-26 Thread Patrick Wildt
The MNT Reform 2 is a modular DIY laptop. In its initial version it is based on the BoundaryDevices i.MX8MQ SoM. Some parts have been lifted from BoundaryDevices official U-Boot downstream project. Signed-off-by: Patrick Wildt --- arch/arm/dts/imx8mq-mnt-reform2-u-boot.dtsi | 11 + arch

[PATCH v5 1/2] arm: dts: imx8mq: update MNT Reform 2 to Linux v5.19-rc3

2022-06-26 Thread Patrick Wildt
--- arch/arm/dts/imx8mq-mnt-reform2.dts | 145 +- arch/arm/dts/imx8mq-nitrogen-som.dtsi | 15 +-- 2 files changed, 152 insertions(+), 8 deletions(-) diff --git a/arch/arm/dts/imx8mq-mnt-reform2.dts b/arch/arm/dts/imx8mq-mnt-reform2.dts index 4f2db6197b..8956a46788

[PATCH v5 0/2] Add MNT Reform 2 board support

2022-06-26 Thread Patrick Wildt
filename. - Provided ramdisk_addr_r. Changes since v2: - Switched to Binman. Changes since v1: - Synced DTS with files in Linux git repo. - Added support for USB host ports. Patrick Wildt (2): arm: dts: imx8mq: update MNT Reform 2 to Linux v5.19-rc3 board: mntre: imx8mq: Add MNT Reform 2 board

[PATCH v2 4/4] arm64: dts: imx8mq-u-boot.dtsi: improve odd blob-ext naming

2022-01-13 Thread Patrick Wildt
Rather than using odd implicit blob-ext naming, explicitly specify the type to be of blob-ext and therefore also simplify the node naming. Signed-off-by: Patrick Wildt --- arch/arm/dts/imx8mq-u-boot.dtsi | 34 - 1 file changed, 21 insertions(+), 13 deletions

[PATCH v2 3/4] arm64: dts: imx8mm-u-boot.dtsi: use dash for node names

2022-01-13 Thread Patrick Wildt
Some of the nodes were named using a underscore, so rectify this and consistenly use dashes. Signed-off-by: Patrick Wildt --- arch/arm/dts/imx8mm-u-boot.dtsi | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/arm/dts/imx8mm-u-boot.dtsi b/arch/arm/dts/imx8mm-u

[PATCH v2 2/4] arm64: dts: imx8mq-u-boot.dtsi: explicitly add spl filename

2022-01-13 Thread Patrick Wildt
Explicitly add SPL aka u-boot-spl.bin filename. Signed-off-by: Patrick Wildt --- arch/arm/dts/imx8mq-u-boot.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/dts/imx8mq-u-boot.dtsi b/arch/arm/dts/imx8mq-u-boot.dtsi index d8208ae7b0..566b8b8035 100644 --- a/arch/arm/dts/imx8mq-u

[PATCH v2 1/4] arm64: dts: imx8mq-u-boot.dtsi: alphabetically re-order properties

2022-01-13 Thread Patrick Wildt
Alphabetically re-order properties. Signed-off-by: Patrick Wildt --- arch/arm/dts/imx8mq-u-boot.dtsi | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/arch/arm/dts/imx8mq-u-boot.dtsi b/arch/arm/dts/imx8mq-u-boot.dtsi index 8a6075c77b..d8208ae7b0

[PATCH v2 0/4] arm64: imx8mq/imx8mm: cleanup binman configuration

2022-01-13 Thread Patrick Wildt
v1: - Underscores in node names replaced with dashes. Patrick Wildt (4): arm64: dts: imx8mq-u-boot.dtsi: alphabetically re-order properties arm64: dts: imx8mq-u-boot.dtsi: explicitly add spl filename arm64: dts: imx8mm-u-boot.dtsi: use dash for node names arm64: dts: imx8mq-u-boot.dtsi

Re: [PATCH 3/4] arm64: dts: imx8mm-u-boot.dtsi: fix typo in ddr blob name

2022-01-13 Thread Patrick Wildt
On Thu, Jan 13, 2022 at 10:40:21AM -0300, Fabio Estevam wrote: > Hi Patrick, > > On 13/01/2022 10:29, Michael Walle wrote: > > > Why don't you just change it to the correct naming then? > > I agree with Michael: node names should use a dash instead of the > underscore. > > dtc complains about

Re: [PATCH 3/4] arm64: dts: imx8mm-u-boot.dtsi: fix typo in ddr blob name

2022-01-13 Thread Patrick Wildt
On Thu, Jan 13, 2022 at 12:42:50PM +0100, Michael Walle wrote: > Hi, > > > --- a/arch/arm/dts/imx8mm-u-boot.dtsi > > +++ b/arch/arm/dts/imx8mm-u-boot.dtsi > > @@ -39,7 +39,7 @@ > > filename = "u-boot-spl.bin"; > > }; > > > > - 1d-imem { > > +

Re: [PATCH v4 0/2] Add MNT Reform 2 board support

2022-01-12 Thread Patrick Wildt
On Wed, Jan 12, 2022 at 05:03:28PM -0500, Tom Rini wrote: > On Wed, Jan 12, 2022 at 10:29:50PM +0100, Patrick Wildt wrote: > > > Hi, > > > > is there anything I can do to help get attention on this patchset? > > Not a whole lot, sorry. The big hold up righ

Re: [PATCH v4 0/2] Add MNT Reform 2 board support

2022-01-12 Thread Patrick Wildt
now obsolete and hence breaks compilation, but I'm not sure it's worth sending it out if there's gonna be a v6 and v7 for another rebase soon anyway. Cheers, Patrick On Sat, Jan 08, 2022 at 04:04:14PM +0100, Patrick Wildt wrote: > The MNT Reform 2 is a modular DIY laptop. In its initial vers

[PATCH 4/4] arm64: dts: imx8mq-u-boot.dtsi: improve odd blob-ext naming

2022-01-12 Thread Patrick Wildt
Rather than using odd implicit blob-ext naming, explicitly specify the type to be of blob-ext and therefore also simplify the node naming. Signed-off-by: Patrick Wildt --- arch/arm/dts/imx8mq-u-boot.dtsi | 32 1 file changed, 20 insertions(+), 12 deletions

[PATCH 3/4] arm64: dts: imx8mm-u-boot.dtsi: fix typo in ddr blob name

2022-01-12 Thread Patrick Wildt
One of the blobs was named using a hyphen instead of an underscore, so make it consistent. Signed-off-by: Patrick Wildt --- arch/arm/dts/imx8mm-u-boot.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/dts/imx8mm-u-boot.dtsi b/arch/arm/dts/imx8mm-u-boot.dtsi index

[PATCH 2/4] arm64: dts: imx8mq-u-boot.dtsi: explicitly add spl filename

2022-01-12 Thread Patrick Wildt
Explicitly add SPL aka u-boot-spl.bin filename. Signed-off-by: Patrick Wildt --- arch/arm/dts/imx8mq-u-boot.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/dts/imx8mq-u-boot.dtsi b/arch/arm/dts/imx8mq-u-boot.dtsi index d8208ae7b0..566b8b8035 100644 --- a/arch/arm/dts/imx8mq-u

[PATCH 1/4] arm64: dts: imx8mq-u-boot.dtsi: alphabetically re-order properties

2022-01-12 Thread Patrick Wildt
Alphabetically re-order properties. Signed-off-by: Patrick Wildt --- arch/arm/dts/imx8mq-u-boot.dtsi | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/arch/arm/dts/imx8mq-u-boot.dtsi b/arch/arm/dts/imx8mq-u-boot.dtsi index 8a6075c77b..d8208ae7b0

[PATCH 0/4] arm64: imx8mq/imx8mm: cleanup binman configuration

2022-01-12 Thread Patrick Wildt
The i.MX8MM boards have been converted for some longer time compared to i.MX8MQ. During that time the i.MX8MM binman configuration has already gotten some cleanup. This brings the i.MX8MQ binman config in line with the i.MX8MM one, and fixes a typo in the i.MX8MM config. Patrick Wildt (4

Re: [PATCH 3/3] doc: verdin-imx8mm: Remove ATF_LOAD_ADDR export

2022-01-12 Thread Patrick Wildt
On Wed, Jan 12, 2022 at 05:49:46PM -0300, Fabio Estevam wrote: > imx8mm-u-boot.dtsi passes the ATF load address via the > 'entry' and 'load' properties. > > Remove the step that performs the ATF_LOAD_ADDR export, which is > now unneeded. > > Signed-off-by: Fabio Estevam

Re: [PATCH 2/3] doc: sl-mx8mm: Remove ATF_LOAD_ADDR export

2022-01-12 Thread Patrick Wildt
On Wed, Jan 12, 2022 at 05:49:45PM -0300, Fabio Estevam wrote: > imx8mm-u-boot.dtsi passes the ATF load address via the > 'entry' and 'load' properties. > > Remove the step that performs the ATF_LOAD_ADDR export, which is > now unneeded. > > Signed-off-by: Fabio Estevam

Re: [PATCH 1/3] doc: imx8mm_evk: Remove ATF_LOAD_ADDR export

2022-01-12 Thread Patrick Wildt
On Wed, Jan 12, 2022 at 05:49:44PM -0300, Fabio Estevam wrote: > imx8mm-u-boot.dtsi passes the ATF load address via the > 'entry' and 'load' properties. > > Remove the step that performs the ATF_LOAD_ADDR export, which is > now unneeded. > > Signed-off-by: Fabio Estevam

Re: [PATCH] imx8mq: Generate a single bootable flash.bin again

2022-01-08 Thread Patrick Wildt
On Sat, Jan 08, 2022 at 12:24:29PM -0300, Fabio Estevam wrote: > On 08/01/2022 12:16, Patrick Wildt wrote: > > > but it's not only imx8mq_evk. Tom has merged the patchset that switches > > *all* i.MX8MQ boards to Binman, which means that this change touches not > >

[PATCH v2] imx8mq: Generate a single bootable flash.bin again

2022-01-08 Thread Patrick Wildt
purposes). Also update imx8mq_evk.rst to remove the u-boot.itb copy step. This is a cherry-pick of 028abfd9b157 ("imx8mm-evk: Generate a single bootable flash.bin again") adjusted to apply to i.MX8MQ. Signed-off-by: Patrick Wildt --- arch/arm/dts/imx8mq-u-boot.dtsi

Re: [PATCH] imx8mq: Generate a single bootable flash.bin again

2022-01-08 Thread Patrick Wildt
On Sat, Jan 08, 2022 at 12:10:49PM -0300, Fabio Estevam wrote: > On 08/01/2022 11:58, Patrick Wildt wrote: > > After the conversion to binman in commit c1ecd03d90c7 ("imx: imx8mq_evk: > > switch to binman"), it is necessary to flash both flash.bin and > > u-boot.itb

[PATCH v4 2/2] board: mntre: imx8mq: Add MNT Reform 2 board support

2022-01-08 Thread Patrick Wildt
The MNT Reform 2 is a modular DIY laptop. In its initial version it is based on the BoundaryDevices i.MX8MQ SoM. Some parts have been lifted from BoundaryDevices official U-Boot downstream project. Signed-off-by: Patrick Wildt --- arch/arm/dts/imx8mq-mnt-reform2-u-boot.dtsi | 13 + arch

[PATCH v4 1/2] arm: dts: imx8mq: add MNT Reform 2

2022-01-08 Thread Patrick Wildt
Device tree taken from Linux v5.16-rc5. Signed-off-by: Patrick Wildt --- arch/arm/dts/Makefile | 1 + arch/arm/dts/imx8mq-mnt-reform2.dts | 214 arch/arm/dts/imx8mq-nitrogen-som.dtsi | 275 ++ 3 files changed, 490 insertions

[PATCH v4 0/2] Add MNT Reform 2 board support

2022-01-08 Thread Patrick Wildt
support for USB host ports. Patrick Wildt (2): arm: dts: imx8mq: add MNT Reform 2 board: mntre: imx8mq: Add MNT Reform 2 board support arch/arm/dts/Makefile |1 + arch/arm/dts/imx8mq-mnt-reform2-u-boot.dtsi | 13 + arch/arm/dts/imx8mq-mnt-reform2.dts

[PATCH] imx8mq: Generate a single bootable flash.bin again

2022-01-08 Thread Patrick Wildt
ll be used standalone (for example, for secure boot purposes). Also update imx8mq_evk.rst to remove the u-boot.itb copy step. This is a cherry-pick of 028abfd9b157 ("imx8mm-evk: Generate a single bootable flash.bin again") adjusted to apply to i.MX8MQ. Signed-off-by: Patrick Wildt --- a

Re: [PATCH] dts: rockchip: rk3399: enable emmc phy for spl

2021-12-17 Thread Patrick Wildt
Am Mon, Nov 01, 2021 at 12:43:47PM +0800 schrieb Yifeng Zhao: > adapting commit ac804143cf ("mmc: rockchip_sdhci: add phy and clock > config for rk3399") to fix the issue "Not found emmc phy device". Reviewed-by: Patrick Wildt Tested-by: Patrick Wildt - on a

[PATCH v3 2/2] board: mntre: imx8mq: Add MNT Reform 2 board support

2021-12-14 Thread Patrick Wildt
The MNT Reform 2 is a modular DIY laptop. In its initial version it is based on the BoundaryDevices i.MX8MQ SoM. Some parts have been lifted from BoundaryDevices official U-Boot downstream project. Signed-off-by: Patrick Wildt --- arch/arm/dts/imx8mq-mnt-reform2-u-boot.dtsi | 143 +++ arch

[PATCH v3 1/2] arm: dts: imx8mq: add MNT Reform 2

2021-12-14 Thread Patrick Wildt
Device tree taken from Linux v5.16-rc5. Signed-off-by: Patrick Wildt --- arch/arm/dts/Makefile | 1 + arch/arm/dts/imx8mq-mnt-reform2.dts | 214 arch/arm/dts/imx8mq-nitrogen-som.dtsi | 275 ++ 3 files changed, 490 insertions

[PATCH v3 0/2] Add MNT Reform 2 board support

2021-12-14 Thread Patrick Wildt
. Changes since v2: - Switched to Binman. Changes since v1: - Synced DTS with files in Linux git repo. - Added support for USB host ports. Patrick Wildt (2): arm: dts: imx8mq: add MNT Reform 2 board: mntre: imx8mq: Add MNT Reform 2 board support arch/arm/dts/Makefile

Re: [PATCH v2 2/2] board: mntre: imx8mq: Add MNT Reform 2 board support

2021-11-24 Thread Patrick Wildt
On Fri, Nov 12, 2021 at 11:59:29AM -0800, Vagrant Cascadian wrote: > On 2021-11-11, Patrick Wildt wrote: > > On Thu, Nov 11, 2021 at 12:21:26PM +0100, Patrick Wildt wrote: > >> On Wed, Nov 10, 2021 at 02:26:54PM -0800, Vagrant Cascadian wrote: > >> > On 2

Re: [PATCH v2 2/2] board: mntre: imx8mq: Add MNT Reform 2 board support

2021-11-11 Thread Patrick Wildt
On Thu, Nov 11, 2021 at 12:21:26PM +0100, Patrick Wildt wrote: > On Wed, Nov 10, 2021 at 02:26:54PM -0800, Vagrant Cascadian wrote: > > On 2021-09-02, Patrick Wildt wrote: > > > The MNT Reform 2 is a modular DIY laptop. In its initial version it > > > is based on the

Re: [PATCH V3 5/5] doc: imx8mq_evk: update doc after using binman

2021-11-11 Thread Patrick Wildt
On Fri, Oct 22, 2021 at 10:42:20AM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > Update doc after using binman to pack images Not necessary if we make sure flash.bin stays a single bootable image > Signed-off-by: Peng Fan > --- > doc/board/nxp/imx8mq_evk.rst | 3 ++- > 1 file changed, 2

Re: [PATCH V3 4/5] imx: imx8mq use common imximage.cfg

2021-11-11 Thread Patrick Wildt
On Fri, Oct 22, 2021 at 10:42:19AM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > After all these board switch to binman, we could use common imximage.cfg Reviewed-by: Patrick Wildt > Signed-off-by: Peng Fan > --- > arch/arm/mach-imx/imx8m/imximage.cfg | 12 +++

Re: [PATCH V3 3/5] imx: pico-imx8mq: switch to use binman

2021-11-11 Thread Patrick Wildt
On Fri, Oct 22, 2021 at 10:42:18AM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > Switch to use binman to pack images Reviewed-by: Patrick Wildt > Signed-off-by: Peng Fan > --- > arch/arm/dts/imx8mq-pico-pi.dts | 1 + > arch/arm/mach-imx/imx8m/Kconfig

Re: [PATCH V3 2/5] imx: imx8mq_phanbell: switch to binman

2021-11-11 Thread Patrick Wildt
On Fri, Oct 22, 2021 at 10:42:17AM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > Switch to binman to pack images Reviewed-by: Patrick Wildt > Signed-off-by: Peng Fan > --- > arch/arm/dts/imx8mq-phanbell-u-boot.dtsi | 2 ++ > arch/arm/mach-imx/imx8m/K

Re: [PATCH V3 1/5] imx: imx8mq_evk: switch to binman

2021-11-11 Thread Patrick Wildt
On Fri, Oct 22, 2021 at 10:42:16AM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > Switch to use binman to pack images > > Signed-off-by: Peng Fan I'm unsure how to reply to this. On the one hand I really like to see this go in, on the other hand this changes the expectation of what

Re: [PATCH v2 2/2] board: mntre: imx8mq: Add MNT Reform 2 board support

2021-11-11 Thread Patrick Wildt
On Wed, Nov 10, 2021 at 02:26:54PM -0800, Vagrant Cascadian wrote: > On 2021-09-02, Patrick Wildt wrote: > > The MNT Reform 2 is a modular DIY laptop. In its initial version it > > is based on the BoundaryDevices i.MX8MQ SoM. Some parts have been > > lifted from BoundaryDe

Re: [PATCH v2 2/2] board: mntre: imx8mq: Add MNT Reform 2 board support

2021-09-03 Thread Patrick Wildt
Am Fri, Sep 03, 2021 at 05:58:07PM -0300 schrieb Fabio Estevam: > Hi Patrick, > > On Fri, Sep 3, 2021 at 11:30 AM Patrick Wildt wrote: > > > U-Boot SPL 2021.10-rc3-00023-g2c634e01b6-dirty (Sep 03 2021 - 18:22:04 > > +0200) > > Normal Boot > > Coul

Re: [PATCH v2 2/2] board: mntre: imx8mq: Add MNT Reform 2 board support

2021-09-03 Thread Patrick Wildt
Am Fri, Sep 03, 2021 at 08:25:39PM +0200 schrieb Heiko Thiery: > Hi Patrick, > > Am Fr., 3. Sept. 2021 um 16:30 Uhr schrieb Patrick Wildt : > > > > Am Fri, Sep 03, 2021 at 11:01:06AM +0200 schrieb Heiko Thiery: > > > Hi Patrick, > > > > > > Am Do.,

Re: [PATCH v2 2/2] board: mntre: imx8mq: Add MNT Reform 2 board support

2021-09-03 Thread Patrick Wildt
Am Fri, Sep 03, 2021 at 11:01:06AM +0200 schrieb Heiko Thiery: > Hi Patrick, > > Am Do., 2. Sept. 2021 um 23:44 Uhr schrieb Patrick Wildt : > > > > The MNT Reform 2 is a modular DIY laptop. In its initial version it > > is based on the BoundaryDevices i.MX8MQ

[PATCH v2 2/2] board: mntre: imx8mq: Add MNT Reform 2 board support

2021-09-02 Thread Patrick Wildt
The MNT Reform 2 is a modular DIY laptop. In its initial version it is based on the BoundaryDevices i.MX8MQ SoM. Some parts have been lifted from BoundaryDevices official U-Boot downstream project. Signed-off-by: Patrick Wildt --- arch/arm/dts/imx8mq-mnt-reform2-u-boot.dtsi | 11 + arch

[PATCH v2 1/2] arm: dts: imx8mq: add MNT Reform 2

2021-09-02 Thread Patrick Wildt
Signed-off-by: Patrick Wildt --- arch/arm/dts/Makefile | 1 + arch/arm/dts/imx8mq-mnt-reform2.dts | 213 arch/arm/dts/imx8mq-nitrogen-som.dtsi | 275 ++ 3 files changed, 489 insertions(+) create mode 100644 arch/arm/dts/imx8mq-mnt

[PATCH v2 0/2] Add MNT Reform 2 board support

2021-09-02 Thread Patrick Wildt
. Changes since v2: - Synced DTS with files in Linux git repo. - Added support for USB host ports. Patrick Wildt (2): arm: dts: imx8mq: add MNT Reform 2 board: mntre: imx8mq: Add MNT Reform 2 board support arch/arm/dts/Makefile |1 + arch/arm/dts/imx8mq-mnt-reform2

[PATCH] mux: correct prototype for mux_control_try_select()

2021-07-13 Thread Patrick Wildt
The macro should be passed a state, which should be passed to the actual function. Otherwise using that macro would yield a build error. Signed-off-by: Patrick Wildt --- include/mux.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/mux.h b/include/mux.h index

Re: [PATCH 1/4] phy: phy-imx8mq-usb: Add USB PHY driver for i.MX8MQ

2021-07-13 Thread Patrick Wildt
> > > > > > On Mon, Jul 12, 2021 at 11:27 AM Patrick Wildt > > > > wrote: > > > > > > > > > > Am Sun, Feb 21, 2021 at 08:26:21AM -0800 schrieb Ye Li: > > > > > > Add the USB PHY driver for i.MX8MQ to work with D

Re: [PATCH 4/4] imx8mq_evk: Enable the USB3.0 host port

2021-07-12 Thread Patrick Wildt
Am Sun, Feb 21, 2021 at 08:26:24AM -0800 schrieb Ye Li: > Setup USB clock in board codes, and enable the DWC3 XHCI and > PHY drivers to make USB3.0 host port working on i.MX8MQ EVK. > > Signed-off-by: Ye Li The same change works on the MNT Reform 2 as well. Reviewed-by: P

Re: [PATCH 3/4] arm: imx8mq: Add USB clock init function

2021-07-12 Thread Patrick Wildt
Am Sun, Feb 21, 2021 at 08:26:23AM -0800 schrieb Ye Li: > Add clock function to setup relevant clocks for USB3.0 controllers and > PHYs on i.MX8MQ > > Signed-off-by: Ye Li Reviewed-by: Patrick Wildt Tested-by: Patrick Wildt > --- > arch/arm/include/asm/arch-imx8m/clock.h

Re: [PATCH 2/4] arm: dts: imx8mq: Add alias for two usb controllers

2021-07-12 Thread Patrick Wildt
; I'm not sure what the policy is. Should changes to the device tree be put into the u-boot.dtsi? At least it isn't part of torvald's master branch. In any case: Tested-by: Patrick Wildt > }; > > ckil: clock-ckil { > -- > 2.7.4 >

Re: [PATCH 1/4] phy: phy-imx8mq-usb: Add USB PHY driver for i.MX8MQ

2021-07-12 Thread Patrick Wildt
Am Sun, Feb 21, 2021 at 08:26:21AM -0800 schrieb Ye Li: > Add the USB PHY driver for i.MX8MQ to work with DWC3 USB controller. > > Signed-off-by: Ye Li Reviewed-by: Patrick Wildt Tested-by: Patrick Wildt > --- > drivers/phy/Kconfig | 7 ++ > drivers/phy/Make

Re: [EXT] Re: [PATCH 4/4] imx8mq_evk: Enable the USB3.0 host port

2021-07-12 Thread Patrick Wildt
Am Mon, Jul 12, 2021 at 10:28:25AM -0300 schrieb Fabio Estevam: > Hi Patrick, > > On Sat, Jul 10, 2021 at 8:35 PM Patrick Wildt wrote: > > > is this patchset still being reviewed? I think the discussion has moved > > to some SD card problem, which is fixed now? Would b

Re: [EXT] Re: [PATCH 4/4] imx8mq_evk: Enable the USB3.0 host port

2021-07-10 Thread Patrick Wildt
Am Wed, Mar 03, 2021 at 08:53:52AM + schrieb Bough Chen: > > -Original Message- > > From: Ye Li > > Sent: 2021年2月27日 14:05 > > To: feste...@gmail.com; Bough Chen > > Cc: Peng Fan ; u-boot@lists.denx.de; dl-uboot-imx > > ; sba...@denx.de > > Subject: Re: [EXT] Re: [PATCH 4/4]

[PATCH 2/2] board: mntre: imx8mq: Add MNT Reform 2 board support

2021-07-10 Thread Patrick Wildt
The MNT Reform 2 is a modular DIY laptop. In its initial version it is based on the BoundaryDevices i.MX8MQ SoM. Some parts have been lifted from BoundaryDevices official U-Boot downstream project. Signed-off-by: Patrick Wildt --- arch/arm/dts/imx8mq-mnt-reform2-u-boot.dtsi | 11 + arch

[PATCH 1/2] arm: dts: imx8mq: add MNT Reform 2

2021-07-10 Thread Patrick Wildt
Device tree taken from v4 of the MNT Reform 2 series on the Linux ARM Kernel Architecture mailing list: https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=500045 Signed-off-by: Patrick Wildt --- arch/arm/dts/Makefile | 1 + arch/arm/dts/imx8mq-mnt-reform2.dts

[PATCH 0/2] Add MNT Reform 2 board support

2021-07-10 Thread Patrick Wildt
on the Linux ARM Kernel Architecture mailing list, which hopefully will now be merged as is. This U-Boot patchset supports the serial console, the SD card and eMMC, and Gigabit Ethernet. Best regards, Patrick Patrick Wildt (2): arm: dts: imx8mq: add MNT Reform 2 board: mntre: imx8mq: Add MNT

Re: [PATCHv3 1/3] pci: pcie_dw_rockchip: Fixed the below compilation error

2021-06-04 Thread Patrick Wildt
0: error: 'PCIBIOS_UNSUPPORTED' > undeclared (first use in this function) >90 | return PCIBIOS_UNSUPPORTED; > | ^~~ > > Cc: Patrick Wildt > Cc: Neil Armstrong > Cc: Kever Yang > Reviewed-by: Neil Armstrong > Signed-off-by: Anand Moon &

Re: [PATCHv3 2/3] pci: pcie_dw_rockchip: Drop the unused variable warning

2021-06-04 Thread Patrick Wildt
Am Fri, Jun 04, 2021 at 04:56:06AM + schrieb Anand Moon: > Drop the unused variable warning below. > > drivers/pci/pcie_dw_rockchip.c:161:6: warning: unused variable > 'val' [-Wunused-variable] > 161 | u32 val; > | ^~~ > Cc: Patrick Wildt > Cc: Neil Arm

Re: [PATCHv3 3/3] pci: pcie_dw_rockchip: Replace msleep occurences by udelay

2021-06-04 Thread Patrick Wildt
Am Fri, Jun 04, 2021 at 04:56:07AM + schrieb Anand Moon: > Replace msleep occurences by udelay. > > drivers/pci/pcie_dw_rockchip.c:254:3: warning: implicit > declaration of function 'msleep' [-Wimplicit-function-declaration] > > Cc: Patrick Wildt > Cc: Neil Armstr

Re: [PATCH] rk3399: Add basic support for helios64【请注意,邮件由cglom...@redhat.com代发】

2021-05-31 Thread Patrick Wildt
Any news on this? Uwe, Christian? Am Tue, Mar 30, 2021 at 03:21:32PM +0800 schrieb Kever Yang: > Hi > > Could you send new patch set if everything is ready. > > > Thanks, > > - Kever > > On 2021/3/9 上午12:29, Christian Glombek wrote: > > I've looked into this a bit over the weekend - my

Re: [PATCH 3/3] pci: pcie_dw_rockchip: Use udelay instead of msleep

2021-04-27 Thread Patrick Wildt
Am Tue, Apr 27, 2021 at 11:11:19AM +0530 schrieb Anand Moon: > hi Patrick, > > On Tue, 27 Apr 2021 at 01:38, Patrick Wildt wrote: > > > > Am Mon, Apr 26, 2021 at 01:26:32PM + schrieb Anand Moon: > > > Use udelay instead of msleep fix the below warning. > >

Re: [PATCH 2/3] usb: ehci-mx6: add IMX8MM OTG support

2021-04-27 Thread Patrick Wildt
Am Tue, Apr 27, 2021 at 10:50:34AM -0700 schrieb Tim Harvey: > On Tue, Apr 27, 2021 at 10:44 AM Marek Vasut wrote: > > > > On 4/27/21 7:08 PM, Tim Harvey wrote: > > > Add support for determining host vs peripheral mode for IMX8MM > > > configured as OTG. > > > > > > Signed-off-by: Tim Harvey > >

Re: [PATCH 1/3] pci: pcie_dw_rockchip: Fixed the below compilation error

2021-04-26 Thread Patrick Wildt
Am Mon, Apr 26, 2021 at 01:26:30PM + schrieb Anand Moon: > Use the Error values that may be returned by PCI functions > Added the error macro from linux/include/linux/pci.h > > drivers/pci/pcie_dw_rockchip.c: In function 'rk_pcie_read': > drivers/pci/pcie_dw_rockchip.c:70:10: error:

Re: [PATCH 3/3] pci: pcie_dw_rockchip: Use udelay instead of msleep

2021-04-26 Thread Patrick Wildt
Am Mon, Apr 26, 2021 at 01:26:32PM + schrieb Anand Moon: > Use udelay instead of msleep fix the below warning. You sure that's correct? the m in msleep means milli, while the u in udelay means micro. That's a factor of 1000 of a difference. > drivers/pci/pcie_dw_rockchip.c:254:3: warning:

Re: [PATCH] arm64: rk3399: Add support NanoPi R4s

2021-02-26 Thread Patrick Wildt
Am Fri, Feb 26, 2021 at 09:37:58PM +0100 schrieb Patrick Wildt: > Am Mon, Feb 08, 2021 at 04:56:35PM +0800 schrieb xiaobo: > > From: Xiaobo Tian > > > > NanoPi R4s is SBC base on Rockchip RK3399 hexa-core processor with > > dual-Core Cortex-A72 and Mali-T864 GPU with 4

Re: [PATCH] arm64: rk3399: Add support NanoPi R4s

2021-02-26 Thread Patrick Wildt
Am Mon, Feb 08, 2021 at 04:56:35PM +0800 schrieb xiaobo: > From: Xiaobo Tian > > NanoPi R4s is SBC base on Rockchip RK3399 hexa-core processor with > dual-Core Cortex-A72 and Mali-T864 GPU with 4GiB(LPDDR4) of RAM, SD card > support, > including 2 gigabit ethernet(RTL8211E 1Gbps - RTL8111H

Re: [PATCH v2] serial: s5p: Allow independent selection

2021-02-14 Thread Patrick Wildt
SoCs as well. > > Signed-off-by: Mark Kettenis Reviewed-by: Patrick Wildt > --- > > v2: fix Kconfig > > drivers/serial/Kconfig | 7 +++ > drivers/serial/Makefile | 2 +- > 2 files changed, 8 insertions(+), 1 deletion(-) > > diff --git a/drivers/serial/Kconfi

Re: [PATCH v3 2/2] efi_loader: fix use after free in receive path

2020-11-20 Thread Patrick Wildt
On Fri, Nov 20, 2020 at 06:31:52PM -0500, Tom Rini wrote: > On Fri, Nov 20, 2020 at 11:56:27PM +0100, Patrick Wildt wrote: > > Am Wed, Oct 07, 2020 at 03:26:38PM +0200 schrieb Heinrich Schuchardt: > > > On 07.10.20 11:04, Patrick Wildt wrote: > > > > With DM enabled

Re: [PATCH v3 2/2] efi_loader: fix use after free in receive path

2020-11-20 Thread Patrick Wildt
Am Wed, Oct 07, 2020 at 03:26:38PM +0200 schrieb Heinrich Schuchardt: > On 07.10.20 11:04, Patrick Wildt wrote: > > With DM enabled the ethernet code will receive a packet, call > > the push method that's set by the EFI network implementation > > and then free the packet. U

[PATCH v3 2/2] efi_loader: fix use after free in receive path

2020-10-07 Thread Patrick Wildt
to receive 32 packets at once, thus we better allocate as many buffers as the stack. Signed-off-by: Patrick Wildt --- Changes from v2: - Inverted the logic of efi_net_receive() reflecting the fill level, since in v2 it was the wrong way around. - Clearing the packet queue by simply setting the amount

[PATCH v3 1/2] net: add a define for the number of packets received as batch

2020-10-07 Thread Patrick Wildt
With a define for the magic number of packets received as batch we can make sure that the EFI network stack caches the same amount of packets. Signed-off-by: Patrick Wildt --- Changes in v3: - Simple rebase to resend patches together. Changes in v2: - Split this commit out of another one

[PATCH v2 2/2] efi_loader: fix use after free in receive path

2020-10-06 Thread Patrick Wildt
to receive 32 packets at once, thus we better allocate as many buffers as the stack. Signed-off-by: Patrick Wildt --- lib/efi_loader/efi_net.c | 88 +--- 1 file changed, 65 insertions(+), 23 deletions(-) diff --git a/lib/efi_loader/efi_net.c b/lib/efi_loader/efi_net.c

[PATCH v2 1/2] net: add a define for the number of packets received as batch

2020-10-06 Thread Patrick Wildt
With a define for the magic number of packets received as batch we can make sure that the EFI network stack caches the same amount of packets. Signed-off-by: Patrick Wildt --- include/net.h| 3 +++ net/eth-uclass.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git

Re: [PATCH] efi_loader: fix use after free in receive path

2020-10-06 Thread Patrick Wildt
On Wed, Oct 07, 2020 at 12:45:17AM +0200, Heinrich Schuchardt wrote: > Am 7. Oktober 2020 00:30:51 MESZ schrieb Patrick Wildt : > >With DM enabled the ethernet code will receive a packet, call > >the push method that's set by the EFI network implementation > >and

[PATCH] efi_loader: fix use after free in receive path

2020-10-06 Thread Patrick Wildt
to receive 32 packets at once, thus we better allocate as many buffers as the stack. Make that magic number a define, so it only needs to be changed in one place. Signed-off-by: Patrick Wildt --- include/net.h| 3 ++ lib/efi_loader/efi_net.c | 88

Re: efi_loader: fix free() before use in RX path

2020-10-06 Thread Patrick Wildt
On Tue, Oct 06, 2020 at 10:26:44PM +0200, Heinrich Schuchardt wrote: > On 10/6/20 6:32 PM, Patrick Wildt wrote: > > On Tue, Oct 06, 2020 at 04:56:31PM +0200, Patrick Wildt wrote: > >> Hi, > >> > >> I have an EFI application doing TFTP on an i.MX8MM board. The

Re: efi_loader: fix free() before use in RX path

2020-10-06 Thread Patrick Wildt
On Tue, Oct 06, 2020 at 04:56:31PM +0200, Patrick Wildt wrote: > Hi, > > I have an EFI application doing TFTP on an i.MX8MM board. The EFI > application uses the Simple Network Protocol and does ARP itself. > ARP didn't work, and I saw that the replies that were received on &

efi_loader: fix free() before use in RX path

2020-10-06 Thread Patrick Wildt
s the first packet from that list. Best regards, Patrick Signed-off-by: Patrick Wildt diff --git a/lib/efi_loader/efi_net.c b/lib/efi_loader/efi_net.c index 22f0123eca..6e3c29cba2 100644 --- a/lib/efi_loader/efi_net.c +++ b/lib/efi_loader/efi_net.c @@ -25,6 +25,8 @@ static const efi_guid_t efi_pxe_

Re: [PATCH v3] spl: allow board_spl_fit_post_load() to fail

2020-07-22 Thread Patrick Wildt
On Fri, Jun 05, 2020 at 03:54:14PM -0400, Tom Rini wrote: > On Mon, Jun 01, 2020 at 12:08:45PM +0200, Marek Vasut wrote: > > On 6/1/20 4:30 AM, Peng Fan wrote: > > >> Subject: [PATCH v3] spl: allow board_spl_fit_post_load() to fail > > >> > > >> On i.MX platforms board_spl_fit_post_load() can

Re: rockchip: correctly set vop0 or vop1

2020-06-08 Thread Patrick Wildt
On Mon, Jun 08, 2020 at 02:24:32PM +0200, Arnaud Patard wrote: > Patrick Wildt writes: > > > On Mon, Jun 08, 2020 at 10:18:19AM +0200, Arnaud Patard wrote: > >> Patrick Wildt writes: > >> > >> Hi, > >> > >> > The EDP_LCDC_SEL bit h

Re: rockchip: correctly set vop0 or vop1

2020-06-08 Thread Patrick Wildt
On Mon, Jun 08, 2020 at 10:18:19AM +0200, Arnaud Patard wrote: > Patrick Wildt writes: > > Hi, > > > The EDP_LCDC_SEL bit has to be set correctly to select vop0 or > > vop1, but so far we have set it in both conditions, which is not > > correct. > > > &

rockchip: correctly set vop0 or vop1

2020-06-07 Thread Patrick Wildt
The EDP_LCDC_SEL bit has to be set correctly to select vop0 or vop1, but so far we have set it in both conditions, which is not correct. Can someone verify this is the correct way round? vop1 -> set, vop0 -> clear? Signed-off-by: Patrick Wildt diff --git a/drivers/video/rockchip/rk_e

Re: [PATCH v3 2/2] rockchip: Enable PCIe and NVMe on ROCKPro64

2020-06-07 Thread Patrick Wildt
On Sun, Jun 07, 2020 at 02:57:00PM +0100, Peter Robinson wrote: > On Sun, Jun 7, 2020 at 2:47 PM Peter Robinson wrote: > > > > On Sun, Jun 7, 2020 at 1:07 PM Mark Kettenis wrote: > > > > > > Enable CONFIG_PCI and CONFIG_NVME and related configs for the > > > ROCKPro64 board. > > > > > >

rockchip: enable PCIe and NVMe on Pinebook Pro

2020-06-07 Thread Patrick Wildt
Enable CONFIG_PCI and CONFIG_NVME and related configs for the Pinebook Pro. Signed-off-by: Patrick Wildt diff --git a/configs/pinebook-pro-rk3399_defconfig b/configs/pinebook-pro-rk3399_defconfig index 9cce7ac00c1..0c129b9aebb 100644 --- a/configs/pinebook-pro-rk3399_defconfig +++ b/configs

[PATCH v3] spl: allow board_spl_fit_post_load() to fail

2020-05-31 Thread Patrick Wildt
. Allowing the function to return an error, allows the SPL to try booting from another source as a fallback instead of ending up as a brick. Signed-off-by: Patrick Wildt --- Changes in v3: - use EINVAL as return value to have a proper errno Changes in v2: - set SPL_FIT_FOUND only after successful post

Re: [PATCH] ARM: imx: hab: panic on authentication failure

2020-05-31 Thread Patrick Wildt
On Sun, May 31, 2020 at 06:51:14PM +0200, Marek Vasut wrote: > On 5/31/20 5:53 PM, Patrick Wildt wrote: > > On Sun, May 31, 2020 at 05:38:05PM +0200, Marek Vasut wrote: > >> On 5/30/20 10:53 PM, Patrick Wildt wrote: > >>> On Sat, May 30, 2020 at 10:29:19PM +0200, Mar

Re: [PATCH] ARM: imx: hab: panic on authentication failure

2020-05-31 Thread Patrick Wildt
On Sun, May 31, 2020 at 05:38:05PM +0200, Marek Vasut wrote: > On 5/30/20 10:53 PM, Patrick Wildt wrote: > > On Sat, May 30, 2020 at 10:29:19PM +0200, Marek Vasut wrote: > >> On 5/30/20 10:14 PM, Patrick Wildt wrote: > >>> On Sat, May 30, 2020 at 03:31:29PM -0300,

Re: [PATCH] ARM: imx: hab: panic on authentication failure

2020-05-30 Thread Patrick Wildt
On Sat, May 30, 2020 at 10:29:19PM +0200, Marek Vasut wrote: > On 5/30/20 10:14 PM, Patrick Wildt wrote: > > On Sat, May 30, 2020 at 03:31:29PM -0300, Fabio Estevam wrote: > >> Hi Marek, > >> > >> [Adding Breno] > >> > >> On Sat, May 30, 2

Re: [PATCH] ARM: imx: hab: panic on authentication failure

2020-05-30 Thread Patrick Wildt
On Sat, May 30, 2020 at 03:31:29PM -0300, Fabio Estevam wrote: > Hi Marek, > > [Adding Breno] > > On Sat, May 30, 2020 at 3:29 PM Marek Vasut wrote: > > > > Instead of hang()ing the system and thus disallowing any automated > > recovery possibility from a HAB authentication failure, panic() . >

[PATCH v2] spl: allow board_spl_fit_post_load() to fail

2020-05-28 Thread Patrick Wildt
. Allowing the function to return an error, allows the SPL to try booting from another source as a fallback instead of ending up as a brick. Signed-off-by: Patrick Wildt --- Changes in v2: - set SPL_FIT_FOUND only after successful post load arch/arm/mach-imx/spl.c | 6 -- common/spl/spl_fit.c

Re: imx: move ATF to the back of the FIT to fix loading over yModem

2020-05-28 Thread Patrick Wildt
Ping? On Fri, May 08, 2020 at 11:59:47AM +0200, Patrick Wildt wrote: > With yModem the FIT Image is only supplied once, so we can only > seek forward in the yModem supplied image and never backwards. > With the recent changes to the SPL mechanism, including loading > U-Boot firs

Re: [PATCH 1/1] imx: rom api: fix image offset computation

2020-05-12 Thread Patrick Wildt
On Tue, May 12, 2020 at 03:09:54PM +0200, S??bastien Szymanski wrote: > According to the table 6-25 "Primary image offset and IVT offset > details", in the IMX8MNRM, the ROM expects the following image offset: > > SD: 32KB > eMMC: 0 if image is in boot partion and 32KB if it is on user partition

Re: efi_loader: tighten PE verification code?

2020-05-10 Thread Patrick Wildt
On Sun, May 10, 2020 at 02:36:51PM -0600, Simon Glass wrote: > Hi Patrick, > > On Fri, 8 May 2020 at 12:56, Patrick Wildt wrote: > > > > Hi, > > > > even though this mail has a diff, it's not supposed to be a patch. I > > have started adjusting my fuzzer

  1   2   >