Re: [PATCH v2] tools: Add script to update git subtree projects

2024-07-23 Thread Quentin Schulz
Hi Raymond, On 7/23/24 4:05 PM, Raymond Mao wrote: Hi Quentin, On Tue, 23 Jul 2024 at 03:16, Quentin Schulz wrote: Hi Raymond, On 7/22/24 9:30 PM, Raymond Mao wrote: Recently we are introducing multiple git subtree projects and it is the right time to have a universal script to update

Re: [PATCH v2] tools: Add script to update git subtree projects

2024-07-23 Thread Quentin Schulz
Hi Raymond, On 7/22/24 9:30 PM, Raymond Mao wrote: Recently we are introducing multiple git subtree projects and it is the right time to have a universal script to update various subtrees and replace the dts/update-dts-subtree.sh. update-subtree.sh is a wrapper of git subtree commands. Usage:

Re: [PATCH v2 02/14] spl: Correct use of CMD_BOOTI and CMD_BOOTZ

2024-07-22 Thread Quentin Schulz
spl_image->load_addr, spl_image->size); return 0; } -#elif defined(CMD_BOOTZ) +#elif defined(CONFIG_CMD_BOOTZ) Ditto? In any case, Reviewed-by: Quentin Schulz Though i'm wondering why we are checking for CMD_BOOTI in SPL in the first place?

Re: [PATCH] rockchip: bring-up to Radxa Rock 3C board

2024-07-19 Thread Quentin Schulz
Hi Maxim, On 7/19/24 9:35 AM, Maxim Moskalets wrote: Just copy of rock-3a-rk3568_defconfig with dts for rock-3c-rk3566. Separated from the original due to the use of different DTS, than fixed primarily network support. Signed-off-by: Maxim Moskalets --- configs/rock-3c-rk3566_defconfig

Re: Pull request: u-boot-rockchip-20240614

2024-07-18 Thread Quentin Schulz
Hi Kever, On 7/18/24 5:52 AM, Kever Yang wrote: Hi Tom, Please pull the fixex for rockchip platform: - pmic fix for rk8xx; - pinctrl fix for rk3188/rv1126/rk3588; - mkimage fix for rockcihp "-l" option; I think this is a mistake? All commits are already merged. I assume you picked the

Re: [PATCH] b4-config: configure `b4` for U-Boot

2024-07-17 Thread Quentin Schulz
Hi Juaxun, On 7/17/24 5:12 PM, Jiaxun Yang wrote: `b4` is a commandline tool to make patch-based development easier[1] Provide a .b4-config file to match U-Boot's patch preference so it will be easier for people to use b4 with U-Boot development. I've been using b4 with the default settings

[PATCH v2 0/2] rockchip: theobroma: use HTTPS for git URLs and drop RK3368 Lion support

2024-07-17 Thread Quentin Schulz
more user-friendly (and also that git:// was only supported for Puma repo until yesterday). Signed-off-by: Quentin Schulz --- Changes in v2: - removed lion from DT Makefile - Link to v1: https://lore.kernel.org/r/20240620-tsd-http-git-clone-v1-0-666e8d6a8...@cherry.de --- Quentin Schulz (2

[PATCH v2 2/2] rockchip: remove support for Theobroma Systems RK3368 Lion

2024-07-17 Thread Quentin Schulz
From: Quentin Schulz No meaningful changes were made to this SoM since February 2021. Nobody from Theobroma has booted anything recent on that product since July 2021 at the latest. The product isn't available to buy anymore and disappeared from our website. This product is therefore

[PATCH v2 1/2] rockchip: theobroma-systems: migrate git URLs to HTTPS

2024-07-17 Thread Quentin Schulz
From: Quentin Schulz It turns out only Puma had a working git:// URL. Though that is now fixed, having HTTPS URLs make it easier to directly reach our cgit webserver to check what's up without having to change the URL manually. Depending on your terminal settings, this also makes it possible

Re: [PATCH next 1/4] rockchip: ringneck-px30: disable broken USB gadget

2024-07-16 Thread Quentin Schulz
Hi Kever, On 7/16/24 4:04 AM, Kever Yang wrote: Hi Quentin, On 2024/6/14 19:04, Quentin Schulz wrote: From: Quentin Schulz USB gadget simply doesn't work right now on PX30. Tested on PX30 EVB and PX30 Ringneck with Linux mainline and Rockchip 5.10 Linux as well as U-Boot. Do you mean

Re: [PATCH 13/13] doc: Describe the bootstd settings

2024-07-15 Thread Quentin Schulz
Hi Simon, On 7/15/24 12:13 PM, Simon Glass wrote: The bootstd node provides some configuration properties. Add these to the documentation. Signed-off-by: Simon Glass Reviewed-by: Quentin Schulz Thanks! Quentin

Re: [PATCH 12/13] boot: Correct indentation in efi bootmeth

2024-07-15 Thread Quentin Schulz
Hi Simon, On 7/15/24 12:13 PM, Simon Glass wrote: Fix a minor indentation / whitespace problem in a comment. Signed-off-by: Simon Glass Reviewed-by: Quentin Schulz Thanks! Quentin

Re: [PATCH 11/13] doc: Add a link to VBE from the bootstd docs

2024-07-15 Thread Quentin Schulz
Hi Simon, On 7/15/24 12:13 PM, Simon Glass wrote: Link to this page to make it easier to find the VBE docs. Signed-off-by: Simon Glass Reviewed-by: Quentin Schulz Thanks! Quentin

Re: [PATCH 10/13] doc: Add a description for bootmeth_script

2024-07-15 Thread Quentin Schulz
Hi Simon, On 7/15/24 12:13 PM, Simon Glass wrote: Add documentation for the script bootmeth. Signed-off-by: Simon Glass Reviewed-by: Quentin Schulz Thanks! Quentin

Re: [PATCH 08/13] bootstd: Tidy up comments on the boothmeth drivers

2024-07-15 Thread Quentin Schulz
Hi Simon, On 7/15/24 12:13 PM, Simon Glass wrote: Fix a typo in the comment and add one to the EFI driver too. Signed-off-by: Simon Glass Reviewed-by: Quentin Schulz Thanks! Quentin

Re: [PATCH 07/13] doc: Add a description for bootmeth_sandbox

2024-07-15 Thread Quentin Schulz
Hi Simon, On 7/15/24 12:13 PM, Simon Glass wrote: Add documentation for the sandbox bootmeth. Fix up the compatible string to drop the 'extlinux' part, which is not relevant to this bootmeth. Signed-off-by: Simon Glass Reviewed-by: Quentin Schulz Thanks! Quentin

Re: [PATCH 06/13] doc: Add a description for bootmeth_cros

2024-07-15 Thread Quentin Schulz
Hi Simon, On 7/15/24 12:13 PM, Simon Glass wrote: Add documentation for the cros bootmeth. Signed-off-by: Simon Glass Reviewed-by: Quentin Schulz Thanks! Quentin

Re: [PATCH 05/13] doc: Add a description for bootmeth_qfw

2024-07-15 Thread Quentin Schulz
Hi Simon, On 7/15/24 12:13 PM, Simon Glass wrote: Add documentation for the qfw bootmeth. Fix up the compatible string to drop the 'extlinux' part, which is not relevant to this bootmeth. Signed-off-by: Simon Glass Reviewed-by: Quentin Schulz Thanks! Quentin

Re: [PATCH 04/13] doc: Add a description for bootmeth_pxe

2024-07-15 Thread Quentin Schulz
Hi Simon, On 7/15/24 12:13 PM, Simon Glass wrote: Add documentation for the pxe bootmeth. Signed-off-by: Simon Glass Reviewed-by: Quentin Schulz Thanks! Quentin

Re: [PATCH 03/13] doc: Add a description for bootmeth_extlinux

2024-07-15 Thread Quentin Schulz
Hi Simon, On 7/15/24 12:13 PM, Simon Glass wrote: Add documentation for the extlinux bootmeth. Signed-off-by: Simon Glass Reviewed-by: Quentin Schulz Thanks! Quentin

Re: [PATCH 02/13] doc: Move bootstd into its own directory

2024-07-15 Thread Quentin Schulz
Hi Simon, On 7/15/24 12:13 PM, Simon Glass wrote: Before adding more files, move the bootstd docs into a new directory, with an index. Signed-off-by: Simon Glass Reviewed-by: Quentin Schulz Thanks! Quentin

Re: [PATCH 01/13] MAINTAINERS: Rename BOOTDEVICE

2024-07-15 Thread Quentin Schulz
Hi Simon, On 7/15/24 12:13 PM, Simon Glass wrote: Rename this to BOOTSTD which is the normal name for the feature. Signed-off-by: Simon Glass Reviewed-by: Quentin Schulz Thanks! Quentin

Re: [PATCH] dm: button: support remapping phone keys

2024-07-15 Thread Quentin Schulz
Hi Caleb, On 7/15/24 10:38 AM, Caleb Connolly wrote: Hi Quentin, On 15/07/2024 10:16, Quentin Schulz wrote: Hi Caleb, On 7/14/24 9:49 PM, Caleb Connolly wrote: We don't have audio support in U-Boot, but we do have boot menus. Add an option to re-map the volume and power buttons to up/down

Re: [PATCH] dm: button: support remapping phone keys

2024-07-15 Thread Quentin Schulz
Hi Caleb, On 7/14/24 9:49 PM, Caleb Connolly wrote: We don't have audio support in U-Boot, but we do have boot menus. Add an option to re-map the volume and power buttons to up/down/enter so that in situations where these are the only available buttons (such as on mobile phones) it's still

Re: [PATCH 09/10] fdtgrep: Allow propagating properties up to supernodes

2024-07-11 Thread Quentin Schulz
Hi Manorit, On 7/10/24 8:15 AM, Manorit Chawdhry wrote: Hi Simon, On 09:36-20231217, Simon Glass wrote: The existing bootph binding is defined such that properties in a subnode are also implied in the supernode also, as in this example: buttons { /* bootph,pre-ram is implied by

Re: [PATCH] spl: fit: List DTOs applied by SPL in U-Boot control DT

2024-07-08 Thread Quentin Schulz
Hi Marek, On 7/7/24 2:29 AM, Marek Vasut wrote: On 7/1/24 10:42 AM, Quentin Schulz wrote: Hi Marek, Hi, Shouldn't this rather be in /config node? This is what I had there originally, but then I realized that some DTs might not have the /config node in them (or am I mistaken?), so I

[PATCH 3/3] rockchip: tiger-rk3588: add PCIe support

2024-07-04 Thread Quentin Schulz
From: Quentin Schulz This enables PCIe support on Tiger as exposed on Q7_PCIE[0123]_[RT]X_[PN] signals and more specifically on the `PCI Express` connector on the Haikou devkit. This was tested with a PCIe to NVMe adapter (e.g. https://www.amazon.de/dp/B07RZZ3TJG). Signed-off-by: Quentin

[PATCH 2/3] rockchip: jaguar-rk3588: add PCIe M.2 M-KEY NVMe support

2024-07-04 Thread Quentin Schulz
From: Quentin Schulz Jaguar has an M.2 M-KEY slot for NVMes, connected to the PCIe3 4-lane PHY on RK3588. CONFIG_PHY_ROCKCHIP_NANENG_COMBOPHY=y is technically not necessary since it's required only for the M.2 E-KEY slot on the main PCB, but that is used typically for WiFi+BT modules

[PATCH 1/3] arm64: dts: rockchip: add PCIe3 support on rk3588-jaguar

2024-07-04 Thread Quentin Schulz
From: Heiko Stuebner The Jaguar SBC provides an M.2 slot connected to the pcie3 controller. In contrast to a number of other boards the pcie-refclk is gpio-controlled, so the necessary clock and is added to the list of pcie3 clocks. Signed-off-by: Heiko Stuebner Reviewed-by: Quentin Schulz

[PATCH 0/3] rockchip: enable PCIe/NVMe support for Theobroma RK3588 devices

2024-07-04 Thread Quentin Schulz
Jaguar has an M.2 M-KEY slot for NVMes and Tiger exposes the signals to the Q7 connector which is then routed on the Haikou devkit's `PCI Express` connector. With the help of a PCIe to NVMe adapter, NVMes can be used on Tiger Haikou as well. Signed-off-by: Quentin Schulz --- Heiko Stuebner (1

Re: [PATCH 0/2] Import environment variables from FIT configuration

2024-07-02 Thread Quentin Schulz
Hi Lukas, On 7/2/24 2:58 PM, Lukas Funke wrote: Hi Quentin, On 02.07.2024 13:37, Quentin Schulz wrote: Hi Lukas, On 7/2/24 1:01 PM, Lukas Funke wrote: Hi Quentin, On 02.07.2024 11:16, Quentin Schulz wrote: Hi Lukas, On 7/2/24 8:48 AM, lukas.funke-...@weidmueller.com wrote: From: Lukas

Re: [PATCH 0/2] Import environment variables from FIT configuration

2024-07-02 Thread Quentin Schulz
Hi Lukas, On 7/2/24 1:01 PM, Lukas Funke wrote: Hi Quentin, On 02.07.2024 11:16, Quentin Schulz wrote: Hi Lukas, On 7/2/24 8:48 AM, lukas.funke-...@weidmueller.com wrote: From: Lukas Funke This series enables U-Boot to import environment variables from the selectd FIT configuration. One

Re: [PATCH 0/2] Import environment variables from FIT configuration

2024-07-02 Thread Quentin Schulz
Hi Lukas, On 7/2/24 8:48 AM, lukas.funke-...@weidmueller.com wrote: From: Lukas Funke This series enables U-Boot to import environment variables from the selectd FIT configuration. One use-case is that the overall build process enriches the FIT configuration node with dm-verity information

Re: [PATCH] spl: fit: List DTOs applied by SPL in U-Boot control DT

2024-07-01 Thread Quentin Schulz
Hi Marek, On 6/30/24 4:33 AM, Marek Vasut wrote: On 6/28/24 10:27 AM, Quentin Schulz wrote: Hi, Shouldn't this rather be in /config node? This is what I had there originally, but then I realized that some DTs might not have the /config node in them (or am I mistaken?), so I moved the new

Re: [PATCH v4 3/3] drivers: bootcount: Fix typo in documentation

2024-07-01 Thread Quentin Schulz
Hi Vasileios, On 6/28/24 7:35 PM, Vasileios Amoiridis wrote: The bootcount documentation was using "unattended" while it probably intending to say "unintended" Signed-off-by: Vasileios Amoiridis Reviewed-by: Quentin Schulz Thanks! Quentin

Re: [PATCH v4 1/3] drivers: bootcount: Add support for ANY filesystem

2024-07-01 Thread Quentin Schulz
Hi Vasileios, On 6/28/24 7:35 PM, Vasileios Amoiridis wrote: Add support to save boot count variable in ANY filesystem. Tested with FAT and EXT. Reviewed-by: Tom Rini Reviewed-by: Heiko Schocher Reviewed-by: Philip Oberfichtner Signed-off-by: Vasileios Amoiridis --- doc/README.bootcount

Re: [PATCH] spl: fit: List DTOs applied by SPL in U-Boot control DT

2024-06-28 Thread Quentin Schulz
Hi Marek, On 6/28/24 4:42 AM, Marek Vasut wrote: On 6/27/24 2:42 PM, Quentin Schulz wrote: Hi Marek, Hi, On 6/27/24 1:58 AM, Marek Vasut wrote: Insert /u-boot, = property into the U-Boot control DT during SPL DTO application process. This can be used by user to inspect which DTOs got

Re: [PATCH] spl: fit: List DTOs applied by SPL in U-Boot control DT

2024-06-27 Thread Quentin Schulz
Hi Marek, On 6/27/24 1:58 AM, Marek Vasut wrote: Insert /u-boot, = property into the U-Boot control DT during SPL DTO application process. This can be used by user to inspect which DTOs got applied by the SPL and in which order from running U-Boot. Example: ``` u-boot=> fdt addr

Re: [PATCH 1/3] net: give a different name to rtl8169 interfaces

2024-06-27 Thread Quentin Schulz
Hi Etienne, On 6/25/24 1:42 PM, Etienne Dublé wrote: Hello, Le 25/06/2024 à 12:25, Dragan Simic a écrit : Another option may be to name them "rtl8169@", with "" reflecting the PCI region address (so it is unique and stable). What do you think? I guess that's one way, I'm also wondering

Re: [PATCH 1/3] net: give a different name to rtl8169 interfaces

2024-06-25 Thread Quentin Schulz
Hi Etienne, On 6/25/24 8:38 AM, Etienne Dublé wrote: Hi Quentin, Thanks for reviewing my patches. Le 24/06/2024 à 15:08, Quentin Schulz a écrit : [...]   1 file changed, 11 insertions(+) diff --git a/drivers/net/rtl8169.c b/drivers/net/rtl8169.c index 93e83661ce..b30d51731f 100644

Re: [PATCH 2/3] rockchip: fix wrong PCI range address in rk3568 dtsi

2024-06-24 Thread Quentin Schulz
Hi Etienne, On 6/24/24 2:40 PM, ETIENNE DUBLE wrote: One of the PCI ranges was wrong in this device tree. When testing with a FriendlyElec Nanopi R5C board, the 2nd ethernet interface (labelled "wan") was not working in u-boot because of that. With the correct value (found in FriendlyElec's

Re: [PATCH 1/3] net: give a different name to rtl8169 interfaces

2024-06-24 Thread Quentin Schulz
Hi Etienne, On 6/24/24 2:40 PM, ETIENNE DUBLE wrote: This commit implements the .bind member function, and gives a different name to interfaces: "RTL8169#0", "RTL8169#1", etc. This was tested on a FriendlyElec Nanopi R5C board, which has two RTL-8125B interfaces managed by this driver. Since

Re: [PATCH v4 16/16] Drop the special am335x_boneblack_vboot target

2024-06-24 Thread Quentin Schulz
Hi Simon, On 6/23/24 7:53 PM, Simon Glass wrote: Now that am335x_evm boots OK on the Beaglebone black, drop the latter and update the docs to cover the change. Also add a few updates about 'make fit' and drop the note about the security review, as U-Boot's verified boot has had quite extensive

Re: [PATCH v4 14/16] rockchip: Avoid #ifdefs in RK3399 SPL

2024-06-24 Thread Quentin Schulz
Hi Simon, On 6/23/24 7:53 PM, Simon Glass wrote: The code here is confusing due to large blocks which are #ifdefed out. Add a function phase_sdram_init() which returns whether SDRAM init should happen in the current phase, using that as needed to control the code flow. This increases code size

Re: [PATCH v4 13/16] rockchip: Ensure memory size is available in RK3399 SPL

2024-06-24 Thread Quentin Schulz
rge rockchip_sdram_size() function. Signed-off-by: Simon Glass Reviewed-by: Quentin Schulz Thanks! Quentin

Re: Request for hosting a boot-firmware repository in u-boot git (denx and GitHub)

2024-06-21 Thread Quentin Schulz
Hi Peter, On 6/21/24 10:56 AM, Peter Robinson wrote: rk3568 is now upstream, there was a PR upstream for this for some time, similar to rk3588, albeit not as long as rk56x. In some cases the issue here is the speed of review of upstream ATF. I don't think that means it should go into something

Re: Request for hosting a boot-firmware repository in u-boot git (denx and GitHub)

2024-06-21 Thread Quentin Schulz
Hi Peter, On 6/21/24 12:29 AM, Peter Robinson wrote: On Thu, 20 Jun 2024 at 23:22, Quentin Schulz wrote: Hi Nishanth Menon, +Cc Kever from Rockchip as maintainer of the arch in U-Boot +Cc Heiko as maintainer of many things Rockchip in many projects On 6/20/24 11:35 PM, Nishanth Menon wrote

Re: Request for hosting a boot-firmware repository in u-boot git (denx and GitHub)

2024-06-20 Thread Quentin Schulz
Hi Nishanth Menon, +Cc Kever from Rockchip as maintainer of the arch in U-Boot +Cc Heiko as maintainer of many things Rockchip in many projects On 6/20/24 11:35 PM, Nishanth Menon wrote: Hi Team, We have briefly discussed this topic on IRC[1]. I would like to propose a new boot-firmware

[PATCH next 2/2] rockchip: remove support for Theobroma Systems RK3368 Lion

2024-06-20 Thread Quentin Schulz
From: Quentin Schulz No meaningful changes were made to this SoM since February 2021. Nobody from Theobroma has booted anything recent on that product since July 2021 at the latest. The product isn't available to buy anymore and disappeared from our website. This product is therefore

[PATCH next 1/2] rockchip: theobroma-systems: migrate git URLs to HTTPS

2024-06-20 Thread Quentin Schulz
From: Quentin Schulz It turns out only Puma had a working git:// URL. Though that is now fixed, having HTTPS URLs make it easier to directly reach our cgit webserver to check what's up without having to change the URL manually. Depending on your terminal settings, this also makes it possible

[PATCH next 0/2] rockchip: theobroma: use HTTPS for git URLs and drop RK3368 Lion support

2024-06-20 Thread Quentin Schulz
more user-friendly (and also that git:// was only supported for Puma repo until yesterday). Signed-off-by: Quentin Schulz --- Quentin Schulz (2): rockchip: theobroma-systems: migrate git URLs to HTTPS rockchip: remove support for Theobroma Systems RK3368 Lion arch/arm/dts/rk3368-lion

[PATCH next v2] rockchip: puma-rk3399: increase Ethernet PHY timeout to 30s

2024-06-19 Thread Quentin Schulz
From: Quentin Schulz On Puma v2.1 with a KSZ9031, the Ethernet PHY often doesn't detect the link in the 4-second default timeout. After some boot-loop test for about a thousand boots, 70% were below 10s, 90% below 15s and 100% below 30s. Let's play it safe and make it 30s so that hopefully all

Re: [PATCH] rockchip: puma-rk3399: increase Ethernet PHY timeout to 30s

2024-06-19 Thread Quentin Schulz
Hi Tom, On 6/19/24 5:22 PM, Tom Rini wrote: On Wed, Jun 19, 2024 at 11:55:52AM +0200, Quentin Schulz wrote: From: Quentin Schulz On Puma v2.1 with a KSZ9031, the Ethernet PHY often doesn't detect the link in the 4-second default timeout. After some boot-loop test for about a thousand boots

[PATCH] scripts/Makefile.lib: remove bootph-some-ram property from VPL/TPL/SPL

2024-06-19 Thread Quentin Schulz
From: Quentin Schulz The property isn't useful in VPL/SPL/TPL as it is only for U-Boot proper pre-reloc, which has its own DTB. Signed-off-by: Quentin Schulz --- scripts/Makefile.lib | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/Makefile.lib b/scripts

Re: [PATCH COVER] rockchip: rk3399: fix SPI-NOR flash not found in U-Boot pre-reloc

2024-06-19 Thread Quentin Schulz
Hi, On 6/19/24 12:33 PM, Quentin Schulz wrote: Hi Jonas, On 6/17/24 8:53 PM, Jonas Karlman wrote: [...] I'm wondering if we shouldn't do the same for U-Boot proper DTB as well? I think that would be good, and should also remove the need for the recursive pinctrl lookup for bootph props

Re: [PATCH COVER] rockchip: rk3399: fix SPI-NOR flash not found in U-Boot pre-reloc

2024-06-19 Thread Quentin Schulz
Hi Jonas, On 6/17/24 8:53 PM, Jonas Karlman wrote: [...] I'm wondering if we shouldn't do the same for U-Boot proper DTB as well? I think that would be good, and should also remove the need for the recursive pinctrl lookup for bootph props during pre-reloc. i.e. cmd_fdt_rm_props = cat $<

[PATCH] rockchip: puma-rk3399: increase Ethernet PHY timeout to 30s

2024-06-19 Thread Quentin Schulz
From: Quentin Schulz On Puma v2.1 with a KSZ9031, the Ethernet PHY often doesn't detect the link in the 4-second default timeout. After some boot-loop test for about a thousand boots, 70% were below 10s, 90% below 15s and 100% below 30s. Let's play it safe and make it 30s so that hopefully all

Re: [PATCH next] power: rk8xx: fix display name for RK808

2024-06-18 Thread Quentin Schulz
Hi Dragan, On 6/17/24 7:57 PM, Dragan Simic wrote: On 2024-06-17 18:48, Quentin Schulz wrote: From: Quentin Schulz Commit 2ce40542e0eb ("power: rk8xx: properly print all supported PMICs name") fixed all PMICs name that were broken but broke the only one that was not broken alre

Re: [PATCH next v3 5/6] power: rk8xx: properly print all supported PMICs name

2024-06-17 Thread Quentin Schulz
Hi Dragan, On 6/17/24 4:58 PM, Dragan Simic wrote: Hello Quentin, On 2024-06-17 16:10, Quentin Schulz wrote: On 6/6/24 10:45 AM, Quentin Schulz wrote: From: Quentin Schulz The ID of the PMIC is stored in the 2 16b registers but the only part that matters right now is the 3 MSB, which make

[PATCH next] power: rk8xx: fix display name for RK808

2024-06-17 Thread Quentin Schulz
From: Quentin Schulz Commit 2ce40542e0eb ("power: rk8xx: properly print all supported PMICs name") fixed all PMICs name that were broken but broke the only one that was not broken already: RK808. This one is a special case because the ID registers are marked as reserved and always re

Re: [PATCH next v3 5/6] power: rk8xx: properly print all supported PMICs name

2024-06-17 Thread Quentin Schulz
Hi all, On 6/6/24 10:45 AM, Quentin Schulz wrote: From: Quentin Schulz The ID of the PMIC is stored in the 2 16b registers but the only part that matters right now is the 3 MSB, which make the 3 digits (in hex) of the part number. Right now, only RK808 was properly displayed, with this all

Re: [PATCH COVER] rockchip: rk3399: fix SPI-NOR flash not found in U-Boot pre-reloc

2024-06-17 Thread Quentin Schulz
Hi Jonas, On 6/17/24 3:44 PM, Jonas Karlman wrote: Hi Quentin, On 2024-06-17 15:29, Quentin Schulz wrote: Hi Jonas, On 6/17/24 3:26 PM, Jonas Karlman wrote: Hi Quentin, On 2024-06-17 15:10, Quentin Schulz wrote: From: Quentin Schulz In commit 100f489f58a6 ("rockchip: rk3399: Fix lo

Re: [PATCH COVER] rockchip: rk3399: fix SPI-NOR flash not found in U-Boot pre-reloc

2024-06-17 Thread Quentin Schulz
Hi Jonas, On 6/17/24 3:26 PM, Jonas Karlman wrote: Hi Quentin, On 2024-06-17 15:10, Quentin Schulz wrote: From: Quentin Schulz In commit 100f489f58a6 ("rockchip: rk3399: Fix loading FIT from SD-card when booting from eMMC"), the spi1 bootph properties were mistakenly removed mean

Re: [PATCH COVER] rockchip: rk3399: fix SPI-NOR flash not found in U-Boot pre-reloc

2024-06-17 Thread Quentin Schulz
Hi all, This is a patch, even if the mail subject says COVER, some regression in new b4 release. Cheers, Quentin On 6/17/24 3:10 PM, Quentin Schulz wrote: From: Quentin Schulz In commit 100f489f58a6 ("rockchip: rk3399: Fix loading FIT from SD-card when booting from eMMC"), the s

[PATCH COVER] rockchip: rk3399: fix SPI-NOR flash not found in U-Boot pre-reloc

2024-06-17 Thread Quentin Schulz
From: Quentin Schulz In commit 100f489f58a6 ("rockchip: rk3399: Fix loading FIT from SD-card when booting from eMMC"), the spi1 bootph properties were mistakenly removed meaning, so re-add them back to fix SPI-NOR flash not being found in U-Boot pre-reloc as required for RK3399 Pu

Re: [PATCH v2 2/2] bootstd: Replace bootmethod(s) -> bootmeth(s)

2024-06-17 Thread Quentin Schulz
Hi Heinrich, On 6/17/24 11:24 AM, Heinrich Schuchardt wrote: On 17.06.24 11:00, Quentin Schulz wrote: Hi all, On 6/17/24 8:31 AM, Mattijs Korpershoek wrote: Hi Heinrich, Thank you for your review. On dim., juin 16, 2024 at 09:38, Heinrich Schuchardt wrote: On 6/4/24 17:15, Mattijs

Re: [PATCH v2 2/2] bootstd: Replace bootmethod(s) -> bootmeth(s)

2024-06-17 Thread Quentin Schulz
Hi all, On 6/17/24 8:31 AM, Mattijs Korpershoek wrote: Hi Heinrich, Thank you for your review. On dim., juin 16, 2024 at 09:38, Heinrich Schuchardt wrote: On 6/4/24 17:15, Mattijs Korpershoek wrote: According to [1], we should use bootmeth when describing the struct bootmeth: """ For

[PATCH next 2/3] rockchip: io-domain: add support for PX30

2024-06-14 Thread Quentin Schulz
From: Quentin Schulz Port the PX30 part of the Rockchip IO Domain driver from Linux. This differs from linux version in that the io iodomain bit is enabled in the write ops instead of in an init ops as in linux, this way we can avoid keeping a full state of all supplies that have been

[PATCH next 3/3] rockchip: ringneck-px30: enable IO domain

2024-06-14 Thread Quentin Schulz
From: Quentin Schulz Enable the IO domain on Ringneck. Based on the current HW design, this should do nothing else than making sure vccio6 iodomain is controlled by the GRF and not GPIO0B6. Signed-off-by: Quentin Schulz --- configs/ringneck-px30_defconfig | 1 + 1 file changed, 1 insertion

[PATCH next 1/3] rockchip: px30: bind sub-nodes for GRF (syscon)

2024-06-14 Thread Quentin Schulz
From: Quentin Schulz There are some sub-nodes under the grf DT nodes, so add bind callback function in syscon_px30 driver to scan them recursively. Fixes: e9ccb2f526ed ("rockchip: add px30 architecture core") Signed-off-by: Quentin Schulz --- arch/arm/mach-rockchip/px30/syscon_

[PATCH next 0/3] rockchip: px30: add IO domain driver

2024-06-14 Thread Quentin Schulz
. Finally, enable this on PX30 Ringneck. Signed-off-by: Quentin Schulz --- Quentin Schulz (3): rockchip: px30: bind sub-nodes for GRF (syscon) rockchip: io-domain: add support for PX30 rockchip: ringneck-px30: enable IO domain arch/arm/mach-rockchip/px30/syscon_px30.c | 3

[PATCH next 3/4] rockchip: px30: imply ARMV8_CRYPTO

2024-06-14 Thread Quentin Schulz
From: Quentin Schulz PX30 supports ARMv8 Cryptography Extensions so let's enable it by default for all PX30 to make FIT verification when enabled much faster. While A35 shouldn't be impacted by ARMV8_SET_SMPEN cache coherency according to the Kconfig help text, let's enable it just in case

[PATCH next 4/4] rockchip: puma-rk3399: add button support

2024-06-14 Thread Quentin Schulz
From: Quentin Schulz The Haikou Devkit exposes 4 buttons over GPIO so let's enable their support so their status can be queried from the `button` command from the CLI. Signed-off-by: Quentin Schulz --- configs/puma-rk3399_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configs

[PATCH next 2/4] rockchip: ringneck-px30: enable FIT verification in SPL

2024-06-14 Thread Quentin Schulz
From: Quentin Schulz This enables FIT verification in SPL for its payload (bl31, u-boot.itb, ...). This makes PX30 Ringneck match what happens on other Theobroma boards. Signed-off-by: Quentin Schulz --- configs/ringneck-px30_defconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH next 1/4] rockchip: ringneck-px30: disable broken USB gadget

2024-06-14 Thread Quentin Schulz
From: Quentin Schulz USB gadget simply doesn't work right now on PX30. Tested on PX30 EVB and PX30 Ringneck with Linux mainline and Rockchip 5.10 Linux as well as U-Boot. We don't want to our users to assume that USB gadget is supported on Q7 USB P1 on Ringneck Haikou, so let's remove its

[PATCH next 0/4] rockchip: imply ARMV8_CRYPTO on px30 + px30-ringneck/rk3399-puma defconfig changes

2024-06-14 Thread Quentin Schulz
. So disable for now to not mislead users. Additionally, add full fit support in SPL for PX30 Ringneck. Finally, add button support for Puma since its Haikou devkit exposes 4 over GPIO. Signed-off-by: Quentin Schulz --- Quentin Schulz (4): rockchip: ringneck-px30: disable broken USB gadget

Re: [PATCH v3 2/2] doc: api: bootcount: Convert to rST documentation

2024-06-14 Thread Quentin Schulz
t; (not deliberate) rather than "unattended" (unsupervised)? I understand you didn't introduce this and just migrated it to rST, so free patch to whoever feels like sending one :) Reviewed-by: Quentin Schulz Thanks! Quentin

Re: [PATCH v3 1/2] drivers: bootcount: Add support for ANY filesystem

2024-06-14 Thread Quentin Schulz
Hi Vasileios, On 6/14/24 12:02 AM, Vasileios Amoiridis wrote: Add support to save boot count variable in ANY filesystem. Tested with FAT and EXT. Reviewed-by: Tom Rini Reviewed-by: Heiko Schocher Reviewed-by: Philip Oberfichtner Signed-off-by: Vasileios Amoiridis --- doc/README.bootcount

[PATCH 2/4] boot: fix typos in help text of Kconfig configs

2024-06-12 Thread Quentin Schulz
From: Quentin Schulz This fixes a handful of typos in various help texts in Kconfig configs. Signed-off-by: Quentin Schulz --- boot/Kconfig | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/boot/Kconfig b/boot/Kconfig index 6f3096c15a6..de277d2ba50

[PATCH 3/4] doc: bootstd: fix typos

2024-06-12 Thread Quentin Schulz
From: Quentin Schulz This fixes a few syntactic issues as well as typos and grammar. Signed-off-by: Quentin Schulz --- doc/develop/bootstd.rst | 50 - 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/doc/develop/bootstd.rst b/doc

[PATCH 4/4] boot: bootflow_menu: fix crash for EFI BOOTMGR global bootmeth

2024-06-12 Thread Quentin Schulz
From: Quentin Schulz The global bootmeths don't set the dev in bootflow struct which means the dev_get_parent(bflow->dev) triggers a NULL-pointer dereference and crash U-Boot. So before trying to handle a bootflow, check that the associated bootmeth isn't global, otherwise skip it. Sugges

[PATCH 1/4] cmd: fix typo in CMD_BOOTMETH help text

2024-06-12 Thread Quentin Schulz
From: Quentin Schulz It's bootmeths and not bootmethds. Signed-off-by: Quentin Schulz --- cmd/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/Kconfig b/cmd/Kconfig index b026439c773..57929d4462d 100644 --- a/cmd/Kconfig +++ b/cmd/Kconfig @@ -308,7 +308,7

[PATCH 0/4] boot: fix crash in bootflow menu with EFI BOOTMGR support + typos

2024-06-12 Thread Quentin Schulz
pos in multiple places. Signed-off-by: Quentin Schulz --- Quentin Schulz (4): cmd: fix typo in CMD_BOOTMETH help text boot: fix typos in help text of Kconfig configs doc: bootstd: fix typos boot: bootflow_menu: fix crash for EFI BOOTMGR global bootmeth boot/Kcon

[PATCH 2/2] rockchip: puma-rk3399: get closer to other Theobroma defconfigs

2024-06-12 Thread Quentin Schulz
From: Quentin Schulz Disable support for unused OSes as Linux is the primary target. Disable support for bootz as zImage isn't a format compatible with Aarch64 machines so it should never be attempted to be booted. Enable a bunch of commands: - erofs - gpio - squashfs that could be useful

[PATCH 1/2] rockchip: ringneck-px30: get closer to other Theobroma defconfigs

2024-06-12 Thread Quentin Schulz
From: Quentin Schulz RK3588 Jaguar and Tiger, and RK3399 Puma use standard boot with the full feature set, so let's do that as well for PX30 Ringneck. Disable support for unused OSes as Linux is the primary target. Enable a bunch of commands: - boot/bootd - erofs - gpio - iminfo

[PATCH 0/2] rockchip: puma-rk3399/ringneck-px30: make closer to Jaguar/Tiger defconfigs

2024-06-12 Thread Quentin Schulz
this in the future if necessary. Also disables support for zImage on Puma since those aren't supported on Aarch64, one is supposed to use Image.gz (or any other supported compression format) with booti instead. Signed-off-by: Quentin Schulz --- Quentin Schulz (2): rockchip: ringneck-px30: get closer

Re: Shutting down of the git-daemon (git protocol, https and ssh still remain)

2024-06-12 Thread Quentin Schulz
Hi Claudius, On 6/12/24 12:20 PM, Claudius Heine wrote: Hi everyone, in the past we used cgit, which provided cloning the u-boot repo via http, https, ssh and the git protocol. When we migrated to gitlab, which doesn't support the git protocol, we implemented some additional service files

Re: [PATCH v2 1/1] drivers: bootcount: Add support for FAT filesystem

2024-06-11 Thread Quentin Schulz
Hi Vasileios, On 6/11/24 6:20 PM, Vasileios Amoiridis wrote: On Tue, Jun 11, 2024 at 10:06:59AM -0600, Tom Rini wrote: On Tue, Jun 11, 2024 at 05:41:19PM +0200, Quentin Schulz wrote: Hi Vasileios, On 6/11/24 5:27 PM, Vasileios Amoiridis wrote: On Tue, Jun 11, 2024 at 11:33:12AM +0200

Re: [PATCH v2 1/1] drivers: bootcount: Add support for FAT filesystem

2024-06-11 Thread Quentin Schulz
Hi Vasileios, On 6/11/24 5:27 PM, Vasileios Amoiridis wrote: On Tue, Jun 11, 2024 at 11:33:12AM +0200, Quentin Schulz wrote: Hi Vasileios, On 6/10/24 8:51 PM, Vasileios Amoiridis wrote: Add support to save boot count variable in a file in a FAT filesystem. Signed-off-by: Vasileios Amoiridis

Re: [PATCH v2 7/9] rockchip: Ensure memory size is available in RK3399 SPL

2024-06-11 Thread Quentin Schulz
Hi Jonas, On 6/11/24 3:43 PM, Jonas Karlman wrote: Hi Simon and Quentin, On 2024-06-11 13:27, Quentin Schulz wrote: Hi Simon, On 6/10/24 4:59 PM, Simon Glass wrote: At present gd->ram_size is 0 in SPL, meaning that it is not possible to enable the cache. Correct this by always populat

[PATCH v2 3/4] dm: core: migrate debug() messages to use dm_warn

2024-06-11 Thread Quentin Schulz
From: Quentin Schulz Prior to that, seeing the debug() messages required to enable DM_DEBUG which defines DEBUG (and then _DEBUG) which in turn makes failing assert() calls reset U-Boot which isn't necessarily what is desired. Instead, let's migrate to dm_warn which is using log_debug when

[PATCH v2 2/4] dm: core: fix signedness in debug messages

2024-06-11 Thread Quentin Schulz
From: Quentin Schulz outp always point to an unsigned type in ofnode_read_u* functions but the format specifier is currently always using signed type. This is an issue since the signed type can only contain half of the unsigned type values above 0. However, this now breaks another usecase

[PATCH v2 4/4] dm: core: fix typo in SPL_DM_WARN prompt text

2024-06-11 Thread Quentin Schulz
From: Quentin Schulz It should read "in SPL" and not "wuth SPL". Signed-off-by: Quentin Schulz --- drivers/core/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/core/Kconfig b/drivers/core/Kconfig index 1081d61fcf0..e4b1a66ecb1 10064

[PATCH v2 0/4] dm: core: fix several debug messages and migrate debug() to dm_warn

2024-06-11 Thread Quentin Schulz
but it applies without complaints on top of master as well, so up to you to which branch to merge it. Signed-off-by: Quentin Schulz --- Changes in v2: - add missing dm/util.h header includes - Link to v1: https://lore.kernel.org/r/20240610-misc-20240610-v1-0-6914f1725...@cherry.de --- Quentin Schulz (4

[PATCH v2 1/4] dm: core: fix misleading debug message when matching compatible

2024-06-11 Thread Quentin Schulz
From: Quentin Schulz A driver can have multiple compatible. When the id->compatible matches for that driver, the first compatible supported by the driver is currently returned, which gives the following confusing message: - found match at 'rk3588_syscon': 'rockchip,rk3588-sys-grf' matc

Re: [PATCH v2 7/9] rockchip: Ensure memory size is available in RK3399 SPL

2024-06-11 Thread Quentin Schulz
Hi Simon, On 6/10/24 4:59 PM, Simon Glass wrote: At present gd->ram_size is 0 in SPL, meaning that it is not possible to enable the cache. Correct this by always populating the RAM size correctly. Part of the confusion here comes from the large blocks of code which are #ifdefed out. Add a

Re: [PATCH v2 1/1] drivers: bootcount: Add support for FAT filesystem

2024-06-11 Thread Quentin Schulz
Hi Vasileios, On 6/10/24 8:51 PM, Vasileios Amoiridis wrote: > Add support to save boot count variable in a file in a FAT filesystem. > > Signed-off-by: Vasileios Amoiridis > --- > doc/README.bootcount | 12 ++--- > drivers/bootcount/Kconfig | 53

Re: [PATCH v2 3/9] rockchip: veyron: Add logging for power init

2024-06-10 Thread Quentin Schulz
Hi Simon, On 6/10/24 4:59 PM, Simon Glass wrote: Add better logging for power init so that CONFIG_LOG_ERROR_RETURN can be enabled. Signed-off-by: Simon Glass Reviewed-by: Quentin Schulz Thanks! Quentin

[PATCH] smbios: only look for a SYSINFO udevice if SYSINFO support is enabled

2024-06-10 Thread Quentin Schulz
From: Quentin Schulz If SYSINFO support isn't enabled, it's a given that uclass_first_device for UCLASS_SYSINFO will not find anything, therefore let's skip the test entirely. This allows to get rid of the following debug message that may be confusing: Cannot find uclass for id 118: please add

[PATCH] cmd: sound: fix help text

2024-06-10 Thread Quentin Schulz
From: Quentin Schulz There's never been a -q or -s argument handled in the command, so let's remove it. This was highlighted during review[1] but somehow still got through. While at it, slightly "reword" in the help text how the len + freq arguments are defined. Indeed, len and

  1   2   3   4   5   6   7   8   9   10   >