Re: [U-Boot] Rockchip patches for testing

regulator/pwm_regulator.c:135:10: error: 'struct > pwm_regulator_info' has no member named 'boot_on' > + if (priv->boot_on) > + ^ > +make[2]: *** [drivers/power/regulator/pwm_regulator.o] Error 1 > +make[1]: *** [drivers/power/regulator] Error 2 > +make: *** [sub-mak

Re: [U-Boot] disabling mmc in spl when booting using bootrom

> > My concern with the Rockchip back-to-brom feature is that then U-Boot > cannot load U-Boot normally as SPL likes to do. I think it is fine > when we are short on space, but OF_PLATDATA fixes that. > > So I think the back-to-rom feature need to be optional on boards which > don't have to use

Re: [U-Boot] [PATCH v2 0/3] Add sdram capacity auto detect for rk3288

On Tue, Sep 20, 2016 at 10:56 PM, Kever Yang wrote: > > parameters changes from dts to auto-detect including those I removed from > dts and ddrconfig, stride, they should be the same as without my patch, > which means my patch suppose to not change any parameter for DDR

Re: [U-Boot] [PATCH v2 1/3] rk3288: config change for enable dram capacity auto-detect.

On Tue, Sep 20, 2016 at 11:00 PM, Kever Yang <kever.y...@rock-chips.com> wrote: > Hi Sandy, > > On 09/20/2016 09:21 PM, Sandy Patterson wrote: > > You're probably going to need to change this around now that the Kconfig > stuff has been applied to master. Suggest followin

Re: [U-Boot] [PATCH v2 0/3] Add sdram capacity auto detect for rk3288

I can confirm that this boots on rock2 with current master branch. 9b1b6d42256a4c2e59c803afdbf90d39371e61ba It doesn't boot for me using rock2 on v2016.09 tag. I get: U-Boot SPL 2016.09-2-g690a8a3 (Sep 20 2016 - 10:47:44) Trying to boot from MMC1 It continues to detect 2GB of ram. on master.

Re: [U-Boot] [PATCH v2 1/3] rk3288: config change for enable dram capacity auto-detect.

You're probably going to need to change this around now that the Kconfig stuff has been applied to master. Suggest following patch instead: diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig index 1aac3c8..dc471d6 100644 --- a/arch/arm/mach-rockchip/Kconfig +++

Re: [U-Boot] [PATCH 0/2] Add sdram capacity auto detect for rk3288

> > 1) It seems the BACK_TO_BROM feature is broken. It doesn't boot using the >> 2016.09. I'm afraid I don't have the time to track it down. >> > It works fine on my evb, do you flash the image correctly? it's different > with the way you don't use BACK_TO_BROM. > Well, I tested again on the

Re: [U-Boot] [PATCH 0/2] Add sdram capacity auto detect for rk3288

Hi Kever and Vagrant, I tested this patch on my rock2 board against 2016.09. (I didn't have my board with me over the weekend) 1) It seems the BACK_TO_BROM feature is broken. It doesn't boot using the 2016.09. I'm afraid I don't have the time to track it down. 2) It seems the SPL is still small

Re: [U-Boot] [PATCH 0/2] Add sdram capacity auto detect for rk3288

not be getting any output because you didn't modify your burning process. See the README.rockchip section on CONFIG_ROCKCHIP_SPL_BACK_TO_BROM for details, but you have to dd your images slightly differently with this macro enabled. Also, you might get more info from Ziyuan's DEBUG advice. Sandy

[U-Boot] [PATCH v3 2/2] Enable ROCKCHIP_SPL_BACK_TO_BROM for rock2 board

before 1M boundary Signed-off-by: Sandy Patterson <apatter...@sightlogix.com> --- Changes in v3: - Move activate in rock2_defconfig to proper commit. - Make environment changes dependent on ROCKCHIP_SPL_BACK_TO_BROM. Changes in v2: None configs/rock2_defconfig | 2 +- include/configs/rock2

[U-Boot] [PATCH v3 1/2] Disable SPL_MMC_SUPPORT if ROCKCHIP_SPL_BACK_TO_BROM is enabled.

Default SPL_MMC_SUPPORT to false when ROCKCHIP_SPL_BACK_TO_BROM is enabled. Acked-by: Ziyuan Xu <xzy...@rock-chips.com> Signed-off-by: Sandy Patterson <apatter...@sightlogix.com> --- Changes in v3: - Move activate in rock2_defconfig to proper commit. Changes in v2: - Rebase af

[U-Boot] [PATCH v3 0/2] With this change the SPL binary shrinks from 32k to 23k when

"Kconfig: Move CONFIG_SPL_..._SUPPORT to Kconfig." - Remove all the refactoring in the configs. - Split enabling featuring in rock2 into separate commit. Sandy Patterson (2): Disable SPL_MMC_SUPPORT if ROCKCHIP_SPL_BACK_TO_BROM is enabled. Enable ROCKCHIP_SPL_BACK_TO_BROM for rock2 board

Re: [U-Boot] [PATCH v2 2/2] Enable ROCKCHIP_SPL_BACK_TO_BROM for rock2 board

On Sun, Aug 28, 2016 at 10:01 PM, Ziyuan Xu <xzy...@rock-chips.com> wrote: > Hi, > > > On 2016年08月28日 03:39, Sandy Patterson wrote: > >> Rock2 has been tested with back to brom feature. The tricky part is that >> with this feature the default environment is i

[U-Boot] [PATCH v2 1/2] Disable SPL_MMC_SUPPORT if ROCKCHIP_SPL_BACK_TO_BROM is enabled.

Default SPL_MMC_SUPPORT to false when ROCKCHIP_SPL_BACK_TO_BROM is enabled. Signed-off-by: Sandy Patterson <apatter...@sightlogix.com> --- Changes in v2: - Rebase after "Kconfig: Move CONFIG_SPL_..._SUPPORT to Kconfig." - Remove all the refactoring in the configs. - Split en

[U-Boot] [PATCH v2 0/2] With this change the SPL binary shrinks from 32k to 23k when

g in rock2 into separate commit. Sandy Patterson (2): Disable SPL_MMC_SUPPORT if ROCKCHIP_SPL_BACK_TO_BROM is enabled. Enable ROCKCHIP_SPL_BACK_TO_BROM for rock2 board arch/arm/mach-rockchip/Kconfig | 3 +++ configs/rock2_defconfig| 2 +- include/configs/rock2.h| 8 3 files

[U-Boot] [PATCH v2 2/2] Enable ROCKCHIP_SPL_BACK_TO_BROM for rock2 board

-by: Sandy Patterson <apatter...@sightlogix.com> --- Changes in v2: None include/configs/rock2.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/configs/rock2.h b/include/configs/rock2.h index ee924c3..946367f 100644 --- a/include/configs/rock2.h +++ b/i

Re: [U-Boot] [PATCH 4/4] RK3288 needs fdt and initrd below 256M now.

On Sat, Aug 27, 2016 at 12:06 PM, Simon Glass <s...@chromium.org> wrote: > Hi Sandy, > > On 11 July 2016 at 11:38, Sandy Patterson <apatter...@sightlogix.com> > wrote: > > I am not sure why this limit is changing. But my kernel > > doesn't load w

Re: [U-Boot] [PATCH] rockchip: Disable SPL_MMC_SUPPORT if ROCKCHIP_SPL_BACK_TO_BROM is enabled.

On Wed, Aug 24, 2016 at 9:27 AM, Sandy Patterson <apatter...@sightlogix.com> wrote: > > On Fri, Aug 12, 2016 at 8:59 PM, Sandy Patterson < > apatter...@sightlogix.com> wrote: > >> CONFIG_SPL_MMC_SUPPORT is used pretty much for every board except jerry, &g

Re: [U-Boot] [PATCH] rockchip: Disable SPL_MMC_SUPPORT if ROCKCHIP_SPL_BACK_TO_BROM is enabled.

On Fri, Aug 12, 2016 at 8:59 PM, Sandy Patterson <apatter...@sightlogix.com> wrote: > CONFIG_SPL_MMC_SUPPORT is used pretty much for every board except jerry, > so we can refactor the define into rk3288_common.h. Then only define it if > we are using using the Bootrom to load the

[U-Boot] [PATCH] rockchip: Disable SPL_MMC_SUPPORT if ROCKCHIP_SPL_BACK_TO_BROM is enabled.

is enabled. This has been tested on the rock2 board. It should work with any rk3288 though since the bootrom is loading the SPL already it should load the main U-Boot as well. Rock2 has been tested with ROCKCHIP_SPL_BACK_TO_BROM So enabled for rock2. Signed-off-by: Sandy Patterson <apat

Re: [U-Boot] disabling mmc in spl when booting using bootrom

On Fri, Aug 12, 2016 at 1:20 PM, Simon Glass <s...@chromium.org> wrote: > Hi Ziyuan, > > On 11 August 2016 at 05:35, Ziyuan Xu <xzy...@rock-chips.com> wrote: > > > > > > On 2016年08月11日 19:31, Sandy Patterson wrote: > >> > >> Simon, > >

[U-Boot] disabling mmc in spl when booting using bootrom

Simon, I am trying to format a patch to disable MMC in the SPL if booting main u-boot using BOOTROM, therefore the SPL MMC isn't needed. Is the best solution to wrap every header file (rock2.h firefly-rk3288.h, etc) with ifdefs on the BACK_TO_BROM define? Or would it be better to move the SPL

Re: [U-Boot] disabling mmc in spl when booting using bootrom

On Thu, Aug 11, 2016 at 7:35 AM, Ziyuan Xu <xzy...@rock-chips.com> wrote: > > > On 2016年08月11日 19:31, Sandy Patterson wrote: > >> Simon, >> >> I am trying to format a patch to disable MMC in the SPL if booting main >> u-boot using BOOTROM, therefore t

Re: [U-Boot] [PATCH] rockchip: Fix SPL console output when ROCKCHIP_SPL_BACK_TO_BROM is enabled

On Wed, Aug 10, 2016 at 11:01 PM, Ziyuan Xu <xzy...@rock-chips.com> wrote: > > > On 2016年08月10日 22:21, Sandy Patterson wrote: > >> Move back_to_bootrom() call later in SPL init so that the console is >> initialized and printouts happen. >> >> Currently

[U-Boot] [PATCH] rockchip: Fix SPL console output when ROCKCHIP_SPL_BACK_TO_BROM is enabled

spl_board_init, then go back to bootrom there after preloader_console_init(). Otherwise fall back to old behavior of doing it in board_init_f. Signed-off-by: Sandy Patterson <apatter...@sightlogix.com> --- arch/arm/mach-rockchip/rk3288-board-spl.c | 5 - 1 file changed, 4 insertions(+), 1 de

Re: [U-Boot] [PATCH v2 3/3] CONFIG_EFI_LOADER breaks rock2 kernel loading

hich Tom had merge it into u-boot/master. > > > On 2016年08月09日 05:43, Simon Glass wrote: > >> Hi Sandy, >> >> On 22 July 2016 at 08:40, Sandy Patterson <apatter...@sightlogix.com> >> wrote: >> >>> The problem seems to be invalidate_icache_all()

Re: [U-Boot] [PATCH] ARM: Rework and correct barrier definitions

Works for me on rock2. Thanks for the fix. Acked-by: Sandy Patterson <apatter...@sightlogix.com> On Mon, Aug 1, 2016 at 8:39 PM, Tom Rini <tr...@konsulko.com> wrote: > On Tue, Aug 02, 2016 at 08:37:19AM +0800, Ziyuan Xu wrote: > > Hi Tom, > > > > > &g

[U-Boot] [PATCH] rockchip: rockchip, sdram-channel 0xff fix remaining dts

Add an extra byte so that this data is not byteswapped. Signed-off-by: Sandy Patterson <apatter...@sightlogix.com> --- arch/arm/dts/rk3288-rock2-square.dts | 2 +- arch/arm/dts/rk3288-veyron.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/dts/

Re: [U-Boot] [PATCH] arm: re-implement proper ISB instruction for ARMv7-A

with the EFI parts compiled in. I don't believe anyone has tested the functionality of EFI wtih rk3288. Sandy Patterson On Thu, Jul 28, 2016 at 8:03 AM, Ziyuan Xu <xzy...@rock-chips.com> wrote: > Hi Alexander, > > On 2016年07月28日 18:39, Alexander Graf wrote: > >> On 07/28/2016 1

Re: [U-Boot] [issue report] mainline u-boot was stuck before booting kernel

e the MMU from the >> each processor followed by an ISB to ensure the MMU disable operation is >> complete, then followed by a DSB to drain previous memory transactions." >> >> In my humble opinion, maybe instructions tlb had alter, and cause running >> away??? I'm not sure ab

Re: [U-Boot] [issue report] mainline u-boot was stuck before booting kernel

Ah, thanks. Your debugging looks the same as what I've seen from printf debugging. I'll try to verify though. On Mon, Jul 25, 2016 at 10:58 AM, Ziyuan Xu wrote: > hi Stany, > > The difference is that you print out assertion log. > > Reset not supported on this platform >

Re: [U-Boot] [PATCH v2 1/3] Revert "arm: Replace v7_maint_dcache_all(ARMV7_DCACHE_CLEAN_INVAL_ALL) with asm code"

I see the problem with 4.7-rc6. Is there a different kernel I should test with? On Fri, Jul 22, 2016 at 4:39 PM, Tom Rini <tr...@konsulko.com> wrote: > On Fri, Jul 22, 2016 at 10:40:11AM -0400, Sandy Patterson wrote: > > > Commit c09d29057a and df120142f36 break kernel load

[U-Boot] [PATCH v2 3/3] CONFIG_EFI_LOADER breaks rock2 kernel loading

The problem seems to be invalidate_icache_all() inside the runtime. This patch just disables EFI_LOADER for rock2 board. Signed-off-by: Sandy Patterson <apatter...@sightlogix.com> --- configs/rock2_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/rock2_defconfig b/c

[U-Boot] [PATCH v2 0/3] Fix loading kernel on RK3288 Radxa Rock2 Square

with with 3.14 adn 4.7-rc6 kernels. I used gcc-linaro-5.3-2016.02-x86_64_arm-linux-gnueabi. Before fixing, the console output was: Starting kernel ... ### ERROR ### Please RESET the board ### Changes for v2: - Remove patch to change to high mem limit. - Rebase to u-boot/master. Sandy Patterson (3

[U-Boot] [PATCH v2 2/3] Revert "arm: Replace v7_maint_dcache_all(ARMV7_DCACHE_INVAL_ALL) with asm code"

/cache_v7_asm.S Signed-off-by: Sandy Patterson <apatter...@sightlogix.com> --- arch/arm/cpu/armv7/cache_v7.c | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/arch/arm/cpu/armv7/cache_v7.c b/arch/arm/cpu/armv7/cache_v7.c index 9fbabb4..e72bed5 100644 --- a/ar

[U-Boot] [PATCH v2 1/3] Revert "arm: Replace v7_maint_dcache_all(ARMV7_DCACHE_CLEAN_INVAL_ALL) with asm code"

/cache_v7_asm.S Signed-off-by: Sandy Patterson <apatter...@sightlogix.com> --- arch/arm/cpu/armv7/Makefile | 2 +- arch/arm/cpu/armv7/cache_v7.c| 114 +++- arch/arm/cpu/armv7/cache_v7_asm.S| 154 --- arch/ar

Re: [U-Boot] [PATCH 0/4] Ability to load linux kernel on rock2 RK3288

: 1781acd31b01225402167fbdb8fa97157cc269eb CONFIG_EFI_LOADER=n and cache reverts required to load kernel *_high changes don't seem to be required anymore Sandy Patterson On Thu, Jul 21, 2016 at 11:21 PM, Simon Glass <s...@chromium.org> wrote: > +Hans, Tom > > Hi Sandy, > > On 15 July 2016 at 0

Re: [U-Boot] [PATCH 0/4] Ability to load linux kernel on rock2 RK3288

:19 PM, Simon Glass <s...@chromium.org> wrote: > HI Sandy, > > On 13 July 2016 at 11:51, Sandy Patterson <apatter...@sightlogix.com> > wrote: > > I did a little more on this, and talked to someone else here. It seems > that > > my problem with loading the ker

Re: [U-Boot] [PATCH 0/4] Ability to load linux kernel on rock2 RK3288

. We're left with the puzzle of what's wrong on the RK3288 regarding caching and memory. Sandy Patterson On Mon, Jul 11, 2016 at 1:38 PM, Sandy Patterson <apatter...@sightlogix.com> wrote: > I wasn't able to load the linux kernel using a Rock2 board > using the latest master branc

[U-Boot] [PATCH 3/4] Disable CONFIG_EFI_LOADER for rock2.

I'm not sure why this breaks kernel loading. Signed-off-by: Sandy Patterson <apatter...@sightlogix.com> --- configs/rock2_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/rock2_defconfig b/configs/rock2_defconfig index 3e16b80..3a06b7e 100644 --- a/configs/rock2_def

[U-Boot] [PATCH 4/4] RK3288 needs fdt and initrd below 256M now.

I am not sure why this limit is changing. But my kernel doesn't load when it's above 256. This was testing on the rock2 board. Signed-off-by: Sandy Patterson <apatter...@sightlogix.com> --- include/configs/rk3288_common.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[U-Boot] [PATCH 2/4] Revert "arm: Replace v7_maint_dcache_all(ARMV7_DCACHE_INVAL_ALL) with asm code"

This reverts commit df120142f36b6ff8b12187b8860269763b2b3203. Conflicts: arch/arm/cpu/armv7/cache_v7.c arch/arm/cpu/armv7/cache_v7_asm.S Signed-off-by: Sandy Patterson <apatter...@sightlogix.com> --- arch/arm/cpu/armv7/cache_v7.c | 24 +--- 1 file c

[U-Boot] [PATCH 1/4] Revert "arm: Replace v7_maint_dcache_all(ARMV7_DCACHE_CLEAN_INVAL_ALL) with asm code"

This reverts commit c09d29057ab0b04db0857d319c6bff74de31b9c3. Conflicts: arch/arm/cpu/armv7/cache_v7.c arch/arm/cpu/armv7/cache_v7_asm.S Signed-off-by: Sandy Patterson <apatter...@sightlogix.com> --- arch/arm/cpu/armv7/Makefile | 2 +- arch/arm/cpu

[U-Boot] [PATCH 0/4] Ability to load linux kernel on rock2 RK3288

volages correctly, but at least the Kernel is loading. I also am not sure changing the caching for all armv7 is the right answer. I wasn't too sure about the revert. I am not very familiar with this low level stuff. Sandy Patterson Sandy Patterson (4): Revert "arm: Replace v7_maint_dcach

[U-Boot] Radxa Rock2 square bug report (kernel won't load)

. Just a friendly bug report. Good luck, Sandy Patterson U-Boot SPL 2016.05 (Jun 28 2016 - 09:57:30) Trying to boot from MMC1 I see a similar log in master: U-Boot 2016.05 (Jun 28 2016 - 09:57:30 -0400) Model: Radxa Rock 2 Square DRAM: 2 GiB MMC: dwmmc@ff0f: 0, dwmmc@ff0c: 1 ** First