Re: [PATCH v4 00/21] qcom: rpmh core and regulator support

2024-07-10 Thread Sumit Garg
ing this, this looks much better from a maintainability perspective. Although I am seeing a lot of patches saying adjustments and build fixes, I think you should have taken care of commits bisect-ability such that individual commits don't cause any build errors. FWIW, for the series: Acked-by: Sumit

Re: [PATCH 2/3] soc: qcom: rpmh and cmd-db drivers

2024-07-08 Thread Sumit Garg
Hi Caleb, On Mon, 8 Jul 2024 at 16:13, Caleb Connolly wrote: > > Hi Sumit, > > Sorry for the late response. > > In general, I'd rather keep this port closer to the Linux original, so > that future cherry-picking of new features and fixes is easier. This is > quite standard practice in U-Boot

Re: [PATCH 0/3] rockchip: enable PCIe/NVMe support for Theobroma RK3588 devices

2024-07-04 Thread Sumit Garg
+++ > 3 files changed, 68 insertions(+) FWIW, for the series: Acked-by: Sumit Garg -Sumit > --- > base-commit: 0f073e022ddc5070e5df1d053e4bdc1874fbcc0f > change-id: 20240704-tsd-rk3588-nvme-aa133c24cb9e > > Best regards, > -- > Quentin Schulz >

Re: [PATCH] mach-snapdragon: move default environment to a file

2024-06-21 Thread Sumit Garg
On Fri, 21 Jun 2024 at 15:14, Caleb Connolly wrote: > > > > On 21/06/2024 10:07, Sumit Garg wrote: > > On Fri, 21 Jun 2024 at 13:19, Caleb Connolly > > wrote: > >> > >> > >> > >> On 21/06/2024 09:35, Sumit Garg wrote: > >>

Re: [PATCH 2/3] soc: qcom: rpmh and cmd-db drivers

2024-06-21 Thread Sumit Garg
Hi Caleb, On Mon, 17 Jun 2024 at 14:02, Caleb Connolly wrote: > > Introduce two Qualcomm SoC drivers, the RPMh and cmd-db. RPMh is a the > name for the second generation Resource Power Management hub on Qualcomm > SoCs. Most core regulators have to be controlled via this hub. > > The cmd-db is a

Re: [PATCH] mach-snapdragon: move default environment to a file

2024-06-21 Thread Sumit Garg
On Fri, 21 Jun 2024 at 13:19, Caleb Connolly wrote: > > > > On 21/06/2024 09:35, Sumit Garg wrote: > > Hi Caleb, > > > > On Mon, 17 Jun 2024 at 14:26, Caleb Connolly > > wrote: > >> > >> Make use of CONFIG_DEFAULT_ENV_FILE and move t

Re: [PATCH] mach-snapdragon: move default environment to a file

2024-06-21 Thread Sumit Garg
Hi Caleb, On Mon, 17 Jun 2024 at 14:26, Caleb Connolly wrote: > > Make use of CONFIG_DEFAULT_ENV_FILE and move the default qcom > environment to a file under board/qualcomm. > > This is much cleaner and means we don't need to recompile on changing > the environment. > > Additionally, extend the

Re: [PATCH] dt-bindings: imx: Drop redundant imports with dts/upstream

2024-06-19 Thread Sumit Garg
On Wed, 19 Jun 2024 at 18:51, Michael Nazzareno Trimarchi wrote: > > Hi > > On Wed, Jun 19, 2024 at 3:07 PM Sumit Garg wrote: > > > > On Wed, 19 Jun 2024 at 18:26, Adam Ford wrote: > > > > > > On Wed, Jun 19, 2024 at 7:53 AM Sumit Garg wrote: >

Re: [PATCH v2] Makefile: Fix include directory for OF_UPSTREAM

2024-06-17 Thread Sumit Garg
Hi Michael, Sorry for the delayed response as I had some health issues last week. On Thu, 13 Jun 2024 at 12:44, Michael Nazzareno Trimarchi wrote: > > Hi Sumit > > On Thu, Jun 13, 2024 at 9:02 AM Sumit Garg wrote: > > > > On Mon, 3 Jun 2024 at 20:38, Pat

Re: [PATCH v2] Makefile: Fix include directory for OF_UPSTREAM

2024-06-13 Thread Sumit Garg
On Mon, 3 Jun 2024 at 20:38, Patrick Barsanti wrote: > > Always prioritizing u-boot includes causes problems when trying to migrate > boards to OF_UPSTREAM that have different local devicetree files with > respect to the upstream ones, if local DT headers are not dropped. > At the same time if

Re: [PATCH v3 0/8] qcom: implement capsule updates

2024-06-06 Thread Sumit Garg
On Wed, 5 Jun 2024 at 18:12, Caleb Connolly wrote: > > Hi Sumit, > > On 05/06/2024 07:31, Sumit Garg wrote: > > Hi Caleb, > > > > On Mon, 3 Jun 2024 at 18:19, Caleb Connolly > > wrote: > >> > >> Hook up support for capsule updates loade

Re: [PATCH v3 4/8] mach-snapdragon: implement capsule update support

2024-06-06 Thread Sumit Garg
On Wed, 5 Jun 2024 at 18:03, Caleb Connolly wrote: > > Hi Sumit, > >> +/** > >> + * qcom_configure_capsule_updates() - Configure the DFU string for > >> capsule updates > >> + * > >> + * U-Boot is flashed to the boot partition on Qualcomm boards. In most > >> cases there > >> + * are two boot

Re: [PATCH v4 00/10] add ArmSoM Sige7 Rk3588 board

2024-06-06 Thread Sumit Garg
arm64: dts: rockchip: add USBDP phys on rk3588 > arm64: dts: rockchip: add USB3 DRD controllers on rk3588 > Nice to see cherry pick from subtree worked as expected for you. FWIW, for the series: Acked-by: Sumit Garg -Sumit > MAINTAINERS | 1 +

Re: [PATCH v3 0/8] qcom: implement capsule updates

2024-06-04 Thread Sumit Garg
To: Simon Glass > To: Lukasz Majewski > To: Mattijs Korpershoek > To: Caleb Connolly > To: Neil Armstrong > To: Sumit Garg > Cc: Ilias Apalodimas > Cc: u-boot@lists.denx.de > Cc: u-boot-q...@groups.io > > Changes in v3: > - Address comments in scsi dfu support >

Re: [PATCH v3 4/8] mach-snapdragon: implement capsule update support

2024-06-04 Thread Sumit Garg
Hi Caleb, On Mon, 3 Jun 2024 at 18:19, Caleb Connolly wrote: > > Qualcomm boards flash U-Boot to the boot partition, implement support > for determining which slot U-Boot is running from and finding the > correct boot partition for that slot and configuring the appropriate DFU > string. > > For

Re: [PATCH] Makefile: Fix include directory for OF_UPSTREAM

2024-05-30 Thread Sumit Garg
On Thu, 30 May 2024 at 14:43, Patrick Barsanti wrote: > > Hi Sumit, > > On Wed, 29 May 2024 at 14:00, Sumit Garg wrote: >> >> On Wed, 29 May 2024 at 14:45, Patrick Barsanti >> wrote: >> > >> > Hi Sumit, >> > >> > On We

Re: [PATCH] Makefile: Fix include directory for OF_UPSTREAM

2024-05-29 Thread Sumit Garg
On Wed, 29 May 2024 at 14:45, Patrick Barsanti wrote: > > Hi Sumit, > > On Wed, 29 May 2024 at 08:57, Sumit Garg wrote: >> >> Hi Patrick, >> >> On Tue, 28 May 2024 at 14:16, Patrick Barsanti >> wrote: >> > >> > Always prioritizing

Re: [PATCH] Makefile: Fix include directory for OF_UPSTREAM

2024-05-29 Thread Sumit Garg
Hi Patrick, On Tue, 28 May 2024 at 14:16, Patrick Barsanti wrote: > > Always prioritizing u-boot includes causes problems when trying to > migrate boards to OF_UPSTREAM that have divergent devicetree files with > respect to the upstream ones. > > For example, migrating a board based on

Re: [PATCH 5/5] pinctrl: qcom: sm8650: add special pins pins configuration data

2024-05-29 Thread Sumit Garg
pinctrl-sm8650.c | 42 > --- > 1 file changed, 34 insertions(+), 8 deletions(-) > Reviewed-by: Sumit Garg -Sumit > diff --git a/drivers/pinctrl/qcom/pinctrl-sm8650.c > b/drivers/pinctrl/qcom/pinctrl-sm8650.c > index d6cc1bbdda8..58fc94e71ac 100644 > --- a/drivers/pinctrl/qcom/pin

Re: [PATCH 4/5] pinctrl: qcom: sm8550: add special pins pins configuration data

2024-05-29 Thread Sumit Garg
pinctrl-sm8550.c | 42 > --- > 1 file changed, 34 insertions(+), 8 deletions(-) > Reviewed-by: Sumit Garg -Sumit > diff --git a/drivers/pinctrl/qcom/pinctrl-sm8550.c > b/drivers/pinctrl/qcom/pinctrl-sm8550.c > index 7265cb73404..c65dfe0435e 100644 > --- a/drivers/pinctrl/qcom/pin

Re: [PATCH 3/5] pinctrl: qcom: add support setting pin configuration for special pins

2024-05-29 Thread Sumit Garg
m/pinctrl-qcom.c | 37 > +++-- > 1 file changed, 35 insertions(+), 2 deletions(-) > Reviewed-by: Sumit Garg -Sumit > diff --git a/drivers/pinctrl/qcom/pinctrl-qcom.c > b/drivers/pinctrl/qcom/pinctrl-qcom.c > index 4f4e9a83949..26a3fba194a 100644 > --- a/drivers/p

Re: [PATCH 2/5] arm: mach-snapdragon: gpio: introduce msm_special_pin_data

2024-05-29 Thread Sumit Garg
d to the pins_data to allow specifying the special > pins data for each SoC. > > Signed-off-by: Neil Armstrong > --- > arch/arm/mach-snapdragon/include/mach/gpio.h | 16 +++- > 1 file changed, 15 insertions(+), 1 deletion(-) > Reviewed-by: Sumit Garg -Sumit

Re: [PATCH 1/5] pinctrl: qcom: add support for bias-pull-down

2024-05-28 Thread Sumit Garg
Hi Neil, On Tue, 28 May 2024 at 14:02, Neil Armstrong wrote: > > Add support for bias-pull-down as an alternate of bias-pull-up. nit: s/alternate/alternative/ > > Signed-off-by: Neil Armstrong > --- > drivers/pinctrl/qcom/pinctrl-qcom.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [PATCH 2/2] ARM: dts: renesas: Drop R8A779H0 V4M DTs with OF_UPSTREAM counterparts

2024-05-26 Thread Sumit Garg
gned-off-by: Marek Vasut > --- > Cc: Adam Ford > Cc: Hai Pham > Cc: Paul Barker > Cc: Sumit Garg > Cc: Tom Rini > Cc: u-boot@lists.denx.de > --- > arch/arm/dts/Makefile | 3 - > arch/arm/dts/r8a779h0-gray-hawk-cpu.dtsi | 166 ---

Re: [PATCH 1/2] ARM: dts: renesas: Switch to using upstream DT on Renesas R8A779H0 V4M

2024-05-26 Thread Sumit Garg
is patch finalizes OF_UPSTREAM conversion of R8A779H0 V4M which DTs > landed in Linux 6.9 . > > Signed-off-by: Marek Vasut > --- > Cc: Adam Ford > Cc: Hai Pham > Cc: Paul Barker > Cc: Sumit Garg > Cc: Tom Rini > Cc: u-boot@lists.denx.de > --- > configs/r8a779h0_gra

Re: [PATCH] arm: exynos: Migrate E850-96 board to OF_UPSTREAM

2024-05-23 Thread Sumit Garg
rl.dtsi > delete mode 100644 arch/arm/dts/exynos850.dtsi > delete mode 100644 > doc/device-tree-bindings/clock/samsung,exynos850-clock.yaml > delete mode 100644 doc/device-tree-bindings/soc/samsung/exynos-usi.yaml > delete mode 100644 include/dt-bindings/clock/exynos850.h > delete

Re: [PATCH v2 2/5] dt-bindings: clock: qcom: ipq4019: drop downstream file

2024-05-23 Thread Sumit Garg
Changes in v2: > * Drop the downstream dt-bindings header as it matches the upstream Linux one > > include/dt-bindings/clock/qcom,gcc-ipq4019.h | 169 --- > 1 file changed, 169 deletions(-) > delete mode 100644 include/dt-bindings/clock/qcom,gcc-ipq4019.h > Reviewed-by: Sumi

Re: [PATCH v2] arm: dts: k3-j7200: Move to OF_UPSTREAM

2024-05-23 Thread Sumit Garg
; delete mode 100644 arch/arm/dts/k3-j7200-som-p0.dtsi > delete mode 100644 arch/arm/dts/k3-j7200-thermal.dtsi > delete mode 100644 arch/arm/dts/k3-j7200.dtsi > Acked-by: Sumit Garg -Sumit > diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile > index f7032f1e175..ea8fee8e25c 10

Re: [PATCH v2] board: rockchip: add ArmSoM Sige7 Rk3588 board

2024-05-23 Thread Sumit Garg
On Wed, 22 May 2024 at 23:33, Quentin Schulz wrote: > > Hi Jianfeng Liu, > > On 5/22/24 6:58 PM, Jianfeng Liu wrote: > [...] > > Note that these commits: > > - e18e5e8188f2 (arm64: dts: rockchip: add USBDP phys on rk3588) > > - 6fca4edb93d3 (arm64: dts: rockchip: Add rk3588 GPU node) > > are not

Re: [PATCH] arm: dts: mvebu: Migrate to upstream DT for Synology DS116 (Armada 385) board

2024-05-23 Thread Sumit Garg
> arch/arm/dts/Makefile | 1 - > arch/arm/dts/armada-385-synology-ds116.dts | 291 - > configs/ds116_defconfig| 3 +- > 3 files changed, 2 insertions(+), 293 deletions(-) > delete mode 100644 arch/arm/dts/armada-385-synology-ds116.dts > A

Re: [PATCH FOR TESTING ONLY RFC 4/4] sunxi-d1s-t113: Add D1 and T113 PWM node

2024-05-20 Thread Sumit Garg
On Sat, 18 May 2024 at 09:25, John Watts wrote: > > This is based on the binding from the as yet unmerged kernel series: > > https://lore.kernel.org/linux-kernel/20240131125920.2879433-2-privates...@gmail.com/ > > Signed-off-by: John Watts > --- > arch/riscv/dts/sunxi-d1s-t113.dtsi

Re: [RESEND PATCH 4/4] omap3: igep0x00: Migrate to use upstream DT

2024-05-20 Thread Sumit Garg
00644 arch/arm/dts/omap3-igep0020-common.dtsi > delete mode 100644 arch/arm/dts/omap3-igep0020.dts > Acked-by: Sumit Garg -Sumit > diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile > index a5c82ebf7a5f..a9bd4921718e 100644 > --- a/arch/arm/dts/Makefile > +++ b/

Re: [PATCH 08/10] dts/upsteam: Add Makefile for xtensa

2024-05-20 Thread Sumit Garg
On Mon, 20 May 2024 at 02:24, Jiaxun Yang wrote: > > It is required to get it xtensa OF_UPSTREAM work. > > Signed-off-by: Jiaxun Yang > --- > dts/upstream/src/xtensa/Makefile | 14 ++ > 1 file changed, 14 insertions(+) > Reviewed-by: Sumit Garg -Sumit >

Re: [PATCH] ARM: dts: renesas: Reserve space in 64bit R-Car DTs

2024-05-20 Thread Sumit Garg
s behavior in arch/arm/dts/Makefile with OF_UPSTREAM. > > Signed-off-by: Marek Vasut > --- > Cc: Sumit Garg > Cc: Tom Rini > --- > dts/upstream/src/arm64/Makefile | 4 > 1 file changed, 4 insertions(+) > Reviewed-by: Sumit Garg -Sumit > diff --git a/dts/upst

Re: [PATCH v3 11/12] MIPS: boston: Migrate to OF_UPSTREAM

2024-05-20 Thread Sumit Garg
On Mon, 20 May 2024 at 04:17, Tom Rini wrote: > > On Sun, May 19, 2024 at 09:57:03PM +0100, Jiaxun Yang wrote: > > > > > > 在2024年5月19日五月 下午7:20,Daniel Schwierzeck写道: > > > > > > Reviewed-by: Daniel Schwierzeck > > > > > Hi Daniel, > > > > Thanks for reviewing the series. > > > > > [...] > > > >

Re: [PATCH 12/13] MIPS: boston: Migrate to OF_UPSTREAM

2024-05-16 Thread Sumit Garg
On Thu, 16 May 2024 at 17:29, Jiaxun Yang wrote: > > > > 在2024年5月14日五月 上午6:45,Sumit Garg写道: > > Hi Jiaxun, > > > [...] > >> @@ -0,0 +1,10 @@ > >> +// SPDX-License-Identifier: GPL-2.0+ > >> + > >> +_regs { > >>

Re: [PATCH 1/1] Squashed 'dts/upstream/' changes from b35b9bd1d4ee..7e08733c96c8

2024-05-16 Thread Sumit Garg
On Wed, 15 May 2024 at 21:30, Tom Rini wrote: > > On Wed, May 15, 2024 at 11:39:08AM +0200, Jonas Karlman wrote: > > [snip] > > My main concern is how to best handle new boards and features/drivers. > > E.g. for Rockchip the RK3588 SoC is under active development, new boards > > and

Re: [PATCH 1/1] Squashed 'dts/upstream/' changes from b35b9bd1d4ee..7e08733c96c8

2024-05-15 Thread Sumit Garg
On Wed, 15 May 2024 at 15:09, Jonas Karlman wrote: > > Hi Sumit, > > On 2024-05-15 10:49, Sumit Garg wrote: > > Hi Jonas, > > > > On Wed, 15 May 2024 at 13:11, Jonas Karlman wrote: > >> > >> Hi Tom, > >> > >> On 2024-05-14 18:

Re: [PATCH 1/1] Squashed 'dts/upstream/' changes from b35b9bd1d4ee..7e08733c96c8

2024-05-15 Thread Sumit Garg
Hi Jonas, On Wed, 15 May 2024 at 13:11, Jonas Karlman wrote: > > Hi Tom, > > On 2024-05-14 18:42, Tom Rini wrote:> > > git-subtree-dir: dts/upstream > > git-subtree-split: 7e08733c96c84eb323f47e9b248c924e2ac6272a > > --- > > This moves OF_UPSTREAM to be tracking the v6.9 release and is for the >

Re: [PATCH 12/13] MIPS: boston: Migrate to OF_UPSTREAM

2024-05-13 Thread Sumit Garg
nks for your efforts although I have a further suggestion below but FWIW: Reviewed-by: Sumit Garg > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig > index 748b5175b2eb..733a8de4fb83 100644 > --- a/arch/mips/Kconfig > +++ b/arch/mips/Kconfig > @@ -146,6 +146,7 @@

Re: [PATCH 11/13] dts/upstream: Add Makefile for MIPS

2024-05-13 Thread Sumit Garg
Hi Jiaxun, On Mon, 13 May 2024 at 23:43, Jiaxun Yang wrote: > > It is required to make OF_UPSTREAM work. > > Signed-off-by: Jiaxun Yang > --- > dts/upstream/src/mips/Makefile | 14 ++ > 1 file changed, 14 insertions(+) > Reviewed-by: Sumit Garg -S

Re: [PATCH] mach-snapdragon: do carveouts for qcs404 only

2024-05-08 Thread Sumit Garg
On Wed, 8 May 2024 at 18:09, Caleb Connolly wrote: > > Hi Sam, > > On 08/05/2024 13:40, Sam Day wrote: > > Salutations Sumit, > > > > On Wednesday, 8 May 2024 at 11:14 AM, Sumit Garg > > wrote: > > > >> > >> > >> Hi Sam,

Re: [PATCH] mach-snapdragon: do carveouts for qcs404 only

2024-05-08 Thread Sumit Garg
Hi Sam, On Wed, 8 May 2024 at 00:11, Sam Day wrote: > > The newly introduced carve_out_reserved_memory causes issues when > U-Boot is chained from the lk2nd bootloader. lk2nd provides a > simple-framebuffer device and marks the framebuffer region as no-map in > the supplied /reserved-memory.

Re: [PATCH 108/149] board: qualcomm: Remove and add needed includes

2024-05-01 Thread Sumit Garg
On Wed, 1 May 2024 at 08:15, Tom Rini wrote: > > Remove from this board vendor directory and when needed > add missing include files directly. > > Signed-off-by: Tom Rini > --- > Cc: Ramon Fried > Cc: Caleb Connolly > Cc: Neil Armstrong > Cc: Sumit G

Re: [PATCH v4 0/7] Add SE HMBSC board support

2024-04-23 Thread Sumit Garg
On Tue, 23 Apr 2024 at 17:29, Caleb Connolly wrote: > > Applied, thanks. Thanks. > > (b4 didn't seem to detect this series properly, hence the manual mail). > Switching my workflow to b4 is on my ToDo list. I hope to do it sooner rather than later. -Sumit > On 12/04/2024

Re: [PATCH 0/3] qcom: switch to OF_UPSTREAM

2024-04-22 Thread Sumit Garg
Connolly (3): > mach-snapdragon: use OF_UPSTREAM > arm: dts: drop qcom dts files > qcom_defconfig: set SYS_INIT_SP_BSS_OFFSET > Reviewed-by: Sumit Garg -Sumit > MAINTAINERS |4 - > arch/arm/Kconfig

Re: [PATCH v3 1/3] clk: imx8mm: Add support for PCIe clocks

2024-04-21 Thread Sumit Garg
Hi Tim, On Fri, 19 Apr 2024 at 08:29, Tim Harvey wrote: > > Add support for PCIe clocks required to enable PCIe support on > iMX8MM SoC. > > Signed-off-by: Tim Harvey > --- > v3: wrap pcie clk config around IS_ENABLED to avoid SPL growth as > suggested by Marek > --- >

Re: [PATCH v4 0/7] Add SE HMBSC board support

2024-04-19 Thread Sumit Garg
Hi Caleb, On Fri, 12 Apr 2024 at 02:54, Sumit Garg wrote: > > SE HMIBSC board is based on Qcom APQ8016 SoC. One of the major > difference from db410c is serial port where HMIBSC board uses UART1 as > the debug console with an RS232 port, patch #2 - #5 adds corresponding >

[PATCH v4 7/7] board: add support for Schneider HMIBSC board

2024-04-12 Thread Sumit Garg
protection - USB based ethernet adaptors Signed-off-by: Sumit Garg --- board/schneider/hmibsc/MAINTAINERS | 6 +++ board/schneider/hmibsc/hmibsc.env | 40 ++ configs/hmibsc_defconfig | 87 ++ doc/board/index.rst| 1 + doc/board

[PATCH v4 6/7] arm: dts: qcom: Add Schneider HMIBSC board dts

2024-04-12 Thread Sumit Garg
://lore.kernel.org/linux-kernel/20240403043416.3800259-4-sumit.g...@linaro.org/ Signed-off-by: Sumit Garg --- arch/arm/dts/apq8016-schneider-hmibsc.dts | 491 ++ 1 file changed, 491 insertions(+) create mode 100644 arch/arm/dts/apq8016-schneider-hmibsc.dts diff --git a/arch/arm/dts

[PATCH v4 5/7] pinctrl: qcom: apq8016: Add GPIO pinctrl function

2024-04-12 Thread Sumit Garg
Add GPIO pinctrl function to enable driving GPIO pins as output low or high. Signed-off-by: Sumit Garg --- drivers/pinctrl/qcom/pinctrl-apq8016.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pinctrl/qcom/pinctrl-apq8016.c b/drivers/pinctrl/qcom/pinctrl-apq8016.c index

[PATCH v4 4/7] pinctrl: qcom: Add support for driving GPIO pins output

2024-04-12 Thread Sumit Garg
Add support for driving the GPIO pins as output low or high. Signed-off-by: Sumit Garg --- drivers/pinctrl/qcom/pinctrl-qcom.c | 25 - 1 file changed, 20 insertions(+), 5 deletions(-) diff --git a/drivers/pinctrl/qcom/pinctrl-qcom.c b/drivers/pinctrl/qcom/pinctrl

[PATCH v4 3/7] serial_msm: Enable RS232 flow control

2024-04-12 Thread Sumit Garg
SE HMIBSC board debug console requires RS232 flow control, so enable corresponding support if RS232 gpios are present. Reviewed-by: Caleb Connolly Signed-off-by: Sumit Garg --- drivers/serial/serial_msm.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers

[PATCH v4 2/7] apq8016: Add support for UART1 clocks and pinmux

2024-04-12 Thread Sumit Garg
SE HMIBSC board uses UART1 as the main debug console, so add corresponding clocks and pinmux support. Along with that update instructions to enable clocks for debug UART support. Reviewed-by: Caleb Connolly Signed-off-by: Sumit Garg --- drivers/clk/qcom/clock-apq8016.c | 38

[PATCH v4 1/7] qcom: Don't enable LINUX_KERNEL_IMAGE_HEADER by default

2024-04-12 Thread Sumit Garg
LINUX_KERNEL_IMAGE_HEADER where it's actually required. Fixes: 059d526af312 ("mach-snapdragon: generalise board support") Reviewed-by: Caleb Connolly Signed-off-by: Sumit Garg --- arch/arm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/Kconfig b/arch/a

[PATCH v4 0/7] Add SE HMBSC board support

2024-04-12 Thread Sumit Garg
-main/?ref_type=heads [5] https://lore.kernel.org/all/cafa6wyo+3vroudfuvh390taviqx8pmqroqdtsn0yu6bd5yy...@mail.gmail.com/ Sumit Garg (7): qcom: Don't enable LINUX_KERNEL_IMAGE_HEADER by default apq8016: Add support for UART1 clocks and pinmux serial_msm: Enable RS232 flow control pinctrl

Re: [PATCH 1/7] mmc: msm_sdhci: correct vendor_spec_cap0 register for v5

2024-04-12 Thread Sumit Garg
On Fri, 12 Apr 2024 at 14:06, Neil Armstrong wrote: > > On 11/04/2024 15:59, Sumit Garg wrote: > > On Tue, 9 Apr 2024 at 23:33, Caleb Connolly > > wrote: > >> > >> The V4 and V5 controllers have quite varied register layouts. Inherit > >> the regi

Re: [PATCH 1/7] mmc: msm_sdhci: correct vendor_spec_cap0 register for v5

2024-04-11 Thread Sumit Garg
On Tue, 9 Apr 2024 at 23:33, Caleb Connolly wrote: > > The V4 and V5 controllers have quite varied register layouts. Inherit > the register offsets and naming from the Linux driver. More version > specific offsets can be inherited from Linux as needed. > > Fixes: 364c22a ("mmc: msm_sdhci: Add

[PATCH v2] mach-snapdragon: Allow other board vendors apart from Qcom

2024-04-11 Thread Sumit Garg
Qcom SoCs derived boards can come from various OEMs/ODMs and not just Qcom itself. So allow CONFIG_SYS_VENDOR to be set correctly corressponding to the actual board vendor. Suggested-by: Stephan Gerhold Reviewed-by: Caleb Connolly Signed-off-by: Sumit Garg --- Changes in v2: - Retained

Re: [PATCH v2 0/4] qcom: pinctrl drivers for qcm2290/sm6115/sm8250

2024-04-11 Thread Sumit Garg
qcom-rbx-soc-v1-0-900db37b8...@linaro.org > > --- > Caleb Connolly (4): > pinctrl: qcom: add qcm2290 pinctrl driver > pinctrl: qcom: add sm6115 pinctrl driver > pinctrl: qcom: add sm8250 pinctrl driver > qcom_defconfig: enable pinctrl for new qcm229

Re: [PATCH v2 0/2] phy: qcom: add support for the Qualcomm Synopsys eUSB2 PHY

2024-04-11 Thread Sumit Garg
fixed driver build failure due to missin } > - Link to v1: > https://lore.kernel.org/r/20240405-topic-sm8x50-usb-phy-v1-0-8a8604bf8...@linaro.org > > --- > Neil Armstrong (2): > phy: qcom: add Synopsys eUSB2 PHY driver > qcom_defconfig: enable the Qualcomm Synopsy

[PATCH] mach-snapdragon: Allow other board vendors apart from Qcom

2024-04-11 Thread Sumit Garg
Qcom SoCs derived boards can come from various OEMs/ODMs and not just Qcom itself. So allow CONFIG_SYS_VENDOR to be set correctly corressponding to the actual board vendor. Suggested-by: Stephan Gerhold Signed-off-by: Sumit Garg --- arch/arm/mach-snapdragon/Kconfig | 15

Re: [PATCH 3/4] clk/qcom: add driver for sm8250 GCC

2024-04-10 Thread Sumit Garg
Hi Caleb, On Mon, 8 Apr 2024 at 18:37, Caleb Connolly wrote: > > Add a clock driver for the SM8250 SoC. This driver can enable necessary > clocks for UART, UFS, USB, and MMC. > > Signed-off-by: Caleb Connolly > --- > drivers/clk/qcom/Kconfig| 8 ++ > drivers/clk/qcom/Makefile |

Re: [PATCH] MAINTAINERS: add Qualcomm mailing list

2024-04-10 Thread Sumit Garg
On Tue, 9 Apr 2024 at 20:32, Caleb Connolly wrote: > > Add the newly created u-boot-qcom mailing list to keep track of Qualcomm > patches. > > Additionally, link to the U-Boot Snapdragon custodian tree. > > Signed-off-by: Caleb Connolly > --- > > Cc: Neil Armstr

Re: [PATCH 7/7] dts: sdm845-db845c-u-boot: adjust MMC clocks

2024-04-10 Thread Sumit Garg
Hi Caleb, On Tue, 9 Apr 2024 at 23:33, Caleb Connolly wrote: > > Remove the reference to the xo clock which is on the unsupported rpmhcc > clock controller. It isn't needed for MMC functionality. Can it rather be handled via a NOP clock driver for rpmhcc? I suppose this kind of DT modifications

Re: [PATCH 3/3] qcom_defconfig: enable SM8550 & SM8650 pinctrl driver

2024-04-10 Thread Sumit Garg
On Fri, 5 Apr 2024 at 13:45, Neil Armstrong wrote: > > Enable the SM8550 & SM8650 pinctrl drivers for Qualcomm defconfig. > > Signed-off-by: Neil Armstrong > --- > configs/qcom_defconfig | 2 ++ > 1 file changed, 2 insertions(+) > Acked-by: Sumit Garg -S

Re: [PATCH 2/3] pinctrl: qcom: Add SM8650 pinctrl driver

2024-04-10 Thread Sumit Garg
> drivers/pinctrl/qcom/Kconfig | 7 > drivers/pinctrl/qcom/Makefile | 1 + > drivers/pinctrl/qcom/pinctrl-sm8650.c | 75 > +++ > 3 files changed, 83 insertions(+) > Acked-by: Sumit Garg -Sumit > diff --git a/driver

Re: [PATCH 1/3] pinctrl: qcom: Add SM8550 pinctrl driver

2024-04-10 Thread Sumit Garg
> drivers/pinctrl/qcom/Kconfig | 7 > drivers/pinctrl/qcom/Makefile | 1 + > drivers/pinctrl/qcom/pinctrl-sm8550.c | 75 > +++ > 3 files changed, 83 insertions(+) > Acked-by: Sumit Garg -Sumit > diff --git a/driver

Re: [PATCH 1/3] clk: qcom: Add SM8550 clock driver

2024-04-10 Thread Sumit Garg
On Wed, 10 Apr 2024 at 15:00, wrote: > > On 10/04/2024 11:27, Sumit Garg wrote: > > On Wed, 10 Apr 2024 at 14:46, Neil Armstrong > > wrote: > >> > >> On 10/04/2024 11:13, Sumit Garg wrote: > >>> Hi Neil, > >>> > >>> On T

Re: [PATCH 1/3] clk: qcom: Add SM8550 clock driver

2024-04-10 Thread Sumit Garg
On Wed, 10 Apr 2024 at 14:46, Neil Armstrong wrote: > > On 10/04/2024 11:13, Sumit Garg wrote: > > Hi Neil, > > > > On Thu, 4 Apr 2024 at 22:16, Neil Armstrong > > wrote: > >> > >> Add the GCC and TCSRCC clock driver for the SM8550 SoC. > >

Re: [PATCH 2/3] clk: qcom: Add SM8650 clock driver

2024-04-10 Thread Sumit Garg
On Thu, 4 Apr 2024 at 22:16, Neil Armstrong wrote: > > Add the GCC and TCSRCC clock driver for the SM8650 SoC. > > The GCC driver uses the clk-qcom infrastructure to support GDSCs, > Resets and gates. While the TCSRCC is a simpler clock driver which > only supports gates. > > The GCC enable and

Re: [PATCH 1/3] clk: qcom: Add SM8550 clock driver

2024-04-10 Thread Sumit Garg
Hi Neil, On Thu, 4 Apr 2024 at 22:16, Neil Armstrong wrote: > > Add the GCC and TCSRCC clock driver for the SM8550 SoC. > > The GCC driver uses the clk-qcom infrastructure to support GDSCs, > Resets and gates. While the TCSRCC is a simpler clock driver which > only supports gates. > > The GCC

Re: [PATCH v3 6/6] board: add support for Schneider HMIBSC board

2024-04-08 Thread Sumit Garg
On Fri, 5 Apr 2024 at 20:16, Stephan Gerhold wrote: > > On Fri, Apr 05, 2024 at 02:37:42PM +0530, Sumit Garg wrote: > > Support for Schneider Electric HMIBSC. Features: > > - Qualcomm Snapdragon 410C SoC - APQ8016 (4xCortex A53, Adreno 306) > > - 2GiB RAM > > -

Re: [RFC PATCH 01/15] DO-NOT-MERGE: dts: upstream: src: Necessary pulls from upstream dts

2024-04-05 Thread Sumit Garg
On Fri, 5 Apr 2024 at 11:17, Jayesh Choudhary wrote: > > Hello Sumit, > > On 05/04/24 10:27, Sumit Garg wrote: > > Hi Jayesh, > > > > On Thu, 4 Apr 2024 at 14:30, Jayesh Choudhary wrote: > >> > >> j722s dts support that needs to be pulled from

[PATCH v3 6/6] board: add support for Schneider HMIBSC board

2024-04-05 Thread Sumit Garg
protection - USB based ethernet adaptors Signed-off-by: Sumit Garg --- arch/arm/dts/apq8016-schneider-hmibsc.dts | 491 ++ board/schneider/hmibsc/MAINTAINERS| 6 + configs/hmibsc_defconfig | 86 doc/board/index.rst | 1

[PATCH v3 5/6] pinctrl: qcom: apq8016: Add GPIO pinctrl function

2024-04-05 Thread Sumit Garg
Add GPIO pinctrl function to enable driving GPIO pins as output low or high. Signed-off-by: Sumit Garg --- drivers/pinctrl/qcom/pinctrl-apq8016.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pinctrl/qcom/pinctrl-apq8016.c b/drivers/pinctrl/qcom/pinctrl-apq8016.c index

[PATCH v3 4/6] pinctrl: qcom: Add support for driving GPIO pins output

2024-04-05 Thread Sumit Garg
Add support for driving the GPIO pins as output low or high. Signed-off-by: Sumit Garg --- drivers/pinctrl/qcom/pinctrl-qcom.c | 25 - 1 file changed, 20 insertions(+), 5 deletions(-) diff --git a/drivers/pinctrl/qcom/pinctrl-qcom.c b/drivers/pinctrl/qcom/pinctrl

[PATCH v3 3/6] serial_msm: Enable RS232 flow control

2024-04-05 Thread Sumit Garg
SE HMIBSC board debug console requires RS232 flow control, so enable corresponding support if RS232 gpios are present. Reviewed-by: Caleb Connolly Signed-off-by: Sumit Garg --- drivers/serial/serial_msm.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers

[PATCH v3 2/6] apq8016: Add support for UART1 clocks and pinmux

2024-04-05 Thread Sumit Garg
SE HMIBSC board uses UART1 as the main debug console, so add corresponding clocks and pinmux support. Along with that update instructions to enable clocks for debug UART support. Signed-off-by: Sumit Garg --- drivers/clk/qcom/clock-apq8016.c | 38 ++ drivers

[PATCH v3 1/6] qcom: Don't enable LINUX_KERNEL_IMAGE_HEADER by default

2024-04-05 Thread Sumit Garg
LINUX_KERNEL_IMAGE_HEADER where it's actually required. Fixes: 059d526af312 ("mach-snapdragon: generalise board support") Reviewed-by: Caleb Connolly Signed-off-by: Sumit Garg --- arch/arm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/Kconfig b/arch/a

[PATCH v3 0/6] Add SE HMBSC board support

2024-04-05 Thread Sumit Garg
. - Merged board support patches into a single patch#5. [1] https://source.denx.de/u-boot/custodians/u-boot-snapdragon/-/commits/qcom-next?ref_type=heads [2] https://rauc.readthedocs.io/en/latest/ [3] https://lore.kernel.org/linux-kernel/20240403043416.3800259-4-sumit.g...@linaro.org/ Sumit Garg (6

Re: [RFC PATCH 01/15] DO-NOT-MERGE: dts: upstream: src: Necessary pulls from upstream dts

2024-04-04 Thread Sumit Garg
Hi Jayesh, On Thu, 4 Apr 2024 at 14:30, Jayesh Choudhary wrote: > > j722s dts support that needs to be pulled from devicetree-rebasing > tree. The whole series depends on this support. > Which devicetree-rebasing tag does this patch depend upon? v6.8-dts has already made its way to U-Boot

Re: [PATCH v1] verdin-imx8mm/verdin-imx8mp: move imx verdins to OF_UPSTREAM

2024-04-04 Thread Sumit Garg
delete mode 100644 arch/arm/dts/imx8mm-verdin.dtsi > delete mode 100644 arch/arm/dts/imx8mp-verdin-dev.dtsi > delete mode 100644 arch/arm/dts/imx8mp-verdin-wifi-dev.dts > delete mode 100644 arch/arm/dts/imx8mp-verdin-wifi.dtsi > delete mode 100644 arch/arm/dts/imx8mp-verdin.dtsi >

Re: [PATCH 1/3] arm64: imx: imx8mp-beacon: Migrate to OF_UPSTREAM

2024-04-03 Thread Sumit Garg
On Thu, 4 Apr 2024 at 08:29, Adam Ford wrote: > > The imx8mp-beacon boards can migrate to OF_UPSTREAM which also > allows for the removal the device tree files. > > Signed-off-by: Adam Ford > For the series: Reviewed-by: Sumit Garg -Sumit > diff --git a/arch/arm/dts/Ma

Re: [PATCH v1] verdin-am62: move verdin am62 to OF_UPSTREAM

2024-04-03 Thread Sumit Garg
-am62-verdin.dtsi > delete mode 100644 arch/arm/dts/k3-am625-verdin-wifi-dev.dts > Reviewed-by: Sumit Garg -Sumit > diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile > index 7b7788f7550..18fedc16740 100644 > --- a/arch/arm/dts/Makefile > +++ b/arch/arm/dts/Makefile > @@ -1416

Re: [PATCH v5 03/16] phy: qcom: Add SNPS femto v2 USB HS phy

2024-04-02 Thread Sumit Garg
On Tue, 2 Apr 2024 at 15:37, Caleb Connolly wrote: > > Hi Sumit, > > On 01/04/2024 06:46, Sumit Garg wrote: > > On Thu, 28 Mar 2024 at 23:29, Caleb Connolly > > wrote: > >> > >> From: Bhupesh Sharma > >> > >> Some Qualcomm SoCs

Re: [PATCH 00/31] rockchip: rk3399: Sync DT with linux v6.8 and update defconfigs

2024-04-01 Thread Sumit Garg
On Mon, 1 Apr 2024 at 16:34, Jonas Karlman wrote: > > On 2024-04-01 12:53, Sumit Garg wrote: > > On Mon, 1 Apr 2024 at 15:31, Jonas Karlman wrote: > >> > >> On 2024-04-01 11:45, Jonas Karlman wrote: > >>> Hi Sumit, > >>> > &

Re: [PATCH 00/31] rockchip: rk3399: Sync DT with linux v6.8 and update defconfigs

2024-04-01 Thread Sumit Garg
On Mon, 1 Apr 2024 at 15:54, Jonas Karlman wrote: > > On 2024-04-01 12:08, Sumit Garg wrote: > > On Mon, 1 Apr 2024 at 15:15, Jonas Karlman wrote: > >> > >> Hi Sumit, > >> > >> On 2024-04-01 10:52, Sumit Garg wrote: > >>> Hi Jonas, &

Re: [PATCH 00/31] rockchip: rk3399: Sync DT with linux v6.8 and update defconfigs

2024-04-01 Thread Sumit Garg
On Mon, 1 Apr 2024 at 15:31, Jonas Karlman wrote: > > On 2024-04-01 11:45, Jonas Karlman wrote: > > Hi Sumit, > > > > On 2024-04-01 10:52, Sumit Garg wrote: > >> Hi Jonas, > >> > >> On Mon, 1 Apr 2024 at 01:59, Jonas Karlman wrote: >

Re: [PATCH 00/31] rockchip: rk3399: Sync DT with linux v6.8 and update defconfigs

2024-04-01 Thread Sumit Garg
On Mon, 1 Apr 2024 at 15:15, Jonas Karlman wrote: > > Hi Sumit, > > On 2024-04-01 10:52, Sumit Garg wrote: > > Hi Jonas, > > > > On Mon, 1 Apr 2024 at 01:59, Jonas Karlman wrote: > >> > >> This series adds support for new clocks used in linux v6.8

Re: [PATCH 11/31] clk: rockchip: rk3399: Rename SCLK_DDRCLK to SCLK_DDRC

2024-04-01 Thread Sumit Garg
On Mon, 1 Apr 2024 at 02:01, Jonas Karlman wrote: > > Sync rk3399-cru.h with one from linux v6.2+ and fix use of the > SCLK_DDRCLK name that was only used by U-Boot. > > Signed-off-by: Jonas Karlman > --- > arch/arm/dts/rk3399-u-boot.dtsi| 2 +- > drivers/clk/rockchip/clk_rk3399.c

Re: [PATCH 00/31] rockchip: rk3399: Sync DT with linux v6.8 and update defconfigs

2024-04-01 Thread Sumit Garg
Hi Jonas, On Mon, 1 Apr 2024 at 01:59, Jonas Karlman wrote: > > This series adds support for new clocks used in linux v6.8 device trees, > enables use of FIT signature check for checksum validation and fixes > loading FIT from SD-card when loading FIT from eMMC fails. > > After this series it

Re: [PATCH v5 15/16] qcom_defconfig: enable USB

2024-03-31 Thread Sumit Garg
d-off-by: Caleb Connolly > --- > configs/qcom_defconfig | 52 > -- > 1 file changed, 29 insertions(+), 23 deletions(-) > Reviewed-by: Sumit Garg -Sumit > diff --git a/configs/qcom_defconfig b/configs/qcom_defconfig > index 8c44

Re: [PATCH v5 14/16] qcom_defconfig: enable livetree

2024-03-31 Thread Sumit Garg
slow down. > > Reviewed-by: Neil Armstrong > Signed-off-by: Caleb Connolly > --- > configs/qcom_defconfig | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Sumit Garg -Sumit > diff --git a/configs/qcom_defconfig b/configs/qcom_defconfig > index cbc612b44bd9..8c4402

Re: [PATCH v5 13/16] dts: sdm845-db845c: add u-boot fixups

2024-03-31 Thread Sumit Garg
-connector node, but for now we'll just mark the regulator as > always-on so that it will be enabled automatically during boot. > > Signed-off-by: Caleb Connolly > --- > arch/arm/dts/sdm845-db845c-u-boot.dtsi | 9 + > 1 file changed, 9 insertions(+) > Reviewed-by: Sumit Garg

Re: [PATCH v5 12/16] mach-snapdragon: call regulators_enable_boot_on()

2024-03-31 Thread Sumit Garg
le changed, 2 insertions(+) > Reviewed-by: Sumit Garg -Sumit > diff --git a/arch/arm/mach-snapdragon/board.c > b/arch/arm/mach-snapdragon/board.c > index 65e4c61e866a..3d5994c87886 100644 > --- a/arch/arm/mach-snapdragon/board.c > +++ b/arch/arm/mach-snapdragon/board.c &g

Re: [PATCH v5 11/16] mach-snapdragon: fixup power-domains

2024-03-31 Thread Sumit Garg
s which are loading post-relocation. > Drivers loaded pre-reloc that reference the rpm(h)pd still need > DM_FLAG_DEFAULT_PD_CTRL_OFF in their flags. > > Signed-off-by: Caleb Connolly > --- > arch/arm/mach-snapdragon/of_fixup.c | 32 ++++ > 1 file chang

Re: [PATCH v5 10/16] mach-snapdragon: fixup USB nodes

2024-03-31 Thread Sumit Garg
p.c | 123 > +++ > arch/arm/mach-snapdragon/qcom-priv.h | 20 ++ > 4 files changed, 147 insertions(+) > Acked-by: Sumit Garg -Sumit > diff --git a/arch/arm/mach-snapdragon/Makefile > b/arch/arm/mach-snapdragon/Makefile > index 857171e593

Re: [PATCH v5 03/16] phy: qcom: Add SNPS femto v2 USB HS phy

2024-03-31 Thread Sumit Garg
On Thu, 28 Mar 2024 at 23:29, Caleb Connolly wrote: > > From: Bhupesh Sharma > > Some Qualcomm SoCs newer than SDM845 feature a so-called "7nm phy" > driver, notable the SM8250 SoC which will gain U-Boot support in > upcoming patches. > > Introduce a driver based on the Linux driver. > >

Re: [PATCH v5 02/16] phy: qcom: add Qualcomm QUSB2 USB PHY driver

2024-03-31 Thread Sumit Garg
> drivers/phy/qcom/phy-qcom-qusb2.c | 429 > ++ > 3 files changed, 437 insertions(+) > Acked-by: Sumit Garg -Sumit > diff --git a/drivers/phy/qcom/Kconfig b/drivers/phy/qcom/Kconfig > index f4ca174805a4..361dfb6e1126 100644 > --- a/drivers/phy/qcom/Kconf

  1   2   3   4   5   6   7   8   >