Re: [PATCH v2] arm: mvebu: Enable bootstd and other modernization for Synology DS414 (Armada XP) board

2024-07-04 Thread Tony Dinh
Hi Phil, On Thu, Jul 4, 2024 at 4:27 AM Phil Sutter wrote: > > Hi Tony, > > On Fri, Jun 28, 2024 at 03:44:01PM -0700, Tony Dinh wrote: > > On Fri, Jun 28, 2024 at 3:04 PM Tony Dinh wrote: > > > On Wed, Jun 26, 2024 at 3:31 AM Phil Sutter wrote: > > > > O

Re: [PATCH v2] arm: mvebu: Enable bootstd and other modernization for Synology DS414 (Armada XP) board

2024-06-28 Thread Tony Dinh
Hi Phil, On Fri, Jun 28, 2024 at 3:04 PM Tony Dinh wrote: > > Hi Phil, > > On Wed, Jun 26, 2024 at 3:31 AM Phil Sutter wrote: > > > > Hi Tony, > > > > On Sat, Jun 15, 2024 at 03:06:54PM -0700, Tony Dinh wrote: > > [...] > > > diff --git a/

Re: [PATCH v2] arm: mvebu: Enable bootstd and other modernization for Synology DS414 (Armada XP) board

2024-06-28 Thread Tony Dinh
Hi Phil, On Wed, Jun 26, 2024 at 3:31 AM Phil Sutter wrote: > > Hi Tony, > > On Sat, Jun 15, 2024 at 03:06:54PM -0700, Tony Dinh wrote: > [...] > > diff --git a/board/Synology/ds414/ds414.c b/board/Synology/ds414/ds414.c > > index abe6f9eb5e..f0b55fa095 100644 >

[PATCH v2] arm: mvebu: Enable bootstd and other modernization for Synology DS414 (Armada XP) board

2024-06-15 Thread Tony Dinh
IDENT_STRING to indicate this u-boot supports both Synology DS414 and DS214+ boards - Add SYS_THUMB_BUILD to reduce binary size - Add NET_RANDOM_ETHADDR - Add CONFIG_LBA48 and CONFIG_SYS_64BIT_LBA to support >2TB HDD/SDD Signed-off-by: Tony Dinh --- Changes in v2: - Define EXTRA_ENV_SETTINGS_LEG

Re: [PATCH v2] Makefile: Fix include directory for OF_UPSTREAM

2024-06-12 Thread Tony Dinh
he people that wanted the commit message > > clarified to Ack/Review the patch. Did I just miss that? Sorry. > > > > Agreed, let's wait for more feedback I have migrated to OF_UPSTREAM for ARCH_KIRWOOD boards, and also for a single board (DS116, Armada 385), and have given a lot of thoughts about this problem. I agreed with Michael. Either the whole Arch is migrated at the same time, or we need to prioritize upstream includes to avoid breakage for boards that have been migrated and also boards that have not been. Reviewed-by: Tony Dinh All the best, Tony > > Michael > > > -- > > Tom

Re: [PATCH] arm: dts: mvebu: Update DTS for Thecus N2350 board

2024-06-11 Thread Tony Dinh
Hi Dragan, On Sun, Jun 9, 2024 at 6:07 PM Dragan Simic wrote: > > Hello Tony, > > Please see a few comments below. > > On 2024-06-10 02:34, Tony Dinh wrote: > > - Change the spi-max-frequency to 5000 (50 Mhz). According to the > > data sheet[1], the MX25L3205D

[PATCH] arm: dts: mvebu: Update DTS for Thecus N2350 board

2024-06-09 Thread Tony Dinh
-MX25L6405D-Macronix-MX25L3205DM2I-12G-datasheet.pdf Signed-off-by: Tony Dinh --- arch/arm/dts/armada-385-thecus-n2350.dts | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/arm/dts/armada-385-thecus-n2350.dts b/arch/arm/dts/armada-385-thecus-n2350.dts index

Re: [PATCH] arm: mvebu: Enable bootstd and other modernization for Synology DS414 (Armada XP) board

2024-06-09 Thread Tony Dinh
Hi Phil, On Sat, Jun 8, 2024 at 4:32 PM Phil Sutter wrote: > > On Fri, Jun 07, 2024 at 04:14:26PM -0700, Tony Dinh wrote: > > On Fri, Jun 7, 2024 at 6:45 AM Phil Sutter wrote: > > > On Thu, Jun 06, 2024 at 04:44:36PM -0700, Tony Dinh wrote: > > > > - Switch to

Re: [PATCH] arm: mvebu: Enable bootstd and other modernization for Synology DS414 (Armada XP) board

2024-06-07 Thread Tony Dinh
Hi Phil, On Fri, Jun 7, 2024 at 6:45 AM Phil Sutter wrote: > > Hi Tony, > > On Thu, Jun 06, 2024 at 04:44:36PM -0700, Tony Dinh wrote: > > - Switch to standard boot (in include/configs/ds414.h and > > configs/ds414_defconfig) > > - Implement board_late_init() to

[PATCH] arm: mvebu: Enable bootstd and other modernization for Synology DS414 (Armada XP) board

2024-06-06 Thread Tony Dinh
IDENT_STRING to indicate this u-boot supports both Synology DS414 and DS214+ boards - Add SYS_THUMB_BUILD to reduce binary size - Add NET_RANDOM_ETHADDR - Add CONFIG_LBA48 and CONFIG_SYS_64BIT_LBA to support >2TB HDD/SDD Signed-off-by: Tony Dinh --- board/Synology/ds414/ds414.c | 15 +++ conf

[PATCH] arm: mvebu: env_sf_get_env_addr() missing check for CONFIG_ENV_IS_IN_SPI_FLASH

2024-06-05 Thread Tony Dinh
The CONFIG_ENV_OFFSET is undefined if boot device is UART (CONFIG_MVEBU_SPL_BOOT_DEVICE_UART), or envs are not stored on flash (CONFIG_ENV_IS_NOWHERE). Check for CONFIG_ENV_IS_IN_SPI_FLASH as the first condition to determine whether env_sf_get_env_addr() should be provided. Signed-off-by: Tony

[PATCH] arm: dts: mvebu: Migrate to upstream DT for Synology DS116 (Armada 385) board

2024-05-22 Thread Tony Dinh
Enable OF_UPSTREAM to use upstream DT and add marvell/ prefix to the DEFAULT_DEVICE_TREE in DS116 defconfig. Remove current DTS in arch/arm/dts/ directory. Signed-off-by: Tony Dinh --- arch/arm/dts/Makefile | 1 - arch/arm/dts/armada-385-synology-ds116.dts | 291

Re: [PATCH v2 1/2] doc: Detailed example for netconsole setup

2024-05-18 Thread Tony Dinh
Hi Fiona, Added Heinrich to CC list. On Sat, May 18, 2024 at 4:05 AM Fiona Klute wrote: > > Hi Tony! > > Am 16.05.24 um 21:28 schrieb Tony Dinh: > > On Thu, May 16, 2024 at 3:43 AM Fiona Klute wrote: > >> > >> This adds details that I would

Re: [PATCH v2 1/2] doc: Detailed example for netconsole setup

2024-05-16 Thread Tony Dinh
information, if the board uses static IP then the example would be slightly different. I usually use static IP and ping the netconsole server to make sure it is up. However, I think this DHCP example is good enough to show how to prepare and activate netconsole. Reviewed-by: Tony Dinh All the best, Tony

Re: [PATCH v2 2/2] doc: Update netconsole examples, mention stderr

2024-05-16 Thread Tony Dinh
gt; - => setenv ncip 192.168.1.1 > - => saveenv > - => run nc > +=> env set nc 'env set stdout nc; env set stderr nc; env set stdin nc' > +=> env set ncip 192.168.1.1 > +=> env save > +=> run nc > > On the host side, please use this script to access the console > > -- > 2.43.0 > Reviewed-by: Tony Dinh All the best, Tony

Re: [PATCH 1/2] doc: Detailed example for netconsole setup

2024-05-15 Thread Tony Dinh
Hi Fiona, On Tue, May 14, 2024 at 5:28 PM Fiona Klute wrote: > > This adds details that I would have liked to have readily available, > in particular how to activate the network interface before enabling > netconsole, and how to integrate netconsole so you can use the U-Boot > prompt. > >

Re: [PATCH 11/81] ata: Remove and add needed includes

2024-05-01 Thread Tony Dinh
Przywara > Cc: Simon Glass > Cc: Jonas Karlman > Cc: Johan Jonker > Cc: Bin Meng > Cc: Tony Dinh > Cc: Michal Simek Reviewed-by: Tony Dinh > --- > drivers/ata/ahci-pci.c | 1 - > drivers/ata/ahci-uclass.c | 1 - > drivers/ata/ahci.c | 2 +- >

Re: [PATCH 149/149] board: zyxel: Remove and add needed includes

2024-05-01 Thread Tony Dinh
On Tue, Apr 30, 2024 at 7:46 PM Tom Rini wrote: > > Remove from this board vendor directory and when needed > add missing include files directly. > > Signed-off-by: Tom Rini > --- > Cc: Tony Dinh > Cc: Luka Perkov Reviewed-by: Tony Dinh Tested-by: Tony

Re: [PATCH 075/149] board: iomega: Remove and add needed includes

2024-05-01 Thread Tony Dinh
On Tue, Apr 30, 2024 at 7:44 PM Tom Rini wrote: > > Remove from this board vendor directory and when needed > add missing include files directly. > > Signed-off-by: Tom Rini > --- > Cc: Tony Dinh > Cc: Luka Perkov Reviewed-by: Tony Dinh > --- > board/iomega/

Re: [PATCH 039/149] board: cloudengines: Remove and add needed includes

2024-05-01 Thread Tony Dinh
On Tue, Apr 30, 2024 at 7:44 PM Tom Rini wrote: > > Remove from this board vendor directory and when needed > add missing include files directly. > > Signed-off-by: Tom Rini > --- > Cc: Dave Purdy > Cc: Tony Dinh Reviewed-by: Tony Dinh > --- > board/cloude

Re: [PATCH 011/149] board: Seagate: Remove and add needed includes

2024-05-01 Thread Tony Dinh
On Tue, Apr 30, 2024 at 7:43 PM Tom Rini wrote: > > Remove from this board vendor directory and when needed > add missing include files directly. > > Signed-off-by: Tom Rini > --- > Cc: Tony Dinh > Cc: Evgeni Dobrev Reviewed-by: Tony Dinh > --- > board/Seaga

Re: [PATCH 010/149] board: Marvell: Remove and add needed includes

2024-05-01 Thread Tony Dinh
On Tue, Apr 30, 2024 at 7:43 PM Tom Rini wrote: > > Remove from this board vendor directory and when needed > add missing include files directly. > > Signed-off-by: Tom Rini > --- > Cc: Stefan Roese > Cc: Chris Packham > Cc: Tony Dinh > Cc: Jason Cooper &g

Re: [PATCH 001/149] global: Make include

2024-05-01 Thread Tony Dinh
Hi Tom, This patch does not apply cleanly on the master branch. Perhaps this patch series has a dependency on another previous patch? Please see below at arch/arm/lib/bdinfo.c. On Tue, Apr 30, 2024 at 7:50 PM Tom Rini wrote: > > This follows the example of RISC-V where includes > directly as

Re: [PATCH u-boot-mvebu 00/10] Turris Omnia DDR training changes

2024-04-16 Thread Tony Dinh
for a given binary from U-Boot version string. OK, sounds good. Tested-by: Tony Dinh # regression test for DS116 All the best, Tony > > Marek > > On Mon, 15 Apr 2024 15:20:49 -0700 > Tony Dinh wrote: > > > Hi Marek, > > > > I'm running a regression test with t

Re: [PATCH u-boot-mvebu 00/10] Turris Omnia DDR training changes

2024-04-15 Thread Tony Dinh
Hi Marek, I'm running a regression test with this patch on another Armada 385 board (Synology DS116). And it is running without problem. I noticed that there is no version bump. Is this still 14.0.0? It's kind of hard to see which version we are using without a minor revision such as 14.0.1.

[PATCH v3] arm: dts: kirkwood: Enable upstream DT on Kirkwood boards

2024-04-01 Thread Tony Dinh
bindings and styles in upstream DTS version. Tested-by: Michael Walle # on lschv2 Acked-by: Sumit Garg Reviewed-by: Stefan Roese Signed-off-by: Tony Dinh --- Changes in v3: - Collect Reviewed/Tested/Acked-by tags. - Trim the commit description and point to lore.kernel.org for detailed informa

Re: [PATCH v2] arm: dts: kirkwood: Enable upstream DT on Kirkwood boards

2024-03-28 Thread Tony Dinh
> On Thu Mar 28, 2024 at 3:18 AM CET, Tony Dinh wrote: > > Enable OF_UPSTREAM to use upstream DT and add marvell/ prefix to the > > DEFAULT_DEVICE_TREE for Kirkwood boards. And so we can directly build > > DTBs from dts/upstream/src/arm/marvell, and including *-u-boot.dt

[PATCH v2] arm: dts: kirkwood: Enable upstream DT on Kirkwood boards

2024-03-27 Thread Tony Dinh
8F6282) and Zyxel NSA310S (Kirkwood 88F6281). The Zyxel NSA325 board has a USB 3.0 controller attached to the PCIe bus. And the Zyxel NSA310S has an extensive overhaul in bindings and styles in upstream DTS version. Signed-off-by: Tony Dinh --- Changes in v2: Remove unnecessary redefined OF_UPSTREAM a

Re: [PATCH] arm: dts: kirkwood: Remove DTS files for Kirkwood boards

2024-03-27 Thread Tony Dinh
Hi Sumit, On Tue, Mar 26, 2024 at 9:30 PM Sumit Garg wrote: > > On Wed, 27 Mar 2024 at 02:43, Tony Dinh wrote: > > > > Remove DTS and DTSI files for Kirkwood boards that have upstream supports. > > nit: s/supports/support/ > > > > > This patch depends on &

Re: [PATCH] arm: dts: kirkwood: Enable upstream DT on Kirkwood boards

2024-03-27 Thread Tony Dinh
Hi Sumit, On Tue, Mar 26, 2024 at 9:21 PM Sumit Garg wrote: > > Hi Tony, > > On Fri, 22 Mar 2024 at 07:48, Tony Dinh wrote: > > > > Enable OF_UPSTREAM to use upstream DT and add marvell/ prefix to the > > DEFAULT_DEVICE_TREE for Kirkwood boards. And so we can di

[PATCH] arm: dts: kirkwood: Remove DTS files for Kirkwood boards

2024-03-26 Thread Tony Dinh
Remove DTS and DTSI files for Kirkwood boards that have upstream supports. This patch depends on "arm: dts: kirkwood: Enable upstream DT on Kirkwood boards" https://patchwork.ozlabs.org/project/uboot/patch/20240322021747.14873-1-mibo...@gmail.com/ Signed-off-by: Tony Dinh --- ar

Re: [PATCH] arm: dts: kirkwood: Enable upstream DT on Kirkwood boards

2024-03-22 Thread Tony Dinh
Hi Michael, On Fri, Mar 22, 2024 at 2:10 PM Michael Walle wrote: > > Hi Tony, > > On Fri Mar 22, 2024 at 3:17 AM CET, Tony Dinh wrote: > > Enable OF_UPSTREAM to use upstream DT and add marvell/ prefix to the > > DEFAULT_DEVICE_TREE for Kirkwood boards. And so we can dire

[PATCH] arm: dts: kirkwood: Enable upstream DT on Kirkwood boards

2024-03-21 Thread Tony Dinh
8F6282) and Zyxel NSA310S (Kirkwood 88F6281). The Zyxel NSA325 board has a USB 3.0 controller attached to the PCIe bus. And the Zyxel NSA310S has an extensive overhaul in bindings and styles in upstream DTS version. Signed-off-by: Tony Dinh --- arch/arm/dts/kirkwood-dreamplug-u-boot.dtsi | 7 +

Re: [PATCH] Makefile: Add missing OF_UPSTREAM Makefile for 32bit ARM

2024-03-19 Thread Tony Dinh
STREAM . > > > > Signed-off-by: Marek Vasut > > Tested-by: Adam Ford #am3517-evm Tested-by: Tony Dinh All the best, Tony > > > --- > > Cc: Adam Ford > > Cc: Biju Das > > Cc: Lad Prabhakar > > Cc: Paul Barker > >

Re: [PATCH v6 00/11] An effort to bring DT bindings compliance within U-Boot

2024-03-11 Thread Tony Dinh
Hi Sumit, On Sun, Mar 10, 2024 at 11:24 PM Sumit Garg wrote: > > Hi Tony, > > On Mon, 11 Mar 2024 at 09:20, Tony Dinh wrote: > > > > Hi Sumit, > > Hi Tom, > > > > On Mon, Mar 4, 2024 at 4:29 AM Fabio Estevam wrote: > > > > > > On Mo

Re: [PATCH v6 00/11] An effort to bring DT bindings compliance within U-Boot

2024-03-10 Thread Tony Dinh
Hi Sumit, Hi Tom, On Mon, Mar 4, 2024 at 4:29 AM Fabio Estevam wrote: > > On Mon, Mar 4, 2024 at 9:15 AM Sumit Garg wrote: > > > I suppose the earlier reference patch wasn't complete, can you rather > > try its v4 [1] instead? > > > > [1] > >

Re: [PATCH RFC 26/26] dts: support building all dtb files for a specific vendor

2024-03-04 Thread Tony Dinh
Hi Caleb, On Mon, Mar 4, 2024 at 9:24 AM Caleb Connolly wrote: > > This adjusts OF_UPSTREAM to behave more like the kernel by allowing for > all the devicetree files for a given vendor to be compiled. This is > useful for Qualcomm in particular as most boards are supported by a > single U-Boot

Re: I'm looking for the source code of a specific u-boot version.

2023-12-28 Thread Tony Dinh
the best, Tony > > Regards, > Simon > > > > > > On Thu, Dec 28, 2023 at 3:47 PM Mario Marietto > > wrote: > > > > > > Hello. > > > > > > Can someone provide the right link to download u-boot-2017.0.5 , please ? > > > >

Re: I'm looking for the source code of a specific u-boot version.

2023-12-27 Thread Tony Dinh
Hi Mario and Heinrich, On Wed, Dec 27, 2023 at 12:23 PM Mario Marietto wrote: > > Hello. > > I'm trying to boot FreeBSD for arm32 bit as DomU on my ARM Chromebook > SNOW with xen. Basically there are two ways to accomplish this task : > > > 1) to write a patch that allows the FreeBSD kernel to

Re: [PATCH 0/8] An effort to bring DT bindings compliance within U-boot

2023-12-26 Thread Tony Dinh
Hi Sumit Hi Simon, On Tue, Dec 26, 2023 at 2:13 AM Sumit Garg wrote: > > Hi Simon, > > On Tue, 26 Dec 2023 at 15:17, Simon Glass wrote: > > > > Hi Sumit, > > > > On Fri, Dec 22, 2023 at 5:34 AM Sumit Garg wrote: > > > > > > On Thu, 21 Dec 2023 at 20:48, Simon Glass wrote: > > > > > > > > Hi,

Re: bootstd: Scanning for USB bootflow will remove existing SCSI bootflow

2023-11-06 Thread Tony Dinh
Hi Simon, On Mon, Nov 6, 2023 at 12:51 PM Tony Dinh wrote: > > On Mon, Nov 6, 2023 at 11:51 AM Tom Rini wrote: > > > > On Mon, Nov 06, 2023 at 11:42:51AM -0800, Tony Dinh wrote: > > > Hi Simon, > > > > > > On Mon, Nov 6, 2023 at 9:25 A

Re: bootstd: Scanning for USB bootflow will remove existing SCSI bootflow

2023-11-06 Thread Tony Dinh
On Mon, Nov 6, 2023 at 11:51 AM Tom Rini wrote: > > On Mon, Nov 06, 2023 at 11:42:51AM -0800, Tony Dinh wrote: > > Hi Simon, > > > > On Mon, Nov 6, 2023 at 9:25 AM Simon Glass wrote: > > > > > > Hi Tony, > > > > > > On Wed, 4 O

Re: bootstd: Scanning for USB bootflow will remove existing SCSI bootflow

2023-11-06 Thread Tony Dinh
Hi Simon, On Mon, Nov 6, 2023 at 9:25 AM Simon Glass wrote: > > Hi Tony, > > On Wed, 4 Oct 2023 at 21:23, Tony Dinh wrote: > > > > Hi Simon, > > > > On Mon, Oct 2, 2023 at 12:25 PM Tony Dinh wrote: > > > > > > Hi Simon, > &g

[PATCH v2] bootstd: Skip over bad device during bootflows scanning

2023-11-02 Thread Tony Dinh
Sheevaplug has MMC and USB only, but the later variant comes with USB, MMC, and eSATA ports. We have been using the same u-boot (starting with CONFIG_IDE and later with DM CONFIG_SATA) for both variants. This worked well with the old envs-scripting booting scheme. Signed-off-by: Tony Dinh --- Changes

Re: [PATCH] bootstd: Skip over bad device during bootflows scanning

2023-11-01 Thread Tony Dinh
Hi Simon, On Wed, Nov 1, 2023 at 9:10 AM Simon Glass wrote: > > Hi Tony, > > On Tue, 31 Oct 2023 at 13:45, Tony Dinh wrote: > > > > On Tue, Oct 31, 2023 at 12:26 PM Tony Dinh wrote: > > > > > > Hi Simon, > > > > > > On Mon, Oct 3

Re: Re bootstd: Skip over bad device during bootflows scanning

2023-10-31 Thread Tony Dinh
Hi Simon, On Tue, Oct 31, 2023 at 12:00 PM Tony Dinh wrote: > > Hi Simon, > > On Tue, Oct 31, 2023 at 11:50 AM Simon Glass wrote: > > > > Hi Tony, > > > > Sorry I cannot reply to the patch[1]. > > > > Can you please send the console trace for t

Re: [PATCH] bootstd: Skip over bad device during bootflows scanning

2023-10-31 Thread Tony Dinh
On Tue, Oct 31, 2023 at 12:26 PM Tony Dinh wrote: > > Hi Simon, > > On Mon, Oct 30, 2023 at 12:47 PM Tony Dinh wrote: > > > > During scanning for the next bootdev, if bootdev_next_prio() encounters > > a device error (e.g. ENOSYS), let it continue scanning the

Re: [PATCH] bootstd: Skip over bad device during bootflows scanning

2023-10-31 Thread Tony Dinh
Hi Simon, On Mon, Oct 30, 2023 at 12:47 PM Tony Dinh wrote: > > During scanning for the next bootdev, if bootdev_next_prio() encounters > a device error (e.g. ENOSYS), let it continue scanning the next devices, > not stopping prematurely. > > Background: > > During scan

Re: Re bootstd: Skip over bad device during bootflows scanning

2023-10-31 Thread Tony Dinh
Hi Simon, On Tue, Oct 31, 2023 at 11:50 AM Simon Glass wrote: > > Hi Tony, > > Sorry I cannot reply to the patch[1]. > > Can you please send the console trace for this situation? I don't want > to ignore errors completely, so wonder if there is a special error > code which could be produced when

[PATCH] bootstd: Skip over bad device during bootflows scanning

2023-10-30 Thread Tony Dinh
with USB, MMC, and eSATA ports. We have been using the same u-boot (starting with CONFIG_IDE and later with DM CONFIG_SATA) for both variants. This worked well with the old envs-scripting booting scheme. Signed-off-by: Tony Dinh --- boot/bootdev-uclass.c | 2 -- 1 file changed, 2 deletions(-) diff

Re: [PATCH] fixup! usb: xhci: Guard all calls to xhci_wait_for_event

2023-10-29 Thread Tony Dinh
On Sun, Oct 29, 2023 at 2:33 PM Peter Robinson wrote: > > On Sun, Oct 29, 2023 at 9:25 PM Marek Vasut wrote: > > > > On 10/27/23 08:03, Hector Martin wrote: > > > On 27/10/2023 09.36, Marek Vasut wrote: > > >> On 10/27/23 01:26, Hector Martin wrote: > > >>> Gah, I should've paid more attention

[PATCH] arm: kirkwood: Enable bootstd for Zyxel NSA310S board

2023-10-25 Thread Tony Dinh
Enable bootstd for Zyxel NSA310S board, and remove distroboot. Signed-off-by: Tony Dinh --- configs/nsa310s_defconfig | 3 ++- include/configs/nsa310s.h | 17 ++--- 2 files changed, 4 insertions(+), 16 deletions(-) diff --git a/configs/nsa310s_defconfig b/configs

[PATCH] arm: kirkwood: Enable bootstd for Pogo V4 board

2023-10-24 Thread Tony Dinh
Enable bootstd for Pogo V4 board, and remove distroboot. Signed-off-by: Tony Dinh --- configs/pogo_v4_defconfig | 3 ++- include/configs/pogo_v4.h | 35 ++- 2 files changed, 4 insertions(+), 34 deletions(-) diff --git a/configs/pogo_v4_defconfig b/configs

Re: [PATCH v5] bootstd: sata: Add bootstd support for ahci sata

2023-10-23 Thread Tony Dinh
On Mon, Oct 23, 2023 at 12:08 PM Tom Rini wrote: > > On Wed, 11 Oct 2023 13:26:42 -0700, Tony Dinh wrote: > > > Add ahci sata bootdev and corresponding hunting function. > > > > > > I know this is recent but given their importance, applied to u-boot/master, >

Re: When do we merge bug fixes and new functionality

2023-10-22 Thread Tony Dinh
Hi Tom, Simon, Stefan, On Tue, Oct 10, 2023 at 12:14 AM Tony Dinh wrote: > > Hi Tom, Simon, Stefan, > > I have a few people waiting for these patches to get merged. So I hope > you don't mind (I'm not sure about the merging schedule), I'd bug you > guys about these

[RESEND PATCH] arm: kirkwood: Pogo v4: Enable LTO

2023-10-16 Thread Tony Dinh
Enable building Pogo V4 u-boot image with LTO, which results in about 30K reduction in size. Rebased to latest master and resend. Signed-off-by: Tony Dinh --- configs/pogo_v4_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/pogo_v4_defconfig b/configs/pogo_v4_defconfig

[PATCH v5] bootstd: sata: Add bootstd support for ahci sata

2023-10-11 Thread Tony Dinh
Add ahci sata bootdev and corresponding hunting function. Signed-off-by: Tony Dinh --- Changes in v5: - In bootmeth_script script_boot(), it's unnecessary to check for ret so remove it. While we're here, also initialize ret in declaration. Changes in v4: - Revise logic in bootmeth_script

Re: [PATCH v4] bootstd: sata: Add bootstd support for ahci sata

2023-10-11 Thread Tony Dinh
Hi Tom, On Wed, Oct 11, 2023 at 7:43 AM Tom Rini wrote: > > On Sun, Sep 17, 2023 at 04:06:48PM -0700, Tony Dinh wrote: > > Add ahci sata bootdev and corresponding hunting function. > > > > Signed-off-by: Tony Dinh > > Reviewed-by: Simon Glass > > --- >

When do we merge bug fixes and new functionality

2023-10-10 Thread Tony Dinh
Hi Tom, Simon, Stefan, I have a few people waiting for these patches to get merged. So I hope you don't mind (I'm not sure about the merging schedule), I'd bug you guys about these patches. Wondering if these will be in v2024.01-rc1 or subsequence rc? bootstd: sata: bootdev scanning for ahci

[PATCH] arm: mvebu: Enable bootstd for Thecus N2350 board

2023-10-07 Thread Tony Dinh
Enable bootstd for Thecus N2350 board, and remove distroboot. Signed-off-by: Tony Dinh --- configs/n2350_defconfig | 3 ++- include/configs/n2350.h | 12 +--- 2 files changed, 3 insertions(+), 12 deletions(-) diff --git a/configs/n2350_defconfig b/configs/n2350_defconfig index

[PATCH] arm: mvebu: Enable bootstd for Synology DS116 board

2023-10-07 Thread Tony Dinh
Enable bootstd for Synology DS116 board, and remove distroboot. Signed-off-by: Tony Dinh --- configs/ds116_defconfig | 3 ++- include/configs/ds116.h | 12 +--- 2 files changed, 3 insertions(+), 12 deletions(-) diff --git a/configs/ds116_defconfig b/configs/ds116_defconfig index

[RESEND PATCH] bootstd: sata: bootdev scanning for ahci sata with no drive attached

2023-10-06 Thread Tony Dinh
the right patch. Signed-off-by: Tony Dinh --- drivers/ata/sata.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/ata/sata.c b/drivers/ata/sata.c index f126b84e05..dcb5fcf476 100644 --- a/drivers/ata/sata.c +++ b/drivers/ata/sata.c @@ -79,6 +79,12 @@ int sata_rescan(bool verbose

Re: [PATCH] bootstd: sata: bootdev scanning for ahci sata with no drive attached

2023-10-06 Thread Tony Dinh
On Fri, Oct 6, 2023 at 5:49 PM Tony Dinh wrote: > > It's normal to have no SATA drive attached to the controller, so return a > successful status when there is no block device found after probing. > > Note: this patch depends on the previous patch > https://patchwork.ozlabs

[PATCH] bootstd: sata: bootdev scanning for ahci sata with no drive attached

2023-10-06 Thread Tony Dinh
-by: Tony Dinh --- drivers/ata/sata.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/ata/sata.c b/drivers/ata/sata.c index f126b84e05..59c40a829f 100644 --- a/drivers/ata/sata.c +++ b/drivers/ata/sata.c @@ -79,6 +79,11 @@ int sata_rescan(bool verbose) ret = uclass_probe_all

Re: bootstd: Scanning for USB bootflow will remove existing SCSI bootflow

2023-10-04 Thread Tony Dinh
Hi Simon, On Mon, Oct 2, 2023 at 12:25 PM Tony Dinh wrote: > > Hi Simon, > > On Sun, Oct 1, 2023 at 6:22 PM Simon Glass wrote: > > > > Hi Tony, > > > > On Tue, 26 Sept 2023 at 13:40, Tony Dinh wrote: > > > > > > Hi Simon, > >

Re: bootstd: Scanning for USB bootflow will remove existing SCSI bootflow

2023-10-02 Thread Tony Dinh
Hi Simon, On Sun, Oct 1, 2023 at 6:22 PM Simon Glass wrote: > > Hi Tony, > > On Tue, 26 Sept 2023 at 13:40, Tony Dinh wrote: > > > > Hi Simon, > > > > On Tue, Sep 26, 2023 at 4:37 AM Simon Glass wrote: > > > > > > Hi Tony, >

Re: bootstd: Scanning for USB bootflow will remove existing SCSI bootflow

2023-09-26 Thread Tony Dinh
Hi Simon, On Tue, Sep 26, 2023 at 4:37 AM Simon Glass wrote: > > Hi Tony, > > On Mon, 25 Sept 2023 at 14:02, Tony Dinh wrote: > > > > Hi Simon, > > > > Here is an observation during testing the bootflow command. > > > > If there is a SCSI

bootstd: Scanning for USB bootflow will remove existing SCSI bootflow

2023-09-25 Thread Tony Dinh
Hi Simon, Here is an observation during testing the bootflow command. If there is a SCSI bootflow, scanning for USB bootflow will remove that existing SCSI bootflow. To bring it back, I scanned for SCSI bootflow again, and it was back to normal. Perhaps there is some kind of indexing problem?

Re: [PATCH] arm: mvebu: sata_mv: Add bootstd hook to enable sata_bootdev

2023-09-25 Thread Tony Dinh
Thanks Stefan! All the best, Tony On Mon, Sep 25, 2023 at 1:14 AM Stefan Roese wrote: > > On 9/6/23 07:22, Tony Dinh wrote: > > Add hook in sata_mv probe to enable bootstd bootdev. > > > > Note: bootdev_setup_for_sibling_blk() invocation is a noop if bootsd is > >

Re: [PATCH] arm: mvebu: sata_mv: Add bootstd hook to enable sata_bootdev

2023-09-24 Thread Tony Dinh
Hi Simon, On Sun, Sep 24, 2023 at 1:40 PM Simon Glass wrote: > > Hi Tony, > > On Tue, 5 Sept 2023 at 23:23, Tony Dinh wrote: > > > > Add hook in sata_mv probe to enable bootstd bootdev. > > > > Note: bootdev_setup_for_sibling_blk() invocation is a noop if boo

Re: [PATCH] arm: mvebu: sata_mv: Add bootstd hook to enable sata_bootdev

2023-09-23 Thread Tony Dinh
Hi Stefan, In case you forgot, please review this patch! Thanks, Tony On Tue, Sep 5, 2023 at 10:23 PM Tony Dinh wrote: > > Add hook in sata_mv probe to enable bootstd bootdev. > > Note: bootdev_setup_for_sibling_blk() invocation is a noop if bootsd is > not enabled fo

[PATCH] bootstd: use ARCH_DMA_MINALIGN in memalign() when allocating memory

2023-09-19 Thread Tony Dinh
://patchwork.ozlabs.org/project/uboot/patch/20230917230649.30357-1-mibo...@gmail.com/ Signed-off-by: Tony Dinh --- boot/bootmeth_script.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/boot/bootmeth_script.c b/boot/bootmeth_script.c index 96e0ec5efa..de2e510da1 100644

[PATCH v4] bootstd: sata: Add bootstd support for ahci sata

2023-09-17 Thread Tony Dinh
Add ahci sata bootdev and corresponding hunting function. Signed-off-by: Tony Dinh --- Changes in v4: - Revise logic in bootmeth_script() to set devtype to sata for non-scsi SATA device - Rewrite sata_rescan() logic to properly remove all devices before probing - Add description to sata_rescan

Re: bootstd: CACHE Misaligned operation errors (Marvell Armada 385)

2023-09-16 Thread Tony Dinh
Hi Simon, On Fri, Sep 15, 2023 at 8:40 PM Tony Dinh wrote: > > On Fri, Sep 15, 2023 at 6:32 PM Tony Dinh wrote: > > > > Hi Tom, Hi Simon, > > > > On Wed, Sep 13, 2023 at 9:53 PM Tony Dinh wrote: > > > > > > Hi Simon, > > >

Re: bootstd: CACHE Misaligned operation errors (Marvell Armada 385)

2023-09-15 Thread Tony Dinh
On Fri, Sep 15, 2023 at 6:32 PM Tony Dinh wrote: > > Hi Tom, Hi Simon, > > On Wed, Sep 13, 2023 at 9:53 PM Tony Dinh wrote: > > > > Hi Simon, > > > > On Wed, Sep 13, 2023 at 8:38 PM Simon Glass wrote: > > > > > > Hi Tom, >

Re: bootstd: CACHE Misaligned operation errors (Marvell Armada 385)

2023-09-15 Thread Tony Dinh
Hi Tom, Hi Simon, On Wed, Sep 13, 2023 at 9:53 PM Tony Dinh wrote: > > Hi Simon, > > On Wed, Sep 13, 2023 at 8:38 PM Simon Glass wrote: > > > > Hi Tom, > > > > On Wed, 13 Sept 2023 at 14:14, Tom Rini wrote: > > > > > > On Wed, Sep 13, 202

Re: bootstd: CACHE Misaligned operation errors (Marvell Armada 385)

2023-09-13 Thread Tony Dinh
Hi Simon, On Wed, Sep 13, 2023 at 8:38 PM Simon Glass wrote: > > Hi Tom, > > On Wed, 13 Sept 2023 at 14:14, Tom Rini wrote: > > > > On Wed, Sep 13, 2023 at 12:56:53PM -0700, Tony Dinh wrote: > > > Hi Tom, > > > > > > On Wed, Sep 13, 2023 at 9

Re: bootstd: CACHE Misaligned operation errors (Marvell Armada 385)

2023-09-13 Thread Tony Dinh
Hi Tom, On Wed, Sep 13, 2023 at 1:13 PM Tom Rini wrote: > > On Wed, Sep 13, 2023 at 12:56:53PM -0700, Tony Dinh wrote: > > Hi Tom, > > > > On Wed, Sep 13, 2023 at 9:22 AM Tom Rini wrote: > > > > > > On Tue, Sep 12, 2023 at 12:38:00PM -0700, Tony D

Re: bootstd: CACHE Misaligned operation errors (Marvell Armada 385)

2023-09-13 Thread Tony Dinh
Hi Tom, On Wed, Sep 13, 2023 at 9:22 AM Tom Rini wrote: > > On Tue, Sep 12, 2023 at 12:38:00PM -0700, Tony Dinh wrote: > > > I've been testing the boostd for a few Marvell boards and seeing this > > error on the Thecus N2350 (Marvell Armada 385, dual-core CPU). The &g

bootstd: CACHE Misaligned operation errors (Marvell Armada 385)

2023-09-12 Thread Tony Dinh
I've been testing the boostd for a few Marvell boards and seeing this error on the Thecus N2350 (Marvell Armada 385, dual-core CPU). The "bootflow scan scsi" command triggered the "CACHE: Misaligned operation at range" error. However, this error did not affect the result of the scan, i.e. the

Re: [PATCH v3] bootstd: sata: Add bootstd support for ahci sata

2023-09-11 Thread Tony Dinh
Hi Simon, On Sun, Sep 10, 2023 at 3:37 PM Simon Glass wrote: > > Hi Tony, > > On Fri, 8 Sept 2023 at 13:10, Tony Dinh wrote: > > > > Add ahci sata bootdev and corresponding hunting function. > > > > Signed-off-by: Tony Dinh > > --- > > >

[PATCH v3] bootstd: sata: Add bootstd support for ahci sata

2023-09-08 Thread Tony Dinh
Add ahci sata bootdev and corresponding hunting function. Signed-off-by: Tony Dinh --- Changes in v3: - Correct drivers/ata/Makefile to compile sata_bootdev only if ahci sata is enabled. Changes in v2: - set devtype to sata in bootmeth_script for non-scsi SATA device. boot/bootmeth_script.c

Re: [PATCH v2] bootstd: sata: Add bootstd support for ahci sata

2023-09-08 Thread Tony Dinh
On Thu, Sep 7, 2023 at 2:39 PM Tony Dinh wrote: > > Add ahci sata bootdev and corresponding hunting function. > > Signed-off-by: Tony Dinh > --- > > Changes in v2: > - set devtype to sata in bootmeth_script for non-scsi SATA device > > boot/bootmeth_script.c

[PATCH v2] bootstd: sata: Add bootstd support for ahci sata

2023-09-07 Thread Tony Dinh
Add ahci sata bootdev and corresponding hunting function. Signed-off-by: Tony Dinh --- Changes in v2: - set devtype to sata in bootmeth_script for non-scsi SATA device boot/bootmeth_script.c | 12 ++-- drivers/ata/Makefile | 1 + drivers/ata/sata.c | 25

Re: [PATCH] bootstd: sata: Add bootstd support for ahci sata

2023-09-06 Thread Tony Dinh
Hi Simon, On Tue, Sep 5, 2023 at 9:00 PM Tony Dinh wrote: > > Add ahci sata bootdev and corresponding hunting function. > > Signed-off-by: Tony Dinh > --- > > drivers/ata/Makefile | 1 + > drivers/ata/sata.c | 25 +++ > driv

[PATCH] arm: mvebu: sata_mv: Add bootstd hook to enable sata_bootdev

2023-09-05 Thread Tony Dinh
Add hook in sata_mv probe to enable bootstd bootdev. Note: bootdev_setup_for_sibling_blk() invocation is a noop if bootsd is not enabled for ahci sata yet. Signed-off-by: Tony Dinh --- drivers/ata/sata_mv.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/ata

[PATCH] bootstd: sata: Add bootstd support for ahci sata

2023-09-05 Thread Tony Dinh
Add ahci sata bootdev and corresponding hunting function. Signed-off-by: Tony Dinh --- drivers/ata/Makefile | 1 + drivers/ata/sata.c | 25 +++ drivers/ata/sata_bootdev.c | 62 ++ include/sata.h | 1 + 4 files changed

Re: [PATCH] bootstd: Drop some TODOs

2023-09-04 Thread Tony Dinh
Hi Simon, On Fri, Aug 25, 2023 at 5:51 PM Tony Dinh wrote: > > Hi Simon, > > On Fri, Aug 25, 2023 at 4:53 PM Simon Glass wrote: > > > > Hi Tony, > > > > On Fri, 25 Aug 2023 at 14:17, Tony Dinh wrote: > > > > > > Hi Simon, > >

Re: [PATCH] arm: kirkwood: Add support for ZyXEL NSA325 board

2023-08-29 Thread Tony Dinh
/#mf17689e3e963ab7a34fda34a97f67dea7a877b65 Stefan: "Just checking: Are the DT files imported from the Linux ones?" Yes, these DT files were copied verbatim from Linux. That's why we see some minor warnings about styles. All the best, Tony On Fri, Aug 25, 2023 at 8:33 PM Tony Dinh wrote: > &

[PATCH] arm: kirkwood: Add support for ZyXEL NSA325 board

2023-08-25 Thread Tony Dinh
ZyXEL NSA325 specifications: Marvell Kirkwood 88F6282 SoC 1.6 GHz CPU 1x GBE LAN port (Marvell MV88E1318) 512 MB RAM 128 MB Eon NAND, SLC I2C 1x USB 3.0 (on PCIe bus) 2x USB 2.0 2x SATA (hot swap slots) Serial console Signed-off-by: Tony Dinh --- arch/arm/dts/Makefile| 1

Re: [PATCH] bootstd: Drop some TODOs

2023-08-25 Thread Tony Dinh
Hi Simon, On Fri, Aug 25, 2023 at 4:53 PM Simon Glass wrote: > > Hi Tony, > > On Fri, 25 Aug 2023 at 14:17, Tony Dinh wrote: > > > > Hi Simon, > > > > On Thu, Aug 24, 2023 at 6:48 PM Simon Glass wrote: > > > > > > The existing TO

Re: [PATCH] bootstd: Drop some TODOs

2023-08-25 Thread Tony Dinh
Hi Simon, On Thu, Aug 24, 2023 at 6:48 PM Simon Glass wrote: > > The existing TODOs are done, so remove them. Add another that came up > today. > > Signed-off-by: Simon Glass > --- > > doc/develop/bootstd.rst | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git

[PATCH] arm: kirkwood: Pogo v4: Enable LTO

2023-08-24 Thread Tony Dinh
Enable building Pogo V4 u-boot image with LTO, which results in about 30K reduction in size. Signed-off-by: Tony Dinh --- configs/pogo_v4_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/pogo_v4_defconfig b/configs/pogo_v4_defconfig index 3e3e811543..ad36da712b 100644

Re: [PATCH] arm: Use builtins for ffs/fls

2023-08-24 Thread Tony Dinh
nderson > --- > I only tested this on ARMv8. If someone has an ARMv5 or ARMv6 board, > please test this. Thanks for the patch! I've tested it with the Pogo V4 board (Kirkwood 88F6192, ARMv5) with LTO and SYS_THUMB_BUILD. Also nice size reduction: Before: 502K After: 499K So for ARMv5, Te

Re: [PATCH] kirkwood: dns325: Enable 2nd harddrive

2023-08-11 Thread Tony Dinh
t; @@ -89,6 +89,7 @@ int board_early_init_f(void) > kw_gpio_set_blink(DNS325_GPIO_LED_POWER , 1); > > kw_gpio_set_value(DNS325_GPIO_SATA0_EN , 1); > + kw_gpio_set_value(DNS325_GPIO_SATA1_EN , 1); > return 0; > } > > -- > 2.41.0 > Reviewed-by: Tony Dinh All the best, Tony

Re: F2-NAS2 and NSA325 contributions

2023-06-29 Thread Tony Dinh
need fake-hwclock anyway.. All the best, Tony > czw., 29 cze 2023 o 21:01 Tony Dinh napisał(a): > > > > Hi Henry, > > > > On Thu, Jun 29, 2023 at 6:53 PM Tony Dinh wrote: > > > > > > Hi Heny, > > > > > > On Thu, Jun 29, 202

Re: F2-NAS2 and NSA325 contributions

2023-06-29 Thread Tony Dinh
Hi Henry, On Thu, Jun 29, 2023 at 6:53 PM Tony Dinh wrote: > > Hi Heny, > > On Thu, Jun 29, 2023 at 6:01 PM Henry Smith wrote: > > > > Hello, > > > > I'm a hobbyist that has been playing with Linkstation LS-WVL years > > ago. After frying UAR

Re: F2-NAS2 and NSA325 contributions

2023-06-29 Thread Tony Dinh
Hi Heny, On Thu, Jun 29, 2023 at 6:01 PM Henry Smith wrote: > > Hello, > > I'm a hobbyist that has been playing with Linkstation LS-WVL years > ago. After frying UART on that, I got Terramaster F2-NAS2 later and > got u-boot from the main tree to work on it. > > Both landed in the closet until I

[Test] arm: mvebu: PCI_MVEBU driver on Kirkwood boards

2023-06-21 Thread Tony Dinh
Hi Pali, FYI. In reference to this patch: https://lore.kernel.org/all/20230114164125.1298-1-p...@kernel.org/ Recently, I built a new Linux kernel 6.3.x for the Kirkwood boards and discovered that the PCI_MVEBU driver was marked as BROKEN in Linux mainline. That was a surprise for me, since I've

[PATCH] arm: mvebu: Enable gpio-fan for Thecus N2350 board

2023-06-20 Thread Tony Dinh
Add gpio-fan in the DTS and enable the GPIO in board file to start the fan during boot. Note that this patch depends on https://patchwork.ozlabs.org/project/uboot/patch/20230606214539.4229-1-mibo...@gmail.com/ Signed-off-by: Tony Dinh --- arch/arm/dts/armada-385-thecus-n2350.dts | 15

  1   2   3   4   5   >