[PATCH RFC/RFT v2 4/4] configs: j784s4_evm_r5: Enable ESM related configs

2024-09-11 Thread Andrew Halaney
Like other TI platforms, let's enable the ESM. This allows the ESM to be programmed during boot, and the PMIC associated with the ESM output, enabling blocks like the RTI watchdogs to actually cause the system to reset. Signed-off-by: Andrew Halaney --- configs/j784s4_evm_r5_defconfi

[PATCH RFC/RFT v2 3/4] board: ti: j784s4: Initialize the ESM & PMIC ESM

2024-09-11 Thread Andrew Halaney
4&id=9d8b40958ce792808bc571d828197dbc2e7978d6 Signed-off-by: Andrew Halaney --- board/ti/j784s4/evm.c | 24 1 file changed, 24 insertions(+) diff --git a/board/ti/j784s4/evm.c b/board/ti/j784s4/evm.c index 548dbd5925d..0f4d383b420 100644 --- a/board/ti/j784s4/evm.c +++ b/board/ti/j784

[PATCH RFC/RFT v2 2/4] arm: dts: k3-am69-r5-evm: Add the PMIC ESM node

2024-09-11 Thread Andrew Halaney
Add the PMIC ESM node which is responsible for triggering the PMIC reset. Suggested-by: Udit Kumar Signed-off-by: Andrew Halaney --- arch/arm/dts/k3-am69-r5-sk.dts | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/dts/k3-am69-r5-sk.dts b/arch/arm/dts/k3-am69-r5-sk.dts index

[PATCH RFC/RFT v2 1/4] arm: dts: k3-j784s4-r5-evm: Add the PMIC ESM node

2024-09-11 Thread Andrew Halaney
From: Neha Malcom Francis Add the PMIC ESM node which is responsible for triggering the PMIC reset. Signed-off-by: Neha Malcom Francis Link: https://git.ti.com/cgit/ti-u-boot/ti-u-boot/commit/?h=ea82cf77031e Signed-off-by: Andrew Halaney --- arch/arm/dts/k3-j784s4-r5-evm.dts | 7 +++ 1

[PATCH RFC/RFT v2 0/4] k3-j784s4-r5-evm: Enable ESMs and related PMIC

2024-09-11 Thread Andrew Halaney
27;t break boot. Link: https://lore.kernel.org/lkml/20240911-j784s4-tps6594-bootph-v2-0-a83526264...@redhat.com/ Signed-off-by: Andrew Halaney --- Changes in v2: - Loop over ESMs, only configure if prior was successful as without all of them they're not useful (Udit) - Add am69-sk PMIC E

Re: [PATCH RFC/RFT 2/3] board: ti: j784s4: Initialize the ESM & PMIC ESM

2024-09-10 Thread Andrew Halaney
On Sat, Sep 07, 2024 at 11:12:05AM GMT, Kumar, Udit wrote: > Hi Andrew, > > On 9/7/2024 2:54 AM, Andrew Halaney wrote: > > From: Keerthy > > > > Initialize the ESM & PMIC ESM. This allows things like > > the watchdog to reset the board when tripped. > &

Re: [PATCH RFC/RFT 0/3] k3-j784s4-r5-evm: Enable ESMs and related PMIC

2024-09-10 Thread Andrew Halaney
On Tue, Sep 10, 2024 at 04:21:32PM GMT, Kumar, Udit wrote: > Hi Andrew > > On 9/7/2024 2:54 AM, Andrew Halaney wrote: > > This enables the ESMs and the associated PMIC. Programming these bits is > > a requirement to make the watchdog actually reset the board. > > &

[PATCH RFC/RFT 3/3] configs: j784s4_evm_r5: Enable ESM related configs

2024-09-07 Thread Andrew Halaney
Like other TI platforms, let's enable the ESM. This allows the ESM to be programmed during boot, and the PMIC associated with the ESM output, enabling blocks like the RTI watchdogs to actually cause the system to reset. Signed-off-by: Andrew Halaney --- configs/j784s4_evm_r5_defconfi

[PATCH RFC/RFT 1/3] arm: dts: k3-j784s4-r5-evm: Add the PMIC ESM node

2024-09-07 Thread Andrew Halaney
From: Neha Malcom Francis Add the PMIC ESM node which is responsible for triggering the PMIC reset. Signed-off-by: Neha Malcom Francis Link: https://git.ti.com/cgit/ti-u-boot/ti-u-boot/commit/?h=ea82cf77031e Signed-off-by: Andrew Halaney --- arch/arm/dts/k3-j784s4-r5-evm.dts | 7 +++ 1

[PATCH RFC/RFT 2/3] board: ti: j784s4: Initialize the ESM & PMIC ESM

2024-09-07 Thread Andrew Halaney
4&id=9d8b40958ce792808bc571d828197dbc2e7978d6 [halaney: add a line to the commit message, include header] Signed-off-by: Andrew Halaney --- board/ti/j784s4/evm.c | 28 1 file changed, 28 insertions(+) diff --git a/board/ti/j784s4/evm.c b/board/ti/j784s4/evm.c index 548dbd5925d..a0e

[PATCH RFC/RFT 0/3] k3-j784s4-r5-evm: Enable ESMs and related PMIC

2024-09-07 Thread Andrew Halaney
eries (with the linked change) on the k3-j784s4-evm, but not its sibling the k3-am69-sk. I'd appreciate at a minimum someone to test on that platform to ensure this doesn't break boot. Link: https://lore.kernel.org/all/20240906-j784s4-tps6594-bootph-v1-0-c5b58d43b...@redhat.com/ Signed

Re: [PATCH v4 06/10] arm: mach-k3: am62x: am625_init: Probe AM65 CPSW NUSS

2024-08-14 Thread Andrew Davis
On 8/14/24 12:17 AM, Chintan Vankar wrote: On 13/08/24 23:57, Andrew Davis wrote: On 8/12/24 6:48 AM, Chintan Vankar wrote: From: Kishon Vijay Abraham I In order to support Ethernet boot on AM62x, probe AM65 CPSW NUSS driver in board_init_f(). Signed-off-by: Kishon Vijay Abraham I Signed

Re: [PATCH v4 06/10] arm: mach-k3: am62x: am625_init: Probe AM65 CPSW NUSS

2024-08-13 Thread Andrew Davis
&cpswdev)) + printf("Failed to probe am65_cpsw_nuss driver\n"); + } + spl_enable_cache(); Any reason you added this before enabling caches? Andrew fixup_a53_cpu_freq_by_speed_grade();

Re: [PATCH v2 1/5] arch: arm: dts: k3-j784s4-r5-evm: Add missing fss range

2024-08-09 Thread Andrew Davis
commit, and the name does not linewrap, even if it is more than 80 chars. repo [1] into dts/upstream) No newline. Signed-off-by: Jonathan Humphreys Reviewed-by: Andrew Davis --- arch/arm/dts/k3-j784s4-r5-evm.dts | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/dts/k3-j784s

Re: [PATCH v2] remoteproc: uclass: Modify uc_pdata->name to use combination of device name and device's parent name

2024-08-09 Thread Andrew Davis
to uc_pdata->name not being unique and rproc_init() will fail. Fix this by using combination of dev->name and dev->parent->name instead of using just the dev->name to populate uc_pdata->name. Signed-off-by: MD Danish Anwar --- Reviewed-by: Andrew Davis Cc: Andrew Davis F

Re: [PATCH 1/5] arch: arm: dts: k3-j784s4-r5-evm: Add missing fss range

2024-08-08 Thread Andrew Davis
Looks like way too many tabs, do you have your editor set to 8 space tabs for DTS files? Otherwise, LGTM, Reviewed-by: Andrew Davis +}; + &mcu_ringacc { ti,sci = <&dm_tifs>; };

[PATCH] defconfig: Add a config for AM335x High Security EVM with SPI Boot support

2024-08-07 Thread Andrew Davis
Add a new defconfig file for the AM335x High Security EVM. This config is specific for the case of SPI booting. Signed-off-by: Andrew Davis --- configs/am335x_hs_evm_spi_defconfig | 26 ++ 1 file changed, 26 insertions(+) create mode 100644 configs

[PATCH] arm: dts: keystone: Move to OF_UPSTREAM

2024-08-07 Thread Andrew Davis
Enable OF_UPSTREAM for Keystone boards. Remove DT files that are now available in dts/upstream. Signed-off-by: Andrew Davis --- arch/arm/dts/Makefile | 7 - arch/arm/dts/keystone-clocks.dtsi | 411 - arch/arm/dts/keystone-k2e-clocks.dtsi

[PATCH v2] sandbox: Fix LTO to work with STACKPROTECTOR

2024-07-02 Thread Andrew Goodbody
Add the STACKPROTECTOR symbols to the script that generates the symbols that should not be removed by the use of LTO when linking a shared object. This prevents a fail to build due to link errors. https://source.denx.de/u-boot/u-boot/-/issues/35 Signed-off-by: Andrew Goodbody --- Changes in v2

Re: [PATCH] sandbox: Fix LTO to work with STACKPROTECTOR

2024-07-01 Thread Andrew Goodbody
On 01/07/2024 14:57, Simon Glass wrote: Hi Andrew, On Mon, 24 Jun 2024 at 10:29, Andrew Goodbody wrote: Add the STACKPROTECTOR symbols to the script that generates the symbols that should not be removed by the use of LTO when linking a shared object. This prevents a fail to build due to link

[PATCH] sandbox: Fix LTO to work with STACKPROTECTOR

2024-06-24 Thread Andrew Goodbody
Add the STACKPROTECTOR symbols to the script that generates the symbols that should not be removed by the use of LTO when linking a shared object. This prevents a fail to build due to link errors. https://source.denx.de/u-boot/u-boot/-/issues/35 Signed-off-by: Andrew Goodbody --- scripts

Re: [PATCH] board: beagle: beagleplay: enable OF_SYSTEM_SETUP

2024-06-19 Thread Andrew Davis
nel's FDT to inform it of the actual location of the firmware CC: Andrew Davis CC: Nishanth Menon CC: Robert Nelson Reported-by: Dhruva Gole Signed-off-by: Bryan Brattlof --- Acked-by: Andrew Davis Hello everyone, Fair warning, this may turn into a philosophical discussion about t

Re: [PATCH 1/6] arm: mach-k3: Add default ATF location for AM62/AM62a

2024-06-19 Thread Andrew Davis
On 6/19/24 1:20 PM, Nishanth Menon wrote: On 17:19-20240619, Dhruva Gole wrote: Hi, On Feb 14, 2024 at 10:30:04 -0600, Andrew Davis wrote: There is a default ATF load address that is used for devices that have ATF running in SRAM. For AM62 and AM62a, ATF runs from DRAM. Instead of having to

Re: [PATCH v2 3/8] arm: mach-k3: j721e: Enable QoS for DSS

2024-06-14 Thread Andrew Davis
v/null +++ b/arch/arm/mach-k3/r5/j721e/j721e_qos.h @@ -0,0 +1,96 @@ +/* SPDX-License-Identifier: GPL-2.0+ */ +/* + * Keystone3 Quality of service endpoint definitions Our marketing folks claim it is "K3" not "Keystone3" :), otherwise lgtm, Reviewed-by: Andrew Davis + * Auto

Re: [PATCH v2 2/8] arm: mach-k3: am62a: Simplify the logic for QOS reg and val propagation

2024-06-14 Thread Andrew Davis
and make the corresponding changes for am62a_qos_uboot file. Suggested-by: Andrew Davis Signed-off-by: Jayesh Choudhary --- Looks a bit better IMHO, Acked-by: Andrew Davis arch/arm/mach-k3/include/mach/k3-qos.h | 86 arch/arm/mach-k3/r5/am62ax/am62a_qos_uboot.c

Re: [PATCH 1/3] arm: dts: k3-am642-evm-u-boot: Add remoteproc-name for PRU cores

2024-06-07 Thread Andrew Davis
On 5/23/24 1:33 AM, Anwar, Md Danish wrote: Hi Andrew, On 5/22/2024 9:38 PM, Andrew Davis wrote: On 5/22/24 1:36 AM, MD Danish Anwar wrote: Add remoteproc-name property for PRU cores. Signed-off-by: MD Danish Anwar ---   arch/arm/dts/k3-am642-evm-u-boot.dtsi | 44

Re: [PATCH 09/14] arch: mach-k3: Introduce basic files to support J722S SoC family

2024-05-29 Thread Andrew Davis
old address. You'll need to do the same as done for AM62p here: https://patchwork.ozlabs.org/project/uboot/patch/20240520-am62p-fdt-fix-v1-1-49845dcb3...@ti.com/ Andrew default 0x7000 help The load address for the ATF image. This value is used to build the @@ -163,6 +167,7 @

Re: [PATCH 03/14] soc: add info to identify the J722S SoC family

2024-05-29 Thread Andrew Davis
On 5/29/24 8:24 AM, Jayesh Choudhary wrote: Include the part number for TI's j722s family of SoC to identify it during boot. Signed-off-by: Vaishnav Achath Signed-off-by: Jayesh Choudhary --- arch/arm/mach-k3/include/mach/hardware.h | 2 ++ drivers/soc/soc_ti_k3.c | 3 +++

Re: [PATCH 01/14] arm: mach-k3: Sort CONFIG_SOC* and K3_SOC_ID entries

2024-05-29 Thread Andrew Davis
have it, etc.. No issue with alphabetical either, just looking for a "why" in the commit message, otherwise, Reviewed-by: Andrew Davis Signed-off-by: Jayesh Choudhary --- arch/arm/mach-k3/include/mach/hardware.h | 37 1 file changed, 19 insertions(+), 18

Re: [PATCH] arm: mach-k3: am62p: Fixup TF-A/OP-TEE reserved-memory node in FDT

2024-05-23 Thread Andrew Davis
{} nodes when the loaded address does not match the address in DT. Reported-by: Andrew Davis Signed-off-by: Bryan Brattlof --- Hello everyone, This is a little fixup to avoid any confusion once we're in the kernel. Because TF-A can be configured in U-Boot to be anywhere we want, we need up u

Re: [PATCH 1/3] arm: dts: k3-am642-evm-u-boot: Add remoteproc-name for PRU cores

2024-05-22 Thread Andrew Davis
lback to using `dev->name` if these are not set, does that not work for us here? Andrew +}; + +&rtu0_0 { + remoteproc-name = "rtu0_0"; +}; + +&tx_pru0_0 { + remoteproc-name = "tx_pru0_0"; +}; + +&pru0_1 { + remoteproc-name = "pru0_

Re: [PATCH 2/7] arm: mach-k3: j721e: Enable QoS for DSS

2024-05-22 Thread Andrew Davis
qos_data[] = { + /* DSS_PIPE_VID1 - 2 endpoints, 2 channels */ + { + .reg = K3_DSS_MAIN_0_DSS_INST0_VBUSM_DMA + 0x100 + 0x4 * 0, 0x100 being the instance, and 0x4 * x being the specific device register right? That could be encoded in a macro (the "Resource Partitioning tool" would

Re: [PATCH 1/7] arm: mach-k3: am62a_qos: Move common bit MACROS to k3_qos header file

2024-05-22 Thread Andrew Davis
(13 << 16) +#define VIRTID_14 (14 << 16) +#define VIRTID_15 (15 << 16) This all seem like it could be made into some macro, something like #define K3_QOS(qos, orderid, asel, epriority, virtid, atype) \ (qos << 0 | \ orderid <

Re: [PATCH v3 2/2] configs: add defconfigs for the am625-lp-sk

2024-05-15 Thread Andrew Davis
H/SOC/TARGET info in the defconfig file so buildman can find it without following the #include. Andrew

Re: [PATCH v2 5/8] drivers: ram: Kconfig: Add CONFIG_K3_INLINE_ECC

2024-05-15 Thread Andrew Davis
platforms can opt-out as needed instead. Andrew + help + Enable Inline ECC support on K3 platforms. 1/9th of the SDRAM space + is used for ECC storage and the rest 8/9th is available for system + use. Enabling ECC increases boot time as the ECC protected regions +

[PATCH v2] arm: mach-k3: Move code specific to a SoC into that SoC's directory

2024-05-10 Thread Andrew Davis
Each SoC now has a directory in mach-k3, let's move the SoC specific files into their respective directories. Signed-off-by: Andrew Davis --- Changes for v2: - Rebased on latest -next arch/arm/mach-k3/Makefile | 24 ++--- arch/arm/mach-k3/am62ax/Mak

Re: [PATCH v2 2/2] arm: dts: k3-j7200-binman: Add support for HSSE1.0 and HSFS1.0

2024-05-09 Thread Andrew Davis
release (IIRC), but for completeness this is fine to have supported, Reviewed-by: Andrew Davis Reported-by: Suman Anna Reported-by: Aniket Limaye Signed-off-by: Neha Malcom Francis --- arch/arm/dts/k3-j7200-binman.dtsi | 95 ++- 1 file changed, 94 insertions(+), 1

Re: [PATCH v2 1/2] arm: dts: k3-j721e-binman: Add support for HSFS1.1

2024-05-09 Thread Andrew Davis
HS-SE SR2.0 generation Looks good to me now, Reviewed-by: Andrew Davis arch/arm/dts/k3-j721e-binman.dtsi | 90 ++- 1 file changed, 89 insertions(+), 1 deletion(-) diff --git a/arch/arm/dts/k3-j721e-binman.dtsi b/arch/arm/dts/k3-j721e-binman.dtsi index

[PATCH] arm: mach-k3: am62ax: Fix typo in ROM data macro name

2024-04-26 Thread Andrew Davis
s/ENTENDED/EXTENDED Signed-off-by: Andrew Davis --- arch/arm/mach-k3/am62a7_init.c | 2 +- arch/arm/mach-k3/include/mach/am62a_hardware.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-k3/am62a7_init.c b/arch/arm/mach-k3/am62a7_init.c index

[PATCH] arm: mach-k3: Move code specific to a SoC into that SoC's directory

2024-04-25 Thread Andrew Davis
Each SoC now has a directory in mach-k3, let's move the SoC specific files into their respective directories. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/Makefile | 27 ++--- arch/arm/mach-k3/am62ax/Makefile| 7 ++ arch/arm/ma

Re: [PATCH 1/2] arm: dts: k3-j721e-binman: Add support for HSSE2.0 and HSFS1.1

2024-04-22 Thread Andrew Davis
6 +129,205 @@ }; }; +&binman { + tiboot3-j721e_sr2-hs-evm.bin { This already seems to exist in this file, it is hidden up in the first binman{} GP node at the top. Might just need split out from that. Andrew + filename = "tiboot3-j721e_sr2-hs-evm.bin"; +

[PATCH] arm: mach-k3: am642: Fix reset for workaround errata ID i2331

2024-04-18 Thread Andrew Davis
driver allowing do_reset() to again function as expected. Reported-by: Jonathan Humphreys Fixes: fc5d40283483 ("firmware: ti_sci: Bind sysreset driver when enabled") Signed-off-by: Andrew Davis --- arch/arm/mach-k3/am642_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[PATCH] arm: mach-k3: security: Lower verbosity of cert message for GP

2024-04-10 Thread Andrew Davis
When we find a certificate on an image to be booted on a GP device we print out a message explaining that the certificate is being skipped. This message is rather long and is printed for every image. Shorten the message and make the long version into a debug message. Signed-off-by: Andrew Davis

Re: [PATCH 3/7] dts: j721e: binman: Include firmware capsules binman nodes

2024-04-10 Thread Andrew Davis
On 4/10/24 1:24 PM, Jon Humphreys wrote: Andrew Davis writes: On 4/8/24 5:17 PM, Jonathan Humphreys wrote: Signed-off-by: Jonathan Humphreys --- arch/arm/dts/k3-j721e-binman.dtsi | 32 +++ 1 file changed, 32 insertions(+) diff --git a/arch/arm/dts/k3-j721e

Re: [PATCH 01/13] ti:keys Add EFI signature list

2024-04-10 Thread Andrew Davis
On 4/10/24 4:38 AM, Ilias Apalodimas wrote: On Tue, 9 Apr 2024 at 23:14, Andrew Davis wrote: On 4/9/24 2:26 PM, Heinrich Schuchardt wrote: On 4/9/24 14:14, Andrew Davis wrote: On 4/8/24 10:34 PM, Heinrich Schuchardt wrote: On 4/8/24 23:33, Jonathan Humphreys wrote: EFI signature list

Re: [PATCH 3/7] dts: j721e: binman: Include firmware capsules binman nodes

2024-04-09 Thread Andrew Davis
use the _unsigned images here? HS devices cannot boot unsigned GP images, but both GP and HS devices *can* boot the normal signed images (GP just strips the signatures off). So no need to use the _unsigned images anymore (I'm planning to just remove them at some point to prevent this confusion). Andrew +}; +&uboot_name { + filename = "u-boot.img_unsigned"; +}; + #endif

Re: [PATCH 01/13] ti:keys Add EFI signature list

2024-04-09 Thread Andrew Davis
On 4/9/24 2:26 PM, Heinrich Schuchardt wrote: On 4/9/24 14:14, Andrew Davis wrote: On 4/8/24 10:34 PM, Heinrich Schuchardt wrote: On 4/8/24 23:33, Jonathan Humphreys wrote: EFI signature list using TI dummy keys. Adding vendor public keys into the code base to lock down generated binaries

Re: [PATCH 01/13] ti:keys Add EFI signature list

2024-04-09 Thread Andrew Davis
public license. The matching private keys are already published in this same repo/directory (arch/arm/mach-k3/keys). Andrew Best regards Heinrich Signed-off-by: Jonathan Humphreys ---   arch/arm/mach-k3/keys/custMpk.esl | Bin 0 -> 1523 bytes   1 file changed, 0 insertions(+), 0 deleti

Re: [RFC PATCH 13/15] arm: dts: Introduce J722S U-Boot dts files

2024-04-05 Thread Andrew Davis
On 4/5/24 2:18 AM, Jayesh Choudhary wrote: Hi, On 04/04/24 20:59, Andrew Davis wrote: On 4/4/24 4:00 AM, Jayesh Choudhary wrote: Include the uboot device tree files needed to boot the board. Co-developed-by: Vaishnav Achath Signed-off-by: Vaishnav Achath Signed-off-by: Jayesh Choudhary

Re: [PATCH 1/1] net: nfs: fix file handle length in NFSv3

2024-04-04 Thread Andrew Davis
Fix this by using a variable length file handle for dirfh. [1] https://www.rfc-editor.org/rfc/rfc1813.html#page-106 Fixes: b0baca982048 ("net: NFS: Add NFSv3 support") Signed-off-by: Sébastien Szymanski --- Fixes NFS boot for me, thanks! Tested-by: Andrew Davis net/nfs.c | 18 ++

Re: [RFC PATCH 15/15] doc: board: ti: Add J722S-EVM documentation

2024-04-04 Thread Andrew Davis
parameters + $ unset TFA_EXTRA_ARGS Why unset, who is setting in the first place? + $ export OPTEE_PLATFORM=k3-am62x None of the addresses OPTEE cares about changed from AM62? + $ export OPTEE_EXTRA_ARGS="CFG_WITH_SOFTWARE_PRNG=y" Do you still need this, the HW RNG should work no

Re: [RFC PATCH 13/15] arm: dts: Introduce J722S U-Boot dts files

2024-04-04 Thread Andrew Davis
ootph-pre-ram; + + k3_sysreset: sysreset-controller { + compatible = "ti,sci-sysreset"; + bootph-pre-ram; This node won't be needed soon either[0]. Should mean an almost empty -u-boot.dtsi file, which should be the goal. Andrew [0] https://lore.

Re: [PATCH 2/2] arm: dts: k3: Remove unneeded ti, sci-sysreset binding and nodes

2024-04-03 Thread Andrew Davis
On 4/3/24 1:37 AM, Neha Malcom Francis wrote: Hi Andrew, On 02/04/24 21:39, Andrew Davis wrote: This extra binding is non-standard and now unneeded as we bind the sysreset driver automatically. This matches what is done in Linux and allows us to more closely match the DTBs. Remove the binding

[PATCH 1/2] firmware: ti_sci: Bind sysreset driver when enabled

2024-04-02 Thread Andrew Davis
The sysreset TI-SCI API is available with TI-SCI always, there is no need for a DT node to describe the availability of this. If the sysreset driver is available then bind it during ti-sci probe. Remove the unneeded device tree matching. Signed-off-by: Andrew Davis --- drivers/firmware

[PATCH 2/2] arm: dts: k3: Remove unneeded ti, sci-sysreset binding and nodes

2024-04-02 Thread Andrew Davis
This extra binding is non-standard and now unneeded as we bind the sysreset driver automatically. This matches what is done in Linux and allows us to more closely match the DTBs. Remove the binding and all users. Signed-off-by: Andrew Davis --- arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi | 7

[PATCH 0/2] Remove ti,sci-sysreset

2024-04-02 Thread Andrew Davis
Hello all, Idea here is to remove one more delta between the U-Boot and Linux DTB files: ti,sci-sysreset. We currently have to add this to every board's -u-boot.dtsi file as this is not a standard node. Instead do what we are moving the kernel towards[0] and remove this node. Thanks, Andre

Re: [PATCH] am625x_evm_a53: Tweak boot command to set fdt

2024-03-26 Thread Andrew Davis
file` from the environment variables set by these config options, however this script currently isn't being run. I think this patch will be unneeded after this series goes in: https://lore.kernel.org/u-boot/20240109191506.3820908-1...@ti.com/ Andrew Calling this script results in the corr

Re: [PATCH u-boot v2019.04-aspeed-openbmc] ARM: dts: aspeed: Add Ampere's BMC platform (AST2600)

2024-03-25 Thread Andrew Jeffery
However, you've sent this to the upstream list. You will need to rework your patch on top of mainline u-boot if you want it accepted there, and follow all the usual documentation on how to submit patches to the u- boot project (e.g. you should not be including `u-boot v2019.04-aspeed- openbmc` in the patch subject prefix in upstream submissions). Andrew

Re: [PATCH 3/4] arm: dts: k3-*-binman.dtsi: Clean up and templatize boot binaries

2024-03-23 Thread Andrew Davis
hy is the BeaglePlay board including the SK binman file? Looks like you made `k3-am625-sk-binman.dtsi` into the SoC general file, which is good, but you should probably also rename it here to match: `k3-am625-binman.dtsi`. Andrew

Re: [PATCH] Makefile: Improve generated_defconfig file handling

2024-03-08 Thread Andrew Davis
an that up on `make clean'. Also we probably want to hide it in `git status' list. This patch makes the described changes, and also adds `-P' parameter to the CPP command that produces the `generated_defconfig' to avoid generating linemarkers. All look like sensible improvem

Re: [PATCH 4/6] arm: mach-k3: am62: Fixup TF-A/OP-TEE reserved-memory node in FDT

2024-03-06 Thread Andrew Davis
On 3/6/24 7:35 AM, Bryan Brattlof wrote: On February 14, 2024 thus sayeth Andrew Davis: The address we load TF-A and OP-TEE to is configurable by Kconfig CONFIG_K3_{ATF,OPTEE}_LOAD_ADDR, but the DT nodes reserving this memory are often statically defined. As these binaries are dynamically

Re: [PATCH 4/6] arm: mach-k3: am62: Fixup TF-A/OP-TEE reserved-memory node in FDT

2024-03-06 Thread Andrew Davis
On 2/28/24 12:24 AM, Manorit Chawdhry wrote: Hi Andrew, On 10:30-20240214, Andrew Davis wrote: The address we load TF-A and OP-TEE to is configurable by Kconfig CONFIG_K3_{ATF,OPTEE}_LOAD_ADDR, but the DT nodes reserving this memory are often statically defined. As these binaries are

Re: [PATCH 2/6] arm: mach-k3: Add config option for setting OP-TEE address

2024-03-06 Thread Andrew Davis
On 2/28/24 12:21 AM, Manorit Chawdhry wrote: Hi Andrew, On 10:30-20240214, Andrew Davis wrote: Much like we have for ATF, OP-TEE has a standard address that we load it too and run it from. Add a Kconfig item for this to remove some hard-coding and allow this address to be more easily changed

[PATCH v2] arm: dts: k3-am64: Move to OF_UPSTREAM

2024-03-05 Thread Andrew Davis
Enable OF_UPSTREAM for AM64-EVM and SK-AM64 boards. Remove DT files that are now available in dts/upstream. Update the appended files based on version of latest OF_UPSTREAM sync point (v6.7-rc7). Signed-off-by: Andrew Davis --- Changes for v2: - Rebased on latest -next to fix merge conflict

[PATCH] arm: dts: k3-am64: Move to OF_UPSTREAM

2024-03-04 Thread Andrew Davis
Enable OF_UPSTREAM for AM64-EVM and SK-AM64 boards. Remove DT files that are now available in dts/upstream. Update the appended files based on version of latest OF_UPSTREAM sync point (v6.7-rc7). Signed-off-by: Andrew Davis --- As suggested here[0]. Based on Mar 4 -next. [0] https

Re: [PATCH v10 14/15] configs: am69_sk: Add defconfig for AM69 SK board

2024-02-29 Thread Andrew Davis
snavis Sabiya Signed-off-by: Apurva Nandan --- Reviewed-by: Andrew Davis board/ti/j784s4/MAINTAINERS | 2 ++ configs/am69_sk_a72_defconfig | 9 + configs/am69_sk_r5_defconfig | 10 ++ 3 files changed, 21 insertions(+) create mode 100644 configs/am69_sk_a72_def

Re: [RFC PATCH 1/4] configs: j721e_sk: Move to separate defconfig for J721E SK board

2024-02-28 Thread Andrew Davis
ery defconfig for when doing testing. So you also for now need to re-define the ARCH, even though it comes in from the include. See how it was done here[0]. Basically just add here: CONFIG_ARM=y CONFIG_ARCH_K3=y CONFIG_SOC_K3_J721E=y CONFIG_TARGET_J721E_A72_EVM=y Andrew [0] https://lore.kernel.

Re: [PATCH v8 16/16] doc: board: ti: k3: Add J784S4 EVM and AM69 SK documentation

2024-02-15 Thread Andrew Halaney
uj62... SW8 is a push button for a user defined interrupt for wake up (I think), and SW9 is the main domain warm reset push button. I'm not sure either of those are what you're trying to highlight here. Love the TI documentation by the way, it is very nice. Thanks, Andrew

Re: [PATCH 6/6] arm: mach-k3: Move DRAM address of ATF for AM62/AM62a

2024-02-15 Thread Andrew Davis
On 2/15/24 2:06 AM, Francesco Dolcini wrote: Hello Andrew, thanks for this series. On Wed, Feb 14, 2024 at 10:30:09AM -0600, Andrew Davis wrote: The current address of TF-A in DRAM is just below the 512MB address line. This means if the DRAM in a system is 512MB then TF-A is right at the end

[PATCH 5/6] arm: mach-k3: am62a: Fixup TF-A/OP-TEE reserved-memory node in FDT

2024-02-14 Thread Andrew Davis
The address we load TFA and OP-TEE to is configurable by CONFIG_K3_{ATF,OPTEE}_LOAD_ADDR, but the DT nodes reserving this memory are static. Fix that by updating this node when the loaded address does not match the address in DT. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/Makefile

[PATCH 3/6] arm: mach-k3: am62: Enable OF_SYSTEM_SETUP for all boards

2024-02-14 Thread Andrew Davis
The fixups provided by ft_system_setup() are applicable for all AM62 based boards. Select this at the target selection level for all AM62 boards and remove it from any specific defconfig. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/am62x/Kconfig| 3 +++ configs/verdin

[PATCH 6/6] arm: mach-k3: Move DRAM address of ATF for AM62/AM62a

2024-02-14 Thread Andrew Davis
Linux and is fully forward/backward compatible. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-k3/Kconfig b/arch/arm/mach-k3/Kconfig index 55bb874d9aa..33f20f61f83 100644 --- a/arch/arm/mach-k3/Kconfig

[PATCH 1/6] arm: mach-k3: Add default ATF location for AM62/AM62a

2024-02-14 Thread Andrew Davis
There is a default ATF load address that is used for devices that have ATF running in SRAM. For AM62 and AM62a, ATF runs from DRAM. Instead of having to override the address in every defconfig, make add a default for these ATF in DRAM devices. Signed-off-by: Andrew Davis --- arch/arm/mach-k3

[PATCH 0/6] Move DRAM address of ATF

2024-02-14 Thread Andrew Davis
Hello all, Explanation for this series is mostly in [4/6]. First 3 patches should be safe to take independent of the last 3. Thanks, Andrew Andrew Davis (6): arm: mach-k3: Add default ATF location for AM62/AM62a arm: mach-k3: Add config option for setting OP-TEE address arm: mach-k3: am62

[PATCH 4/6] arm: mach-k3: am62: Fixup TF-A/OP-TEE reserved-memory node in FDT

2024-02-14 Thread Andrew Davis
above. Add this fixup function, and enable it for AM62. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/am625_fdt.c | 2 ++ arch/arm/mach-k3/common_fdt.c | 52 +++ arch/arm/mach-k3/common_fdt.h | 2 ++ 3 files changed, 56 insertions(+) diff --git a/arch/arm

[PATCH 2/6] arm: mach-k3: Add config option for setting OP-TEE address

2024-02-14 Thread Andrew Davis
Much like we have for ATF, OP-TEE has a standard address that we load it too and run it from. Add a Kconfig item for this to remove some hard-coding and allow this address to be more easily changed. Signed-off-by: Andrew Davis --- arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi | 4 ++-- arch

Re: [PATCH 2/2] ti: keystone2: Move common Kconfig selections to under ARCH_KEYSTONE

2024-02-08 Thread Andrew Davis
On 7/25/23 12:41 PM, Tom Rini wrote: On Tue, Jul 25, 2023 at 10:54:16AM -0500, Andrew Davis wrote: These select/imply settings are common to the whole architecture not just these boards, move these settings to the architecture config. Signed-off-by: Andrew Davis Reviewed-by: Tom Rini

Re: [PATCH 02/10] arm: dts: k3-am68*: Sync with 6.8-rc1

2024-02-06 Thread Andrew Davis
On 2/6/24 6:21 AM, Manorit Chawdhry wrote: Syncs the DT from Linux v6.8-rc1. Remove udmap overrides and handle location change of chipid node. Message doesn't match the patch. This patch should just be squashed into the previous one anyway. Andrew Signed-off-by: Manorit Cha

Re: [PATCH] arm: mach-k3: Refactor QoS settings

2024-02-06 Thread Andrew Davis
default y if CPU_V7R && SOC_K3_AM62A7 If this is R5 only, then put it in the arch/arm/mach-k3/r5 Kconfig and you can drop the CPU_V7R check. Andrew + help + This option enables the R5 SPL to apply QoS settings for various + HW controllers inside the TI K3 SoCs.

Re: [PATCH v2 05/13] arm: mach-k3: invert logic for split DM firmware config

2024-02-02 Thread Andrew Davis
_K3_AM654 && !CLK_TI_SCI && !TI_SCI_POWER_DOMAIN Always amusing to see how many SoCs get added to these lists before someone realizes there is only one or two SoCs that are not on the list :) BTW, this whole file is inside an "if ARCH_K3" block, so all symbols depend on

Re: [PATCH v2 10/13] arm: dts: introduce am62p5 uboot dts files

2024-02-02 Thread Andrew Davis
On 2/2/24 10:28 AM, Bryan Brattlof wrote: Hi Andrew! On February 2, 2024 thus sayeth Andrew Davis: On 1/31/24 9:06 PM, Bryan Brattlof wrote: Include the uboot device tree files needed to boot the board. Signed-off-by: Bryan Brattlof --- arch/arm/dts/Makefile |2

Re: [PATCH v2 10/13] arm: dts: introduce am62p5 uboot dts files

2024-02-02 Thread Andrew Davis
mmy) * through a SYSFW PM-init step and will need a re-init in some way * due to changing module clock frequencies. */ - if (IS_ENABLED(CONFIG_K3_EARLY_CONS)) + if (IS_ENABLED(CONFIG_K3_EARLY_CONS)) { Looks like fixes for a previous patch that didn't ge

[PATCH 3/6] arm: mach-k3: Move tispl.bin loading into R5 directory

2024-02-01 Thread Andrew Davis
ATF, OPTEE, DM (tispl.bin) loading is only ever done by the R5 core, move the code into the R5 directory. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/common.c| 248 +- arch/arm/mach-k3/r5/common.c | 249 +++ 2 files

[PATCH 2/6] arm: mach-k3: Move disable_linefill_optimization() into R5 directory

2024-02-01 Thread Andrew Davis
The disable_linefill_optimization() function is only ever loaded by the R5 core, move the code into the R5 directory. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/common.c| 25 - arch/arm/mach-k3/r5/Makefile | 1 + arch/arm/mach-k3/r5/common.c | 35

[PATCH 6/6] arm: mach-k3: Move ARM64 specific code into new arm64 directory

2024-02-01 Thread Andrew Davis
Like we did with R5, move ARM64 code into a specific directory to make it clear what code is only meant to run on each core type. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/Makefile| 3 +-- arch/arm/mach-k3/arm64/Makefile | 6 ++ arch/arm/mach-k3/{ => ar

[PATCH 5/6] arm: mach-k3: Move firewall removal into R5 directory

2024-02-01 Thread Andrew Davis
Firewalls are only ever removed by the R5 core, move this code into the R5 directory. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/common.c| 44 arch/arm/mach-k3/r5/common.c | 44 2 files changed, 44 insertions

[PATCH 4/6] arm: mach-k3: am62a7: Disable firewalls only after loading SYSFW

2024-02-01 Thread Andrew Davis
Currently we do this multiple times, instead just do it once after loading SYSFW in R5 SPL. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/am62a7_init.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-k3/am62a7_init.c b/arch/arm/mach-k3/am62a7_init.c

[PATCH 1/6] arm: mach-k3: Move SYS_K3_SPL_ATF definition into R5 Kconfig

2024-02-01 Thread Andrew Davis
Loading ATF is only supported from the R5, move the Kconfig symbol definition to match. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/Kconfig| 7 --- arch/arm/mach-k3/r5/Kconfig | 6 ++ 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/arch/arm/mach-k3/Kconfig b/arch

[PATCH 1/2] arm: dts: k3-am64: Sync with kernel v6.7-rc1

2024-02-01 Thread Andrew Davis
From: Nishanth Menon Sync with kernel v6.7-rc1 and sync up the u-boot dts files accordingly. Signed-off-by: Nishanth Menon Signed-off-by: Andrew Davis --- arch/arm/dts/k3-am64-main.dtsi| 37 ++--- arch/arm/dts/k3-am64-mcu.dtsi | 2 + arch/arm/dts/k3-am64.dtsi

[PATCH 2/2] arm: dts: k3-am64: Sync with kernel v6.8-rc1

2024-02-01 Thread Andrew Davis
Sync with kernel v6.8-rc1 and sync up the u-boot dts files accordingly. Signed-off-by: Andrew Davis --- arch/arm/dts/k3-am64-main.dtsi| 22 +- arch/arm/dts/k3-am642-evm-u-boot.dtsi | 21 + arch/arm/dts/k3-am642-evm.dts | 12

Re: [PATCH v8 15/16] configs: Add am69_sk_* defconfig fragments

2024-01-31 Thread Andrew Davis
On 1/29/24 12:26 PM, Apurva Nandan wrote: On 23/01/24 20:31, Andrew Davis wrote: On 1/23/24 8:39 AM, Apurva Nandan wrote: Hi Andrew, On 20/01/24 00:43, Andrew Davis wrote: On 1/19/24 11:50 AM, Apurva Nandan wrote: From: Dasnavis Sabiya Add config fragments for am69_sk A72 and R5

Re: [PATCH] firmware: ti_sci: fix the secure_hdr in do_xfer

2024-01-25 Thread Andrew Davis
just drop this code and if we ever need it then we add it back over in the right spot at that time. Andrew memcpy(&secure_buf[sizeof(secure_hdr)], xfer->tx_message.buf, xfer->tx_message.len); which is basically trying to create a 4 byte offset (trying to abide by the secure msg for

Re: [PATCH v8 15/16] configs: Add am69_sk_* defconfig fragments

2024-01-23 Thread Andrew Davis
On 1/23/24 8:39 AM, Apurva Nandan wrote: Hi Andrew, On 20/01/24 00:43, Andrew Davis wrote: On 1/19/24 11:50 AM, Apurva Nandan wrote: From: Dasnavis Sabiya Add config fragments for am69_sk A72 and R5 configuration. This applies on to: j784s4_evm_a72_defconfig -> am69_sk_a72.con

Re: [PATCH v8 15/16] configs: Add am69_sk_* defconfig fragments

2024-01-19 Thread Andrew Davis
not confuse buildman which seems to directly parse the configs for arch detection). Andrew @@ -0,0 +1,5 @@ +# Defconfig fragment to apply on top of j784s4_evm_a72_defconfig + +CONFIG_DEFAULT_DEVICE_TREE="k3-am69-sk" +CONFIG_SPL_OF_LIST="k3-am69-sk" +CONFIG_OF_LIST="

Re: [PATCH RFC] Kconfig: Add support for FIT image signature enforcing

2024-01-17 Thread Andrew Davis
+ having keys and allows booting the images without having proper setup. s/be having/have Andrew + This option enforces the FIT signature mechanism to contain the keys in + the DTB and enforce the nodes to be authenticated without relying on + th

Re: [PATCH v3 0/8] Suspend to RAM support for K3 J7200

2024-01-12 Thread Andrew Davis
On 1/10/24 3:34 AM, Thomas Richard wrote: On 1/9/24 18:32, Andrew Davis wrote: On 1/8/24 10:56 AM, Thomas Richard wrote: This series is the U-Boot part of the work to add the suspend to RAM support for the K3 J7200 EVM board. During the boot R5 SPL makes a copy of DM-Firmware and TF-A in

Re: [PATCH v3 0/8] Suspend to RAM support for K3 J7200

2024-01-09 Thread Andrew Davis
unprotected. Then why post this? If it is just to get some eyes on it, then label it as an "RFC" so our silence isn't considered acceptance, otherwise we have to manually NAK these each time. Andrew [1] https://lore.kernel.org/all/20231229-binman-firewalling-v7-0-47ed4af30...@ti.com/

Re: [PATCH 08/10] board: beagle: beagleboneai64: Set fdtfile from C code instead of findfdt script

2024-01-08 Thread Andrew Davis
warning for "findfdt" like your commit message says you do..). Andrew + env_set("fdtfile", fdtfile); + + return 0; +} +#endif diff --git a/board/beagle/beagleboneai64/beagleboneai64.env b/board/beagle/beagleboneai64/beagleboneai64.env index 4f0a94a8113e

Re: [PATCH 01/10] board: ti: common: Introduce a common fdt ops library

2024-01-08 Thread Andrew Davis
fdt) + env_set("name_fdt", name_fdt); "name_fdt" should match "fdtfile", you should have just: env_set("name_fdt", fdtfile); are you mixing this up with "board_name"? Andrew + /* Also set the findfdt legacy script to warn us

Re: [PATCH 1/2] board: ti: am62x: am62x.env: Fix boot_targets

2024-01-04 Thread Andrew Davis
On 1/4/24 1:52 AM, Manorit Chawdhry wrote: Hi Andrew, Simon, On 08:58-20240102, Andrew Davis wrote: On 12/31/23 6:48 AM, Simon Glass wrote: Hi, On Wed, Nov 29, 2023 at 7:48 PM Simon Glass wrote: Hi Andrew, On Mon, 6 Nov 2023 at 11:05, Andrew Davis wrote: On 11/6/23 11:47 AM, Simon

  1   2   3   4   5   6   7   8   9   10   >