Re: [U-Boot] [PATCH 08/11] Blackfin: bf60x: add rsi/sdh support

2013-03-04 Thread Wolfgang Denk
Dear Sonic Zhang, In message cajxxz0o_ozk7w_cdfjkzpwdmfqwt1m-yn_bz6yzhrdfqt6w...@mail.gmail.com you wrote: Maybe I didn't describe it clearly. Yes, I return 0 at the end of this function. But, the same function may return UNUSABLE_ERR(-17) at the beginning if the data flags match

Re: [U-Boot] [PATCH 08/11] Blackfin: bf60x: add rsi/sdh support

2013-03-04 Thread Sonic Zhang
Hi Wolfgang, On Mon, Mar 4, 2013 at 7:21 PM, Wolfgang Denk w...@denx.de wrote: Dear Sonic Zhang, In message cajxxz0o_ozk7w_cdfjkzpwdmfqwt1m-yn_bz6yzhrdfqt6w...@mail.gmail.com you wrote: Maybe I didn't describe it clearly. Yes, I return 0 at the end of this function. But, the same

Re: [U-Boot] [PATCH 08/11] Blackfin: bf60x: add rsi/sdh support

2013-02-17 Thread Wolfgang Denk
Dear Sonic Zhang, In message cajxxz0otwow6x2kx8yaujtrxc6qicvpmo2rp4mhwjqvqubh...@mail.gmail.com you wrote: @@ -113,16 +131,19 @@ static int sdh_setup_data(struct mmc *mmc, struct mmc_data *data) ... - int ret = 0; ... - return ret; + return 0; If this function can

Re: [U-Boot] [PATCH 08/11] Blackfin: bf60x: add rsi/sdh support

2013-02-17 Thread Sonic Zhang
Hi Wolfgang, On Mon, Feb 18, 2013 at 4:15 AM, Wolfgang Denk w...@denx.de wrote: Dear Sonic Zhang, In message cajxxz0otwow6x2kx8yaujtrxc6qicvpmo2rp4mhwjqvqubh...@mail.gmail.com you wrote: @@ -113,16 +131,19 @@ static int sdh_setup_data(struct mmc *mmc, struct mmc_data *data) ... -

Re: [U-Boot] [PATCH 08/11] Blackfin: bf60x: add rsi/sdh support

2013-02-08 Thread Sonic Zhang
On Thu, Feb 7, 2013 at 6:17 PM, Wolfgang Denk w...@denx.de wrote: Dear Sonic Zhang, In message 1360223258-6945-9-git-send-email-sonic@gmail.com you wrote: From: Sonic Zhang sonic.zh...@analog.com Add rsi/sdh support for bf60x. Checkpatch errors. Please fix. @@ -113,16 +131,19 @@

Re: [U-Boot] [PATCH 08/11] Blackfin: bf60x: add rsi/sdh support

2013-02-07 Thread Wolfgang Denk
Dear Sonic Zhang, In message 1360223258-6945-9-git-send-email-sonic@gmail.com you wrote: From: Sonic Zhang sonic.zh...@analog.com Add rsi/sdh support for bf60x. Checkpatch errors. Please fix. @@ -113,16 +131,19 @@ static int sdh_setup_data(struct mmc *mmc, struct mmc_data *data) ...

Re: [U-Boot] [PATCH 08/11] Blackfin: bf60x: add rsi/sdh support

2013-02-07 Thread Sonic Zhang
On Thu, Feb 7, 2013 at 6:17 PM, Wolfgang Denk w...@denx.de wrote: Dear Sonic Zhang, In message 1360223258-6945-9-git-send-email-sonic@gmail.com you wrote: From: Sonic Zhang sonic.zh...@analog.com Add rsi/sdh support for bf60x. Checkpatch errors. Please fix. OK @@ -113,16 +131,19

[U-Boot] [PATCH 08/11] Blackfin: bf60x: add rsi/sdh support

2013-02-06 Thread Sonic Zhang
From: Sonic Zhang sonic.zh...@analog.com Add rsi/sdh support for bf60x. Signed-off-by: Sonic Zhang sonic.zh...@analog.com Signed-off-by: Bob Liu lliu...@gmail.com --- arch/blackfin/include/asm/mach-common/bits/sdh.h | 38 +++- drivers/mmc/bfin_sdh.c | 68