Re: [U-Boot] [PATCH 1/2] flash/cfi_flash: Use virtual sector start address, not phys

2009-02-05 Thread Stefan Roese
On Tuesday 03 February 2009, Kumar Gala wrote: > On Feb 3, 2009, at 2:53 AM, Pieter wrote: > >> static inline void flash_unmap(flash_info_t *info, flash_sect_t sect, > >>unsigned int offset, void *addr) > >> { > >> - unsigned int byte_offset = offset * info->portwidth; > >> - > >> - u

Re: [U-Boot] [PATCH 1/2] flash/cfi_flash: Use virtual sector start address, not phys

2009-02-05 Thread Stefan Roese
On Monday 02 February 2009, Becky Bruce wrote: > include/flash.h was commented to say that the address in > flash_info->start was a physical address. However, from u-boot's > point of view, and looking at most flash code, it makes more > sense for this to be a virtual address. So I corrected the

Re: [U-Boot] [PATCH 1/2] flash/cfi_flash: Use virtual sector start address, not phys

2009-02-03 Thread Becky Bruce
On Feb 3, 2009, at 8:48 AM, Kumar Gala wrote: > > On Feb 3, 2009, at 2:53 AM, Pieter wrote: > >>> >>> static inline void flash_unmap(flash_info_t *info, flash_sect_t >>> sect, >>> unsigned int offset, void *addr) >>> { >>> - unsigned int byte_offset = offset * info->portwidth; >>>

Re: [U-Boot] [PATCH 1/2] flash/cfi_flash: Use virtual sector start address, not phys

2009-02-03 Thread Kumar Gala
On Feb 3, 2009, at 2:53 AM, Pieter wrote: >> >> static inline void flash_unmap(flash_info_t *info, flash_sect_t sect, >> unsigned int offset, void *addr) >> { >> -unsigned int byte_offset = offset * info->portwidth; >> - >> -unmap_physmem(addr, flash_sector_size(info, sect) -

Re: [U-Boot] [PATCH 1/2] flash/cfi_flash: Use virtual sector start address, not phys

2009-02-03 Thread Pieter
Becky Bruce wrote: > include/flash.h was commented to say that the address in > flash_info->start was a physical address. However, from u-boot's > point of view, and looking at most flash code, it makes more > sense for this to be a virtual address. So I corrected the > comment to indicate that t

[U-Boot] [PATCH 1/2] flash/cfi_flash: Use virtual sector start address, not phys

2009-02-02 Thread Becky Bruce
include/flash.h was commented to say that the address in flash_info->start was a physical address. However, from u-boot's point of view, and looking at most flash code, it makes more sense for this to be a virtual address. So I corrected the comment to indicate that this was a virtual address. T