> -Original Message-
> From: Peng Fan
> Sent: 2019年8月27日 9:10
> To: Schrempf Frieder ; lu...@denx.de;
> sba...@denx.de; feste...@gmail.com
> Cc: dl-uboot-imx ; u-boot@lists.denx.de
> Subject: RE: [PATCH 22/22] imx: Add i.MX8MM EVK board support.
>
> > Subject: Re: [PATCH 22/22] imx: Add
> Subject: Re: [PATCH 22/22] imx: Add i.MX8MM EVK board support.
>
> On 15.08.19 02:57, Peng Fan wrote:
> >> Subject: Re: [PATCH 22/22] imx: Add i.MX8MM EVK board support.
> >>
> >> On 09.08.19 06:15, Peng Fan wrote:
> >>> Add board and SoC dts
> >>> Add ddr training code
> >>> support
On 15.08.19 02:57, Peng Fan wrote:
>> Subject: Re: [PATCH 22/22] imx: Add i.MX8MM EVK board support.
>>
>> On 09.08.19 06:15, Peng Fan wrote:
>>> Add board and SoC dts
>>> Add ddr training code
>>> support SD/MMC/GPIO/PINCTRL/UART
>>>
>>> Signed-off-by: Peng Fan
>>> ---
>>>
> Subject: Re: [PATCH 22/22] imx: Add i.MX8MM EVK board support.
>
> On 09.08.19 06:15, Peng Fan wrote:
> > Add board and SoC dts
> > Add ddr training code
> > support SD/MMC/GPIO/PINCTRL/UART
> >
> > Signed-off-by: Peng Fan
> > ---
> > arch/arm/dts/Makefile |3 +-
On 09.08.19 06:15, Peng Fan wrote:
> Add board and SoC dts
> Add ddr training code
> support SD/MMC/GPIO/PINCTRL/UART
>
> Signed-off-by: Peng Fan
> ---
> arch/arm/dts/Makefile |3 +-
> arch/arm/dts/imx8mm-evk-u-boot.dtsi| 92 ++
>
Hi Peng,
I think that I've made a review to the code adding some i.MX8 board in
the past, but I do see that those comments were not applied:
1. The DDR4 configuration code as a very large table of magic numbers
(but there is a commented out CONFIG_ to train the DDR4 in .h
file.
2. Not using
Add board and SoC dts
Add ddr training code
support SD/MMC/GPIO/PINCTRL/UART
Signed-off-by: Peng Fan
---
arch/arm/dts/Makefile |3 +-
arch/arm/dts/imx8mm-evk-u-boot.dtsi| 92 ++
arch/arm/dts/imx8mm-evk.dts| 235
7 matches
Mail list logo
