Re: [U-Boot] [PATCH V2] Allow PHY addresses on kirkwood egiga to be non continuous.

2010-06-28 Thread Prafulla Wadaskar
> -Original Message- > From: Wolfgang Denk [mailto:w...@denx.de] > Sent: Monday, June 28, 2010 5:32 PM > To: Tor Krill > Cc: Prafulla Wadaskar; u-boot@lists.denx.de > Subject: Re: [U-Boot] [PATCH V2] Allow PHY addresses on > kirkwood egiga to be non continuous

Re: [U-Boot] [PATCH V2] Allow PHY addresses on kirkwood egiga to be non continuous.

2010-06-28 Thread Wolfgang Denk
Dear Tor Krill, In message <1277716302.2221.37.ca...@tor-desktop> you wrote: > > > 2. For the boards using single port will also need to configure PHY address > > for other port, which is meaningless, unnecessary and confusing. > > Sure you had to put something there to be on the safe side. But

Re: [U-Boot] [PATCH V2] Allow PHY addresses on kirkwood egiga to be non continuous.

2010-06-28 Thread Tor Krill
On Thu, 2010-06-24 at 18:37 +0200, Mike Frysinger wrote: > On Thursday, June 24, 2010 05:31:47 Tor Krill wrote: > > void reset_phy(void) > > { > > char *name = "egiga0"; > > + u8 port_addr[] = CONFIG_PHY_ADDRS; > > > > if (miiphy_set_current_dev(name)) > > return; > > > >

Re: [U-Boot] [PATCH V2] Allow PHY addresses on kirkwood egiga to be non continuous.

2010-06-28 Thread Tor Krill
On Thu, 2010-06-24 at 14:26 +0200, Prafulla Wadaskar wrote: > > > -Original Message- > > From: Tor Krill [mailto:t...@excito.com] > > Sent: Thursday, June 24, 2010 5:05 PM > > To: Prafulla Wadaskar > > Cc: u-boot@lists.denx.de > > Subject: RE: [PATCH V2] Allow PHY addresses on kirkwood eg

Re: [U-Boot] [PATCH V2] Allow PHY addresses on kirkwood egiga to be non continuous.

2010-06-24 Thread Albert ARIBAUD
Hi all, Le 24/06/2010 18:37, Mike Frysinger a écrit : > i dont know anything about the kirkwood_egiga, but cant you have more than one > instance on a board ? if so, it'd make more sense to change the phy addr > define stuff into an array argument that gets passed to the driver init func. > -mik

Re: [U-Boot] [PATCH V2] Allow PHY addresses on kirkwood egiga to be non continuous.

2010-06-24 Thread Mike Frysinger
On Thursday, June 24, 2010 05:31:47 Tor Krill wrote: > void reset_phy(void) > { > char *name = "egiga0"; > + u8 port_addr[] = CONFIG_PHY_ADDRS; > > if (miiphy_set_current_dev(name)) > return; > > /* reset the phy */ > - miiphy_reset(name, CONFIG_PHY_BASE_

Re: [U-Boot] [PATCH V2] Allow PHY addresses on kirkwood egiga to be non continuous.

2010-06-24 Thread Tor Krill
Hi Prafulla, On Thu, 2010-06-24 at 13:22 +0200, Prafulla Wadaskar wrote: > > > -Original Message- > > From: Tor Krill [mailto:t...@excito.com] > > Sent: Thursday, June 24, 2010 3:02 PM > > To: u-boot@lists.denx.de > > Cc: Prafulla Wadaskar; Tor Krill > > Subject: [PATCH V2] Allow PHY ad

Re: [U-Boot] [PATCH V2] Allow PHY addresses on kirkwood egiga to be non continuous.

2010-06-24 Thread Prafulla Wadaskar
> -Original Message- > From: Tor Krill [mailto:t...@excito.com] > Sent: Thursday, June 24, 2010 3:02 PM > To: u-boot@lists.denx.de > Cc: Prafulla Wadaskar; Tor Krill > Subject: [PATCH V2] Allow PHY addresses on kirkwood egiga to > be non continuous. > > Changing its configuration from

[U-Boot] [PATCH V2] Allow PHY addresses on kirkwood egiga to be non continuous.

2010-06-24 Thread Tor Krill
Changing its configuration from PHY_BASE_ADR single value to use CONFIG_PHY_BASE_ADDRS as an array with adresses. Updated in version 2: Merged board updates to single patch. Signed-off-by: Tor Krill --- board/keymile/km_arm/km_arm.c |3 ++- drivers/net/kirkwood_egiga.c |3 ++- drivers