Re: [U-Boot] [PATCH v2 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-25 Thread Ajay Bhargav
- "Mike Frysinger" wrote: > On Thursday, August 25, 2011 01:10:30 Ajay Bhargav wrote: > > - "Mike Frysinger" wrote: > > > On Wednesday, August 24, 2011 09:07:18 Ajay Bhargav wrote: > > > > + /* Read mac from env if available */ > > > > + eth_getenv_enetaddr("ethaddr", dev->e

Re: [U-Boot] [PATCH v2 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-25 Thread Mike Frysinger
On Thursday, August 25, 2011 01:10:30 Ajay Bhargav wrote: > - "Mike Frysinger" wrote: > > On Wednesday, August 24, 2011 09:07:18 Ajay Bhargav wrote: > > > + /* Read mac from env if available */ > > > + eth_getenv_enetaddr("ethaddr", dev->enetaddr); > > > > you shouldnt need to do this. the h

Re: [U-Boot] [PATCH v2 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-25 Thread Ajay Bhargav
- "Marek Vasut" wrote: > On Thursday, August 25, 2011 01:07:32 PM Ajay Bhargav wrote: > > - "Marek Vasut" wrote: > > > > [...] > > > > > > +static void abortdma(struct eth_device *dev) > > > > +{ > > > > + struct armdfec_device *darmdfec = to_darmdfec(dev); > > > > + struc

Re: [U-Boot] [PATCH v2 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-25 Thread Marek Vasut
On Thursday, August 25, 2011 01:07:32 PM Ajay Bhargav wrote: > - "Marek Vasut" wrote: > > [...] > > > > +static void abortdma(struct eth_device *dev) > > > +{ > > > + struct armdfec_device *darmdfec = to_darmdfec(dev); > > > + struct armdfec_reg *regs = darmdfec->regs; > > > + int delay; > >

Re: [U-Boot] [PATCH v2 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-25 Thread Marek Vasut
On Thursday, August 25, 2011 07:21:25 AM Ajay Bhargav wrote: > - "Marek Vasut" wrote: > > On Wednesday, August 24, 2011 03:07:18 PM Ajay Bhargav wrote: > > > This patch adds support for Fast Ethernet Controller driver for > > > Armada100 series. > > > > > > Signed-off-by: Ajay Bhargav > > >

Re: [U-Boot] [PATCH v2 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-25 Thread Marek Vasut
On Thursday, August 25, 2011 07:24:22 AM Ajay Bhargav wrote: > - "Marek Vasut" wrote: > > On Wednesday, August 24, 2011 05:42:06 PM Mike Frysinger wrote: > > > On Wednesday, August 24, 2011 09:07:18 Ajay Bhargav wrote: > > > > + darmdfec->p_rxdesc = (struct rx_desc *) > > > > memalign(P

Re: [U-Boot] [PATCH v2 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-25 Thread Ajay Bhargav
- "Marek Vasut" wrote: [...] > > +static void abortdma(struct eth_device *dev) > > +{ > > + struct armdfec_device *darmdfec = to_darmdfec(dev); > > + struct armdfec_reg *regs = darmdfec->regs; > > + int delay; > > + int maxretries = 40; > > + > > + do { > > + writel(SDMA_

Re: [U-Boot] [PATCH v2 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-24 Thread Ajay Bhargav
- "Marek Vasut" wrote: > On Wednesday, August 24, 2011 05:42:06 PM Mike Frysinger wrote: > > On Wednesday, August 24, 2011 09:07:18 Ajay Bhargav wrote: > > > + darmdfec->p_rxdesc = (struct rx_desc *) > memalign(PKTALIGN, > > > + ARMDFEC_RXQ_DESC_ALIGNED_SIZE * RIN

Re: [U-Boot] [PATCH v2 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-24 Thread Ajay Bhargav
- "Marek Vasut" wrote: > On Wednesday, August 24, 2011 03:07:18 PM Ajay Bhargav wrote: > > This patch adds support for Fast Ethernet Controller driver for > > Armada100 series. > > > > Signed-off-by: Ajay Bhargav > > --- > > [...] > [...] > > + > > +static int armdfec_phy_timeout(u32 reg

Re: [U-Boot] [PATCH v2 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-24 Thread Ajay Bhargav
- "Mike Frysinger" wrote: > On Wednesday, August 24, 2011 09:07:18 Ajay Bhargav wrote: > > + darmdfec->p_rxdesc = (struct rx_desc *) memalign(PKTALIGN, > > + ARMDFEC_RXQ_DESC_ALIGNED_SIZE * RINGSZ + > 1); > > memalign() returns a void*, so you shouldnt need to ca

Re: [U-Boot] [PATCH v2 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-24 Thread Marek Vasut
On Wednesday, August 24, 2011 05:42:06 PM Mike Frysinger wrote: > On Wednesday, August 24, 2011 09:07:18 Ajay Bhargav wrote: > > + darmdfec->p_rxdesc = (struct rx_desc *) memalign(PKTALIGN, > > + ARMDFEC_RXQ_DESC_ALIGNED_SIZE * RINGSZ + 1); > > memalign() returns a void

Re: [U-Boot] [PATCH v2 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-24 Thread Marek Vasut
On Wednesday, August 24, 2011 03:07:18 PM Ajay Bhargav wrote: > This patch adds support for Fast Ethernet Controller driver for > Armada100 series. > > Signed-off-by: Ajay Bhargav > --- [...] > diff --git a/drivers/net/armada100_fec.c b/drivers/net/armada100_fec.c > new file mode 100644 > index

Re: [U-Boot] [PATCH v2 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-24 Thread Mike Frysinger
On Wednesday, August 24, 2011 09:07:18 Ajay Bhargav wrote: > + darmdfec->p_rxdesc = (struct rx_desc *) memalign(PKTALIGN, > + ARMDFEC_RXQ_DESC_ALIGNED_SIZE * RINGSZ + 1); memalign() returns a void*, so you shouldnt need to cast its return value (you do this a couple of

[U-Boot] [PATCH v2 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-24 Thread Ajay Bhargav
This patch adds support for Fast Ethernet Controller driver for Armada100 series. Signed-off-by: Ajay Bhargav --- Changes for v2: - removed random MAC generation - driver init function changed to register as per new naming convention - code cleanup (Thanks to Wolfgang, Mar