Re: [PATCH v1 7/9] configs: gxp: add core support

2022-06-02 Thread Tom Rini
On Thu, Jun 02, 2022 at 02:46:09PM +, Hawkins, Nick wrote: > > > > Can we figure any of that out dynamically instead? Since > > CONFIG_SYS_SDRAM_SIZE is only used (for ARM) in board code, I'd rather see > > this handled in there, with SZ_xxx and not use CONFIG_SYS_SDRAM_SIZE at all. > > H

RE: [PATCH v1 7/9] configs: gxp: add core support

2022-06-02 Thread Hawkins, Nick
> Can we figure any of that out dynamically instead? Since > CONFIG_SYS_SDRAM_SIZE is only used (for ARM) in board code, I'd rather see > this handled in there, with SZ_xxx and not use CONFIG_SYS_SDRAM_SIZE at all. Hi Tom, Would something like this be acceptable? int dram_init(void) { #ifd

Re: [PATCH v1 7/9] configs: gxp: add core support

2022-06-01 Thread Tom Rini
On Thu, May 26, 2022 at 01:55:46PM -0500, nick.hawk...@hpe.com wrote: > From: Nick Hawkins > > Add the include file for the gxp soc. > > Signed-off-by: Nick Hawkins [snip] > +#ifdef CONFIG_TARGET_GXP > +#ifdef CONFIG_GXP_ECC > +#define CONFIG_SYS_SDRAM_SIZE 0x0f80 > +#else > +