On Thu, May 26, 2022 at 01:55:46PM -0500, nick.hawk...@hpe.com wrote: > From: Nick Hawkins <nick.hawk...@hpe.com> > > Add the include file for the gxp soc. > > Signed-off-by: Nick Hawkins <nick.hawk...@hpe.com> [snip] > +#ifdef CONFIG_TARGET_GXP > +#ifdef CONFIG_GXP_ECC > + #define CONFIG_SYS_SDRAM_SIZE 0x0f800000 > +#else > + #define CONFIG_SYS_SDRAM_SIZE 0x1f000000 > +#endif > + > +#ifdef CONFIG_GXP_VROM_64MB > + #undef CONFIG_SYS_SDRAM_SIZE > + #ifdef CONFIG_GXP_ECC > + #define CONFIG_SYS_SDRAM_SIZE 0x0c000000 > + #else > + #define CONFIG_SYS_SDRAM_SIZE 0x18000000 > + #endif > +#endif
Can we figure any of that out dynamically instead? Since CONFIG_SYS_SDRAM_SIZE is only used (for ARM) in board code, I'd rather see this handled in there, with SZ_xxx and not use CONFIG_SYS_SDRAM_SIZE at all. -- Tom
signature.asc
Description: PGP signature
