> Can we figure any of that out dynamically instead? Since > CONFIG_SYS_SDRAM_SIZE is only used (for ARM) in board code, I'd rather see > this handled in there, with SZ_xxx and not use CONFIG_SYS_SDRAM_SIZE at all. Hi Tom, Would something like this be acceptable? int dram_init(void) { #ifdef CONFIG_TARGET_GXP #ifdef CONFIG_GXP_ECC gd->ram_size = SZ_128M + SZ_64M + SZ_32M + SZ_16M + SZ_8M; #else gd->ram_size = SZ_256M + SZ_128M + SZ_64M + SZ_32M + SZ_16M; #endif #endif #ifdef CONFIG_GXP_VROM_64MB #ifdef CONFIG_GXP_ECC gd->ram_size = SZ_128M + SZ_64M; #else gd->ram_size = SZ_256M + SZ_128M; #endif #endif return 0; } Thanks for the feedback, -Nick Hawkins
- [PATCH v1 1/9] ARM: hpe: gxp: add core support nick . hawkins
- [PATCH v1 2/9] timer: gxp: Add HPE GXP timer support nick . hawkins
- [PATCH v1 3/9] board: hpe: gxp: add HPE GXP soc suppor... nick . hawkins
- [PATCH v1 5/9] dt-bindings: timer: Add hpe gxp timer nick . hawkins
- [PATCH v1 4/9] dt-bindings: arm: hpe: add GXP Support nick . hawkins
- [PATCH v1 7/9] configs: gxp: add core support nick . hawkins
- Re: [PATCH v1 7/9] configs: gxp: add core support Tom Rini
- RE: [PATCH v1 7/9] configs: gxp: add core supp... Hawkins, Nick
- [PATCH v1 8/9] configs: gxp: add gxp_defconfig nick . hawkins
- [PATCH v1 6/9] ARM: dts: Add device tree files for hpe... nick . hawkins
- Re: [PATCH v1 6/9] ARM: dts: Add device tree files... Tom Rini
- RE: [PATCH v1 6/9] ARM: dts: Add device tree f... Hawkins, Nick
- Re: [PATCH v1 6/9] ARM: dts: Add device tr... Tom Rini
- RE: [PATCH v1 6/9] ARM: dts: Add devi... Hawkins, Nick
- RE: [PATCH v1 6/9] ARM: dts: Add ... Hawkins, Nick
- Re: [PATCH v1 6/9] ARM: dts: ... Tom Rini
- RE: [PATCH v1 6/9] ARM: dts: ... Hawkins, Nick