[PATCH 10/10] include: env: ti: Drop default_findfdt

2024-01-08 Thread Nishanth Menon
We shouldn't need finfdt anymore. Drop the env script. Signed-off-by: Nishanth Menon --- include/env/ti/default_findfdt.env | 12 1 file changed, 12 deletions(-) delete mode 100644 include/env/ti/default_findfdt.env diff --git a/include/env/ti/default_findfdt.env b/includ

[PATCH 01/10] board: ti: common: Introduce a common fdt ops library

2024-01-08 Thread Nishanth Menon
-by: Nishanth Menon --- board/ti/common/Kconfig | 12 board/ti/common/Makefile | 1 + board/ti/common/fdt_ops.c | 65 +++ board/ti/common/fdt_ops.h | 41 4 files changed, 119 insertions(+) create mode 100644 board/ti/common

[PATCH 03/10] board: ti: am62x: Set fdtfile from C code instead of findfdt script

2024-01-08 Thread Nishanth Menon
Stop using the findfdt script and switch to setting the fdtfile from C code. While at this, replace findfdt in environment with a warning as it is no longer needed Signed-off-by: Nishanth Menon --- board/ti/am62x/am62x.env| 1 - board/ti/am62x/evm.c| 8 configs

[PATCH 06/10] board: ti: j721e: Set fdtfile from C code instead of findfdt script

2024-01-08 Thread Nishanth Menon
We now can provide a map and have the standard fdtfile variable set from code itself. This allows for bootstd to "just work". While at this, replace findfdt in environment with a warning as it is no longer needed. Signed-off-by: Nishanth Menon --- board/ti/j721e/evm.c | 8 +

[PATCH 00/10] board/ti: k3 boards: Stop using findfdt

2024-01-08 Thread Nishanth Menon
ge. Based on next branch at: c2c598e87cfe Merge branch 'staging' of https://source.denx.de/u-boot/custodians/u-boot-tegra into next Nishanth Menon (10): board: ti: common: Introduce a common fdt ops library board: ti: am62ax: Set fdtfile from C code instead of findfdt script b

[PATCH 05/10] board: ti: am65x: Set fdtfile from C code instead of findfdt script

2024-01-08 Thread Nishanth Menon
We now can provide a map and have the standard fdtfile variable set from code itself. This allows for bootstd to "just work". While at this, replace findfdt in environment with a warning as it is no longer needed. Signed-off-by: Nishanth Menon --- board/ti/am65x/am65x.env | 3 ---

[PATCH 04/10] board: ti: am64x: Set fdtfile from C code instead of findfdt script

2024-01-08 Thread Nishanth Menon
We now can provide a map and have the standard fdtfile variable set from code itself. This allows for bootstd to "just work". While at this, replace findfdt in environment with a warning as it is no longer needed. Signed-off-by: Nishanth Menon --- board/ti/am64x/am64x.env | 9 --

[PATCH 09/10] board: beagle: beagleplay: Set fdtfile from C code instead of findfdt script

2024-01-08 Thread Nishanth Menon
Stop using the findfdt script and switch to setting the fdtfile from C code. While at this, replace findfdt in environment with a warning as it is no longer needed. Signed-off-by: Nishanth Menon --- board/beagle/beagleplay/beagleplay.c | 14 ++ board/beagle/beagleplay

[PATCH 02/10] board: ti: am62ax: Set fdtfile from C code instead of findfdt script

2024-01-08 Thread Nishanth Menon
Stop using the findfdt script and switch to setting the fdtfile from C code. While at this, replace findfdt in environment with a warning as it is no longer needed Signed-off-by: Nishanth Menon --- board/ti/am62ax/am62ax.env | 1 - board/ti/am62ax/evm.c| 10

Re: [PATCH 01/10] board: ti: common: Introduce a common fdt ops library

2024-01-08 Thread Nishanth Menon
On 12:50-20240108, Andrew Davis wrote: > On 1/8/24 11:32 AM, Nishanth Menon wrote: > > Introduce a common fdt operations library for basic device tree > > operations that are common between various boards. > > > > The first library to introduce here is the capability

Re: [PATCH 08/10] board: beagle: beagleboneai64: Set fdtfile from C code instead of findfdt script

2024-01-08 Thread Nishanth Menon
t" and adds warning for > "findfdt" like your commit message says you do..). Will fix up the commit message in the next revision -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH 01/10] board: ti: common: Introduce a common fdt ops library

2024-01-09 Thread Nishanth Menon
; > > + * @fdt_file_name: device tree blob name as described by kernel > > + */ > > +struct ti_fdt_map { > > + const char *name_fdt; > > + char *fdt_file_name; > > +}; > > + > > +/** > > + * ti_set_fdt_env - Find the correct device tree file name and set > > 'fdtfile' > > "Find the correct device tree file name based on the board name and "... OK. > > > + * env variable with correct folder structure appropriate to the > > architecture > > + * and kernel conventions. This function is invoked typically as part of > > + * board_late_init > > + * > > + * fdt name is picked by: > > + * a) If a match is found, use the match > > "a) If a board name match is found, use the match" OK. [...] -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH 08/10] board: beagle: beagleboneai64: Set fdtfile from C code instead of findfdt script

2024-01-09 Thread Nishanth Menon
On 20:24-20240108, Jon Humphreys wrote: > Nishanth Menon writes: > > > Stop using the findfdt script and switch to setting the fdtfile from C > > code. > > > > While at this, replace findfdt in environment with a warning as it is > > no longer needed &

Re: [PATCH 02/10] board: ti: am62ax: Set fdtfile from C code instead of findfdt script

2024-01-09 Thread Nishanth Menon
just returns a hard coded value, which could be based on > the CONFIG_DEFAULT_DEVICE_TREE config. Ends up being superflous - there is already a push to reduce the config options. [..] -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH] arch: mach-k3: Fix incorrect mapping of higher DDR addresses as device memory

2024-01-09 Thread Nishanth Menon
gt; .phys = 0x5UL, > - .size = 0x4UL, > + .size = 0x38000UL, > .attrs = PTE_BLOCK_MEMTYPE(MT_DEVICE_NGNRNE) | > PTE_BLOCK_NON_SHARE | > PTE_BLOCK_PXN | PTE_BLOCK_UX

Re: [PATCH 04/10] board: ti: am64x: Set fdtfile from C code instead of findfdt script

2024-01-09 Thread Nishanth Menon
g in the board name as the boards are now shipped with > HS-FS chip and are no longer GP. Intent of the series was to get rid of findfdt - it was not meant to cleanup existing name usage in the files. If there is a desire to do so, please - patches are welcome. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH 01/10] board: ti: common: Introduce a common fdt ops library

2024-01-09 Thread Nishanth Menon
t; + */ > > +struct ti_fdt_map { > > + const char *name_fdt; > > Can we call this board_name? as name_fdt corresponds to device tree name. > Done. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH v3 0/8] Suspend to RAM support for K3 J7200

2024-01-09 Thread Nishanth Menon
e mentioned previously for TFA as well - I am looking for some common sequence to be defined between am62x and J7200 family rather than each go completely tangentially, until that happens, please consider my standing NAK. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH 06/10] board: ti: j721e: Set fdtfile from C code instead of findfdt script

2024-01-09 Thread Nishanth Menon
On 18:20-20240109, Roger Quadros wrote: > > > On 08/01/2024 19:32, Nishanth Menon wrote: > > We now can provide a map and have the standard fdtfile variable set from > > code itself. This allows for bootstd to "just work". > > > > While at this, repla

Re: [PATCH 4/4] configs: am64x_evm_a53_defconfig: Enable NAND

2024-01-09 Thread Nishanth Menon
E=y > +CONFIG_SPL_NAND_IDENT=y > +CONFIG_SPL_NAND_ECC=y > +CONFIG_SYS_NAND_MAX_CHIPS=1 > +CONFIG_SYS_MAX_NAND_DEVICE=1 > +# CONFIG_SPL_NAND_AM33XX_BCH is not set > +CONFIG_SPL_MTD_SUPPORT=y > +CONFIG_SYS_NAND_U_BOOT_LOCATIONS=y > +CONFIG_SYS_NAND_U_BOOT_OFFS=0x60 > -- > 2.34.1 > Why not a config fragment? -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH 0/4] arm: mach-k3: am64: Add NAND configuration

2024-01-09 Thread Nishanth Menon
| 19 ++ > 5 files changed, 51 insertions(+), 6 deletions(-) Please update am64x documentation as well. People will need to know how to actually build, flash and use it. > > > base-commit: c2c598e87cfe56f5991730762c00733c5aa9a994 > prerequisite-patch-id: e04

[PATCH V2 05/10] board: ti: am65x: Set fdtfile from C code instead of findfdt script

2024-01-09 Thread Nishanth Menon
We now can provide a map and have the standard fdtfile variable set from code itself. This allows for bootstd to "just work". While at this, replace findfdt in environment with a warning as it is no longer needed. Signed-off-by: Nishanth Menon --- Changes from V1: None. I have re

[PATCH V2 03/10] board: ti: am62x: Set fdtfile from C code instead of findfdt script

2024-01-09 Thread Nishanth Menon
Stop using the findfdt script and switch to setting the fdtfile from C code. While at this, replace findfdt in environment with a warning as it is no longer needed Signed-off-by: Nishanth Menon --- Changes from V1: None. I have retained the central call ti_set_fdt_env() to retain the population

[PATCH V2 01/10] board: ti: common: Introduce a common fdt ops library

2024-01-09 Thread Nishanth Menon
-by: Nishanth Menon --- Changes Since v1: * s/TI_EVM_FDT_FOLDER_PATH/TI_FDT_FOLDER_PATH s/name_fdt/board_name s/TI_NAME_FDT_MAX/TI_BOARD_NAME_MAX * Comment updates in various places for review clarification. * Still maintain the fall back using CONFIG_DEFAULT_DEVICE_TREE for reasons explained in

[PATCH V2 02/10] board: ti: am62ax: Set fdtfile from C code instead of findfdt script

2024-01-09 Thread Nishanth Menon
Stop using the findfdt script and switch to setting the fdtfile from C code. While at this, replace findfdt in environment with a warning as it is no longer needed Signed-off-by: Nishanth Menon --- Changes from V1: None. I have retained the central call ti_set_fdt_env() to retain the population

[PATCH V2 07/10] board: ti: j721s2: Set fdtfile from C code instead of findfdt script

2024-01-09 Thread Nishanth Menon
We now can provide a map and have the standard fdtfile variable set from code itself. This allows for bootstd to "just work". While at this, replace findfdt in environment with a warning as it is no longer needed. Signed-off-by: Nishanth Menon --- Changes from V1: None.

[PATCH V2 06/10] board: ti: j721e: Set fdtfile from C code instead of findfdt script

2024-01-09 Thread Nishanth Menon
We now can provide a map and have the standard fdtfile variable set from code itself. This allows for bootstd to "just work". While at this, replace findfdt in environment with a warning as it is no longer needed. Signed-off-by: Nishanth Menon --- Changes from V1: None.

[PATCH V2 09/10] board: beagle: beagleplay: Set fdtfile from C code instead of findfdt script

2024-01-09 Thread Nishanth Menon
Stop using the findfdt script and switch to setting the fdtfile from C code. Signed-off-by: Nishanth Menon --- Changes from V1: * Just macro name change s/TI_EVM_FDT_FOLDER_PATH/TI_FDT_FOLDER_PATH * Commit message update to drop the "warning added to findfdt" since that is not don

[PATCH V2 00/10] board/ti: k3 boards: Stop using findfdt

2024-01-09 Thread Nishanth Menon
and consistent with other similar usage. V1: https://lore.kernel.org/all/20240108173301.2692332-1...@ti.com/ Nishanth Menon (10): board: ti: common: Introduce a common fdt ops library board: ti: am62ax: Set fdtfile from C code instead of findfdt script board: ti: am62x: Set fdtfile fr

[PATCH V2 08/10] board: beagle: beagleboneai64: Set fdtfile from C code instead of findfdt script

2024-01-09 Thread Nishanth Menon
Stop using the findfdt script and switch to setting the fdtfile from C code. Signed-off-by: Nishanth Menon --- Changes from V1: * Just macro name change s/TI_EVM_FDT_FOLDER_PATH/TI_FDT_FOLDER_PATH * Commit message update to drop the "warning added to findfdt" since that is not don

[PATCH V2 10/10] include: env: ti: Drop default_findfdt

2024-01-09 Thread Nishanth Menon
We shouldn't need finfdt anymore. Drop the env script. Signed-off-by: Nishanth Menon --- Changes from V1: None. V1: https://lore.kernel.org/r/20240108173301.2692332-11...@ti.com include/env/ti/default_findfdt.env | 12 1 file changed, 12 deletions(-) delete mode 100644 in

[PATCH V2 04/10] board: ti: am64x: Set fdtfile from C code instead of findfdt script

2024-01-09 Thread Nishanth Menon
We now can provide a map and have the standard fdtfile variable set from code itself. This allows for bootstd to "just work". While at this, replace findfdt in environment with a warning as it is no longer needed. Signed-off-by: Nishanth Menon --- Changes from V1: None. I have retain

Re: [PATCH 4/4] configs: am64x_evm_a53_defconfig: Enable NAND

2024-01-09 Thread Nishanth Menon
ND_DRIVERS=y > +CONFIG_SPL_NAND_BASE=y > +CONFIG_SPL_NAND_IDENT=y > +CONFIG_SPL_NAND_ECC=y > +CONFIG_SYS_NAND_MAX_CHIPS=1 > +CONFIG_SYS_MAX_NAND_DEVICE=1 > +# CONFIG_SPL_NAND_AM33XX_BCH is not set > +CONFIG_SPL_MTD_SUPPORT=y > +CONFIG_SYS_NAND_U_BOOT_LOCATIONS=y > +CONFIG_SYS_NAND_U_BOOT_OFFS=0x60 > -- > 2.34.1 > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH] board: ti: am64: Support TMDS64EVM

2024-01-09 Thread Nishanth Menon
quot;) || \ > board_ti_k3_is("AM64-HSEVM")) > > #define board_is_am64x_skevm() (board_ti_k3_is("AM64-SKEVM") || \ > > base-commit: c2c598e87cfe56f5991730762c00733c5aa9a994 > -- > 2.34.1 > Reviewed-by: Nishanth Menon -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH 4/4] configs: am64x_evm_a53_defconfig: Enable NAND

2024-01-09 Thread Nishanth Menon
le I am not trying to diminish NAND support, we are in a constant struggle to keep SRAM viable and adding additional boot modes to a single config, IMHO is the wrong direction to go. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH 4/4] configs: am64x_evm_a53_defconfig: Enable NAND

2024-01-09 Thread Nishanth Menon
On 21:00-20240109, Francesco Dolcini wrote: > On Tue, Jan 09, 2024 at 02:54:00PM -0500, Tom Rini wrote: > > On Tue, Jan 09, 2024 at 01:18:59PM -0600, Nishanth Menon wrote: > > > On 14:26-20240109, Roger Quadros wrote: > > > > CONFIG_CMD_PMIC=y &

Re: [PATCH V2 10/10] include: env: ti: Drop default_findfdt

2024-01-10 Thread Nishanth Menon
MMAND="run findfdt; run distro_bootcmd" > omap4_panda_defconfig:CONFIG_BOOTCOMMAND="if test ${boot_fit} -eq 1; then run > update_to_fit; fi; run findfdt; run init_console; run envboot; run > distro_bootcmd" > omap4_sdp4430_defconfig:CONFIG_BOOTCOMMAND=&q

Re: [PATCH v7 15/17] configs: Add am69_sk_* defconfig fragments

2024-01-11 Thread Nishanth Menon
On 15:06-20240111, Manorit Chawdhry wrote: > Hi Nishanth, > > On 11:59-20240103, Nishanth Menon wrote: > > On 00:45-20231220, Apurva Nandan wrote: > > > From: Dasnavis Sabiya > > > > > > Add config fragments for am69_sk A72 and R5 conf

Re: [PATCH v7 15/17] configs: Add am69_sk_* defconfig fragments

2024-01-11 Thread Nishanth Menon
d//configs directory? > Else we will just keep polluting the configs directory. Correct - fragments should be in board/ti/.../ folder. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH 01/10] board: ti: am62x: Init DRAM size in R5/A53 SPL

2024-01-12 Thread Nishanth Menon
> splash_display(); > > + if (IS_ENABLED(CONFIG_SPL_ETH)) > + /* Init DRAM size for R5/A53 SPL */ > + dram_init_banksize(); > } > > #if defined(CONFIG_K3_AM64_DDRSS) > -- > 2.34.1 > Are you sure? tftp seems to work without

Re: [PATCH 06/10] arm: mach-k3: am62: Update SoC autogenerated data to enable Ethernet Boot

2024-01-12 Thread Nishanth Menon
.. could please elaborate in the commit message. > > Signed-off-by: Andreas Dannenberg > Signed-off-by: Siddharth Vadapalli > --- > arch/arm/mach-k3/r5/am62x/clk-data.c | 79 ++-- > 1 file changed, 39 insertions(+), 40 deletions(-) > [...] -

Re: [PATCH 07/10] arm: mach-k3: am625_init: Probe AM65 CPSW NUSS

2024-01-12 Thread Nishanth Menon
(CONFIG_TI_AM65_CPSW_NUSS) > && > + spl_boot_device() == BOOT_DEVICE_ETHERNET) { > + struct udevice *cpswdev; > + > + if (uclass_get_device_by_driver(UCLASS_MISC, > DM_DRIVER_GET(am65_cpsw_nuss), > + &cps

Re: [PATCH 08/10] configs: am62: Add configs for enabling ETHBOOT in R5SPL

2024-01-12 Thread Nishanth Menon
y Abraham I > Signed-off-by: Andreas Dannenberg > Signed-off-by: Siddharth Vadapalli > --- > configs/am62x_evm_r5_ethboot_defconfig | 110 + NAK. use config fragments please. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH 00/10] Add support for Ethernet Boot on SK-AM62

2024-01-12 Thread Nishanth Menon
| 5 ++ > arch/arm/mach-k3/am625_init.c| 10 +++ > arch/arm/mach-k3/r5/am62x/clk-data.c | 79 > board/ti/am62x/evm.c | 3 + > configs/am62x_evm_a53_defconfig | 8 ++ > configs/am62x_evm_r5_ethboot_defconfig | 110 +

Re: [PATCH 09/10] configs: am62x_evm_a53_defconfig: Enable configs required for Ethboot

2024-01-12 Thread Nishanth Menon
;AM62X U-Boot A53 SPL" > CONFIG_SPL_POWER_DOMAIN=y > # CONFIG_SPL_SPI_FLASH_TINY is not set > CONFIG_SPL_SPI_FLASH_SFDP_SUPPORT=y > @@ -61,6 +68,7 @@ CONFIG_SPL_DM=y > CONFIG_SPL_DM_SEQ_ALIAS=y > CONFIG_REGMAP=y > CONFIG_SPL_REGMAP=y > +CONFIG_SPL_SYSCON=y &

Re: [PATCH v4 6/7] beagleplay: Add DFU support

2024-01-12 Thread Nishanth Menon
_GADGET=y > +CONFIG_USB_XHCI_HCD=y > +CONFIG_USB_XHCI_DWC3=y > +CONFIG_USB_DWC3=y > +CONFIG_USB_DWC3_GENERIC=y > +CONFIG_SPL_USB_DWC3_GENERIC=y > +CONFIG_SPL_USB_DWC3_AM62=y > +CONFIG_USB_DWC3_AM62=y > +CONFIG_USB_GADGET=y > +CONFIG_SPL_USB_GADGET=y > +CONFIG_USB_GADGET

Re: [PATCH v4 7/7] doc: board: Add document for DFU boot on am62x SoCs

2024-01-12 Thread Nishanth Menon
USB reset has to be done after each upload. > + > +When using dfu-util the following commands can be used to boot to a u-boot > shell: > + > +.. prompt:: bash $ > + > + dfu-util -a bootloader -D tiboot3.bin > + dfu-util -R -a tispl -D tispl.bin > + dfu-util -R -a u-boot.img -D u-boot.img > + > +.. am62x_evm_rst_include_end_dfu_boot > + > Debugging U-Boot > > > -- > 2.43.0 > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH v4 5/7] configs: am62x_evm_*: Enable USB and DFU support

2024-01-12 Thread Nishanth Menon
t; +CONFIG_USB_GADGET_PRODUCT_NUM=0x6165 > +CONFIG_USB_GADGET_DOWNLOAD=y > +CONFIG_SPL_DFU=y > +# CONFIG_SPL_MMC is not set > +# CONFIG_SPL_FS_FAT is not set > +# CONFIG_SPL_LIBDISK_SUPPORT is not set > +# CONFIG_SPL_SPI is not set > +# CONFIG_SPL_SYS_MALLOC is not set > +# CONFIG_CMD_GPT is not set > +# CONFIG_CMD_MMC is not set > +# CONFIG_CMD_FAT is not set > +# CONFIG_MMC_SDHCI is not set > -- > 2.43.0 > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH 01/10] board: ti: am62x: Init DRAM size in R5/A53 SPL

2024-01-12 Thread Nishanth Menon
On 18:01-20240112, Siddharth Vadapalli wrote: > Hello Nishanth, > > On 12/01/24 17:56, Nishanth Menon wrote: > > On 12:17-20240112, Siddharth Vadapalli wrote: > >> From: Kishon Vijay Abraham I > >> > >> Call dram_init_banksize() from spl_board_init() oth

Re: [PATCH 00/10] Add support for Ethernet Boot on SK-AM62

2024-01-12 Thread Nishanth Menon
On 18:06-20240112, Siddharth Vadapalli wrote: > > > On 12/01/24 18:02, Nishanth Menon wrote: > > On 12:17-20240112, Siddharth Vadapalli wrote: > >> Hello, > >> > >> This series enables Ethernet Boot on SK-AM62 device. > >> Product Link: htt

Re: [PATCH 00/10] Add support for Ethernet Boot on SK-AM62

2024-01-12 Thread Nishanth Menon
On 18:17-20240112, Siddharth Vadapalli wrote: > > > On 12/01/24 18:12, Nishanth Menon wrote: > > On 18:06-20240112, Siddharth Vadapalli wrote: > >> > >> > >> On 12/01/24 18:02, Nishanth Menon wrote: > >>> On 12:17-20240112, Siddharth Va

Re: [PATCH 4/5] arm: dts: k3-j721e-beagleboneai64: Fix USB operation

2024-01-12 Thread Nishanth Menon
-all; > + u-boot,mux-autoprobe; > }; > > &serdes_wiz2 { > -- > 2.34.1 > Is this a u-boot thing? or a driver limitation? -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH 4/5] arm: dts: k3-j721e-beagleboneai64: Fix USB operation

2024-01-12 Thread Nishanth Menon
On 15:06-20240112, Roger Quadros wrote: > > > On 12/01/2024 15:02, Nishanth Menon wrote: > > On 14:49-20240112, Roger Quadros wrote: > >> Without correct SERDES MUX and Lane control settings > >> USB0 will be broken. Set the MUX and Lane control devices &

Re: [PATCH v4 5/7] configs: am62x_evm_*: Enable USB and DFU support

2024-01-12 Thread Nishanth Menon
uda, but other platforms still keep u-boot in emmc boot0 and depending on the part and TEE binary size, the available space can be constraining) I am starting to wonder if https://lore.kernel.org/u-boot/20231101170519.39627-1-...@ti.com/ will help us here. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH v4 5/7] configs: am62x_evm_*: Enable USB and DFU support

2024-01-12 Thread Nishanth Menon
sh about redoing work if the baseline changes or has a reasonable chance of change.. Just doing it once and cleanly is my preference. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH 0/2] arm: dts: Add Itap Delay Value For High Speed DDR

2024-01-19 Thread Nishanth Menon
.3490141.14935960940418963459.b4...@ti.com/ > > > > So , kernel and uboot dt files will remain in sync. > > > > Sorry I may be missing something. Why do we need these properties in > U-Boot now? Why not wait 2 weeks for the v6.8-rc1 tag in Linux and sync > everything all at once? I agree. NAK for the series. Please get this part of dts sync. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH v4 00/11] An effort to bring DT bindings compliance within U-Boot

2024-01-19 Thread Nishanth Menon
ccc511 Revert "test: hush: dollar: fix bugous behavior" -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH v8 12/16] arm: dts: Introduce j784s4 u-boot dts files

2024-01-19 Thread Nishanth Menon
template>; }; }; This allows boards to readily include the template for the binaries of choice and generate just relevant output. Wont it save much confusion? [...] -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH v8 04/16] arm: dts: Add bootph-all for memory node

2024-01-19 Thread Nishanth Menon
emory@8000 { > device_type = "memory"; > + bootph-all; > /* 32G RAM */ > reg = <0x00 0x8000 0x00 0x80000000>, > <0x08 0x8000 0x07 0x8000>; > -- > 2.34.1 > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH v8 02/16] arm: mach-k3: Add basic support for J784S4 SoC definition

2024-01-19 Thread Nishanth Menon
> ctr); > + break; > + } > + ctr++; What is the use of ctr++ ?? please do a limit check for instances. [...] Next time, please respond to the review comment questions so that I know that you have considered and decided something is not necessary or something was missed in the new version - for example what happened to mmc_stop/restart? -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH v8 09/16] board: ti: j784s4: Add board support for J784S4 EVM

2024-01-19 Thread Nishanth Menon
fic initialization for J784S4 EVM > + * > + * Copyright (C) 2023-2024 Texas Instruments Incorporated - > https://www.ti.com/ > + * Hari Nagalla > + * > + */ > + > +#include > +#include > +#include > +#include Are you sure we need all the above headers? > +#include "../common/fdt_ops.h" [...] -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH v8 02/16] arm: mach-k3: Add basic support for J784S4 SoC definition

2024-01-23 Thread Nishanth Menon
t; > [...] > > > > Next time, please respond to the review comment questions so that I > > know that you have considered and decided something is not necessary > > or something was missed in the new version - for example what happened > > to mmc_stop/restart? > mmc_stop/restart were removed (mentioned in series changelog) Mentioning in diffstat of the patch helps give people the context of the change w.r.t the path itself. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH v8 12/16] arm: dts: Introduce j784s4 u-boot dts files

2024-01-23 Thread Nishanth Menon
e types it wants and overrides of dtbs it needs. > - The board binman files will include these templates and update the dtb > files in them. Correct. > - Final board.dts will use the correct board-binman.dtsi files if the templates are abstract enough, the additional code will be so min

Re: [PATCH 07/10] arm: mach-k3: am625_init: Probe AM65 CPSW NUSS

2024-01-23 Thread Nishanth Menon
On 15:49-20240122, Chintan Vankar wrote: > > On 12/01/24 18:00, Nishanth Menon wrote: > > On 12:17-20240112, Siddharth Vadapalli wrote: > > > From: Kishon Vijay Abraham I > > > > > > In order to support Ethernet boot on AM62x, probe AM65 CPSW NUSS

Re: [PATCH] firmware: ti_sci: fix the secure_hdr in do_xfer

2024-01-24 Thread Nishanth Menon
> Fixes: 32cd25128bd849 ("firmware: Add basic support for TI System Control > > > Interface (TI SCI)") > > > Signed-off-by: Dhruva Gole > > > --- > > > > > > Boot tested for sanity on AM62x SK > > > https://gist.github.com/DhruvaG2

Re: [PATCH] firmware: ti_sci: fix the secure_hdr in do_xfer

2024-01-24 Thread Nishanth Menon
On 23:07-20240124, Dhruva Gole wrote: > On Jan 24, 2024 at 10:39:10 -0600, Nishanth Menon wrote: > > On 18:38-20240124, Dhruva Gole wrote: > > > On Jan 24, 2024 at 16:42:12 +0530, Kamlesh Gurudasani wrote: > > > > Dhruva Gole writes: > > > > > > &g

Re: [PATCH V3] firmware: ti_sci: fix the secure_hdr in do_xfer

2024-01-24 Thread Nishanth Menon
ty on AM62x SK > https://gist.github.com/DhruvaG2000/724ceba3a0db03f4b0bff47de1160074 > > Changelog: > v2 --> v3 > Address Kamlesh's comment on v2: use sizeof(struct ti_sci_secure_msg_hdr) Lets finish discussing in: https://lore.kernel.org/all/20240124163910.sp7gt56lihoujm7k@etc

Re: [PATCH 1/2] env: ti: mmc: add save_uenv command

2024-01-24 Thread Nishanth Menon
t} = yes || test ${boot_fdt} = try; then > if run get_fdt_mmc; then > > -- > 2.43.0 > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [RFC PATCH v3 02/15] misc: fs-loader: Use fw_storage_interface instead of storage_interface

2024-01-24 Thread Nishanth Menon
fw_ubi_mtdpart"); > ubi_volume = env_get("fw_ubi_volume"); > -- > 2.34.1 > You should move these specific patches out of the series and debate on their merits seperately. mixing things like these in a single series that needs to go to multiple u-boot custodians just creates problems for everyone. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH] firmware: ti_sci: fix the secure_hdr in do_xfer

2024-01-25 Thread Nishanth Menon
upport - which again, we should probably document in the code so that people don't go scratching our heads again. That is unfortunately confusing enough for code since 99% of rest of u-boot flow does not use secure comm path. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F

Re: [PATCH v8 02/16] arm: mach-k3: Add basic support for J784S4 SoC definition

2024-01-29 Thread Nishanth Menon
On 17:02-20240129, Apurva Nandan wrote: > Hi, > > On 24/01/24 02:17, Nishanth Menon wrote: > > On 20:21-20240123, Apurva Nandan wrote: > > [...] > > > > > +void k3_mem_init(void) > > > > > +{ > > > > > + struct udevice *dev

Re: [PATCH V3] firmware: ti_sci: fix the secure_hdr in do_xfer

2024-01-29 Thread Nishanth Menon
On 11:44-20240129, Dhruva Gole wrote: > On Jan 24, 2024 at 12:09:06 -0600, Nishanth Menon wrote: > > On 18:37-20240124, Dhruva Gole wrote: > > > The secure_hdr needs to be 0 init-ed however this was never being put > > > into the secure_buf, leading to possibil

Re: [PATCH V4 1/2] firmware: ti_sci: fix the secure_hdr in do_xfer

2024-01-30 Thread Nishanth Menon
tically ensures > the first 4 bytes of secure_buf are 0. > > Fixes: 32cd25128bd849 ("firmware: Add basic support for TI System Control > Interface (TI SCI)") > Cc: Nishanth Menon > Cc: Andrew Davis > Cc: Manorit Chawdhry > Signed-off-by: Dhruva Gole > --- &g

Re: [PATCH V4 2/2] firmware: ti_sci: Add comment explaining the is_secure code

2024-01-30 Thread Nishanth Menon
de" when it hands off from Boot > + * ROM over to the Secondary bootloader. The initial set of calls > + * we have to make need to be on a secure pipe. > + */ > if (info->is_secure) { > /* ToDo: get checksum of the entire message

[PATCH V3 00/11] board/ti: k3 boards: Stop using findfdt

2024-01-30 Thread Nishanth Menon
RN (around LATE_INIT) and CHECK (fdt_ops #ifdeffery) that on closer inspection looks fine and consistent with other similar usage. V2: https://lore.kernel.org/all/20240109191506.3820908-1...@ti.com/ V1: https://lore.kernel.org/all/20240108173301.2692332-1...@ti.com/ Nishanth Menon (11): board: ti: A

[PATCH V3 08/11] board: ti: j721s2: Set fdtfile from C code instead of findfdt script

2024-01-30 Thread Nishanth Menon
ned-off-by: Nishanth Menon --- Changes in V3: - none other than picking up reviews. V2: https://lore.kernel.org/r/20240109191506.3820908-8...@ti.com board/ti/j721s2/evm.c | 8 board/ti/j721s2/j721s2.env | 8 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/board

[PATCH V3 01/11] board: ti: Add missing common/Kconfig references

2024-01-30 Thread Nishanth Menon
Add missing board/ti/common/Kconfig references for the platforms that missed it. The intent is for the common Kconfig to be usable across TI reference boards as required. Reported-by: Tom Rini Signed-off-by: Nishanth Menon --- New patch: Fixed build fail that Tom noted: https

[PATCH V3 10/11] board: beagle: beagleplay: Set fdtfile from C code instead of findfdt script

2024-01-30 Thread Nishanth Menon
Stop using the findfdt script and switch to setting the fdtfile from C code. Reviewed-by: Jonathan Humphreys Reviewed-by: Roger Quadros Signed-off-by: Nishanth Menon --- Changes in V3: - none other than picking up reviews. V2: https://lore.kernel.org/r/20240109191506.3820908-10...@ti.com

[PATCH V3 02/11] board: ti: common: Introduce a common fdt ops library

2024-01-30 Thread Nishanth Menon
: Jonathan Humphreys Reviewed-by: Roger Quadros Signed-off-by: Nishanth Menon --- Changes in V3: - none other than picking up reviews. V2: https://lore.kernel.org/r/20240109191506.3820908-2...@ti.com board/ti/common/Kconfig | 12 board/ti/common/Makefile | 1 + board/ti/common

[PATCH V3 03/11] board: ti: am62ax: Set fdtfile from C code instead of findfdt script

2024-01-30 Thread Nishanth Menon
Stop using the findfdt script and switch to setting the fdtfile from C code. While at this, replace findfdt in environment with a warning as it is no longer needed Reviewed-by: Jonathan Humphreys Reviewed-by: Roger Quadros Signed-off-by: Nishanth Menon --- Changes in V3: - none other than

[PATCH V3 07/11] board: ti: j721e: Set fdtfile from C code instead of findfdt script

2024-01-30 Thread Nishanth Menon
ned-off-by: Nishanth Menon --- Changes in V3: - none other than picking up reviews. V2: https://lore.kernel.org/r/20240109191506.3820908-7...@ti.com board/ti/j721e/evm.c | 8 board/ti/j721e/j721e.env | 10 -- 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/boar

[PATCH V3 05/11] board: ti: am64x: Set fdtfile from C code instead of findfdt script

2024-01-30 Thread Nishanth Menon
ned-off-by: Nishanth Menon --- Changes in V3: - none other than picking up reviews. V2: https://lore.kernel.org/r/20240109191506.3820908-5...@ti.com board/ti/am64x/am64x.env | 9 - board/ti/am64x/evm.c | 8 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/boar

[PATCH V3 04/11] board: ti: am62x: Set fdtfile from C code instead of findfdt script

2024-01-30 Thread Nishanth Menon
Stop using the findfdt script and switch to setting the fdtfile from C code. While at this, replace findfdt in environment with a warning as it is no longer needed Reviewed-by: Jonathan Humphreys Reviewed-by: Roger Quadros Signed-off-by: Nishanth Menon --- Changes in V3: - none other than

[PATCH V3 11/11] include: env: ti: Drop default_findfdt

2024-01-30 Thread Nishanth Menon
We shouldn't need finfdt anymore. Drop the env script. Reviewed-by: Jonathan Humphreys Reviewed-by: Roger Quadros Signed-off-by: Nishanth Menon --- Changes in V3: - none other than picking up reviews. V2: https://lore.kernel.org/r/20240109191506.3820908-11...@ti.com include/e

[PATCH V3 06/11] board: ti: am65x: Set fdtfile from C code instead of findfdt script

2024-01-30 Thread Nishanth Menon
ned-off-by: Nishanth Menon --- Changes in V3: - none other than picking up reviews. V2: https://lore.kernel.org/r/20240109191506.3820908-6...@ti.com board/ti/am65x/am65x.env | 3 --- board/ti/am65x/evm.c | 2 ++ 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/board/ti/am65x/am65x.env

[PATCH V3 09/11] board: beagle: beagleboneai64: Set fdtfile from C code instead of findfdt script

2024-01-30 Thread Nishanth Menon
Stop using the findfdt script and switch to setting the fdtfile from C code. Reviewed-by: Jonathan Humphreys Reviewed-by: Roger Quadros Signed-off-by: Nishanth Menon --- Changes in V3: - none other than picking up reviews. V2: https://lore.kernel.org/r/20240109191506.3820908-9...@ti.com

Re: eMMC broken on SK-AM62

2023-11-09 Thread Nishanth Menon
t flow is not exactly the same. > > > > > Thanks! > > Maxime There is nothing complex here - sorry for the late response, Sync DT with v6.7-rc1 should take care of this: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/arch/arm64/boot/dts/ti?id=c412c2f26eed08b1836ccf79f5547b67c1b55d5d Vs: https://github.com/u-boot/u-boot/blob/master/arch/arm/dts/k3-am625-sk-u-boot.dtsi#L93 (notice no sdhci0 with bootph properties) -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [RFC PATCH 1/1] arm: mach-k3: Enable icache on am625 to boot faster

2023-11-09 Thread Nishanth Menon
BLED(CONFIG_CPU_V7R) && !IS_ENABLED(CONFIG_SYS_ICACHE_OFF)) > + icache_enable(); > } > > u32 spl_mmc_boot_mode(struct mmc *mmc, const u32 boot_device) > -- > 2.34.1 Just noticed that icache_enable was missed for all of k3 as well - I suspect this is a miss rath

Re: [RFC PATCH 1/1] arm: mach-k3: Enable icache on am625 to boot faster

2023-11-10 Thread Nishanth Menon
On 09:59-20231110, Francesco Dolcini wrote: > On Thu, Nov 09, 2023 at 01:51:19PM -0500, Tom Rini wrote: > > On Thu, Nov 09, 2023 at 12:44:56PM -0600, Andrew Davis wrote: > > > On 11/9/23 11:37 AM, Nishanth Menon wrote: > > > > On 11:09-20231109, Joao Paulo Goncalv

[PATCH 1/8] arm: mach-k3: am62a: Add main_timer0 id to the dev list

2023-11-13 Thread Nishanth Menon
main_timer0 is used by u-boot as the tick-timer. Add it to the soc devices list so it an be enabled via the k3 power controller. Signed-off-by: Nishanth Menon --- arch/arm/mach-k3/am62ax/dev-data.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-k3/am62ax/dev-data.c b/arch

[PATCH 0/8] arm: dts: am62a: Update to kernel v6.7-rc1

2023-11-13 Thread Nishanth Menon
t;arm: dts: k3-am6: Fix Ethernet/DMA" Jai Luthra (1): doc: board: ti: Add AM62A documentation Nishanth Menon (6): arm: mach-k3: am62a: Add main_timer0 id to the dev list arm: dts: k3-am62a*: Sync with kernel v6.7-rc1 configs: am62ax_evm_a53_defconfig: Enable networking board: ti: a

[PATCH 4/8] configs: am62ax_evm_a53_defconfig: Enable networking

2023-11-13 Thread Nishanth Menon
Enable networking Signed-off-by: Nishanth Menon --- configs/am62ax_evm_a53_defconfig | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/configs/am62ax_evm_a53_defconfig b/configs/am62ax_evm_a53_defconfig index d0a34c75505d..c94708a7bf85 100644 --- a/configs

[PATCH 6/8] board: ti: am62ax: env: Set the boot_targets

2023-11-13 Thread Nishanth Menon
Set the default boot_targets to map up SD card as priority followed by emmc and so on. Signed-off-by: Nishanth Menon --- board/ti/am62ax/am62ax.env | 1 + 1 file changed, 1 insertion(+) diff --git a/board/ti/am62ax/am62ax.env b/board/ti/am62ax/am62ax.env index 2af6914e3fab..a6d967e982d4 100644

[PATCH 3/8] dma: ti: k3-udma: Introduce DMA support for the am62ax

2023-11-13 Thread Nishanth Menon
From: Vignesh Raghavendra In preparation for enabling ethernet for the am62ax family of SoCs, introduce the initial DMA channel settings for the am62ax Signed-off-by: Vignesh Raghavendra [b...@ti.com: expanded on commit message] Signed-off-by: Bryan Brattlof Signed-off-by: Nishanth Menon

[PATCH 5/8] board: ti: am62ax: env: Use default findfdt

2023-11-13 Thread Nishanth Menon
Use the default findfdt instead of local logic. Signed-off-by: Nishanth Menon --- board/ti/am62ax/am62ax.env | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/board/ti/am62ax/am62ax.env b/board/ti/am62ax/am62ax.env index bfed7f360844..2af6914e3fab 100644 --- a/board/ti

[PATCH 8/8] doc: board: ti: Add AM62A documentation

2023-11-13 Thread Nishanth Menon
From: Jai Luthra Add generic boot-flow diagrams, and SoC-specific info around build steps. Signed-off-by: Jai Luthra Signed-off-by: Nishanth Menon --- doc/board/ti/am62ax_sk.rst | 213 + doc/board/ti/k3.rst| 1 + 2 files changed, 214 insertions

[PATCH 7/8] configs: am62ax_evm_a53_defconfig: switch to stdboot

2023-11-13 Thread Nishanth Menon
Switch over to stdboot Signed-off-by: Nishanth Menon --- configs/am62ax_evm_a53_defconfig | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/configs/am62ax_evm_a53_defconfig b/configs/am62ax_evm_a53_defconfig index c94708a7bf85..38083586a3ec 100644 --- a/configs

[PATCH 2/8] arm: dts: k3-am62a*: Sync with kernel v6.7-rc1

2023-11-13 Thread Nishanth Menon
Sync with kernel v6.7-rc1 and sync up the u-boot dts files accordingly. Signed-off-by: Nishanth Menon --- arch/arm/dts/k3-am62a-main.dtsi | 585 +- arch/arm/dts/k3-am62a-mcu.dtsi| 131 ++ arch/arm/dts/k3-am62a-thermal.dtsi| 47 +++ arch/arm/dts/k3

[PATCH 4/4] arm: dts: k3-am625-sk-r5/u-boot: Drop duplicate bootph-nodes

2023-11-13 Thread Nishanth Menon
Kernel dts import now provides bootph-all and bootph-pre-ram properties for the properties we have been overriding so far. Drop the same. While at this enable the DM and tifs uarts for programming pinmux since they are marked reserved by board.dts Signed-off-by: Nishanth Menon --- arch/arm/dts

[PATCH 1/4] arm: dts: k3-am625*: Sync with kernel v6.7-rc1

2023-11-13 Thread Nishanth Menon
Sync with kernel v6.7-rc1 and sync up the u-boot dts files accordingly. Signed-off-by: Nishanth Menon --- arch/arm/dts/k3-am62-main.dtsi| 12 ++- arch/arm/dts/k3-am62-mcu.dtsi | 2 + arch/arm/dts/k3-am62-verdin-wifi.dtsi | 6 ++ arch/arm/dts/k3-am62-verdin.dtsi | 1

<    2   3   4   5   6   7   8   9   10   11   >