Re: [U-Boot] __FILE__ usage and and SPL limits for SRAM

2017-03-28 Thread Nishanth Menon
for __FILE__ (I have'nt investigated how).. and get a build time macro to define relative path which is provided as a replacement for __FILE__ [1] http://stackoverflow.com/questions/8487986/file-macro-shows-full-path -- --- Regards, Nishanth Menon ___ U-Boot

[U-Boot] __FILE__ usage and and SPL limits for SRAM

2017-03-27 Thread Nishanth Menon
-shows-full-path -- Regards, Nishanth Menon ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 2/2] ARM: OMAP5: Enable support for AVS0 for OMAP5 production devices

2017-08-04 Thread Nishanth Menon
nce Manual SWPU282AF (May 2012-Revised Aug 2016) NOTE: All collaterals on OMAP5432 silicon itself seems to have been removed from ti.com, though EVM details are still available: http://www.ti.com/tool/OMAP5432-EVM Signed-off-by: Nishanth Menon <n...@ti.com> --- arch/arm/incl

[U-Boot] [PATCH 0/2] ARM: OMAP5: Add AVS support for ES2.0

2017-08-04 Thread Nishanth Menon
ple. b) 750-2628-222(A) UEVM5432G-02 with pre-production sample. build tested with: buildman -b omap5-evm omap5 [1] https://www.pyra-handheld.com/wiki/index.php?title=OMAP_5 Nishanth Menon (2): ARM: OMAP5: Remove OPP_LOW Definitions for ES2.0 ARM: OMAP5: Enable support for AVS0 for OMAP5 productio

[U-Boot] [PATCH 1/2] ARM: OMAP5: Remove OPP_LOW Definitions for ES2.0

2017-08-04 Thread Nishanth Menon
ES2.0 descopes OPP_LOW definition. So remove it from macros defined. Signed-off-by: Nishanth Menon <n...@ti.com> --- arch/arm/include/asm/arch-omap5/clock.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/arm/include/asm/arch-omap5/clock.h b/arch/arm/include/asm/arch-omap5/c

Re: [U-Boot] [PATCH 3/3] regulator: lp873x: Fix the return value of buck_get_enable function

2017-06-12 Thread Nishanth Menon
@@ -318,7 +318,7 @@ static bool buck_get_enable(struct udevice *dev) ret = lp873x_buck_enable(dev, PMIC_OP_GET, ); if (ret) - return ret; + return false; return enable; } just squash 2/3 and 3/3 to a single patch? -- Regards

Re: [U-Boot] [PATCH v3 2/2] power: regulator: lp87565: add regulator support

2017-06-09 Thread Nishanth Menon
for a bool function? return false perhaps? -- Regards, Nishanth Menon ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 2/4] ARM: Introduce ability to enable invalidate of BTB with ICIALLU on Cortex-A15 for CVE-2017-5715

2018-06-14 Thread Nishanth Menon
. I think it is clear from Russell's summary that we dont want "may work" workaround in kernel/bootloaders. in case of u-boot (which this patch is about), I'd suggest adding the CONFIG_*CVE* input to the Kconfig for the SoC where you know for sure this works. Does that sound a fair tradeoff? -- Regards, Nishanth Menon ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 2/4] ARM: Introduce ability to enable invalidate of BTB with ICIALLU on Cortex-A15 for CVE-2017-5715

2018-06-12 Thread Nishanth Menon
-by: Nishanth Menon --- arch/arm/Kconfig | 4 arch/arm/cpu/armv7/start.S | 8 2 files changed, 12 insertions(+) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 9e32d5b43cb0..98f58fd27696 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -109,6 +109,7 @@ config

[U-Boot] [PATCH 0/4] ARM: Provide workaround setup bits for CVE-2017-5715 (A8/A15)

2018-06-12 Thread Nishanth Menon
tps://pastebin.ubuntu.com/p/9yDM22bJ6n/ (dual core A15) OMAP3-beagle-xm: https://pastebin.ubuntu.com/p/9DfDkpyxym/ (Single A8) AM335x-Beaglebone-black: https://pastebin.ubuntu.com/p/DczT9jPMwb/ (Single A8) Nishanth Menon (4): ARM: Introduce ability to enable ACR::IBE on Cortex-A8 for CVE-2017-5

Re: [U-Boot] [RFC PATCH 0/2] ARM: v7: Enable basic framework for supporting bits for CVE-2017-5715

2018-06-12 Thread Nishanth Menon
On Tue, May 22, 2018 at 9:05 AM, Fabio Estevam wrote: > On Thu, Jan 25, 2018 at 7:45 PM, Nishanth Menon wrote: >> Hi Folks, >> >> This is a follow through on the discussion we have had in [1]. >> This itself is'nt a complete solution and is based on recommendation >

[U-Boot] [PATCH 1/4] ARM: Introduce ability to enable ACR::IBE on Cortex-A8 for CVE-2017-5715

2018-06-12 Thread Nishanth Menon
: Russell King Cc: Tony Lindgren Cc: Robin Murphy Cc: Florian Fainelli Cc: Catalin Marinas Cc: Will Deacon Cc: Christoffer Dall Cc: Andre Przywara Cc: Ard Biesheuvel Cc: Tom Rini Cc: Michael Nazzareno Trimarchi Signed-off-by: Nishanth Menon --- arch/arm/Kconfig | 5 + arch

[U-Boot] [PATCH 3/4] ARM: mach-omap2: omap5/dra7: Enable ACTLR[0] (Enable invalidates of BTB) to facilitate CVE_2017-5715 WA in OS

2018-06-12 Thread Nishanth Menon
kernel reports: CPU0: Spectre v2: using ICIALLU workaround NOTE: This by itself does not enable the workaround for CPU1 (on OMAP5 and DRA72/AM572 SoCs) and may require additional kernel patches. Signed-off-by: Nishanth Menon --- arch/arm/mach-omap2/Kconfig | 1 + 1 file changed, 1 insertion

[U-Boot] [PATCH 4/4] ARM: mach-omap2: omap3/am335x: Enable ACR::IBE on Cortex-A8 SoCs for CVE-2017-5715

2018-06-12 Thread Nishanth Menon
context of ACR would be lost (off-mode etc). Signed-off-by: Nishanth Menon --- arch/arm/mach-omap2/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig index 77820cc8d1e4..f4babc8d2600 100644 --- a/arch/arm/mach-omap2/Kconfig +++ b

Re: [U-Boot] [RFC PATCH 0/2] ARM: v7: Enable basic framework for supporting bits for CVE-2017-5715

2018-06-12 Thread Nishanth Menon
mc calling conventions vary). -- Regards, Nishanth Menon ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [RFC PATCH 0/2] ARM: v7: Enable basic framework for supporting bits for CVE-2017-5715

2018-06-13 Thread Nishanth Menon
On 10:08-20180613, Russell King - ARM Linux wrote: > On Tue, Jun 12, 2018 at 04:58:34PM -0500, Nishanth Menon wrote: > > On 21:40-20180612, Russell King - ARM Linux wrote: > > [...] > > > > I started respinning the series, while there is definitely a use of >

Re: [U-Boot] [PATCH 3/4] ARM: mach-omap2: omap5/dra7: Enable ACTLR[0] (Enable invalidates of BTB) to facilitate CVE_2017-5715 WA in OS

2018-06-13 Thread Nishanth Menon
On 23:06-20180612, Marek Vasut wrote: > On 06/12/2018 10:24 PM, Nishanth Menon wrote: > > Enable CVE_2017_5715 and since we have our own v7_arch_cp15_set_acr > > function to setup the bits, we are able to override the settings. > > > > Without this enabled, Linux kernel

Re: [U-Boot] [PATCH 2/4] ARM: Introduce ability to enable invalidate of BTB with ICIALLU on Cortex-A15 for CVE-2017-5715

2018-06-13 Thread Nishanth Menon
On 23:05-20180612, Marek Vasut wrote: > On 06/12/2018 10:24 PM, Nishanth Menon wrote: [..] > > +#ifdef CONFIG_ARM_CORTEX_A15_CVE_2017_5715 > > + mrc p15, 0, r0, c1, c0, 1 @ read auxilary control register > > + orr r0, r0, #1 << 0 @ Enable invalid

Re: [U-Boot] [PATCH 2/4] ARM: Introduce ability to enable invalidate of BTB with ICIALLU on Cortex-A15 for CVE-2017-5715

2018-06-13 Thread Nishanth Menon
On 00:30-20180613, Florian Fainelli wrote: > On June 12, 2018 1:24:09 PM PDT, Nishanth Menon wrote: > >As recommended by Arm in [1], ACTLR[0] (Enable invalidates of BTB) > >needs to be set[2] for BTB to be invalidated on ICIALLU. This needs to > >be done unconditionally for

Re: [U-Boot] [PATCH 2/4] ARM: Introduce ability to enable invalidate of BTB with ICIALLU on Cortex-A15 for CVE-2017-5715

2018-06-13 Thread Nishanth Menon
On 15:46-20180613, Tom Rini wrote: > On Wed, Jun 13, 2018 at 08:32:15AM -0500, Nishanth Menon wrote: > > On 23:05-20180612, Marek Vasut wrote: > > > On 06/12/2018 10:24 PM, Nishanth Menon wrote: > > [..] > > > > +#ifdef CONFIG_ARM_CORTEX_A15_CVE_2017_5715 > &

Re: [U-Boot] [PATCH 3/4] ARM: mach-omap2: omap5/dra7: Enable ACTLR[0] (Enable invalidates of BTB) to facilitate CVE_2017-5715 WA in OS

2018-06-13 Thread Nishanth Menon
On 20:36-20180613, Marek Vasut wrote: > On 06/13/2018 07:36 PM, Russell King - ARM Linux wrote: > > On Wed, Jun 13, 2018 at 01:06:13AM +0200, Marek Vasut wrote: > >> On 06/12/2018 10:24 PM, Nishanth Menon wrote: > >>> Enable CVE_2017_5715 and since we hav

Re: [U-Boot] U-Boot, cache speculation side channel attacks and ARM

2018-01-19 Thread Nishanth Menon
st? A8/9/12/17: "So without IBE set, as the comments above say, the flush won't do anything." https://marc.info/?l=linux-arm-kernel=151566145121435=2 A15: ACTLR https://marc.info/?l=linux-arm-kernel=151562519425981=2 Am I misunderstanding the list we need to do in u-boot?

Re: [U-Boot] [RFC PATCH 2/2] ARM: Introduce ability to enable invalidate of BTB on Cortex-A15 for CVE-2017-5715

2018-01-26 Thread Nishanth Menon
On 01/26/2018 03:17 AM, Marc Zyngier wrote: On 25/01/18 21:45, Nishanth Menon wrote: As recommended by Arm in [1], ACR needs to be set[2] to enable invalidation of BTB. This has to be enabled unconditionally for ICIALLU to be functional on Cortex-A15 processors. Provide a config Not quite

[U-Boot] [RFC PATCH 1/2] ARM: Introduce ability to enable ACR::IBE on Cortex-A8 for CVE-2017-5715

2018-01-25 Thread Nishanth Menon
rm.com> Cc: Will Deacon <will.dea...@arm.com> Cc: Christoffer Dall <christoffer.d...@linaro.org> Cc: Andre Przywara <andre.przyw...@arm.com> Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> Cc: Tom Rini <tr...@konsulko.com> Cc: Michael Nazzareno Trimarchi <mich

[U-Boot] [RFC PATCH 2/2] ARM: Introduce ability to enable invalidate of BTB on Cortex-A15 for CVE-2017-5715

2018-01-25 Thread Nishanth Menon
i <tr...@konsulko.com> Cc: Michael Nazzareno Trimarchi <mich...@amarulasolutions.com> Signed-off-by: Nishanth Menon <n...@ti.com> --- arch/arm/Kconfig | 4 arch/arm/cpu/armv7/start.S | 8 2 files changed, 12 insertions(+) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig

[U-Boot] [RFC PATCH 0/2] ARM: v7: Enable basic framework for supporting bits for CVE-2017-5715

2018-01-25 Thread Nishanth Menon
level workarounds. Nishanth Menon (2): ARM: Introduce ability to enable ACR::IBE on Cortex-A8 for CVE-2017-5715 ARM: Introduce ability to enable invalidate of BTB on Cortex-A15 for CVE-2017-5715 arch/arm/Kconfig | 9 + arch/arm/cpu/armv7/start.S | 15

Re: [U-Boot] [PATCH] ARM: armv7: Add early stack for erratum workarounds

2018-11-20 Thread Nishanth Menon
On 17:02-20181120, Nishanth Menon wrote: > On 14:47-20181119, Andrew F. Davis wrote: > > Some erratum workarounds call into C code before the stack > > is setup, this can lead to values pushed onto the stack > > being lost, firewall exceptions, and other undefined beh

Re: [U-Boot] [PATCH] ARM: armv7: Add early stack for erratum workarounds

2018-11-20 Thread Nishanth Menon
liance */ > + mov sp, r0 > + Dumb q: Is this a little too late? bl cpu_init_cp15 gets invoked from reset.. doesnt sp need to be setup prior to the call in? > #ifdef CONFIG_ARM_ERRATA_798870 > cmp r2, #0x30 @ Applies to lower than R3p0 > b

Re: [U-Boot] [PATCH] firmware: ti_sci: Always request response from firmware

2019-04-29 Thread Nishanth Menon
lejandro Hernandez > --- > drivers/firmware/ti_sci.c | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) Acked-by: Nishanth Menon -- Regards, Nishanth Menon ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] remoteproc: Fix potential build issues with SPL remoteproc

2019-07-19 Thread Nishanth Menon
oc_get_ops(dev) ((struct dm_rproc_ops *)(dev)->driver->ops) > > -#ifdef CONFIG_REMOTEPROC > +#if CONFIG_IS_ENABLED(REMOTEPROC) > /** > * rproc_init() - Initialize all bound remote proc devices > * > -- > 2.22.0 > Aaah.. Thanks.. Reviewed-by: Nishanth Meno

Re: [PATCH v2 02/46] firmware: ti_sci: Fix not calling dev_err with a device

2020-09-15 Thread Nishanth Menon
_device_state(const struct > ti_sci_handle *handle, > > ret = ti_sci_do_xfer(info, xfer); > if (ret) { > - dev_err(dev, "Mbox send fail %d\n", ret); > + dev_err(info->dev, "Mbox send fail %d\n", ret); > return ret; >

Re: [PATCH 0/5] configs: ti: am65x/j721e: Use DEFAULT_LINUX_BOOT_ENV

2020-10-07 Thread Nishanth Menon
On 11:15-20201007, Lokesh Vutla wrote: > > > On 07/10/20 12:35 am, Nishanth Menon wrote: > > Use the common defaults from ./include/configs/ti_armv7_common.h > > > > This saves us from rediscovering the same painful lessons learnt from > > ARMv7 (kernel dtbs r

Re: [PATCH 0/5] configs: ti: am65x/j721e: Use DEFAULT_LINUX_BOOT_ENV

2020-10-07 Thread Nishanth Menon
On 07:11-20201007, Nishanth Menon wrote: > On 11:15-20201007, Lokesh Vutla wrote: > > > > > > On 07/10/20 12:35 am, Nishanth Menon wrote: > > > Use the common defaults from ./include/configs/ti_armv7_common.h > > > > > > This saves us from re

[PATCH V2 2/4] env: ti: ufs: Use dtboaddr instead of overlayaddr

2020-10-07 Thread Nishanth Menon
Use dtboaddr to define the overlay address common to all TI platforms instead of creating a new overlayaddr for the purpose. Signed-off-by: Nishanth Menon --- Changes since V1: - reordered to be patch #2, no functional changes V1: https://patchwork.ozlabs.org/project/uboot/patch

[PATCH V2 4/4] configs: am65x_evm: Use DEFAULT_LINUX_BOOT_ENV and remove overlayaddr

2020-10-07 Thread Nishanth Menon
in ti_armv7_common.h for this very purpose) and get rid of the definition of overlayaddr.. Signed-off-by: Nishanth Menon --- Changes since V1: - Squashed patch of #1 and #4, no functional changes V1: https://patchwork.ozlabs.org/project/uboot/patch/20201006190507.13346-2...@ti.com/ https

[PATCH V2 1/4] configs: j721e_evm: Use DEFAULT_LINUX_BOOT_ENV

2020-10-07 Thread Nishanth Menon
in ti_armv7_common.h for this very purpose).. we will get rid of overlayaddr later in the series. Signed-off-by: Nishanth Menon --- Changes since V1: - reordered to be patch #1, no functional changes V1: https://patchwork.ozlabs.org/project/uboot/patch/20201006190507.13346-3...@ti.com/ include

[PATCH V2 3/4] configs: j721e_evm: Get rid of overlayaddr

2020-10-07 Thread Nishanth Menon
Now that we dont have any further users of overlayaddr, get rid of it. Signed-off-by: Nishanth Menon --- Changes since V1: - reordered to be patch #3, no functional changes V1: https://patchwork.ozlabs.org/project/uboot/patch/20201006190507.13346-6...@ti.com/ include/configs/j721e_evm.h | 1

[PATCH V2 0/4] configs: ti: am65x/j721e: Use DEFAULT_LINUX_BOOT_ENV

2020-10-07 Thread Nishanth Menon
loosing bisectability. - Reordered to remove the j721e dependencies ahead of am654 V1: https://patchwork.ozlabs.org/project/uboot/list/?series=206321 Nishanth Menon (4): configs: j721e_evm: Use DEFAULT_LINUX_BOOT_ENV env: ti: ufs: Use dtboaddr instead of overlayaddr configs: j721e_evm: Get rid

[PATCH 2/5] configs: j721e_evm: Use DEFAULT_LINUX_BOOT_ENV

2020-10-06 Thread Nishanth Menon
in ti_armv7_common.h for this very purpose).. we will get rid of overlayaddr later in the series. Signed-off-by: Nishanth Menon --- include/configs/j721e_evm.h | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/include/configs/j721e_evm.h b/include/configs/j721e_evm.h

[PATCH 5/5] configs: j721e_evm: Get rid of overlayaddr

2020-10-06 Thread Nishanth Menon
Now that we dont have any further users of overlayaddr, get rid of it. Signed-off-by: Nishanth Menon --- include/configs/j721e_evm.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/configs/j721e_evm.h b/include/configs/j721e_evm.h index 820e51378260..b707fc4e899f 100644 --- a/include

[PATCH 1/5] configs: am65x_evm: Use DEFAULT_LINUX_BOOT_ENV

2020-10-06 Thread Nishanth Menon
in ti_armv7_common.h for this very purpose).. we will get rid of overlayaddr later in the series. Signed-off-by: Nishanth Menon --- include/configs/am65x_evm.h | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/include/configs/am65x_evm.h b/include/configs/am65x_evm.h

[PATCH 0/5] configs: ti: am65x/j721e: Use DEFAULT_LINUX_BOOT_ENV

2020-10-06 Thread Nishanth Menon
Use the common defaults from ./include/configs/ti_armv7_common.h This saves us from rediscovering the same painful lessons learnt from ARMv7 (kernel dtbs ramdisks overlays stomping on each other etc..) Nishanth Menon (5): configs: am65x_evm: Use DEFAULT_LINUX_BOOT_ENV configs: j721e_evm

[PATCH 3/5] env: ti: ufs: Use dtboaddr instead of overlayaddr

2020-10-06 Thread Nishanth Menon
Use dtboaddr to define the overlay address common to all TI platforms instead of creating a new overlayaddr for the purpose. Signed-off-by: Nishanth Menon --- include/environment/ti/ufs.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/environment/ti/ufs.h b

[PATCH 4/5] configs: am65x_evm: Get rid of overlayaddr

2020-10-06 Thread Nishanth Menon
Now that we are all clear of users of overlayaddr, get rid of it. Signed-off-by: Nishanth Menon --- include/configs/am65x_evm.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/configs/am65x_evm.h b/include/configs/am65x_evm.h index 19dc1a537e6a..9eed0ea203a9 100644 --- a/include

Re: [PATCH v2 12/23] logicpd: Drop omap3 zoom1

2020-06-16 Thread Nishanth Menon
On 23:45-20200613, Jagan Teki wrote: > On Wed, May 27, 2020 at 6:27 PM Jagan Teki wrote: > > > > OF_CONTROL, DM_SPI and other driver model migration deadlines > > are expired for this board. > > > > Drop it. > > > > Cc: Nishanth Menon > > Any

[PATCH 1/2] arm: dts: k3-*-r5-*-board: Add GTC clock

2021-01-06 Thread Nishanth Menon
Add GTC Clock definition as index 0 clock so that we can use the clock node in the driver later on. Signed-off-by: Nishanth Menon --- arch/arm/dts/k3-am654-r5-base-board.dts| 1 + arch/arm/dts/k3-j7200-r5-common-proc-board.dts | 1 + arch/arm/dts/k3-j721e-r5-common-proc-board.dts | 1

[PATCH 2/2] remoteproc: ti_k3_arm64: Program CNTFID0 register in GTC

2021-01-06 Thread Nishanth Menon
are/commit/6a22d9ea3c7fa28d053d3ba264b49b7396a86f9e Signed-off-by: Nishanth Menon --- drivers/remoteproc/ti_k3_arm64_rproc.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/remoteproc/ti_k3_arm64_rproc.c b/drivers/remoteproc/ti_k3_arm64_rproc.c index 28c6ddb69

[PATCH 0/2] remoteproc: ti_k3_arm64: Program GTC FID0 register

2021-01-06 Thread Nishanth Menon
/cntfid0 [3] https://developer.arm.com/docs/ddi0595/h/external-system-registers/cntcr [4] https://github.com/ARM-software/arm-trusted-firmware/commit/6a22d9ea3c7fa28d053d3ba264b49b7396a86f9e Nishanth Menon (2): arm: dts: k3-*-r5-*-board: Add GTC clock remoteproc: ti_k3_arm64: Program CNTFID0

[PATCH] power: regulator: Kconfig: add a dependency for POWER_SUPPORT for SPL

2020-11-19 Thread Nishanth Menon
Will not suffice, since the entire regulator build for SPL depends on CONFIG_SPL_POWER_SUPPORT. Elaborate that information in the Kconfig dependency. Signed-off-by: Nishanth Menon --- drivers/power/regulator/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power

Re: [PATCH 1/2] firmware: ti_sci: Include linux/err.h in ti_sci_protocol.h

2021-08-27 Thread Nishanth Menon
e_revision: Firmware revision (not usually used). > * @firmware_description: Firmware description (not usually used). > */ > -#include > struct ti_sci_version_info { > u8 abi_major; > u8 abi_minor; Reviewed-by: Nishanth Menon -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH 2/2] arm: mach-k3: common: Add a release_resources_for_core_shutdown() stub

2021-08-27 Thread Nishanth Menon
loadaddr, > u32 *loadaddr) > } > #endif > > +__weak void release_resources_for_core_shutdown(void) > +{ > + debug("%s not implemented...\n", __func__); > +} > + > void __noreturn jump_to_image_no_args(struct spl_image_info *spl_image) > { >

[PATCH 0/2] arm: mach-k3: Fix corruption of device manager firmware

2021-08-31 Thread Nishanth Menon
address and sequencing. Nishanth Menon (2): arm: mach-k3: common: Make sure firmware sections are loaded prior to armv8 startup tools: k3_fit_atf: Change DM load address to avoid conflict arch/arm/mach-k3/common.c | 30 ++ tools/k3_fit_atf.sh | 4 ++-- 2

[PATCH 1/2] arm: mach-k3: common: Make sure firmware sections are loaded prior to armv8 startup

2021-08-31 Thread Nishanth Menon
these conditions, lets make sure that the elf parse and copy operations are completed ahead of ARMv8 being released to execute. We will pay a penalty of elf copy time, but that is a valid tradeoff in comparison to debug of alternate scenarios. Signed-off-by: Nishanth Menon --- arch/arm/mach-k3/common.c

[PATCH 2/2] tools: k3_fit_atf: Change DM load address to avoid conflict

2021-08-31 Thread Nishanth Menon
to a lesser used DDR address, yet within the typical 1GB address space. We may need to consider going for a configuration option if this is turning to be a limitation (boards with lesser DDR space). Signed-off-by: Nishanth Menon --- tools/k3_fit_atf.sh | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH 2/2] tools: k3_fit_atf: Change DM load address to avoid conflict

2021-08-31 Thread Nishanth Menon
On 13:20-20210831, Nishanth Menon wrote: > DM binary is expected to be an elf file. The expected address of > this elf is in the range of 0xa000_ in DDR. In the current > configuration, elf file is loaded to the exact same address and we > invoke load_elf_image_phdr to decod

[PATCH] dt-bindings: pinctrl: k3: Synchronize with v5.14 kernel

2021-08-31 Thread Nishanth Menon
Synchronize with the upstream version as of v5.14 kernel tag Signed-off-by: Nishanth Menon --- NOTE: checkpatch complains about BIT() macro usage, but I propose that we are better off staying in sync with the kernel tag itself. include/dt-bindings/pinctrl/k3.h | 51

Re: [PATCH] ARM: dts: Fix node status to "okay" on TI boards

2021-08-20 Thread Nishanth Menon
>, ><_sst_fck>, > diff --git a/arch/arm/dts/omap36xx.dtsi b/arch/arm/dts/omap36xx.dtsi > index 6fb23ada1f..52e1b8ce0f 100644 > --- a/arch/arm/dts/omap36xx.dtsi > +++ b/arch/arm/dts/omap36xx.dtsi > @@ -153,7 +153,7 @@ > }; > > { > - status =

Re: status="ok" treated as disabled by DM

2021-08-19 Thread Nishanth Menon
ll not be bound. > > What is the right fix? > 1) make u-boot DM to treat satus="ok" as enabled. > 2) fix device tree by changing "ok" to "okay". > > cheers, > -roger https://github.com/devicetree-org/dt-schema/blob/master/schemas/dt-core.yam

Re: [PATCH v2] ARM: dts: Fix node status to "okay" on TI boards

2021-08-25 Thread Nishanth Menon
sense.. some of which indicates missing sync with k.org dts, I suspect.. Reviewed-by: Nishanth Menon -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH] MAINTAINERS: Update ARM TI entry

2021-09-03 Thread Nishanth Menon
lp helping maintain TI port. Reviewed-by: Nishanth Menon > --- > MAINTAINERS| 2 +- > board/davinci/da8xxevm/MAINTAINERS | 2 +- > board/ti/am43xx/MAINTAINERS| 2 +- > board/ti/am57xx/MAINTAINERS| 2 +- > board/ti/am64x/MAINTAINERS

Re: [u-boot PATCH] arm: mach-k3: am6_init: Prioritize MSMC traffic over DDR in NAVSS Northbridge

2021-09-08 Thread Nishanth Menon
ect/uboot/patch/20210908202859.10942-1...@ti.com/ -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

[PATCH V2] arm: mach-k3: am6_init: Prioritize MSMC traffic over DDR in NAVSS Northbridge

2021-09-08 Thread Nishanth Menon
-off-by: Nishanth Menon --- Changes in V2: * rebase (Thanks Jan) * Updated commit message. V1: https://patchwork.ozlabs.org/project/uboot/patch/20200130080503.28657-1-rog...@ti.com/ arch/arm/mach-k3/am6_init.c | 15 +++ arch/arm/mach-k3/include/mach/am6_hardware.h

Re: [u-boot PATCH] arm: mach-k3: am6_init: Prioritize MSMC traffic over DDR in NAVSS Northbridge

2021-09-07 Thread Nishanth Menon
. This will only effect traffic taking advantage of the 2 ports to MSMC and mapping to independent threads inside MSMC, one for SRAM and one for DDR bound traffic. In short, the patch is valid, we should be able to apply this consistently on AM65x SoCs independent of the platform. Hope this helps? -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

[PATCH] spl: fit: Skip attempting to load 0 length image

2021-10-19 Thread Nishanth Menon
When, for various reasons, a bad FIT image is used where a loadable image is marked as 0 length, attempt is made for a 0 length allocation and read of 0 byte read operation. Instead provide warning in log and skip attempting to do such a load. Signed-off-by: Nishanth Menon --- common/spl

Re: Help with TI-U-BOOT

2021-07-23 Thread Nishanth Menon
MLO.byteswap CFGCHK u-boot.cfg > Now, that said, since there is a bit of a mix of TI conventions involved, i would suggest asking for help in https://e2e.ti.com/ -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH 0/2] AM64: Tick timer fixes

2022-03-07 Thread Nishanth Menon
veloper.arm.com/documentation/102379//System-Counter?lang=en [2] https://developer.arm.com/documentation/den0024/a/Multi-core-processors/Multi-processing-systems/Timers -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH v2 0/2] AM64: Tick timer fixes

2022-03-18 Thread Nishanth Menon
Correct timer frequency > > arch/arm/dts/k3-am642-evm-u-boot.dtsi | 2 +- > arch/arm/dts/k3-am642-sk-u-boot.dtsi | 2 +- > configs/am64x_evm_a53_defconfig | 3 --- > 3 files changed, 2 insertions(+), 5 deletions(-) > > -- > 2.35.1 > Reviewed-by: Nishanth Menon

Re: [PATCH v2 1/2] configs: am64x_evm_a53_defconfig: Switch to per-cpu timer as tick provider

2022-03-18 Thread Nishanth Menon
er-cpu timer as tick timer for A53 SPL/U-Boot. > > Signed-off-by: Vignesh Raghavendra meh.. patchworks is still not smart[1] - so, responding per patch.. Reviewed-By: Nishanth Menon [1] https://github.com/getpatchwork/patchwork/issues/113 -- Regards, Nishanth Menon Key (0xDDB5849D17362

Re: [PATCH v2 2/2] ARM: dts: k3-am642: Correct timer frequency

2022-03-18 Thread Nishanth Menon
On 21:23-20220311, Vignesh Raghavendra wrote: > Timer0 runs at 200MHz,and the clock-frequency defined in DT is > incorrect. Fix it. > > Signed-off-by: Vignesh Raghavendra Reviewed-By: Nishanth Menon -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54

Re: [PATCH v1 1/4] misc: k3_esm: Add functionality to set and route error events within K3SoC

2022-02-03 Thread Nishanth Menon
any pending events */ > writel(ESM_SFT_RST_KEY, base + ESM_SFT_RST); > > - for (i = 0; i < num_pins; i++) > + for (i = 0; i < num_pins; i++) { > + esm_intr_prio_set(base, pins[i]); > + esm_clear_raw_status(base, pins[i]); >

Re: [PATCH v1 3/4] arch: arm: mach-k3: am642_init: Probe ESM nodes

2022-02-03 Thread Nishanth Menon
+44,17 @@ static void ctrl_mmr_unlock(void) > mmr_unlock(MCU_PADCFG_MMR1_BASE, 1); > } > > +static void mcu_ctrl_mmr_unlock(void) > +{ There is no real point in spliting this up into mcu_ctrl_mmr_unlock. I'd suggest putting it part of ctrl_mmr_unlock (we already do unlock MCU pa

Re: [PATCH v1 2/4] arm: dts: k3-am64: Add support for ESM device nodes

2022-02-03 Thread Nishanth Menon
0x0042 0x00 0x1000>, /* > ESM0 */ ^^ we need to ensure that kernel.org also has this specific change. We need to be able to copy the device tree files and overwrite u-boot device trees and things continue to function. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D)/Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH] arm: mach-k3: am642_init: Unlock MCU PADCFG regs

2022-01-14 Thread Nishanth Menon
> #define MAIN_DEVSTAT_PRIMARY_BOOTMODE_MASK 0x0078 > #define MAIN_DEVSTAT_PRIMARY_BOOTMODE_SHIFT 3 > Acked-by: Nishanth Menon -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH v2 01/20] remoteproc: k3_system_controller: Support optional boot_notification channel

2022-01-18 Thread Nishanth Menon
> > >> > > >> On 17/01/22 11:01 am, Aswath Govindraju wrote: > > >>> Hi Tom, > > >>> > > >>> On 13/01/22 7:42 pm, Tom Rini wrote: > > >>>> On Tue, Jan 11, 2022 at 01:25:26PM +0530, Aswath Govindraju wrote

[RFC/DONOT MERGE PATCH] arm: mach-k3: Enable Serror exception trap at u-boot

2022-01-07 Thread Nishanth Menon
: https://patchwork.ozlabs.org/project/uboot/cover/20200117012047.31096-1-andre.przyw...@arm.com/#2349054 Signed-off-by: Nishanth Menon --- This patch is RFC based on the discussion https://libera.irclog.whitequark.org/u-boot/2022-01-07 This is armv8 architecture implementation detail

Re: [RFC PATCH 2/2] configs: Add am62x_beagleplay_* defconfigs

2023-08-30 Thread Nishanth Menon
62x_evm_r5_defconfig + dfu.config 4. am62x_beagleplay_r5_dfu_defconfig = am62x_evm_r5_defconfig + beagleplay_r5.config + dfu.config This information can be in a single txt file Rather than have a defconfig file for each combination. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH v4 5/6] docs: board: ti: Add j721s2_evm documentation

2023-09-05 Thread Nishanth Menon
8 > > Reviewed-by: Neha Malcom Francis > Signed-off-by: Manorit Chawdhry > --- Reviewed-by: Nishanth Menon -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH v4 6/6] board: ti: j721s2: MAINTAINERS: Update the MAINTAINERS File.

2023-09-05 Thread Nishanth Menon
t; 1 file changed, 9 insertions(+), 2 deletions(-) > For whatever it is worth: Reviewed-by: Nishanth Menon -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH v2 7/7] arm: dts: k3-j721e: Sync with v6.5-rc1

2023-09-11 Thread Nishanth Menon
reg-names = "rt", "fifos", "proxy_gcfg", "proxy_target", "cfg"; > + bootph-pre-ram; > +}; > > - chipid@43000014 { > +_udmap { > + reg = <0x0 0x285c 0x0 0x100>, > + <0x0 0x284c 0x0 0x4000>, > + <0x0 0x2a80 0x0 0x4>, > + <0x0 0x284a 0x0 0x4000>, > + <0x0 0x2aa0 0x0 0x4>, > + <0x0 0x2840 0x0 0x2000>; > + reg-names = "gcfg", "rchan", "rchanrt", "tchan", > + "tchanrt", "rflow"; > bootph-pre-ram; > - }; > }; NOTE: v6.6-rc1 has been tagged yesterday - so it is probably time for us to sync with that and drop these. [...] -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH] ARM: dts: am335x-pocketbeagle: choose tick-timer

2023-09-11 Thread Nishanth Menon
On 09:27-20230909, Trevor Woerner wrote: > On Fri 2023-09-08 @ 12:36:17 PM, Nishanth Menon wrote: > > On 11:25-20230830, Trevor Woerner wrote: > > > Commit 4b2be78ab66c ("time: Fix get_ticks being non-monotonic") > > > requires '/chosen/tick-ti

[PATCH 1/4] arm: dts: Introduce k3-serdes.h from v6.6-rc1

2023-09-11 Thread Nishanth Menon
Introduce the new serdes header from kernel v6.6-rc1 The DTS uses constants for SERDES MUX idle state values which were earlier provided as bindings header. But they are unsuitable for bindings. So move these constants in a header next to DTS. Signed-off-by: Nishanth Menon --- arch/arm/dts/k3

[PATCH 3/4] dt-bindings: ti-serdes: Deprecate header with constants with v6.6-rc1

2023-09-11 Thread Nishanth Menon
references to bindings header are removed. So add a warning to mark this bindings header as deprecated. We could probably drop this header, but let us wait for kernel to cleanup. Signed-off-by: Nishanth Menon --- include/dt-bindings/mux/ti-serdes.h | 70 + 1 file c

Re: [PATCH] config: j7200: removed not needed power config

2023-09-11 Thread Nishanth Menon
POWER_DOMAIN && TI_SCI_PROTOCOL && !TI_POWER_DOMAIN help Generic power domain implementation for TI devices implementing the TI SCI protocol. config TI_POWER_DOMAIN bool "Enable the TI K3 Power domain driver" - depends on POWER_DOMAIN && ARCH_K3 + depends on POWER_DOMAIN && ARCH_K3 && !TI_SCI_POWER_DOMAIN help Generic power domain implementation for TI K3 devices. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

[PATCH 2/2] arm: dts: k3-am625: Sync with kernel v6.6-rc1

2023-09-11 Thread Nishanth Menon
Sync device tree with v6.6-rc1 Signed-off-by: Nishanth Menon --- arch/arm/dts/k3-am62-main.dtsi | 52 - arch/arm/dts/k3-am62-mcu.dtsi| 24 + arch/arm/dts/k3-am62-verdin-dev.dtsi | 50 + arch/arm/dts/k3-am62-verdin.dtsi | 45 +++- arch/arm/dts/k3

[PATCH 1/2] arm: dts: k3-pinctrl: Sync with kernel v6.6-rc1

2023-09-11 Thread Nishanth Menon
Sync pinctrl header with v6.6-rc1 Signed-off-by: Nishanth Menon --- arch/arm/dts/k3-pinctrl.h | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm/dts/k3-pinctrl.h b/arch/arm/dts/k3-pinctrl.h index c97548a3f42d..2a4e0e084d69 100644 --- a/arch/arm/dts/k3-pinctrl.h +++ b

Re: [PATCH] config: j7200: removed not needed power config

2023-09-11 Thread Nishanth Menon
On 20:29-20230911, Kumar, Udit wrote: > Thank you for suggestion Nishanth > > On 9/11/2023 6:51 PM, Nishanth Menon wrote: > > On 16:49-20230911, Udit Kumar wrote: > > > [..] > > And maybe expand this patch so that it contains something like the > > following to

[PATCH 0/2] arm: dts: k3-am625: Sync with kernel v6.6-rc1

2023-09-11 Thread Nishanth Menon
Sync device tree with v6.6-rc1 Bootlog: beagleplay: https://gist.github.com/nmenon/b46863248e8cf0cdaaeca0d55c966af4 Nishanth Menon (2): arm: dts: k3-pinctrl: Sync with kernel v6.6-rc1 arm: dts: k3-am625: Sync with kernel v6.6-rc1 arch/arm/dts/k3-am62-main.dtsi | 52 - arch

[PATCH 4/4] arm: dts: k3-am642: Sync with kernel v6.6-rc1

2023-09-11 Thread Nishanth Menon
Sync device tree with v6.6-rc1 Signed-off-by: Nishanth Menon --- arch/arm/dts/k3-am64-main.dtsi | 48 +++--- arch/arm/dts/k3-am642-evm.dts | 2 ++ arch/arm/dts/k3-am642-sk.dts | 6 ++--- 3 files changed, 25 insertions(+), 31 deletions(-) diff --git a/arch/arm

[PATCH 2/4] arm: dts: k3*: Use local header for SERDES MUX idle-state values

2023-09-11 Thread Nishanth Menon
The DTS uses constants for SERDES MUX idle state values which were earlier provided as bindings header. But they are unsuitable for bindings. So move these constants in a header next to DTS. NOTE: sync with v6.6-rc1 will bring in this change naturally. Signed-off-by: Nishanth Menon --- arch

[PATCH 0/4] arm: dts: k3-am642: Sync with kernel v6.6-rc1

2023-09-11 Thread Nishanth Menon
Sync with kernel v6.6-rc1 Bootlog: am642-sk: https://gist.github.com/nmenon/35f509e2f63b0ab0b434625e68e4f37d Nishanth Menon (4): arm: dts: Introduce k3-serdes.h from v6.6-rc1 arm: dts: k3*: Use local header for SERDES MUX idle-state values dt-bindings: ti-serdes: Deprecate header

Re: [PATCH] include: env: ti: mmc: Add 'ti' directory prefix for overlays

2023-09-15 Thread Nishanth Menon
done; > get_kern_mmc=load mmc ${bootpart} ${loadaddr} > > base-commit: 2fe4b54556ea6271237b35de68dc458bfceab94c we should move to stdboot and simplify this. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [RFC PATCH 1/2] doc: sphinx: Add sphinx-prompt

2023-08-24 Thread Nishanth Menon
On 17:47-20230824, Heinrich Schuchardt wrote: > On 24.08.23 17:40, Nishanth Menon wrote: > > Sphinx-prompt[1] helps bring-in '.. prompt::' option that allows a > > better rendered documentation, yet be able to copy paste without > > picking up the prompt from rendered docum

Re: [PATCH v1 2/2] board: verdin-am62: fix check for minimum memory size

2023-08-24 Thread Nishanth Menon
On 17:52-20230824, Francesco Dolcini wrote: > On Thu, Aug 24, 2023 at 09:58:56AM -0500, Nishanth Menon wrote: > > On 16:37-20230824, Francesco Dolcini wrote: > > > Hello Nishanth, > > > > > > On Thu, Aug 24, 2023 at 07:14:12AM -0500, Nishanth Menon wrote:

Re: [PATCH V5 08/17] include: env: ti: ti_common: Add a generic findfdt

2023-08-24 Thread Nishanth Menon
On 11:14-20230824, Tom Rini wrote: > On Wed, Aug 23, 2023 at 10:10:52PM -0500, Nishanth Menon wrote: > > ti_mmc bootmethod uses a findfdt routine that is expected to be > > implemented by all platforms. > > > > Define a default findfdt based on configured DEFAULT_DEVICE

Re: [PATCH V5 02/17] include: configs: am62x_evm: Drop unused SDRAM address

2023-08-24 Thread Nishanth Menon
On 10:13-20230824, Mattijs Korpershoek wrote: > Hi Nishanth, > > On mer., août 23, 2023 at 22:10, Nishanth Menon wrote: > > > Drop unused macro. This was meant for a second region of DDR which we > > do not need for AM62x evm configurations. > > >

Re: [PATCH V4 8/8] doc: board: ti: Add BeaglePlay documentation

2023-08-24 Thread Nishanth Menon
e $) in front of > each line and disallows copying it when copying from the html generated page. That does look like a very interesting option. This could very well be a different series of it's own, if Heinrich is OK with it.. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH v1 1/2] verdin-am62: add u-boot update wrappers

2023-08-24 Thread Nishanth Menon
adaddr} tiboot3.bin => mmc write ${loadaddr} 0x0 0x400 => fatload mmc 1 ${loadaddr} tispl.bin => mmc write ${loadaddr} 0x400 0x1000 => fatload mmc 1 ${loadaddr} u-boot.img => mmc write ${loadaddr} 0x1400 0x2000 -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH v1 2/2] board: verdin-am62: fix check for minimum memory size

2023-08-24 Thread Nishanth Menon
an 512MB RAM detected\n"); Have you considered fdtdec_setup_mem_size_base fdtdec_setup_memory_banksize - in which case the reserved memory regions can be changed in dt (will need corresponding custom binaries ofcourse).. > > return 0; > } > -- > 2.34.1 > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

[RFC PATCH 1/2] doc: sphinx: Add sphinx-prompt

2023-08-24 Thread Nishanth Menon
-by: Nishanth Menon --- Version picked is the best that works with Sphinx 3.4.3 doc/conf.py | 2 +- doc/sphinx/requirements.txt | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/conf.py b/doc/conf.py index 00f241366477..5e2ff1c8f5e2 100644 --- a/doc/conf.py +++ b

[RFC PATCH 0/2] doc: sphinx: Add sphinx-prompt

2023-08-24 Thread Nishanth Menon
applicable. Quick video to show the difference in experience: https://youtu.be/ylDrHXWGVgo Nishanth Menon (2): doc: sphinx: Add sphinx-prompt doc: board: ti: k3: Convert to sphinx-prompt doc/board/ti/k3.rst | 112 ++-- doc/conf.py | 2

<    2   3   4   5   6   7   8   9   10   11   >