On 13/03/2013 17:01, Marek Vasut wrote:
Apart of the fact that fixes booting old kernel, these changes affects
all mx28 boards, not only mx28evk. Can we have a description about which
changes are done and why they are required ?
Please see [1] below, this describes the situation at hand
On 13/03/2013 14:35, Benoît Thébaudeau wrote:
Hi Stefano,
Hi Benoît,
For that, patches 1 until 9 are related to i.MX and mainly to the NAND
for i.MX. They get already Scott's ACK. IMHO they are independent from
the rest of the patchset and they can be merged now. My proposal is that
I
On 13/03/2013 23:26, Albert ARIBAUD wrote:
On Wed, 13 Mar 2013 13:29:55 +0100, Albert ARIBAUD
albert.u.b...@aribaud.net wrote:
Hi Stefano,
Hi Albert,
Regardless of applying the two patches above, there is a merge conflict
between u-boot-imx/master and u-boot-arm/master between:
-
On 13/03/2013 23:59, Fabio Estevam wrote:
From: Fabio Estevam fabio.este...@freescale.com
Fix the following build error when buildig nitrogen6s1g:
nitrogen6x.c:89:17: error: 'CONFIG_DDR_MB' undeclared (first use in
this function)
nitrogen6x.c:89:17: note: each undeclared identifier is
On 13/03/2013 23:59, Fabio Estevam wrote:
From: Fabio Estevam fabio.este...@freescale.com
When building for the nitrogen boards with 2GB the following warning happens:
nitrogen6x.c:89:38: warning: integer overflow in expression [-Woverflow]
2GB can not fit in 32-bits, so use ulong
albert.u.b...@aribaud.net
Signed-off-by: Fabio Estevam fabio.este...@freescale.com
Signed-off-by: Stefano Babic sba...@denx.de
---
Changes since V1:
- move casting inside expression to force using unsigned long
board/boundary/nitrogen6x/nitrogen6x.c |2 +-
1 file changed, 1 insertion
On 14/03/2013 09:03, Stefano Babic wrote:
From: fabio.este...@freescale.com fabio.este...@freescale.com
When building for the nitrogen boards with 2GB the following warning happens:
nitrogen6x.c:89:38: warning: integer overflow in expression [-Woverflow]
2GB can not fit in 32-bits, so
albert.u.b...@aribaud.net
Signed-off-by: Fabio Estevam fabio.este...@freescale.com
Signed-off-by: Stefano Babic sba...@denx.de
---
Changes since V2:
- move casting inside expression to force using unsigned long
board/boundary/nitrogen6x/nitrogen6x.c |2 +-
1 file changed, 1 insertion
On 13/03/2013 23:49, Eric Nelson wrote:
Yes, but I used (ulong) instead.
Would it be OK?
Works for me...
Note that Troy wanted to see DDR_MB expressed as bytes instead,
which would have solved the overflow problem.
Ok, I sent also a fix, but I will wait for Troy's patch.
Regards,
On 14/03/2013 14:48, Eric Nelson wrote:
On 03/14/2013 02:38 AM, Stefano Babic wrote:
On 13/03/2013 23:49, Eric Nelson wrote:
Yes, but I used (ulong) instead.
Would it be OK?
Works for me...
Note that Troy wanted to see DDR_MB expressed as bytes instead,
which would have solved
On 14/03/2013 14:15, Albert ARIBAUD wrote:
Hi Stefano,
On Thu, 14 Mar 2013 09:09:21 +0100, Stefano Babic sba...@denx.de
wrote:
From: fabio.este...@freescale.com fabio.este...@freescale.com
When building for the nitrogen boards with 2GB the following warning happens:
nitrogen6x.c:89:38
mxs: Fix iomux.h to not break build during assembly stage
mx23_olinuxino: Add support for status LED
mx23evk: Enable USB support
mx23_olinuxino: Enable USB support
mx23_olinuxino: Add ethernet support
mx23_olinuxino: Fix warning for implicit declaration
Stefano
supply.
I understand that less redundant information is better, but this is very
important info and it cannot be used only if DEBUG is set. IMHO we
should let it as it is - it helps us when something bad happens.
Best regards,
Stefano Babic
initialized between them. It will still behave the
same old way for all other network operations and any time another
network operation happens between netconsole operations.
Hi Joe,
Signed-off-by: Joe Hershberger joe.hershber...@ni.com
Cc: Stefano Babic sba...@denx.de
---
common
...@advansee.com
Cc: Wolfgang Denk w...@denx.de
Cc: Stefano Babic sba...@denx.de
---
.../drivers/spi/mxc_spi.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git u-boot-4d3c95f.orig/drivers/spi/mxc_spi.c
u-boot-4d3c95f/drivers/spi/mxc_spi.c
aflem...@gmail.com
Cc: Stefano Babic sba...@denx.de
Cc: Kim Phillips kim.phill...@freescale.com
---
.../drivers/mmc/fsl_esdhc.c|3 +++
1 file changed, 3 insertions(+)
diff --git u-boot-4d3c95f.orig/drivers/mmc/fsl_esdhc.c
u-boot-4d3c95f/drivers/mmc/fsl_esdhc.c
On 11/08/2012 16:39, Benoît Thébaudeau wrote:
Hi Stefano,
Hi,
fsl_esdhc_mmc_init() exists, so it should give access to all features.
This was left for compatibility with PowerPC SOCs.
Moreover,
it's shorter to #define a config option than to create custom fsl_esdhc_mmc
init
functions
this issue, and I have never update the status of
my patch. Is ther estill some interest on this or have I missed
something and now is the behavior in shell as in your example ?
Best regards,
Stefano Babic
--
=
DENX Software Engineering
for CONFIG_MX* results clear for us today, but
nobody will remember after some times and if the checked CONFIG_MX* will
be changed, it will have drawbacks not so evident on MMC. I prefer the
first solution, adding an entry to imx-regs.h.
Best regards,
Stefano Babic
somewhere.
can I ask you which kind of problems you have seen on a i.MX35 ? I was
curious after your e-amil and I enabled the FSL_ESDHC driver on a
mx35pdk - it seems working out of the box, I have not changed the driver.
Best regards,
Stefano Babic
On 09/08/2012 18:01, Tom Rini wrote:
Hey all,
Hi Tom,
As Allen Martin noted, on tegra platforms a bug is exposed when using
certain toolchains that currently calls to lowlevel_init must be calls
to another assembly function as the stack is not explicitly setup /
saved and thus register
if
fsl_esdhc_mmc_init() were used for an i.MX board.
Signed-off-by: Benoît Thébaudeau benoit.thebaud...@advansee.com
Cc: Andy Fleming aflem...@gmail.com
Cc: Stefano Babic sba...@denx.de
Cc: Kim Phillips kim.phill...@freescale.com
---
.../board/efikamx/efikamx.c|4
On 13/08/2012 16:39, Benoît Thébaudeau wrote:
Why don't you get rid of no_snoop at all ? Using ARCH_IMX is not
needed
anymore.
Because I didn't know if disabling cache snooping could be a useful option or
not for architectures other than i.MX, so I preferred to leave it just in
case,
MX28
include asm/arch/regs-clkctrl-mx28.h
#else #ifdef MX23
include asm/arch/regs-clkctrl-mx23.h
Best regards,
Stefano Babic
--
=
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office
On 13/08/2012 22:48, Benoît Thébaudeau wrote:
This patches fixes the TODO to use same register definitions in mtd mxc_nand
and
nand_spl fsl nfc drivers.
Signed-off-by: Benoît Thébaudeau benoit.thebaud...@advansee.com
Cc: Scott Wood scottw...@freescale.com
Cc: Stefano Babic sba...@denx.de
On 13/08/2012 22:48, Benoît Thébaudeau wrote:
Signed-off-by: Benoît Thébaudeau benoit.thebaud...@advansee.com
Cc: Scott Wood scottw...@freescale.com
Cc: Stefano Babic sba...@denx.de
---
.../drivers/mtd/nand/mxc_nand.c|9 +++--
.../include/fsl_nfc.h
On 13/08/2012 22:50, Benoît Thébaudeau wrote:
Use _mxc_nand_enable_hwecc() instead of duplicating its code.
Signed-off-by: Benoît Thébaudeau benoit.thebaud...@advansee.com
Cc: Scott Wood scottw...@freescale.com
Cc: Stefano Babic sba...@denx.de
---
Hi Benoît,
+#ifdef
On 13/08/2012 22:48, Benoît Thébaudeau wrote:
Merge duplicated code into functions, which is better for SPL size too.
Signed-off-by: Benoît Thébaudeau benoit.thebaud...@advansee.com
Cc: Scott Wood scottw...@freescale.com
Cc: Stefano Babic sba...@denx.de
---
Hi Benoît,
.../nand_spl
: Scott Wood scottw...@freescale.com
Cc: Stefano Babic sba...@denx.de
---
Hi Benoît,
.../include/configs/flea3.h|1 -
.../include/configs/mx35pdk.h |1 -
.../include/configs/tx25.h |1 -
.../include/fsl_nfc.h
increase the number of boards using nand_spl.
Best regards,
Stefano Babic
--
=
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49
by another patch later.
Best regards,
Stefano Babic
--
=
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142
On 14/08/2012 13:13, Benoît Thébaudeau wrote:
Hi Stefano,
Hi Benoît,
We have currently only two boards supporting this mechanismus, using
MX25 (karo tx25) and MX31. Both MX25 and MX31 have an internal RAM
(128KB) that is is suitable for installing the SPL. Note that TI SOCs
have less RAM
-boot-imx, thanks.
Best regards,
Stefano Babic
--
=
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49
On 05/08/2012 18:17, Fabio Estevam wrote:
From: Fabio Estevam fabio.este...@freescale.com
Turn on data and instruction caches.
Signed-off-by: Fabio Estevam fabio.este...@freescale.com
---
Applied to u-boot-imx, thanks.
Best regards,
Stefano Babic
asm/io.h
-#include asm/arch/iomux-mx28.h
#include asm/arch/imx-regs.h
#include asm/arch/sys_proto.h
#include asm/gpio.h
Applied to u-boot-imx (the whole series), thanks.
Best regards,
Stefano Babic
--
=
DENX Software
On 10/08/2012 09:26, Bastian Ruppert wrote:
Signed-off-by: Bastian Ruppert bastian.rupp...@sewerin.de
CC: Tom Rini tr...@ti.com
CC: Stefano Babic sba...@denx.de
---
include/configs/ea20.h | 106
++--
1 files changed, 66 insertions(+), 40
)
+ defined(CONFIG_MACH_DAVINCI_DA850_EVM) \
+ !defined(CONFIG_DRIVER_TI_EMAC_RMII_NONEG)
for (i = 0; i num_phy; i++) {
if (phy[i].is_phy_connected(i))
phy[i].auto_negotiate(i);
Acked-by: Stefano Babic sba...@denx.de
Best
On 10/08/2012 09:26, Bastian Ruppert wrote:
Signed-off-by: Bastian Ruppert bastian.rupp...@sewerin.de
CC: Tom Rini tr...@ti.com
CC: Stefano Babic sba...@denx.de
---
board/davinci/ea20/ea20.c | 23 +++
1 files changed, 15 insertions(+), 8 deletions(-)
diff --git
On 10/08/2012 09:26, Bastian Ruppert wrote:
Do not allow to overwrite it when video is enabled.
Signed-off-by: Bastian Ruppert bastian.rupp...@sewerin.de
CC: Tom Rini tr...@ti.com
CC: Stefano Babic sba...@denx.de
---
Acked-by: Stefano Babic sba...@denx.de
Best regards,
Stefano Babic
On 15/08/2012 20:11, Benoît Thébaudeau wrote:
Hi Stefano,
Hi Benoît,
I understand this part as the mx35 goes on to copy the whole image,
depending on the size set into the header, to the address specified
in
the table itself. There is no limitation. Exactly in the same way
it
works on
On 15/08/2012 23:30, Tom Rini wrote:
Hey all,
Hi Tom,
The following patch series merges the davinci and omap-common SPL
frameworks into a single framework, CONFIG_SPL_FRAMEWORK along with a
few small cleanups to the code to make it a little smaller and more
flexible. The end result is
On 15/08/2012 23:30, Tom Rini wrote:
Add a new flag, CONFIG_SPL_FRAMEWORK to opt into the arch/arm/lib SPL
framework, enable on all of the previously using boards.
Signed-off-by: Tom Rini tr...@ti.com
---
Hi Tom,
README |5 +
== MMCSD_MODE_FAT) {
debug(boot mode - FAT\n);
mmc_load_image_fat(mmc);
+#endif
} else {
puts(spl: wrong MMC boot mode\n);
hang();
Right, this should be done !
Acked-by: Stefano Babic sba...@denx.de
Regards,
Stefano
On 15/08/2012 23:30, Tom Rini wrote:
This detection code doesn't (and can't) do anything currently, so
remove.
Signed-off-by: Tom Rini tr...@ti.com
---
arch/arm/cpu/armv7/omap3/board.c |3 ---
arch/arm/include/asm/omap_common.h |1 -
arch/arm/lib/spl_nand.c| 13
On 15/08/2012 23:30, Tom Rini wrote:
We can only attempt to setup a malloc pool if
CONFIG_SYS_SPL_MALLOC_START is defined, and not all boards require it.
Make the call depend on the define.
Signed-off-by: Tom Rini tr...@ti.com
---
arch/arm/lib/spl.c |2 ++
1 file changed, 2
On 15/08/2012 23:30, Tom Rini wrote:
This is an OMAP/related-specific function, move calling it to
spl_board_init() and turn on CONFIG_SPL_BOARD_INIT on the boards that
enabled NAND and didn't enable this already.
Signed-off-by: Tom Rini tr...@ti.com
---
/io.h
#include asm/arch/clock.h
#include asm/arch/imx-regs.h
+#include asm/arch/iomux.h
#include asm/arch/mx6x_pins.h
#include asm/errno.h
#include asm/gpio.h
Acked-by: Stefano Babic sba...@denx.de
Best regards,
Stefano Babic
On 16/08/2012 16:38, Tom Rini wrote:
On 08/16/2012 12:45 AM, Stefano Babic wrote:
On 15/08/2012 23:30, Tom Rini wrote:
Add a new flag, CONFIG_SPL_FRAMEWORK to opt into the arch/arm/lib SPL
framework, enable on all of the previously using boards.
Signed-off-by: Tom Rini tr...@ti.com
---
Hi
idea to have a watchdog driver in drivers/watchdog.
Feel free to add a driver here and replacing the i.MX31 stuff.
Best regards,
Stefano Babic
--
=
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235
Babic sba...@denx.de
Best regards,
Stefano Babic
--
=
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49
for apx4devkit, I have added it, but
you get here my:
Acked-by: Stefano Babic sba...@denx.de
Best regards,
Stefano Babic
--
=
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office
without documentation. Can you add an entry into the
README file (I know, a lot of CONFIG_ are missing, but we can at least
avoid to add hidden features..).
Best regards,
Stefano Babic
--
=
DENX Software Engineering GmbH, MD
{
+ const char *name;
+ unsigned cfg_val;
+};
+
+void add_board_boot_modes(const struct boot_mode *p);
+void boot_mode_apply(unsigned cfg_val);
+extern const struct boot_mode soc_boot_modes[];
+#endif
Acked-by: Stefano Babic sba...@denx.de
Best regards,
Stefano Babic
to use it. You can set
it to 0x5301 (better write as in your comment, (GPIO 8) + CS) and sf
probe will take it automatically.
Best regards,
Stefano Babic
--
=
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB
regards,
Stefano Babic
--
=
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba
CSPI3_BASE_ADDR
These are not configurable. If a board is a MX5, they are fixed from
imx-regs.h. See also my previous answer to Patch 2/3.
Best regards,
Stefano Babic
--
=
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev
On 15/08/2012 19:11, Tom Rini wrote:
On Tue, Aug 14, 2012 at 10:40:50PM +0200, Jeroen Hofstee wrote:
Several omap boards won't build when DEBUG is defined, SPL build error:
vsprintf.c:791: undefined reference to `do_reset', since SPL has no
commands. Therefore don't call do_reset in SPL. SPL
as well.
[1] http://git.bfuser.eu/?p=marex/mxsldr.git;a=summary
Signed-off-by: Marek Vasut ma...@denx.de
Cc: Stefano Babic sba...@denx.de
Cc: Fabio Estevam fabio.este...@freescale.com
---
arch/arm/cpu/arm926ejs/mx28/start.S | 42
---
1 file changed, 42
On 06/08/2012 23:34, Marek Vasut wrote:
Move some function calls to a more appropriate place, so they're
called only when needed.
Signed-off-by: Marek Vasut ma...@denx.de
Cc: Stefano Babic sba...@denx.de
Cc: Fabio Estevam fabio.este...@freescale.com
---
arch/arm/cpu/arm926ejs/mx28
On 14/08/2012 15:17, Benoît Thébaudeau wrote:
Now that the main i.MX features work fine with dcache enabled, enabled it by
default if CONFIG_SYS_DCACHE_OFF is not defined.
Signed-off-by: Benoît Thébaudeau benoit.thebaud...@advansee.com
Cc: Stefano Babic sba...@denx.de
---
.../arch/arm/cpu
On 14/08/2012 15:17, Benoît Thébaudeau wrote:
Now that the main i.MX features work fine with dcache enabled, enabled it by
default if CONFIG_SYS_DCACHE_OFF is not defined.
Signed-off-by: Benoît Thébaudeau benoit.thebaud...@advansee.com
Cc: Stefano Babic sba...@denx.de
---
.../arch/arm/cpu
On 14/08/2012 15:28, Benoît Thébaudeau wrote:
Signed-off-by: Benoît Thébaudeau benoit.thebaud...@advansee.com
Cc: Stefano Babic sba...@denx.de
---
.../arch/arm/include/asm/arch-mx35/crm_regs.h |4 ++--
.../board/CarMediaLab/flea3/flea3.c|2 +-
.../board
On 14/08/2012 15:33, Benoît Thébaudeau wrote:
Signed-off-by: Benoît Thébaudeau benoit.thebaud...@advansee.com
Cc: Stefano Babic sba...@denx.de
---
.../arch/arm/include/asm/arch-mx31/imx-regs.h |2 +-
.../arch/arm/include/asm/arch-mx35/imx-regs.h |2 +-
2 files changed, 2
-by: Benoît Thébaudeau benoit.thebaud...@advansee.com
Cc: Stefano Babic sba...@denx.de
---
Hi Benoît,
to my understanding. The SION bit is used to set a predefined function,
independently from the value of the iomux. So I have the choice to set
the SION bit or I select the function I want, including
On 14/08/2012 17:18, Benoît Thébaudeau wrote:
Coding style cleanup:
- Remove useless parentheses.
- Use tabs for indentations and alignments.
Signed-off-by: Benoît Thébaudeau benoit.thebaud...@advansee.com
Cc: Stefano Babic sba...@denx.de
---
Changes for v2:
- Make patch description
On 14/08/2012 17:30, Benoît Thébaudeau wrote:
Do not pretend to have initialized mmc successfully if CONFIG_FSL_ESDHC is not
defined.
Signed-off-by: Benoît Thébaudeau benoit.thebaud...@advansee.com
Cc: Stefano Babic sba...@denx.de
---
Hi Benoît,
.../arch/arm/cpu/armv7/imx-common/cpu.c
On 14/08/2012 17:01, Benoît Thébaudeau wrote:
Signed-off-by: Benoît Thébaudeau benoit.thebaud...@advansee.com
Cc: Stefano Babic sba...@denx.de
---
Hi Benoît,
.../arch/arm/cpu/armv7/imx-common/timer.c |6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git u
: Stefano Babic sba...@denx.de
---
Hi Benoît,
just some minor points:
.../arch/arm/cpu/arm1136/mx35/timer.c | 43
.../include/configs/flea3.h|1 +
.../include/configs/mx35pdk.h |1 +
3 files changed, 27
benoit.thebaud...@advansee.com
Cc: Stefano Babic sba...@denx.de
---
.../arch/arm/cpu/armv7/imx-common/timer.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git u-boot-4d3c95f.orig/arch/arm/cpu/armv7/imx-common/timer.c
u-boot-4d3c95f/arch/arm/cpu/armv7/imx-common
On 14/08/2012 23:03, Benoît Thébaudeau wrote:
Signed-off-by: Benoît Thébaudeau benoit.thebaud...@advansee.com
Cc: Stefano Babic sba...@denx.de
---
.../arch/arm/include/asm/arch-mx35/imx-regs.h |1 -
1 file changed, 1 deletion(-)
diff --git u-boot-4d3c95f.orig/arch/arm/include/asm
regards,
Stefano Babic
--
=
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba
On 14/08/2012 17:46, Benoît Thébaudeau wrote:
Create default pin initialization functions for the default iomux function
assignments of the main peripherals.
Signed-off-by: Benoît Thébaudeau benoit.thebaud...@advansee.com
Cc: Stefano Babic sba...@denx.de
---
Hi Benoît,
.../arch/arm/cpu
On 17/08/2012 21:52, Benoît Thébaudeau wrote:
Hi Stefano,
On 14/08/2012 17:01, Benoît Thébaudeau wrote:
Signed-off-by: Benoît Thébaudeau benoit.thebaud...@advansee.com
Cc: Stefano Babic sba...@denx.de
---
Hi Benoît,
.../arch/arm/cpu/armv7/imx-common/timer.c |6 +-
1
idiot doing something wrong.
We all know that this is impossible because idiots are very creative ;-)
Best regards,
Stefano Babic
--
=
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich
On 17/08/2012 23:03, Benoît Thébaudeau wrote:
OK, then for mx25/35/5/6, would you like in timer.c something like:
#ifdef CONFIG_SYS_MX{*}_CLK32
#define CLK_32KHZ CONFIG_SYS_MX{*}_CLK32
#else
#define CLK_32KHZ 32768
#endif
{*}: 25, 35, 5 or 6
In that way, this
On 17/08/2012 22:43, Benoît Thébaudeau wrote:
Add cpu_mmc_init() function to make it easy to init a single eSDHC instance.
Signed-off-by: Benoît Thébaudeau benoit.thebaud...@advansee.com
Cc: Stefano Babic sba...@denx.de
---
Changes for v2:
- Do not define cpu_mmc_init
On 17/08/2012 22:42, Benoît Thébaudeau wrote:
Do not pretend to have initialized mmc successfully if CONFIG_FSL_ESDHC is not
defined. Instead, only implement a custom cpu_mmc_init() when it does
something.
Signed-off-by: Benoît Thébaudeau benoit.thebaud...@advansee.com
Cc: Stefano Babic
Babic sba...@denx.de
Best regards,
Stefano Babic
--
=
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49
);
if (!mxcs) {
puts(mxc_spi: SPI Slave not allocated !\n);
return NULL;
Agree, the structure must be zeroed.
Acked-by: Stefano Babic sba...@denx.de
Best regards,
Stefano Babic
--
=
DENX Software
),
+ MX51_PAD_GPIO1_8__SD2_CD= IOMUX_PAD(0x814,
0x3e8, 6, __NA_, 0, MX51_ESDHC_PAD_CTRL),
+};
+
+#endif /* __IOMUX_MX51_H__ */
Ok, good, this is the same as in kernel.
Best regards,
Stefano Babic
--
=
DENX Software
Each i.MX has its own gpio.h, defining the same structure.
The internal GPIO controller has the same layout
(at least for the register used by u-boot) and can be shared.
Signed-off-by: Stefano Babic sba...@denx.de
CC: Matt Sealey m...@genesi-usa.com
CC: Marek Vasut ma...@denx.de
CC: Benoit
? I think you should add only yours.
# Copyright (C) 2010 Marek Vasut marek.va...@gmail.com
-#
-# BASED ON: imx51evk
+# Copyright (C) 2009-2012 Genesi USA, Inc.
#
# (C) Copyright 2009
# Stefano Babic DENX Software Engineering sba...@denx.de.
@@ -43,48 +43,44 @@ BOOT_FROM spi
and disadvantages.
Anyway, who will maintain the efikas in future ? Marek, do you hold it,
or Matt will take this job ? In last case I would like to see a patch
for the MAINTAINER file.
Best regards,
Stefano Babic
--
=
DENX Software
-by: Stefano Babic sba...@denx.de
Best regards.
Stefano Babic
--
=
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0
Am 18/08/2012 21:25, schrieb Benoît Thébaudeau:
#define MXC_GPIO_PORT_TO_NUM(port, bit) (((port - 1) 5) + (bit
0x1f))
Keeping this is also useless. GPIO_NUMBER() from the new
asm/imx-common/gpio.h
can be used instead everywhere needed.
That is right - I drop it.
-/* GPIO
Am 18/08/2012 23:02, schrieb Matt Sealey:
On Sat, Aug 18, 2012 at 10:50 AM, Stefano Babic sba...@denx.de wrote:
On 17/08/2012 20:19, Matt Sealey wrote:
Anyway, who will maintain the efikas in future ? Marek, do you hold it,
or Matt will take this job ?
I can't test every patch
everyone
and it is not common i.MX code - I can't only
make a review because it is difficult to read it.
Best regards,
Stefano Babic
--
=
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5
Am 18/08/2012 23:18, schrieb Matt Sealey:
I will, for now it's the top of Linus' tree, but this code is going to
get removed from the Linux kernel soon, so I understand, we need to
figure out where it will last forever (probably linux-stable@3.5) so
we can always reference it.
Right. Add
Am 19/08/2012 00:28, schrieb Otavio Salvador:
On Sat, Aug 18, 2012 at 7:06 PM, Marek Vasut ma...@denx.de wrote:
Dear Otavio Salvador,
On Sat, Aug 18, 2012 at 3:03 PM, Marek Vasut marek.va...@gmail.com wrote:
I think we should try and see if the mx28 and mx23 .bd can't be converged
together
Am 19/08/2012 00:29, schrieb Marek Vasut:
Dear Matt Sealey,
On Sat, Aug 18, 2012 at 10:34 AM, Stefano Babic sba...@denx.de wrote:
On 17/08/2012 20:19, Matt Sealey wrote:
The i.MX Boot ROM lets us set up certain registers before U-Boot even
gets executed. Rather than setting up DDR, putting
Am 19/08/2012 00:59, schrieb Fabio Estevam:
Hi Stefano,
On Sat, Aug 18, 2012 at 12:26 PM, Stefano Babic sba...@denx.de wrote:
+#define GPIO_NUMBER(port, index)
port)-1)*32)+((index)31))
What about calling this macro IMX_GPIO_NR instead?
This way we can have
On 19/08/2012 02:25, Benoît Thébaudeau wrote:
Hi Stefano,
#define MXC_GPIO_PORT_TO_NUM(port, bit) (((port - 1) 5) + (bit
0x1f))
Keeping this is also useless. GPIO_NUMBER() from the new
asm/imx-common/gpio.h
can be used instead everywhere needed.
That is right - I drop it.
I
Signed-off-by: Stefano Babic sba...@denx.de
---
Changes in v2:
- call the macro IMX_GPIO_NR as in kernel (Fabio Estevam)
- change psr in gpio_psr (Benoit Thebaudeau)
- drop MXC_GPIO_PORT_TO_NUM and use common macro (Benoit Thebaudeau)
arch/arm/include/asm/arch-mx25/gpio.h |5
CONFIG_ENV_IS_IN_SPI_FLASH
#ifdef CONFIG_ENV_IS_IN_SPI_FLASH
#define CONFIG_SYS_REDUNDAND_ENVIRONMENT
#define CONFIG_ENV_SIZE 0x1000 /* 4KB */
Acked-by: Stefano Babic sba...@denx.de
Regards,
Stefano
Signed-off-by: Stefano Babic sba...@denx.de
---
Changes in v2:
- please ignore this version, it is broken
Changes in v3:
- call the macro IMX_GPIO_NR as in kernel (Fabio Estevam)
- change psr in gpio_psr (Benoit Thebaudeau)
- drop MXC_GPIO_PORT_TO_NUM and use common macro (Benoit Thebaudeau
Am 19/08/2012 15:30, schrieb Benoît Thébaudeau:
Hi Stefano,
Your detailed description from v1 is gone.
I will add it again
Signed-off-by: Stefano Babic sba...@denx.de
Your Cc's from v1 are gone.
This is ok - I used patman this time, and CC are automatically handled
by the tool
Each i.MX has its own gpio.h, defining the same structure.
The internal GPIO controller has the same layout
(at least for the register used by u-boot) and can be shared.
Signed-off-by: Stefano Babic sba...@denx.de
---
Changes in v2:
- please ignore this version, it is broken
Changes in v3
as well.
[1] http://git.bfuser.eu/?p=marex/mxsldr.git;a=summary
Signed-off-by: Marek Vasut ma...@denx.de
Cc: Stefano Babic sba...@denx.de
Cc: Fabio Estevam fabio.este...@freescale.com
---
Applied to u-boot-imx, thanks.
Best regards,
Stefano Babic
On 06/08/2012 23:34, Marek Vasut wrote:
Move some function calls to a more appropriate place, so they're
called only when needed.
Signed-off-by: Marek Vasut ma...@denx.de
Cc: Stefano Babic sba...@denx.de
Cc: Fabio Estevam fabio.este...@freescale.com
---
arch/arm/cpu/arm926ejs/mx28
regards,
Stefano Babic
--
=
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba
401 - 500 of 6679 matches
Mail list logo
