Re: [PATCH] pytest:Shutdown power-supply to board after the pytest execution

2021-05-27 Thread Stephen Warren
On 5/27/21 2:33 AM, opensource@gmail.com wrote: From: Adarsh Babu Kalepalli After executing the test-cases from pytest ,the board is still powered.Shutting down the board power supply at this point ,would keep the board safe. FWIW, this violates the original design of the test system.

Re: [PATCH] uboot-test-hooks: Switch to our GitLab instance

2021-02-22 Thread Stephen Warren
On 2/22/21 8:49 AM, Tom Rini wrote: > As Stephen is no longer actively maintaining the uboot-test-hooks > repository, switch to using the instance on our GitLab. Acked-by: Stephen Warren

RE: [PATCH] Tegra: remove e2220-1170 board

2021-02-17 Thread Stephen Warren
Peter Robinson wrote at Wednesday, February 17, 2021 10:07 AM: > It's an old bringup board with out upstream Linux or L4T support > > Signed-off-by: Peter Robinson > Cc: Stephen Warren > Cc: Tom Warren > --- > > The E2220-1170 was a Tegra210 bringup board and outside

[PATCH v2] test/py: fix runtest wrapper for pytest 6

2021-01-31 Thread Stephen Warren
than this. Reported-by: Heinrich Schuchardt Signed-off-by: Stephen Warren --- v2: Rebased on a marginally newer commit, hence removed the change to test/py/test.py. Cleaned up return statement. --- test/py/conftest.py | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/test/py

[PATCH] test/py: support pytest 6

2021-01-30 Thread Stephen Warren
implementations do need to do a little more than this. Reported-by: Heinrich Schuchardt (point 2) Signed-off-by: Stephen Warren --- test/py/conftest.py | 5 - test/py/test.py | 4 ++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/test/py/conftest.py b/test/py/conftest.py index

Re: [PATCH V3] net: dwc_eth_qos: Pad descriptors to cacheline size

2021-01-07 Thread Stephen Warren
eneric cache flush / invalidate operations. Tested-by: Stephen Warren Reviewed-by: Stephen Warren

Re: [PATCH V2] net: dwc_eth_qos: Pad descriptors to cacheline size

2021-01-06 Thread Stephen Warren
On 1/6/21 2:10 PM, Marek Vasut wrote: > On 1/6/21 10:06 PM, Stephen Warren wrote: > [...] > >>>>> diff --git a/include/configs/tegra-common-post.h >>>>> b/include/configs/tegra-common-post.h >>>> >>>>> -#define CONFIG_SYS_NO

Re: [PATCH V2] net: dwc_eth_qos: Pad descriptors to cacheline size

2021-01-06 Thread Stephen Warren
On 1/6/21 1:53 PM, Marek Vasut wrote: > On 1/6/21 8:25 PM, Stephen Warren wrote: >> On 1/6/21 7:14 AM, Marek Vasut wrote: >>> The DWMAC4 IP has the possibility to skip up to 7 AXI bus width size >>> words >>> after the descriptor. Use this to pad t

Re: [PATCH V2] net: dwc_eth_qos: Pad descriptors to cacheline size

2021-01-06 Thread Stephen Warren
On 1/6/21 7:14 AM, Marek Vasut wrote: > The DWMAC4 IP has the possibility to skip up to 7 AXI bus width size words > after the descriptor. Use this to pad the descriptors to cacheline size and > remove the need for noncached memory altogether. Moreover, this lets Tegra > use the generic cache

Re: [PATCH V2] mmc: display an error number to debug

2020-11-17 Thread Stephen Warren
On 11/16/20 3:04 PM, Jaehoon Chung wrote: > It's useful to know an error number when it's debugging. > > Signed-off-by: Jaehoon Chung > Reviewed-by: Peng Fan > --- > Changelog on V2 > - Change from "put" to "printf" to fix build error Note that v1 was already applied to u-boot-mmc/master,

Re: [PATCH] mmc: display an error number to debug

2020-11-16 Thread Stephen Warren
On 11/6/20 4:23 AM, Jaehoon Chung wrote: > It's useful to know an error number when it's debugging. > diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c > @@ -2746,7 +2746,7 @@ static int mmc_power_on(struct mmc *mmc) > int ret = regulator_set_enable(mmc->vmmc_supply, true); > >

Re: [PATCH 15/17] pytest: Collect SPL unit tests

2020-10-26 Thread Stephen Warren
On 10/23/20 1:27 PM, Simon Glass wrote: > Hi Stephen, > > On Mon, 5 Oct 2020 at 15:35, Stephen Warren wrote: >> >> On 10/5/20 1:51 PM, Simon Glass wrote: >>> Hi Stephen, >>> >>> On Mon, 5 Oct 2020 at 13:39, Stephen Warren wrote: >>>>

Re: [PATCH 15/17] pytest: Collect SPL unit tests

2020-10-05 Thread Stephen Warren
On 10/5/20 1:51 PM, Simon Glass wrote: > Hi Stephen, > > On Mon, 5 Oct 2020 at 13:39, Stephen Warren wrote: >> >> On 10/3/20 9:25 AM, Simon Glass wrote: >>> Add a new test_spl fixture to handle running SPL unit tests. >> >>> diff --gi

Re: [PATCH 15/17] pytest: Collect SPL unit tests

2020-10-05 Thread Stephen Warren
On 10/3/20 9:25 AM, Simon Glass wrote: > Add a new test_spl fixture to handle running SPL unit tests. > diff --git a/test/py/conftest.py b/test/py/conftest.py > @@ -317,10 +318,13 @@ def pytest_generate_tests(metafunc): > Returns: > Nothing. > """ > - > +#print('name',

Re: [PATCH v2 1/6] arm64: PIE: Do not skip static relocation

2020-09-30 Thread Stephen Warren
NU binutils starting with v2.27.1 do this build-time relocation > automatically, to be in-line with other architecures. So on newer > toolchains our manual fixup is actually not needed. It doesn't hurt to > have it, though, so that we keep compatibility with the popular Linaro > toolchains, which lack this feature. Reviewed-by: Stephen Warren

Re: [PATCH 5/5] qemu-arm64: Enable POSITION_INDEPENDENT

2020-09-24 Thread Stephen Warren
initial stack, we need to keep the fixed initial > stack pointer, which points to DRAM in our case. Patches 1,2,5: Reviewed-by: Stephen Warren I guess we'll need to add/modify a patch to re-enable STATIC_RELA.

Re: [PATCH 1/5] arm64: PIE: Skip fixups if distance is zero

2020-09-24 Thread Stephen Warren
On 9/24/20 8:45 AM, André Przywara wrote: > On 24/09/2020 01:17, Andre Przywara wrote: >> When the actual offset between link and runtime address is zero, there >> is no need for patching up U-Boot early when running with >> CONFIG_POSITION_INDEPENDENT. > > That turns out to be not fully true. >

Re: [PATCH test hooks 1/1] u-boot-hooks: add virtio-rng-pci

2020-09-22 Thread Stephen Warren
On 9/22/20 12:27 PM, Heinrich Schuchardt wrote: > In the UEFI subsystem we test the RNG device. > On QEMU it is provided via '-device virtio-rng-pci'. > > We need to add this PCI device before enable DM_RNG on ARCH_ARM. Applied, thanks.

Re: [PATCH] RFC: tegra: xhci: Allocate from non-cached memory

2020-09-14 Thread Stephen Warren
On 9/12/20 9:24 AM, Marek Vasut wrote: > On 9/11/20 9:43 PM, twar...@nvidia.com wrote: >> From: Tom Warren >> >> This fixes the XHCI driver on T210 boards (TX1, Nano). I was seeing >> that Set_Address wasn't completing, returning with a Context Parameter >> error. Examining the slot context, etc.

Re: [PATCH 1/1] test: do no assume hush parser in validate_empty()

2020-09-10 Thread Stephen Warren
On 9/10/20 4:09 AM, Heinrich Schuchardt wrote: > The environment variable test uses function validate_empty() to check that > a variable is not defined. If the hush parser is not enabled, we cannot > refer to a variable by $var_name but only by ${var_name}. Acked-by: Stephen Warren

Re: [PATCH v3 0/4] arm64: Large PIE fixes

2020-09-09 Thread Stephen Warren
sted by reviewers, I've also added a runtime check for > non-PIE builds to trap the startup sequence early if the start > address doesn't match between run-time and link-time. The series, Reviewed-by: Stephen Warren

Re: [PATCH v2 2/3] arm64: Bail out PIE builds early if load address is not 4K aligned

2020-09-08 Thread Stephen Warren
On 9/7/20 3:52 AM, Edgar E. Iglesias wrote: > On Fri, Sep 04, 2020 at 12:43:57PM -0600, Stephen Warren wrote: >> On 9/4/20 3:07 AM, Edgar E. Iglesias wrote: >>> From: "Edgar E. Iglesias" >>> >>> PIE requires a 4K aligned load address. If this is n

Re: [PATCH v2 3/3] arm64: Add support for larger PIE U-boot

2020-09-04 Thread Stephen Warren
On 9/4/20 3:07 AM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Linking a U-boot larger than 1MB fails with PIE enabled: > u-boot/arch/arm/cpu/armv8/start.S:71:(.text+0x3c): relocation > truncated to fit: R_AARCH64_ADR_PREL_LO21 against symbol `__rel_dyn_end' > defined in .bss_start

Re: [PATCH v2 2/3] arm64: Bail out PIE builds early if load address is not 4K aligned

2020-09-04 Thread Stephen Warren
On 9/4/20 3:07 AM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > PIE requires a 4K aligned load address. If this is not met, trap > the startup sequence in a WFI loop rather than running into obscure > failures. > diff --git a/arch/arm/cpu/armv8/start.S b/arch/arm/cpu/armv8/start.S >

Re: [PATCH v2 1/3] arm64: Mention 4K aligned load addresses in the PIE Kconfig help

2020-09-04 Thread Stephen Warren
On 9/4/20 3:07 AM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Mention the requirement of 4K aligned load addresses in the > help section for the POSITION_INDEPENDENT option. > > Suggested-by: Michal Simek > Signed-off-by: Edgar E. Iglesias > --- > arch/arm/Kconfig | 3 +++ > 1

Re: [PATCH] ARM: Distro boot: document the need for fdtfile variable to be set

2020-09-03 Thread Stephen Warren
On 9/3/20 2:14 PM, Dennis Gilmore wrote: > On Thu, Sep 3, 2020 at 2:15 PM Stephen Warren wrote: >> >> On 9/3/20 10:40 AM, Dennis Gilmore wrote: >>> When testing builds provided in https://github.com/openwrt/openwrt/pull/3360 >>> I discovered that fdtfile was not

Re: [PATCH] ARM: Distro boot: document the need for fdtfile variable to be set

2020-09-03 Thread Stephen Warren
> > Cc: Atish Patra > Cc: Lukas Auer > Cc: Tom Rini > Cc: Masahiro Yamada > Cc: Vagrant Cascadian > Cc: Stephen Warren > Cc: Karsten Merker > --- > doc/README.distro | 8 > 1 file changed, 8 insertions(+) > > diff --git a/doc/README.dis

Re: [PATCH] arm64: Add support for bigger u-boot when CONFIG_POSITION_INDEPENDENT=y

2020-09-03 Thread Stephen Warren
On 9/3/20 1:07 PM, Edgar E. Iglesias wrote: > On Thu, Sep 03, 2020 at 09:45:39AM -0600, Stephen Warren wrote: >> On 9/3/20 7:40 AM, André Przywara wrote: >>> On 03/09/2020 14:35, Michal Simek wrote: >>>> >>>> >>>> On 02. 09. 20 18:34, Steph

Re: [PATCH] arm64: Add support for bigger u-boot when CONFIG_POSITION_INDEPENDENT=y

2020-09-03 Thread Stephen Warren
On 9/3/20 7:40 AM, André Przywara wrote: > On 03/09/2020 14:35, Michal Simek wrote: >> >> >> On 02. 09. 20 18:34, Stephen Warren wrote: >>> On 9/2/20 5:15 AM, Michal Simek wrote: >>>> From: "Edgar E. Iglesias" >>>> >&g

Re: [PATCH] travis-ci: Add SH4 r2dplus machine with various PCI ethernet options

2020-09-02 Thread Stephen Warren
On 8/5/20 3:26 PM, Marek Vasut wrote: > Add SH4 R2Dplus machine configured to test various U-Boot PCI ethernet > options -- RTL8139, EEPRO100, AMD PCnet, DEC Tulip. Sorry for the delay. I've applied this now.

Re: [PATCH] arm64: Add support for bigger u-boot when CONFIG_POSITION_INDEPENDENT=y

2020-09-02 Thread Stephen Warren
On 9/2/20 5:15 AM, Michal Simek wrote: > From: "Edgar E. Iglesias" > > When U-Boot binary exceeds 1MB with CONFIG_POSITION_INDEPENDENT=y > compilation error is shown: > /mnt/disk/u-boot/arch/arm/cpu/armv8/start.S:71:(.text+0x3c): relocation > truncated to fit: R_AARCH64_ADR_PREL_LO21 against

Re: [PATCH] travis-ci: Add SH4 r2dplus machine with various PCI ethernet options

2020-09-02 Thread Stephen Warren
On 9/2/20 9:42 AM, Tom Rini wrote: > On Tue, Aug 18, 2020 at 06:50:06PM +0200, Marek Vasut wrote: > >> On 8/5/20 11:26 PM, Marek Vasut wrote: >>> Add SH4 R2Dplus machine configured to test various U-Boot PCI ethernet >>> options -- RTL8139, EEPRO100, AMD PCnet, DEC Tulip. >>> >> >> Bump ? > >

Re: Chainloading U-Boot from Fastboot on Tegra30

2020-08-21 Thread Stephen Warren
Geis wrote: >>>>> >>>>> On Mon, Jul 6, 2020 at 1:04 PM Stephen Warren >>>>> wrote: >>>>>> >>>>>> On 7/3/20 6:32 AM, Peter Geis wrote: >>>>>>> Good Morning, >>>>>&

[PATCH] tests: support mkfs.ext4 without metadata_csum

2020-08-04 Thread Stephen Warren
From: Stephen Warren Modify various test/py filesystem creation routines to support systems that don't implement the metadata_csum ext4 feature. Signed-off-by: Stephen Warren --- test/py/tests/test_env.py | 5 - test/py/tests/test_fs/conftest.py | 6 -- 2 files changed, 8

Re: [PATCH v4 11/14] test: environment in ext4

2020-08-03 Thread Stephen Warren
On 8/3/20 9:51 AM, Tom Rini wrote: > On Mon, Aug 03, 2020 at 09:43:18AM -0600, Stephen Warren wrote: >> On 7/28/20 3:51 AM, Patrick Delaunay wrote: >>> Add basic test to persistent environment in ext4: >>> save and load in host ext4 file 'uboot.env'. >>> >&

Re: [PATCH v4 11/14] test: environment in ext4

2020-08-03 Thread Stephen Warren
On 7/28/20 3:51 AM, Patrick Delaunay wrote: > Add basic test to persistent environment in ext4: > save and load in host ext4 file 'uboot.env'. > > On first execution an empty EXT4 file system is created in > persistent data dir: env.ext4.img. > diff --git a/test/py/tests/test_env.py

[PATCH] fixdep: fix coding style in previous fix

2020-07-21 Thread Stephen Warren
From: Stephen Warren Remove a double space introduced by my previous fixdep fix. Fixes: 76ae74d348a0 ("fixdep: fix CONFIG_IS_ENABLED etc. handling") Signed-off-by: Stephen Warren --- scripts/basic/fixdep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scr

Re: uboot-test-hooks: dfu-util

2020-07-16 Thread Stephen Warren
On 7/15/20 12:14 PM, Heinrich Schuchardt wrote: > On 15.07.20 19:38, Heinrich Schuchardt wrote: >> On 15.07.20 17:57, Stephen Warren wrote: >>> On 7/15/20 4:34 AM, Heinrich Schuchardt wrote: >>>> Hello Stephen, >>>> >>>> I have just looked int

Re: uboot-test-hooks: dfu-util

2020-07-15 Thread Stephen Warren
On 7/15/20 4:34 AM, Heinrich Schuchardt wrote: > Hello Stephen, > > I have just looked into dfu testing. > > Do we still need a custom dfu-util? At least the dfu-util provided by > Ubuntu bionic/universe in our Docker image provides the -p parameter. Yes, it looks like the -p option is

Re: [v2] test: Have test_fs work with non-functional guestmount tools

2020-07-09 Thread Stephen Warren
to use sudo. Restructure our code to try > sudo if guestmount fails rather than only when it is not in our path. > Further, only note that we are using fuse on success of the call. > > [1]: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/759725 Reviewed-by: Stephen Warren

[PATCH] fixdep: fix CONFIG_IS_ENABLED etc. handling

2020-07-08 Thread Stephen Warren
From: Stephen Warren When fixdep detects CONFIG_IS_ENABLED and other similar macros, it must parse the macro parameter to determine which actual CONFIG_ option is being referenced. This involves moving a pointer forward through the entire CONFIG_ option "word". Currently, the code use

Re: test/py GPIO failure in u-boot/master

2020-07-08 Thread Stephen Warren
On 7/8/20 2:24 PM, Stephen Warren wrote: > On 7/8/20 10:06 AM, Tom Rini wrote: >> On Wed, Jul 08, 2020 at 09:50:06AM -0600, Stephen Warren wrote: >>> Latest u-boot/master is failing a couple test/py test_ut tests for GPIO: >>> >>>> => ut dm gpio >&g

Re: test/py GPIO failure in u-boot/master

2020-07-08 Thread Stephen Warren
On 7/8/20 10:06 AM, Tom Rini wrote: > On Wed, Jul 08, 2020 at 09:50:06AM -0600, Stephen Warren wrote: >> Latest u-boot/master is failing a couple test/py test_ut tests for GPIO: >> >>> => ut dm gpio >>> Test: dm_test_gpio: gpio.c >>> extra-gpios: get_va

test/py GPIO failure in u-boot/master

2020-07-08 Thread Stephen Warren
Latest u-boot/master is failing a couple test/py test_ut tests for GPIO: > => ut dm gpio > Test: dm_test_gpio: gpio.c > extra-gpios: get_value: error: gpio b5 not reserved > /var/lib/jenkins/workspace/u-boot-denx_uboot-master-build/src/u-boot/test/dm/gpio.c:137, > dm_test_gpio (): 0 ==

Re: [PATCH] test: Have test_fs work with non-functional guestmount tools

2020-07-07 Thread Stephen Warren
On 7/7/20 12:46 PM, Tom Rini wrote: > On Tue, Jul 07, 2020 at 12:34:19PM -0600, Stephen Warren wrote: >> On 7/7/20 9:53 AM, Tom Rini wrote: >>> Since 2011 Ubuntu has intentionally broken support for guestmount[1] by >>> default and requires sysadmin interv

Re: [PATCH] test: Have test_fs work with non-functional guestmount tools

2020-07-07 Thread Stephen Warren
On 7/7/20 9:53 AM, Tom Rini wrote: > Since 2011 Ubuntu has intentionally broken support for guestmount[1] by > default and requires sysadmin intervention to re-enable support. This > in turn exposed that in our tests if guestmount is available but fails > we do not fall back to trying to use

Re: [PATCH v3 14/14] test: sandbox: add test for erase command

2020-07-06 Thread Stephen Warren
On 6/25/20 1:59 AM, Patrick Delaunay wrote: > Add test for the erase command tested on ENV in EXT4. Acked-by: Stephen Warren

Re: [PATCH v3 11/14] test: environment in ext4

2020-07-06 Thread Stephen Warren
On 6/25/20 1:59 AM, Patrick Delaunay wrote: > Add basic test to persistent environment in ext4: > save and load in host ext4 file 'uboot.env'. > > On first execution an empty EXT4 file system is created in > persistent data dir: env.ext4.img. Acked-by: Stephen Warren A couple n

Re: Chainloading U-Boot from Fastboot on Tegra30

2020-07-06 Thread Stephen Warren
On 7/3/20 6:32 AM, Peter Geis wrote: > Good Morning, > > I am attempting to expand on the work for chainloading U-Boot on the > nyan-big in order to chainload U-Boot on the Ouya Tegra30 device from > fastboot. > I have so far been unsuccessful at getting any output from U-Boot > through this

Re: [PATCH v2 1/1] travis-ci: Fix "ResourceWarning: unclosed file"

2020-06-24 Thread Stephen Warren
On 12/30/19 9:41 AM, Stephen Warren wrote: > On 12/30/19 4:49 AM, Cristian Ciocaltea wrote: >> This patch gets rid of the warning messages like: >> >> uboot-test-hooks/py/travis-ci/travis_tftp.py:43: ResourceWarning: >> unclosed file <_io.BufferedReader name

Re: [RESEND PATCH v5 4/4] test: env: add test for env info sub-command

2020-06-23 Thread Stephen Warren
On 6/23/20 7:25 AM, Patrick DELAUNAY wrote: > Hi Stephen, > >> From: Stephen Warren >> Sent: lundi 22 juin 2020 20:51 >> >> On 6/19/20 6:03 AM, Patrick Delaunay wrote: >>> Add a pytest for testing the env info sub-command: >>> >>>

Re: [PATCH] travis-ci: Update QEMU RISC-V run command

2020-06-23 Thread Stephen Warren
On 6/23/20 6:34 AM, Bin Meng wrote: > From: Bin Meng > > Explicitly pass the "-bios" option to QEMU to run U-Boot, instead > of the "-kernel" option, as we know that "-bios" behavior will be > changed since QEMU 5.1.0. Applied, thanks.

Re: [PATCH] travis-ci: Update QEMU RISC-V run command

2020-06-23 Thread Stephen Warren
On 6/23/20 7:24 AM, Bin Meng wrote: > Hi Tom, > > On Tue, Jun 23, 2020 at 9:17 PM Tom Rini wrote: >> >> On Tue, Jun 23, 2020 at 05:34:34AM -0700, Bin Meng wrote: >> >>> From: Bin Meng >>> >>> Explicitly pass the "-bios" option to QEMU to run U-Boot, instead >>> of the "-kernel" option, as we

Re: [PATCH 2/2] ARM: tegra: Enable PSCI support for Tegra210 and Tegra186

2020-06-22 Thread Stephen Warren
On 6/18/20 5:54 AM, Jon Hunter wrote: > The PSCI nodes are currently not populated for the Tegra210 and Tegra186 > devices. This prevents the PSCI driver from being able to identify the > PSCI method used by these devices and causes the probe of the PSCI > driver to fail. > > Since commit

Re: [PATCH v2 9/9] test: sandbox: add test for erase command

2020-06-22 Thread Stephen Warren
On 6/16/20 1:40 AM, Patrick Delaunay wrote: > Add test for the erase command tested on ENV in EXT4. Acked-by: Stephen Warren

Re: [PATCH v2 6/9] test: environment in ext4

2020-06-22 Thread Stephen Warren
On 6/16/20 1:40 AM, Patrick Delaunay wrote: > Add basic test to persistent environment in ext4: > save and load in host ext4 file 'uboot.env'. > > On first execution an empty EXT4 file system is created in > persistent data dir: env.ext4.img. > diff --git a/test/py/tests/test_env.py

Re: [RESEND PATCH v5 4/4] test: env: add test for env info sub-command

2020-06-22 Thread Stephen Warren
> with a known ENV configuration: ready & default & persistent > > The quiet option '-q' is used for support in shell test; > for example: > if env info -p -d -q; then env save; fi Acked-by: Stephen Warren > +def test_env_info(state_test_env): ... > +for l in response

Re: [PATCH v3] common: fdt: Remove additional 4k space for fdt allocation

2020-06-22 Thread Stephen Warren
e copying FDT to different locations by > image_setup_libfdt(). > That's why in proper flow none should modified DTB used by U-Boot that's > why there is no need for additional space. Acked-by: Stephen Warren

Re: [PATCH 1/1] gitlab: show skipped Python tests

2020-06-22 Thread Stephen Warren
On 6/22/20 10:07 AM, Heinrich Schuchardt wrote: > Call pytest3 with argument -ra to display reason why Python tests are > skipped. Acked-by: Stephen Warren

Re: [PATCH] test_sleep.py: make sleep time and margin configurable

2020-06-17 Thread Stephen Warren
On 6/16/20 9:11 PM, Simon Glass wrote: > Hi Stephen, > > On Mon, 8 Jun 2020 at 11:25, Stephen Warren wrote: >> >> On 6/8/20 11:12 AM, Simon Glass wrote: >>> Hi Stephen, >>> >>> On Mon, 8 Jun 2020 at 10:43, Stephen Warren wrote: >>>> &g

Re: [PATCH v2 29/49] tegra: Drop the unused non-binman code

2020-06-17 Thread Stephen Warren
On 6/16/20 7:44 AM, Simon Glass wrote: > Hi Stephen, > > On Mon, 15 Jun 2020 at 16:03, Stephen Warren wrote: >> >> On 6/13/20 8:57 PM, Simon Glass wrote: >>> This has been in the Makefile long enough to ensure migration is complete. >>> Drop it.

Re: [PATCH v4 4/4] test: env: add test for env info sub-command

2020-06-17 Thread Stephen Warren
On 6/16/20 2:01 AM, Patrick DELAUNAY wrote: > Hi Stephen, > >> From: Stephen Warren >> Sent: mardi 16 juin 2020 00:09 >> >> On 6/15/20 8:01 AM, Patrick Delaunay wrote: >>> Add a pytest for testing the env info sub-command: >>> >

Re: [PATCH v4 4/4] test: env: add test for env info sub-command

2020-06-15 Thread Stephen Warren
On 6/15/20 8:01 AM, Patrick Delaunay wrote: > Add a pytest for testing the env info sub-command: > > test_env_info: test command with several option > > test_env_info_quiet: test the result of the sub-command with quiet option, > '-q' as used for support in shell test; for example: > if env

Re: [PATCH v2 29/49] tegra: Drop the unused non-binman code

2020-06-15 Thread Stephen Warren
On 6/13/20 8:57 PM, Simon Glass wrote: > This has been in the Makefile long enough to ensure migration is complete. > Drop it. > diff --git a/Makefile b/Makefile > -OBJCOPYFLAGS_u-boot-nodtb-tegra.bin = -O binary > --pad-to=$(CONFIG_SYS_TEXT_BASE) > -u-boot-nodtb-tegra.bin: spl/u-boot-spl

Re: [PATCH v2] common: fdt: Remove additional 4k space for fdt allocation

2020-06-12 Thread Stephen Warren
On 6/12/20 4:56 PM, Heinrich Schuchardt wrote: > On 6/12/20 9:28 PM, Stephen Warren wrote: >> On 6/11/20 5:10 AM, Michal Simek wrote: >>> From: Ashok Reddy Soma >>> >>> There is no technical reason to add additional 4k space for FDT. This space >>>

Re: [PATCH v2] common: fdt: Remove additional 4k space for fdt allocation

2020-06-12 Thread Stephen Warren
On 6/11/20 5:10 AM, Michal Simek wrote: > From: Ashok Reddy Soma > > There is no technical reason to add additional 4k space for FDT. This space > is completely unused and just increase memory requirements. This is > problematic on systems with limited memory resources as Xilinx Zynq >

Re: [PATCH v2] common: fdt: Remove additional 4k space for fdt allocation

2020-06-12 Thread Stephen Warren
On 6/11/20 5:10 AM, Michal Simek wrote: > From: Ashok Reddy Soma > > There is no technical reason to add additional 4k space for FDT. This space > is completely unused and just increase memory requirements. This is > problematic on systems with limited memory resources as Xilinx Zynq >

Re: [PATCH] test_sleep.py: make sleep time and margin configurable

2020-06-08 Thread Stephen Warren
On 6/8/20 11:12 AM, Simon Glass wrote: > Hi Stephen, > > On Mon, 8 Jun 2020 at 10:43, Stephen Warren wrote: >> >> On 6/7/20 7:45 AM, Simon Glass wrote: >>> On Thu, 4 Jun 2020 at 09:24, Heiko Schocher wrote: >>>> >>>> make the sleep

Re: [PATCH] test_sleep.py: make sleep time and margin configurable

2020-06-08 Thread Stephen Warren
On 6/4/20 9:24 AM, Heiko Schocher wrote: > make the sleep time and the margin configurable. Reviewed-by: Stephen Warren

Re: [PATCH] test_sleep.py: make sleep time and margin configurable

2020-06-08 Thread Stephen Warren
On 6/7/20 7:45 AM, Simon Glass wrote: > On Thu, 4 Jun 2020 at 09:24, Heiko Schocher wrote: >> >> make the sleep time and the margin configurable. >> >> Signed-off-by: Heiko Schocher >> --- >> >> travis build: >> https://travis-ci.org/github/hsdenx/u-boot-test/builds/694545225 >> >> This patch is

Re: [PATCH 1/1] test/py: use actual core count for parallel builds

2020-05-31 Thread Stephen Warren
On 5/30/20 4:44 PM, Heinrich Schuchardt wrote: > When building U-Boot we should not blindly use make -j8 but consider the > actual core count given by os.cpu_count(). Acked-by: Stephen Warren

Re: Setting up test.py for a platform with 2 U-Boots?

2020-05-07 Thread Stephen Warren
On 5/7/20 12:48 PM, Tom Rini wrote: > Hey, > > So I'm trying to enable our test.py framework on am65x_evm_r5 + > am65x_evm_a53. The short version is this platform has an R5 core that > sets things up and fires off the A53 cores. So there's two U-Boots and > the console log looks like this (I

Re: [PATCH 1/2] test: describe naming conventions for macro UNIT_TEST

2020-05-06 Thread Stephen Warren
static int UNIT_TEST_FUNC(log, nolog_err)(struct unit_test_state *uts) But certainly this series is a good first step, and fine even if we don't implement this suggestion. The series, Reviewed-by: Stephen Warren

Re: [PATCH 8/8] net: gmac_rockchip: Add dwc_eth_qos support

2020-04-30 Thread Stephen Warren
On 4/30/20 4:45 AM, David Wu wrote: > Change the original data structure so that Rockchip's Soc > gmac controller can support the designware.c and dwc_eth_qos.c > drivers, a Soc can only support one. I'm really confused; with a filename like gmac_rockchip.c that sounds like it's driver for a MAC

Re: [PATCH 7/8] net: dwc_eth_qos: Export common struct and interface at head file

2020-04-30 Thread Stephen Warren
On 4/30/20 4:45 AM, David Wu wrote: > Open structure data and interface, so that Soc using dw_eth_qos > controller can reference. This shouldn't be necessary; nothing outside of this driver should need access to the registers. At most, perhaps implement some additional functions so that other

Re: [PATCH 5/8] net: dwc_eth_qos: Make clk_rx and clk_tx optional

2020-04-30 Thread Stephen Warren
On 4/30/20 4:43 AM, David Wu wrote: > For others using, clk_rx and clk_tx may not be necessary, > and their clock names are different. > diff --git a/drivers/net/dwc_eth_qos.c b/drivers/net/dwc_eth_qos.c > @@ -1691,20 +1699,16 @@ static int eqos_probe_resources_stm32(struct udevice > *dev) >

Re: [PATCH 3/8] net: dwc_eth_qos: Add option "snps, reset-gpio" phy-rst gpio for stm32

2020-04-30 Thread Stephen Warren
On 4/30/20 4:36 PM, Stephen Warren wrote: > On 4/30/20 4:36 AM, David Wu wrote: >> It can be seen that most of the Socs using STM mac, "snps,reset-gpio" >> gpio is used, adding this option makes reset function more general. > >> diff --git a/drivers/net/dwc_eth

Re: [PATCH 4/8] net: dwc_eth_qos: Move interface() to eqos_ops struct

2020-04-30 Thread Stephen Warren
On 4/30/20 4:36 AM, David Wu wrote: > After moving to eqos_ops, if eqos_config is defined > outside, can not export interface() definition. Looking at the patch itself, I think this patch just moves a function pointer from the config to the ops structure which makes sense. However, I can't

Re: [PATCH 3/8] net: dwc_eth_qos: Add option "snps, reset-gpio" phy-rst gpio for stm32

2020-04-30 Thread Stephen Warren
On 4/30/20 4:36 AM, David Wu wrote: > It can be seen that most of the Socs using STM mac, "snps,reset-gpio" > gpio is used, adding this option makes reset function more general. > diff --git a/drivers/net/dwc_eth_qos.c b/drivers/net/dwc_eth_qos.c > @@ -1712,11 +1724,29 @@ static int

Re: [PATCH 2/8] net: dwc_eth_qos: Fix the software reset

2020-04-30 Thread Stephen Warren
On 4/30/20 4:36 AM, David Wu wrote: > When using rgmii Gigabit mode, the wait_for_bit_le32() > reset method resulting in RX can not receive data, after > this patch, works well. > diff --git a/drivers/net/dwc_eth_qos.c b/drivers/net/dwc_eth_qos.c > + limit = eqos->config->swr_wait / 10; > +

Re: [PATCH] net: dwc_eth_qos: Pad descriptors to cacheline size

2020-04-29 Thread Stephen Warren
On 4/29/20 3:41 PM, Marek Vasut wrote: > On 4/29/20 11:25 PM, Stephen Warren wrote: >> On 4/29/20 1:56 PM, Marek Vasut wrote: >>> On 4/29/20 9:51 PM, Stephen Warren wrote: >>>> On 4/29/20 1:14 PM, Marek Vasut wrote: >>>>> The DWMAC4 IP has the

Re: [PATCH] net: dwc_eth_qos: Pad descriptors to cacheline size

2020-04-29 Thread Stephen Warren
On 4/29/20 1:56 PM, Marek Vasut wrote: > On 4/29/20 9:51 PM, Stephen Warren wrote: >> On 4/29/20 1:14 PM, Marek Vasut wrote: >>> The DWMAC4 IP has the possibility to skip up to 7 64bit words after >>> the descriptor, use this to pad the descriptors to cacheline size.

Re: [PATCH] net: dwc_eth_qos: Pad descriptors to cacheline size

2020-04-29 Thread Stephen Warren
On 4/29/20 1:14 PM, Marek Vasut wrote: > The DWMAC4 IP has the possibility to skip up to 7 64bit words after > the descriptor, use this to pad the descriptors to cacheline size. > diff --git a/drivers/net/dwc_eth_qos.c b/drivers/net/dwc_eth_qos.c > /* Descriptors */ > +/* Nit: Blank line

Re: Build error in u-boot-dm/master

2020-04-27 Thread Stephen Warren
On 4/27/20 11:02 AM, Simon Glass wrote: > Hi Stephen, > > On Mon, 27 Apr 2020 at 10:04, Stephen Warren wrote: >> >> Simon, >> >> All 32-bit Tegra builds of u-boot-dm/master are failing with the >> following (this log is from Harmony): >> >>>

Build error in u-boot-dm/master

2020-04-27 Thread Stephen Warren
Simon, All 32-bit Tegra builds of u-boot-dm/master are failing with the following (this log is from Harmony): > CC spl/common/spl/spl.o > CC spl/lib/display_options.o > LD spl/common/spl/built-in.o > LD spl/lib/built-in.o > LD spl/u-boot-spl > OBJCOPY

Re: [PATCH] test: use correct path in file system tests

2020-04-21 Thread Stephen Warren
On 4/21/20 4:41 AM, Heinrich Schuchardt wrote: > For non-root users mkfs.ext4 and fsck.ext4 are not in the search path at > least on Debian. Use /sbin/mkfs.ext4 and /sbin/fsck.ext4 instead. Why not just set $PATH correctly before running the tests? This change prevents the code from finding mkfs

Re: [PATCH 1/1] test: test_fs error message

2020-04-20 Thread Stephen Warren
On 4/20/20 12:48 PM, Heinrich Schuchardt wrote: > For non-root users mkfs.vfat is not in the search path at least on Debian. > Hence when running 'make tests' a message indicates that file system tests > have been skipped: > > SKIPPED [13] test/py/tests/test_fs/conftest.py:340: Setup failed for >

Re: [PATCH] common: Add Kconfig option for FDT mem alignment

2020-04-16 Thread Stephen Warren
On 4/16/20 11:06 AM, Tom Rini wrote: > On Thu, Apr 16, 2020 at 05:47:41PM +0200, Michal Simek wrote: >> On 16. 04. 20 17:39, Tom Rini wrote: >>> On Mon, Apr 13, 2020 at 10:03:04AM +0200, Michal Simek wrote: >>> From: Ashok Reddy Soma FDT memory is aligned by 4KB. This is hardcoded

Re: [PATCH 2/2] arm: tegra: add options for BOOTENV_EFI_SET_FDTFILE_FALLBACK for tegra186

2020-04-02 Thread Stephen Warren
On 4/1/20 5:28 PM, Peter Robinson wrote: > Upstream linux DT naming doesn't align with the U-Boot DT, which may > not always be the case so this allows using BOOTENV_EFI_SET_FDTFILE_FALLBACK > where it might be appropriate for some boards. > > Signed-off-by: Peter Robinson > --- > > This is a

Re: [PATCH] ARM: tegra: Add NVIDIA Jetson Nano Developer Kit support

2020-04-01 Thread Stephen Warren
On 4/1/20 4:57 PM, Tom Warren wrote: > Peter Robinson wrote at Wednesday, April 1, 2020 3:31 PM: >> diff --git a/configs/p3450-_defconfig b/configs/p3450-_defconfig > Should it also have the following that was added for the other > tegra210 Jetson that you sent through with one of hte

Re: [PATCH 1/3] travis-ci: Add EFI grub2 and fit image configuration for qemu-riscv64

2020-03-26 Thread Stephen Warren
On 3/26/20 10:05 AM, Bin Meng wrote: > This adds EFI grub2 and fit image configuration for qemu-riscv64 > target used for test. I've applied the series.

Re: [PATCH] test/py: mmc: Fix 'mmc info' testcase

2020-03-26 Thread Stephen Warren
On 3/26/20 11:07 AM, Harald Seiler wrote: > Commit 41e30dcf8796 ("cmd: mmc: Make Mode: printout consistent") fixed > the layout of `mmc info` output. Reflect this change in the respective > testcase. > > Also fix a typo in the documentation. Acked-by: Stephen Warr

Re: [PATCH] fs: ext4: Fix alignment of cache buffers

2020-03-25 Thread Stephen Warren
d5aee659f217 ("fs: ext4: cache extent data") > Signed-off-by: Jan Kiszka Reviewed-by: Stephen Warren It's probably just a fluke that this happens to show up on some SoCs/boards/configurations but not others. Or perhaps the MINALIGN value differs?

Re: ext4: invalid extent block on imx7

2020-03-25 Thread Stephen Warren
On 3/25/20 1:11 PM, Jan Kiszka wrote: > On 25.03.20 16:00, Tom Rini wrote: >> On Wed, Mar 25, 2020 at 07:32:30AM +0100, Jan Kiszka wrote: >>> On 20.03.20 19:21, Tom Rini wrote: On Mon, Mar 16, 2020 at 08:09:53PM +0100, Jan Kiszka wrote: > Hi all, > > => ls mmc 0:1

Re: [PATCH] ARM: tegra: Add NVIDIA Jetson Nano Developer Kit support

2020-03-25 Thread Stephen Warren
On 3/24/20 1:03 PM, twar...@nvidia.com wrote: > From: Tom Warren > > The Jetson Nano Developer Kit is a Tegra X1-based development board. It > is similar to Jetson TX1 but it is not pin compatible. It features 4GB > of LPDDR4, a SPI NOR flash for early boot firmware and an SD card slot > used

Re: [PATCH 1/6] net: dwc_eth_qos: Fully rewrite RX descriptor field 3

2020-03-23 Thread Stephen Warren
nly modified and the aforementioned two bits are ORRed > into the field. This could lead to a residual dirty bits being left in > the field 3 from previous transfer, and it generally does. Fully set the > field 3 instead to clear those residual dirty bits. The series, Tested-by: Stephen Warr

Re: [PATCH 2/2] tegra: Enable CONFIG_BOOTP_PREFER_SERVERIP for all boards

2020-03-18 Thread Stephen Warren
On 3/18/20 5:52 PM, Tom Warren wrote: > -Original Message- > From: Stephen Warren > Sent: Wednesday, March 18, 2020 4:31 PM > To: Tom Warren > Cc: u-boot@lists.denx.de; Stephen Warren ; Thierry Reding > ; Jonathan Hunter ; > tomcwarren3...@gmail.com > Subjec

Re: [PATCH 2/2] tegra: Enable CONFIG_BOOTP_PREFER_SERVERIP for all boards

2020-03-18 Thread Stephen Warren
On 3/17/20 2:07 PM, twar...@nvidia.com wrote: > From: Tom Warren > > This allows the user to set $serverip in the environment before > executing a DHCP request. If they do, U-Boot will use that IP rather > than using the IP in the DHCP response. Acked-by: Stephen Wa

Re: [PATCH 1/2] net: rt8169: WAR for DHCP not getting IP after kernel boot/reboot

2020-03-18 Thread Stephen Warren
On 3/17/20 2:07 PM, twar...@nvidia.com wrote: > From: Tom Warren > > This is a WAR for DHCP failure after rebooting from the L4T kernel. The > r8169.c kernel driver is setting bit 19 of the rt816x HW register 0xF0, > which goes by FuncEvent and MISC in various driver source/datasheets. > That

Re: [PATCH 2/5] t210: do not enable PLLE and UPHY PLL HW PWRSEQ

2020-03-18 Thread Stephen Warren
e OK in practice too. Acked-by: Stephen Warren > Thanks, > JC > > On 3/18/20 1:44 AM, Tom Warren wrote: >> -----Original Message- >> From: Stephen Warren >> Sent: Tuesday, March 17, 2020 10:30 AM >> To: Tom Warren >> Cc: u-boot@lists.denx.de; Jui

  1   2   3   4   5   6   7   8   9   10   >