[Bug 1317491] Re: virsh blockcommit hangs at 100%

Thank you Robie. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1317491 Title: virsh blockcommit hangs at 100% To manage notifications about this bug go to:

[Bug 1317491] Re: virsh blockcommit hangs at 100%

This bug was fixed in the package libvirt - 1.2.2-0ubuntu13.1.20 --- libvirt (1.2.2-0ubuntu13.1.20) trusty; urgency=medium [ Rafael David Tinoco ] * d/p/reject-blockcommit-of-active-layer.patch: Block commit code isn't ready for QEMU 2.0 and has to be blocked. This avoids

[Bug 1317491] Re: virsh blockcommit hangs at 100%

20:54 For SRU, LP #1317491 has landed in -proposed on "2017-02-22" and has been tag "verification done" the following day "2017-02-23", and the package is languishing in -proposed since then "libvirt | 1.2.2-0ubuntu13.1.20 | trusty-proposed". Could someone please have a look this bug and let

[Bug 1317491] Re: virsh blockcommit hangs at 100%

I've verified the diff between 1.17 and 1.20 fixes this bug only, and the verification in this bug looks good (and very comprehensive - thank you), so I conclude that this is fine to release. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to

[Bug 1317491] Re: virsh blockcommit hangs at 100%

This case is long time waiting for SRU being published. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1317491 Title: virsh blockcommit hangs at 100% To manage notifications about this bug go to:

[Bug 1317491] Re: virsh blockcommit hangs at 100%

** Tags removed: sts-sru -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1317491 Title: virsh blockcommit hangs at 100% To manage notifications about this bug go to:

[Bug 1317491] Re: virsh blockcommit hangs at 100%

Unsubscribing sponsors since everybody else forgot. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1317491 Title: virsh blockcommit hangs at 100% To manage notifications about this bug go to:

[Bug 1317491] Re: virsh blockcommit hangs at 100%

** No longer affects: libvirt (Ubuntu Xenial) ** No longer affects: libvirt (Ubuntu Yakkety) ** No longer affects: libvirt (Ubuntu Zesty) ** Changed in: libvirt (Ubuntu) Importance: Undecided => Medium -- You received this bug notification because you are a member of Ubuntu Bugs, which is

[Bug 1317491] Re: virsh blockcommit hangs at 100%

** Description changed: [Impact]  * Virsh can't merge snapshots using the Block Commit technique  * It is only possible to merge base to top image (not the opposite)  * Combination of libvirt v1.2.2 and QEMU 2 is no good for Block Commit  * After this fix, virsh won't hang on the

[Bug 1317491] Re: virsh blockcommit hangs at 100%

# Testing with more snapshots inaddy@(kvm02):~$ sudo qemu-img info --backing-chain /var/lib/libvirt/images/guest.1487879587 image: /var/lib/libvirt/images/guest.1487879587 file format: qcow2 virtual size: 30G (32212254720 bytes) disk size: 3.0M cluster_size: 65536 backing file:

[Bug 1317491] Re: virsh blockcommit hangs at 100%

# Testing Bigger Merge inaddy@(kvm02):~$ sudo qemu-img info --backing-chain /var/lib/libvirt/images/guest.1487880011 image: /var/lib/libvirt/images/guest.1487880011 file format: qcow2 virtual size: 30G (32212254720 bytes) disk size: 196K cluster_size: 65536 backing file:

[Bug 1317491] Re: virsh blockcommit hangs at 100%

Finishing Verification with @cpaelzer questions: I like your tests in #12 and #18, but can you think and compare several permutations of commits to non-active layers? Those should have worked before as far as I read the comments. What would that be base->s1->s2->s3 and then committing s3 to s2 ?

[Bug 1317491] Re: virsh blockcommit hangs at 100%

# Testing to merge into (both are offline): inaddy@(kvm02):~$ virsh blockcommit --domain guest --path=/var/lib/libvirt/images/guest.1487875788 --top=/var/lib/librt/images/guest.1487745012 --base=/var/lib/libvirt/images/guest.qcow2 --wait --verbose Block Commit: [100 %] Commit complete It

[Bug 1317491] Re: virsh blockcommit hangs at 100%

# Creating a new snapshot: inaddy@(kvm02):~$ virsh snapshot-create-as --domain guest --disk-only --atomic Domain snapshot 1487875788 created inaddy@(kvm02):~$ virsh domblklist --domain guest Target Source vda

[Bug 1317491] Re: virsh blockcommit hangs at 100%

# # VERIFICATION # inaddy@(kvm02):~$ dpkg -l | grep libvirt | awk '{print $2"\t"$3}' libvirt-bin 1.2.2-0ubuntu13.1.20 libvirt01.2.2-0ubuntu13.1.20 inaddy@(kvm02):~$ : virsh domblklist --domain guest Target Source vda

[Bug 1317491] Re: virsh blockcommit hangs at 100%

All my usual regression Tests completed on the proposed version 1.2.2-0ubuntu13.1.20. Attaching the logs for later reference. @Tinoco - when you completed all extra steps that I asked for and things are good there as well, feel free to mark as verification-done. ** Attachment added: "collection

[Bug 1317491] Re: virsh blockcommit hangs at 100%

Answers to @cpaelzer: >> Not so important but FYI your link in the description is broken - it leads me to some weird catching site, not really an emulatortalk.info with some content. - Fixed >> I like your tests in #12 and #18, but can you think and compare several >> permutations of commits

[Bug 1317491] Re: virsh blockcommit hangs at 100%

Hello Stefan, or anyone else affected, Accepted libvirt into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libvirt/1.2.2-0ubuntu13.1.20 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See

[Bug 1317491] Re: virsh blockcommit hangs at 100%

I accepted the package to the -proposed pocket. The .20 version seems ok, I also don't mind the removal of the changelog entries as those never really existed in the main archives (it would only introduce unwanted noise). But good thing that you mentioned the issues with .18 and .19 existing as

[Bug 1317491] Re: virsh blockcommit hangs at 100%

There was a short "WTF" moment as it seems https://launchpad.net/ubuntu/+source/libvirt/1.2.2-0ubuntu13.1.18 existed. But it was only in proposed and got removed from there by inactivity to test the case. There is also https://launchpad.net/ubuntu/+source/libvirt/1.2.2-0ubuntu13.1.19 which

[Bug 1317491] Re: virsh blockcommit hangs at 100%

Hi Rafael, Not so important but FYI your link in the description is broken - it leads me to some weird catching site, not really an emulatortalk.info with some content. I like your tests in #12 and #18, but can you think and compare several permutations of commits to non-active layers? Those

[Bug 1317491] Re: virsh blockcommit hangs at 100%

inaddy@(kvm02):~$ virsh start guest inaddy@(kvm02):~$ virsh snapshot-create-as --domain guest --disk-only --atomic Domain snapshot 1487745012 created inaddy@(kvm02):~$ virsh domblklist --domain guest inaddy@(kvm02):~$ virsh domblklist --domain guest Target Source

[Bug 1317491] Re: virsh blockcommit hangs at 100%

** Patch added: "trusty_libvirt_1.2.2-0ubuntu13.1.18.debdiff" https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1317491/+attachment/4824090/+files/trusty_libvirt_1.2.2-0ubuntu13.1.18.debdiff ** Description changed: + [Impact] + + * Virsh can't merge snapshots using the Block Commit

[Bug 1317491] Re: virsh blockcommit hangs at 100%

@cpaelzer, could u please review ? I think its all covered for the SRU. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1317491 Title: virsh blockcommit hangs at 100% To manage notifications about

[Bug 1317491] Re: virsh blockcommit hangs at 100%

-- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1317491 Title: virsh blockcommit hangs at 100% To manage notifications about this bug go to:

[Bug 1317491] Re: virsh blockcommit hangs at 100%

For the fix to be cherry-picked cleanly I would need several patches: commit 4f20226664b2d4d9e9496ec1e05c9280581a1ca0 Author: Eric Blake Date: Wed Mar 19 11:11:16 2014 -0600 conf: prepare to track multiple host source files per commit

[Bug 1317491] Re: virsh blockcommit hangs at 100%

I have read libvirt code, specifically: tools/virsh-domain.c src/libvirt-domain.c src/qemu_driver.c In the execution path of the block commit logic: vshcommandrun() -> cmdblockcommit() -> virtdomainblockcommit() -> domain->driver(qemu)->domainblockcommit() -> qemudomainblockcommit() As

[Bug 1317491] Re: virsh blockcommit hangs at 100%

This upstream explains what I discovered in previous comments: commit e6bcbcd32c70ae394e7b6a530012fe8b07a59b5d Author: Eric Blake Date: Tue May 27 17:07:08 2014 -0600 qemu: reject rather than hang on blockcommit of active layer qemu 2.0 added the ability to commit

[Bug 1317491] Re: virsh blockcommit hangs at 100%

Somehow libvirt (virsh) is not checking the block-job execution: inaddy@(kvm02):~$ virsh qemu-monitor-command guest --pretty -- '{ "execute": "query-block-jobs" }' { "return": [ { "io-status": "ok", "device": "drive-virtio-disk0", "busy": false,

[Bug 1317491] Re: virsh blockcommit hangs at 100%

I was able to successfully Block Commit using QEMU in Trusty. So the problem lives likely in libvirt: QEMU (2.0.0+dfsg-2ubuntu1.32) ## HMP CONSOLE # create a snapshot from "guest.qcow2" to "guestsnap.qcow2" (qemu) snapshot_blkdev disk0 /var/lib/libvirt/images/guestsnap.qcow2 qcow2 ## QMP

[Bug 1317491] Re: virsh blockcommit hangs at 100%

I was able to block commit using libvirt, finally. Found the problem: inaddy@(kvm02):~$ virsh snapshot-create-as --domain guest --disk-only --atomic Domain snapshot 1487158333 created Formatting '/var/lib/libvirt/images/guest.1487158333', fmt=qcow2 size=32212254720

[Bug 1317491] Re: virsh blockcommit hangs at 100%

For the Live Snapshot merge you can either rely on: - Block Streaming or - Block Commit (Check: http://wiki.qemu-project.org/Features/Snapshots for more info) WORKAROUND is to use Block Streaming: (1) Virtual machine uses its qcow2 image disk: inaddy@(kvm01):~$ sudo ls

[Bug 1317491] Re: virsh blockcommit hangs at 100%

** Also affects: libvirt (Ubuntu Trusty) Importance: Undecided Status: New ** Also affects: libvirt (Ubuntu Xenial) Importance: Undecided Status: New ** Also affects: libvirt (Ubuntu Yakkety) Importance: Undecided Status: New ** Also affects: libvirt (Ubuntu Zesty)

[Bug 1317491] Re: virsh blockcommit hangs at 100%

** Changed in: libvirt (Ubuntu Zesty) Importance: Medium => Undecided ** Changed in: libvirt (Ubuntu Zesty) Status: Confirmed => Fix Released ** Changed in: libvirt (Ubuntu Yakkety) Status: New => Fix Released ** Changed in: libvirt (Ubuntu Zesty) Assignee: Rafael David

[Bug 1317491] Re: virsh blockcommit hangs at 100%

No, I'm doing the reverse. ** This bug is no longer a duplicate of bug 1455475 Block Commit: [100 %]error: failed to pivot job for disk vda ** Changed in: libvirt (Ubuntu) Assignee: (unassigned) => Rafael David Tinoco (inaddy) ** Tags added: sts -- You received this bug notification

[Bug 1317491] Re: virsh blockcommit hangs at 100%

I have marked this as duplicate of a newer one simply because the new one already includes QEMU upstream "package", I'll just find missing commits in between libvirt 1.1 and 1.3 and inform there, making other versions as Fix Released. ** Changed in: libvirt (Ubuntu) Status: Fix Released =>

[Bug 1317491] Re: virsh blockcommit hangs at 100%

One workaround would be to use the libvirt version in the cloud archive. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1317491 Title: virsh blockcommit hangs at 100% To manage notifications about

[Bug 1317491] Re: virsh blockcommit hangs at 100%

in Ubuntu Trusty 14.04 Server is still present. looking at official libvirt changelog, this problem seems to be resolved in 1.2.5 version that is not present in ubuntu trusty (last version is 1.2.2) Are there any workaround? -- You received this bug notification because you are a member of

[Bug 1317491] Re: virsh blockcommit hangs at 100%

Since this should be fixed by the new libvirt release now in vivid, marking fix-released. ** Changed in: libvirt (Ubuntu) Status: Confirmed = Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1317491] Re: virsh blockcommit hangs at 100%

Since this should be fixed by the new libvirt release now in vivid, marking fix-released. ** Changed in: libvirt (Ubuntu) Status: Confirmed = Fix Released -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to libvirt in Ubuntu.

[Bug 1317491] Re: virsh blockcommit hangs at 100%

I'm hoping we merge hte newest libvirt release next week into 15.04 ** Changed in: libvirt (Ubuntu) Importance: Undecided = Wishlist -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1317491 Title:

[Bug 1317491] Re: virsh blockcommit hangs at 100%

Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: libvirt (Ubuntu) Status: New = Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1317491 Title:

[Bug 1317491] Re: virsh blockcommit hangs at 100%

I can confirm this bug in my 14.04 box. Don't know if this bug has been solved in the upstream version of libvirt -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1317491 Title: virsh blockcommit

[Bug 1317491] Re: virsh blockcommit hangs at 100%

ok, after a small google search I found this blog http://kashyapc.com/2014/10/07/libvirt-blockcommit-shorten-disk-image- chain-by-live-merging-the-current-active-disk-content/ it seems that an upstream version of libvirt will allow libvirt users to commit back to the first file all the change