Re: [PATCH] bug in __check_pf() (getaddrinfo.c)

2008-12-08 Thread Carmelo Amoroso
Khem Raj wrote: > On (08/12/08 10:35), Carmelo Amoroso wrote: >> On 07/12/2008, Ricard Wanderlof <[EMAIL PROTECTED]> wrote: >>> On Sat, 6 Dec 2008, Hiroshi Shinji wrote: >>> Hi Khem, Thanks for your comment. 2008/12/6 Khem Raj <[EMAIL PROTECTED]>: > Getting NULL for ifa_addr

Re: [PATCH] bug in __check_pf() (getaddrinfo.c)

2008-12-08 Thread Khem Raj
On (08/12/08 10:35), Carmelo Amoroso wrote: > On 07/12/2008, Ricard Wanderlof <[EMAIL PROTECTED]> wrote: > > > > On Sat, 6 Dec 2008, Hiroshi Shinji wrote: > > > >> Hi Khem, > >> Thanks for your comment. > >> > >> 2008/12/6 Khem Raj <[EMAIL PROTECTED]>: > >>> Getting NULL for ifa_addr means that the

Re: [PATCH] bug in __check_pf() (getaddrinfo.c)

2008-12-08 Thread Denys Vlasenko
On Friday 05 December 2008 23:52, Khem Raj wrote: > Getting NULL for ifa_addr means that the interface has no address. Do > you know in what cases does this happen. Patch looks ok though. I committed + if (runp->ifa_addr == NULL) + continue; part too, it does

Re: [PATCH] bug in __check_pf() (getaddrinfo.c)

2008-12-08 Thread Carmelo Amoroso
Bernhard Reutner-Fischer wrote: > On Mon, Dec 08, 2008 at 10:35:50AM +0100, Carmelo Amoroso wrote: >> On 07/12/2008, Ricard Wanderlof <[EMAIL PROTECTED]> wrote: >>> On Sat, 6 Dec 2008, Hiroshi Shinji wrote: >>> Hi Khem, Thanks for your comment. 2008/12/6 Khem Raj <[EMAIL PROTECT

Re: [PATCH] bug in __check_pf() (getaddrinfo.c)

2008-12-08 Thread Bernhard Reutner-Fischer
On Mon, Dec 08, 2008 at 10:35:50AM +0100, Carmelo Amoroso wrote: >On 07/12/2008, Ricard Wanderlof <[EMAIL PROTECTED]> wrote: >> >> On Sat, 6 Dec 2008, Hiroshi Shinji wrote: >> >>> Hi Khem, >>> Thanks for your comment. >>> >>> 2008/12/6 Khem Raj <[EMAIL PROTECTED]>: Getting NULL for ifa_addr me

Re: [PATCH] bug in __check_pf() (getaddrinfo.c)

2008-12-08 Thread Carmelo Amoroso
On 07/12/2008, Ricard Wanderlof <[EMAIL PROTECTED]> wrote: > > On Sat, 6 Dec 2008, Hiroshi Shinji wrote: > >> Hi Khem, >> Thanks for your comment. >> >> 2008/12/6 Khem Raj <[EMAIL PROTECTED]>: >>> Getting NULL for ifa_addr means that the interface has no address. Do >>> you know in what cases does

Re: [PATCH] bug in __check_pf() (getaddrinfo.c)

2008-12-07 Thread Ricard Wanderlof
On Sat, 6 Dec 2008, Hiroshi Shinji wrote: Hi Khem, Thanks for your comment. 2008/12/6 Khem Raj <[EMAIL PROTECTED]>: Getting NULL for ifa_addr means that the interface has no address. Do you know in what cases does this happen. Patch looks ok though. True. My environment has a interface that

Re: [PATCH] bug in __check_pf() (getaddrinfo.c)

2008-12-05 Thread Hiroshi Shinji
Hi Khem, Thanks for your comment. 2008/12/6 Khem Raj <[EMAIL PROTECTED]>: > Getting NULL for ifa_addr means that the interface has no address. Do > you know in what cases does this happen. Patch looks ok though. True. My environment has a interface that has no address. And, previous source code

Re: [PATCH] bug in __check_pf() (getaddrinfo.c)

2008-12-05 Thread Khem Raj
Getting NULL for ifa_addr means that the interface has no address. Do you know in what cases does this happen. Patch looks ok though. On Fri, Dec 5, 2008 at 1:16 PM, Hiroshi Shinji <[EMAIL PROTECTED]> wrote: > Hi, > > I built root file system using buildroot, but some > commands (ping(busybox), ss

[PATCH] bug in __check_pf() (getaddrinfo.c)

2008-12-05 Thread Hiroshi Shinji
Hi, I built root file system using buildroot, but some commands (ping(busybox), sshd, ntpdate, etc) occured segmentation fault in getaddrinfo(). So I read uclibc/libc/inet/getaddrinfo.c and found a bug in __check_pf(). (It has no NULL check and so on.) Please review this patch. Regards, -- Hir