Re: [PATCH-0.9.33] common/pread_write.c: unbreak on archs without __NR_pread64

2013-11-21 Thread Peter Korsgaard
Khem == Khem Raj raj.k...@gmail.com writes: Hi, The code nicely checks for it, but then ends up hard coding the syscall to use __NR_pread64 afterwards, rendering the check useless. Fix it by using the result of the test instead. Mike i think you should look at all the pread/pwrite

Re: [PATCH-0.9.33] common/pread_write.c: unbreak on archs without __NR_pread64

2013-10-16 Thread Mike Frysinger
On Tuesday 15 October 2013 16:37:32 Peter Korsgaard wrote: Mike your e-mail client still sucks btw Sorry, in what way? the quoting style unreasonably mangles things -mike signature.asc Description: This is a digitally signed message part. ___

Re: [PATCH-0.9.33] common/pread_write.c: unbreak on archs without __NR_pread64

2013-10-16 Thread Peter Korsgaard
Mike == Mike Frysinger vap...@gentoo.org writes: Hi, On Tuesday 15 October 2013 16:37:32 Peter Korsgaard wrote: Mike your e-mail client still sucks btw Sorry, in what way? the quoting style unreasonably mangles things The supercite 'name' thing? I kind of like it, but I've turned it

Re: [PATCH-0.9.33] common/pread_write.c: unbreak on archs without __NR_pread64

2013-10-15 Thread Peter Korsgaard
Peter == Peter Korsgaard pe...@korsgaard.com writes: Peter Some archs (avr32 in particular) still doesn't define __NR_pread64, so Peter we should fall back to __NR_pread if it isn't available. Peter The code nicely checks for it, but then ends up hard coding the syscall Peter to use

Re: [PATCH-0.9.33] common/pread_write.c: unbreak on archs without __NR_pread64

2013-10-15 Thread Peter Korsgaard
Peter == Peter Korsgaard pe...@korsgaard.com writes: Hi, Peter Some archs (avr32 in particular) still doesn't define __NR_pread64, so Peter we should fall back to __NR_pread if it isn't available. Peter The code nicely checks for it, but then ends up hard coding the syscall Peter to use

Re: [PATCH-0.9.33] common/pread_write.c: unbreak on archs without __NR_pread64

2013-10-15 Thread Mike Frysinger
On Friday 04 October 2013 17:45:20 Peter Korsgaard wrote: Peter == Peter Korsgaard pe...@korsgaard.com writes: Peter Some archs (avr32 in particular) still doesn't define __NR_pread64, so Peter we should fall back to __NR_pread if it isn't available. Peter The code nicely checks for it,

Re: [PATCH-0.9.33] common/pread_write.c: unbreak on archs without __NR_pread64

2013-10-15 Thread Mike Frysinger
On Friday 04 October 2013 15:41:20 Peter Korsgaard wrote: Some archs (avr32 in particular) still doesn't define __NR_pread64, so we should fall back to __NR_pread if it isn't available. The code nicely checks for it, but then ends up hard coding the syscall to use __NR_pread64 afterwards,

Re: [PATCH-0.9.33] common/pread_write.c: unbreak on archs without __NR_pread64

2013-10-15 Thread Peter Korsgaard
Mike == Mike Frysinger vap...@gentoo.org writes: Hi, I noticed another critical issue on ARM EABI. The use of __LONG_LONG_PAIR for the offset doesn't take alignment requirement of 64bit parameters on EABI into consideration, so the offset is off by one register :/

Re: [PATCH-0.9.33] common/pread_write.c: unbreak on archs without __NR_pread64

2013-10-15 Thread Peter Korsgaard
Mike == Mike Frysinger vap...@gentoo.org writes: Hi, The code nicely checks for it, but then ends up hard coding the syscall to use __NR_pread64 afterwards, rendering the check useless. Fix it by using the result of the test instead. Mike i think you should look at all the pread/pwrite

Re: [PATCH-0.9.33] common/pread_write.c: unbreak on archs without __NR_pread64

2013-10-15 Thread Khem Raj
On Oct 15, 2013, at 1:41 PM, Peter Korsgaard pe...@korsgaard.com wrote: Mike == Mike Frysinger vap...@gentoo.org writes: Hi, The code nicely checks for it, but then ends up hard coding the syscall to use __NR_pread64 afterwards, rendering the check useless. Fix it by using the result of

Re: [PATCH-0.9.33] common/pread_write.c: unbreak on archs without __NR_pread64

2013-10-15 Thread Mike Frysinger
On Tuesday 15 October 2013 19:04:12 Khem Raj wrote: On Oct 15, 2013, at 1:41 PM, Peter Korsgaard pe...@korsgaard.com wrote: Mike == Mike Frysinger vap...@gentoo.org writes: Hi, The code nicely checks for it, but then ends up hard coding the syscall to use __NR_pread64 afterwards,

[PATCH-0.9.33] common/pread_write.c: unbreak on archs without __NR_pread64

2013-10-04 Thread Peter Korsgaard
Some archs (avr32 in particular) still doesn't define __NR_pread64, so we should fall back to __NR_pread if it isn't available. The code nicely checks for it, but then ends up hard coding the syscall to use __NR_pread64 afterwards, rendering the check useless. Fix it by using the result of the

Re: [PATCH-0.9.33] common/pread_write.c: unbreak on archs without __NR_pread64

2013-10-04 Thread Peter Korsgaard
Peter == Peter Korsgaard pe...@korsgaard.com writes: Hi, Peter Some archs (avr32 in particular) still doesn't define __NR_pread64, so Peter we should fall back to __NR_pread if it isn't available. Peter The code nicely checks for it, but then ends up hard coding the syscall Peter to use