Re: svn commit: trunk/uClibc/libc/inet

2008-11-03 Thread Denys Vlasenko
On Mon, Nov 3, 2008 at 9:37 AM, Bernhard Reutner-Fischer [EMAIL PROTECTED] wrote: On Sun, Nov 02, 2008 at 11:07:46PM +0100, Denys Vlasenko wrote: On Sunday 02 November 2008 11:59, Bernhard Reutner-Fischer wrote: On Sun, Nov 02, 2008 at 12:42:58AM +0100, Denys Vlasenko wrote: P.S. our resolver

Re: svn commit: trunk/uClibc/libc/inet

2008-11-02 Thread Rob Landley
On Sunday 02 November 2008 16:07:46 Denys Vlasenko wrote: On Sunday 02 November 2008 11:59, Bernhard Reutner-Fischer wrote: On Sun, Nov 02, 2008 at 12:42:58AM +0100, Denys Vlasenko wrote: P.S. our resolver is scary. Locking is busted. I fear handling of IPv6 DNS replies are busted too.

Re: svn commit: trunk/uClibc/libc/inet

2008-11-01 Thread Denys Vlasenko
I applied some simpler fixes for these bugs, but here is the big one which is largish. I can use an additional pair of eyes here. Please review attached patch and apply if it looks ok. I found a buglet myself (wasn't supplying an aughmented name with search domain appended). Fixed in

Re: svn commit: trunk/uClibc/libc/inet

2008-06-07 Thread Denys Vlasenko
On Friday 06 June 2008 15:43, Bernhard Fischer wrote: On Fri, Jun 06, 2008 at 03:25:30PM +0200, Denys Vlasenko wrote: You mean ifenslave applet in busybox? /me nods vda Shrank it a bit. ___ uClibc mailing list uClibc@uclibc.org

Re: svn commit: trunk/uClibc/libc/inet

2008-06-06 Thread Bernd Schmidt
[EMAIL PROTECTED] wrote: Author: vda Date: 2008-06-06 00:25:12 -0700 (Fri, 06 Jun 2008) New Revision: 22244 Log: Use more natural way to return a value in __read_etc_hosts_r: - if (buflen sizeof(char *)*(ALIAS_DIM)) + if (buflen sizeof(char *)*ALIAS_DIM) return

Re: svn commit: trunk/uClibc/libc/inet

2008-06-06 Thread Carmelo AMOROSO
Bernd Schmidt wrote: [EMAIL PROTECTED] wrote: Author: vda Date: 2008-06-06 00:25:12 -0700 (Fri, 06 Jun 2008) New Revision: 22244 Log: Use more natural way to return a value in __read_etc_hosts_r: -if (buflen sizeof(char *)*(ALIAS_DIM)) +if (buflen sizeof(char

Re: svn commit: trunk/uClibc/libc/inet

2008-06-06 Thread Bernhard Fischer
On Fri, Jun 06, 2008 at 12:49:33PM +0200, Carmelo AMOROSO wrote: Bernd Schmidt wrote: [EMAIL PROTECTED] wrote: Author: vda Date: 2008-06-06 00:25:12 -0700 (Fri, 06 Jun 2008) New Revision: 22244 Log: Use more natural way to return a value in __read_etc_hosts_r: hah. vda bashing!

Re: svn commit: trunk/uClibc/libc/inet

2008-06-06 Thread Denys Vlasenko
On Friday 06 June 2008 15:02, Bernhard Fischer wrote: On Fri, Jun 06, 2008 at 12:49:33PM +0200, Carmelo AMOROSO wrote: Bernd Schmidt wrote: [EMAIL PROTECTED] wrote: Author: vda Date: 2008-06-06 00:25:12 -0700 (Fri, 06 Jun 2008) New Revision: 22244 Log: Use more natural way to

Re: svn commit: trunk/uClibc/libc/inet

2008-06-06 Thread Bernd Schmidt
[EMAIL PROTECTED] wrote: Remove superfluous attribute_hidden from function definition. I seems to produce spurious warning: libc/inet/resolv.c:1549: warning: 'visibility' attribute ignored on non-class types (seems like gcc bug) -FILE * attribute_hidden __open_etc_hosts(void) +FILE *

Re: svn commit: trunk/uClibc/libc/inet

2008-06-06 Thread Bernd Schmidt
Bernhard Fischer wrote: PS: You know that i usually do not blindly rewrite stuff, but the resolver code is really an ugly and bloated mess (and doesn't even work for IPv6-only), but this time i think it would be saner to write this thing from scratch and not try to beat it into shape. Surely

Re: svn commit: trunk/uClibc/libc/inet

2008-06-06 Thread Denys Vlasenko
On Friday 06 June 2008 15:31, Bernd Schmidt wrote: [EMAIL PROTECTED] wrote: Remove superfluous attribute_hidden from function definition. I seems to produce spurious warning: libc/inet/resolv.c:1549: warning: 'visibility' attribute ignored on non-class types (seems like gcc bug)

Re: svn commit: trunk/uClibc/libc/inet

2008-06-06 Thread Daniel Jacobowitz
On Fri, Jun 06, 2008 at 04:27:25PM +0200, Denys Vlasenko wrote: Possibly. I tried FILE * __open_etc_hosts(void) attribute_hidden { ... - that didn't work at all. So I decided to just take advantage of the fact that we already have extern decl with attribute_hidden at the beginning of this

Re: svn commit: trunk/uClibc/libc/inet

2008-06-06 Thread Bernd Schmidt
Bernhard Fischer wrote: Author: vda Date: 2008-06-06 00:25:12 -0700 (Fri, 06 Jun 2008) New Revision: 22244 Log: Use more natural way to return a value in __read_etc_hosts_r: hah. vda bashing! ;) No, serious: The proper term is patch review. I've gone through the last 200 checkins